Re: Review Request 130057: Bug 288042 - Option to reset forms

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/#review103403
---



How does this play with undo/redo?

I haven't tried but i think this would feel weird (please try):

* Open a file with two fields
* Go to field 1 and write "hola"
* Go to field 2 and write "adios"
* Go to field 1 and delete everything
* Now press "Clear forms"
* Now press "undo", what happens? if my guess is right, field 1 will go to 
"hola" and field 2 will stay empty, which is exactly the opposite of what you 
had when pressing "Clear forms"


part.rc (line 2)


You need to increase the verison if you add new stuff.


- Albert Astals Cid


On mar. 30, 2017, 7 p.m., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130057/
> ---
> 
> (Updated mar. 30, 2017, 7 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 288042
> http://bugs.kde.org/show_bug.cgi?id=288042
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks 
> CheckBoxEdit and ListEdit form elements. 
> 
> I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which 
> state I should reset/clear them. Especially for ComboBox, I am not sure if 
> clearing them could be harmful.
> 
> 
> Diffs
> -
> 
>   part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074 
>   ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c 
>   ui/formwidgets.cpp 6ab49b0ed9fa3ba71486cf45e89e46c7b0f61d3f 
>   ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65 
>   ui/pageview.cpp 88ffe62418f3b68ca8c2314c54f13226d2ed6191 
>   ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 
>   ui/pageviewutils.cpp a57712ca235b2ca629f5739ad73488d513416d0c 
> 
> Diff: https://git.reviewboard.kde.org/r/130057/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

Re: Review Request 130043: Remove method FilePrinter::psPaperSize

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130043/#review103402
---


Ship it!




Ship It!

- Albert Astals Cid


On mar. 23, 2017, 5:33 a.m., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130043/
> ---
> 
> (Updated mar. 23, 2017, 5:33 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> I was about to simplify the method FilePrinter::psPaperSize in the file 
> fileprinter.cpp.  As it turned out, this method is never called anywhere 
> anyway.  So this patch removes it.
> 
> 
> Diffs
> -
> 
>   core/fileprinter.cpp a27529e7 
> 
> Diff: https://git.reviewboard.kde.org/r/130043/diff/
> 
> 
> Testing
> ---
> 
> Grepping for the method name doesn't return anything.
> 
> Code still builds without the method.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

Re: Review Request 130055: Do not convert to ps for printing---at least sometimes

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130055/#review103401
---



> KDE 4.1 is long gone.  What is fileprinter supposed to be replaced with?

Some code in Qt that was never made public

> What direction should I take to obtain something mergeable?

Get people that actually use Okular to print with different printers to test 
it. Or otherwise just say "fuck it" and merge it and fix all the things that 
break afterwards :D



Have you tested printing to different sizes? What about margins?

- Albert Astals Cid


On abr. 4, 2017, 1:44 p.m., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130055/
> ---
> 
> (Updated abr. 4, 2017, 1:44 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This patch is an improved version of what is in the pdfprintpdf branch.  
> (There is really only a single patch in that branch.)
> 
> The patch tries to avoid converting pdf files to ps files for printing as 
> much as possible.  In particular:
> 
> - If we are printing a file, and printing of annotations is not requested, 
> then the pdf file is sent straight to the printer.
> - If rasterization is requested, then the short previously-windows-only 
> printing code is used, because it does exactly that: printing by 
> rasterization.
> - In all other cases, the file is converted to ps as before.
> - The big #ifdef Q_OS_WIN ... #else ... #endif is removed.  All code is 
> compiled on all platforms, but on Windows forceRasterize is always set. 
> Therefore, the behavior on Windows remains unchanged.
> 
> There are a few behavioral changes that I know of:
> - The resolution of the rasterization most likely changes.  Don't know 
> whether this is a problem.
> - Previously, when printing without printAnnots to a file, the result file 
> did not have the annotations anymore.  With the new code, the annotations are 
> still there, but they are still actual annotations, unlike what you get when 
> using the old code to print annotations.  I am not sure whether to call this 
> a regression or a feature.
> 
> I am motivated to improve this patch some more, but I need some guidance.  
> What direction should I take to obtain something mergeable?
> 
> Also: in the file fileprinter.h it says:
> 
> // This Class is a temporary addition to Okular for the duration of KDE 4.0.
> // In KDE 4.1 this class will either be moved to kdelibs if still required,
> // or replaced  with a Qt 4.4 based solution.
> 
> KDE 4.1 is long gone.  What is fileprinter supposed to be replaced with?
> 
> 
> Diffs
> -
> 
>   generators/poppler/generator_pdf.h a078f50b 
>   generators/poppler/generator_pdf.cpp 42ccb3a2 
>   part.cpp df38e85e 
> 
> Diff: https://git.reviewboard.kde.org/r/130055/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

D6268: HiDPI Support for Okular

[Albert Astals Cid]

aacid added a comment.


  I would very much prefer if you didn't break the ABI of the files in core/
  
  Also not sure why you need to pass the devicepixel ratio up and down, isn't 
it the same basically in all the app?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D6268

To: hetzenecker, davidedmundson, aacid
Cc: sander, anthonyfieroni, #okular, aacid

D6185: Okular empty "Tools" context menu

[Emirald Mateli]

emateli abandoned this revision.
emateli added a comment.


  Resolved by author

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D6185

To: emateli, #okular, aacid
Cc: aacid

D6185: Okular empty "Tools" context menu

[Albert Astals Cid]

aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.


  Please close this, i fixed it correctly in 
https://cgit.kde.org/okular.git/commit/?h=Applications/17.04=3b5f19fd9d67b49a7009b5810c5dd4ecb1a7cede

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D6185

To: emateli, #okular, aacid
Cc: aacid

Re: How to write plugin for Okular to export selected text to Emacs/Org-mode?

[Albert Astals Cid]

El dissabte, 1 de juliol de 2017, a les 12:36:16 CEST, numbch...@gmail.com va 
escriure:
> [stardiviner] GPG key ID: 47C32433
> IRC(freeenode): stardiviner Twitter:  @numbchild
> Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
> Blog: http://stardiviner.github.io/

The only plugins Okular supports are backend renderers.

Cheers,
  Albert

[okular] [Bug 185636] More printing options for page control

[Jaak Ristioja]

https://bugs.kde.org/show_bug.cgi?id=185636

--- Comment #8 from Jaak Ristioja  ---
(In reply to Manuel López-Ibáñez from comment #7)
> It seems there is some way to enable a page ranges interface: 
> https://bugs.kde.org/show_bug.cgi?id=208736#c6 but it is not enabled by
> default.

Nothing in that bug report seems to indicate that one can work around this as a
user.

-- 
You are receiving this mail because:
You are the assignee for the bug.