[okular] [Bug 385468] "Missing \"Version=5\", file '/usr/share/kconf_update/okular.upd' will be skipped."

2017-10-27 Thread Simon Andric 
https://bugs.kde.org/show_bug.cgi?id=385468

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382860] Okular does not execute any basic PDF form action

2017-10-27 Thread Simon Andric 
https://bugs.kde.org/show_bug.cgi?id=382860

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8379: PDF: Support the new poppler renderToImage with update callback

2017-10-27 Thread Henrik Fehlauer 
rkflx added a comment.


  The latest version is much better and I could not reproduce my issues from 
above anymore. Still some oddities (tested using `dublin-center-street.pdf`):
  
  - With Fit Page, first the main view renders and after finishing the 
thumbnail should be the only thing left to render. However, the thumbnail takes 
a much longer time to show an initial frame with the CPU being busy throughout 
doing something else (after this, the incremental rendering seems to need about 
the same time as the main view). It is likely this has been there all the time 
and the patch just makes this phenomenon more visible, nevertheless may be a 
candidate for huge CPU time savings in a later patch (freeing resources for 
subsequent pages).
  - When zooming, the initial timeout to start showing the incremental 
rendering seems much longer than 500ms and also much longer compared to when 
reloading the document at the same zoom level afterwards. Okular seems busy 
doing something else. Maybe the rendering of intermediate zoom levels is not 
cancelled correctly? This is also seen when closing Okular with rendering still 
in progress, where the shell prompt returns only much later while the window 
closes immediately.
  - In some situations, incremental rendering happens twice in a row, i.e. the 
first pass is thrown away when finished and a second pass starts. (Occurs now 
and then, unfortunately I cannot give you instructions on how to reproduce yet. 
Try moving around with the scroll wheel when zoomed in.)
  - Segfaults on entering Presentation mode (works fine without the patch to 
Okular but still with the newer Poppler).
  - Extensive flickering of some screen areas (switching between white and 
content rapidly for several seconds) when redrawing after panning a rotated 
page in some cases, even a segfault occasionally.
  
  Not sure whether all of this should even be fixed in this patch, but I would 
appreciate a short comment from you regarding those points.
  
  > I don't see a need to limit it really (other than the initial 500ms barrier)
  
  Just to put some numbers behind this: A quick measurement with a stopwatch 
and an artificially slowed down CPU consistently gives me total rendering times 
of ~7.5s vs. ~9.0s, i.e. the patch is ~15% slower.
  
  > lots of pages take more than 30ms and you don't really want to see them 
rendering just twice
  
  I tried to get a feeling for the difference between updating immediately 
(which I presume would be more pleasant) and updating after a delay of much 
more than the typical 30ms human perception normally does not notice (which you 
claim to be preferable). However, there are so many timeouts/delays and 
intermediate images like the scaled up thumbnails happening, that to even 
compare both approaches a substantial code rework would be needed. Let's just 
keep it as proposed, then.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8379

To: aacid, #okular, mlaurent
Cc: rkflx, ngraham, michaelweghorn, mlaurent, #okular, aacid

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

2017-10-27 Thread Lex Dem 
lexdem added a comment.


  In https://phabricator.kde.org/D8385#160109, @rkflx wrote:
  
  > > So, if there are a lot of products with new features, they're bundled to 
some new version? Like from 16.12 to 17.04 . Is this also controlled by any 
kind of CI, to bundle them? Sorry, if I ask too much, I'm just curious about 
the whole process :)
  >
  > You can look at the Annoucements  to 
get a sense for what products KDE ships, what software those include and which 
changes are made. Note that these are time-based releases according to the 
Schedules , while other applications e.g. 
in Extragear have other release cycles, sometimes even feature-based like you 
were describing. See also here 
.
  >
  > As for release automation, I believe right now this is a manual process 
with the help of some scripts (not sure how accurate, but this 
, 
https://phabricator.kde.org/source/sysadmin-release-tools/ and 
https://phabricator.kde.org/source/releaseme/ may give you some idea) and 
depending on product is done by the release team 
 or the individual maintainers.
  >
  > That said, you can also visit KDE's IRC channels 
 to get questions answered in a more 
interactive fashion.
  
  
  Thanks a lot for pointing me to the right direction :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8385

To: lexdem, #okular, rkflx, ngraham
Cc: ltoscano, aacid, rkflx, ngraham

KDE CI: Applications okular kf5-qt5 FedoraQt5.8 - Build # 88 - Still unstable!

2017-10-27 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FedoraQt5.8/88/
 Project:
Applications okular kf5-qt5 FedoraQt5.8
 Date of build:
Fri, 27 Oct 2017 13:53:44 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.mainshelltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report88%
(21/24)46%
(124/268)46%
(124/268)29%
(10896/38010)19%
(4944/26254)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault80%
(4/5)80%
(4/5)48%
(808/1679)29%
(371/1267)autotests93%
(13/14)93%
(13/14)83%
(1631/1976)38%
(944/2477)conf6%
(1/17)6%
(1/17)7%
(53/805)0%
(1/272)conf.autotests100%
(1/1)100%
(1/1)100%
(17/17)50%
(7/14)core83%
(40/48)83%
(40/48)46%
(4177/9133)34%
(2017/6015)core.script0%
(0/9)0%
(0/9)0%
(0/494)0%
(0/230)generators.comicbook29%
(2/7)29%
(2/7)3%
(10/397)0%
(0/430)generators.dvi2%
(1/46)2%
(1/46)0%
(9/3571)0%
(1/2423)generators.fax17%
(1/6)17%
(1/6)2%
(7/432)0%
(0/585)generators.fictionbook60%
(3/5)60%
(3/5)3%
(16/531)0%
(2/454)generators.kimgio100%
(1/1)100%
(1/1)63%
(41/65)31%
(5/16)generators.kimgio.tests100%
(1/1)100%
(1/1)100%
(49/49)46%
(24/52)generators.mobipocket60%
(3/5)60%
(3/5)11%
(13/115)0%
(0/120)generators.ooo27%
(3/11)27%
(3/11)1%
(14/1125)0%
(0/736)generators.plucker100%
(1/1)100%
(1/1)4%
(4/98)0%
(0/36)generators.plucker.unpluck0%
(0/6)0%
(0/6)0%
(0/1652)0%
(0/876)generators.poppler60%
(3/5)60%
(3/5)44%
(575/1311)35%
(247/697)generators.tiff100%
(1/1)100%
(1/1)4%
(10/226)0%

KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 44 - Still Failing!

2017-10-27 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/44/
 Project:
Applications okular kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Fri, 27 Oct 2017 13:53:44 +
 Build duration:
9 min 55 sec and counting
   CONSOLE OUTPUT
  [...truncated 295.99 KB...][ 36%] Building CXX object CMakeFiles/okularpart.dir/ui/embeddedfilesdialog.cpp.objeditannottooldialog.cppeditdrawingtooldialog.cppwidgetannottools.cppwidgetconfigurationtoolsbase.cppwidgetdrawingtools.cppextensions.cppembeddedfilesdialog.cpp[ 36%] Building CXX object CMakeFiles/okularpart.dir/ui/annotwindow.cpp.objannotwindow.cpp[ 37%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationmodel.cpp.objannotationmodel.cpp[ 37%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationpopup.cpp.objannotationpopup.cpp[ 37%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationpropertiesdialog.cpp.objannotationpropertiesdialog.cpp[ 38%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationproxymodels.cpp.objannotationproxymodels.cpp[ 38%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationtools.cpp.objannotationtools.cpp[ 38%] Building CXX object CMakeFiles/okularpart.dir/ui/annotationwidgets.cpp.objannotationwidgets.cpp[ 39%] Building CXX object CMakeFiles/okularpart.dir/ui/bookmarklist.cpp.objbookmarklist.cpp[ 39%] Building CXX object CMakeFiles/okularpart.dir/ui/debug_ui.cpp.objdebug_ui.cpp[ 40%] Building CXX object CMakeFiles/okularpart.dir/ui/fileprinterpreview.cpp.objfileprinterpreview.cpp[ 40%] Building CXX object CMakeFiles/okularpart.dir/ui/formwidgets.cpp.objformwidgets.cpp[ 41%] Building CXX object CMakeFiles/okularpart.dir/ui/guiutils.cpp.objguiutils.cpp[ 41%] Building CXX object CMakeFiles/okularpart.dir/ui/ktreeviewsearchline.cpp.objktreeviewsearchline.cpp[ 41%] Building CXX object CMakeFiles/okularpart.dir/ui/latexrenderer.cpp.objlatexrenderer.cpp[ 42%] Building CXX object CMakeFiles/okularpart.dir/ui/minibar.cpp.objminibar.cpp[ 42%] Building CXX object CMakeFiles/okularpart.dir/ui/okmenutitle.cpp.objokmenutitle.cpp[ 43%] Building CXX object CMakeFiles/okularpart.dir/ui/pagesizelabel.cpp.objpagesizelabel.cpp[ 43%] Building CXX object CMakeFiles/okularpart.dir/ui/pageviewmouseannotation.cpp.objpageviewmouseannotation.cpp[ 43%] Building CXX object CMakeFiles/okularpart.dir/ui/magnifierview.cpp.objmagnifierview.cpp[ 44%] Building CXX object CMakeFiles/okularpart.dir/ui/presentationsearchbar.cpp.objpresentationsearchbar.cpp[ 44%] Building CXX object CMakeFiles/okularpart.dir/ui/propertiesdialog.cpp.objpropertiesdialog.cpp[ 45%] Building CXX object CMakeFiles/okularpart.dir/ui/searchlineedit.cpp.objsearchlineedit.cpp[ 45%] Building CXX object CMakeFiles/okularpart.dir/ui/searchwidget.cpp.objsearchwidget.cpp[ 45%] Building CXX object CMakeFiles/okularpart.dir/ui/snapshottaker.cpp.objsnapshottaker.cpp[ 45%] Building CXX object CMakeFiles/okularpart.dir/ui/tocmodel.cpp.objtocmodel.cpp[ 45%] Building CXX object CMakeFiles/okularpart.dir/ui/toolaction.cpp.objtoolaction.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/videowidget.cpp.objvideowidget.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/tts.cpp.objtts.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/conf/preferencesdialog.cpp.objpreferencesdialog.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/part.cpp.objpart.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/drawingtoolactions.cpp.objdrawingtoolactions.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/findbar.cpp.objfindbar.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/pageitemdelegate.cpp.objpageitemdelegate.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/pagepainter.cpp.objpagepainter.cpp[ 46%] Building CXX object CMakeFiles/okularpart.dir/ui/pageviewannotator.cpp.objpageviewannotator.cpp[ 47%] Building CXX object CMakeFiles/okularpart.dir/ui/pageview.cpp.objC:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9\ui\drawingtoolactions.cpp(50): warning C4566: character represented by universal-character-name '\u2713' cannot be represented in the current code page (1252)C:\CI\WORKSP~1\APPLIC~2.9\INSTAL~1\include\KF5\PURPOS~1\purposewidgets/menu.h(21): fatal error C1083: Cannot open include file: 'purposewidgets_export.h': No such file or directoryjom: C:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9\build\CMakeFiles\okularpart.dir\build.make [CMakeFiles\okularpart.dir\part.cpp.obj] Error 2pageview.cppC:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9\ui\pageview.cpp(99): warning C4838: conversion from 'double' to 'const float' requires a narrowing conversionC:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9\ui\pageview.cpp(99): warning C4305: 'initializing': truncation from 'double' to 'const float'C:\CI\workspace\Applications okular kf5-qt5 WindowsMSVCQt5.9\ui\pageview.cpp(3937): warning C4305: '=': truncation from

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.7 - Build # 94 - Fixed!

2017-10-27 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.7/94/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.7
 Date of build:
Fri, 27 Oct 2017 13:53:44 +
 Build duration:
7 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s)

D8415: Soften correctness of image file open check

2017-10-27 Thread Alexander Trufanov 
trufanov added a comment.


  In https://phabricator.kde.org/D8415#159049, @aacid wrote:
  
  > Please consider fixing this in Qt before asking us to create a workaround.
  
  
  I'm fine with workarounded gwenview as well as working GIMP and ImageMagick.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8415

To: trufanov, ngraham, #okular
Cc: aacid, progwolff