D8642: Rework saving of annotations and form data

2017-11-07 Thread Michael Weghorn 
michaelweghorn added a comment.


  > Open pdf file, add anotation, close app
  >  You get dialog about losing changes, check that save, discard, cancel all 
do what they say
  
  This works as described. One additional thought on that:
  Some users may want to save the modified version to a new file instead of 
overwriting the existing one. While this is already possible via "File" -> 
"Save As" (or Ctrl+Shift+S), I think it might be helpful to add an additional 
button "Save as" in that dialog as well. This would also help avoid users 
accidently overwriting the original file. (Evince, for example only offers a 
"Save As" option and users switching between the two programs might not be 
aware of the difference at once.)
  Alternatively (or in addition to that), clarifying the question in the dialog 
to something like "Do you want to save your changes TO THE DOCUMENT  
or discard them?" (capital letters only here to indicate what has been added) 
might possibly be an option as well.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8642

To: aacid, mlaurent
Cc: lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid

D8704: Don't use exec() to open dialogs

2017-11-07 Thread Elvis Angelaccio 
elvisangelaccio added a subscriber: okular-devel.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8704

To: elvisangelaccio, #okular
Cc: okular-devel, aacid

D8704: Don't use exec() to open dialogs

2017-11-07 Thread Elvis Angelaccio 
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Okular.
Restricted Application added a project: Okular.

REVISION SUMMARY
  exec() is blocking and should not be used if possible.
  
  Currently it makes impossible to interact with a 2nd okular window
  if the first window has the Properties or Embedded Files dialog open.
  
  It also causes a double delete crash when closing okular via dbus
  while either of those dialogs is open.
  
  We can use open() instead which does not block the event loop and fixes
  both the problems.

TEST PLAN
  1. Open the Properties or Embedded Files dialog, then close okular via dbus.
  2. Open two okular windows, then open the Properties or Embedded Files dialog 
in one of them and try to use the other window.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8704

AFFECTED FILES
  part.cpp

To: elvisangelaccio, #okular
Cc: aacid

D8415: Soften correctness of image file open check

2017-11-07 Thread Nathaniel Graham 
ngraham added a comment.


  Could we add the local workaround here, and include a FIXME comment urging an 
upstream fix later? Gwenview already has this workaround...

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8415

To: trufanov, ngraham, #okular
Cc: aacid, progwolff

[okular] [Bug 385384] Some PNG files produced by acdsee can't be displayed

2017-11-07 Thread Alexander Trufanov 
https://bugs.kde.org/show_bug.cgi?id=385384

--- Comment #2 from Alexander Trufanov  ---
The workaround is proposed on https://phabricator.kde.org/D8415

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 385384] Some PNG files produced by acdsee can't be displayed

2017-11-07 Thread Simon Andric 
https://bugs.kde.org/show_bug.cgi?id=385384

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Julian Wolff 
progwolff added inline comments.

INLINE COMMENTS

> part.cpp:1400
>  {
> -mimes << pathMime << argMime;
> +mimes << argMime << pathMime;
>  }

I changed the order here.
Now mime types defined by OpenUrlArguments are prefered. This allows opening 
files with wrong endings by forcing the right mime type.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8690

To: progwolff, aacid
Cc: #okular, aacid

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Julian Wolff 
progwolff added a comment.


  Right, this might be worth a test too.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8690

To: progwolff, aacid
Cc: #okular, aacid

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Albert Astals Cid 
aacid added a comment.


  Not sure that's the test we really want, i mean what we really want to check 
is that the proper backend was opened, no?
  
  I mean maybe what makes sense is to set the mimetype to txt and then giving 
it a pdf file and checking that the txt backend was used instead of the pdf one?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8690

To: progwolff, aacid
Cc: #okular, aacid

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Julian Wolff 
progwolff updated this revision to Diff 22028.
progwolff added a comment.


  - add autotest

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8690?vs=22020=22028

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D8690

AFFECTED FILES
  autotests/parttest.cpp
  part.cpp

To: progwolff, aacid
Cc: #okular, aacid

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Julian Wolff 
progwolff edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8690

To: progwolff, aacid
Cc: #okular, aacid

D8690: Fix use of OpenUrlArguments

2017-11-07 Thread Julian Wolff 
progwolff created this revision.
progwolff added a reviewer: aacid.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.

REVISION SUMMARY
  BUG: 386600
  
  Applications using Okular as a KPart might set a file's mime type in the 
OpenUrlArguments.
  Okular currently clears this arguments while opening a document. This 
revision fixes this, allowing 
  applications to actually pass a file's mime type to Okular.

TEST PLAN
  Opened documents with mime type "text/markdown" and "application/rtf" in 
kate, using the new
  preview plugin. The embedded Okular KPart displays these files correctly.

REPOSITORY
  R223 Okular

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D8690

AFFECTED FILES
  part.cpp

To: progwolff, aacid
Cc: #okular, aacid

[okular] [Bug 386600] Okularpart renders markdown as regular text

2017-11-07 Thread Julian Wolff 
https://bugs.kde.org/show_bug.cgi?id=386600

Julian Wolff  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #4 from Julian Wolff  ---
Thanks for clarifying.

I will look into this then.

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Applications okular kf5-qt5 FedoraQt5.8 - Build # 96 - Still Unstable!

2017-11-07 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FedoraQt5.8/96/
 Project:
Applications okular kf5-qt5 FedoraQt5.8
 Date of build:
Tue, 07 Nov 2017 10:03:08 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.mainshelltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report88%
(21/24)46%
(124/268)46%
(124/268)29%
(10913/38014)19%
(4971/26262)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault80%
(4/5)80%
(4/5)48%
(808/1679)29%
(371/1267)autotests93%
(13/14)93%
(13/14)83%
(1631/1976)39%
(957/2477)conf6%
(1/17)6%
(1/17)7%
(53/805)0%
(1/272)conf.autotests100%
(1/1)100%
(1/1)100%
(17/17)50%
(7/14)core83%
(40/48)83%
(40/48)46%
(4181/9134)34%
(2023/6017)core.script0%
(0/9)0%
(0/9)0%
(0/494)0%
(0/230)generators.comicbook29%
(2/7)29%
(2/7)3%
(10/397)0%
(0/430)generators.dvi2%
(1/46)2%
(1/46)0%
(9/3571)0%
(1/2423)generators.fax17%
(1/6)17%
(1/6)2%
(7/432)0%
(0/585)generators.fictionbook60%
(3/5)60%
(3/5)3%
(16/531)0%
(2/454)generators.kimgio100%
(1/1)100%
(1/1)63%
(41/65)31%
(5/16)generators.kimgio.tests100%
(1/1)100%
(1/1)100%
(49/49)46%
(24/52)generators.mobipocket60%
(3/5)60%
(3/5)11%
(13/115)0%
(0/120)generators.ooo27%
(3/11)27%
(3/11)1%
(14/1125)0%
(0/736)generators.plucker100%
(1/1)100%
(1/1)4%
(4/98)0%
(0/36)generators.plucker.unpluck0%
(0/6)0%
(0/6)0%
(0/1652)0%
(0/876)generators.poppler60%
(3/5)60%
(3/5)44%
(575/1311)35%
(247/697)generators.tiff100%
(1/1)100%
(1/1)4%
(10/226)0%

[okular] [Bug 386600] Okularpart renders markdown as regular text

2017-11-07 Thread Friedrich W . H . Kossebau 
https://bugs.kde.org/show_bug.cgi?id=386600

--- Comment #3 from Friedrich W. H. Kossebau  ---
I do not have Okular from master branch, so cannot test this myself for
Markdown documents.

But the KParts plugin used should know about the mimetype, it is passed both
when loading via a file and when loading via a stream. 
Cmp. KPartView::updatePreview():
https://cgit.kde.org/kate.git/tree/addons/preview/kpartview.cpp#n161
(merged now into the kate repo)

So by theory (and experience with other KParts plugins) the Okular KParts
plugin "should" know about the mimetype, so without knowing more I suspect some
issues on the Okular side :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8677: Update okular docbook

2017-11-07 Thread Burkhard Lück 
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:01ce40b955f9: Update okular docbook (authored by lueck).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8677?vs=21953=22017#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8677?vs=21953=22017

REVISION DETAIL
  https://phabricator.kde.org/D8677

AFFECTED FILES
  doc/bookmarks.png
  doc/index.docbook
  doc/rating.png

To: lueck, #documentation, #okular, yurchor
Cc: aacid

[okular] [Bug 386600] Okularpart renders markdown as regular text

2017-11-07 Thread Julian Wolff 
https://bugs.kde.org/show_bug.cgi?id=386600

Julian Wolff  changed:

   What|Removed |Added

 CC||kosse...@kde.org

--- Comment #2 from Julian Wolff  ---
Friedrich, can you confirm this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 386600] Okularpart renders markdown as regular text

2017-11-07 Thread Julian Wolff 
https://bugs.kde.org/show_bug.cgi?id=386600

Julian Wolff  changed:

   What|Removed |Added

 CC||wo...@julianwolff.de

--- Comment #1 from Julian Wolff  ---
This is not a problem in Okular, but in the (experimental)
KTextEditorPreviewPlugin.

Due to the way this plugin forwards the file to Okular, Okular can't know the
mime type of the file, thus falls back to plain text.

See https://phabricator.kde.org/D7455#138854

-- 
You are receiving this mail because:
You are the assignee for the bug.