KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 86 - Still Unstable!

2018-04-25 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/86/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 26 Apr 2018 01:31:54 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 112 - Failure!

2018-04-25 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/112/
 Project:
Applications okular kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 26 Apr 2018 01:31:54 +
 Build duration:
2 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 248.77 KB...][ 32%] Automatic MOC for target visibilitytestScanning dependencies of target calculatetexttest_autogenScanning dependencies of target generatorstest_autogen[ 32%] Built target addremoveannotationtest_autogen[ 32%] Automatic MOC for target modifyannotationpropertiestest[ 32%] Automatic MOC for target calculatetexttest[ 32%] Automatic MOC for target generatorstest[ 32%] Generating settings.h, settings.cpp[ 32%] Built target editformstest_autogen[ 32%] Built target searchtest_autogen[ 33%] Generating pdfsettings.h, pdfsettings.cpp[ 33%] Generating ui_pdfsettingswidget.h[ 33%] Built target modifyannotationpropertiestest_autogen[ 33%] Built target translateannotationtest_autogen[ 33%] Built target visibilitytest_autogen[ 33%] Built target generatorstest_autogen[ 33%] Built target calculatetexttest_autogenScanning dependencies of target okularGenerator_kimgioScanning dependencies of target okularGenerator_tiffScanning dependencies of target okularplugin[ 34%] Building CXX object generators/kimgio/CMakeFiles/okularGenerator_kimgio.dir/generator_kimgio.cpp.oScanning dependencies of target okularGenerator_xps[ 34%] Building CXX object generators/tiff/CMakeFiles/okularGenerator_tiff.dir/generator_tiff.cpp.o[ 34%] Building CXX object mobile/components/CMakeFiles/okularplugin.dir/okularplugin.cpp.oScanning dependencies of target okularGenerator_popplerScanning dependencies of target okularGenerator_fb[ 34%] Building CXX object generators/xps/CMakeFiles/okularGenerator_xps.dir/generator_xps.cpp.o[ 34%] Building CXX object generators/poppler/CMakeFiles/okularGenerator_poppler.dir/generator_pdf.cpp.o[ 34%] Building CXX object generators/fictionbook/CMakeFiles/okularGenerator_fb.dir/converter.cpp.oScanning dependencies of target okularGenerator_ooo[ 35%] Building CXX object generators/ooo/CMakeFiles/okularGenerator_ooo.dir/converter.cpp.oScanning dependencies of target okularGenerator_dvi[ 35%] Building CXX object generators/dvi/CMakeFiles/okularGenerator_dvi.dir/generator_dvi.cpp.o/home/jenkins/workspace/Applications okular kf5-qt5 SUSEQt5.9/generators/poppler/generator_pdf.cpp: In function 'Okular::Action* createLinkFromPopplerLink(const Poppler::Link*)':/home/jenkins/workspace/Applications okular kf5-qt5 SUSEQt5.9/generators/poppler/generator_pdf.cpp:332:11: warning: enumeration value 'OCGState' not handled in switch [-Wswitch] switch(popplerLink->linkType())   ^[ 35%] Built target okularpart_autogen[ 35%] Building CXX object generators/poppler/CMakeFiles/okularGenerator_poppler.dir/formfields.cpp.o[ 35%] Building CXX object generators/ooo/CMakeFiles/okularGenerator_ooo.dir/document.cpp.o[ 35%] Building CXX object generators/tiff/CMakeFiles/okularGenerator_tiff.dir/okularGenerator_tiff_autogen/mocs_compilation.cpp.o[ 35%] Building CXX object generators/poppler/CMakeFiles/okularGenerator_poppler.dir/annots.cpp.o[ 35%] Building CXX object generators/dvi/CMakeFiles/okularGenerator_dvi.dir/bigEndianByteReader.cpp.o[ 35%] Building CXX object generators/fictionbook/CMakeFiles/okularGenerator_fb.dir/document.cpp.o[ 35%] Building CXX object generators/xps/CMakeFiles/okularGenerator_xps.dir/okularGenerator_xps_autogen/mocs_compilation.cpp.o[ 36%] Building CXX object mobile/components/CMakeFiles/okularplugin.dir/__/__/ui/guiutils.cpp.o[ 36%] Building CXX object generators/ooo/CMakeFiles/okularGenerator_ooo.dir/formatproperty.cpp.o[ 37%] Building CXX object generators/fictionbook/CMakeFiles/okularGenerator_fb.dir/generator_fb.cpp.o[ 37%] Building CXX object generators/kimgio/CMakeFiles/okularGenerator_kimgio.dir/okularGenerator_kimgio_autogen/mocs_compilation.cpp.o[ 38%] Building CXX object generators/dvi/CMakeFiles/okularGenerator_dvi.dir/dviRenderer.cpp.o[ 39%] Building CXX object generators/poppler/CMakeFiles/okularGenerator_poppler.dir/pdfsettings.cpp.o[ 39%] Linking CXX shared module okularGenerator_xps.so[ 39%] Building CXX object mobile/components/CMakeFiles/okularplugin.dir/__/__/ui/tocmodel.cpp.o[ 39%] Built target okularGenerator_xps[ 39%] Building CXX object generators/poppler/CMakeFiles/okularGenerator_poppler.dir/okularGenerator_poppler_autogen/mocs_compilation.cpp.o[ 40%] Building CXX object generators/ooo/CMakeFiles/okularGenerator_ooo.dir/generator_ooo.cpp.o[ 40%] Linking CXX shared module okularGenerator_tiff.so[ 40%] Building CXX object mobile/components/CMakeFiles/okularplugin.dir/__/__/ui/pagepainter.cpp.o[ 40%] Built target okularGenerator_tiff[ 40%] Building CXX object generators/dvi/CMakeFiles/okularGenerator_dvi.dir/dviRenderer_draw.cpp.o[ 40%] Building CXX object generators/fictionbook/CMakeFiles/okularGenerator_fb.dir/okularGenerator_fb_autogen/mocs_compilation.cpp.o[ 

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 85 - Still Unstable!

2018-04-25 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/85/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 25 Apr 2018 22:36:09 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

[okular] [Bug 325119] Size of inline notes not adjusted to font size and does not respect drawn boundaries

2018-04-25 Thread Chris
https://bugs.kde.org/show_bug.cgi?id=325119

Chris  changed:

   What|Removed |Added

 CC||inkbottle...@gmail.com

--- Comment #9 from Chris  ---
There is also a Poppler bug concerning fonts in annotations which might be
related to the present matter:
https://bugs.freedesktop.org/show_bug.cgi?id=65956#c14

Apparently the font configured to be used in the annotation is ignored in
general. Maybe this should be fixed and the rest might work then?


Another point is I agree with comment saying that the shape and size of the
bounding box cannot be reasonably be fixed in advance ("drawn boundaries")
.

I think it should be marked as duplicate of the above Poppler bug; and as for
the "drawn boundaries", a wishlist bug should be opened where the intended
behavior of the "drawn box" could be discussed.

Also, since applications 17.08, it is very easy to reshape the box after the
text is entered.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D11609: Add support for chained / next actions

2018-04-25 Thread Oliver Sander
sander added a comment.


  People in my field still use Movie annotations, by means of LaTeX/multimedia. 
 Any improvement to their support is always welcome. :-)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11609

To: aheinecke, #okular
Cc: sander, aacid, ngraham


D12067: [Okular Part] Add "Print" action

2018-04-25 Thread Albert Astals Cid
aacid added a subscriber: dfaure.
aacid added a comment.


  @dfaure David, what is correct, should the part or the shell provide the 
print action?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12067

To: broulik, #okular, aacid
Cc: dfaure, ngraham, aacid


[okular] [Bug 393459] text in file not shown in viewer

2018-04-25 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=393459

--- Comment #8 from Albert Astals Cid  ---
it works for with with Nimbus provided by gsfonts, give it a try and make sure
you tweak your fontconfig

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 393478] crash when I exit presentation mode and enter again

2018-04-25 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=393478

--- Comment #6 from Dr. Chapatin  ---
(In reply to Albert Astals Cid from comment #5)
> (In reply to Dr. Chapatin from comment #4)
> > Okular does not show such message on Arch Linux.
> 
> I'm 99.9% sure it does, it's probably that you already pressed "don't
> show again" before, no?

Maybe. However I do not remember it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 393459] text in file not shown in viewer

2018-04-25 Thread Erik Quaeghebeur
https://bugs.kde.org/show_bug.cgi?id=393459

--- Comment #7 from Erik Quaeghebeur  ---
Created attachment 112245
  --> https://bugs.kde.org/attachment.cgi?id=112245=edit
screenshot of file fonts in viewer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 393478] crash when I exit presentation mode and enter again

2018-04-25 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=393478

--- Comment #5 from Albert Astals Cid  ---
(In reply to Dr. Chapatin from comment #4)
> Okular does not show such message on Arch Linux.

I'm 99.9% sure it does, it's probably that you already pressed "don't show
again" before, no?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 393459] text in file not shown in viewer

2018-04-25 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=393459

--- Comment #6 from Albert Astals Cid  ---
You probably have a wrong Helvetica font substitution configured on your
system, please attach a screenshot of Files->Properties->Fonts

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10932: [Okular] Option to reset forms

2018-04-25 Thread Henrik Fehlauer
rkflx added a comment.


  In D10932#252571 , @aacid wrote:
  
  > In D10932#248618 , @rkflx wrote:
  >
  > > FWIW, Foxit Reader does have a Reset Form button, which upon clicking 
shows a dialog asking "This option will reset all form fields to their default 
values. You may lose some data. Are you sure?".
  > >
  > > Let me know if you have specific example documents I should test this 
applications with, to see how they solved some of the more complicated aspects.
  >
  >
  > Can you try it with 
https://cgit.kde.org/okular.git/plain/autotests/data/formSamples.pdf ? what 
does it do with the "Option buttons" on the top left?
  
  
  After opening the file, the first option is selected. Resetting goes back to 
that exact same state:
  
  F5822304: foxit-reader-forms.webm 

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10932

To: ahmadosama, #okular, aacid
Cc: rkflx, cfeck, ngraham, aacid, #okular


KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 84 - Still Unstable!

2018-04-25 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/84/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 25 Apr 2018 16:09:06 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 83 - Still Unstable!

2018-04-25 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/83/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 25 Apr 2018 14:02:15 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

D11609: Add support for chained / next actions

2018-04-25 Thread Andre Heinecke
aheinecke added a comment.


  In D11609#253518 , @sander wrote:
  
  > > I've tried to create a test document with Adobe Acrobat Pro DC but ended 
up
  > >  frustrated and unable to create Movie or Rendition Actions (except for 
the Page Open Action).
  >
  > Would using LaTeX and the 'multimedia' package help here?
  
  
  Googling around it at least brought me to 
http://pages.uoregon.edu/noeckel/PDFmovie.html This page at least describes 
some formats and with an example document with which I was able to create 
rendition actions. And even trigger the debug output I added here.
  But I was unable to get the rendition action to work (even without having it 
as a chained action) in Okular. The page open play works fine.
  
  Here is my try:
  F5822001: movie-edit.pdf 
  
  > I know it create Movie _annotations_ . Is that the same as movie _actions_?
  
  No. From the PDF reference on movie actions:
  
  > The contents of a movie action dictionary are identical to those of a movie 
activa-
  >  tion dictionary (see Table 9.31 on page 785), with the additional entries 
shown in
  >  Table 8.59. The contents of the activation dictionary associated with the 
movie
  >  annotation provide the default values. Any information specified in the 
movie ac-
  >  tion dictionary overrides these values.
  
  So there is a difference.
  
  To be honest, I think that Movie actions and Renditon actions are deprecated, 
don't fully work and are exotic. 
  The most common usecase appears to be to have the Annotations on page open 
etc, which works.
  So I think we can, with good conscience, skip the support for them in this 
new feature here.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11609

To: aheinecke, #okular
Cc: sander, aacid, ngraham


[okular] [Bug 309902] Use KMessageWidget for informations rather than custom implementation

2018-04-25 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=309902

Luigi Toscano  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/oku
   ||lar/56c101833f6ec2c97ccadb4
   ||ed9d328295a8e4d88
   Version Fixed In||4.14.0
 CC||luigi.tosc...@tiscali.it

--- Comment #3 from Luigi Toscano  ---
Uh, more than "now" - this bug was strangly missed during the Okular sprint
(long time ago) when it was fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 393478] crash when I exit presentation mode and enter again

2018-04-25 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=393478

--- Comment #4 from Dr. Chapatin  ---
My neon dev unstable runs pulseaudio 8.0.

I can not reproduce the crash on Arch Linux running pulseaudio 11.1 and okular
1.4.0

I just noticed something: on neon okular shown a message when I changed to
presentation mode talking about ways to exit (ESC key and a button). After I
check "do not show again" I can not reproduce the crash anymore.
Okular does not show such message on Arch Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D11609: Add support for chained / next actions

2018-04-25 Thread Oliver Sander
sander added a comment.


  > I've tried to create a test document with Adobe Acrobat Pro DC but ended up
  >  frustrated and unable to create Movie or Rendition Actions (except for the 
Page Open Action).
  
  Would using LaTeX and the 'multimedia' package help here?  I know it create 
Movie _annotations_ .
  Is that the same as movie _actions_?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11609

To: aheinecke, #okular
Cc: sander, aacid, ngraham


[okular] [Bug 383675] highlight makes text disappear

2018-04-25 Thread Germano Massullo
https://bugs.kde.org/show_bug.cgi?id=383675

Germano Massullo  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |WORKSFORME
 Status|NEEDSINFO   |RESOLVED

--- Comment #7 from Germano Massullo  ---
The bug is no longer happening

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 315930] Ability to sign a PDF with my scanned signature (i.e. picture file) like in Adobe Acrobat

2018-04-25 Thread Ortwin Glück
https://bugs.kde.org/show_bug.cgi?id=315930

Ortwin Glück  changed:

   What|Removed |Added

 CC|o...@odi.ch  |

--- Comment #5 from Ortwin Glück  ---
Oh yes, never mind. Digital signatures would be
https://bugs.kde.org/show_bug.cgi?id=233806

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12067: [Okular Part] Add "Print" action

2018-04-25 Thread Kai Uwe Broulik
broulik added a comment.


  So, the situation is: the "Print" action comes from Konqueror. Kate part, for 
instance, adds its own "Print" action, so you get two but only one in Ark. So I 
don't know how this could be fixed in both cases. Either you end up with 
duplicate actions in Konqueror or none in Ark (or duplicate in Ark if we add 
one there).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12067

To: broulik, #okular, aacid
Cc: ngraham, aacid


D11609: Add support for chained / next actions

2018-04-25 Thread Andre Heinecke
aheinecke updated this revision to Diff 33048.
aheinecke added a comment.


  Removed unused deletion prevention for media links.
  Noted instead that nextActions containing MovieActions or
  RenditionActions are unsupported.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11609?vs=32471=33048

REVISION DETAIL
  https://phabricator.kde.org/D11609

AFFECTED FILES
  autotests/visibilitytest.cpp
  core/action.cpp
  core/action.h
  core/document.cpp
  generators/poppler/CMakeLists.txt
  generators/poppler/formfields.cpp
  generators/poppler/generator_pdf.cpp

To: aheinecke, #okular
Cc: aacid, ngraham


D11609: Add support for chained / next actions

2018-04-25 Thread Andre Heinecke
aheinecke added a comment.


  Right, I overlooked this a bit and assumed that the references were resolved 
on demand.
  But I think we could also say that we should resolve the MediaLinkReferences 
of the next actions, too.
  
  Looking at this more I see the problem that if we have a movie action
  as a next action it would be executed but the media links won't be resolved.
  I'm not really sure if this would be bad (crash) or if the second action just 
won't work.
  
  I've tried to create a test document with Adobe Acrobat Pro DC  but ended up
  frustrated and unable to create Movie or Rendition Actions (except for the 
Page Open Action).
  I was unable to add Media that was compatible with the "Play Media (Acrobat 5 
compatible)" and
  "Play Media (Acrobat 6 compatible)" actions, which I expect to be
  Movie / Rendition actions.
  
  The only thing I could do with added Movies was to create "RichMediaExecute" 
actions,
  which are (as far as i can tell) not supported by poppler. So it looks to me 
that Movie / Rendition actions
  are somewhat deprecated by Adobe Acrobat.
  
  As we don't have a testcase I think its probably better to just leave it 
unsupported. I'll update the patch accordingly.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11609

To: aheinecke, #okular
Cc: aacid, ngraham


[okular] [Bug 393478] crash when I exit presentation mode and enter again

2018-04-25 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=393478

--- Comment #3 from Albert Astals Cid  ---
Invalid write to eventfd: Bad file descriptor
Code should not be reached at pulsecore/fdsem.c:199, function pa_fdsem_post().
Aborting.

This tells me there's something wrong going with your pulseaudio. Which version
are you using? Maybe you should try opening a pulseaudio bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 393459] text in file not shown in viewer

2018-04-25 Thread Erik Quaeghebeur
https://bugs.kde.org/show_bug.cgi?id=393459

--- Comment #5 from Erik Quaeghebeur  ---
Created attachment 112229
  --> https://bugs.kde.org/attachment.cgi?id=112229=edit
screenshot of file in viewer with (invisible) text selected

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 393459] text in file not shown in viewer

2018-04-25 Thread Erik Quaeghebeur
https://bugs.kde.org/show_bug.cgi?id=393459

--- Comment #4 from Erik Quaeghebeur  ---
Created attachment 112228
  --> https://bugs.kde.org/attachment.cgi?id=112228=edit
screenshot of file in viewer

-- 
You are receiving this mail because:
You are the assignee for the bug.