KDE CI: Applications okular kf5-qt5 FreeBSDQt5.10 - Build # 10 - Unstable!

2018-05-17 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.10/10/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 17 May 2018 23:45:35 +
 Build duration:
3 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 16 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.addremoveannotationtestFailed: TestSuite.annotationstestFailed: TestSuite.calculatetexttestFailed: TestSuite.documenttestFailed: TestSuite.editannotationcontentstestFailed: TestSuite.editdrawingtooldialogtestFailed: TestSuite.editformstestFailed: TestSuite.generatorstestFailed: TestSuite.kimgiotestFailed: TestSuite.mainshelltestFailed: TestSuite.modifyannotationpropertiestestFailed: TestSuite.parttestFailed: TestSuite.searchtestFailed: TestSuite.translateannotationtestFailed: TestSuite.urldetecttestFailed: TestSuite.visibilitytest

[okular] [Bug 394226] Okular having random crash (archlinux)

2018-05-17 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=394226

Christoph Feck  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12901: Add unit test for SignatureFormField

2018-05-17 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 34385.
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Updated test PDF.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12901?vs=34212=34385

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12901

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/data/pdf_with_signature.pdf
  autotests/signatureformtest.cpp

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid


KDE CI: Applications okular kf5-qt5 FreeBSDQt5.10 - Build # 9 - Fixed!

2018-05-17 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.10/9/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 17 May 2018 14:57:26 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 17 test(s)

D12825: Fix recalculating forms twice

2018-05-17 Thread Andre Heinecke
aheinecke added a comment.


  To clarify:
  
  d->m_undoStack->push( uc );
  
  results in:
  EditFormTextCommand::redo()
  
  https://cgit.kde.org/okular.git/tree/core/documentcommands.cpp#n513
  
  which calls:
  
  m_docPriv->notifyFormChanges( m_pageNumber );
  
  https://cgit.kde.org/okular.git/tree/core/document.cpp#n3435
  
  That triggers the recalculate. So it is duplicated here.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12825

To: aheinecke, aacid
Cc: okular-devel, ngraham, aacid


D12884: Remove the internal file navigation from the global drawer

2018-05-17 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:600e72100b13: Remove the internal file navigation from 
the global drawer (authored by apol).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12884?vs=34335=34371

REVISION DETAIL
  https://phabricator.kde.org/D12884

AFFECTED FILES
  mobile/app/app.qrc
  mobile/app/package/contents/ui/Documents.qml
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/main.qml
  mobile/components/documentitem.cpp

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid


D12884: Remove the internal file navigation from the global drawer

2018-05-17 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12884

To: apol, #okular, mart, aacid
Cc: okular-devel, ngraham, aacid


[okular] [Bug 394374] New: cmake check for runtime deps

2018-05-17 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=394374

Bug ID: 394374
   Summary: cmake check for runtime deps
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: sit...@kde.org
  Target Milestone: ---

I've noticed that okular has a fair number of findExecutable calls. It'd be
really awesome if these runtime dependencies would get checked for in the
cmakelists (like already done for kirigami).
This makes the requirements reasonably codified, points users to potential
problems with their custom builds, and helps distros ensure all runtime deps
are properly pulled in by their packaging.

In neon, for example, we have special tech parsing the cmake feature_summary
output to check runtime dependencies are actually met.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 393459] text in file not shown in viewer

2018-05-17 Thread Erik Quaeghebeur
https://bugs.kde.org/show_bug.cgi?id=393459

--- Comment #10 from Erik Quaeghebeur  ---
(In reply to Christoph Feck from comment #9)
> Erik, did comment #8 help to resolve the issue?
I have not managed to try it out. My initial attempts stranded because I do not
know how to get Nimbus to be selected for substitution. I inquired on the
Gentoo forums, but did not get a response that helped me understand what I
needed to do. Currently, I do not have the time to try further.

-- 
You are receiving this mail because:
You are the assignee for the bug.