D21734: [WIP] Improve class documentation for PageView and PageViewItem

2019-06-12 Thread David Hurka 
davidhurka added a comment.


  In D21734#478372 , @aacid wrote:
  
  > In D21734#477729 , @davidhurka 
wrote:
  >
  > > Oh, does someone know any intended purpose division between 
setupActions(), setupViewerActions(), and setupBaseActions()?
  >
  >
  > someone does yes.
  >
  > it has to do with part's m_embedMode check part.cpp it's actually pretty 
easy to see the use case for them
  
  
  I think I figured that out now.
  
  ViewerWidgetMode limits editing actions, and PrintPreviewMode additionally 
limits zoom action shortcuts. I don’t understand why viewer embedding modes 
forbid text selection.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21734

To: davidhurka, #okular
Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen

D21759: Hold zoom center below center/mouse position

2019-06-12 Thread David Hurka 
davidhurka added a comment.


  Using cursor position for Ctrl+Scroll, but not for Ctrl+Plus/Minus makes 
sense to me.
  
  Can this be extended to using the initial cursor position for 
middle-button-drag zooming?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21759

To: steffenh, #okular
Cc: davidhurka, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21734: [WIP] Improve class documentation for PageView and PageViewItem

2019-06-12 Thread David Hurka 
davidhurka marked 6 inline comments as done.
davidhurka added inline comments.

INLINE COMMENTS

> aacid wrote in pageview.h:56
> i kind of know how this works, and i don't understand what "shown pages" is 
> supposed to mean.

Made the item “Content area” more general, to explain its purpose not before 
the item “Viewport area”.

> aacid wrote in pageview.h:104
> what does "can modify the viewport" mean for you?

Didn’t make sense. fitPageWidth() relayouts the pages, so mentioning that 
instead.

> aacid wrote in pageview.h:144
> what do you mean by uncropped geometry?

That’s a coordinate system of PageViewItem. Uncropped geometry is now explained 
in the Detailed Description of PageViewItem.

Do you think this is unclear, or didn’t you read so far yet?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21734

To: davidhurka, #okular
Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen

D21734: [WIP] Improve class documentation for PageView and PageViewItem

2019-06-12 Thread David Hurka 
davidhurka updated this revision to Diff 59687.
davidhurka added a comment.


  Looked over the whole patch again.
  
  Several wording improvements, and made some less specific or more accurate.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21734?vs=59553=59687

BRANCH
  create-pageview-documentation

REVISION DETAIL
  https://phabricator.kde.org/D21734

AFFECTED FILES
  ui/pageview.cpp
  ui/pageview.h
  ui/pageviewutils.h

To: davidhurka, #okular
Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen

[okular] [Bug 408620] New: Not able to view full PDF

2019-06-12 Thread Matt 
https://bugs.kde.org/show_bug.cgi?id=408620

Bug ID: 408620
   Summary: Not able to view full PDF
   Product: okular
   Version: 1.7.0
  Platform: Ubuntu Packages
OS: Linux
Status: REPORTED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: mattcowi...@gmail.com
  Target Milestone: ---

SUMMARY


STEPS TO REPRODUCE
1. Deleted the copy of PDF
2. Uninstalled Okular
3. Reinstalled Okular and redownloaded the PDF
4. Checked other PDF viewers (Chrome, Adobe Reader) and am able to view the 
full PDF

OBSERVED RESULT
The PDF is a book to study for a test. It starts midway through chapter 2

EXPECTED RESULT
The expected result is the ability to view the full book


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Ubuntu 19.04
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

-- 
You are receiving this mail because:
You are the assignee for the bug.

D21759: Hold zoom center below center/mouse position

2019-06-12 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21759

To: steffenh, #okular
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

[okular] [Bug 213508] Closing a navigation pane should shift focus to the document (away from the navigation panel)

2019-06-12 Thread Mayank Choudhary 
https://bugs.kde.org/show_bug.cgi?id=213508

Mayank Choudhary  changed:

   What|Removed |Added

 CC||mayankch...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 185636] More printing options for page control

2019-06-12 Thread Michael Weghorn 
https://bugs.kde.org/show_bug.cgi?id=185636

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|CONFIRMED   |RESOLVED

--- Comment #10 from Michael Weghorn  ---
(In reply to David Hurka from comment #9)
> Created attachment 120708 [details]
> Print options for page set
> 
> This seems to be fixed now. 
> 
> KDE Frameworks 5.58
> Qt 5.12.0
> Okular 1.7.1

Yes, it's been implemented in the Qt print dialog, s.
https://codereview.qt-project.org/c/qt/qtbase/+/215390 .

-- 
You are receiving this mail because:
You are the assignee for the bug.

D21759: Hold zoom center below center/mouse position

2019-06-12 Thread Steffen Hartleib 
steffenh created this revision.
steffenh added a reviewer: Okular.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
steffenh requested review of this revision.

REVISION SUMMARY
  This patch hold (if possibly) the zoom center below the mouse position (zoom 
with Ctrl + Mouse Wheel) or the center position from the pinch gesture.
  
  BUG: 390707 

REPOSITORY
  R223 Okular

BRANCH
  holdZoomCenter

REVISION DETAIL
  https://phabricator.kde.org/D21759

AFFECTED FILES
  ui/pageview.cpp
  ui/pageview.h

To: steffenh, #okular
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

[okular] [Bug 402015] Okular prints to a local queue which alphanumerically precedes a remote destination when cups-browsed is not installed.

2019-06-12 Thread Yuri Chornoivan 
https://bugs.kde.org/show_bug.cgi?id=402015

Yuri Chornoivan  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME
 CC||yurc...@ukr.net

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 402015] Okular prints to a local queue which alphanumerically precedes a remote destination when cups-browsed is not installed.

2019-06-12 Thread Brian Pokin 
https://bugs.kde.org/show_bug.cgi?id=402015

--- Comment #3 from Brian Pokin  ---
I took the hint and used the neon-user-20190606-1138.iso, which has okular
19.04.1. A local print queue, aaa, was set up and the print dialog also offered
a number of remote queues to print to. With cups-browsed stopped jobs were sent
to the remote queues. Unlike the Debian 17.12.2 none of the jobs went to aaa.

In other words I do not experience the previously described behaviour. As far
as I am concerned this report can be closed.

-- 
Brian.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15580: New annotation toolbar

2019-06-12 Thread Simone Gaiarin 
simgunz added inline comments.

INLINE COMMENTS

> aacid wrote in pageview.cpp:665
> You're right, it seems it never has. Can you use the other one?

Is it there a clean way to obtain a reference to the toolbar from within this 
class?
I guess that KMainWindow::toolBar(name) is a possibility, but how do I get a 
reference to the main window?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: aacid, anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, joaonetto, tfella, darcyshen