D15580: [WIP] New annotation toolbar

[Simone Gaiarin]

simgunz marked 6 inline comments as done.
simgunz added a subscriber: cfeck.
simgunz added a comment.


  I have managed to re-enable the action Tools > Review to show/hide the 
annotation toolbar.
  
  This action needs to be defined in shell.cpp, because to use 
KToggleToolBarAnnotation we need to pass a reference of the KToolbar to its 
constructor, and the toolbar does not yet exists when we setup the actions in 
pageview.cpp (line 633).
  This action needs to be created for each new part (e.g. when multiple tabs 
are created). This seems to work properly.
  
  Another weird thing I have noticed is that KToggleToolBarAnnotation is only 
able to toggle the annotation toolbar if this is also defined in shell.rc, 
while it is unable to toggle it when defined only in part.rc (even tough I am 
able to retrieve the toolbar instance correctly from shell.cpp, e.g. using 
toolBars(), also when the toolbar is only defined in part.rc). For this reason 
I had to define an empty annotation toolbar in shell.rc with the same name as 
the one in part.rc so that the two are merged. Is this the expected behavior of 
KToggleToolBarAnnotation? ( I include @cfeck in this discussion given that we 
were discussing KToggleToolBarAnnotation functionalities)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: cfeck, aacid, anthonyfieroni, davidhurka, knambiar, ngraham, 
tobiasdeiminger, okular-devel, maguirre, fbampaloukas, joaonetto, tfella, 
darcyshen

D15580: [WIP] New annotation toolbar

[Simone Gaiarin]

simgunz updated this revision to Diff 61188.
simgunz added a comment.


  - Clean parseTool
  - Initialize private members
  - Add action to toggle annotation toolbar, set default position below

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15580?vs=60168=61188

BRANCH
  new-annotation-toolbar

REVISION DETAIL
  https://phabricator.kde.org/D15580

AFFECTED FILES
  CMakeLists.txt
  conf/dlgannotations.cpp
  conf/dlgannotationsbase.ui
  conf/okular.kcfg
  part.rc
  shell/shell.cpp
  shell/shell.h
  shell/shell.rc
  ui/annotationactionhandler.cpp
  ui/annotationactionhandler.h
  ui/data/tools.xml
  ui/pageview.cpp
  ui/pageview.h
  ui/pageviewannotator.cpp
  ui/pageviewannotator.h
  ui/pageviewutils.cpp
  ui/pageviewutils.h
  ui/toolaction.cpp

To: simgunz, #okular
Cc: aacid, anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, maguirre, fbampaloukas, joaonetto, tfella, darcyshen

[okular] [Bug 409508] New: Permit to change the text's color or improve the invert colors option to respect images

[eemantsal]

https://bugs.kde.org/show_bug.cgi?id=409508

Bug ID: 409508
   Summary: Permit to change the text's color or improve the
invert colors option to respect images
   Product: okular
   Version: 1.7.2
  Platform: Gentoo Packages
OS: Linux
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: inf...@openaliasbox.org
  Target Milestone: ---

Okular has a few nice accesibility options to let the user change the
background color for the documents if these are really text documents, not just
scanned images. This is almost a must if one uses to read for long times in
dark environments and loves his retinas: you set the document's background in a
comfortable semidark color and you are almost dome. But I say "almost" because
the ideal would be to have an almost black background, but you can't because
Okular doesn't permit to change the text color, so you would end with a very
dark background and black text, which is illegible. So, finally you use the
"minor evil", not the optimal solution.
Theres an option to invert the colors for all the document, but this includes
the images, something rather annoying; the read is nice but then you see the
images in negative and something creaks in your brain.

So, my suggestions are to add the option to change the text color, my favorite,
since this would give the option of configuring the look very granularly and
make happy evry user out there; or add the possibility of excluding the images
in the «Invert colors» option.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 409507] Export highlighted text to plaintext file

[Yuri Chornoivan]

https://bugs.kde.org/show_bug.cgi?id=409507

Yuri Chornoivan  changed:

   What|Removed |Added

 CC||yurc...@ukr.net

--- Comment #1 from Yuri Chornoivan  ---
It is easy to copy all text right now with Ctrl+A then right-click and select
"Copy text".

Would it be an appropriate solution for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 409507] New: Export highlighted text to plaintext file

[eemantsal]

https://bugs.kde.org/show_bug.cgi?id=409507

Bug ID: 409507
   Summary: Export highlighted text to plaintext file
   Product: okular
   Version: 1.7.2
  Platform: Gentoo Packages
OS: Linux
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: inf...@openaliasbox.org
  Target Milestone: ---

When one has a lot of highlighted lines in a big Epub, PDF, etc, document,
being able to export them to a simple txt, or maybe markdown (in case one wants
to keep format for titles, bullets, etc), would be a great way to have résumés,
summaries, guides for presentations, talks, etc, without having to copy & paste
hundreds of times. When you have a 400 pages document is a real PITA, just
exporting would make life much more beautiful.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D22259: Reduce default sidebar icon size

[Noah Davis]

ndavis added a comment.


  In D22259#490892 , @stevenv wrote:
  
  > In D22259#490551 , @ndavis wrote:
  >
  > > I like the idea of having a thinner sidebar, but I don't like the idea of 
having unlabelled views by default. I think hiding labels would hurt usability 
for first time users.
  >
  >
  > I was on the fence about hiding the text for exactly that reason. But since 
the text is so wide it keeps the sidebar huge too. From a usability standpoint 
I think the tooltips //might// be enough, but I'm not a designer.
  
  
  You'd be surprised how often people forget that tooltips exist, event after 
being reminded many times. It's not that they aren't smart enough to remember, 
they just aren't that into computers.
  
  > Alternatively it could be changed to the vertical text used in places like 
the Kate sidebar. That however would be a much larger change and out of the 
scope of this patch.
  >  And personally I am not a fan of vertical text and find it difficult to 
read.
  
  I'm not a fan of vertical text either for the same reason.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22259

To: stevenv, #okular, #vdg
Cc: aacid, ndavis, okular-devel, maguirre, fbampaloukas, joaonetto, tfella, 
ngraham, darcyshen

D22259: Reduce default sidebar icon size

[Albert Astals Cid]

aacid added a comment.


  Unless you can give me empirical data that people prefer what you suggest i 
don't see the point in a change.
  
  All this is configurable, people can choose whatever they want.
  
  Also please use invent.kde.org in the future for Okular merge requests.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22259

To: stevenv, #okular, #vdg
Cc: aacid, ndavis, okular-devel, maguirre, fbampaloukas, joaonetto, tfella, 
ngraham, darcyshen

D22262: Thumbnails sidebar always open when okular starts

[Albert Astals Cid]

aacid added a comment.


  Please use invent.kde.org for new Merge requests agains okular.
  
  And yes you need to write tests.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22262

To: mayankchoudhary, aacid, ngraham, #okular
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, tfella, ngraham, 
darcyshen, aacid

D22259: Reduce default sidebar icon size

[Steven vanZyl]

stevenv added a comment.


  In D22259#490551 , @ndavis wrote:
  
  > I like the idea of having a thinner sidebar, but I don't like the idea of 
having unlabelled views by default. I think hiding labels would hurt usability 
for first time users.
  
  
  I was on the fence about hiding the text for exactly that reason. But since 
the text is so wide it keeps the sidebar huge too. From a usability standpoint 
I think the tooltips //might// be enough, but I'm not a designer.
  
  Alternatively it could be changed to the vertical text used in places like 
the Kate sidebar. That however would be a much larger change and out of the 
scope of this patch.
  And personally I am not a fan of vertical text and find it difficult to read.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22259

To: stevenv, #okular, #vdg
Cc: ndavis, okular-devel, maguirre, fbampaloukas, joaonetto, tfella, ngraham, 
darcyshen, aacid

D22262: Thumbnails sidebar always open when okular starts

[Mayank Choudhary]

mayankchoudhary added a comment.


  When I am trying to write autotests the pointer moves outside of the  okular 
window. I tried
  
QTest::mouseMove()
  
  &
  
QPoint()
  
  methods.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22262

To: mayankchoudhary, aacid, ngraham, #okular
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, tfella, ngraham, 
darcyshen, aacid

D22262: Thumbnails sidebar always open when okular starts

[Mayank Choudhary]

mayankchoudhary added reviewers: aacid, ngraham, Okular.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22262

To: mayankchoudhary, aacid, ngraham, #okular
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, tfella, ngraham, 
darcyshen, aacid

D22262: Thumbnails sidebar always open when okular starts

[Mayank Choudhary]

mayankchoudhary added a comment.


  Should i write autotests ?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22262

To: mayankchoudhary, aacid, ngraham, #okular
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, tfella, ngraham, 
darcyshen, aacid

D22262: Thumbnails sidebar always open when okular starts

[Mayank Choudhary]

mayankchoudhary created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
mayankchoudhary requested review of this revision.

REVISION SUMMARY
  Every time Okular starts, one of the items of the Sidebar is open (usually 
the Thumbnails panel).There is no way to disable it globally. It would be 
convenient to the users to automatically save the state of the panel upon exit 
and restore it when the Okular is opened again.
  FEATURE: 344599

TEST PLAN
  1. Open a PDF with Okular
  2. You will find that one of the items of the side navigation panel is open
  3. Click on the item icon of the navigation panel to minimize item's panel
  4. Close Okular
  5. Reopen Okular with same or different file as in step 1
  6. One of the items of the side navigation panel is again open
  7. But after applying this patch, the side navigation panel should be remain 
collapsed in step 6 with none of the item is selected

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22262

AFFECTED FILES
  conf/okular.kcfg
  part.cpp
  ui/sidebar.cpp

To: mayankchoudhary
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, tfella, ngraham, 
darcyshen, aacid