[okular] [Bug 409455] Request: Make signature notification more unobtrusive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=409455

Nate Graham  changed:

   What|Removed |Added

   Severity|wishlist|minor
 CC||n...@kde.org
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Nate Graham  ---
I don't disagree. However, the devil's in the details:

1. seems reasonable and doable.

2. would cause people to report it as a bug ("Why does the signature message
box just end in the middle of nowhere?"

3. is not a great UX since the message box could easily disappear before you've
finished reading it, or after you've read it and while you're moving your
cursor towards the button do do something with it. That would be really
infuriating.

4. would cause 99% of people to miss it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15347: Modify CloseDialogHelper in parttest

[Oliver Sander]

sander added a comment.


  Agreed.  I think the first step should be to write a unit test that triggers 
https://bugs.kde.org/show_bug.cgi?id=409638. That way we get a reproducible way 
to trigger the problem even for people without a stylus.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15347

To: tobiasdeiminger
Cc: sander, aacid, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen

D15580: [WIP] New annotation toolbar

[Simone Gaiarin]

simgunz added a comment.


  I messed up something... I see many files I have not modified that are marked 
as modified here. Probably because I changed the origin remote and my master 
was not in sync with upstream. I'll fix this with the next arc diff, now it 
does not let me arc diff again because it says that the diff is empty.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: cfeck, aacid, anthonyfieroni, davidhurka, knambiar, ngraham, 
tobiasdeiminger, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen

D15580: [WIP] New annotation toolbar

[Simone Gaiarin]

simgunz updated this revision to Diff 61742.
simgunz added a comment.


  - Fix action deselected if favorite tool with the same type is activated
  - Fix geom shapes action disabled when okular reparses config
  - Disable text annotation when file does not support them

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15580?vs=61190=61742

BRANCH
  new-annotation-toolbar

REVISION DETAIL
  https://phabricator.kde.org/D15580

AFFECTED FILES
  .gitlab-ci.yml
  CMakeLists.txt
  conf/dlgannotations.cpp
  conf/dlgannotationsbase.ui
  conf/editannottooldialog.cpp
  conf/editannottooldialog.h
  conf/okular.kcfg
  core/document.cpp
  core/signatureutils.h
  core/textdocumentgenerator.cpp
  generators/dvi/special.cpp
  generators/poppler/pdfsignatureutils.h
  generators/xps/generator_xps.cpp
  part.rc
  shell/shell.cpp
  shell/shell.h
  shell/shell.rc
  ui/annotationactionhandler.cpp
  ui/annotationactionhandler.h
  ui/annotationwidgets.cpp
  ui/annotationwidgets.h
  ui/data/tools.xml
  ui/pageview.cpp
  ui/pageview.h
  ui/pageviewannotator.cpp
  ui/pageviewannotator.h
  ui/pageviewutils.cpp
  ui/pageviewutils.h
  ui/side_reviews.cpp
  ui/toolaction.cpp

To: simgunz, #okular
Cc: cfeck, aacid, anthonyfieroni, davidhurka, knambiar, ngraham, 
tobiasdeiminger, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen

[okular] [Bug 342094] State of side Navigation Panel is not not remembered

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=342094

toon.peperm...@hotmail.com changed:

   What|Removed |Added

 CC||toon.peperm...@hotmail.com

--- Comment #7 from toon.peperm...@hotmail.com ---
I am simply astonished something like this hasn't been implemented years ago.
It can't be difficult: Okular can remember whether the navigation panel was
open or not in the last session, and Okular can remember the position and even
zoom of a specific document. Now it has to be a simple step to add
"ShowLeftPanel=false" or "ShowLeftPanel=true" to the xml files in
/home/user/.local/share/okular/docdata
In those files there already is something like:
  
   

   
  "
While in /home/user/.config/okularpartrc I find:
 [Main View]
 ShowLeftPanel=false
(when the navigation panel is open, however, there isn't "ShowLeftPanel=true",
but just nothing, maybe this should change)
Why not add this to the individual document files? I tried to change an xml
file myself, but that didn't work.
The next step (I suppose more difficult) is to remember which of the panels
(thumbnails or contents) was opened.
All this is standard behavior in Adobe Acrobat Reader DC on Windows 7, do you
think Adobe is getting lots of angry emails about this? It's also standard
behavior on the new WPS pdf reader.

Just to make clear my personal user case: I generally read pdf text files (or
djvu or epub, thank you very much for adding these file types to Okular), so
the thumbnails panel is mostly useless for me. The contents panel is very handy
however, but not every pdf has contents, and sometimes these 'contents' are
IMG_0001, IMG_0002, etc. In those cases I don't need a navigation panel at all.
So Okular remembering for each file if the panel was open or not is very useful
to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15347: Modify CloseDialogHelper in parttest

[Tobias Deiminger]

tobiasdeiminger added a comment.


  In D15347#495182 , @sander wrote:
  
  > @tobiasdeiminger , that hidden bug you mention, could it be the cause of 
https://bugs.kde.org/show_bug.cgi?id=409638 ?
  
  
  That may well be. I have not tried to reproduce bug 409638 myself, but the 
bug description hints that it's also the `QInputDialog` within  
`PickPointEngine::end` that gets spawned multiple times. If so, the symptoms 
are the same. Seems like a good time to pick the issue here up again.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15347

To: tobiasdeiminger
Cc: sander, aacid, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen

D15347: Modify CloseDialogHelper in parttest

[Oliver Sander]

sander added a comment.


  @tobiasdeiminger , that hidden bug you mention, could it be the cause of 
https://bugs.kde.org/show_bug.cgi?id=409638 ?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15347

To: tobiasdeiminger
Cc: sander, aacid, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, ngraham, darcyshen

[okular] [Bug 409638] Inline note with pen opens new notes while hovering

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=409638

--- Comment #2 from Oliver Sander  ---
Could this be related to what Tobias describes in 

  https://phabricator.kde.org/D15347

?

-- 
You are receiving this mail because:
You are the assignee for the bug.