[frameworks-kguiaddons] [Bug 424961] Attempting to launch "Help" from the button on the Menu->Settings"->"Configure Ocular" Dialog will launch a browser tab with a 404 Error

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=424961

Ahmad Samir  changed:

   What|Removed |Added

   Assignee|okular-devel@kde.org|kdelibs-b...@kde.org
  Component|general |general
Product|okular  |frameworks-kguiaddons
Version|20.12.3 |5.83.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424961] Attempting to launch "Help" from the button on the Menu->Settings"->"Configure Ocular" Dialog will launch a browser tab with a 404 Error

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=424961

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424961] Attempting to launch "Help" from the button on the Menu->Settings"->"Configure Ocular" Dialog will launch a browser tab with a 404 Error

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=424961

Ahmad Samir  changed:

   What|Removed |Added

   Version Fixed In||5.84
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kguiaddons/-/commit/
   ||897f83272c2f974844bf44b28d6
   ||63193b42a2fe1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424961] Attempting to launch "Help" from the button on the Menu->Settings"->"Configure Ocular" Dialog will launch a browser tab with a 404 Error

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=424961

Ahmad Samir  changed:

   What|Removed |Added

 CC||sergioaovale...@gmail.com

--- Comment #5 from Ahmad Samir  ---
*** Bug 419779 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424961] Attempting to launch "Help" from the button on the Menu->Settings"->"Configure Ocular" Dialog will launch a browser tab with a 404 Error

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=424961

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 CC||a.samir...@gmail.com
 Ever confirmed|0   |1

--- Comment #4 from Ahmad Samir  ---
https://invent.kde.org/frameworks/kguiaddons/-/merge_requests/18

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 436808] Okular crashes when closing it.

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=436808

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kwidgetsaddons/commi
   ||t/2c4e4bdab18e1d590403c96c8
   ||2efe6ca30b55638
 Status|CONFIRMED   |RESOLVED

--- Comment #5 from Ahmad Samir  ---
Git commit 2c4e4bdab18e1d590403c96c82efe6ca30b55638 by Ahmad Samir.
Committed on 10/05/2021 at 11:51.
Pushed by dfaure into branch 'master'.

Fix crash in KSelectAction

If the destroyed() signal from QComboBox, which is connected to the
comboBoxDeleted() slot, is emitted while the KSelectAction object is being
taken down, there is a crash is QList::removeAll(). Fix the issue by
disconnecting the signal in the KSelectActionPrivate() destructor.

This fixes a crash when closing a window that contains some KSelectAction
objects (e.g. KMail composer window, and OKular).

Add a comment explaining why the KSelectActionPrivate() destructor is virtual,
the comment is taken from an old commit by pino in kdelibs circa 2007 :)

Add unit test.

M  +32   -0autotests/kselectaction_unittest.cpp
M  +2-0autotests/kselectaction_unittest.h
M  +4-0src/kselectaction_p.h
M  +2-1tests/kselectactiontest.cpp

https://invent.kde.org/frameworks/kwidgetsaddons/commit/2c4e4bdab18e1d590403c96c82efe6ca30b55638

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 426976] Okular mangles url fragment if the it contains a '.'

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=426976

--- Comment #2 from Ahmad Samir  ---
Is the anchor part of a url only relevant to pdf's? if that is the case then we
could check for the index of ".pdf" and if the # is before it, it's part of the
filename otherwise is a legit url fragment and should be kept.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 426976] Okular mangles url fragment if the it contains a '.'

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=426976

Ahmad Samir  changed:

   What|Removed |Added

Summary|kioclient5 exec / kde-open5 |Okular mangles url fragment
   |with URL fragment on PDF|if the it contains a '.'

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 426976] kioclient5 exec / kde-open5 with URL fragment on PDF

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=426976

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Status|REPORTED|CONFIRMED
Product|frameworks-kio  |okular
Version|5.74.0  |unspecified
   Assignee|kio-bugs-n...@kde.org   |okular-devel@kde.org
 Ever confirmed|0   |1
  Component|general |general

--- Comment #1 from Ahmad Samir  ---
Okular issue.

ShellUtils::urlFromArg() mangles the url fragment if it contains a '.'
character.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421469] [Regression] Slow search in the contents pane

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=421469

--- Comment #8 from Ahmad Samir  ---
It turns out that the issue was in how itemMatches() was being called; it was
being called too many times.

A proposed fix: https://invent.kde.org/kde/okular/-/merge_requests/166

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421469] [Regression] Slow search in the contents pane

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=421469

--- Comment #7 from Ahmad Samir  ---
Indeed it is slower... reverting the changes in
KTreeViewSearchLine::itemMatches() restores the old behaviour. I am looking at
it, so far I don't see anything obvious, other than that QRegExp::FixedString
has some kind of optimisation that is much faster than what can be achieved by
using QRegularExpression::escape() on the pattern (QRegExp docs say that using
FixedString is equivalent to searching by using a pattern escaped by using
QRegExp::escape()).

I could just use plain string comparison when the "regular expression" search
option is disabled; string comparison is always faster than regular expression;
that doesn't fix the issue for "regular expression"... I'll test some more (but
it'll have to wait until tomorrow, it's getting late and I am almost
asleep...).

Sorry about the trouble :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

D25684: [core/*] replace foreach, deprecated, with range-for

[Ahmad Samir]

ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  Created a pull request on invent.kde.org. 
https://invent.kde.org/kde/okular/merge_requests/73

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25684

To: ahmadsamir, aacid
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25684: [core/*] replace foreach, deprecated, with range-for

[Ahmad Samir]

ahmadsamir added a comment.


  Trying to land this diff I get these errors:
  
remote: FATAL: W refs/heads/master okular ahmadsamir DENIED by refs/.*
remote: error: hook declined to update refs/heads/master
To git.kde.org:okular
 ! [remote rejected] c63256c8d18f7f2798019554d62e2c0fb8d0110c -> master 
(hook declined)
error: failed to push some refs to 'g...@git.kde.org:okular'
Usage Exception: Push failed! Fix the error and run "arc land" again.

REPOSITORY
  R223 Okular

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25684

To: ahmadsamir, aacid
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25684: [core/*] replace foreach, deprecated, with range-for

[Ahmad Samir]

ahmadsamir added a comment.


  Ping

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25684

To: ahmadsamir, aacid
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25684: [core/*] replace foreach, deprecated, with range-for

[Ahmad Samir]

ahmadsamir updated this revision to Diff 70945.
ahmadsamir added a comment.


  Rebase.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25684?vs=70874=70945

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25684

AFFECTED FILES
  core/annotations.cpp
  core/bookmarkmanager.cpp
  core/document.cpp
  core/documentcommands.cpp
  core/form.cpp
  core/generator_p.cpp
  core/page.cpp
  core/textdocumentgenerator.cpp
  core/textpage.cpp

To: ahmadsamir, aacid
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25684: [core/*] replace foreach, deprecated, with range-for

[Ahmad Samir]

ahmadsamir added a comment.


  In D25684#572361 , @aacid wrote:
  
  > Please rebase your patch on current master, since it will fail to merge 
properly, i prefer you do the work and not me ^_^
  
  
  FWIW, I always 'git pull --rebase' on the branch right before I 'arc land' :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25684

To: ahmadsamir, aacid
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25684: [core/*] replace foreach, deprecated, with range-for

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> aacid wrote in document.cpp:3920
> don't do const & for basic types, it's cheaper to copy them than to reference 
> them

Thanks. Noted.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25684

To: ahmadsamir, aacid
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25684: [core/*] replace foreach, deprecated, with range-for

[Ahmad Samir]

ahmadsamir updated this revision to Diff 70874.
ahmadsamir marked 7 inline comments as done.
ahmadsamir added a comment.


  ::distanceSqr() is going to be made const, so qAsConst isn't needed
  It's cheaper to copy basic types than reference them
  qAsConst isn't needed when iterating over member variable containers in const 
methods

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25684?vs=70756=70874

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25684

AFFECTED FILES
  core/annotations.cpp
  core/bookmarkmanager.cpp
  core/document.cpp
  core/documentcommands.cpp
  core/form.cpp
  core/generator_p.cpp
  core/page.cpp
  core/textdocumentgenerator.cpp
  core/textpage.cpp

To: ahmadsamir, aacid
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25684: [core/*] replace foreach, deprecated, with range-for

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added a reviewer: aacid.
Herald added a project: Okular.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  The code compiles and okular seems to load and work as before, all unit
  tests pass except (parttest and epubgeneratortest, but they fail on master
  too).

REPOSITORY
  R223 Okular

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25684

AFFECTED FILES
  core/annotations.cpp
  core/bookmarkmanager.cpp
  core/document.cpp
  core/documentcommands.cpp
  core/form.cpp
  core/generator_p.cpp
  core/page.cpp
  core/textdocumentgenerator.cpp
  core/textpage.cpp

To: ahmadsamir, aacid
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

[okular] [Bug 355399] make # of recent files configurable

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=355399

Ahmad Samir  changed:

   What|Removed |Added

  Component|general |general
   Assignee|kdelibs-b...@kde.org|okular-devel@kde.org
Product|frameworks-kconfigwidgets   |okular
 CC||a.samir...@gmail.com

--- Comment #10 from Ahmad Samir  ---
KRecentFilesAction has setMaxItems(); Okular can make use of it to fix this bug
report.

-- 
You are receiving this mail because:
You are the assignee for the bug.