Re: [Okular-devel] How to install your Okular
On 30 Sep 2014, at 21:21, Chang Lee changle...@gmail.com wrote: Hi, Someone recommended your program but I couldn't understand how to install it on my Windows 7. The download page direct me to a page called KDE. Is this the program Okular which is used to read PDFs? Did Okular change its name to KDE? The download page is very complicated and not user-friendly.. Are there simple instructions to install Okular (or KDE) to my computer? ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel Hi Okular is integrated with KDE framework which initially was a graphical desktop environment for Linux. You need to run the KDE installer and select from the list of applications just okular (or whatever application you need). Thus you will install okular port on Windows. regards Bogdan___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Porting okular to KDE frameworks 5
On 11/09/2013 12:21 PM, Albert Astals Cid wrote: El Diumenge, 20 d'octubre de 2013, a les 22:35:42, Albert Astals Cid va escriure: El Dissabte, 19 d'octubre de 2013, a les 20:53:32, Bogdan Cristea va escriure: On Sat 19 Oct 2013 07:04:25 PM CEST, Albert Astals Cid wrote: El Dissabte, 19 d'octubre de 2013, a les 15:15:37, Luigi Toscano va escriure: Bogdan Cristea wrote: Hi What is the status of porting okular to KF5 ? Given the current status of KF5 is this possible ? We are talking about a still unstable set of libraries (KF5) over a still unstable set of libraries (Qt 5.2). If you check the expected timelines, KDE Applications will still have new releases for the 4.x series (4.12 will arrive soon, 4.13 is expected too, I wouldn't be surprised by 4.14). Sure, experimental versions can be tried too, but as usual it's a matter of manpower (which is lacking). Albert can say something more, as I'm not a core developer, but *I* think that *right now* is better to have a more complete and stable version for 4.x than to spend time porting on two layers of instability. +1 Your time is better invested either in: A) Improving Okular as we shit it now B) Improving KF5 itself. I am interested in porting okular core library to embedded platforms (e.g. Android). I would like to experiment with okular and KF5 since KF5 uses now a modular structure, much more suitable I believe for stand alone KDE applications. So if you have an interest, what's stopping you doing it? :-) So did you start to work on this? No, not yet, I need to find some time, but this won't happen before Christmas. I'll let you know once I have something functional. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Porting okular to KDE frameworks 5
Hi What is the status of porting okular to KF5 ? Given the current status of KF5 is this possible ? thanks Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] PartTest - accessing private members
On 02.07.2013 13:23, Jaydeep Solanki wrote: Hi, In parttest.cpp, I see that private members have been accessed. It would be nice if someone can throw a light on how is it done, because when I try to do it, it doesn't compile saying cannot access private members. Cheers, Jaydeep ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel Look for some friend class and try to override it ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Akademy 2013
where the presentation slides can be found ? On Thu, May 2, 2013 at 1:26 PM, Mailson Lira mail...@gmail.com wrote: Hey guys. I'm sending this e-mail to let you know that I'll be attending akademy and also will give a 45min talk about the tiled-based engine (sorry for not telling you before). That's all! ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel -- Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 155515] Switch to tabbed interface
https://bugs.kde.org/show_bug.cgi?id=155515 Bogdan Cristea crist...@gmail.com changed: What|Removed |Added CC||crist...@gmail.com --- Comment #59 from Bogdan Cristea crist...@gmail.com --- Very good work Jonathan. You could open a review request at https://git.reviewboard.kde.org and upload your patch against okular sources from master. There are still a number of minor issues to solve, but they could be solved later. Issues I have found: - the same document can be opened several times in different tabs. Expected behavior: the same tab should be used or a dialog should be shown asking if the same tab or a different tab should be used - tab size differ among different documents according to their file name. Expected behavior: the same tab size should be used and a tooltip should be shown with the full file name -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Compile okular from master on Active Plasma development release
Hi I am trying to compile okular from master on AP, but the compilation of the okular frontend fails with the error: /home/mer/Build/okular/part.cpp:1185:51: error: ‘class KMimeType’ has no member named ‘parentMimeType’ The AP developers said that kdelibs is build only for AP without the deprecated symbols so I am wondering why the sources from master are not yet refactored. Is there an okular branch with the newest changes (related mainly to observer IDs removal) allowing to compile on AP ? regards -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Compile okular with qt5
Hi I am wondering if there are plans to provide okular with qt5? I know that qt5 is not source compatible with qt4, but I think that there are some speed improvements and new features from qt5 that might be worth trying. regards -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109115: Make observer.h installable
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109115/#review27956 --- Ship it! works for me - Bogdan Cristea On Feb. 23, 2013, 10:25 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109115/ --- (Updated Feb. 23, 2013, 10:25 p.m.) Review request for Okular, Aaron J. Seigo, Bogdan Cristea, and Marco Martin. Description --- Make observer.h installable To make sense in doing that kill the harcoded observer ids, move the priorities to an okular-ui only place and make the pixmap preload easier to access (not depend on random priority values) We need the m_tiledObserver hack since we only support one tiled observer in the code. Also kill viewId from View since doesn't make sense either and is unused :-) Note, there are twohtml pages in the view diff page Marco, Aaron, I haven't tried the active part, could you give it a quick try? Superceeds https://git.reviewboard.kde.org/r/107047/ Diffs - ui/toc.cpp bde7c97 ui/minibar.h 185adff ui/pagepainter.h 42a7313 ui/pagepainter.cpp 91ae211 ui/pagesizelabel.h 7c4a1e2 ui/pageview.h d8a7653 ui/pageview.cpp 60a273d ui/presentationwidget.h 1608ef8 ui/presentationwidget.cpp 35b9d34 ui/priorities.h PRE-CREATION ui/side_reviews.h bbd8324 ui/side_reviews.cpp a35f9ed ui/thumbnaillist.h 20c434f ui/thumbnaillist.cpp f191274 ui/toc.h 8679648 ui/bookmarklist.h cb8fcc3 ui/bookmarklist.cpp e1b3869 active/components/pageitem.cpp a04a8dc active/components/pageitem.h 0db4080 active/components/documentitem.cpp 404d863 active/components/documentitem.h 750e5af CMakeLists.txt e40cfd6 core/rotationjob_p.h 305e2a1 core/rotationjob.cpp e26bd6b core/page_p.h 75575a7 core/page.cpp 4df58e0 core/page.h 6bc60c5 core/observer.h f7189be core/generator_p.h 66d4574 core/generator.cpp 402c881 core/generator.h 420bd41 core/document_p.h 57a3bee core/document.h 1d825e1 core/document.cpp 372af56 core/bookmarkmanager.cpp accd65f ui/annotationmodel.cpp d6d234d part.h e3a9418 part.cpp f1cdc11 generators/spectre/generator_ghostview.cpp d687d01 generators/chm/generator_chm.cpp c342a10 generators/chm/generator_chm.h d87071a core/view.h d1fa376 Diff: http://git.reviewboard.kde.org/r/109115/diff/ Testing --- Compiles, after some tests doesn't seem to crash. Thanks, Albert Astals Cid ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109115: Make observer.h installable
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109115/#review27940 --- active/components/documentitem.cpp http://git.reviewboard.kde.org/r/109115/#comment20939 remove trailing space - Bogdan Cristea On Feb. 23, 2013, 6:27 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109115/ --- (Updated Feb. 23, 2013, 6:27 p.m.) Review request for Okular, Aaron J. Seigo, Bogdan Cristea, and Marco Martin. Description --- Make observer.h installable To make sense in doing that kill the harcoded observer ids, move the priorities to an okular-ui only place and make the pixmap preload easier to access (not depend on random priority values) We need the m_tiledObserver hack since we only support one tiled observer in the code. Also kill viewId from View since doesn't make sense either and is unused :-) Note, there are twohtml pages in the view diff page Marco, Aaron, I haven't tried the active part, could you give it a quick try? Superceeds https://git.reviewboard.kde.org/r/107047/ Diffs - ui/toc.cpp bde7c97 ui/pagesizelabel.h 7c4a1e2 ui/pageview.h d8a7653 ui/pageview.cpp 60a273d ui/presentationwidget.h 1608ef8 ui/presentationwidget.cpp 35b9d34 ui/priorities.h PRE-CREATION ui/side_reviews.h bbd8324 ui/side_reviews.cpp a35f9ed ui/thumbnaillist.h 20c434f ui/thumbnaillist.cpp f191274 ui/toc.h 8679648 core/rotationjob.cpp e26bd6b core/rotationjob_p.h 305e2a1 core/view.h d1fa376 generators/chm/generator_chm.h d87071a generators/chm/generator_chm.cpp c342a10 generators/spectre/generator_ghostview.cpp d687d01 part.h e3a9418 part.cpp f1cdc11 ui/annotationmodel.cpp d6d234d ui/bookmarklist.h cb8fcc3 ui/bookmarklist.cpp e1b3869 ui/minibar.h 185adff ui/pagepainter.h 42a7313 ui/pagepainter.cpp 91ae211 CMakeLists.txt e40cfd6 active/components/documentitem.h 750e5af active/components/documentitem.cpp 404d863 active/components/pageitem.h 0db4080 active/components/pageitem.cpp a04a8dc core/bookmarkmanager.cpp accd65f core/document.h 1d825e1 core/document.cpp 372af56 core/document_p.h 57a3bee core/generator.h 420bd41 core/generator.cpp 402c881 core/generator_p.h 66d4574 core/observer.h f7189be core/page.h 6bc60c5 core/page.cpp 4df58e0 core/page_p.h 75575a7 Diff: http://git.reviewboard.kde.org/r/109115/diff/ Testing --- Compiles, after some tests doesn't seem to crash. Thanks, Albert Astals Cid ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109115: Make observer.h installable
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109115/#review27941 --- It crashes while opening pdf or chm files. Below is the crash report for pdf file Application: Okular (okular), signal: Segmentation fault Using host libthread_db library /lib64/libthread_db.so.1. [KCrash Handler] #5 Okular::DocumentPrivate::searchLowestPriorityPixmap (this=this@entry=0x14abf90, unloadableOnly=unloadableOnly@entry=true, thenRemoveIt=thenRemoveIt@entry=false, observer=observer@entry=0x0) at /home/bogdan/Build/okular/core/document.cpp:426 #6 0x7f0550afeac9 in Okular::DocumentPrivate::sendGeneratorPixmapRequest (this=this@entry=0x14abf90) at /home/bogdan/Build/okular/core/document.cpp:1140 #7 0x7f0550aff5d7 in Okular::DocumentPrivate::requestDone (this=0x14abf90, req=0x18cf6c0) at /home/bogdan/Build/okular/core/document.cpp:4182 #8 0x7f0550b117b6 in Okular::GeneratorPrivate::pixmapGenerationFinished (this=0x1865540) at /home/bogdan/Build/okular/core/generator.cpp:108 #9 0x7f055d3e70ae in QObject::event(QEvent*) () from /usr/lib64/libQtCore.so.4 #10 0x7f055e02974c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4 #11 0x7f055e02dc7a in QApplication::notify(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4 #12 0x7f055ed3d006 in KApplication::notify(QObject*, QEvent*) () from /usr/lib64/libkdeui.so.5 #13 0x7f055d3d273e in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib64/libQtCore.so.4 #14 0x7f055d3d6091 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/lib64/libQtCore.so.4 #15 0x7f055d4007a3 in ?? () from /usr/lib64/libQtCore.so.4 #16 0x7f05595553b5 in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0 #17 0x7f05595556e8 in ?? () from /usr/lib64/libglib-2.0.so.0 #18 0x7f05595557a4 in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0 #19 0x7f055d400936 in QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib64/libQtCore.so.4 #20 0x7f055e0c98ae in ?? () from /usr/lib64/libQtGui.so.4 #21 0x7f055d3d173f in QEventLoop::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib64/libQtCore.so.4 #22 0x7f055d3d19c8 in QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from /usr/lib64/libQtCore.so.4 #23 0x7f055d3d63a8 in QCoreApplication::exec() () from /usr/lib64/libQtCore.so.4 #24 0x0040887e in main (argc=optimized out, argv=optimized out) at /home/bogdan/Build/okular/shell/main.cpp:94 - Bogdan Cristea On Feb. 23, 2013, 6:27 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109115/ --- (Updated Feb. 23, 2013, 6:27 p.m.) Review request for Okular, Aaron J. Seigo, Bogdan Cristea, and Marco Martin. Description --- Make observer.h installable To make sense in doing that kill the harcoded observer ids, move the priorities to an okular-ui only place and make the pixmap preload easier to access (not depend on random priority values) We need the m_tiledObserver hack since we only support one tiled observer in the code. Also kill viewId from View since doesn't make sense either and is unused :-) Note, there are twohtml pages in the view diff page Marco, Aaron, I haven't tried the active part, could you give it a quick try? Superceeds https://git.reviewboard.kde.org/r/107047/ Diffs - ui/toc.cpp bde7c97 ui/pagesizelabel.h 7c4a1e2 ui/pageview.h d8a7653 ui/pageview.cpp 60a273d ui/presentationwidget.h 1608ef8 ui/presentationwidget.cpp 35b9d34 ui/priorities.h PRE-CREATION ui/side_reviews.h bbd8324 ui/side_reviews.cpp a35f9ed ui/thumbnaillist.h 20c434f ui/thumbnaillist.cpp f191274 ui/toc.h 8679648 core/rotationjob.cpp e26bd6b core/rotationjob_p.h 305e2a1 core/view.h d1fa376 generators/chm/generator_chm.h d87071a generators/chm/generator_chm.cpp c342a10 generators/spectre/generator_ghostview.cpp d687d01 part.h e3a9418 part.cpp f1cdc11 ui/annotationmodel.cpp d6d234d ui/bookmarklist.h cb8fcc3 ui/bookmarklist.cpp e1b3869 ui/minibar.h 185adff ui/pagepainter.h 42a7313 ui/pagepainter.cpp 91ae211 CMakeLists.txt e40cfd6 active/components/documentitem.h 750e5af active/components/documentitem.cpp 404d863 active/components/pageitem.h 0db4080 active/components/pageitem.cpp a04a8dc core/bookmarkmanager.cpp accd65f core/document.h 1d825e1 core/document.cpp 372af56 core/document_p.h 57a3bee core/generator.h 420bd41 core
Re: [Okular-devel] Review Request 107047: Settings separation: observer.h install and compilation correction on Windows
On Feb. 10, 2013, 10:49 p.m., Albert Astals Cid wrote: The patch looks ok minor the two small inline comments. Having a look at the patch though i see we have those *special* ids, and i think it would make much more sense not to have any, that would mean having a look at what those special ids do and splitting it into separate options of either observer, or the function calls or whatever. But maybe this is too much for this and we should just commit this first and then try to generalize those? What do you all think? You need to provide anyway the maximum number of public IDs for Document class in order to generate private IDs outside the reserved range. So I believe that is better to have public IDs and their number in one place, i.e. in an enumeration inside Document class. For the moment I would just commit these changes as they are and open maybe a feature request or whatever in order to remove completely these IDs (I do not see yet how it might be done). - Bogdan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/#review27146 --- On Feb. 11, 2013, 9:07 p.m., Bogdan Cristea wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/ --- (Updated Feb. 11, 2013, 9:07 p.m.) Review request for Okular. Description --- This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows): - after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols - add definitions needed to activate these switches on Windows Diffs - ui/thumbnaillist.h 20c434f ui/thumbnaillist.cpp 33a5431 ui/toc.h 8679648 ui/toc.cpp bde7c97 generators/chm/generator_chm.cpp c342a10 part.h e3a9418 ui/annotationmodel.cpp d6d234d ui/bookmarklist.h cb8fcc3 ui/bookmarklist.cpp e1b3869 ui/minibar.h a0c0514 ui/pagepainter.cpp 91ae211 ui/pagesizelabel.h 7c4a1e2 ui/pageview.h d8a7653 ui/pageview.cpp 60a273d ui/presentationwidget.h 1608ef8 ui/presentationwidget.cpp 35b9d34 ui/side_reviews.h bbd8324 core/document.cpp 372af56 core/generator.cpp 402c881 core/observer.h f7189be core/observer.cpp 59bbb11 core/page.h 6bc60c5 core/page.cpp 4df58e0 core/page_p.h 75575a7 CMakeLists.txt e40cfd6 active/components/pageitem.cpp a04a8dc core/document.h 1d825e1 Diff: http://git.reviewboard.kde.org/r/107047/diff/ Testing --- no Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 107047: Settings separation: observer.h install and compilation correction on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/ --- (Updated Feb. 11, 2013, 9:07 p.m.) Review request for Okular. Description --- This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows): - after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols - add definitions needed to activate these switches on Windows Diffs (updated) - ui/thumbnaillist.h 20c434f ui/thumbnaillist.cpp 33a5431 ui/toc.h 8679648 ui/toc.cpp bde7c97 generators/chm/generator_chm.cpp c342a10 part.h e3a9418 ui/annotationmodel.cpp d6d234d ui/bookmarklist.h cb8fcc3 ui/bookmarklist.cpp e1b3869 ui/minibar.h a0c0514 ui/pagepainter.cpp 91ae211 ui/pagesizelabel.h 7c4a1e2 ui/pageview.h d8a7653 ui/pageview.cpp 60a273d ui/presentationwidget.h 1608ef8 ui/presentationwidget.cpp 35b9d34 ui/side_reviews.h bbd8324 core/document.cpp 372af56 core/generator.cpp 402c881 core/observer.h f7189be core/observer.cpp 59bbb11 core/page.h 6bc60c5 core/page.cpp 4df58e0 core/page_p.h 75575a7 CMakeLists.txt e40cfd6 active/components/pageitem.cpp a04a8dc core/document.h 1d825e1 Diff: http://git.reviewboard.kde.org/r/107047/diff/ Testing --- no Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 107047: Settings separation: observer.h install and compilation correction on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/ --- (Updated Feb. 11, 2013, 9:07 p.m.) Review request for Okular. Description --- This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows): - after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols - add definitions needed to activate these switches on Windows Diffs (updated) - ui/thumbnaillist.h 20c434f ui/thumbnaillist.cpp 33a5431 ui/toc.h 8679648 ui/toc.cpp bde7c97 generators/chm/generator_chm.cpp c342a10 part.h e3a9418 ui/annotationmodel.cpp d6d234d ui/bookmarklist.h cb8fcc3 ui/bookmarklist.cpp e1b3869 ui/minibar.h a0c0514 ui/pagepainter.cpp 91ae211 ui/pagesizelabel.h 7c4a1e2 ui/pageview.h d8a7653 ui/pageview.cpp 60a273d ui/presentationwidget.h 1608ef8 ui/presentationwidget.cpp 35b9d34 ui/side_reviews.h bbd8324 core/document.cpp 372af56 core/generator.cpp 402c881 core/observer.h f7189be core/observer.cpp 59bbb11 core/page.h 6bc60c5 core/page.cpp 4df58e0 core/page_p.h 75575a7 CMakeLists.txt e40cfd6 active/components/pageitem.cpp a04a8dc core/document.h 1d825e1 Diff: http://git.reviewboard.kde.org/r/107047/diff/ Testing --- no Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 107047: Settings separation: observer.h install and compilation correction on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/ --- (Updated Feb. 11, 2013, 9:07 p.m.) Review request for Okular. Description --- This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows): - after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols - add definitions needed to activate these switches on Windows Diffs - ui/thumbnaillist.h 20c434f ui/thumbnaillist.cpp 33a5431 ui/toc.h 8679648 ui/toc.cpp bde7c97 generators/chm/generator_chm.cpp c342a10 part.h e3a9418 ui/annotationmodel.cpp d6d234d ui/bookmarklist.h cb8fcc3 ui/bookmarklist.cpp e1b3869 ui/minibar.h a0c0514 ui/pagepainter.cpp 91ae211 ui/pagesizelabel.h 7c4a1e2 ui/pageview.h d8a7653 ui/pageview.cpp 60a273d ui/presentationwidget.h 1608ef8 ui/presentationwidget.cpp 35b9d34 ui/side_reviews.h bbd8324 core/document.cpp 372af56 core/generator.cpp 402c881 core/observer.h f7189be core/observer.cpp 59bbb11 core/page.h 6bc60c5 core/page.cpp 4df58e0 core/page_p.h 75575a7 CMakeLists.txt e40cfd6 active/components/pageitem.cpp a04a8dc core/document.h 1d825e1 Diff: http://git.reviewboard.kde.org/r/107047/diff/ Testing --- no Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 107047: Settings separation: observer.h install and compilation correction on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/ --- (Updated Feb. 10, 2013, 9:51 p.m.) Review request for Okular. Changes --- Removed most of hard coded observer IDs, for now corrections related to compilation on windows are dropped since they could be put in a different patch. Description --- This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows): - after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols - add definitions needed to activate these switches on Windows Diffs (updated) - ui/minibar.h a0c0514 ui/pagepainter.cpp 91ae211 ui/pagesizelabel.h 7c4a1e2 ui/pageview.h d8a7653 ui/pageview.cpp 60a273d ui/presentationwidget.h 1608ef8 ui/presentationwidget.cpp 35b9d34 ui/side_reviews.h bbd8324 ui/thumbnaillist.h 20c434f ui/thumbnaillist.cpp 33a5431 ui/toc.h 8679648 ui/toc.cpp bde7c97 CMakeLists.txt e40cfd6 active/components/pageitem.cpp a04a8dc core/document.h 1d825e1 core/document.cpp 372af56 core/generator.cpp 402c881 core/observer.h f7189be core/observer.cpp 59bbb11 core/page.h 6bc60c5 core/page.cpp 4df58e0 core/page_p.h 75575a7 generators/chm/generator_chm.cpp c342a10 part.h e3a9418 ui/annotationmodel.cpp d6d234d ui/bookmarklist.h cb8fcc3 ui/bookmarklist.cpp e1b3869 Diff: http://git.reviewboard.kde.org/r/107047/diff/ Testing (updated) --- no Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 107047: Settings separation: observer.h install and compilation correction on Windows
On Feb. 8, 2013, 11:20 p.m., Albert Astals Cid wrote: Bogdan? sorry for being so late, you'll have my patch this week-end - Bogdan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/#review27034 --- On Oct. 26, 2012, 7:57 a.m., Bogdan Cristea wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/ --- (Updated Oct. 26, 2012, 7:57 a.m.) Review request for Okular. Description --- This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows): - after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols - add definitions needed to activate these switches on Windows Diffs - CMakeLists.txt 063778f active/components/CMakeLists.txt 19b759e conf/settings.kcfgc 5e2ec95 okular_part_export.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107047/diff/ Testing --- yes Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] trying to add my own functionality into Okular
On Thursday 07 February 2013 23:44:14 Albert Astals Cid wrote: I work for a research center and we would like to test some of our research on open source viewers. Okular is my first choice. The things I'll need to do include changing some UI, getting content of documents from backend, applying our algorithm and get some output, etc. As this is my first experience of developing with open source software and I'm now having some trouble with understanding the source code. Is there any kind of developer's manual or other similar documents so that I could understand the source code quickly? Or do you have any suggestions how I should get started? Thanks a lot! I have made a reader using okular backend https://projects.kde.org/projects/playground/edu/ebookreader Have a look at okulardocument.cpp in order to understand how okular backend is used. There is also okular active which uses qml plugins (currently included into okular) -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Error when loading pdf document with latest sources from master
libpoppler version 0.18.0-2.6.1 x86_64 from openSUSE 12.2 repository On Tue, Feb 5, 2013 at 8:09 PM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 4 de febrer de 2013, a les 21:57:51, Bogdan Cristea va escriure: It should work with any pdf file generated with Google Chrome. Works fine here, which poppler version are you using? Cheers, Albert On Mon, Feb 4, 2013 at 8:33 PM, Albert Astals Cid aa...@kde.org wrote: El Diumenge, 3 de febrer de 2013, a les 21:50:26, Bogdan Cristea va escriure: The loaded document has a black background and I get the following error in terminal: Clash for annotations with ID: 0 The pdf is generated with Google-Chrome by printing to file a web page. I think you forgot to attach the file or give the url. Cheers, Albert ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel -- Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Error when loading pdf document with latest sources from master
The loaded document has a black background and I get the following error in terminal: Clash for annotations with ID: 0 The pdf is generated with Google-Chrome by printing to file a web page. -- Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Option for exporting annotations
Hi Is there an option allowing to export the annotations from a PDF file ? I need to provide reviews for some articles so I need to export as text only the annotations (with the page number if possible). regards -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 312681] New: pdf files generated from google-chrome are not opened
https://bugs.kde.org/show_bug.cgi?id=312681 Bug ID: 312681 Summary: pdf files generated from google-chrome are not opened Classification: Unclassified Product: okular Version: 0.16.60 Hardware: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: PDF backend Assignee: okular-devel@kde.org Reporter: crist...@gmail.com PDF files generated from Google Chrome are not opened by okular, while Acrobat Reader opens them. Also, the time needed to report the error is quite important (more than one minute). Reproducible: Always Steps to Reproduce: 1. save a web page from Google Chrome as PDF file 2. check that the PDF file is not damaged with another PDF viewer (e.g. Acrobat Reader) 3. open the saved file with okular Actual Results: the file is not opened Expected Results: the file should be opened. In case of an error (due to the underlying poppler library), this one should be reported ASAP to the user. using openSUSE 12.2, x86_64 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 312681] pdf files generated from google-chrome are not opened
https://bugs.kde.org/show_bug.cgi?id=312681 --- Comment #1 from Bogdan Cristea crist...@gmail.com --- Created attachment 76206 -- https://bugs.kde.org/attachment.cgi?id=76206action=edit used to reproduce the reported behavior -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 312681] pdf files generated from google-chrome are not opened
https://bugs.kde.org/show_bug.cgi?id=312681 --- Comment #3 from Bogdan Cristea crist...@gmail.com --- poppler 0.20.0-2.9.1 x86_64 from openSUSE 12.2 repository. Actually the okular window is not responding, no error message is shown. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 312681] pdf files generated from google-chrome are not opened
https://bugs.kde.org/show_bug.cgi?id=312681 --- Comment #5 from Bogdan Cristea crist...@gmail.com --- #0 0x7fa799fca673 in ?? () from /usr/lib64/libQtXml.so.4 #1 0x7fa799fcad48 in ?? () from /usr/lib64/libQtXml.so.4 #2 0x7fa799fca7d2 in ?? () from /usr/lib64/libQtXml.so.4 #3 0x7fa799fd39b6 in ?? () from /usr/lib64/libQtXml.so.4 #4 0x7fa786da2d81 in Poppler::Annotation::storeBaseAnnotationProperties(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #5 0x7fa786da4379 in Poppler::LinkAnnotation::store(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #6 0x7fa786d9c1e2 in Poppler::AnnotationUtils::storeAnnotation(Poppler::Annotation const*, QDomElement, QDomDocument) () from /usr/lib64/libpoppler-qt4.so.4 #7 0x7fa786da38f6 in Poppler::Annotation::storeBaseAnnotationProperties(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #8 0x7fa786da4379 in Poppler::LinkAnnotation::store(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #9 0x7fa786d9c1e2 in Poppler::AnnotationUtils::storeAnnotation(Poppler::Annotation const*, QDomElement, QDomDocument) () from /usr/lib64/libpoppler-qt4.so.4 #10 0x7fa786da38f6 in Poppler::Annotation::storeBaseAnnotationProperties(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #11 0x7fa786da4379 in Poppler::LinkAnnotation::store(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #12 0x7fa786d9c1e2 in Poppler::AnnotationUtils::storeAnnotation(Poppler::Annotation const*, QDomElement, QDomDocument) () from /usr/lib64/libpoppler-qt4.so.4 #13 0x7fa786da38f6 in Poppler::Annotation::storeBaseAnnotationProperties(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #14 0x7fa786da4379 in Poppler::LinkAnnotation::store(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #15 0x7fa786d9c1e2 in Poppler::AnnotationUtils::storeAnnotation(Poppler::Annotation const*, QDomElement, QDomDocument) () from /usr/lib64/libpoppler-qt4.so.4 #16 0x7fa786da38f6 in Poppler::Annotation::storeBaseAnnotationProperties(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #17 0x7fa786da4379 in Poppler::LinkAnnotation::store(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #18 0x7fa786d9c1e2 in Poppler::AnnotationUtils::storeAnnotation(Poppler::Annotation const*, QDomElement, QDomDocument) () from /usr/lib64/libpoppler-qt4.so.4 #19 0x7fa786da38f6 in Poppler::Annotation::storeBaseAnnotationProperties(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #20 0x7fa786da4379 in Poppler::LinkAnnotation::store(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #21 0x7fa786d9c1e2 in Poppler::AnnotationUtils::storeAnnotation(Poppler::Annotation const*, QDomElement, QDomDocument) () from /usr/lib64/libpoppler-qt4.so.4 #22 0x7fa786da38f6 in Poppler::Annotation::storeBaseAnnotationProperties(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #23 0x7fa786da4379 in Poppler::LinkAnnotation::store(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #24 0x7fa786d9c1e2 in Poppler::AnnotationUtils::storeAnnotation(Poppler::Annotation const*, QDomElement, QDomDocument) () from /usr/lib64/libpoppler-qt4.so.4 #25 0x7fa786da38f6 in Poppler::Annotation::storeBaseAnnotationProperties(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #26 0x7fa786da4379 in Poppler::LinkAnnotation::store(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #27 0x7fa786d9c1e2 in Poppler::AnnotationUtils::storeAnnotation(Poppler::Annotation const*, QDomElement, QDomDocument) () from /usr/lib64/libpoppler-qt4.so.4 #28 0x7fa786da38f6 in Poppler::Annotation::storeBaseAnnotationProperties(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #29 0x7fa786da4379 in Poppler::LinkAnnotation::store(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #30 0x7fa786d9c1e2 in Poppler::AnnotationUtils::storeAnnotation(Poppler::Annotation const*, QDomElement, QDomDocument) () from /usr/lib64/libpoppler-qt4.so.4 #31 0x7fa786da38f6 in Poppler::Annotation::storeBaseAnnotationProperties(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #32 0x7fa786da4379 in Poppler::LinkAnnotation::store(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #33 0x7fa786d9c1e2 in Poppler::AnnotationUtils::storeAnnotation(Poppler::Annotation const*, QDomElement, QDomDocument) () from /usr/lib64/libpoppler-qt4.so.4 #34 0x7fa786da38f6 in Poppler::Annotation::storeBaseAnnotationProperties(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #35 0x7fa786da4379 in Poppler::LinkAnnotation::store(QDomNode, QDomDocument) const () from /usr/lib64/libpoppler-qt4.so.4 #36 0x7fa786d9c1e2 in Poppler
Re: [Okular-devel] Creating new class
Le jeudi 20 décembre 2012 à 12:09 +0200, Jakub Zakrzewski a écrit : I created the tocsearch.moc and tocsearchmodel.moc files from toc.moc and tocmodel.moc files. These errors I get while running `make`: CMakeFiles/okularpart.dir/ui/tocsearchmodel.o:/media/d/workspaces/kde/okular/tocmodel.moc:75: first defined here CMakeFiles/okularpart.dir/ui/tocmodel.o: In function `TOCModel::metaObject() const': /media/d/workspaces/kde/okular/tocmodel.moc:70: multiple definition of `TOCModel::metaObject() const' CMakeFiles/okularpart.dir/ui/tocsearchmodel.o:/media/d/workspaces/kde/okular/tocmodel.moc:70: first defined here CMakeFiles/okularpart.dir/ui/tocmodel.o:(.data.rel.ro+0x0): multiple definition of `TOCModel::staticMetaObject' CMakeFiles/okularpart.dir/ui/tocsearchmodel.o:(.data.rel.ro+0x0): first defined here CMakeFiles/okularpart.dir/ui/tocmodel.o: In function `TOCModel::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)': /media/d/workspaces/kde/okular/tocmodel.moc:44: multiple definition of `TOCModel::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)' CMakeFiles/okularpart.dir/ui/tocsearchmodel.o:/media/d/workspaces/kde/okular/tocmodel.moc:44: first defined here CMakeFiles/okularpart.dir/ui/tocmodel.o: In function `TOCModel::qt_metacall(QMetaObject::Call, int, void**)': /media/d/workspaces/kde/okular/tocmodel.moc:83: multiple definition of `TOCModel::qt_metacall(QMetaObject::Call, int, void**)' CMakeFiles/okularpart.dir/ui/tocsearchmodel.o:/media/d/workspaces/kde/okular/tocmodel.moc:83: first defined here CMakeFiles/okularpart.dir/ui/tocmodel.o:(.data.rel.ro+0x10): multiple definition of `TOCModel::staticMetaObjectExtraData' CMakeFiles/okularpart.dir/ui/tocsearchmodel.o:(.data.rel.ro+0x10): first defined here CMakeFiles/okularpart.dir/ui/tocsearchmodel.o: In function `TOCSearchModel::TOCSearchModel(Okular::Document*, QObject*)': tocsearchmodel.cpp:(.text+0x10f8): undefined reference to `vtable for TOCSearchModel' CMakeFiles/okularpart.dir/ui/tocsearchmodel.o: In function `TOCSearchModel::~TOCSearchModel()': tocsearchmodel.cpp:(.text+0x120c): undefined reference to `vtable for TOCSearchModel' collect2: error: ld returned 1 exit status Hi tocsearch.moc and tocsearchmodel.moc should be automatically created from tocsearch.h and tocsearchmodel.h, respectively. I would then use a clean build folder before trying to compile everything again. regards Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 310227] Okular does not open TGA files if libqtga.so is present
https://bugs.kde.org/show_bug.cgi?id=310227 --- Comment #4 from Bogdan Cristea crist...@gmail.com --- sorry, I have forgotten to check for qtga library existence. On my system, openSUSE 12.2, where libqtga.so is present, the attached file cannot be opened. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 310227] Okular does not open TGA files if libqtga.so is present
https://bugs.kde.org/show_bug.cgi?id=310227 Bogdan Cristea crist...@gmail.com changed: What|Removed |Added CC||crist...@gmail.com --- Comment #3 from Bogdan Cristea crist...@gmail.com --- okular 0.15.70 opens this file -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Settings separation: observer.h install and compilation correction on Windows
On Nov. 1, 2012, 4:36 p.m., Albert Astals Cid wrote: I am sincerely not sure observer.h is ready for prime time installation, i mean, it has a global list of ids/priorities hardcoded in it, maybe we should rework the ids so that you can register yourself and get your id back? About the priorities i guess we could rename them to be less okularpart specific? What do you think? Before I start to code, I would like to discuss the best approach. Hard coded IDs should be removed, so I propose to use instead Observers defined as singletons. When the observer is created an unique ID is generated (since all observers have a common base, one could use a static data member defined in the base class in order to generate unique IDs). On Nov. 1, 2012, 4:36 p.m., Albert Astals Cid wrote: conf/settings.kcfgc, line 7 http://git.reviewboard.kde.org/r/107047/diff/2/?file=92392#file92392line7 SettingsCore is part of libokularcore, so using OKULAR_EXPORT is fine, no? settings_core.h exposes methods found in okularcore library, while settings.h exposes methods found in okularpart library. In Windows, when the second library is build, settings_core.h should import its symbols, while settings.h should export them. For Linux there is no problem since all library symbols are exported by default. - Bogdan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/#review21327 --- On Oct. 26, 2012, 7:57 a.m., Bogdan Cristea wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/ --- (Updated Oct. 26, 2012, 7:57 a.m.) Review request for Okular. Description --- This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows): - after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols - add definitions needed to activate these switches on Windows Diffs - CMakeLists.txt 063778f active/components/CMakeLists.txt 19b759e conf/settings.kcfgc 5e2ec95 okular_part_export.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107047/diff/ Testing --- yes Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 299526] Create empty settings object if none is created from outside okular core library
https://bugs.kde.org/show_bug.cgi?id=299526 Bogdan Cristea crist...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Links shown by cmake after configuring okular
On my system I get the following message at the end of cmake process: The following OPTIONAL packages could NOT be located on your system. Consider installing them to enable more features from this software. - * ActiveApp (0.1 or higher) https://projects.kde.org/projects/extragear/base/plasma-mobile Support for developing applications for Plasma Active * KActivities (6.1.0 or higher) https://projects.kde.org/projects/kde/kdelibs/kactivities Activities interface library Required for Activities integration. What is the purpose of the above two links, using them in a browser generates an error message, while trying to clone using them gives the same error. I would rather prefer to have links to master branches of these two packages. regards -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Links shown by cmake after configuring okular
On Monday 29 October 2012 19:04:52 Albert Astals Cid wrote: Forgot to add, can you please check that the urls still fail for you? Maybe it was a temporary hickup of projects.kde.org ? Yes, they work now. Thanks -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request: Settings separation: observer.h install and compilation correction on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/ --- Review request for Okular. Description --- This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows): - after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols - add definitions needed to activate these switches on Windows Diffs - CMakeLists.txt 063778f active/components/CMakeLists.txt 19b759e conf/settings.kcfgc 5e2ec95 okular_part_export.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107047/diff/ Testing --- yes Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request: Settings separation: observer.h install and compilation correction on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/ --- Review request for Okular. Description --- This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows): - after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols - add definitions needed to activate these switches on Windows Diffs - CMakeLists.txt 063778f active/components/CMakeLists.txt 19b759e conf/settings.kcfgc 5e2ec95 okular_part_export.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107047/diff/ Testing --- yes Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Settings separation: observer.h install and compilation correction on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107047/ --- (Updated Oct. 26, 2012, 7:57 a.m.) Review request for Okular. Changes --- corrected exported symbol in okular_part_export.h for Unix Description --- This patch is related to settings separation for the frontend and the backend. It proposes the installation of core/observer.h and corrects compilation of okular on Windows (using KDE on windows): - after separation, settings.h and settings_core.h need to use different precompiler switches for exporting/importing symbols - add definitions needed to activate these switches on Windows Diffs (updated) - CMakeLists.txt 063778f active/components/CMakeLists.txt 19b759e conf/settings.kcfgc 5e2ec95 okular_part_export.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107047/diff/ Testing --- yes Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Split active app desktop file
On Sunday 21 October 2012 22:44:59 Albert Astals Cid wrote: That doesn't really help with the problem since you can't embed C++ code in a .desktop file No, but you could use this in a cmake lists file instead of a cmake switch as you said previously. -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Split active app desktop file
On Sunday 21 October 2012 23:35:52 Albert Astals Cid wrote: I don't think it makes mush sense either, it'd mean distributions would have to build the binary for the touch code in a touch enabled server? I mean that okular active must rely on an API in order to use the touch screen, so one could use the same API and query for touch screen availability with cmake. -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Split active app desktop file
On Monday 22 October 2012 00:21:33 Albert Astals Cid wrote: The active (touch) code needs to be able to be compiled in a server (as distributions do). So you can't do any assumption on the host environment/hardware doing the compiation versus the target environment/hardware. Well, I guess in this case okular active should be build anyway, maybe a check could be performed when okular active is launched in order to warn the user if no touch support is available. -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Split active app desktop file
On Friday 19 October 2012 17:46:01 Albert Astals Cid wrote:
One would say that on desktop you want okular to have a higher initial
preference and the reverse on touch systems, but how do we do that? with a
cmake switch?
You could test this with a cpp file called from cmake (provided that
QtMobility is available), something like this
bool hasTouch() {
QSystemDeviceInfo systemInfo;
QSystemDeviceInfo::InputMethodFlags flags = systemInfo.inputMethodType();
return ((flags (QSystemDeviceInfo::SingleTouch |
QSystemDeviceInfo::MultiTouch)) != 0) ? true : false;
}
--
Bogdan
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated Oct. 6, 2012, 12:49 p.m.) Review request for Okular. Changes --- Corrected update file (okular.upd) for settings separation. kconf_update creates empty keys in the new groups even if in the old config file these keys don't exist. This behavior seems not to correspond to the behavior described in the help page (http://techbase.kde.org/Development/Tools/Using_kconf_update#Example_update_file). Since empty keys are created a script is used to remove empty keys. Again, an unexpected behavior, if the same config file is used as input/output for the script nothing happens. Thus an intermediate file is used during update (okularpartrc2). Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs (updated) - CMakeLists.txt a057e82 conf/okular.kcfg 9174733 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 143d598 core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.upd PRE-CREATION okular_sep_settings.pl PRE-CREATION ui/pagepainter.cpp 537e5c5 ui/pageview.cpp 2ef10a1 ui/presentationwidget.cpp 9ba942b Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
On Oct. 6, 2012, 6:12 p.m., Albert Astals Cid wrote: Hmmm, having that perl script seems an ugly workaround, i'll see if we can get kconf_update fixed thanks for the work so far :-) Indeed, it is not the best solution. Please let me know if I can help with kconf_update. - Bogdan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review20017 --- On Oct. 6, 2012, 12:49 p.m., Bogdan Cristea wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated Oct. 6, 2012, 12:49 p.m.) Review request for Okular. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs - CMakeLists.txt a057e82 conf/okular.kcfg 9174733 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 143d598 core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.upd PRE-CREATION okular_sep_settings.pl PRE-CREATION ui/pagepainter.cpp 537e5c5 ui/pageview.cpp 2ef10a1 ui/presentationwidget.cpp 9ba942b Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] merging the mart/okularActive branch into master
On Saturday 29 September 2012 15:53:57 Albert Astals Cid wrote: El Divendres, 28 de setembre de 2012, a les 22:04:32, Aaron J. Seigo va escriure: Hi... Hi I would like to merge the mart/okularActive branch into okular master so that we can more easily take advantage of improvements in the master branch as well as make the touch based application more readily accessible to people. I thought that it was agreed back when Marco announced the code that this would end up in a different repo. Any reason why you no longer agree with that? Cheers, Albert right now in the branch, all the added code is in a subdirectory called active. this may not be optimal, as there is already a directory called ui, which is obviously for the desktop client. it may make sense to having something like ui/desktop and ui/touch directories, but then there is also the shell/ directory which contains the desktop application which uses the contents of ui/. so i'm not sure what the most natural arrangement would be in the eyes of the okular team. the code in the active/ subdirectory produces two things: 1) a QML component for okular 2) a full touch based application in the style of Plasma Active, assuming that the necessary dependencies are installed. i think it may also make sense to add a switch to the top level cmake, off by default assuming most people are still building for the desktop, which enables the build of the application in point 2 above. i think there is value in always building the QML component, however, as that lets applications even on the desktop which may use QML for these purposes easily access okular for document rendering. i'm willing to do the work implied by the above, if you can let me know: * if a merge into master OK to you * the best directory structure in your opinion i'm not on the okular-devel list, so please CC me in replies. thanks. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel Hi There is a request for better separation of okular backend and frontend (currently under review and hopefully soon integrated into okular). You could consider using okular core library instead for okular active. regards -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated Sept. 26, 2012, 8:25 p.m.) Review request for Okular. Changes --- Fixed issue related to settings update with kconf_update. Also added observer.h to the list of installed (public) headers. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs (updated) - CMakeLists.txt a057e82 conf/okular.kcfg 9174733 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 7f006e6 core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.upd PRE-CREATION ui/pagepainter.cpp 537e5c5 ui/pageview.cpp 496abdc ui/presentationwidget.cpp 9ba942b Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
On Sept. 26, 2012, 9:14 p.m., Albert Astals Cid wrote: If we are not going to change it to a different file, do we really need the upd file? Yes, because some keys belong now to different groups. However, if we decide to change also the settings file name, that will imply only a minor change in the part.cpp (as specified above), but I see this change unnecessary. - Bogdan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review19480 --- On Sept. 26, 2012, 8:25 p.m., Bogdan Cristea wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated Sept. 26, 2012, 8:25 p.m.) Review request for Okular. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs - CMakeLists.txt a057e82 conf/okular.kcfg 9174733 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 7f006e6 core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.upd PRE-CREATION ui/pagepainter.cpp 537e5c5 ui/pageview.cpp 496abdc ui/presentationwidget.cpp 9ba942b Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 307387] Add to Mendeley option
https://bugs.kde.org/show_bug.cgi?id=307387 Bogdan Cristea crist...@gmail.com changed: What|Removed |Added CC||crist...@gmail.com --- Comment #4 from Bogdan Cristea crist...@gmail.com --- This idea is interesting, but I would open a feature request at Mendeley. Since okular is open source for them it might be much feasible to add such feature to okular. Other option is to use a truly open source project, like, aigaion. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] [Bug 298561] okular 0.14.2 on KDE 4.8.2 fails to open chm files: No plugin for mimetype 'application/octet-stream'
On Friday 21 September 2012 16:11:19 you wrote: https://bugs.kde.org/show_bug.cgi?id=298561 --- Comment #31 from Albert Astals Cid aa...@kde.org --- This patch is wrong. application/x-chm and application/vnd.ms-htmlhelp are the same thing as described by freedesktop.org.xml shared mime package Hi application/x-pdf is declared as an alias for application/pdf in freedesktop.org.xml and still it is present in libokularGenerator_poppler.desktop as MimeType=application/x-pdf;application/pdf;application/x-wwf; Also if I remove application/vnd.ms-htmlhelp from libokularGenerator_chmlib.desktop and I open a chm file, the application never enters into CHMGenerator::loadDocument(), while with the proposed patch this method is reached. regards -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] [Bug 298561] okular 0.14.2 on KDE 4.8.2 fails to open chm files: No plugin for mimetype 'application/octet-stream'
On Friday 21 September 2012 20:33:08 Albert Astals Cid wrote: P.S: Why did you move this to the mailing list and not continue the discussion in the bug itself? Because I was expecting a lengthy discussion and in the bug I would put only the conclusion of this discussion. Anyway, your last comment should be enough for the bug itself. -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 298561] okular 0.14.2 on KDE 4.8.2 fails to open chm files: No plugin for mimetype 'application/octet-stream'
https://bugs.kde.org/show_bug.cgi?id=298561 --- Comment #28 from Bogdan Cristea crist...@gmail.com --- I have been able to go one step further by changing in libokularGenerator_chm.desktop so that MimeType=application/x-chm;application/vnd.ms-htmlhelp; Now, when I open the attached chm file I get the error: Could not start process Unable to create io-slave: klauncher said: 'Error loading kio_msits' I am using openSUSE 12.1, x86_64, and okular is compiled from sources (master branch) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 298561] okular 0.14.2 on KDE 4.8.2 fails to open chm files: No plugin for mimetype 'application/octet-stream'
https://bugs.kde.org/show_bug.cgi?id=298561
--- Comment #29 from Bogdan Cristea crist...@gmail.com ---
In my previous comment I have forgotten to mention the the install path was in
the home folder ${okular_srs}/bin and the env variable KDEDIRS has been set,
then kbuildsyscoca4 has been run. In this configuration kio_msits.so is not
found even if it is installed under ${okular_srs}/bin folder.
I have also compiled okular using CMAKE_INSTALL_PREFIX=/usr and this time I
have been able to open the attached chm file. Not sure why with a local
installation folder chm files are not opened.
I have attached a patch against the sources from master which seems to solve
this issue on openSUSE 12.1 x86_64
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 298561] okular 0.14.2 on KDE 4.8.2 fails to open chm files: No plugin for mimetype 'application/octet-stream'
https://bugs.kde.org/show_bug.cgi?id=298561 --- Comment #30 from Bogdan Cristea crist...@gmail.com --- Created attachment 74056 -- https://bugs.kde.org/attachment.cgi?id=74056action=edit patch for opening chm files on openSUSE -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] okular with chm support
On Sunday 16 September 2012 15:22:02 Albert Astals Cid wrote: Which site? http://okular.kde.org/download.php I am using a local folder under which all okular files are installed and I have set KDEDIRS environment variable. However I am unable to open chm files, but pdf and epub files are opened. Is there something else I should do ? Did cmake say chm was found? Yes, both required and optional packages are found. regards -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] okular with chm support
On Sunday 16 September 2012 07:10:02 Albert Astals Cid wrote: I see you there, to be honest i'm quite puzzled as to why you decided to open a new thread on the mailing list. Sorry, I think it is a problem with my e-mail client. On my PC this mesage seem not be sent.regards -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] okular with chm support
Hi I am trying to compile okular with chm support on openSUSE 12.1, x86_64. I have followed the instructions found on kde site, I am using a local folder under which all okular files are installed and I have set KDEDIRS environment variable. However I am unable to open chm files, but pdf and epub files are opened. Is there something else I should do ? regards -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated Aug. 26, 2012, 7:31 p.m.) Review request for Okular. Changes --- Add okular.upd file. However, it seems that on update even empty keys are created into okularpartrc. Further tests needed. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs (updated) - CMakeLists.txt 31d0da5 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp f6bf699 core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.upd PRE-CREATION ui/pagepainter.cpp 537e5c5 ui/pageview.cpp 25dc63b ui/presentationwidget.cpp 37523e8 Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated Aug. 26, 2012, 7:31 p.m.) Review request for Okular. Changes --- Add okular.upd file. However, it seems that on update even empty keys are created into okularpartrc. Further tests needed. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs (updated) - CMakeLists.txt 31d0da5 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp f6bf699 core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.upd PRE-CREATION ui/pagepainter.cpp 537e5c5 ui/pageview.cpp 25dc63b ui/presentationwidget.cpp 37523e8 Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 298561] okular 0.14.2 on KDE 4.8.2 fails to open chm files: No plugin for mimetype 'application/octet-stream'
https://bugs.kde.org/show_bug.cgi?id=298561 Bogdan Cristea crist...@gmail.com changed: What|Removed |Added CC||crist...@gmail.com --- Comment #26 from Bogdan Cristea crist...@gmail.com --- Tested on openSUSE 12.1, x86_64, with Qt 4.7.4 and KWin 4.7.2, release 5. Okular compiled from sources, master branch, chmlib and chmlib-devel installed. Able to open a pdf document, but not the attached chm file. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 19, 2012, 7:23 p.m.) Review request for Okular. Changes --- removed all references from part.cpp to SettingsCore Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs (updated) - CMakeLists.txt 0034cf3 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 0ebc34e core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 ui/pagepainter.cpp ca55e81 ui/pageview.cpp 4be5e6b ui/presentationwidget.cpp a3b8be4 Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
On June 18, 2012, 8:59 p.m., Albert Astals Cid wrote: Why did you add a new patch file instead of updating the review request? It makes it kind of difficult to continue the review if we have the code splitting in two different places, can you update the review request patch, please? My changes were insignificant, anyway I have submitted a new patch. - Bogdan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review14866 --- On June 19, 2012, 7:23 p.m., Bogdan Cristea wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 19, 2012, 7:23 p.m.) Review request for Okular. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs - CMakeLists.txt 0034cf3 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 0ebc34e core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 ui/pagepainter.cpp ca55e81 ui/pageview.cpp 4be5e6b ui/presentationwidget.cpp a3b8be4 Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 17, 2012, 10:27 p.m.) Review request for Okular. Changes --- this file is the second patch to apply on the previous one on order to answer your comments. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs - CMakeLists.txt 0034cf3 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 0ebc34e core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.spec PRE-CREATION part.cpp 4c6aac8 ui/pagepainter.cpp ca55e81 ui/pageview.cpp 4be5e6b ui/presentationwidget.cpp a3b8be4 Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
On June 5, 2012, 8:35 p.m., Albert Astals Cid wrote: part.cpp, line 286 http://git.reviewboard.kde.org/r/104947/diff/3/?file=66271#file66271line286 Are you sure we need all this SettingsCore calls here? Seems a bit weird they are needed if Settings inherits from SettingsCore, no? Bogdan Cristea wrote: The problem is that the back end uses only SettingsCore class to manage settings and has no ideea of what is above, so in part.cpp both classes, Settings and SettingsCore should be managed. On the other hand, the front end needs to access all settings from a single access point (the instance of Settings class), so Settings class should be derived from SettingsCore. Albert Astals Cid wrote: Why? Settings *is* a SettingsCore, so I don't see the need of creating one if you are already creating a Settings. Indeed, it is possible to remove from part.cpp all references to SettingsCore. I have checked also that the settings are correctly saved and restored. - Bogdan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review14433 --- On June 17, 2012, 10:27 p.m., Bogdan Cristea wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 17, 2012, 10:27 p.m.) Review request for Okular. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs - CMakeLists.txt 0034cf3 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 0ebc34e core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.spec PRE-CREATION part.cpp 4c6aac8 ui/pagepainter.cpp ca55e81 ui/pageview.cpp 4be5e6b ui/presentationwidget.cpp a3b8be4 Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
On June 5, 2012, 8:35 p.m., Albert Astals Cid wrote: part.cpp, line 286 http://git.reviewboard.kde.org/r/104947/diff/3/?file=66271#file66271line286 Are you sure we need all this SettingsCore calls here? Seems a bit weird they are needed if Settings inherits from SettingsCore, no? The problem is that the back end uses only SettingsCore class to manage settings and has no ideea of what is above, so in part.cpp both classes, Settings and SettingsCore should be managed. On the other hand, the front end needs to access all settings from a single access point (the instance of Settings class), so Settings class should be derived from SettingsCore. - Bogdan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review14433 --- On June 3, 2012, 8:30 p.m., Bogdan Cristea wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 3, 2012, 8:30 p.m.) Review request for Okular. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs - CMakeLists.txt 0034cf3 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 0ebc34e core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.spec PRE-CREATION part.cpp 4c6aac8 ui/pagepainter.cpp ca55e81 ui/pageview.cpp 4be5e6b ui/presentationwidget.cpp a3b8be4 Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 3, 2012, 8:28 p.m.) Review request for Okular. Changes --- Settings class is derived from SettingsCore Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs - CMakeLists.txt 0034cf3 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings_core.kcfgc PRE-CREATION core/document.cpp 0ebc34e core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 part.cpp 4c6aac8 ui/pagepainter.cpp ca55e81 ui/pageview.cpp 4be5e6b ui/presentationwidget.cpp a3b8be4 Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 3, 2012, 8:30 p.m.) Review request for Okular. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs (updated) - CMakeLists.txt 0034cf3 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 0ebc34e core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.spec PRE-CREATION part.cpp 4c6aac8 ui/pagepainter.cpp ca55e81 ui/pageview.cpp 4be5e6b ui/presentationwidget.cpp a3b8be4 Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
On May 22, 2012, 10:48 p.m., Albert Astals Cid wrote: Hmmm, having a bad feeling about this, have you actually checked that changing the memory usage level from the config dialog still works? You were correct, Settings class needs to be derived from SettingsCore in order to have all settings options available for KConfigManager. I have tested with these changes and I am able to modify the memory usage level, but still unsure if this is working as expected (the option appears in the configuration file). Note that currently in part.cpp both classes (Settings and SettingsCore) need to be initialized even if Settings is derived from SettingsCore. Since both classes use the same configuration file, I am not sure if there could be an interference between the two, or different files should be used. Anyway, more testing needs to be done. - Bogdan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review14067 --- On June 3, 2012, 8:30 p.m., Bogdan Cristea wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 3, 2012, 8:30 p.m.) Review request for Okular. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs - CMakeLists.txt 0034cf3 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings.kcfgc 0b70390 conf/settings_core.kcfgc PRE-CREATION core/document.cpp 0ebc34e core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 okular.spec PRE-CREATION part.cpp 4c6aac8 ui/pagepainter.cpp ca55e81 ui/pageview.cpp 4be5e6b ui/presentationwidget.cpp a3b8be4 Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated May 16, 2012, 4:38 p.m.) Review request for Okular. Changes --- Full patch proposed for settings separation. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs (updated) - CMakeLists.txt 0034cf3 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings_core.kcfgc PRE-CREATION core/document.cpp 0ebc34e core/script/kjs_fullscreen.cpp c07ac4e core/texteditors_p.h 171dc69 part.cpp 4c6aac8 ui/pagepainter.cpp ca55e81 ui/pageview.cpp 4be5e6b ui/presentationwidget.cpp a3b8be4 Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
On May 15, 2012, 9:38 p.m., Albert Astals Cid wrote: Why is EnableCompositing in core if it is only used in ui? It belongs to Dlg Performance group, same as MemoryLevel entry which is used in core, because I have tried to keep groups intact. If that is ok, I could split the groups too, using as group name in the core something like Core Performance instead of Dlg Performance. It seems to be rather easy to split everything if the respective entry is used or not in the core. I'll submit another patch with these changes if you agree with splitting groups also. - Bogdan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review13868 --- On May 14, 2012, 5:29 p.m., Bogdan Cristea wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated May 14, 2012, 5:29 p.m.) Review request for Okular. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs - CMakeLists.txt 0034cf3 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings_core.kcfgc PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- Review request for Okular. Description --- Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files: -okular.kcfg (front end) -okular_core.kcfg (back end) Diffs - CMakeLists.txt 0034cf3 conf/okular.kcfg 6ad0e19 conf/okular_core.kcfg PRE-CREATION conf/settings_core.kcfgc PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104947/diff/ Testing --- No Thanks, Bogdan Cristea ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 299526] Create empty settings object if none is created from outside okular core library
https://bugs.kde.org/show_bug.cgi?id=299526 --- Comment #3 from Bogdan Cristea crist...@gmail.com --- That could be even better. Maybe we could create some documentation about the available settings. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Make fails with lates repo files
On Monday 07 May 2012 13:48:06 Costash wrote: I have attached the output of make here [0]. I mention that I am at the following commit: fd03f48 2012-05-05 | Fix z-order handling of annotations in PDFs Before this commit it worked fine. Distribution is Ubuntu 12.04. [0]: http://pastebin.com/yasUsBLs I have no problem compiling on my openSUSE 12.1 x86_64. Maybe you need to clean your build folder first. Try to delete completely the build folder, then change to build, do 'cmake ..' and make. Check for errors/warnings when using cmake. -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 299526] Create empty settings object if none is created from outside okular core library
https://bugs.kde.org/show_bug.cgi?id=299526 Bogdan Cristea crist...@gmail.com changed: What|Removed |Added Version|unspecified |0.14.80 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 299526] Create empty settings object if none is created from outside okular core library
https://bugs.kde.org/show_bug.cgi?id=299526 --- Comment #1 from Bogdan Cristea crist...@gmail.com --- Created attachment 70906 -- https://bugs.kde.org/attachment.cgi?id=70906action=edit create empty settings object if none is created from outside okular core library -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 299526] Create empty settings object if none is created from outside okular core library
https://bugs.kde.org/show_bug.cgi?id=299526 Bogdan Cristea crist...@gmail.com changed: What|Removed |Added CC||crist...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Tile rendering model at Akademy
On Tuesday 01 May 2012 15:31:11 Mailson Lira wrote: a friend encouraged me to give a talk at Akademy about the work of tiled rendering in Okular. I don't know much about the event so I'm asking you guys if there's place for presentations like this at the event. I believe it's an interesting topic but since I never went to a KDE event, I don't know what other people would think about it. It's always a good ideea of sharing your knowledge. Please let us know when your presentation is available. -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Better separation of okular core library from the frontend
On Sunday 29 April 2012 15:19:24 Albert Astals Cid wrote: Yes, as i said the okularcore library is not designed for use in other frontends, and yes, this are shortcomings i already knew of. Do you plan working on fixing them? Yes, I am interested in fixing this problem. I am developing an e-book reader for active plasma, so having a backend for handling e-documents would be for us the best approach. Okular team might be also interested in this project, since it tries to provide an e-book reader to touch enabled devices. Okular has little support for this. https://projects.kde.org/projects/playground/edu/ebookreader -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Better separation of okular core library from the frontend
On Sunday 29 April 2012 15:33:00 Pino Toscano wrote: This has always been the case: Document does not asks for pixmaps on its own, but it does on behalf of PixmapRequest's sent by the observers. When a pixmap for a page is available, Document notifies the observers about that and they will act accordingly. Please also note that this part (observers) is not totally public API, especially (as already said) the public okularcore API is currently taylored for generator plugins, not really for users of Document. Again, when using only the okular core library this seems pointless. Given that this is the pixmap generation workflow, it is not pointless at all. Yes, I agree with you that it makes sense to use the observers, but observer header is not made public. I have reasoned from the point of view of someone trying to use okular core library as a backend. So, make public observer header and ensure some mechanism for pixmap manipulation. -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Get a pointer to a pixmap of the current page
On Friday 27 April 2012 23:39:48 Albert Astals Cid wrote: El Divendres, 27 d'abril de 2012, a les 19:26:31, Bogdan Cristea va escriure: Hi I would like to use okular core library for my own e-book reader (https://projects.kde.org/projects/playground/edu/ebookreader). As far as I have understood the main classes for document manipulation are Document and Page. In Page class there is a method hasPixmap(), but how can I get a pointer to that pixmap ? Using the private _o_nearestPixmap function. Yes, but this is a private method, I still need to change the sources in order to get access to page pixmap. My reader uses QLabels on which QPixmaps are put with setPixmap() method. Is there any other way allowing to interface my QLabel widget with okular core library ? The okular core library is nor really structured to be used by anyone other renderer program (it is structure so you can plug backends but not so much for frontends). If you want to work on that feel free to drop by #okular and have a chat. I'll try to do that. Cheers, Albert thanks ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Better separation of okular core library from the frontend
Hi The latest sources for okular contain a call to Settings::instance() method in Part constructor which seems to be mandatory even when using only okular core library. Please ensure a better separation of okular core library from the frontend. Below is the code snipped I use: Settings::instance(); Document doc(NULL); With previous versions of okular the first line is not needed (the instance method does not even exist). Latest version use this call and the Document constructor needs an instance of the Settings class in order to continue. Same problem for the observers: I need to add a custom observer in order to check if the page has a pixmap if(false == page-hasPixmap(MY_OBSERVER_ID, -1, -1)) and to make pixmap requests PixmapRequest *pr = new PixmapRequest(MY_OBSERVER_ID, page-number(), page- width(), page-height(), 0, false); Again, when using only the okular core library this seems pointless. regards -- Bogdan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Get a pointer to a pixmap of the current page
Hi I would like to use okular core library for my own e-book reader (https://projects.kde.org/projects/playground/edu/ebookreader). As far as I have understood the main classes for document manipulation are Document and Page. In Page class there is a method hasPixmap(), but how can I get a pointer to that pixmap ? My reader uses QLabels on which QPixmaps are put with setPixmap() method. Is there any other way allowing to interface my QLabel widget with okular core library ? thanks -- Bogdan Cristea Software Engineer tel: +33 (0)6 21 64 15 81 web: http://sites.google.com/site/cristeab/ ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
