[Okular-devel] [okular] [Bug 326087] Wishlist: forward search and line highlighting

2014-08-23 Thread Ciro Santilli
https://bugs.kde.org/show_bug.cgi?id=326087

Ciro Santilli ciro.santi...@gmail.com changed:

   What|Removed |Added

 CC||ciro.santi...@gmail.com

--- Comment #3 from Ciro Santilli ciro.santi...@gmail.com ---
Possible duplicate of: https://bugs.kde.org/show_bug.cgi?id=240315

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 240315] Visual feedback for okular forward search

2014-08-23 Thread Ciro Santilli
https://bugs.kde.org/show_bug.cgi?id=240315

Ciro Santilli ciro.santi...@gmail.com changed:

   What|Removed |Added

 CC||ciro.santi...@gmail.com

--- Comment #3 from Ciro Santilli ciro.santi...@gmail.com ---
I think SyncTeX gives a rectangle of the page on it's output, which makes this
even easier (could not find documentation for it's output format...):

x:155.464050
y:112.982956
h:89.292244
v:117.964276
W:416.691071
H:16.936472

This feature is also present in Texmaker.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 173264] Add hotkey for Change colors

2014-04-20 Thread Ciro Santilli
https://bugs.kde.org/show_bug.cgi?id=173264

--- Comment #11 from Ciro Santilli ciro.santi...@gmail.com ---
@Albert we could select the most useful ones until we run out =)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 327641] Show navigation panel setting is not read from config file at startup

2013-11-19 Thread Ciro Santilli
https://bugs.kde.org/show_bug.cgi?id=327641

--- Comment #7 from Ciro Santilli ciro.santi...@gmail.com ---
Do you also reproduce my current behaviour Kane?

The behaviour described in the link  is consistent with what I observe,
although the description is not as detailed.

I tried going back one commit before the patch and behaviour seems the same to
the current,  so it seems that it is not that patch which introduced it.

Still, that issue does seem related. Maybe I am not compiling reinstalling
incorrectly. Have you tried to go back one commit before that one to see if it
was it that introduced the current bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 327641] Show navigation panel setting is not read from config file at startup

2013-11-18 Thread Ciro Santilli
https://bugs.kde.org/show_bug.cgi?id=327641

--- Comment #5 from Ciro Santilli ciro.santi...@gmail.com ---
I made my tests by calling Okular directly from a shell with local files as
`okular filename.pdf`, so I think at least in my case it is not related to
Konqueror.

This happens to me if I compile from a recent git source:

 commit 4f077ed54bb3092ac65c4ce7023c8932708cd389
Author: l10n daemon script scri...@kde.org
Date:   Fri Nov 15 04:25:44 2013 +

SVN_SILENT made messages (.desktop file)

installed with a `sudo make install` on Ubuntu 13.10. This shows version
0.17.60

Same happens for the Ubuntu 13.10 package which also shows version 0.17.60.

KDE version: 4.11.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 327641] New: Navigation / left panel setting is read from config file

2013-11-15 Thread Ciro Santilli
https://bugs.kde.org/show_bug.cgi?id=327641

Bug ID: 327641
   Summary: Navigation / left panel setting is read from config
file
Classification: Unclassified
   Product: okular
   Version: unspecified
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: ciro.santi...@gmail.com

The setting related to Show Navigation Panel (F7 default shortcut) seems not to
be read from the  okularpartrc config file at startup.

Test:

- start with an empty config/okularpartrc
- start okular
- hit F7 once
- OK: the navigation panel disappears. [Main View] ShowLeftPanel=false appears
on the rc

- close okular
- restart okular
- Expected:  Navigation panel is not there.
- Actual: Navigation panel is there.

- Hit F7.
- Expected: Navigation panel disappears. `ShowLeftPanel=false`
- Actual: Navigation panel is there. `ShowLeftPanel=false` disappears from rc
file.

- Hit F7 again.
- OK: Navigation panel disappears. `ShowLeftPanel=false` appears on the rc
file.

The setting is  used mostly under part.cpp and is called `ShowLeftPanel`. What
intrigues me the most is that `ShowBottomBar` has very similar code to it but
it works. 

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 327641] Navigation / left panel setting is not read from config file at startup

2013-11-15 Thread Ciro Santilli
https://bugs.kde.org/show_bug.cgi?id=327641

Ciro Santilli ciro.santi...@gmail.com changed:

   What|Removed |Added

Summary|Navigation / left panel |Navigation / left panel
   |setting is read from config |setting is not read from
   |file|config file at startup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 327641] Show navigation panel setting is not read from config file at startup

2013-11-15 Thread Ciro Santilli
https://bugs.kde.org/show_bug.cgi?id=327641

Ciro Santilli ciro.santi...@gmail.com changed:

   What|Removed |Added

Summary|Navigation / left panel |Show navigation panel
   |setting is not read from|setting is not read from
   |config file at startup  |config file at startup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 113434: Added default shortcut Ctrl + I for change colors.

2013-10-26 Thread Ciro Santilli

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113434/
---

(Updated Oct. 26, 2013, 9:44 a.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Bugs: 173264
http://bugs.kde.org/show_bug.cgi?id=173264


Repository: okular


Description
---

Added default shortcut Ctrl + I for change colors.

This should have the exact same of clicking the toolbox Settigs  Configure 
Okular  Accessibility  Change colors and then clicking Ok, therefore changing 
the saved configs.

I am not sure if:

- viewport()-update() is the right way to update the screen after this config 
change? Where is the `update()` method defined? If I tracked well, viewport() 
returns a DocumentViewport, which does not seem to have such a method.

- I placed the new feature in the right class

but it seems to work.


Diffs
-

  ui/pageview.h fd4e3ac 
  ui/pageview.cpp a1ab5bd 

Diff: http://git.reviewboard.kde.org/r/113434/diff/


Testing
---


Thanks,

Ciro Santilli

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 266157] Accessibility improvment - change document colors

2013-10-25 Thread Ciro Santilli
https://bugs.kde.org/show_bug.cgi?id=266157

Ciro Santilli ciro.santi...@gmail.com changed:

   What|Removed |Added

 CC||ciro.santi...@gmail.com

--- Comment #1 from Ciro Santilli ciro.santi...@gmail.com ---
Duplicate of https://bugs.kde.org/show_bug.cgi?id=173264

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 173264] Add hotkey for Change colors

2013-10-25 Thread Ciro Santilli
https://bugs.kde.org/show_bug.cgi?id=173264

--- Comment #2 from Ciro Santilli ciro.santi...@gmail.com ---
Created attachment 83100
  -- https://bugs.kde.org/attachment.cgi?id=83100action=edit
pacth fix

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 173264] Add hotkey for Change colors

2013-10-25 Thread Ciro Santilli
https://bugs.kde.org/show_bug.cgi?id=173264

Ciro Santilli ciro.santi...@gmail.com changed:

   What|Removed |Added

 CC||ciro.santi...@gmail.com

--- Comment #3 from Ciro Santilli ciro.santi...@gmail.com ---
Sorry for double post, first patch and I have just figured that the patch
comment goes to the devel list...

Added default shortcut Ctrl + I for change colors.

This should have the exact same of clicking the toolbox Settigs  Configure
Okular  Accessibility  Change colors and then Ok, therefore changing the
saved configs.

I am not sure if:

-  viewport()-update() is the right way to update the screen after this config
change?

Where is the `update()` method defined? If I tracked well, viewport()
returns a DocumentViewport, which does not seem to have such a method.

- did I put things in the right place

but it seems to work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] Review Request 113434: Added default shortcut Ctrl + I for change colors.

2013-10-25 Thread Ciro Santilli

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113434/
---

Review request for Okular.


Bugs: 173264
http://bugs.kde.org/show_bug.cgi?id=173264


Repository: okular


Description
---

Added default shortcut Ctrl + I for change colors.

This should have the exact same of clicking the toolbox Settigs  Configure 
Okular  Accessibility  Change colors and then clicking Ok, therefore changing 
the saved configs.

I am not sure if:

- viewport()-update() is the right way to update the screen after this config 
change? Where is the `update()` method defined? If I tracked well, viewport() 
returns a DocumentViewport, which does not seem to have such a method.

- I placed the new feature in the right class

but it seems to work.


Diffs
-

  ui/pageview.h fd4e3ac 
  ui/pageview.cpp a1ab5bd 

Diff: http://git.reviewboard.kde.org/r/113434/diff/


Testing
---


Thanks,

Ciro Santilli

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel