D15691: Add unarchiver support for cbr files
fb updated this revision to Diff 44463. fb added a comment. - Fix unar not recognizing subfolder I think you mean unar is faulty here. Yes, it seems that unar is unable to extract the files in a directory without the subfolder from the archive. I only tested comics without a subfolder so I didnt't encounterd this problem until now. The -D option for unar doesn't seem to to anything useful here, so I removed it. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15691?vs=43886=44463 BRANCH unar-patch REVISION DETAIL https://phabricator.kde.org/D15691 AFFECTED FILES .gitignore generators/comicbook/document.cpp generators/comicbook/unrar.cpp generators/comicbook/unrar.h generators/comicbook/unrarflavours.cpp generators/comicbook/unrarflavours.h To: fb Cc: aacid, okular-devel, ngraham
D15691: Add unarchiver support for cbr files
fb updated this revision to Diff 43886. fb edited the summary of this revision. fb added a comment. Okay, I added the virtual functions and created the ProcessArgs type, for a better structure of the processed arguments. These variables will then be used by the startSyncProcess function. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15691?vs=42137=43886 BRANCH unar-patch REVISION DETAIL https://phabricator.kde.org/D15691 AFFECTED FILES .gitignore generators/comicbook/document.cpp generators/comicbook/unrar.cpp generators/comicbook/unrar.h generators/comicbook/unrarflavours.cpp generators/comicbook/unrarflavours.h To: fb Cc: aacid, okular-devel, ngraham
D15691: Add unarchiver support for cbr files
fb edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15691 To: fb Cc: aacid, okular-devel, ngraham
D15691: Add unarchiver support for cbr files
fb updated this revision to Diff 42137. fb added a comment. removed .gitignore file REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15691?vs=42134=42137 BRANCH unar-patch REVISION DETAIL https://phabricator.kde.org/D15691 AFFECTED FILES .gitignore generators/comicbook/document.cpp generators/comicbook/unrar.cpp generators/comicbook/unrar.h generators/comicbook/unrarflavours.cpp generators/comicbook/unrarflavours.h To: fb Cc: okular-devel, ngraham, aacid
D15691: Add unarchiver support for cbr files
fb updated this revision to Diff 42134. fb added a comment. - rm gitignore REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15691?vs=42133=42134 BRANCH unar-patch REVISION DETAIL https://phabricator.kde.org/D15691 AFFECTED FILES .gitignore generators/comicbook/document.cpp generators/comicbook/unrar.cpp generators/comicbook/unrar.h generators/comicbook/unrarflavours.cpp generators/comicbook/unrarflavours.h To: fb Cc: okular-devel, ngraham, aacid
D15691: Add unarchiver support for cbr files
fb updated this revision to Diff 42133. fb added a comment. - rm gitignore REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15691?vs=42131=42133 BRANCH unar-patch REVISION DETAIL https://phabricator.kde.org/D15691 AFFECTED FILES .gitignore generators/comicbook/document.cpp generators/comicbook/unrar.cpp generators/comicbook/unrar.h generators/comicbook/unrarflavours.cpp generators/comicbook/unrarflavours.h To: fb Cc: okular-devel, ngraham, aacid
D15691: Add unarchiver support for cbr files
fb created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. fb requested review of this revision. REVISION SUMMARY FEATURE: 339370 REPOSITORY R223 Okular BRANCH unar-patch REVISION DETAIL https://phabricator.kde.org/D15691 AFFECTED FILES .gitignore generators/comicbook/document.cpp generators/comicbook/unrar.cpp generators/comicbook/unrar.h generators/comicbook/unrarflavours.cpp generators/comicbook/unrarflavours.h To: fb Cc: okular-devel, ngraham, aacid
