[okular] [Bug 491607] New: create indexes for pdfs that don't have any
https://bugs.kde.org/show_bug.cgi?id=491607 Bug ID: 491607 Summary: create indexes for pdfs that don't have any Classification: Applications Product: okular Version: 24.05.2 Platform: Neon OS: Linux Status: REPORTED Severity: wishlist Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.tlus...@gmail.com Target Milestone: --- SUMMARY There is a lot of pdfs out there that are pretty long, but don't have an index/overview. It would be awesome if okular would provide a visual way to create such an index. One possible way would be to use annotions or something similar to mark headers, then export these annotations into a file that then can be used to create an index. Or, do all of it within okular. SOFTWARE/OS VERSIONS Operating System: KDE neon 6.0 KDE Plasma Version: 6.1.3 KDE Frameworks Version: 6.4.0 Qt Version: 6.7.2 Kernel Version: 6.5.0-45-generic (64-bit) Graphics Platform: Wayland Processors: 6 × AMD Ryzen 5 4500U with Radeon Graphics Memory: 15,0 GiB of RAM Graphics Processor: AMD Radeon Graphics Manufacturer: Acer Product Name: Aspire A515-44G System Version: V1.12 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 484547] Does not show drop down menu in formular
https://bugs.kde.org/show_bug.cgi?id=484547 --- Comment #2 from Martin --- (In reply to Albert Astals Cid from comment #1) > Are you clicking on the arrow of the combo box? (right hand side in the > regular style) Ah now I see, the button with the arrow for point 5 is just not rendered (See Attachment). -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 484547] New: Does not show drop down menu in formular
https://bugs.kde.org/show_bug.cgi?id=484547 Bug ID: 484547 Summary: Does not show drop down menu in formular Classification: Applications Product: okular Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- Created attachment 167812 --> https://bugs.kde.org/attachment.cgi?id=167812&action=edit Okular no drop down *** If you're not sure this is actually a bug, instead post about it at https://discuss.kde.org If you're reporting a crash, attach a backtrace with debug symbols; see https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports *** SUMMARY https://bundeswahlleiterin.de/europawahlen/2024/informationen-waehler/unionsbuerger.html STEPS TO REPRODUCE 1. Open the following document in okular: https://bundeswahlleiterin.de/dam/jcr/d975b44c-d57d-439a-b290-7ff6b956ccb4/euwo_anlage-2a_ausfuellbar.pdf 2. Check for point 5 in formulae mode OBSERVED RESULT No drop down menu EXPECTED RESULT Drop down menu like in firefox SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 478644] New: svg file association
https://bugs.kde.org/show_bug.cgi?id=478644 Bug ID: 478644 Summary: svg file association Classification: Applications Product: okular Version: 21.12.3 Platform: Kubuntu OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: kdebugzi...@perfugium.net Target Milestone: --- SUMMARY okular is associated with default opening of svg file types, but it shows the vector image as xml text only, not exactly as expected... STEPS TO REPRODUCE 1. install kubuntu, don't change anything 2. download some svg and open it via its default association - okular 3. try to imaging the image out of shown xml... OBSERVED RESULT above EXPECTED RESULT not being associated with a file it can't properly show. SOFTWARE/OS VERSIONS Operating System: Kubuntu 22.04 KDE Plasma Version: 5.24.7 KDE Frameworks Version: 5.92.0 Qt Version: 5.15.3 Kernel Version: 5.15.0-91-generic (64-bit) Graphics Platform: X11 ADDITIONAL INFORMATION -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 467324] Feature Request: Stamp annotations with fixed length/width ratio
https://bugs.kde.org/show_bug.cgi?id=467324 Reuben Martin changed: What|Removed |Added CC||reube...@gmail.com --- Comment #2 from Reuben Martin --- It also needs to re-draw the image in real time within the dotted outline so that you can preview scale and placement while dragging. This lack of aspect locking and preview makes for a very clunky stamp tool. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 443404] Mousewheel scroll does not work in full page size and non-continous mode for some mouses
https://bugs.kde.org/show_bug.cgi?id=443404 --- Comment #18 from Martin Fernau --- (In reply to an.inbox from comment #17) > Hi all, the issue is related to the use of the Logitech dongle. When using > Bluetooth there is no problem. > > I use the same mouse (Logitech M2S) on two machines. The laptop came first, > using BT: never had a problem. > Then I installed a PC, same OS (Debian Bookworm) but I got this same issue. > This PC has no BT so I used the dongle and this is when the scrolling issue > in okular appeared. > If I use the dongle on the laptop, there's a problem there too. > So those you can use BT, use BT as a work-around. > > So I don't know the reason for this, but the issue only comes when using the > mouse with its dongle. And it's only okular having this issue, only in page > mode. Okular in continuous mode or all other applications are OK. That's great! I've switched to BT (never did that because of laziness) and now this annoying "bug" is gone. Thanks for this hint! -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 468647] Character not printed correctly
https://bugs.kde.org/show_bug.cgi?id=468647 --- Comment #5 from Martin --- I can confirm that the issue is fixed in development nightly (master) Version 23.07.70 Thank you very much! -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 468647] Character not printed correctly
https://bugs.kde.org/show_bug.cgi?id=468647 Martin changed: What|Removed |Added Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO |--- -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 468647] Character not printed correctly
https://bugs.kde.org/show_bug.cgi?id=468647 --- Comment #3 from Martin --- No exactly. If you go on the homepage and dowmload the paper and open it with firefox, the symbols are shown correctly. Just when you open in okular it is not correct -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 468647] New: Character not printed correctly
https://bugs.kde.org/show_bug.cgi?id=468647 Bug ID: 468647 Summary: Character not printed correctly Classification: Applications Product: okular Version: unspecified Platform: Microsoft Windows OS: Microsoft Windows Status: REPORTED Severity: normal Priority: NOR Component: PDF backend Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- Created attachment 158186 --> https://bugs.kde.org/attachment.cgi?id=158186&action=edit Wrong character in formula SUMMARY Okular shows a wrong character in formula STEPS TO REPRODUCE 1. Open the pdf document can be found on https://www.analog.com/en/analog-dialogue/articles/ask-the-applications-engineer-25.html 2. Compare first image on page 19 with the first image on the website OBSERVED RESULT In the formula next to the image is a "almost equal" sign, but okular shows a circle with a plus in it (see attachment) EXPECTED RESULT SOFTWARE/OS VERSIONS PDF Backend 0.6.5, Using Poppler: 23.01.0 Windows: 11 Okular version: 23.03.70 ADDITIONAL INFORMATION -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 428922] Back Button should go back in history
https://bugs.kde.org/show_bug.cgi?id=428922 --- Comment #2 from Martin --- I confirm that the bug exists in Okular Version 21.12.3. Reproduction: Open PDF, click on hyperlink going to a page (eg to the References section), click on Alt+Left Expected: go to last visited paper Actual: go to n-1 page. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 428922] Back Button should go back in history
https://bugs.kde.org/show_bug.cgi?id=428922 Martin changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- CC||martin.monper...@gnieh.org -- You are receiving this mail because: You are the assignee for the bug.
Re: Runtime error "you need to call Settings::instance before using"
Am Samstag, 25. Februar 2023, 11:41:42 CET schrieb Albert Astals Cid: > Why are you adding PDF only options to the general config file and general > config dialog instead of to the PDF generator config file and PDF generator > config dialog/page? Moved the configuration to the Backend Configuration, looks now like this: https://invent.kde.org/martin-de/okular/uploads/82757d49a7fe7daa4ffa872f5f6ca4b6/Screenshot_20230225_144426.png It seems to work now: the configuration is saved and can be retrieved and set as default before printing, and the print dialog no longer crashes after invoking it. Should I create a merge request now? Cheers, Martin
[okular] [Bug 463732] Print Dialog should remember PDF Options
https://bugs.kde.org/show_bug.cgi?id=463732 Martin Schnitkemper changed: What|Removed |Added CC|martin.schnitkemper@nexgo.d | |e | -- You are receiving this mail because: You are the assignee for the bug.
Runtime error "you need to call Settings::instance before using"
Hello, I tried to extend okular to save PDF-Print-Options (wish #463732). All works well so far, I added a new item in the configuration dialog and the new variable "PageScaleMode" is written to and read from "okularpartrc", but I am not able to assign the value of "Okular::Settings::pageScaleMode" to "m_scaleMode->setCurrentIndex" in module "generator_pdf.cpp". Compilation is successful, but it crashes on runtime after opening the print dialog. Message on terminal is "you need to call Settings::instance before using". I am not too familiar with C++ coding and it is my first try to extend an application. I inspected already the other modules of the project where the developers used "Okular::Settings::" in a similar & working way, but I could not find out so far, where the instance has been set for a proper usage. Can anyone tell me what I missed, or guide me to a code example of the okular project where I can see how to get right access to the "Okular::Settings::"? Thank you in advance for your support, Martin
[okular] [Bug 375649] Possibility to change the theme of okular
https://bugs.kde.org/show_bug.cgi?id=375649 Martin changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |NOT A BUG --- Comment #1 from Martin --- This is related to Qt and not to okular -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 463732] Print Dialog should remember PDF Options
https://bugs.kde.org/show_bug.cgi?id=463732 --- Comment #6 from Martin Schnitkemper --- (In reply to Nate Graham from comment #4) > This would work for the scaling option, since it's added by Okular. But it > would not work for any other options that come from the basic dialog itself. > So if we did this, we'd go from "nothing is remembered" to "random options > are remembered, but most aren't". You have a point with that. Perhaps one possibility would be to let the user specify in the application's configuration dialog which option he would like to start the dialog with. Then it is clear that it is not the last selected option that becomes the default, but explicitly the option specified by the user. For me, the scaling option is not that important, we just had a discussion in a German newsgroup about how to change the behavior, and I didn't see an option there. For anyone who suffers from the current behavior, I can provide a patch that defaults to the third item in the list instead of the first. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 463732] Print Dialog should remember PDF Options
https://bugs.kde.org/show_bug.cgi?id=463732
--- Comment #3 from Martin Schnitkemper ---
Sorry, it seems to be decided in the function "PDFOptionsPage" of
"generators/poppler/generator_pdf.cpp":
| m_scaleMode = new QComboBox;
| m_scaleMode->insertItem(FitToPrintableArea, i18n("Fit to printable area"),
FitToPrintableArea);
| m_scaleMode->insertItem(FitToPage, i18n("Fit to full page"), FitToPage);
| m_scaleMode->insertItem(None, i18n("None; print original size"), None);
| m_scaleMode->setToolTip(i18n("Scaling mode for the printed pages"));
| printBackendLayout->addRow(i18n("Scale mode:"), m_scaleMode);
So the return value of "m_scaleMode" should be saved and reloaded as default.
--
You are receiving this mail because:
You are the assignee for the bug.
[okular] [Bug 463732] Print Dialog should remember PDF Options
https://bugs.kde.org/show_bug.cgi?id=463732
Martin Schnitkemper changed:
What|Removed |Added
CC||martin.schnitkemper@nexgo.d
||e
--- Comment #2 from Martin Schnitkemper ---
I'm not the expert, but the decision is made in core/printoptionswidget.cpp:
| {
| setWindowTitle(i18n("Print Options"));
| QFormLayout *layout = new QFormLayout(this);
| m_ignorePrintMargins = new QComboBox;
| // value indicates whether full page is enabled (i.e. print margins
ignored)
| m_ignorePrintMargins->insertItem(0, i18n("Fit to printable area"),
false);
| m_ignorePrintMargins->insertItem(1, i18n("Fit to full page"), true);
| layout->addRow(i18n("Scale mode:"), m_ignorePrintMargins);
| }
Then it should be possible to store the return value ("true" or "false") as a
status in ~/.config/okularrc and when opening the dialog again,
read the value and set it as default.
--
You are receiving this mail because:
You are the assignee for the bug.
[okular] [Bug 443404] Mousewheel scroll does not work in full page size and non-continous mode for some mouses
https://bugs.kde.org/show_bug.cgi?id=443404 --- Comment #15 from Martin Fernau --- I've the same problem since switching to kubuntu 22.04 (coming from 20.04) My mouse is a logitech M720 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 443404] Mousewheel scroll does not work in full page size and non-continous mode for some mouses
https://bugs.kde.org/show_bug.cgi?id=443404 Martin Fernau changed: What|Removed |Added CC||mar...@martin-fernau.de -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 443882] popup menu of highlighted text does not appear on right click in text selection mode
https://bugs.kde.org/show_bug.cgi?id=443882 Martin changed: What|Removed |Added CC||martin.monper...@gnieh.org --- Comment #14 from Martin --- For Okular version 21.12.3, I confirm that this works in "browse" mode. The bug only happens in "text selection" mode. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 367959] Okular mangles some characters (non embedded fonts)
https://bugs.kde.org/show_bug.cgi?id=367959 --- Comment #16 from Martin --- Comment on attachment 149550 --> https://bugs.kde.org/attachment.cgi?id=149550 Micro Character not shown correctly okular: Version 22.03.70 OS: Win10 https://res.cloudinary.com/openmicrolab/raw/upload/v1487645777/hs_usb_pdg_r1_0_zjnjtx.pdf -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 367959] Okular mangles some characters (non embedded fonts)
https://bugs.kde.org/show_bug.cgi?id=367959 Martin changed: What|Removed |Added CC||martin.marmso...@gmail.com --- Comment #15 from Martin --- Created attachment 149550 --> https://bugs.kde.org/attachment.cgi?id=149550&action=edit Micro Character not shown correctly -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 431687] Okular rotates text boxes created by other PDF readers
https://bugs.kde.org/show_bug.cgi?id=431687 --- Comment #11 from Martin --- It is also possible to reproduce using only Okular. When having a pdf (see Attachment "Original Not rotated") and rotating it and saving afterwards. When reopening the pdf it is still rotated. Now create a new note and then the note is rotated as the original rotation (see Attachment "RotatedAndSaved"). -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 431687] Okular rotates text boxes created by other PDF readers
https://bugs.kde.org/show_bug.cgi?id=431687 --- Comment #10 from Martin --- Created attachment 139387 --> https://bugs.kde.org/attachment.cgi?id=139387&action=edit RotatedAndSaved -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 431687] Okular rotates text boxes created by other PDF readers
https://bugs.kde.org/show_bug.cgi?id=431687 Martin changed: What|Removed |Added CC||martin.marmso...@gmail.com --- Comment #9 from Martin --- Created attachment 139386 --> https://bugs.kde.org/attachment.cgi?id=139386&action=edit Original Not rotated Original document not rotated. When placing a Note the orientation is correct -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 332271] search scrolls to wrong position not showing highlighted text with Trim Margins enabled
https://bugs.kde.org/show_bug.cgi?id=332271 --- Comment #4 from Martin Koller --- checking with https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=&ved=2ahUKEwip0eCelaXvAhVSVhoKHaEHD-oQFjABegQIARAD&url=https%3A%2F%2Fcatonmat.net%2Fftp%2Frfbproto.pdf&usg=AOvVaw2TKuAOq3dRhx8n9GD3UEa0 the bug is still there. Tested on: Operating System: openSUSE Tumbleweed 20210306 KDE Plasma Version: 5.21.1 KDE Frameworks Version: 5.79.0 Qt Version: 5.15.2 Kernel Version: 5.11.2-1-default OS Type: 64-bit Graphics Platform: X11 Processors: 4 × Intel® Core™ i5-6300U CPU @ 2.40GHz Memory: 15,5 GiB of RAM Graphics Processor: Mesa DRI Intel® HD Graphics 520 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 426171] Text not recognized correctly
https://bugs.kde.org/show_bug.cgi?id=426171 Martin changed: What|Removed |Added CC||martin.marmso...@gmail.com --- Comment #1 from Martin --- Created attachment 131411 --> https://bugs.kde.org/attachment.cgi?id=131411&action=edit Testdocument Here the testdocument -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 426171] New: Text not recognized correctly
https://bugs.kde.org/show_bug.cgi?id=426171 Bug ID: 426171 Summary: Text not recognized correctly Product: okular Version: unspecified Platform: Other OS: Other Status: REPORTED Severity: normal Priority: NOR Component: PDF backend Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- Created attachment 131410 --> https://bugs.kde.org/attachment.cgi?id=131410&action=edit Comparsion Okular and Firefox PDF Reader SUMMARY When creating a PDF with Autodesk Eagle 9.6 the text in the pdf is not selectable as expected. See screenshot. Therefore it is also not possible to search for parts like "R2" STEPS TO REPRODUCE 1. Create pdf from Autodesk Eagle 9.6 2. Open in Okular 3. Try to search for a text OBSERVED RESULT It is not possible to find "R2" in the pdf with Okular, but with Firefox it is possible EXPECTED RESULT It is possible to select "R2" and being able to find them when searching for it. SOFTWARE/OS VERSIONS Okular version: 1.11.70 Windows: Windows 10 KDE Frameworks 5.71.0 Qt 5.15.0 (kompiliert gegen 5.15.0) Das windows Fenstersystem -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 425597] Annotation Toolbar not shown
https://bugs.kde.org/show_bug.cgi?id=425597 Martin changed: What|Removed |Added Status|NEEDSINFO |RESOLVED --- Comment #5 from Martin --- Seems to fix the problem. Thank you! -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 425597] Annotation Toolbar not shown
https://bugs.kde.org/show_bug.cgi?id=425597 --- Comment #2 from Martin --- No it is not. The problem is also that in the menu action for showing and hiding only the rectangle is visible, but not "Annotation Toolbar" (Next to the action to show and hide the main toolbar). In the flatpak package it is fine. It is hard to make a screenshot of a menu action. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 425598] New: Quick Annotations more accessible
https://bugs.kde.org/show_bug.cgi?id=425598 Bug ID: 425598 Summary: Quick Annotations more accessible Product: okular Version: 1.11.0 Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- Created attachment 131044 --> https://bugs.kde.org/attachment.cgi?id=131044&action=edit Quick Annotations access SUMMARY First thank you for the great toolbar. It looks really promising and it is easy to change the properties. What I think is that the Quick annotations are to much hidden. You must press on the "Quick Annotations" button to open the menu and then again on the tool you wanna have. It might be more "quick" if they are in the new annotation toolbar. Of if this toolbar gets to large maybe in there own toolbar? STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Flatpak version of Okular KDE Frameworks 5.73.0 Qt 5.14.2 (built against 5.14.2) The xcb windowing system ADDITIONAL INFORMATION -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 425597] New: Annotation Toolbar not shown
https://bugs.kde.org/show_bug.cgi?id=425597 Bug ID: 425597 Summary: Annotation Toolbar not shown Product: okular Version: 1.11.0 Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- SUMMARY In Okular 1.11.0 under Arch Linux no annotation toolbar is shown, even when pressing F6. The menu item changes from selected to not selected, but the toolbar it self does not appear. KDE Frameworks 5.73.0 Qt 5.15.0 (built against 5.15.0) The xcb windowing system STEPS TO REPRODUCE 1. Open pdf 2. Enable Browse Tool 3. Press F6 to show annotation toolbar OBSERVED RESULT No annotation toolbar appears EXPECTED RESULT Annotation toolbar appears SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 342003] Trim margins confuses ordering of zoom steps while zooming out
https://bugs.kde.org/show_bug.cgi?id=342003 Martin Sandsmark changed: What|Removed |Added CC||martin.sandsm...@kde.org --- Comment #16 from Martin Sandsmark --- I think it was introduced by this commit: 2b971b07b2314479c59bc6ee3c382d8a869c9440 -- You are receiving this mail because: You are the assignee for the bug.
[Active] [Bug 308240] active-documentviewer crashes by using zoom gestures
https://bugs.kde.org/show_bug.cgi?id=308240 Marco Martin changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |UNMAINTAINED -- You are receiving this mail because: You are on the CC list for the bug.
[okular] [Bug 421469] Slow search
https://bugs.kde.org/show_bug.cgi?id=421469 Martin Steigerwald changed: What|Removed |Added CC||mar...@lichtvoll.de Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #1 from Martin Steigerwald --- Thank you for your report. I can confirm that search is really slow with that document on Debian Sid with Okular 20.04.0-1 using a Sandybridge based laptop (ThinkPad T520). -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 421103] Feature request: change action when clicking and double clicking on drawing tool
https://bugs.kde.org/show_bug.cgi?id=421103 --- Comment #2 from Martin --- Hi David, yes a dedicated button is also good. I'm using in the most time the persistent mode so enabling it is also good. Thanks This request can be closed. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 421102] Feature request: Ability to move tool list freely around
https://bugs.kde.org/show_bug.cgi?id=421102 --- Comment #2 from Martin --- Hi David, yes at least setting the toolbar floating is already nice. The other is not that important, because it will not be zoomed that often. So moving manually is okay :) I think you can close this request. Thank you for your great work. Okular is just amazing :) -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 421103] New: Feature request: change action when clicking and double clicking on drawing tool
https://bugs.kde.org/show_bug.cgi?id=421103 Bug ID: 421103 Summary: Feature request: change action when clicking and double clicking on drawing tool Product: okular Version: 1.9.2 Platform: Other OS: MS Windows Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- In 1.9.2 it is possible by double click on a tool to make it peristent until escape or right click is triggered. With a single click the tool is active for one action. It would be nice to have an option to change the behavior: - single click: tool is active until escape is clicked or right click - double click: tool is activated for one action. SOFTWARE/OS VERSIONS Windows: Windows 10 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 421102] New: Feature request: Ability to move tool list freely around
https://bugs.kde.org/show_bug.cgi?id=421102 Bug ID: 421102 Summary: Feature request: Ability to move tool list freely around Product: okular Version: 1.9.2 Platform: Other OS: MS Windows Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- Created attachment 128192 --> https://bugs.kde.org/attachment.cgi?id=128192&action=edit Attach tool list to page At the moment the tool list for drawing on the pdf can be moved to the four borders of the widget. It would be nice if it is possible to move it freely around, or it would be nice if it is attached to the border of the page it self, like in the attachment. So when zooming the tool list moves till it reaches the border of the widget. So the mouse distance to the tools is smaller. SOFTWARE/OS VERSIONS Windows: 10 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 401944] Copy listings created in Latex not copied properly
https://bugs.kde.org/show_bug.cgi?id=401944
Martin changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution|--- |NOT A BUG
--- Comment #5 from Martin ---
By default, the spacing between characters is made uniform so as to preserve
alignments (source:
https://tex.stackexchange.com/questions/99416/latex-source-code-listing-with-less-space-between-characters)
So this is not a problem of okular or any other library. This is to make the
listing clearer to read and the spaces are in the listing it self.
Setting "columns=fullflexible" solves the problem
\documentclass[10pt,a4paper]{article}
\usepackage[latin1]{inputenc}
\usepackage{amsmath}
\usepackage{amsfonts}
\usepackage{amssymb}
\usepackage{graphicx}
\usepackage{listings} % Syntax Highlining, Programmier sprachen
\begin{document}
\begin{lstlisting}[columns=fullflexible, language=bash,caption={Skript
um für Eclipse die Projektdateien zu erstellen}]
#!/bin/bash
sudo apt-get install libevdev-dev libglib2.0-dev
sudo apt-get install libpcre3 libpcre3-dev lzma lzma-dev
\end{lstlisting}
\end{document}
--
You are receiving this mail because:
You are the assignee for the bug.
[okular] [Bug 401944] Copy listings created in Latex not copied properly
https://bugs.kde.org/show_bug.cgi?id=401944 --- Comment #4 from Martin --- I tried with languate=C++ and it is the same. I think you are right. When I mark the text, I am able to select spaces between characters -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 420699] New: Feature Request: Split View
https://bugs.kde.org/show_bug.cgi?id=420699 Bug ID: 420699 Summary: Feature Request: Split View Product: okular Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- Sometimes you have to check a paper a few pages above the current page to compare stuff (for examples equations). For this it would be nice if a SplitView exists, which displays multiple documents side by side (regardless if it is the same or not). The benefit of a splitview instead opening the document twice is that when you change something in one paper it is directly visible in the second one, without reloading the paper (when you have two view, but only one model). Also you can use one pen for writing notes down. What do you think about? -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 401944] Copy listings created in Latex not copied properly
https://bugs.kde.org/show_bug.cgi?id=401944 --- Comment #2 from Martin --- Did you write a bugreport for poppler or should I do that? -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 419084] New: Add option to print several or all opened pdf files
https://bugs.kde.org/show_bug.cgi?id=419084 Bug ID: 419084 Summary: Add option to print several or all opened pdf files Product: okular Version: 1.9.3 Platform: Other OS: Linux Status: REPORTED Severity: wishlist Priority: NOR Component: printing Assignee: okular-devel@kde.org Reporter: mrb...@gmail.com Target Milestone: --- Sometimes it would be handy to have to the option to print several pdf files with one step. In addition to the "Print" button a "Print all" button would be helpful. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 396087] Okular stops rendering some pages, locks up at 25% CPU usage and won't die
https://bugs.kde.org/show_bug.cgi?id=396087 --- Comment #16 from Martin Bednar --- Patched okular on my Gentoo. Seems fixed. Thank you! You made the day of at least 2 people :) -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 396087] Okular stops rendering some pages, locks up at 25% CPU usage and won't die
https://bugs.kde.org/show_bug.cgi?id=396087 Martin Bednar changed: What|Removed |Added CC||martin+...@serafean.cz --- Comment #14 from Martin Bednar --- Created attachment 125514 --> https://bugs.kde.org/attachment.cgi?id=125514&action=edit PDF endless CPU usage I think I'm in the same boat with the attached PDF. Okular CPU usage never drops under 100% (on one core, I think it would take even more if it could) After a few tries it rendered completely though (CPU usage not dropping)... Poppler version 0.82.0 Okular 1.9.1 (kde-applications-19.12.1) KDE Frameworks 5.66.0 Qt 5.13.2 (built against 5.13.2) -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 411743] when review/comment tool is selected, keep it selected
https://bugs.kde.org/show_bug.cgi?id=411743 --- Comment #2 from Martin --- I confirm that double-clicking works on my box! Thanks a lot Oliver. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 411743] New: when review/comment tool is selected, keep it selected
https://bugs.kde.org/show_bug.cgi?id=411743 Bug ID: 411743 Summary: when review/comment tool is selected, keep it selected Product: okular Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin7...@gmail.com Target Milestone: --- When one annotates a PDF document, one uses a comment tool (eg pop-up notes) Today, as soon as we have used a comment tool, it is unselected, and consequently the commenting process is uneffective select comment tool leave comment select comment tool leave comment select comment tool leave comment Instead, what about keeping the comment tool selected event after usage? this way the usage is more effective: select comment tool leave comment leave comment leave comment Thanks! --Martin -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 402015] Okular prints to a local queue which alphanumerically precedes a remote destination when cups-browsed is not installed.
https://bugs.kde.org/show_bug.cgi?id=402015 Martin Steigerwald changed: What|Removed |Added Resolution|WORKSFORME |FIXED --- Comment #4 from Martin Steigerwald --- Just for the record: Michael found that it is an issue within Qt that is fixed by a certain commit written by you, Albert. So it affects other applications like Kate as well. Dmitry already builds a version of Qt with the backported commit applied. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911844#100 https://salsa.debian.org/qt-kde-team/qt/qtbase/commit/462ab1eccabcfc40 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 402015] Okular prints to a local queue which alphanumerically precedes a remote destination when cups-browsed is not installed.
https://bugs.kde.org/show_bug.cgi?id=402015 Martin Steigerwald changed: What|Removed |Added CC||mar...@lichtvoll.de, ||secur...@kde.org --- Comment #1 from Martin Steigerwald --- Adding KDE's security team to Cc. Could you have a look at the issue? If the issue can be verified it would be good to have a patch in time for Debian's buster release. I am sorry that Debian still carries a very old version of Okular (I asked on why, but did not receive a reply yet). Brian, thank you for your report. Could you please retest at least with Okular 18.04 from Debian experimental or preferably run KDE Neon¹ in a VM and retest with the most recent Okular release? Thank you. [1] https://neon.kde.org/ -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 408056] Activating edit tool automatically
https://bugs.kde.org/show_bug.cgi?id=408056 --- Comment #2 from Martin --- Thank you Oliver! Good to know it exist :) -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 408056] New: Activating edit tool automatically
https://bugs.kde.org/show_bug.cgi?id=408056 Bug ID: 408056 Summary: Activating edit tool automatically Product: okular Version: 1.5.3 Platform: Other OS: Linux Status: REPORTED Severity: wishlist Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- Every time using the "rezesion" tool (F6) it must be clicked on the toolbar to select the appropriate tool needed, even it is used multiple times. Would it be possible to make an option, so the tool isn't deselected when editing the pdf? For example for the marker it would be nice not having to click every time on the toolbar after marking a piece of text. For pop-up notes or inline notes I think it depends if somebody whishes to have it always in hand. So maybe making an option for every single tool? -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407583] New: Save as does anymore work, if the file was edited external
https://bugs.kde.org/show_bug.cgi?id=407583 Bug ID: 407583 Summary: Save as does anymore work, if the file was edited external Product: okular Version: 1.7.1 Platform: Archlinux Packages OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- SUMMARY If I have a file open and edit(or delete) the file with an external tool, I'm not able to save anymore with the save, nor with the save as option Is that intention? STEPS TO REPRODUCE 1. Open pdf file 2. Edit file with an external tool/ delete file 3. Try to save pdf. OBSERVED RESULT - save: If I delete the file, no new file is created, just get the message, that I'm not able to save. - save as: does not recreate the file EXPECTED RESULT - save: create file again in the same path with same name - save as: create file in selected path with selected name SOFTWARE/OS VERSIONS KDE Frameworks 5.57.0 Qt 5.12.3 (kompiliert gegen 5.12.2) -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 402307] New: crash when pasting clipboard into form field
https://bugs.kde.org/show_bug.cgi?id=402307 Bug ID: 402307 Summary: crash when pasting clipboard into form field Product: okular Version: unspecified Platform: openSUSE RPMs OS: Linux Status: REPORTED Keywords: drkonqi Severity: crash Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: kol...@aon.at Target Milestone: --- Application: okular (1.4.3) Qt Version: 5.9.4 Frameworks Version: 5.45.0 Operating System: Linux 4.12.14-lp150.12.28-default x86_64 Distribution: "openSUSE Leap 15.0" -- Information about the crash: - What I was doing when the application crashed: I opened the form pdf from https://formulare.bmf.gv.at/service/formulare/inter-Steuern/pdfs//E30.pdf activated to show the form fields, selected some text from a different browser window with the mouse, then clicked into the first input field and middle-clicked to paste the text -> crash The crash can be reproduced every time. -- Backtrace: Application: Okular (okular), signal: Segmentation fault Using host libthread_db library "/lib64/libthread_db.so.1". [Current thread is 1 (Thread 0x7fa12b93d340 (LWP 27377))] Thread 3 (Thread 0x7fa10b130700 (LWP 27379)): #0 0x7fa12766eb68 in read () from /lib64/libc.so.6 #1 0x7fa12236ca90 in ?? () from /usr/lib64/libglib-2.0.so.0 #2 0x7fa122327cb7 in g_main_context_check () from /usr/lib64/libglib-2.0.so.0 #3 0x7fa122328170 in ?? () from /usr/lib64/libglib-2.0.so.0 #4 0x7fa1223282dc in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0 #5 0x7fa127fa1c0b in QEventDispatcherGlib::processEvents(QFlags) () from /usr/lib64/libQt5Core.so.5 #6 0x7fa127f4a09a in QEventLoop::exec(QFlags) () from /usr/lib64/libQt5Core.so.5 #7 0x7fa127d794da in QThread::exec() () from /usr/lib64/libQt5Core.so.5 #8 0x7fa128421985 in ?? () from /usr/lib64/libQt5DBus.so.5 #9 0x7fa127d7e0ce in ?? () from /usr/lib64/libQt5Core.so.5 #10 0x7fa12465e559 in start_thread () from /lib64/libpthread.so.0 #11 0x7fa12767d81f in clone () from /lib64/libc.so.6 Thread 2 (Thread 0x7fa119a2d700 (LWP 27378)): #0 0x7fa12767307b in poll () from /lib64/libc.so.6 #1 0x7fa124a85387 in ?? () from /usr/lib64/libxcb.so.1 #2 0x7fa124a86fba in xcb_wait_for_event () from /usr/lib64/libxcb.so.1 #3 0x7fa11c7e5029 in ?? () from /usr/lib64/libQt5XcbQpa.so.5 #4 0x7fa127d7e0ce in ?? () from /usr/lib64/libQt5Core.so.5 #5 0x7fa12465e559 in start_thread () from /lib64/libpthread.so.0 #6 0x7fa12767d81f in clone () from /lib64/libc.so.6 Thread 1 (Thread 0x7fa12b93d340 (LWP 27377)): [KCrash Handler] #6 Okular::Page::number (this=this@entry=0x0) at /usr/src/debug/okular-18.04.3-lp150.1.1.x86_64/core/page.cpp:157 #7 0x7fa109718e77 in Okular::JSField::wrapField (ctx=ctx@entry=0x7fffada34658, field=, field@entry=0x556f2d7b9ba0, page=0x0) at /usr/src/debug/okular-18.04.3-lp150.1.1.x86_64/core/script/kjs_field.cpp:232 #8 0x7fa1097175a9 in eventGetTarget (ctx=0x7fffada34658, object=0x556f2d9459a0) at /usr/src/debug/okular-18.04.3-lp150.1.1.x86_64/core/script/kjs_event.cpp:73 #9 0x7fa108c1383f in ?? () from /usr/lib64/libKF5JSApi.so.5 #10 0x7fa108769d0f in KJS::JSObject::get(KJS::ExecState*, KJS::Identifier const&) const () from /usr/lib64/libKF5JS.so.5 #11 0x7fa1087801ad in ?? () from /usr/lib64/libKF5JS.so.5 #12 0x7fa108738e8b in ?? () from /usr/lib64/libKF5JS.so.5 #13 0x7fa10876e6db in ?? () from /usr/lib64/libKF5JS.so.5 #14 0x7fa10876e853 in KJS::Interpreter::evaluate(KJS::UString const&, int, KJS::UChar const*, int, KJS::JSValue*) () from /usr/lib64/libKF5JS.so.5 #15 0x7fa10876e8df in KJS::Interpreter::evaluate(KJS::UString const&, int, KJS::UString const&, KJS::JSValue*) () from /usr/lib64/libKF5JS.so.5 #16 0x7fa108c1264a in KJSInterpreter::evaluate(QString const&, int, QString const&, KJSObject*) () from /usr/lib64/libKF5JSApi.so.5 #17 0x7fa10971163f in Okular::ExecutorKJS::execute (this=this@entry=0x556f2d8d3850, script=..., event=event@entry=0x556f2d9459a0) at /usr/src/debug/okular-18.04.3-lp150.1.1.x86_64/core/script/executor_kjs.cpp:108 #18 0x7fa1096f8f90 in Okular::Scripter::execute (this=, type=, script=...) at /usr/src/debug/okular-18.04.3-lp150.1.1.x86_64/core/scripter.cpp:79 #19 0x7fa1096cab14 in Okular::Document::processAction (this=, action=0x556f2d7c4a30) at /usr/src/debug/okular-18.04.3-lp150.1.1.x86_64/core/document.cpp:4244 #20 0x7fa1096d3918 in Okular::DocumentPrivate::recalculateForms (this=0x556f2d128600) at /usr/src/debug/okular-18.04.3-lp150.1.1.x86_64/core/document.cpp:1148 #21 0x7fa1096d3dc5 in Okular::DocumentPrivate::notifyFormChanges (this=) at /usr/src/debug/okular-18.04.3-lp150.1.1.x86_64/core/document.cpp:3427 #22 0x7fa1096e72ed in Okular::EditFormTextCommand::redo (this=0x556f2d98c240) at /usr/src/debug/okula
[okular] [Bug 401944] New: Copy listings created in Latex not copied properly
https://bugs.kde.org/show_bug.cgi?id=401944
Bug ID: 401944
Summary: Copy listings created in Latex not copied properly
Product: okular
Version: 1.5.3
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: okular-devel@kde.org
Reporter: martin.marmso...@gmail.com
Target Milestone: ---
Created attachment 116825
--> https://bugs.kde.org/attachment.cgi?id=116825&action=edit
Created PDF file
SUMMARY
When copying listings produced with latex there are extra spaces between the
characters, so it is not possible to use the copied text.
STEPS TO REPRODUCE
1. Copy listing from the attached pdf or create a new pdf with the following
code:
\documentclass[10pt,a4paper]{article}
\usepackage[latin1]{inputenc}
\usepackage{amsmath}
\usepackage{amsfonts}
\usepackage{amssymb}
\usepackage{graphicx}
\usepackage{listings} % Syntax Highlining, Programmier sprachen
\begin{document}
\begin{lstlisting}[language=bash,caption={Skript um für Eclipse die
Projektdateien zu erstellen}]
#!/bin/bash
sudo apt-get install libevdev-dev libglib2.0-dev
sudo apt-get install libpcre3 libpcre3-dev lzma lzma-dev
\end{lstlisting}
\end{document}
2. Copy one line from the listing and paste it somewhere
OBSERVED RESULT
sudo apt−g e t i n s t a l l l i b e v d e v −dev l i b g l i b 2 .0− dev
EXPECTED RESULT
sudo apt-get install libevdev-dev libglib2.0-dev
SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Gnome 3.30.2, Arch Linux
KDE Frameworks 5.52.0
Qt 5.11.2 (kompiliert gegen 5.11.2)
Das xcb Fenstersystem
ADDITIONAL INFORMATION
--
You are receiving this mail because:
You are the assignee for the bug.
[okular] [Bug 357430] Okular crashed when activating “fit width”
https://bugs.kde.org/show_bug.cgi?id=357430 Martin Ueding changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO |RESOLVED --- Comment #2 from Martin Ueding --- This issue did not occur since I have reported it, so I presume that it has been fixed or not been triggered again. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 398202] provide navigation for annotations
https://bugs.kde.org/show_bug.cgi?id=398202 --- Comment #4 from Martin Corley --- Man, I'm being dense. Many thanks -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 398202] provide navigation for annotations
https://bugs.kde.org/show_bug.cgi?id=398202 --- Comment #2 from Martin Corley --- Thanks for the response. My apologies: Have used okular for years and somehow missed that(!). So then my only wish would be that this view was much flatter, to reduce the number of clicks to get to a page with an annotation. (In my dream version, text of comments would be available in the reviews panel too: cf Mendeley). -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 398202] New: provide navigation for annotations
https://bugs.kde.org/show_bug.cgi?id=398202 Bug ID: 398202 Summary: provide navigation for annotations Product: okular Version: 1.5.0 Platform: unspecified OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.cor...@ed.ac.uk Target Milestone: --- Hi, a wishlist item based on experience with Mendeley -- would it be possible to have a list of annotations (presumably in the sidebar) which could then be used to navigate to specific comments/marks? -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 397273] New: Not able to set breakpoints in other file than main.cpp
https://bugs.kde.org/show_bug.cgi?id=397273 Bug ID: 397273 Summary: Not able to set breakpoints in other file than main.cpp Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- Hello, I'm trying to import okular from git into KDevelop with cmake. Building the project with Ninja an Llvm works fine, but when I try to debug the project, lldb stops automatically without showing the window. When I set a breakpoint in the first line of the main, I'm able to go through step by step for one line. At the line with "QApplication app(argc, argv);" the debugger stops. In the debugging window is the following Message: QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-martin' qt.qpa.screen: QXcbConnection: Could not connect to display Could not connect to any X display. *** Normal beendet *** While debugging the breakpoints in the symbol column are not visible. Also when the debugging ends, the breakpoints are not visible but still are present which I see in the breakpoints tab. I already tryed to build the project with gcc (-DCMAKE_CXX_COMPILER=g++) and debugging with lldb (did not find the option to change to gdb), but it does not change anything. With qt creator I tested it too (with g++ and gdb), but there is the same problem. I used to compile the master from github from today. Best regards, Martin -- You are receiving this mail because: You are the assignee for the bug.
D12884: Remove the internal file navigation from the global drawer
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12884 To: apol, #okular, mart, aacid Cc: okular-devel, ngraham, aacid
D12770: Android: Make it possible to associate with files
mart accepted this revision. This revision is now accepted and ready to land. Restricted Application added a subscriber: okular-devel. REPOSITORY R223 Okular BRANCH filesAndroid REVISION DETAIL https://phabricator.kde.org/D12770 To: apol, #okular, aacid, mart Cc: okular-devel, ngraham, aacid
D12299: Android: include metadata for okular kirigami
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. for the icon, maybe a png version of https://cgit.kde.org/breeze-icons.git/tree/icons/apps/48/okular.svg which is the breeze icon REPOSITORY R223 Okular BRANCH okularkirigamiandroid REVISION DETAIL https://phabricator.kde.org/D12299 To: apol, #okular, mart, aacid Cc: michaelweghorn, ngraham, aacid
D12176: Turn okularkirigami into an executable
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12176 To: apol, #kirigami, #okular, mart Cc: plasma-devel, michaelweghorn, ngraham, apol, aacid, davidedmundson, mart, hein
[okular] [Bug 381405] New: Link to different document does not launch a new instance of Okular, but replaces current open document
https://bugs.kde.org/show_bug.cgi?id=381405 Bug ID: 381405 Summary: Link to different document does not launch a new instance of Okular, but replaces current open document Product: okular Version: 0.24.0 Platform: Ubuntu Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: drozdik@gmail.com Target Milestone: --- Created attachment 106169 --> https://bugs.kde.org/attachment.cgi?id=106169&action=edit Two documents wit links to each other that should open the other document in a new window. Based on this question: https://tex.stackexchange.com/questions/372181/how-to-add-a-link-that-opens-a-different-pdf-in-a-new-window Using LaTeX I generated two files (in attachment) with links to each other that should open the target document in a new window. However, instead of doing this, the target document replaces the current open document. I suspect this is a problem with okular, since Acrobat Reader 9.5.5 opens the document in a new instance as desired. -- You are receiving this mail because: You are the assignee for the bug.
Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125847/#review102537
---
it looks good to me, but I don't have a touch screen to test on unfortunately
ui/presentationwidget.cpp (line 538)
<https://git.reviewboard.kde.org/r/125847/#comment68336>
always use {}
- Martin Tobias Holmedahl Sandsmark
On Aug. 13, 2016, 7:46 p.m., Oliver Sander wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125847/
> ---
>
> (Updated Aug. 13, 2016, 7:46 p.m.)
>
>
> Review request for Okular.
>
>
> Bugs: 354012
> http://bugs.kde.org/show_bug.cgi?id=354012
>
>
> Repository: okular
>
>
> Description
> ---
>
> This patch adds support for swipe gestures to the presentation mode of
> okular. Swiping right-to-left goes to the previous page, swiping
> left-to-right goes to the next page.
>
> Notes:
>
> 1) The swipe gesture used here is a three-finger swipe, which is what the Qt
> QSwipeGesture class implements. I am not convinced that using three fingers
> is optimal here, but it is the easiest to implement. Other swiping gestures
> are possible, but you would need to implement a custom QGestureRecognizer.
> That would make the patch larger and more error-prone.
>
> 2) Swiping from left to right(!) makes the presentation mode go to the
> next(!) slide. This is the opposite direction compared to what you do when
> you flip pages in a physical book, so it may feel strange. It is, however,
> the direction used in the qt5 gesture example at
> http://doc.qt.io/qt-5/gestures-overview.html Let me know if you want the
> directions reversed.
>
> 3) By default, Qt5 synthesizes a mouse event for each unhandled touch event.
> In particular, a left mouse click is synthesized for each finger tap to the
> screen (which usually makes the presentation go to the next slide). This
> mechanism gets in the way of gesture recognition, because the first finger
> touch of your swipe gesture will already create a mouse-click and make your
> presentation go to the next page, irrespective of the swipe direction.
>
> The patch solves this problem but switching off mouse event synthesis in
> presentation mode. That's the line
>
>
> QCoreApplication::setAttribute(Qt::AA_SynthesizeMouseForUnhandledTouchEvents,false);
>
> in the constructor of PresentationWidget. This has short-term side effects.
> For example, with this, you cannot finger-touch on a movie to start it
> anymore. The fix for this would be to implement proper handling of
> QTouchEvents, which should not be difficult.
>
> An alternative would be to leave mouse event synthesis turned on, but
> implement a dummy touch event handler. This will need only a few lines of
> code, but it will not avoid the side effects mentioned above.
>
> 4) This patch applies to the 'frameworks' branch. I failed at backporting it
> to 'master'. There, the event loop would never receive any touchscreen
> events at all. This may be a Qt bug, but it may as well be my lack of
> experience.
>
>
> Diffs
> -
>
> ui/presentationwidget.h 38bb679
> ui/presentationwidget.cpp 3680de1
>
> Diff: https://git.reviewboard.kde.org/r/125847/diff/
>
>
> Testing
> ---
>
> Tested on a Thinkpad Yoga running Debian testing.
>
>
> Thanks,
>
> Oliver Sander
>
>
[okular] [Bug 375649] New: Possibility to change the theme of okular
https://bugs.kde.org/show_bug.cgi?id=375649 Bug ID: 375649 Summary: Possibility to change the theme of okular Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- Created attachment 103677 --> https://bugs.kde.org/attachment.cgi?id=103677&action=edit Okular under gnome Under gnome with a dark theme okular looks a little bit strange. A possibility to change the theme would be nice. Best pdf reader I ever used! Many cool features! -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 375648] New: Moving comments and resize inline notes
https://bugs.kde.org/show_bug.cgi?id=375648 Bug ID: 375648 Summary: Moving comments and resize inline notes Product: okular Version: unspecified Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: martin.marmso...@gmail.com Target Milestone: --- When a inline note was created and the text in it is to long, the inline note does not resize, so there is just a part of the text visible. So a possibility to resize and move the notes after creating would be a nice feature. -- You are receiving this mail because: You are the assignee for the bug.
Re: Review Request 129832: Only show warning messages by default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129832/ --- (Updated Jan. 16, 2017, 5:41 p.m.) Status -- This change has been marked as submitted. Review request for Okular and Miklós Máté. Changes --- Submitted with commit 7f3eebd9f3bc1f7fec6b33549dcf86b1fdd3c2c3 by Martin T. H. Sandsmark to branch master. Repository: okular Description --- With this debug output has to be explicitly enabled by the user through e. g. kdebugsettings. Diffs - core/debug.cpp a1df0723 generators/chm/kio-msits/kio_mits_debug.cpp 8047d34a generators/comicbook/generator_comicbook.cpp 4ac005d5 generators/dvi/generator_dvi.cpp d98d1e8f generators/epub/epubdocument.cpp 1c5bb1c8 generators/fax/fax_debug.cpp 5396daa6 generators/ooo/manifest.cpp 53ab82f8 generators/poppler/generator_pdf.cpp eb9695df generators/spectre/spectre_debug.cpp 893d47c3 generators/tiff/generator_tiff.cpp f399f33e generators/txt/document.cpp fdddfaa6 generators/xps/generator_xps.cpp c15da173 ui/debug_ui.cpp be2b3c7d Diff: https://git.reviewboard.kde.org/r/129832/diff/ Testing --- Thanks, Martin Tobias Holmedahl Sandsmark
Re: Review Request 129785: Stop debug spam in release builds
ular.core: sending request observer=0x56187c9b8210 833x1177@10 > async == true isTile == false > org.kde.okular.core: request observer=0x56187c9a19e0 108x153@10 > org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@10 > async == true isTile == false > org.kde.okular.core: request observer=0x56187c9b8210 833x1177@11 > org.kde.okular.core: sending request observer=0x56187c9b8210 833x1177@11 > async == true isTile == false > org.kde.okular.core: request observer=0x56187c9a19e0 108x153@11 > org.kde.okular.core: sending request observer=0x56187c9a19e0 108x153@11 > async == true isTile == false > org.kde.okular.core: About to save document info to > "/home/miki/.local/share/okular/docdata/269712.flowratios.pdf.xml" > No frame loaded > No frame loaded > No frame loaded > > (BTW I couldn't track down where the last three lines are printed on exit) > > The kdebugdialog5 settings have no effect on these printouts (I disabled > everything for okular, and checked "Disable all debug output" to be sure), > probably because they are qDebug and not kDebug. I have two questions about > this tool: > - How did you find it? It doesn't have a menu entry. > - Is there a difference between kdebugdialog and kdebugdialog5? > > Miklós Máté wrote: > One more thing: the debug spam from Okular is nothing compared to the > Help Center. > > Albert Astals Cid wrote: > Why are you using kdebugdialog5 when Luigi said kdebugsettings ? > > Miklós Máté wrote: > I thought they were the same thing. Now I see that there is indeed a > separate package called kdebugsettings, which is not part of the default > install. Anyways. It doesn't list Okular in the "KDE application" tab, and > "Turn Off Debug" doesn't stop Okular's debug spam (neither does it silence > khelpcenter). Do I need to add a custom rule? How? I tried > "okular.debug=false", but it didn't do anything. > > Luigi Toscano wrote: > KDebugSettings is part of KDE Applications. Is it installed in the same > environment where Okular is installed? If I compile both in my kdesrc-build > environment, kdebugsettings has Okular categories (same for KHelpCenter). If > you still some messages it's likely because it used qDebug (or still kDebug) > and it was not ported to the categorized version (qCDebug). «No frame loaded» is from kwidgetsaddons. It should be gone now: https://commits.kde.org/kwidgetsaddons/91f77834e5454dbc9a7476aa783fadc89d87ccc9 - Martin Tobias Holmedahl --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129785/#review101848 --- On Jan. 7, 2017, 12:51 p.m., Miklós Máté wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129785/ > --- > > (Updated Jan. 7, 2017, 12:51 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > Okular core prints lots of debug messages, stop that in release builds. > > > Diffs > - > > OkularConfigureChecks.cmake 70fe8768 > ui/formwidgets.cpp 7e68b5c7 > > Diff: https://git.reviewboard.kde.org/r/129785/diff/ > > > Testing > --- > > > Thanks, > > Miklós Máté > >
Review Request 129832: Only show warning messages by default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129832/ --- Review request for Okular and Miklós Máté. Repository: okular Description --- With this debug output has to be explicitly enabled by the user through e. g. kdebugsettings. Diffs - core/debug.cpp a1df0723 generators/chm/kio-msits/kio_mits_debug.cpp 8047d34a generators/comicbook/generator_comicbook.cpp 4ac005d5 generators/dvi/generator_dvi.cpp d98d1e8f generators/epub/epubdocument.cpp 1c5bb1c8 generators/fax/fax_debug.cpp 5396daa6 generators/ooo/manifest.cpp 53ab82f8 generators/poppler/generator_pdf.cpp eb9695df generators/spectre/spectre_debug.cpp 893d47c3 generators/tiff/generator_tiff.cpp f399f33e generators/txt/document.cpp fdddfaa6 generators/xps/generator_xps.cpp c15da173 ui/debug_ui.cpp be2b3c7d Diff: https://git.reviewboard.kde.org/r/129832/diff/ Testing --- Thanks, Martin Tobias Holmedahl Sandsmark
Re: Review Request 129288: Fix unused computation result warning in plucker
> On Nov. 19, 2016, 12:50 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > Which code are you working against? I fixed this in July. > > > > For reference, this code is almost verbatim from the explode tool in the > > original plucker source. The font variable is used to track whether to > > start or end a formatted string span (represented by tags in the > > explode tool). https://cgit.kde.org/okular.git/commit/?id=d9a31fa02ad92c663b3c5bd0fc5be38b09bc761f for more reference. - Martin Tobias Holmedahl --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129288/#review100941 --- On Oct. 30, 2016, 2:29 p.m., Miklós Máté wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129288/ > --- > > (Updated Oct. 30, 2016, 2:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > If we assume that the code was correct, then the pointer dereference is > unnecessary. If we assume that the code was wrong, then it probably wanted to > do (*font)--. I assumed the former, but I can't test it. > > > Diffs > - > > generators/plucker/unpluck/qunpluck.cpp 8363dd3 > > Diff: https://git.reviewboard.kde.org/r/129288/diff/ > > > Testing > --- > > > Thanks, > > Miklós Máté > >
Re: Review Request 129288: Fix unused computation result warning in plucker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129288/#review100941 --- Which code are you working against? I fixed this in July. For reference, this code is almost verbatim from the explode tool in the original plucker source. The font variable is used to track whether to start or end a formatted string span (represented by tags in the explode tool). - Martin Tobias Holmedahl Sandsmark On Oct. 30, 2016, 2:29 p.m., Miklós Máté wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129288/ > --- > > (Updated Oct. 30, 2016, 2:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > If we assume that the code was correct, then the pointer dereference is > unnecessary. If we assume that the code was wrong, then it probably wanted to > do (*font)--. I assumed the former, but I can't test it. > > > Diffs > - > > generators/plucker/unpluck/qunpluck.cpp 8363dd3 > > Diff: https://git.reviewboard.kde.org/r/129288/diff/ > > > Testing > --- > > > Thanks, > > Miklós Máté > >
[okular] [Bug 372581] New: font too big for numbers in printed forms
https://bugs.kde.org/show_bug.cgi?id=372581 Bug ID: 372581 Summary: font too big for numbers in printed forms Product: okular Version: 0.26.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: li...@drmartinus.de Target Milestone: --- I have often to do with pdf forms, and want to use okular to fill them in and then print them. However, numbers, while appearing just like other letters on the screen, are printed way too big on the printout. It seems as if they are automatically scaled to the field size, which is nonsense in my view. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 368229] [Frameworks] 'change light & dark colors' broken
https://bugs.kde.org/show_bug.cgi?id=368229 Martin Sandsmark changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit||http://commits.kde.org/okul ||ar/ff3cc05b6b0f1a7d6cbd8d80 ||b5832667f973132d --- Comment #2 from Martin Sandsmark --- Git commit ff3cc05b6b0f1a7d6cbd8d80b5832667f973132d by Martin T. H. Sandsmark. Committed on 29/10/2016 at 11:02. Pushed by sandsmark into branch 'frameworks'. Fix recoloring of inverted colors. M +3-3ui/pagepainter.cpp http://commits.kde.org/okular/ff3cc05b6b0f1a7d6cbd8d80b5832667f973132d -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 366781] [frameworks] Implement zooming with a pinch gesture on a touch screen
https://bugs.kde.org/show_bug.cgi?id=366781 Martin Sandsmark changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Latest Commit||http://commits.kde.org/okul ||ar/9d90a08ef5e22d682a5a5004 ||128f72d1a5a84aff --- Comment #3 from Martin Sandsmark --- Git commit 9d90a08ef5e22d682a5a5004128f72d1a5a84aff by Martin T. H. Sandsmark. Committed on 15/10/2016 at 13:22. Pushed by sandsmark into branch 'frameworks'. Implement zooming with a pinch gesture on a touch screen Patch by Oliver Sander REVIEW: 128821 M +49 -0ui/pageview.cpp M +5-0ui/pageview.h http://commits.kde.org/okular/9d90a08ef5e22d682a5a5004128f72d1a5a84aff -- You are receiving this mail because: You are the assignee for the bug.
Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr
> On Oct. 4, 2016, 9 p.m., Albert Astals Cid wrote: > > I honestly don't see the benefit > > > > You changed a delete by a reset, is there any benefit at all other than > > making the code harder to read? > > Oliver Sander wrote: > I see three benefits: > a) I can see by looking at the declaration of m_drawingEngine that it has > ownership semantics. IMO that's quite helpful when trying to understand new > code. > b) I don't have to call 'delete' (admittedly that's minor here, because > m_drawingEngine is deleted only once). > c) Have a look at https://git.reviewboard.kde.org/r/128858 . There I had > to introduce > > delete m_drawingEngine; > m_drawingEngine = new SmoothPathEngine( > m_currentDrawingToolElement ); > >With a unique_ptr this is simply > > m_drawingEngine = std::make_unique( > m_currentDrawingToolElement ); > > Oliver Sander wrote: > Alternatively, the last line could be > > m_drawingEngine.reset( new SmoothPathEngine( > m_currentDrawingToolElement ) ); > > which makes the intention even clearer. > > Albert Astals Cid wrote: > The code doesn't certainly seems clearer to me, but probably i'm just > old. I'll let others that are actually developing the frameworks branch > decide. I agree with Albert, tbh., to me the new code takes longer time to grok. Personally I think the conventions for member pointers in Qt and Qt-based applications are easier to grasp than smart pointer ownership semantics. And another minor personal pet peeve is that std:: APIs tend to be badly designed compared to Qt APIs (counter-intuitive naming, lots of abbreviations, some inconsistencies, and in general just not following these guidelines: http://people.mpi-inf.mpg.de/~jblanche/api-design.pdf ). In addition the std:: coding style is different from the Okular code style (e. g. snake_case). That small rant aside, I don't mind if it is merged if anyone else wants it in (but I'm not going to give it a shipit myself). I know I Qt is moving towards using and recommending using more of the standard library instead of Qt's own similar things, so I'll have to learn to love the standard library eventually. :-) - Martin Tobias Holmedahl --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129099/#review99787 --- On Oct. 4, 2016, 8:33 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129099/ > --- > > (Updated Oct. 4, 2016, 8:33 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > Because it has ownership semantics. > > The code would be even shorter with std::make_unique, but that is C++14. Is > that allowed in Okular? > > > Diffs > - > > ui/presentationwidget.h 69574d2 > ui/presentationwidget.cpp c16d616 > > Diff: https://git.reviewboard.kde.org/r/129099/diff/ > > > Testing > --- > > > Thanks, > > Oliver Sander > >
Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen
> On Oct. 2, 2016, 12:54 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > I tried to test with pinching on my touchpad, but apparently Qt doesn't > > handle the gestures from libinput or something. > > Oliver Sander wrote: > Touchpad pinching does not work for me, either. Would you expect that to > work with my patch? Or is some extra code needed? it needs a patch in qt (I started on it here: http://ix.io/1sta). - Martin Tobias Holmedahl --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review99710 --- On Oct. 2, 2016, 6:42 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128821/ > --- > > (Updated Oct. 2, 2016, 6:42 p.m.) > > > Review request for Okular. > > > Bugs: 366781 > http://bugs.kde.org/show_bug.cgi?id=366781 > > > Repository: okular > > > Description > --- > > The attached patch implements document zoom controlled by a two-finger pinch > gesture on a touch screen. > > The actual zooming was done by copy'n'paste, I don't understand the full > details of how zooming works in okular, yet. So a bit of review would be > appreciated. > > > Diffs > - > > ui/pageview.h 7c43f51 > ui/pageview.cpp 5fbabb2 > > Diff: https://git.reviewboard.kde.org/r/128821/diff/ > > > Testing > --- > > I tested it on my Lenovo Thinkpad Yoga, and it works nicely there. > > > Thanks, > > Oliver Sander > >
Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review99717 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On Oct. 2, 2016, 6:42 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128821/ > --- > > (Updated Oct. 2, 2016, 6:42 p.m.) > > > Review request for Okular. > > > Bugs: 366781 > http://bugs.kde.org/show_bug.cgi?id=366781 > > > Repository: okular > > > Description > --- > > The attached patch implements document zoom controlled by a two-finger pinch > gesture on a touch screen. > > The actual zooming was done by copy'n'paste, I don't understand the full > details of how zooming works in okular, yet. So a bit of review would be > appreciated. > > > Diffs > - > > ui/pageview.h 7c43f51 > ui/pageview.cpp 5fbabb2 > > Diff: https://git.reviewboard.kde.org/r/128821/diff/ > > > Testing > --- > > I tested it on my Lenovo Thinkpad Yoga, and it works nicely there. > > > Thanks, > > Oliver Sander > >
Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review99710 --- I tried to test with pinching on my touchpad, but apparently Qt doesn't handle the gestures from libinput or something. ui/pageview.cpp (line 1496) <https://git.reviewboard.kde.org/r/128821/#comment67036> you need to call QAbstractScrollArea::event(), not QWidget::event(), otherwise you get an infinite recursion when scrolling. - Martin Tobias Holmedahl Sandsmark On Sept. 4, 2016, 7:48 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128821/ > --- > > (Updated Sept. 4, 2016, 7:48 p.m.) > > > Review request for Okular. > > > Bugs: 366781 > http://bugs.kde.org/show_bug.cgi?id=366781 > > > Repository: okular > > > Description > --- > > The attached patch implements document zoom controlled by a two-finger pinch > gesture on a touch screen. > > The actual zooming was done by copy'n'paste, I don't understand the full > details of how zooming works in okular, yet. So a bit of review would be > appreciated. > > > Diffs > - > > ui/pageview.h 01c39bf > ui/pageview.cpp cd53407 > > Diff: https://git.reviewboard.kde.org/r/128821/diff/ > > > Testing > --- > > I tested it on my Lenovo Thinkpad Yoga, and it works nicely there. > > > Thanks, > > Oliver Sander > >
Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128858/#review99709 --- maybe try with installEventFilter(qApp) in the presentation widget, override eventFilter() and check for the tablet events in PresentationWidget and call setCursor(Qt::BlankCursor) and unsetCursor(). you could also call setOverrideCursor() and unsetOverrideCursor() in your custom QApplication, but then it's tricky to track when the presentation widget is used and I'd prefer not having a new application class just for this. - Martin Tobias Holmedahl Sandsmark On Sept. 7, 2016, 8:18 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128858/ > --- > > (Updated Sept. 7, 2016, 8:18 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > I am trying to fix the following papercut: I regularly write on pdf files in > presentation mode, using the pen that comes with my Lenovo ThinkPad Yoga. > When I approach the screen with the pen, the cursor appears, and it follows > the pen tip during writing. When I lift off the pen, the cursor stays on, > and auto-hides only a few seconds later (because of > Okular::Settings::EnumSlidesCursor::HiddenDelay). As a consequence, the > cursor frequently hides the last bits of what I have just written. This is a > nuisance, because I do this in front of an audience, and a lot of it is math > (where every detail matters). > > Ideally, the cursor would auto-hide when I lift the pen off the screen. > Luckily, Qt has an event for this: QEvent::TabletLeaveProximity. Unluckily, > the documentation says (http://doc.qt.io/qt-5/qtabletevent.html): > > "TabletEnterProximity and TabletLeaveProximity events [...] are only sent to > QApplication" > > Therefore, this patch introduces a new class TabletApplication, which > inherits from QApplication, and is used in main.cpp instead of QApplication. > The proximity events are really caught, and each time a short note is printed > on the console. > > Unfortunately, at this point I am stuck and need some help. Apparently, I > cannot control the cursor from a QApplication. How do I get the information > that a TabletProximity has been caught to the presentation widget? Maybe the > answer is trivial, but I have very little Qt programming experience. Thanks > for your help! > > > Diffs > - > > shell/CMakeLists.txt 84cbf2d > shell/main.cpp 856d2b0 > shell/tabletapplication.h PRE-CREATION > shell/tabletapplication.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128858/diff/ > > > Testing > --- > > > Thanks, > > Oliver Sander > >
Re: Review Request 128938: Rename method slotAutoScoll to slotAutoScroll
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128938/#review99511 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On Sept. 18, 2016, 6:52 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128938/ > --- > > (Updated Sept. 18, 2016, 6:52 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > The old method name contained a typo. > > > Diffs > - > > ui/pageview.h 01c39bf > ui/pageview.cpp cd53407 > > Diff: https://git.reviewboard.kde.org/r/128938/diff/ > > > Testing > --- > > > Thanks, > > Oliver Sander > >
Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen
> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ui/pageview.cpp, line 1505 > > <https://git.reviewboard.kde.org/r/128821/diff/1/?file=475893#file475893line1505> > > > > potentially uninitialized, add some default value. > > Oliver Sander wrote: > Okay. > > Anthony Fieroni wrote: > Only for clarification in C/C++, *static variables are always > initialized* this is by standard. True, but a zoom factor of 0 would not be nice. - Martin Tobias Holmedahl --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review98864 --- On Sept. 4, 2016, 3:16 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128821/ > --- > > (Updated Sept. 4, 2016, 3:16 p.m.) > > > Review request for Okular. > > > Bugs: 366781 > http://bugs.kde.org/show_bug.cgi?id=366781 > > > Repository: okular > > > Description > --- > > The attached patch implements document zoom controlled by a two-finger pinch > gesture on a touch screen. > > The actual zooming was done by copy'n'paste, I don't understand the full > details of how zooming works in okular, yet. So a bit of review would be > appreciated. > > > Diffs > - > > ui/pageview.h 01c39bf > ui/pageview.cpp cd53407 > > Diff: https://git.reviewboard.kde.org/r/128821/diff/ > > > Testing > --- > > I tested it on my Lenovo Thinkpad Yoga, and it works nicely there. > > > Thanks, > > Oliver Sander > >
Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128821/#review98876 --- Ship it! just some nitpicks, but nothing I think should block, but feel free to fix them before pushing. :-) ui/pageview.h (line 134) <https://git.reviewboard.kde.org/r/128821/#comment66575> nitpick; inconsistent spacing - Martin Tobias Holmedahl Sandsmark On Sept. 4, 2016, 3:16 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128821/ > --- > > (Updated Sept. 4, 2016, 3:16 p.m.) > > > Review request for Okular. > > > Bugs: 366781 > http://bugs.kde.org/show_bug.cgi?id=366781 > > > Repository: okular > > > Description > --- > > The attached patch implements document zoom controlled by a two-finger pinch > gesture on a touch screen. > > The actual zooming was done by copy'n'paste, I don't understand the full > details of how zooming works in okular, yet. So a bit of review would be > appreciated. > > > Diffs > - > > ui/pageview.h 01c39bf > ui/pageview.cpp cd53407 > > Diff: https://git.reviewboard.kde.org/r/128821/diff/ > > > Testing > --- > > I tested it on my Lenovo Thinkpad Yoga, and it works nicely there. > > > Thanks, > > Oliver Sander > >
Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen
> On Sept. 4, 2016, 10:14 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> > ui/pageview.cpp, line 1500
> > <https://git.reviewboard.kde.org/r/128821/diff/1/?file=475893#file475893line1500>
> >
> > Don't put assignments in the if condition.
> >
> > Also, prefer to do an early exit, i. e.
> >
> > if (!pinchGesture)
> > {
> > return false;
> > }
> >
> > or similar.
> >
> > Lastly, don't use static_cast here, it doesn't do runtime type
> > checking.
> >
> > And always prefer qobject_cast over dynamic_cast if you can (that is,
> > if you're casting QObjects). It is faster than dynamic_cast and works
> > across dynamic libraries.
>
> Oliver Sander wrote:
> I moved the assignment out of the conditional.
>
> IMO the early exit is not a good idea. Eventually, the gestureEvent
> method may support other gestures than just pinches. In that case exiting is
> not the right thing to do when the pinch variable is nulptr.
>
> The static_cast is taken from the Qt documentation (e.g.,
> http://doc.qt.io/qt-5/qtwidgets-gestures-imagegestures-example.html). As I
> understand it, event->gesture(Qt::PinchGesture) does the runtime type
> checking for you.
>
> QGestureEvents are not QObjects, there qobject_cast is not appropriate.
> IMO the early exit is not a good idea. Eventually, the gestureEvent method
> may support other gestures than just pinches. In that case exiting is not
> the right thing to do when the pinch variable is nulptr.
Fair enough. But then I guess it makes more sense to check gestureType() in the
if() and then cast inside the conditional block.
> As I understand it, event->gesture(Qt::PinchGesture) does the runtime type
> checking for you.
I'm not sure from the documentation, so I think it makes sense to check
gestureType().
> QGestureEvents are not QObjects, there qobject_cast is not appropriate.
My bad, I was looking at QPinchGesture.
- Martin Tobias Holmedahl
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/#review98864
---
On Sept. 4, 2016, 3:16 p.m., Oliver Sander wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128821/
> ---
>
> (Updated Sept. 4, 2016, 3:16 p.m.)
>
>
> Review request for Okular.
>
>
> Bugs: 366781
> http://bugs.kde.org/show_bug.cgi?id=366781
>
>
> Repository: okular
>
>
> Description
> ---
>
> The attached patch implements document zoom controlled by a two-finger pinch
> gesture on a touch screen.
>
> The actual zooming was done by copy'n'paste, I don't understand the full
> details of how zooming works in okular, yet. So a bit of review would be
> appreciated.
>
>
> Diffs
> -
>
> ui/pageview.h 01c39bf
> ui/pageview.cpp cd53407
>
> Diff: https://git.reviewboard.kde.org/r/128821/diff/
>
>
> Testing
> ---
>
> I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.
>
>
> Thanks,
>
> Oliver Sander
>
>
Re: Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/#review98864
---
I don't have a touch screen to test with, unfortunately.
ui/pageview.cpp (line 1490)
<https://git.reviewboard.kde.org/r/128821/#comment66563>
always {}
ui/pageview.cpp (line 1500)
<https://git.reviewboard.kde.org/r/128821/#comment66559>
Don't put assignments in the if condition.
Also, prefer to do an early exit, i. e.
if (!pinchGesture)
{
return false;
}
or similar.
Lastly, don't use static_cast here, it doesn't do runtime type checking.
And always prefer qobject_cast over dynamic_cast if you can (that is, if
you're casting QObjects). It is faster than dynamic_cast and works across
dynamic libraries.
ui/pageview.cpp (line 1505)
<https://git.reviewboard.kde.org/r/128821/#comment66562>
potentially uninitialized, add some default value.
ui/pageview.cpp (line 1507)
<https://git.reviewboard.kde.org/r/128821/#comment66561>
always use {}, even for oneliners.
ui/pageview.cpp (line 1510)
<https://git.reviewboard.kde.org/r/128821/#comment66560>
Why put this in a separate variable?
- Martin Tobias Holmedahl Sandsmark
On Sept. 3, 2016, 5:49 p.m., Oliver Sander wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128821/
> ---
>
> (Updated Sept. 3, 2016, 5:49 p.m.)
>
>
> Review request for Okular.
>
>
> Bugs: 366781
> http://bugs.kde.org/show_bug.cgi?id=366781
>
>
> Repository: okular
>
>
> Description
> ---
>
> The attached patch implements document zoom controlled by a two-finger pinch
> gesture on a touch screen.
>
> The actual zooming was done by copy'n'paste, I don't understand the full
> details of how zooming works in okular, yet. So a bit of review would be
> appreciated.
>
>
> Diffs
> -
>
> ui/pageview.h 01c39bf
> ui/pageview.cpp cd53407
>
> Diff: https://git.reviewboard.kde.org/r/128821/diff/
>
>
> Testing
> ---
>
> I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.
>
>
> Thanks,
>
> Oliver Sander
>
>
Re: Review Request 128805: Fix compile with MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128805/#review98795 --- Ship it! could probably switch over to std::rand as well, though. - Martin Tobias Holmedahl Sandsmark On Aug. 30, 2016, 3:57 p.m., Gleb Popov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128805/ > --- > > (Updated Aug. 30, 2016, 3:57 p.m.) > > > Review request for kdewin and Okular. > > > Repository: okular > > > Description > --- > > There is no `rand48()` in MSCRT, so use `rand()`. > > > Diffs > - > > ui/presentationwidget.cpp 850e227 > > Diff: https://git.reviewboard.kde.org/r/128805/diff/ > > > Testing > --- > > > Thanks, > > Gleb Popov > >
Re: Review Request 125847: Change pages in presentation mode by swiping on touch screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125847/#review98376 --- okular is now free of kdelibs4support and known regressions, so I guess we might get this in soon. - Martin Tobias Holmedahl Sandsmark On Aug. 13, 2016, 7:46 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125847/ > --- > > (Updated Aug. 13, 2016, 7:46 p.m.) > > > Review request for Okular. > > > Bugs: 354012 > http://bugs.kde.org/show_bug.cgi?id=354012 > > > Repository: okular > > > Description > --- > > This patch adds support for swipe gestures to the presentation mode of > okular. Swiping right-to-left goes to the previous page, swiping > left-to-right goes to the next page. > > Notes: > > 1) The swipe gesture used here is a three-finger swipe, which is what the Qt > QSwipeGesture class implements. I am not convinced that using three fingers > is optimal here, but it is the easiest to implement. Other swiping gestures > are possible, but you would need to implement a custom QGestureRecognizer. > That would make the patch larger and more error-prone. > > 2) Swiping from left to right(!) makes the presentation mode go to the > next(!) slide. This is the opposite direction compared to what you do when > you flip pages in a physical book, so it may feel strange. It is, however, > the direction used in the qt5 gesture example at > http://doc.qt.io/qt-5/gestures-overview.html Let me know if you want the > directions reversed. > > 3) By default, Qt5 synthesizes a mouse event for each unhandled touch event. > In particular, a left mouse click is synthesized for each finger tap to the > screen (which usually makes the presentation go to the next slide). This > mechanism gets in the way of gesture recognition, because the first finger > touch of your swipe gesture will already create a mouse-click and make your > presentation go to the next page, irrespective of the swipe direction. > > The patch solves this problem but switching off mouse event synthesis in > presentation mode. That's the line > > > QCoreApplication::setAttribute(Qt::AA_SynthesizeMouseForUnhandledTouchEvents,false); > > in the constructor of PresentationWidget. This has short-term side effects. > For example, with this, you cannot finger-touch on a movie to start it > anymore. The fix for this would be to implement proper handling of > QTouchEvents, which should not be difficult. > > An alternative would be to leave mouse event synthesis turned on, but > implement a dummy touch event handler. This will need only a few lines of > code, but it will not avoid the side effects mentioned above. > > 4) This patch applies to the 'frameworks' branch. I failed at backporting it > to 'master'. There, the event loop would never receive any touchscreen > events at all. This may be a Qt bug, but it may as well be my lack of > experience. > > > Diffs > - > > ui/presentationwidget.h 38bb679 > ui/presentationwidget.cpp 3680de1 > > Diff: https://git.reviewboard.kde.org/r/125847/diff/ > > > Testing > --- > > Tested on a Thinkpad Yoga running Debian testing. > > > Thanks, > > Oliver Sander > >
Re: Review Request 128673: Remove a spurious trailing semicolon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128673/#review98375 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On Aug. 13, 2016, 7:46 p.m., Oliver Sander wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128673/ > --- > > (Updated Aug. 13, 2016, 7:46 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > g++ 6.1 issues a warning for this. > > > Diffs > - > > conf/widgetdrawingtools.cpp b9e6ebc > > Diff: https://git.reviewboard.kde.org/r/128673/diff/ > > > Testing > --- > > > Thanks, > > Oliver Sander > >
[okular] [Bug 357579] Okular-15.12.0: page numbers text area not sized correctly when refreshing a document
https://bugs.kde.org/show_bug.cgi?id=357579 Martin Sandsmark changed: What|Removed |Added CC||martin.sandsm...@kde.org Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 363435] [frameworks] missing NoDisplay=true in org.kde.mobile.okular.desktop file
https://bugs.kde.org/show_bug.cgi?id=363435 Martin Sandsmark changed: What|Removed |Added CC||martin.sandsm...@kde.org Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #1 from Martin Sandsmark --- forgot to tag this with BUG, but anyways: https://quickgit.kde.org/?p=okular.git&a=commit&h=5e77764ac5608e87baf20043836ee0710f292734 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 356127] "Save as" dialog for "Save copy as": path editing widget and list widget out of sync
https://bugs.kde.org/show_bug.cgi?id=356127 Martin Sandsmark changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED CC||martin.sandsm...@kde.org --- Comment #3 from Martin Sandsmark --- Can't reproduce with the latest frameworks branch, which has had a lot of work done, so I'm marking this as resolved. Feel free to re-open if you can reproduce with a version later than ff274fdecc9d872ba8a58ed57cc29c36c30b1e89. -- You are receiving this mail because: You are the assignee for the bug.
Re: Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128435/ --- (Updated Aug. 13, 2016, 7:29 p.m.) Status -- This change has been marked as submitted. Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez. Changes --- Submitted with commit 8f86818b5cf4bffb38ce9b3f725b4c38f20df598 by Martin T. H. Sandsmark to branch frameworks. Repository: okular Description --- Without the Plasma QPA now the file open dialog just lets you select a single random filetype to view at the time. This tries to improve that, but I'm not sure if that's something you/we want? Diffs - shell/shell.cpp bca7206 Diff: https://git.reviewboard.kde.org/r/128435/diff/ Testing --- Thanks, Martin Tobias Holmedahl Sandsmark
Re: Using TabletEvent hiRes positions
Hi! Sorry for the late reply. On Thu, Jul 14, 2016 at 10:54:29AM +0200, Oliver Sander wrote: > @@ -909,7 +909,7 @@ QRect PageViewAnnotator::routeTabletEvent( QTabletEvent * > e, PageViewItem * item > // figure out the event type and button > AnnotatorEngine::decodeEvent( e, &eventType, &button ); > > -const QPointF globalPosF = e->hiResGlobalPos(); > +const QPointF globalPosF = e->globalPosF(); > [...] > Note that the patch replaces a hiRes position with a low-res one. Is this > change intentional? > Because as I understand it, the hiRes position was used for a reason, see Since Qt5 hiResGlobalPos() and globalPosF() return the same value, if you look at the code. It is also noted in the documentation and hiResGlobalPos() is marked as deprecated with a QT_DEPRECATED macro in the header. -- Martin Sandsmark
Re: Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128435/#review98165 --- This still works fine with e. g. the plasma integration plugin, no duplication of "all supported files" or whatever. So unless there's any objections I'll push it soonish. - Martin Tobias Holmedahl Sandsmark On July 17, 2016, 6:09 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128435/ > --- > > (Updated July 17, 2016, 6:09 p.m.) > > > Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez. > > > Repository: okular > > > Description > --- > > Without the Plasma QPA now the file open dialog just lets you select a single > random filetype to view at the time. This tries to improve that, but I'm not > sure if that's something you/we want? > > > Diffs > - > > shell/shell.cpp bca7206 > > Diff: https://git.reviewboard.kde.org/r/128435/diff/ > > > Testing > --- > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >
Re: [Okular-devel] Review Request 128507: Port: Open relative path again
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128507/#review97956 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On July 24, 2016, 6:04 p.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128507/ > --- > > (Updated July 24, 2016, 6:04 p.m.) > > > Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl > Sandsmark. > > > Repository: okular > > > Description > --- > > This brings back the opening of files with relative path. > > However it was written "correct this mess", and I just did a port of what was > there. Do I push it anyway? > > > Diffs > - > > CMakeLists.txt d999cbe > core/document.cpp 2f99a8c > > Diff: https://git.reviewboard.kde.org/r/128507/diff/ > > > Testing > --- > > Compiled and Tested > > > Thanks, > > Olivier Churlaud > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 128507: Port: Open relative path again
> On July 24, 2016, 2:18 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > core/document.cpp, line 4018
> > <https://git.reviewboard.kde.org/r/128507/diff/2/?file=472240#file472240line4018>
> >
> > instead use something like:
> > if (url.scheme() == "http" && url.host().isEmpty() &&
> > url.fileName().endsWith(".pdf"))
> >
> > is a bit easier to read, and handles corner cases better (with
> > fragments and paths etc).
> >
> > can probably drop the scheme() check as well?
>
> Olivier Churlaud wrote:
> i'm not sure the scheme works: we want to fit http:text and not
> http://text and I think that scheme only works with XXX://
I tested it with the PDF from the bug report, and the code I suggested works
with it. For «http://text» host() will not be empty, it should return «text».
But you should probably also check url.isRelative() (that does not match with
«http:text», however, because it is not a relative URL according to the
standard).
But the current code will fail for relative URLs with #fragments, for example,
so it should be fixed.
> On July 24, 2016, 2:18 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > core/document.cpp, line 4025
> > <https://git.reviewboard.kde.org/r/128507/diff/2/?file=472240#file472240line4025>
> >
> > why create a new QUrl?
>
> Olivier Churlaud wrote:
> It was like this in master.
No need to keep bad code from master. :-)
- Martin Tobias Holmedahl
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128507/#review97800
---
On July 23, 2016, 11:24 a.m., Olivier Churlaud wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128507/
> ---
>
> (Updated July 23, 2016, 11:24 a.m.)
>
>
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl
> Sandsmark.
>
>
> Repository: okular
>
>
> Description
> ---
>
> This brings back the opening of files with relative path.
>
> However it was written "correct this mess", and I just did a port of what was
> there. Do I push it anyway?
>
>
> Diffs
> -
>
> CMakeLists.txt d999cbe
> core/document.cpp 2f99a8c
>
> Diff: https://git.reviewboard.kde.org/r/128507/diff/
>
>
> Testing
> ---
>
> Compiled and Tested
>
>
> Thanks,
>
> Olivier Churlaud
>
>
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 128507: Port: Open relative path again
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128507/#review97800
---
core/document.cpp (line 4018)
<https://git.reviewboard.kde.org/r/128507/#comment65906>
instead use something like:
if (url.scheme() == "http" && url.host().isEmpty() &&
url.fileName().endsWith(".pdf"))
is a bit easier to read, and handles corner cases better (with fragments
and paths etc).
can probably drop the scheme() check as well?
core/document.cpp (line 4025)
<https://git.reviewboard.kde.org/r/128507/#comment65907>
why create a new QUrl?
core/document.cpp (line 4032)
<https://git.reviewboard.kde.org/r/128507/#comment65908>
maybe a better comment would be "KRun autodeletes"?
- Martin Tobias Holmedahl Sandsmark
On July 23, 2016, 11:24 a.m., Olivier Churlaud wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128507/
> ---
>
> (Updated July 23, 2016, 11:24 a.m.)
>
>
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl
> Sandsmark.
>
>
> Repository: okular
>
>
> Description
> ---
>
> This brings back the opening of files with relative path.
>
> However it was written "correct this mess", and I just did a port of what was
> there. Do I push it anyway?
>
>
> Diffs
> -
>
> CMakeLists.txt d999cbe
> core/document.cpp 2f99a8c
>
> Diff: https://git.reviewboard.kde.org/r/128507/diff/
>
>
> Testing
> ---
>
> Compiled and Tested
>
>
> Thanks,
>
> Olivier Churlaud
>
>
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
