D22145: Add "Open Containing Folder" feature
shubham added a comment. Shouldn't this be below Open Recent? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22145 To: ngraham, #okular, aacid, sander Cc: shubham, davidhurka, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid
D10859: Improve layout of annotation configuration dialogs
shubham added inline comments. INLINE COMMENTS > annotationwidgets.cpp:818 > +QWidget * widget = (QWidget*)formlayout->parent(); > + > +addColorButton( widget, formlayout ); Why not qobject_cast? REPOSITORY R223 Okular BRANCH fix-annot-config-dialog REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg, ngraham Cc: shubham, davidhurka, aacid, okular-devel, knambiar, ngraham, joaonetto, tfella, darcyshen
D21730: Pass gridLayout pointer to createStyleWidget
shubham added inline comments.
INLINE COMMENTS
> annotationwidgets.cpp:817
> {
> -QWidget * widget = new QWidget();
> -QVBoxLayout * lay = new QVBoxLayout( widget );
> -lay->setMargin( 0 );
> -QGroupBox * gb = new QGroupBox( widget );
> -lay->addWidget( gb );
> -gb->setTitle( i18n( "Caret Symbol" ) );
> -QHBoxLayout * gblay = new QHBoxLayout( gb );
> -m_pixmapSelector = new PixmapPreviewSelector( gb );
> -gblay->addWidget( m_pixmapSelector );
> +QWidget * widget = (QWidget*)formlayout->parent();
> +
Why not use qobject_cast here and cases above?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21730
To: simgunz
Cc: shubham, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. @ngraham @aacid Ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham updated this revision to Diff 55753. shubham edited the test plan for this revision. shubham added a comment. Do not copy to clipboard REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=54854=55753 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook part.cpp part.h part.rc ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham updated this revision to Diff 54854. shubham added a comment. Do not delete area REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=54700=54854 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook part.cpp part.h part.rc ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. @aacid area is a RegularAreaRect object which is a QRect bounding the selected text. "area" is to be deleted in all the cases except the case in which it is not possible to delete it since "area" will not contain any text in it and hence it will be nullptr. (case: if text is empty string) and hence return is called instead of deleting the "area". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. In D18744#437473 <https://phabricator.kde.org/D18744#437473>, @ngraham wrote: > In D18744#437461 <https://phabricator.kde.org/D18744#437461>, @shubham wrote: > > > Try to fix the crash. I could not test it because for me I could not see the entry added to the menu. > > > You gotta fix that. :) Try deleting `~/.local/share/kxmlgui5/okular/partrc` Does that help? Thanks, that is helpful. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham added inline comments. INLINE COMMENTS > aacid wrote in pageview.cpp:5598 > Why this return? If removed, it causes crash. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham updated this revision to Diff 54700. shubham added a comment. Try to fix the crash REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=54493=54700 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook part.cpp part.h part.rc ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. @ngraham @aacid Ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham updated this revision to Diff 54493. shubham added a comment. Remove useless return REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=53794=54493 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook part.cpp part.h part.rc ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18816: Accept and ignore event
shubham abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18816 To: shubham, aacid Cc: davidhurka, ngraham, okular-devel, tfella, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham edited the test plan for this revision. REPOSITORY R223 Okular BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham updated this revision to Diff 53794. shubham marked an inline comment as done. shubham added a comment. Make requested changes by Albert and Nate REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=52729=53794 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook part.cpp part.h part.rc ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D19183: Use logically correct icon for direction arrows
This revision was automatically updated to reflect the committed changes. Closed by commit R223:4610929e0c38: Use logically correct icon for direction arrows (authored by shubham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19183?vs=53789=53790 REVISION DETAIL https://phabricator.kde.org/D19183 AFFECTED FILES ui/minibar.cpp To: shubham, #vdg, ngraham, #okular Cc: aacid, abetts, davidhurka, ngraham, okular-devel, tfella, darcyshen
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. Surely I can do that, but currently I am busy with my exams. Give me some time. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. @aacid Ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D19183: Use logically correct icon for direction arrows
shubham added a comment. @aacid @ngraham Is this good to go now? REPOSITORY R223 Okular BRANCH arcpatch-D19183 REVISION DETAIL https://phabricator.kde.org/D19183 To: shubham, #vdg, ngraham, #okular Cc: aacid, abetts, davidhurka, ngraham, okular-devel, tfella, darcyshen
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. I will wait for @aacid's review before landing it. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. @aacid @ngraham Can you please confirm it now works to your expectations so that I can go ahead pushing this? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham updated this revision to Diff 52729. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=52576=52729 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook part.cpp part.h part.rc ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D19183: Use logically correct icon for direction arrows
shubham updated this revision to Diff 52727. shubham added a comment. remove check for layout Direction REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19183?vs=52145=52727 BRANCH arcpatch-D19183 REVISION DETAIL https://phabricator.kde.org/D19183 AFFECTED FILES ui/minibar.cpp To: shubham, #vdg, ngraham, #okular Cc: aacid, abetts, davidhurka, ngraham, okular-devel, tfella, darcyshen
D18744: Add action in Edit menu to select the text on current page
shubham updated this revision to Diff 52576. shubham added a comment. 1. Try to fix crash case 2. Improve comment REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=52502=52576 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook part.rc ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18816: Accept and ignore event
shubham added a comment. In D18816#419557 <https://phabricator.kde.org/D18816#419557>, @aacid wrote: > The ping is on your side, you still haven't explained why this is needed and what it fixes I told you in my previous comment that it was handled the same way in ktexteditor, that is why I added it. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18816 To: shubham, aacid Cc: ngraham, okular-devel, tfella, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. In D18744#419287 <https://phabricator.kde.org/D18744#419287>, @yurchor wrote: > In D18744#419212 <https://phabricator.kde.org/D18744#419212>, @shubham wrote: > > > @yurchor what about the crash case, is it fixed now? > > > No. I think that the action should be created in part.cpp, setEnabled(false) by default, then setEnabled(true) in the Part::openFile to avoid the crash. > > Regretfully, no function (like isOpened) for setEnabled to connect to. Another strategy can be to check for if doc is not opened and then setEnable(false) Since setEnabled() is true by default, my if statement is basically dead code. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. @yurchor what about the crash case, is it fixed now? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D19183: Use logically correct icon for direction arrows
shubham added a comment. @aacid Do you have anything to say? REPOSITORY R223 Okular BRANCH icon REVISION DETAIL https://phabricator.kde.org/D19183 To: shubham, #vdg, ngraham, #okular Cc: aacid, abetts, davidhurka, ngraham, okular-devel, tfella, darcyshen
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. I can't test it since for me, somehow I don't see the action added to the menu. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham updated this revision to Diff 52502. shubham added a comment. Enable action for all the modes Try to fix crash REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=51907=52502 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook part.rc ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg, ngraham Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18816: Accept and ignore event
shubham added a comment. Ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18816 To: shubham, aacid Cc: ngraham, okular-devel, tfella, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D19183: Use logically correct icon for direction arrows
shubham added a comment. What's the call? REPOSITORY R223 Okular BRANCH icon REVISION DETAIL https://phabricator.kde.org/D19183 To: shubham, #vdg, ngraham, #okular Cc: aacid, abetts, davidhurka, ngraham, okular-devel, tfella, darcyshen
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. @aacid ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D19183: Use logically correct icon for direction arrows
shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19183 To: shubham, #vdg Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D19183: Use logically correct icon
shubham created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. shubham requested review of this revision. REPOSITORY R223 Okular BRANCH icon REVISION DETAIL https://phabricator.kde.org/D19183 AFFECTED FILES ui/minibar.cpp To: shubham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D19183: Use logically correct icon
shubham edited the test plan for this revision. shubham added a reviewer: VDG. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19183 To: shubham, #vdg Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D19183: Use logically correct icon for direction arrows
shubham retitled this revision from "Use logically correct icon" to "Use logically correct icon for direction arrows". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19183 To: shubham, #vdg Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18719: [WIP]Create context menu entry to rotate individual pages
shubham added a comment. How do I resolve this? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham updated this revision to Diff 51907. shubham added a comment. Remove shortcut and it's documentation REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=51829=51907 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook part.rc ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. > 2. Quadruple-click to select whole page What do other folks think? In my view quadruple click does not make sense because it is seldom the user can think it cam result in some kind of action or behaviour. Secondly, this feature then would remain hidden or unknown about, even though I originally implemented this in double click. I would prefer double click over quadruple since for me double click is expected to do something, but surely quadruple not.(I don't know about others) At the end you all are much more experienced amd understand UX way better than me, I will leave this to you. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham added a comment. In D18744#412143 <https://phabricator.kde.org/D18744#412143>, @ngraham wrote: > OK, works for me now. I'm not thrilled about the Alt-P shortcut since it's the only one in the menu that uses only the Alt modifier. But I won't block on that. I'll hand this back to the #okular <https://phabricator.kde.org/tag/okular/> folks now. Does that earn +1 or Accepted from VDG? ;) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham updated this revision to Diff 51829. shubham edited the test plan for this revision. shubham added a comment. Correct shortcut in documentation Fix coding style REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=51685=51829 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook part.rc ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the text on current page
shubham retitled this revision from "Add action in Edit menu to select the current page" to "Add action in Edit menu to select the text on current page". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the current page
shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the current page
shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the current page
shubham retitled this revision from "[RFC]Add action in Edit menu to select the current page" to "Add action in Edit menu to select the current page". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: [RFC]Add action in Edit menu to select the current page
shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: [RFC]Add action in Edit menu to select the current page
shubham retitled this revision from "Add action in Edit menu to select the current page" to "[RFC]Add action in Edit menu to select the current page". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the current page
shubham updated this revision to Diff 51685. shubham marked 3 inline comments as done. shubham retitled this revision from "Add action in Edit menu to select the current page " to "Add action in Edit menu to select the current page". shubham added a comment. Add action to part.rc Bump version to 40 REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=51610=51685 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook part.rc ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg, ngraham Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the current page
shubham added inline comments. INLINE COMMENTS > ngraham wrote in pageview.cpp:743 > It doesn't have a shortcut at all. If you can't think of anything that > doesn't conflict, then just don't give it one. So better I will remove that. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the current page
shubham added inline comments. INLINE COMMENTS > ngraham wrote in pageview.cpp:743 > Erm, that's the shortcut used for printing. Did you test this? What sequence should I use? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the current page
shubham added a comment. In D18744#411599 <https://phabricator.kde.org/D18744#411599>, @ngraham wrote: > Please test your changes. The new menu is not actually added to the Edit menu and the shortcut you chose conflicts with the print shortcut. I knew ctrl p is for print, so for time being I kept it so I can get suggestion for other shortcut sequence. Also, I can't tell why entry is not added intk Edit menu even though I had added that in docbook REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the current page
shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the current page
shubham retitled this revision from "Add action in Edit menu to select the entire page " to "Add action in Edit menu to select the current page ". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Add action in Edit menu to select the entire page
shubham retitled this revision from "Select entire page on mouse double click event" to "Add action in Edit menu to select the entire page ". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Select entire page on mouse double click event
shubham updated this revision to Diff 51610. shubham added a comment. Remove unneeded comment REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=51609=51610 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18744: Select entire page on mouse double click event
shubham updated this revision to Diff 51609. shubham edited the summary of this revision. shubham added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Add action and shortcut to select the current page Remove triggering on mouseDoubleClick event REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=50959=51609 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES doc/index.docbook ui/pageview.cpp ui/pageview.h To: shubham, aacid, #vdg Cc: kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
D18719: [WIP]Create context menu entry to rotate individual pages
shubham updated this revision to Diff 51520. shubham added a comment. use rotateAt() REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18719?vs=51269=51520 BRANCH page REVISION DETAIL https://phabricator.kde.org/D18719 AFFECTED FILES core/page.h part.cpp part.h To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18719: [WIP]Create context menu entry to rotate individual pages
shubham added a comment. @aacid I'm unsure whether rotateAt() function will actually work, any suggestions you can give? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18816: Accept and ignore event
shubham added a comment. In D18816#409397 <https://phabricator.kde.org/D18816#409397>, @aacid wrote: > Unless you have a bug that needs this fix, i really prefer if you don't touch event handling I added these since they were handed the same way in ktexteditor. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18816 To: shubham, aacid Cc: ngraham, okular-devel, tfella, darcyshen, aacid
D18816: Accept and ignore event
shubham added a comment. Ping REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18816 To: shubham, aacid Cc: ngraham, okular-devel, tfella, darcyshen, aacid
D18719: [WIP]Create context menu entry to rotate individual pages
shubham added inline comments. INLINE COMMENTS > part.cpp:2451 > +int value = ( page->rotation() + 3 ) % 4; > +m_pagePrivate->rotateAt( qobject_cast(value) ); > +} This is valid statement, but why does this produce error? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18719: [RFC]Create context menu entry to rotate individual pages
shubham updated this revision to Diff 51269. shubham added a comment. Remove unneeded include REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18719?vs=51268=51269 BRANCH page REVISION DETAIL https://phabricator.kde.org/D18719 AFFECTED FILES part.cpp part.h To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18719: [WIP]Create context menu entry to rotate individual pages
shubham retitled this revision from "[RFC]Create context menu entry to rotate individual pages" to "[WIP]Create context menu entry to rotate individual pages". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18719: [RFC]Create context menu entry to rotate individual pages
shubham updated this revision to Diff 51268. shubham added a comment. Rotate REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18719?vs=50833=51268 BRANCH page REVISION DETAIL https://phabricator.kde.org/D18719 AFFECTED FILES core/page.h part.cpp part.h To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18719: [RFC]Create context menu entry to rotate individual pages
shubham marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18719: [RFC]Create context menu entry to rotate individual pages
shubham added a comment. @aacid stuck with what my inline message says. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18719: [RFC]Create context menu entry to rotate individual pages
shubham added a comment. Any piece of help would be appreciated, I m stuck. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18719 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18816: Accept and ignore event
shubham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18816 To: shubham, aacid Cc: ngraham, okular-devel, tfella, darcyshen, aacid
D18816: Accept and ignore event
shubham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18816 To: shubham, aacid Cc: ngraham, okular-devel, tfella, darcyshen, aacid
D18816: Accept and ignore event
shubham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18816 To: shubham, aacid Cc: ngraham, okular-devel, tfella, darcyshen, aacid
D18816: Accept and ignore event
shubham created this revision. shubham added a reviewer: aacid. Herald added a project: Okular. Herald added a subscriber: okular-devel. shubham requested review of this revision. REPOSITORY R223 Okular BRANCH event REVISION DETAIL https://phabricator.kde.org/D18816 AFFECTED FILES ui/pageview.cpp To: shubham, aacid Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18744: Select entire page on mouse double click event
shubham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid
D18744: Select entire page on mouse double click event
shubham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid
D18744: Select entire page on mouse double click event
shubham added a comment. I'm unsure how mouse click events of degree n can be handled. Maybe handle mouseDoubleClickEvent() nested inside another mouseDoubleClickEvent() ? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid
D18744: Select entire page on mouse double click event
shubham added a comment. In D18744#406150 <https://phabricator.kde.org/D18744#406150>, @aacidTriple-click is used for "select everything" in word processors, so perhaps we could take advantage of some familiarity there? > > AFAICS triple-click is usually "select line" not "select all page/document" > > Having triple click for "select line" would be actually a great improvement IMHO I will submit a new patch for it. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid
D18744: Select entire page on mouse double click event
shubham added a comment. Caution: I did not do my video editing magic : ) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid
D18744: Select entire page on mouse double click event
shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid
D18744: Select entire page on mouse double click event
shubham added a comment. @ngraham @loh.tar I don't think it is that big of a feature to be shown in the view menu. It is something which is natural, same as when you select a word(which also don't have any action defined). i'm okay anyways. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: abetts, loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid
D18761: Add icon name to service providers in .desktop file
This revision was automatically updated to reflect the committed changes. Closed by commit R241:8657a239a28d: Add icon name to service providers in .desktop file (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18761?vs=50953=50969 REVISION DETAIL https://phabricator.kde.org/D18761 AFFECTED FILES src/urifilters/ikws/searchproviders/google.desktop src/urifilters/ikws/searchproviders/wikipedia.desktop src/urifilters/ikws/searchproviders/yahoo.desktop src/urifilters/ikws/searchproviders/youtube.desktop To: shubham, broulik, ngraham, #vdg, #okular, #frameworks Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender
D18744: Select entire page on mouse double click event
shubham edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18744: Select entire page on mouse double click event
shubham retitled this revision from "[WIP]Select entire page on mouse double click event" to "Select entire page on mouse double click event". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18744: [WIP]Select entire page on mouse double click event
shubham updated this revision to Diff 50959. shubham added a comment. Remove unncessary include REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=50958=50959 BRANCH clipboard REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES ui/pageview.cpp To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18744: [WIP]Select entire page with double click
shubham marked 2 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18744: [WIP]Select entire page on mouse double click event
shubham retitled this revision from "[WIP]Select entire page with double click" to "[WIP]Select entire page on mouse double click event". REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18744: [WIP]Select entire page with double click
shubham updated this revision to Diff 50958. shubham added a comment. Fix segmentation fault error. Now mouse double click event on empty portion of the document selects the entire page REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=50907=50958 BRANCH clipboard REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES ui/pageview.cpp To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18761: Add icon name to service providers in .desktop file
shubham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18761 To: shubham, broulik, ngraham, #vdg, #okular, #frameworks Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender
D18761: Add icon name to service providers in .desktop file
shubham added a comment. In the rest of service providers, very few have any icon specified, and most don't have. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18761 To: shubham, broulik, ngraham, #vdg, #okular Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender
D18730: Use breeze icons for search providers
shubham abandoned this revision. shubham added a comment. Abandoned in favour of D18761 <https://phabricator.kde.org/D18761> REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18730 To: shubham, ngraham, #vdg, #frameworks, cfeck Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender
D18761: Add icon name to service providers in .desktop file
shubham added reviewers: VDG, Okular. shubham added projects: Okular, VDG. shubham added a subscriber: Okular. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18761 To: shubham, broulik, ngraham, #vdg, #okular Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender
D18730: Use breeze icons for search providers
shubham added a comment. @broulik Adding icons to the .desktop files does not work, I tried. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18730 To: shubham, ngraham, #vdg, #frameworks, cfeck Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender
D18744: [WIP]Select entire page with double click
shubham added inline comments. INLINE COMMENTS > shubham wrote in pageview.cpp:3318 > Lines below produce segmentation fault, can't figure out what's wrong here This part of code actually just visualy selects the page, so that a context menu event can occur. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18744: [WIP]Select entire page with double click
shubham added inline comments. INLINE COMMENTS > pageview.cpp:3318 > +const QString text = item->page()->text( area ); > +d->pagesWithTextSelection.insert( currentPage ); > +d->document->setPageTextSelection( currentPage, area, > palette().color( QPalette::Active, QPalette::Highlight ) ); Lines below produce segmentation fault, can't figure out what's wrong here REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18744: [WIP]Select entire page with double click
shubham added a comment. Note: This is not a working version, see my inline comment. Though I can confirm that after fixing the seg fault error, it will become working since I have manually tested to select the entire page and then qDebug() the "text" gave same contents as that of the selected page. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18744: [WIP]Select entire page with double click
shubham added a reviewer: ngraham. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, ngraham Cc: okular-devel, tfella, ngraham, darcyshen, aacid
D18744: [WIP]Select entire page with double click
shubham added a subscriber: Okular. Herald removed a subscriber: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid Cc: okular-devel, tfella, ngraham, darcyshen, aacid
