[okular] [Bug 466521] Characters such as "⑥" cannot be copied as in Chrome, but can only be pasted as "6"

2024-05-24 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=466521

Sune Vuorela  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/-/commit/322fd2
   ||d54e4226f6dbb4fb357a86931a5
   ||c790340
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #2 from Sune Vuorela  ---
Git commit 322fd2d54e4226f6dbb4fb357a86931a5c790340 by Sune Vuorela, on behalf
of Wendi Gan.
Committed on 24/05/2024 at 10:02.
Pushed by sune into branch 'master'.

fix Unicode Normalization: replace NFKC to NFC

Use NFC in copy, makeWord, and export functions, and NFKC for search
operations.
NFKC may alter characters when copied or exported. For example ⑥ in pdf will be
pasted as 6. So most instances are replaced with NFC.
To simplify matching during search operation, NFKC is used.
Related: bug 473495

M  +12   -9core/textpage.cpp
M  +1-1generators/poppler/generator_pdf.cpp

https://invent.kde.org/graphics/okular/-/commit/322fd2d54e4226f6dbb4fb357a86931a5c790340

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 473495] Give an option not to apply compatibility decomposition when copying

2024-05-24 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=473495

--- Comment #2 from Sune Vuorela  ---
Git commit 322fd2d54e4226f6dbb4fb357a86931a5c790340 by Sune Vuorela, on behalf
of Wendi Gan.
Committed on 24/05/2024 at 10:02.
Pushed by sune into branch 'master'.

fix Unicode Normalization: replace NFKC to NFC

Use NFC in copy, makeWord, and export functions, and NFKC for search
operations.
NFKC may alter characters when copied or exported. For example ⑥ in pdf will be
pasted as 6. So most instances are replaced with NFC.
To simplify matching during search operation, NFKC is used.
Related: bug 466521

M  +12   -9core/textpage.cpp
M  +1-1generators/poppler/generator_pdf.cpp

https://invent.kde.org/graphics/okular/-/commit/322fd2d54e4226f6dbb4fb357a86931a5c790340

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 487346] Feature Request: Speak beginning from current page

2024-05-22 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=487346

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com
   Keywords||junior-jobs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 486680] Okular does not accept blank certificate password when digitally signing PDFs

2024-05-07 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=486680

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Hi

What does the version in 'about okular' report?

If it is 24.02, you likely need to actually click the certificate even if it
looks selected. It is a bug fixed in 24.05

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 484938] Okular sidebar will not save

2024-04-28 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=484938

Sune Vuorela  changed:

   What|Removed |Added

 CC||follow...@163.com

--- Comment #4 from Sune Vuorela  ---
*** Bug 486186 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 486186] The visibility of the sidebar and the corresponding UI items not consistent

2024-04-28 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=486186

Sune Vuorela  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE
 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Thank you for your bug report. It was also reported a couple of weeks ago and
already fixed. Will be fixed in 24.05.

*** This bug has been marked as a duplicate of bug 484938 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 485747] PDF signature dialog should preselect (only) certificate

2024-04-19 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=485747

Sune Vuorela  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
(In reply to Frank Siegert from comment #0)
> When signing a PDF document with Okular, and even with only one certificate
> being available, no certificate is preselected. This leads to unnecessary
> work, but more importantly, it leads to a spurious error message if the user
> does not notice this being inactive: "Enter certificate password" (even if
> there is no password for the certificate).

Should be fixed in master around 6 weeks ago; there are no further 24.02 branch
releases planned, so will be available with 24.05

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 482500] Installing Okular from snap breaks home directory

2024-04-09 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=482500

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #4 from Sune Vuorela  ---
(In reply to Scarlett Moore from comment #3)
> Fix is in once merged:
> https://github.com/canonical/snapcraft/pull/4698/commits/
> 221e23cc28896b1098ed4a0c646f00b4b61464f0

Scarlett: thanks

Though this report might be about the qt5 snap ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 482249] Okular text selection glitch confuses beginning and end of selection in PDFs

2024-03-19 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=482249

Sune Vuorela  changed:

   What|Removed |Added

 CC||liusish...@gmail.com

--- Comment #4 from Sune Vuorela  ---
*** Bug 483968 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 483968] Okular now moves the starting point of the text selection region when I position my cursor before the original starting point.

2024-03-19 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=483968

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com
 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Sune Vuorela  ---
Thanks for your great report. It looks very much like
https://bugs.kde.org/show_bug.cgi?id=482249 which is fixed in next patch
release.

Marking as duplicate.

*** This bug has been marked as a duplicate of bug 482249 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 482682] Digital Signature not referenced in AcroForm

2024-03-19 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=482682

--- Comment #9 from Sune Vuorela  ---
Hi Tobias

After much investigation, I think I'm heading towards rejecting this bug
report.

When the AcroForm section is embedded directly into the Catalog dict, Poppler
must rewrite the entire Catalog dict in order to update it. (As I understand
PDF spec ISO 32000-2:2020 section 7.5.6 about incremental updates)

Your signed form is seen with Adobe Reader.

I'm writing a bug report to the ec.europa.eu validator to check this, and also
filing a issue with LibreOffice to suggest them to always do the indirect
references for the AcroForm.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 483678] Signing with Luxtrust's non-repudiation certificate just hangs

2024-03-19 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=483678

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #9 from Sune Vuorela  ---
(In reply to Alain Knaff from comment #6)

> I retried with okular 23.08.1 from Debian testing, and with a poppler that I
> compiled myself (24.03.0), and GPG still didn't show up :-(

Unfortunately you need a newer gpg than what is currently available in debian
(We needed some fixes for handling of padding in signatures)

You could find the gnupg appimage which should contaain a okular and a gnupg
that just works together.  It can be started with adding `-c okular` to the app
image call.

Alternatively, if you can sign a  using either gpgsm on the command
line, or the graphical KDE Application `Kleopatra`, with your luxtrust key then
it is likely that the okular-with-gnupg-smime setup would also work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 482682] Digital Signature not referenced in AcroForm

2024-03-08 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=482682

--- Comment #7 from Sune Vuorela  ---
(Note to the other okular people; This is most probably an issue in poppler,
and I'm looking at that. While it would be most correct to close the bug here
and reopen it in poppler ( https://gitlab.freedesktop.org/poppler/poppler/ ),
I'm keeping the bug open here 'cause that's where the user are)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 482682] Digital Signature not referenced in AcroForm

2024-03-07 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=482682

--- Comment #5 from Sune Vuorela  ---
Created attachment 166594
  --> https://bugs.kde.org/attachment.cgi?id=166594=edit
Unsigned document with form

I guess we should investigate how this form differs from your form ...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 482682] Digital Signature not referenced in AcroForm

2024-03-07 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=482682

--- Comment #4 from Sune Vuorela  ---
(In reply to Tobias Wich from comment #2)
> (In reply to Sune Vuorela from comment #1)
> > Hi Tobias
> > 
> > Any chance you can try again with an okular built with a less ancient
> > poppler ?
> > 
> > Note that quite some work have gotten into digital signatures in both okular
> > and poppler over the last year, and your poppler library is from december
> > 1st, 2022.
> > 
> > I just uploaded a signed test pdf to the europa.eu link, and except for it
> > disliking my custom certificate authority chain, it was all green ?
> 
> Fair point. At the moment I only have the debian packages at my disposal.
> The okular version 23.08.1 is the latest in the repo. It is using
> libpoppler-qt5-1 which I can update to 24.02.0 from deb experimental. With
> that I get the same result. 
> 
> I have to build the programs myself to see for sure, but given fact, that
> the newer poppler version shows the same behaviour, it is probably something
> that is related to the okular code and has been fixed there already okular
> code.
> 
> Just to make sure it's not related to my test document, have you tried
> signing this and checking in the EU validator?

I have now tried signing your document and checking it in the eu validator, and
I see it complaining quite a bit.

I have tried another simple document with forms and signing that, and that was
validated quite okay I think (except certificate chain)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 482682] Digital Signature not referenced in AcroForm

2024-03-07 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=482682

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Hi Tobias

Any chance you can try again with an okular built with a less ancient poppler ?

Note that quite some work have gotten into digital signatures in both okular
and poppler over the last year, and your poppler library is from december 1st,
2022.

I just uploaded a signed test pdf to the europa.eu link, and except for it
disliking my custom certificate authority chain, it was all green ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 482443] okular - add build options for wayland (non X11) build options

2024-03-04 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=482443

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Please submit the patch on invent.kde.org. 

I think there is things wrong (if built with x11 support and run under wayland;
probably the most normal case), but it is better to discuss on invent.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 463647] Slow start on network mounts because of image icon lookups + may broken UI

2024-03-04 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=463647

--- Comment #9 from Sune Vuorela  ---
https://invent.kde.org/graphics/okular/-/merge_requests/777/diffs (in 23.08) is
at least fixing a big part of it. Can anyone try apply that on their local
setups and check ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 463647] Slow start on network mounts because of image icon lookups + may broken UI

2024-03-03 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=463647

--- Comment #7 from Sune Vuorela  ---
(In reply to Bernard Gray from comment #6)
> We're experiencing it over a CIFS network share. Examining the calls via
> wireshark we get a lot of failed attempts to open non-existant files -

Hi
What version of okular are you using?

/Sune

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479141] Graphical glitches in presentation mode

2024-02-21 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479141

Sune Vuorela  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/okular/-/commit/450744 |hics/okular/-/commit/aab13e
   |a37dbf8770b3282b47ab43a797e |3fe25e4964a9ebbbc11832db397
   |d8c347e |d51453e

--- Comment #17 from Sune Vuorela  ---
Git commit aab13e3fe25e4964a9ebbbc11832db397d51453e by Sune Vuorela, on behalf
of Kai Uwe Broulik.
Committed on 21/02/2024 at 08:29.
Pushed by sune into branch 'release/24.02'.

presentationwidget: Invalidate pixmaps on dpr change

Since the last rendered pixmap is usually reused, its device pixel ratio
can end up different from the `devicePixelRatioF()` of the widget which
is used for most size calculations which leads to an area that might be
unpainted causing visual artifacts.

M  +19   -10   part/presentationwidget.cpp
M  +1-0part/presentationwidget.h

https://invent.kde.org/graphics/okular/-/commit/aab13e3fe25e4964a9ebbbc11832db397d51453e

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479141] Graphical glitches in presentation mode

2024-02-21 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479141

Sune Vuorela  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/-/commit/450744
   ||a37dbf8770b3282b47ab43a797e
   ||d8c347e

--- Comment #16 from Sune Vuorela  ---
Git commit 450744a37dbf8770b3282b47ab43a797ed8c347e by Sune Vuorela, on behalf
of Kai Uwe Broulik.
Committed on 21/02/2024 at 08:11.
Pushed by sune into branch 'master'.

presentationwidget: Invalidate pixmaps on dpr change

Since the last rendered pixmap is usually reused, its device pixel ratio
can end up different from the `devicePixelRatioF()` of the widget which
is used for most size calculations which leads to an area that might be
unpainted causing visual artifacts.

M  +19   -10   part/presentationwidget.cpp
M  +1-0part/presentationwidget.h

https://invent.kde.org/graphics/okular/-/commit/450744a37dbf8770b3282b47ab43a797ed8c347e

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 481262] option GPG, does not list my gpg certificate

2024-02-20 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=481262

--- Comment #11 from Sune Vuorela  ---
Git commit 3518099a08f0b129e6be8c8216ecb5fc0bf38273 by Sune Vuorela.
Committed on 20/02/2024 at 13:57.
Pushed by sune into branch 'release/24.02'.

Better user strings for signature settings

M  +9-4generators/poppler/pdfsettingswidget.cpp

https://invent.kde.org/graphics/okular/-/commit/3518099a08f0b129e6be8c8216ecb5fc0bf38273

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 481534] Presentation mode broken with scaling other than 100%

2024-02-19 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=481534

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com
 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #1 from Sune Vuorela  ---


*** This bug has been marked as a duplicate of bug 479141 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479141] Graphical glitches in presentation mode

2024-02-19 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479141

Sune Vuorela  changed:

   What|Removed |Added

 CC||m...@iyanmv.com

--- Comment #12 from Sune Vuorela  ---
*** Bug 481534 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 481262] option GPG, does not list my gpg certificate

2024-02-13 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=481262

--- Comment #7 from Sune Vuorela  ---
(In reply to Ingo Klöcker from comment #5)
> I think a good name for the NSS backend depends on how it behaves on
> different OSes, i.e. if it uses the Windows/macOS certificate store on
> Windows/macOS then "Firefox Certificate store" is probably not a good name.
> And I guess most people don't know that Mozilla Firefox was once called
> Netscape.

Afaik, it still uses the firefox cert store on all platforms.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 481262] option GPG, does not list my gpg certificate

2024-02-13 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=481262

--- Comment #4 from Sune Vuorela  ---
(In reply to Albert Astals Cid from comment #3)
> (In reply to Ingo Klöcker from comment #2)
> > Maybe we should change the name of the backend to "GnuPG (S/MIME)" (or

> that  makes sense, not the first person to be confused by the naming. Sune?

Sure. I didn't have any good ideas at the time, but I kind of prepared the code
for it

https://invent.kde.org/graphics/okular/-/blob/master/generators/poppler/pdfsettingswidget.cpp#L35

If one option should be 
> GnuPG (S/MIME) 
what should the other be
> Netscape NSS 
> NSS
> Firefox Certificate store

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 481266] [wish] pdf signing, okular can use openPGP certificcate

2024-02-12 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=481266

--- Comment #3 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #2)
> In this case, it would be a good thing that Okular, at the first opening,
> creates automatically an S/MIME OpenPGP certificate with Kleopatra.

In general, S/Mime (x509) certificates needs to be authorized/notarized by a
3rd party (not unlike how browser https security works), so just generating
something is not going to be useful in the long run.

For example, in certain countries, you can get a governmental issued
certificate with a government organization as trust anchor.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 481266] [wish] pdf signing, okular can use openPGP certificcate

2024-02-12 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=481266

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Hi

This is not specified in the pdf specification, so it would be a purely
okular-to-okular feature. While it probably wouldn't be many man weeks of work
to implement something that works, given it is not actually specified in the
pdf spec, I don't think it is useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 481262] option GPG, does not list my gpg certificate

2024-02-12 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=481262

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com
 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #1 from Sune Vuorela  ---
the gpg backend setting is still s/mime and not openpgp, so you need s/mime
certificates, just like for the nss backend.

The pdf standard specifies s/mime for signing pdfs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 481111] Keyboard shortcuts or menu items to rotate in okular

2024-02-09 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=48

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
You can actually both add it to the toolbar and add a shortcut. I do think
though that having a shortcut by default could make sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 480485] no night mode

2024-01-29 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=480485

Sune Vuorela  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Sune Vuorela  ---
(In reply to Pejman Rezaei from comment #2)
> I mean dark mode like the one evince has. My kubuntu is update

Color menu was added in may 2022 probably for the 22.08 release, and later on
integration with the actual themes should have been added. 

In the report, you write you have version 21.12. Note that these releases are
year.month.

I'm closing this report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 480485] no night mode

2024-01-29 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=480485

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Do you by 'night mode' mean redshifted supposedly-less-keep-awake ui or a
dark-mode ?

note that your okular is quite old.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 353300] Text search does not work in Arabic

2024-01-23 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=353300

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #6 from Sune Vuorela  ---
(In reply to Saladin Shaban from comment #5)
> Diggin some more into the issue:
> https://chat.openai.com/share/d2f74bc7-6c7b-437d-ac17-e71ae73f689b
> 
> The problem now is the way TinyTextEntity's are sorted according to their
> positions from left to right. This seems to be crucial to the text selection
> logic, and cannot be changed without extensive modifications.
> 
> I'm not sure about the right way to proceed from here. Some possibilities
> are:
> 
> 1- Reorder the text in the Find bar before performing a search, with Qt's
> equivalent of fribidi_reorder_line().
> 
> 2- For text-based documents, delegate search and selection to the
> QTextDocument class itself.
> 
> 3- Skip sorting the text entities, and adjust the search and selection
> methods accordingly.
> 
> The first option is the least intrusive, while the second seems to offer
> greater possibilities, like handling the peculiarities of Arabic search and
> other languages:
> 
> https://community.scripture.software.sil.org/t/search-arabic-text-without-
> tashkeel/882
> https://help-nl.oclc.org/Discovery_and_Reference/WorldCat_Discovery/
> Release_notes/2023_release_notes/
> 040WorldCat_Discovery_release_notes_Arabic_language_support
> 
> QTextDocument doesn't seem to support these yet, but it's something I might
> be able to contribute to Qt.

There is https://invent.kde.org/graphics/okular/-/merge_requests/595 which
claims to fix it. Though it likely introduces a significant memory leak.

I don't know enough about any RTL language to be able to really test and work
on it, but I have prepared
https://invent.kde.org/graphics/okular/-/merge_requests/905 which should make
it easier with the memory management on top of it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479777] Altium Designer PDF popup doesn't show up

2024-01-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479777

Sune Vuorela  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/-/commit/2609f4
   ||001add186e34f4e649f6c1096e3
   ||b499f2f

--- Comment #2 from Sune Vuorela  ---
Git commit 2609f4001add186e34f4e649f6c1096e3b499f2f by Sune Vuorela, on behalf
of Alexis Murzeau.
Committed on 17/01/2024 at 20:01.
Pushed by sune into branch 'master'.

Add support for app.popUpMenu and submenus in popUpMenuEx

These functions from `app` are JS functions that can be used by PDF
files.

Based on popUpMenuEx, the implementation of popUpMenu converts arguments
to app.popUpMenuEx format and then call it.

The popMenuEx function is improved to handle submenus as well using
`oSubMenu`.

app.popUpMenu is used in Altium Designer and EasyEDA exported PDFs.
See an example here:
https://www.st.com/en/evaluation-tools/32f723ediscovery.html#cad-resources
https://www.st.com/resource/en/schematic_pack/mb1260-f723e-d03_schematic.pdf

M  +146  -0autotests/jsfunctionstest.cpp
M  +42   -0core/script/builtin.js
M  +34   -10   core/script/js_app.cpp
M  +2-0core/script/js_app_p.h

https://invent.kde.org/graphics/okular/-/commit/2609f4001add186e34f4e649f6c1096e3b499f2f

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479942

Sune Vuorela  changed:

   What|Removed |Added

   Keywords|qt6 |

--- Comment #3 from Sune Vuorela  ---
not qt6 specific, bug janitor.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479942

Sune Vuorela  changed:

   What|Removed |Added

   Keywords|qt6 |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479942

Sune Vuorela  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from Sune Vuorela  ---
So. I guess I need to discuss this with Albert and maybe read the pdf standard. 
The following becomes a bit technical:

But apparantly the 4 options is in a 'button group' and okular assumes that all
buttons on a button group is in the same page. But 4 is  on a page of itself.
And Okular gets confused by this (and
EditFormButtonsCommand::refreshInternalPageReferences fails (It looks for the
form elements on the wrong page) to succeed) and after that, okular seems to be
in a bad state and starts crashing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479942

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Also reproducible in 22.12.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479110] Text-to-speech is not working

2024-01-15 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479110

Sune Vuorela  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |DOWNSTREAM

--- Comment #5 from Sune Vuorela  ---
(In reply to Doug from comment #4)
> (In reply to Carlos De Maine from comment #3)
> > > The cached device pixel ratio value was stale on window expose.  Please 
> > > file
> > > a QTBUG which explains how to reproduce.
> > > 
> > > Dont' know if that has anything to do with the issue I am having.
> > 
> > no that should not have any relevance on your problem.  i can confirm that
> > after i installed speech-dispatcher and restarted okular that text-to-speech
> > began to work.  i will add speech-dispatcher as a runtime dep of qt6-speech
> > in neon's packaging.
> > 
> > can you retry and see is it works now, preferably after a reboot?
> 
> OK, thank you,  it seems to be working now with speechd, but flite and mock
> do not work.  Are they supposed to work out of the box?  If not, maybe there
> should be a message or something to let people know that there is extra
> configuration needed to use those modules.

I don't think mock should be installed. It isn't an actual working backend.

Flite also requires some extra modules, but last I tried it it wasn't very
good.

I don't think QSpeech (the abstraction layer used) communicates non-working
backends, so there is not much Okular can do about it.

I think I will mark this as closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479683] Okular does not start due to missing okularpart

2024-01-12 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479683

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Sune Vuorela  ---
https://invent.kde.org/graphics/okular/-/merge_requests/906

Sorry about that. 

Also, mail to Distributions list has been sent

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479122] Konqueror on KF6 can't display PDFs using Okular part

2024-01-09 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479122

--- Comment #6 from Sune Vuorela  ---
Git commit 671107c0e53daf80065708daab7505d8f1a36371 by Sune Vuorela.
Committed on 09/01/2024 at 19:17.
Pushed by sune into branch 'master'.

KParts can extend their mimetypes with plugins

Certain KParts can extend their mimetypes with plugins

This feature was kind of lost in the KF6 porting that dropped the
desktop files.

Look for a key in the json file to see what plugins to look for for
extra mimetypes.

M  +13   -3src/partloader.cpp

https://invent.kde.org/frameworks/kparts/-/commit/671107c0e53daf80065708daab7505d8f1a36371

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479122] Konqueror on KF6 can't display PDFs using Okular part

2024-01-09 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479122

Sune Vuorela  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/-/commit/dbb8ba
   ||635e48650b2ed8c84168c79e53e
   ||619ea0f

--- Comment #5 from Sune Vuorela  ---
Git commit dbb8ba635e48650b2ed8c84168c79e53e619ea0f by Sune Vuorela.
Committed on 09/01/2024 at 19:19.
Pushed by sune into branch 'master'.

Communicate our plugin namespace to consumers

This enables others to query our supported mimetypes and thus figure out
what mimetypes they can open with the okular part

It is needed for kpart loading to know which features we can actually do

M  +3-0okular_part.json

https://invent.kde.org/graphics/okular/-/commit/dbb8ba635e48650b2ed8c84168c79e53e619ea0f

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479122] Konqueror on KF6 can't display PDFs using Okular part

2024-01-09 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479122

--- Comment #4 from Sune Vuorela  ---
Git commit 55901afcc3a0d42dbec216ec43426dd6c8e3a2fd by Sune Vuorela.
Committed on 09/01/2024 at 11:10.
Pushed by sune into branch 'master'.

Install parts into the right folder

M  +1-2CMakeLists.txt

https://invent.kde.org/graphics/okular/-/commit/55901afcc3a0d42dbec216ec43426dd6c8e3a2fd

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479142] Bookmarks Sidebar doesn't update unless "Show for all documents" checkbox is toggled

2024-01-03 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479142

Sune Vuorela  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kbookmarks/-/commit/
   ||fa97c1d8ff2f0393bbe7ac92786
   ||58e63291d2e09
 Resolution|--- |FIXED

--- Comment #2 from Sune Vuorela  ---
Git commit fa97c1d8ff2f0393bbe7ac9278658e63291d2e09 by Sune Vuorela.
Committed on 03/01/2024 at 14:25.
Pushed by cullmann into branch 'master'.

Emit specific changed signal

This happened before dbus removal by dbus sending messages back to
current process. Reintroduce it.

M  +1-2src/kbookmarkmanager.cpp

https://invent.kde.org/frameworks/kbookmarks/-/commit/fa97c1d8ff2f0393bbe7ac9278658e63291d2e09

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479108] Zoom dropdown list in toolbar not working

2024-01-02 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479108

Sune Vuorela  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/-/commit/a3f018
   ||184864599161e74e5587b9aa55e
   ||daf360c

--- Comment #2 from Sune Vuorela  ---
Git commit a3f018184864599161e74e5587b9aa55edaf360c by Sune Vuorela.
Committed on 02/01/2024 at 11:21.
Pushed by aacid into branch 'master'.

Fix zoom select

There is a surprising api change in KSelectAction that has renamed
triggered, but a base class is still having a different triggered, so
code still compiles.

Rename the signal to the new version

M  +1-1part/pageview.cpp

https://invent.kde.org/graphics/okular/-/commit/a3f018184864599161e74e5587b9aa55edaf360c

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479110] Text-to-speech is not working

2024-01-02 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479110

Sune Vuorela  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Thank you for your report. Unfortunately, I cannot reproduce.

I just - like in my kf5 setup - drew a square and clicked 'Speak text' from
context menu, and in both cases I got the same 'machine voice' speaking the
exact same words. (Note; I have only tested with speech dispatcher, and just a
single pdf document)

I think this might be a setup issue in your end; either by yourself or by your
distribution.

Do you have the package speech-dispatcher installed ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

T11542: Remove KHTML

2023-12-22 Thread Sune Vuorela
svuorela closed subtask T11539: Port Okular away from KHTML as 
Resolved.

TASK DETAIL
  https://phabricator.kde.org/T11542

To: svuorela
Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, 
#frameworks, knauss, cpmontanari, ghost62, hannahk, davidre, GB_2, ahmadsamir, 
kpiwowarski, usta, asturmlechner, jucato, cullmann, vkrause


[okular] [Bug 478729] Does not show Text of Apple-edited PDFs

2023-12-20 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=478729

--- Comment #2 from Sune Vuorela  ---
I did investigate the file a bit, and it is a quite bad file. 

I don't know if it is so bad that we shouldn't be able to recover from it, but
it looks like we at least don't fully do it.

This is a bit pdf-technical, but it is basically saying that now there is an
object of 360 bytes and then the object is 473 bytes long and such things, and
that's the most obvious errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 478729] Does not show Text of Apple-edited PDFs

2023-12-20 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=478729

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Thank you for your report.

It would also be helpful if you could show a screenshot of the file shown on a
device where it is shown as expected.

I'm also curious if you can provide the 'original' pdf before annotations so we
have that for comparison.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 463647] Slow start on network mounts because of image icon lookups + may broken UI

2023-12-14 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=463647

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #4 from Sune Vuorela  ---
(In reply to Stefano Rosellini from comment #3)
> I notice the performance problem on sshfs mount point.
> If I execute "strace okular filename.pdf" using remote mount point as
> current work directory I see that okular try to open a bunch of file named
> "bookmark-new.*", "help-about.", "kde.*". "okular.*" without path (these
> seems to be the slow part).
> If I open the same remote file but using as current work directory a local
> one the open is fast.
> So the problem seems to be that okular try to open these files without path.
> I hope this can help to fix the problem.

I did some changes here iirc for 23.08 release; which version are you using?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 478304] Okular exits every time I open a digitally signed PDF

2023-12-13 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=478304

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #7 from Sune Vuorela  ---
(In reply to meso5 from comment #6)
> I just emailed it to you.

I'll probably end up reviewing Albert's fix, if not helping implementing it;
any chance I can get a copy as well ? s...@kde.org

It looks like I touched the crashing code in question last.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 402017] Cannot save PDF when loaded file has been deleted

2023-11-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=402017

Sune Vuorela  changed:

   What|Removed |Added

 CC||chronoan...@web.de

--- Comment #78 from Sune Vuorela  ---
*** Bug 477136 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 477136] If the PDF-File was modified by another program, Save As … is ALSO disabled.

2023-11-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=477136

Sune Vuorela  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||k...@pusling.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Sune Vuorela  ---
dupe of https://bugs.kde.org/show_bug.cgi?id=402017 - already fixed.

*** This bug has been marked as a duplicate of bug 402017 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 477108] Font and text issues with Digitally Sign feature for non-english users

2023-11-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=477108

--- Comment #4 from Sune Vuorela  ---
(In reply to igor.mach...@gmail.com from comment #2)
> Regarding flatpak, that's strange indeed, and perhaps it's not related to
> okular itself... For me, on Ubuntu 22.04, I'm forced to use flatpak to have
> Stamps on digital signatures, otherwise the system version is too old. Maybe
It is claimed to work.

Signed by: should be translated into Assinado Por: according to my reading of
the translation data.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 477108] Font and text issues with Digitally Sign feature for non-english users

2023-11-16 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=477108

--- Comment #3 from Sune Vuorela  ---
(In reply to igor.mach...@gmail.com from comment #2)
> Ok Sune, thanks for the feedback. I opened this issue because I couldn't
> find any other one, but I was imagining that others would exist somewhere
> else.
> Regarding flatpak, that's strange indeed, and perhaps it's not related to
> okular itself... For me, on Ubuntu 22.04, I'm forced to use flatpak to have
> Stamps on digital signatures, otherwise the system version is too old. Maybe
> on system version the translation would work... I'll try to find a way to
> upgrade my native system one.
> Thanks!

https://bugs.kde.org/show_bug.cgi?id=443403 
https://bugs.kde.org/show_bug.cgi?id=474222
https://bugs.kde.org/show_bug.cgi?id=473433

and iirc a few more are variations of "visual representation of signature filed
is ugly. please make it pretty."

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 477108] Font and text issues with Digitally Sign feature for non-english users

2023-11-16 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=477108

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
The signed by-text is marked as translated; I'm not sure how translations for
flatpacks works.
https://invent.kde.org/graphics/okular/-/blob/master/generators/poppler/generator_pdf.cpp#L1378

I don't know if Albert has any knowledge here, else I think we should close it
as downstream issue with the flatpacks

The visual appearance is already duplicated by 2-4 other issues, but not yet
any coherent solutions have been found, and all suggestions pulls in different
directions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 476319] Okular crashes when trying to edit form fields

2023-10-30 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=476319

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com
 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED

--- Comment #1 from Sune Vuorela  ---
Fixed in poppler 23.05 or 23.06.  Please ask your distribution to provide an
updated version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-10-16 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

--- Comment #31 from Sune Vuorela  ---
> It is too techie for me. What I understand is :
> - the pdf standard for digital signing is only using a x509 certificate.
> - in the standard, there is no way for digital signing with an OpenPGP
> certificate.
> 
> Right ?

Correct. 

And for added knowledge:
 - LibreOffice can do some operations using OpenPGP. And other operations using
x509
 - Kleopatra works with both OpenPGP keys and x509 certificates for different
and similar things
 - KMail cans sign and verify both with OpenPGP and with x509 (S/Mime)
 - GnuPG has tools to work with OpenPGP keys (gpg) and with x509 certificates
(gpgsm)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-10-16 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

--- Comment #29 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #26)
> :~> gpgsm --list-secret-keys
> /home/roubach/.gnupg/pubring.kbx
> 

So okular's dialog matches what you have in the keyring. That's expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-10-16 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

--- Comment #28 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #27)
> >> And you have your x509 certificates in your gpg store ?
> 
> why you speak about x509 certificate ?
> 
> I speak about gpg certificates. Those found and used by kmail, LibreOffice,
> kleopatra for digital signing.

openpgp certificates are not specified to be used for pdf files.

For that we need CMS -
https://en.wikipedia.org/wiki/Cryptographic_Message_Syntax - and CAdES - 
https://en.wikipedia.org/wiki/CAdES_(computing) - according to the pdf
specification section 12.8. 

I have not seen anyone specifying CMS with openpgp keys, only with x509
certificates.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-10-16 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

--- Comment #25 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #24)
> Created attachment 162271 [details]
> no gpg certificate
> 
> Hello
> 
> OpenSUSE tumbleweed supplies :
> - gpg2 2.4.3
> - poppler built with gpgme support.
> 
> Okular still does not find any gpg certificate.
> 
> See the capture.

And you have your x509 certificates in your gpg store ?

What does `gpgsm --list-secret-keys` output ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-10-03 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

--- Comment #22 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #21)
> Why Okular does not use the same technology as kleopatra, kmail or
> LibreOffcie ?

The work I did in poppler uses the exact same technology as kleopatra and
kmail. Unfortunately there was a few bugs in the way. They were fixed in
gnupg2.4.1.

Why opensuse has buggy QA scripts; that's a good question. But I have submitted
a patch for that to them.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-10-03 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

--- Comment #19 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #17)
> Thanks
> 
> If I understand well, we need:
> - okular default certificate folder is ~.gnupg
> - gpg 2.4.1 or later
> - we need poppler built with gpgme support.
> 
> right ?

point 1 is slighly wrong.
Okular still uses NSS by default with whatever certificate paths. 

You now have a configuration option in the dialog to select gnupg or nss, if
poppler supports it, in the dialog you showed earlier.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-10-03 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

--- Comment #16 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #15)
> (In reply to Sune Vuorela from comment #14)
> > (In reply to Philippe ROUBACH from comment #12)
> > > Created attachment 162025 [details]
> > > backend settings
> > > 
> > > See the settings
> > 
> > Please file a bug report to whomever provides your poppler binaries.
> 
> Do you say the issue is solved or what ?

There is unfortunately 2-3 issues in this bug-thread.

But one of them is that your certificates seen with kleopatra cannot be used
with okular.

If your recent poppler is built with gpgme support (and gnupg2.4.1 or later is
available), okular can use the same certificate store as kleopatra.

You have the new okular that has the dropdown where it should be possible to
select gpg, but the underlying poppler is not built with gpg support, so it
isn't there. 

That you need to take up with whomever delivers your binaries.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-10-03 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

--- Comment #14 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #12)
> Created attachment 162025 [details]
> backend settings
> 
> See the settings

Please file a bug report to whomever provides your poppler binaries.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-10-02 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

--- Comment #11 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #10)
> okular 23.08.1
> poppler 23.09
> 
> Issue still there :
> okular by default does not point to ~/.gnupg/ and when we customize the path
> to ~/.gnupg/ then okular does not find any key. Certainly because it knows
> only NSS format.

Did you select gnupg in the backend dropdown ?

/Sune

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-10-02 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

--- Comment #9 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #6)
> It seems that kde policy is to use gpg store. Why not okular ?

This was released as part of okular 23.08 (requires a similar new-ish poppler
library, at least 23.07)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 439595] Replacing Epub backends to mupdf

2023-09-27 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=439595

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #6 from Sune Vuorela  ---
I do think that this is a bad bug report. 

The bug report should describe the problem. 

The problem is that okular misrenders certain epub files. 

The problem is not that okular does not use mupdf. 

Mupdf could be *one* solution to the problem, but there might also be others
that would still solve the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 474299] Typing long text in PDF forms extremely slow

2023-09-20 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=474299

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #2 from Sune Vuorela  ---
Mostly for other people who finds this:

This was iirc fixed in poppler 23.06. 
https://gitlab.freedesktop.org/poppler/poppler/-/merge_requests/1384/diffs was
a big part of it, but there was a few more fixes here and there.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 474211] Okular crashes when filling the forms

2023-09-07 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=474211

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #2 from Sune Vuorela  ---
This was likely poppler #1383 fixed with poppler commit
62f2eb80fb2a4d4c656e7583584aa73fbc1de511 by Albert.

This is part of poppler 23.05 and newer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 443403] Reduce the size of the digital signature display

2023-08-25 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=443403

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #23 from Sune Vuorela  ---
(In reply to Enrique Artal from comment #22)
> In version 23.08.0 there are some nice improvements about digital signature,
> but the size of the fonts is still very big and non adjustable. Any hope?

It is not currently on *my* work table.

What could help this would be a thorough proposal about
 - What fixed things should be changed - from what and to what. Be specific.
 - What should be adjustable?
- In what dialogs should the adjustability be? How should it look like? Can
you visualize it somehow?
- What should the work flow be for doing this?

And get several of the bug submitters behind it (and preferably also contact
KDE's visual design team for support)

Currently it is mostly people pulling in various directions and a lot of
not-concrete things; if it can somehow be consolidated to a great proposal, it
might help on progress.

About visualization:
 I'm not picky. It can be a photo of a piece of paper with lines on. It can be
mockup tools. Or kolourpaint. Or it can just be a file from QtDesigner

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 473560] Okular cashes when displaying settings configure backends PDF and D-Trust 4.1 id-card inside card reader

2023-08-21 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=473560

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Hi

Can you try collect a minidump ?

https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps
should describe how to do it, and then somehow make it available ?

/Sune

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 473415] Cannot see any signature information for a signed PDF

2023-08-15 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=473415

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #2 from Sune Vuorela  ---
Can you provide a file showing this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 459173] Cannot use USB smartcard to sign document

2023-08-14 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=459173

--- Comment #6 from Sune Vuorela  ---
(In reply to Robert Riemann from comment #5)
> > What version of poppler (The underlying pdf library) are you using ?
> > 
> > The double-pin should be fixed I think, by poppler 23.04, maybe 23.05.
> 
> I am using Poppler 23.06.0 with PDF Backend 0.6.5. Do you have a link on the
> poppler bug report? If it is already merged in 23.06.0 I may reopen it.

There is no bug report on it. I noticed it while doing other stuff.
https://gitlab.freedesktop.org/poppler/poppler/-/merge_requests/1339 is the
merge request.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 459173] Cannot use USB smartcard to sign document

2023-08-14 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=459173

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #4 from Sune Vuorela  ---
(In reply to Robert Riemann from comment #3)
> So with this shared library, it seems to work, even though the PIN has to be
> entered twice and a document password as well for no obvious reason.

What version of poppler (The underlying pdf library) are you using ?

The double-pin should be fixed I think, by poppler 23.04, maybe 23.05.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 471792] Annotations greatly increase PDF file size and massively slow down Okular

2023-07-04 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=471792

--- Comment #6 from Sune Vuorela  ---
(In reply to Joe Breuer from comment #2)
> Trying a 23.07 bump is not immediately accessible to me, since there's
> apparently no release or even git tag yet. Not sure that I want to run git
> master on a production system.

Just fyi; 23.07 is now released.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 471792] Annotations greatly increase PDF file size and massively slow down Okular

2023-07-03 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=471792

--- Comment #4 from Sune Vuorela  ---
(In reply to Joe Breuer from comment #3)
> (In reply to Sune Vuorela from comment #1)
> > Some versions did embed the same fonts multiple times, and your "big"
> > document contains ~140 copies of noto fonts
> 
> What method/tool do you use to obtain this information?

poppler source package (Often in a binary package like poppler-utils or
poppler-tools) contains pdffonts tool that list all of the fonts in the pdf
file.

> I've added a corresponding sample:
> https://github.com/jmbreuer/heap/tree/main/kde-okular-bug-20230630

That file embeds noto sans and noto sans regular. It seems to have grown with
1.5 mb. For two fonts that's not that much off.

> > With poppler 23.06, adding annotations should grow the document with
> > approximately 600k. With poppler 23.07, it should grow the document with
> > approximately 300 k, assuming noto sans (okular default) is used.
> 
> Is that to be expected "per each annotation", or once per adding annotations
> at all, or per annotation type, ...?

Technically, it is per different font, assuming every font is as big as Noto
Sans and compresses with zlib similar to Noto Sans.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 471792] Annotations greatly increase PDF file size and massively slow down Okular

2023-06-30 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=471792

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
What version of the underlying Poppler library are you using ?

Some versions did embed the same fonts multiple times, and your "big" document
contains ~140 copies of noto fonts

It should be fixed in version 23.06 of the poppler library.

With poppler 23.06, adding annotations should grow the document with
approximately 600k. With poppler 23.07, it should grow the document with
approximately 300 k, assuming noto sans (okular default) is used.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 471259] Slowing down, then, sometimes crash when using inline text annotation

2023-06-21 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=471259

--- Comment #5 from Sune Vuorela  ---
(In reply to mabobakrelsedik86 from comment #2)
> (In reply to Sune Vuorela from comment #1)
> > Is it the same okular version?
> > 
> > What version of the underlying "Poppler" library is used ?
> 
> yes, it is the same version of okular
> poppler 23.05.0-1

Is it poppler 23.05 across all your tests, or only in your manjaro ?

Any chance you can try update to 23.06 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 471259] Slowing down, then, sometimes crash when using inline text annotation

2023-06-20 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=471259

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Is it the same okular version?

What version of the underlying "Poppler" library is used ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 471173] git okular build cmake error at 9f498c7f5

2023-06-20 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=471173

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com
 Resolution|--- |NOT A BUG
 Status|REPORTED|RESOLVED

--- Comment #4 from Sune Vuorela  ---
Gentoo has patched all of the testing of okular and changes in e-c-m. 
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-apps/okular/files/okular-21.11.80-tests.patch
and 
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-frameworks/extra-cmake-modules/files/extra-cmake-modules-5.93.0-skip-ecm_add_test-early.patch

A new set of tests has been added in a different location and gentoo should
adapt their patches.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469829] PDF file size increases exponentially after typing in text using the Typewriter tool and Highlighter

2023-06-16 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469829

Sune Vuorela  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED

--- Comment #7 from Sune Vuorela  ---
thanks for confirming. Marking as fixed upstream (Poppler)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 470128] Saving document with resized text creates huge memory footprint

2023-06-14 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=470128

--- Comment #4 from Sune Vuorela  ---
(In reply to dorla.hutch from comment #3)
> (In reply to dorla.hutch from comment #2)
> > From initially 23KiB, it went to 20MiB (at least
> > not 100MiB) …
> 
> After adding the comment box before scaling, it's already 918KiB to be
> honest but after scaling, it becomes 20MiB.

adding ~900kb is kind of expected unless you use poppler (the pdf library
underneath okular) from the newest version (released a couple of weeks ago,
maybe with some of my patches on top), given that noto sans regular is the
default font and it will be embeedded.

But for some reason, though I didn't manage to succeed myself, your file also
contains a 20mb noto sans CJK HK file, so unless you explicitly have specified
it, I'm a bit puzzled. (CJK contains Chinese, Japanese, Korean and maybe other
east asian glyphs)

What are your exact steps to resize the text ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 467144] Support Unicode metadata

2023-06-14 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=467144

Sune Vuorela  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DOWNSTREAM

--- Comment #2 from Sune Vuorela  ---
Fixed in poppler

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 470128] Saving document with resized text creates huge memory footprint

2023-06-13 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=470128

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Can you provide a sample document? Several bugs regarding this has been fixed
in latest poppler release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 467144] Support Unicode metadata

2023-06-13 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=467144

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
https://gitlab.freedesktop.org/poppler/poppler/-/merge_requests/1397 hopefully
fixes it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469829] PDF file size increases exponentially after typing in text using the Typewriter tool and Highlighter

2023-06-12 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469829

--- Comment #4 from Sune Vuorela  ---
Poppler is the underlying library that Okular uses for rendering pdf's and for
writing annotations into pdf's.

What version  of poppler are you using ? 

The version `alstjr7375` is using has a bug that was fixed recently where the
same font gets embedded multiple times. In your "large file" example, the same
font is embedded 6 times; a bug that was fixed probably in poppler 23.06. So
please update to a newer poppler.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 470174] 40 Characters Annotation consuming 20MB

2023-06-12 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=470174

--- Comment #5 from Sune Vuorela  ---
(In reply to der.wolfgang.amadeus.mozart from comment #4)
> Comment on attachment 159566 [details]
> Annotated File from March 2023 with "normal" storage consumption
> 
> I found a file with a relatively big number of annotations created with
> okular (i don't know the version) in march. The storage consumption is
> "normal" - a few KB. I attached the file, I hope it is helpful.

This is kind of interesting. The main reason the files grows are embdednig
fonts.  In the "normal" storage consumption, font embedding fails and it just
adds "Invalid_font" instead of the requested font.

In your "grows to 2mb", the font is wrongly embedded twice and not at all
optimized for storage. 

With only one copy of noto font (The Okular default), not optimized for
storage, approximately 900 kb is the expected growth.

With poppler 23.06, adding a annotation is expected to grow the document with
5-700 kbytes, and when my upcoming changes hopefully lands in poppler 23.07,
annotations are expected to grow the document with 250-300 kbytes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469829] PDF file size increases exponentially after typing in text using the Typewriter tool and Highlighter

2023-06-12 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469829

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #2 from Sune Vuorela  ---
What versions of poppler is involved. There had been some bugs, but fixed by
23.06 version of poppler that make it grow extremely much (By wrongly embedding
the same fonts over and over again).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 470751] Process of adding digital certificates is unintuitive and cumbersome

2023-06-08 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=470751

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Some things to also be aware of:

 - The certificate will often be hardware backed (smartcard or usb dongle), so
can't really be copied around
 - If it is not hardware based, do *not* copy it around. People using it for
real purposes wants to know where their keys are.

The need to restart okular when changing the nss location could probably be
fixed inside poppler, and a side effect of fixing that  will probably fix all
the crash-on-shutdown bugs related to nss.

I'm working on adding an alternative to using nss for digital signatures (using
gpg), and most of the setup bits will kind of be delegated to kleopatra, an app
kind of designed for this. 

Also when using gpg, my patches for okular will hide the path selection for nss
databases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 470174] 40 Characters Annotation consuming 20MB

2023-06-01 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=470174

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #2 from Sune Vuorela  ---
There are at least 3 different fixes needed here.
Poppler (The pdf library used by okular) does not currently compress streams
(font data) on saving. There is a very recent open merge request to address
that.

There is also less space consuming ways of storing font widths in pdf. There is
also a very recent open merge request to address that against poppler.

The pdf standard also supports the concept of only storing a font subsets so
all of the above don't happen with the full font, but only font info for those
needed. That is probably a major task and no current work is happening here.

Using a different font than Noto could also make it grow less. That would be up
to the usability people to change the default. But from a user perspective you
could want to do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 470446] Crash While Editing Forms

2023-05-30 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=470446

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Can you provide the document ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 462312] Okular crash on editing form

2023-05-22 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=462312

Sune Vuorela  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED

--- Comment #6 from Sune Vuorela  ---
Fixed in poppler in the next version, likely called 23.06.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 462312] Okular crash on editing form

2023-05-22 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=462312

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #5 from Sune Vuorela  ---
So, it looks like the form in question wants to use TimesNewRoman as font but
that font is not embedded. At least for the pdf file attacheb by Sylvain. 

TimesNewRoman is not one of the 14 base fonts, though had it been, we would
still have been crashing.

Poppler seems to expect that that should be the case.

I guess the following question is mostly for Albert:

Do we want to do the addFontToDefaultResources dance, or just ignore the
concept of fonts in this case ?  I'm leaning towards adding the fonts to
defaults and at the same time also, if it is one of the 14 base fonts, not
actually embed the fonts, but only reference it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469882] The pdf file does not open and closes with an error.

2023-05-18 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469882

--- Comment #7 from Sune Vuorela  ---
With a fixed poppler, it is also some degree of "cannot validate signature"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469882] The pdf file does not open and closes with an error.

2023-05-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469882

--- Comment #4 from Sune Vuorela  ---
Thanks. Crash happens in poppler. Merge-request submitted. 

Neither the current NSS backend nor the upcoming GPG backend supports GOST as a
hash algorithm though, so neither can validate the signature. I also don't see
it mentioned in 

GOST also isn't mentioned in neither ISO 32000-2:2020, nor in the extenisons
adding more hash algorithms.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469882] The pdf file does not open and closes with an error.

2023-05-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469882

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Any chance you can share the file ? in the bug report, preferred, alternatively
privately.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-05-15 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

--- Comment #7 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #6)
> It seems that kde policy is to use gpg store. Why not okular ?

It's coming.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469705] okular does not find any certificate for digital signing

2023-05-15 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469705

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #4 from Sune Vuorela  ---
(In reply to Philippe ROUBACH from comment #3)
> It's strange because in an issue in gitlab about poppler I read that the
> code for digital signing in poppler is a copy of the code in LibreOffice.
> 
> see https://gitlab.freedesktop.org/poppler/poppler/-/issues/465

The LibreOffice code can interact with both nss and the gpg keystore.

Poppler currently can only interact with the nss keystore (There are patches
under review also letting poppler (and then also okular) interact with the gpg
keystore)

KMail and Kleopatra only uses the gpg keystore.

You can ask poppler about it's available keys with the pdfsig utility, like

`pdfsig -nssdir ~/.pki/nssdb/ -list-nicks`

and see what's available

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469664] Temporary freezing while editing form in pdf document

2023-05-15 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=469664

Sune Vuorela  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED

--- Comment #8 from Sune Vuorela  ---
(In reply to Gaël de Chalendar (aka Kleag) from comment #7)
> I built the master of poppler. Installed it in a local folder. Added its bin
> and lib to PATH and LD_LIBRARY_PATH and started okular from this shell. The
> bug seems to be effectively corrected.

thank you for your quick reply. I'm going to mark this as "resolved, upstream".
It does not require any more work from KDE people; only from poppler people and
distributors.

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   >