[okular] [Bug 474661] Norwegian withholding tax form - wrong calculation of percent value

[Volker Krause]

https://bugs.kde.org/show_bug.cgi?id=474661

--- Comment #10 from Volker Krause  ---
(In reply to Albert Astals Cid from comment #8)
> The internet says it is a localized number
> 
> pdfium and pdf.js say "it doesn't matter, just replace the , to . and parse
> that" (with the understanding that there's no thousand separators i guess)

Indeed, assuming there are no group separators for all string to number
conversions fixes this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 474661] Norwegian withholding tax form - wrong calculation of percent value

[Volker Krause]

https://bugs.kde.org/show_bug.cgi?id=474661

--- Comment #7 from Volker Krause  ---
(In reply to Albert Astals Cid from comment #6)
> Are you asking about sepStyle in AFNumber_Format?

The output part of that is clear I think (and the implementation matches that),
the question is how the input should be interpreted in case of that being a
string rather than a number. The current implementation is using the current
locale format first, and then the alternate format. Unconditionally using the
English format would probably fix this, but the current logic presumably didn't
happen by accident, so there must be more to this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 474661] Norwegian withholding tax form - wrong calculation of percent value

[Volker Krause]

https://bugs.kde.org/show_bug.cgi?id=474661

--- Comment #5 from Volker Krause  ---
It only triggers when the result has exactly three decimals, as only that
produces a string that can be misinterpreted as a value with a dot as group
separator instead of decimal separator.

This probably isn't even terribly hard to fix, the problem is I am not finding
the involved methods in the PDF JS API spec to know how exactly those are
supposed to behave.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 474661] Norwegian withholding tax form - wrong calculation of percent value

[Volker Krause]

https://bugs.kde.org/show_bug.cgi?id=474661

Volker Krause  changed:

   What|Removed |Added

 CC||vkra...@kde.org

--- Comment #2 from Volker Krause  ---
This seems to happen only in locales with a comma as decimal separator. It
breaks when the string "33.335" is passed to JSUtil::stringToNumber(), which
results in the number 5 in a locale with a comma decimal separator, rather
than the expected 33.335, ie. this happens for numbers where the conversion is
ambiguous between different locales.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D25553: Port away from deprecated Bar|Desktop|SmallIcon methods

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:6cf2242cd94b: Port away from deprecated 
Bar|Desktop|SmallIcon methods (authored by vkrause).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25553?vs=70366=70599

REVISION DETAIL
  https://phabricator.kde.org/D25553

AFFECTED FILES
  conf/dlgperformance.cpp
  ui/ktreeviewsearchline.cpp
  ui/pageviewutils.cpp
  ui/presentationwidget.cpp
  ui/thumbnaillist.cpp

To: vkrause, aacid
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25553: Port away from deprecated Bar|Desktop|SmallIcon methods

[Volker Krause]

vkrause added a reviewer: aacid.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25553

To: vkrause, aacid
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25553: Port away from deprecated Bar|Desktop|SmallIcon methods

[Volker Krause]

vkrause added a task: T11654: Deprecate 
SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of 
KIconLoader or QIcon API.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25553

To: vkrause
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25553: Port away from deprecated Bar|Desktop|SmallIcon methods

[Volker Krause]

vkrause created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
vkrause requested review of this revision.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25553

AFFECTED FILES
  conf/dlgperformance.cpp
  ui/ktreeviewsearchline.cpp
  ui/pageviewutils.cpp
  ui/presentationwidget.cpp
  ui/thumbnaillist.cpp

To: vkrause
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

T11542: Remove KHTML

[Volker Krause]

vkrause triaged this task as "Normal" priority.

TASK DETAIL
  https://phabricator.kde.org/T11542

To: vkrause
Cc: ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, 
knauss, GB_2, niccolove, kpiwowarski, vkrause, cordlandwehr, dfaure

T10812: KDE Applications

[Volker Krause]

vkrause added a comment.


  In T10812#184405 , @ngraham wrote:
  
  > As an intermediate step, if we put the Frameworks on the Plasma schedule, 
we wouldn't necessarily need to blobify them into one big framework again; they 
could continue to be separate, but just use the Plasma release schedule.
  >
  > From a code perspective, this would eliminate a whole class of issues we 
currently face where a feature or bugfix requires changes to both a Framework 
and Plasma. Right now these kinds of changes must be carefully planned and 
often require ifdefs or delaying the commit. It also makes life difficult for 
LTS distros because they don't get bugfixes to the Frameworks version they 
shipped with unless they have someone who basically browses the code full-time 
and cherry-picks fixes. Whereas with Plasma, they can just grab the source 
tarball of the bugfix releases and ship updates. If Frameworks moved to the 
Plasma release schedule, those distros could do that with Frameworks too, 
making it easier to ensure a higher level of quality for their users.
  
  
  That might be true for Plasma, but it would worsen the situation considerably 
for anyone else IMHO. While it now takes ~4w until a KF5 fix is released, or a 
new feature becomes available for application developers, this would then take 
3-4x longer. So we'd probably end up syncing the Application release cycle as 
well to mitigate this, and following that we'd probably also end up depending 
on unreleased Frameworks in both Plasma and Application master branches 
(something not particular popular with Application developers at least). We've 
been there before, in KDE3 times.

TASK DETAIL
  https://phabricator.kde.org/T10812

To: ngraham, vkrause
Cc: apol, jriddell, xyquadrat, jtamate, vkrause, lbeltrame, ltoscano, cfeck, 
aacid, #yakuake, #okular, #dolphin, #kate, #spectacle, #konsole, #gwenview, 
#kde_pim, #kde_games, #kde_applications, ngraham

T10812: KDE Applications

[Volker Krause]

vkrause added a comment.


  In T10812#182242 , @cfeck wrote:
  
  > [1] I would even go as far and to also merge KF5 Frameworks - after all 
these years we have to admit that the "Frameworks idea" (people using them 
outside of KDE) has never materialized.
  
  
  This bit I have to strongly disagree with. Sure, KF5 is not at the same level 
of Qt, but it's far from not being used externally. Here's just three examples 
for a single niche framework (syntax highlighting) from the top of my head:
  
  - https://cullmann.io/posts/qt-creator-4-9-uses-ksyntaxhighlighting/ 
(QtCreator)
  - https://kate-editor.org/2018/10/21/mit-licensed-ksyntaxhighlighting-usage/ 
(AbsInt)
  - https://github.com/KDAB/GammaRay/blob/master/CMakeLists.txt#L540 (GammaRay)
  
  All three have resulted in useful upstream contributions btw.

TASK DETAIL
  https://phabricator.kde.org/T10812

To: ngraham, vkrause
Cc: vkrause, lbeltrame, ltoscano, cfeck, aacid, #yakuake, #okular, #dolphin, 
#kate, #spectacle, #konsole, #gwenview, #kde_pim, #kde_games, 
#kde_applications, ngraham

D19037: Remove dependency on okularpart from the mobile components

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:bc4c19eb9233: Remove dependency on okularpart from the 
mobile components (authored by vkrause).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19037?vs=51757=52361

REVISION DETAIL
  https://phabricator.kde.org/D19037

AFFECTED FILES
  conf/settings_mobile.kcfgc
  mobile/components/CMakeLists.txt
  mobile/components/settings.h

To: vkrause, aacid
Cc: aacid, okular-devel, tfella, ngraham, darcyshen

D19037: Remove dependency on okularpart from the mobile components

[Volker Krause]

vkrause added a comment.


  Sure, no doubt this is super ugly and just a tiny bit better on the previous 
situation.
  I failed to come up with an alternative that is nicer and still minimally 
invasive, so I'd rather try to untangle this in small steps while trying to 
remove Android porting scaffolding in the whole stack up to Okular.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19037

To: vkrause, aacid
Cc: aacid, okular-devel, tfella, ngraham, darcyshen

D19037: Remove dependency on okularpart from the mobile components

[Volker Krause]

vkrause created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This only depended on okularpart due to the export header used in the
  kcfgc file, so use a dedicated one for the mobile components that doesn't
  export anything.
  
  This enables disabling the part build for mobile-only builds such as
  Android, and thus removing the need for some difficult dependencies
  like KParts.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19037

AFFECTED FILES
  conf/settings_mobile.kcfgc
  mobile/components/CMakeLists.txt
  mobile/components/settings.h

To: vkrause
Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:dfe6f26c6af8: Fix crash on canceling the file open dialog 
(authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18397?vs=50371=50866#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18397?vs=50371=50866

REVISION DETAIL
  https://phabricator.kde.org/D18397

AFFECTED FILES
  mobile/android/src/OpenFileActivity.java

To: vkrause, apol, nicolasfella, aacid
Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D18399: Fix launching Okular by opening a document from the file browser

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:a9540cf3cef1: Fix launching Okular by opening a document 
from the file browser (authored by vkrause).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18399?vs=49905=50868

REVISION DETAIL
  https://phabricator.kde.org/D18399

AFFECTED FILES
  mobile/android/src/OpenFileActivity.java
  mobile/app/android.cpp
  mobile/app/android.h
  mobile/app/main.cpp

To: vkrause, aacid
Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18398: Fix a few more QML runtime errors/warnings

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:1fd9c052a6c7: Fix a few more QML runtime errors/warnings 
(authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18398?vs=49904=50867#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18398?vs=49904=50867

REVISION DETAIL
  https://phabricator.kde.org/D18398

AFFECTED FILES
  mobile/app/package/contents/ui/TreeDelegate.qml

To: vkrause, aacid
Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18396: Fix ToC icon, and remove unnecessary dependency on KDeclarative

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:e0e4a1689c96: Fix ToC icon, and remove unnecessary 
dependency on KDeclarative (authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18396?vs=49902=50865#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18396?vs=49902=50865

REVISION DETAIL
  https://phabricator.kde.org/D18396

AFFECTED FILES
  mobile/app/package/contents/ui/OkularDrawer.qml
  mobile/app/package/contents/ui/TreeDelegate.qml

To: vkrause, aacid
Cc: mart, okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

[Volker Krause]

vkrause updated this revision to Diff 50371.
vkrause added a comment.


  Check result code as suggested by Nico.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18397?vs=49903=50371

BRANCH
  arcpatch-D18397

REVISION DETAIL
  https://phabricator.kde.org/D18397

AFFECTED FILES
  mobile/android/src/OpenFileActivity.java

To: vkrause, apol
Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D18399: Fix launching Okular by opening a document from the file browser

[Volker Krause]

vkrause created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  There's two issues here:
  
  - Activity::onCreate triggered before the C++ side was loaded, so the call to 
C++ failed (causing a crash). So delay that until we are ready.
  - The static instance of URIHandler in the header caused it to duplicate into 
each translation unit, causing main.cpp to not see what android.cpp wrote into 
it.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18399

AFFECTED FILES
  mobile/android/src/OpenFileActivity.java
  mobile/app/android.cpp
  mobile/app/android.h
  mobile/app/main.cpp

To: vkrause
Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18398: Fix a few more QML runtime errors/warnings

[Volker Krause]

vkrause created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
vkrause requested review of this revision.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18398

AFFECTED FILES
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/ThumbnailsBase.qml
  mobile/app/package/contents/ui/TreeDelegate.qml

To: vkrause
Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

[Volker Krause]

vkrause created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
vkrause requested review of this revision.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18397

AFFECTED FILES
  mobile/android/src/OpenFileActivity.java

To: vkrause
Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18396: Fix ToC icon, and remove unnecessary dependency on KDeclarative

[Volker Krause]

vkrause created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
vkrause requested review of this revision.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18396

AFFECTED FILES
  mobile/app/package/contents/ui/OkularDrawer.qml
  mobile/app/package/contents/ui/TreeDelegate.qml

To: vkrause
Cc: okular-devel, tfella, ngraham, darcyshen, aacid