[Okular-devel] [okular] [Bug 334251] Tools don't work if any tab is in review mode
https://bugs.kde.org/show_bug.cgi?id=334251 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Version Fixed In||14.12.0 Latest Commit||http://commits.kde.org/okul ||ar/b069e3557f995b3759a50516 ||0e3f009e2267506c Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #7 from Albert Astals Cid aa...@kde.org --- Git commit b069e3557f995b3759a505160e3f009e2267506c by Albert Astals Cid, on behalf of Jonathan Doman. Committed on 10/12/2014 at 14:33. Pushed by aacid into branch 'Applications/14.12'. Allow each PageView to use a different tool Keep a local MouseMode setting, and don't rely on the value returned by Settings::mouseMode(). REVIEW: 120660 FIXED-IN: 14.12.0 M +25 -17 ui/pageview.cpp http://commits.kde.org/okular/b069e3557f995b3759a505160e3f009e2267506c -- You are receiving this mail because: You are the assignee for the bug. Make the world a better place. Donate to our year end fundraiser https://www.kde.org/fundraisers/yearend2014/ ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334251] Tools don't work if any tab is in review mode
https://bugs.kde.org/show_bug.cgi?id=334251 --- Comment #4 from Albert Astals Cid aa...@kde.org --- 1 + 2: Because it's what we use to pass around the settings change, you write the setting and then rely on slotNewConfig to set everything correctly, if you remove slotNewConfig and writeConfig you're going to need to rewrite lots of stuff. 3. Because people asked for that feature ;) People is going to hate you if you remove the features they love and use ;) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334251] Tools don't work if any tab is in review mode
https://bugs.kde.org/show_bug.cgi?id=334251 --- Comment #6 from Jonathan Doman jonathan.do...@gmail.com --- So I tested an older version (tag v4.10.97) and this bug exists for multiple windows as well. It's probably been around forever. And there are similar bugs for other settings like continuous view mode. Basically I think the global Settings object is very inadequate for how it's used, and should be re-architected. I guess I'll keep trying to find a short term solution, though. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334251] Tools don't work if any tab is in review mode
https://bugs.kde.org/show_bug.cgi?id=334251 --- Comment #3 from Jonathan Doman jonathan.do...@gmail.com --- I took some time to look at this and I'm not sure how to fix it. The problem is that changing the mouse mode writes the global Settings, which triggers all the Parts to reload (and potentially overwrite) the Settings. We could: 1. Don't watch for the Settings::configChanged signal. This is my preference, as I wouldn't expect the program to reload settings whenever the config file is written to. 2. Don't constantly write settings to disk. Most Settings mutations are followed by a writeConfig(), which seems unnecessary to me. Why not just writeConfig() once when the program is exiting? 3. Remove MouseMode as a global setting. Why not just always start the program in Browse mode? I would ultimately prefer to get rid of all persistent, implicit settings and make everything non-configurable or explicitly configurable because I don't think there's an intuitive way to resolve settings when multiple program instances are simultaneously altering them. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334251] Tools don't work if any tab is in review mode
https://bugs.kde.org/show_bug.cgi?id=334251 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Priority|NOR |HI Status|UNCONFIRMED |CONFIRMED CC||aa...@kde.org Ever confirmed|0 |1 --- Comment #1 from Albert Astals Cid aa...@kde.org --- :/ This is bad :/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
