Re: [Okular-devel] About bug 326844

[saheb preet singh]

ok i uploaded the diff to review board :-

https://git.reviewboard.kde.org/r/115283/



On Fri, Jan 24, 2014 at 5:10 AM, Albert Astals Cid aa...@kde.org wrote:

 El Dimecres, 22 de gener de 2014, a les 19:04:40, saheb preet singh va
 escriure:
  hi,

 Hi

  I was working on bug number 326844.
 
  https://bugs.kde.org/show_bug.cgi?id=326844
 
  It was a feature request to resize the window to fit the current page
 size.
 
  I solved this bug up to some extent and was stuck in a small problem from
  last two three days. Here are some screenshot of what is happening.

 Maybe you can upload your diff to reviewboard so we can see it and try it
 ourselves? For me it's always easier to understand the problems someone are
 having if i can run the software and experience them myself.

 Cheers,
   Albert

 
  Before selecting resize window to fit page:-
 
  [image: Inline image 3]
 
  After selecting resize to fit page:-
 
  [image: Inline image 4]
 
  I am using the resize method for resizing the window.
 
  The window is resizing  as required but sometimes it doesn't resizes . It
  has to be moved by mouse and then again click on the button in the menu
 to
  resize the window again.  Once it is moved by mouse, it works fine. Now,
  when i change the zoom level of the current page, the problem starts
 again.
 
  I think the problem occurs due to something happening in the other
 portion
  of the code.
 
  I searched about it on the internet and nobody was able to answer the
  solution to people with same problem. There are some alternative
 solutions
  to the problem:-
 
  == Use set geometry instead of resize which works fine. but would have
 to
  be taken care of the size of the screen and the original position of the
  window. Also, repainting the portion outside the window when the window
 is
  resized to a smaller window.
 
  == Use a timer which will signal a slot which in turn will resize the
  window, but that might require qsignalmapper to map the width and height
 to
  the slot. ( I didn't tried this solution ).
 
  The best solution i could find on the internet is this
  http://qt-project.org/forums/viewthread/25648
 
  Please guide me how should I solve this problem. Should I use such
 methods
  which don't appear to be clean.
 
  Thanks,
  Saheb Preet Singh

 ___
 Okular-devel mailing list
 Okular-devel@kde.org
 https://mail.kde.org/mailman/listinfo/okular-devel

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] About bug 326844

[Albert Astals Cid]

El Dimecres, 22 de gener de 2014, a les 19:04:40, saheb preet singh va 
escriure:
 hi,

Hi 

 I was working on bug number 326844.
 
 https://bugs.kde.org/show_bug.cgi?id=326844
 
 It was a feature request to resize the window to fit the current page size.
 
 I solved this bug up to some extent and was stuck in a small problem from
 last two three days. Here are some screenshot of what is happening.

Maybe you can upload your diff to reviewboard so we can see it and try it 
ourselves? For me it's always easier to understand the problems someone are 
having if i can run the software and experience them myself.

Cheers,
  Albert

 
 Before selecting resize window to fit page:-
 
 [image: Inline image 3]
 
 After selecting resize to fit page:-
 
 [image: Inline image 4]
 
 I am using the resize method for resizing the window.
 
 The window is resizing  as required but sometimes it doesn't resizes . It
 has to be moved by mouse and then again click on the button in the menu to
 resize the window again.  Once it is moved by mouse, it works fine. Now,
 when i change the zoom level of the current page, the problem starts again.
 
 I think the problem occurs due to something happening in the other portion
 of the code.
 
 I searched about it on the internet and nobody was able to answer the
 solution to people with same problem. There are some alternative solutions
 to the problem:-
 
 == Use set geometry instead of resize which works fine. but would have to
 be taken care of the size of the screen and the original position of the
 window. Also, repainting the portion outside the window when the window is
 resized to a smaller window.
 
 == Use a timer which will signal a slot which in turn will resize the
 window, but that might require qsignalmapper to map the width and height to
 the slot. ( I didn't tried this solution ).
 
 The best solution i could find on the internet is this
 http://qt-project.org/forums/viewthread/25648
 
 Please guide me how should I solve this problem. Should I use such methods
 which don't appear to be clean.
 
 Thanks,
 Saheb Preet Singh

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel