Re: [Okular-devel] Review Request: Properties dialog: switch to QFormLayout and showing icon for mime type
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107357/ --- (Updated Dec. 31, 2012, 8:17 p.m.) Review request for Okular. Changes --- Fixing buddy problem by calling QFormLayout::addRow(QWidget*, QWidget*) instead of QFormLayout::addRow(const QString , QWidget*). Minor fix in the mimetype label internationalization. Description --- This patch changes the properties dialog to use QFormLayout instead of a two-column QGridLayout. This should make the dialog more compatible with other user interfaces. For the mime type row, instead of just showing the mime type's name, a small QLabel is used to show the mime type's icon. Maybe it would be a good idea to not only show the mime type's name, but also the description (KMimeType::comment(..)). Example: PDF Document (application/pdf) Diffs (updated) - ui/propertiesdialog.cpp 2ef8220 Diff: http://git.reviewboard.kde.org/r/107357/diff/ Testing --- Screenshots --- QFormLayout and mime type icon http://git.reviewboard.kde.org/r/107357/s/835/ Thanks, Thomas Fischer ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Properties dialog: switch to QFormLayout and showing icon for mime type
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107357/#review24306 --- I was just going to apply the diff but realized with the new code we get label buddies and that makes the _ appear in almost all the labels of the first column that makes no sense as you can't use Alt+key to focus on the buddy since the buddy is also a label that can't hold focus. Can you please try to make those not appear? - Albert Astals Cid On Nov. 17, 2012, 7:51 p.m., Thomas Fischer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107357/ --- (Updated Nov. 17, 2012, 7:51 p.m.) Review request for Okular. Description --- This patch changes the properties dialog to use QFormLayout instead of a two-column QGridLayout. This should make the dialog more compatible with other user interfaces. For the mime type row, instead of just showing the mime type's name, a small QLabel is used to show the mime type's icon. Maybe it would be a good idea to not only show the mime type's name, but also the description (KMimeType::comment(..)). Example: PDF Document (application/pdf) Diffs - ui/propertiesdialog.cpp 2ef8220 Diff: http://git.reviewboard.kde.org/r/107357/diff/ Testing --- Screenshots --- QFormLayout and mime type icon http://git.reviewboard.kde.org/r/107357/s/835/ Thanks, Thomas Fischer ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Properties dialog: switch to QFormLayout and showing icon for mime type
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107357/ --- (Updated Nov. 17, 2012, 10:56 a.m.) Review request for Okular. Changes --- Updating description Description (updated) --- This patch changes the properties dialog to use QFormLayout instead of a two-column QGridLayout. This should make the dialog more compatible with other user interfaces. For the mime type row, instead of just showing the mime type's name, a small QLabel is used to show the mime type's icon. Maybe it would be a good idea to not only show the mime type's name, but also the description (KMimeType::comment(..)). Example: PDF Document (application/pdf) Diffs - ui/propertiesdialog.cpp 2ef8220 Diff: http://git.reviewboard.kde.org/r/107357/diff/ Testing --- Screenshots --- QFormLayout and mime type icon http://git.reviewboard.kde.org/r/107357/s/835/ Thanks, Thomas Fischer ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Properties dialog: switch to QFormLayout and showing icon for mime type
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107357/#review22143 --- ui/propertiesdialog.cpp http://git.reviewboard.kde.org/r/107357/#comment17036 KMimeType::mimeType may return 0, please account for that ui/propertiesdialog.cpp http://git.reviewboard.kde.org/r/107357/#comment17037 convert the QLatin1String into a i18nc so translators can change the order or the way of showing, maybe () is not usual, if they need it - Albert Astals Cid On Nov. 17, 2012, 5:09 p.m., Thomas Fischer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107357/ --- (Updated Nov. 17, 2012, 5:09 p.m.) Review request for Okular. Description --- This patch changes the properties dialog to use QFormLayout instead of a two-column QGridLayout. This should make the dialog more compatible with other user interfaces. For the mime type row, instead of just showing the mime type's name, a small QLabel is used to show the mime type's icon. Maybe it would be a good idea to not only show the mime type's name, but also the description (KMimeType::comment(..)). Example: PDF Document (application/pdf) Diffs - ui/propertiesdialog.cpp 2ef8220 Diff: http://git.reviewboard.kde.org/r/107357/diff/ Testing --- Screenshots --- QFormLayout and mime type icon http://git.reviewboard.kde.org/r/107357/s/835/ Thanks, Thomas Fischer ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Properties dialog: switch to QFormLayout and showing icon for mime type
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107357/ --- (Updated Nov. 17, 2012, 5:09 p.m.) Review request for Okular. Changes --- Instead of writing out the raw mimetype (example: application/pdf), it shows a description of the mime type followed by the mime type's name in parentheses (example: PDF document (application/pdf)). Description --- This patch changes the properties dialog to use QFormLayout instead of a two-column QGridLayout. This should make the dialog more compatible with other user interfaces. For the mime type row, instead of just showing the mime type's name, a small QLabel is used to show the mime type's icon. Maybe it would be a good idea to not only show the mime type's name, but also the description (KMimeType::comment(..)). Example: PDF Document (application/pdf) Diffs (updated) - ui/propertiesdialog.cpp 2ef8220 Diff: http://git.reviewboard.kde.org/r/107357/diff/ Testing --- Screenshots --- QFormLayout and mime type icon http://git.reviewboard.kde.org/r/107357/s/835/ Thanks, Thomas Fischer ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Properties dialog: switch to QFormLayout and showing icon for mime type
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107357/ --- (Updated Nov. 17, 2012, 7:51 p.m.) Review request for Okular. Changes --- Addressing issues: - KMimeType::mimeType may return 0, please account for that - convert the QLatin1String into a i18nc so translators can change the order or the way of showing, maybe () is not usual, if they need it Description --- This patch changes the properties dialog to use QFormLayout instead of a two-column QGridLayout. This should make the dialog more compatible with other user interfaces. For the mime type row, instead of just showing the mime type's name, a small QLabel is used to show the mime type's icon. Maybe it would be a good idea to not only show the mime type's name, but also the description (KMimeType::comment(..)). Example: PDF Document (application/pdf) Diffs (updated) - ui/propertiesdialog.cpp 2ef8220 Diff: http://git.reviewboard.kde.org/r/107357/diff/ Testing --- Screenshots --- QFormLayout and mime type icon http://git.reviewboard.kde.org/r/107357/s/835/ Thanks, Thomas Fischer ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Properties dialog: switch to QFormLayout and showing icon for mime type
On Nov. 17, 2012, 2:14 p.m., Albert Astals Cid wrote: The QFormLayout is not needed, that's a class totally tailored for small screen state devices (phones) and it's not going to happen that we port this dialog to a phone. The icon thing looks like a nice addition and i don't object to the showing of the comment either, The QFormLayout is not needed, that's a class totally tailored for small screen state devices (phones) According to the documentation, this is only one argument to use this class. The other one is that it adepts to the desktop's settings (KDE, Gnome, Windows, Mac) regarding layout alignment. In this respect, it is an improvement over the previous addWidget(..., Qt::AlignRight); Finally, the addRow statement takes care of creating the label instead of creating and layouting QLabel *key manually. The icon thing looks like a nice addition and i don't object to the showing of the comment either Working on that ... - Thomas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107357/#review22121 --- On Nov. 17, 2012, 10:56 a.m., Thomas Fischer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107357/ --- (Updated Nov. 17, 2012, 10:56 a.m.) Review request for Okular. Description --- This patch changes the properties dialog to use QFormLayout instead of a two-column QGridLayout. This should make the dialog more compatible with other user interfaces. For the mime type row, instead of just showing the mime type's name, a small QLabel is used to show the mime type's icon. Maybe it would be a good idea to not only show the mime type's name, but also the description (KMimeType::comment(..)). Example: PDF Document (application/pdf) Diffs - ui/propertiesdialog.cpp 2ef8220 Diff: http://git.reviewboard.kde.org/r/107357/diff/ Testing --- Screenshots --- QFormLayout and mime type icon http://git.reviewboard.kde.org/r/107357/s/835/ Thanks, Thomas Fischer ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
