Re: [Okular-devel] Review Request: Show paper size names like ISO/DIN A4 instead of just paper size in numbers
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107350/#review24307 --- This review has been submitted with commit 96c69528d436ee910fb376fd6b891ae289d1b227 by Albert Astals Cid on behalf of Thomas Fischer to branch master. - Commit Hook On Nov. 17, 2012, 11:10 a.m., Thomas Fischer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107350/ --- (Updated Nov. 17, 2012, 11:10 a.m.) Review request for Okular. Description --- This patch makes Okular not only show a document's size (width x height) in inches or millimeters, but it will try to guess the paper format's name as well. Example: So far, for an opened PDF file in the Properties dialog (File - Properties), it would print Page Size: 210,016 x 297,011 mm. Using this patch, it would say instead 210,016 x 297,011 mm (portrait ISO/DIN A4) Diffs - core/document.cpp 3e4e21a core/document_p.h 4a20561 Diff: http://git.reviewboard.kde.org/r/107350/diff/ Testing --- Works for example files using format ISO/DIN A4 and legal. No example files for other formats available (e.g. Japanese JIS-B or tabloid). Screenshots --- Showing paper format portrait ISO/DIN A4 http://git.reviewboard.kde.org/r/107350/s/834/ Thanks, Thomas Fischer ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request: Show paper size names like ISO/DIN A4 instead of just paper size in numbers
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107350/ --- (Updated Nov. 16, 2012, 10:33 p.m.) Review request for Okular. Changes --- Rewriting patch to use big switch to cover all paper sizes QPrinter knows. Avoids i18n for static constants. Description --- This patch makes Okular not only show a document's size (width x height) in inches or millimeters, but it will try to guess the paper format's name as well. Example: So far, for an opened PDF file in the Properties dialog (File - Properties), it would print Page Size: 210,016 x 297,011 mm. Using this patch, it would say instead 210,016 x 297,011 mm (portrait ISO/DIN A4) Diffs (updated) - core/document.cpp 3e4e21a core/document_p.h 4a20561 Diff: http://git.reviewboard.kde.org/r/107350/diff/ Testing --- Works for example files using format ISO/DIN A4 and legal. No example files for other formats available (e.g. Japanese JIS-B or tabloid). Screenshots --- Showing paper format portrait ISO/DIN A4 http://git.reviewboard.kde.org/r/107350/s/834/ Thanks, Thomas Fischer ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
