Re: [Okular-devel] Review Request 120660: Allow each PageView to use a different tool

2014-12-10 Thread Jonathan Doman

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120660/
---

(Updated Dec. 10, 2014, 2:34 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Bugs: 334251
http://bugs.kde.org/show_bug.cgi?id=334251


Repository: okular


Description
---

Keep a local MouseMode setting, and don't rely on the value returned by 
Settings::mouseMode().

In the bug report, I stated that each tab should be allowed to use different 
tools. No one objected, but after testing it's not clear this is the right 
answer. The existing behavior was to force all tabs/windows to use the same 
tool, but then it's not clear what to do with review mode.


Diffs
-

  ui/pageview.cpp 17e66f4a3b420bbcaf281532fa9d84379c74d48c 

Diff: https://git.reviewboard.kde.org/r/120660/diff/


Testing
---

Followed steps in bug report for both tabs and windows to make sure different 
tools are allowed.


Thanks,

Jonathan Doman

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 120660: Allow each PageView to use a different tool

2014-12-10 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120660/#review71707
---

Ship it!


Ship It!

- Albert Astals Cid


On oct. 19, 2014, 6:52 p.m., Jonathan Doman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120660/
> ---
> 
> (Updated oct. 19, 2014, 6:52 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 334251
> http://bugs.kde.org/show_bug.cgi?id=334251
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Keep a local MouseMode setting, and don't rely on the value returned by 
> Settings::mouseMode().
> 
> In the bug report, I stated that each tab should be allowed to use different 
> tools. No one objected, but after testing it's not clear this is the right 
> answer. The existing behavior was to force all tabs/windows to use the same 
> tool, but then it's not clear what to do with review mode.
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 17e66f4a3b420bbcaf281532fa9d84379c74d48c 
> 
> Diff: https://git.reviewboard.kde.org/r/120660/diff/
> 
> 
> Testing
> ---
> 
> Followed steps in bug report for both tabs and windows to make sure different 
> tools are allowed.
> 
> 
> Thanks,
> 
> Jonathan Doman
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] Review Request 120660: Allow each PageView to use a different tool

2014-10-19 Thread Jonathan Doman

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120660/
---

Review request for Okular.


Bugs: 334251
http://bugs.kde.org/show_bug.cgi?id=334251


Repository: okular


Description
---

Keep a local MouseMode setting, and don't rely on the value returned by 
Settings::mouseMode().

In the bug report, I stated that each tab should be allowed to use different 
tools. No one objected, but after testing it's not clear this is the right 
answer. The existing behavior was to force all tabs/windows to use the same 
tool, but then it's not clear what to do with review mode.


Diffs
-

  ui/pageview.cpp 17e66f4a3b420bbcaf281532fa9d84379c74d48c 

Diff: https://git.reviewboard.kde.org/r/120660/diff/


Testing
---

Followed steps in bug report for both tabs and windows to make sure different 
tools are allowed.


Thanks,

Jonathan Doman

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel