[okular] [Bug 416229] Zooming out with CTRL+mousewheel does not work correctly anymore

2020-01-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=416229

--- Comment #9 from Albert Astals Cid  ---
(In reply to Oliver Sander from comment #8)
> > At some point we should either remove trim margins or someone should fix 
> > all its bugs
> 
> BTW: Where is the code that determines what the margin is?

Utils::imageBoundingBox

But I don't think there's any bug there, that code is relatively simple.

The code for this bug is probably somewhere else that gets confused when
calculating the zoom.

There's also lots of other bugs related to handling of size of pages since they
are no longer the size we expect them to be once you trim the margins.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 416229] Zooming out with CTRL+mousewheel does not work correctly anymore

2020-01-16 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=416229

--- Comment #8 from Oliver Sander  ---
> At some point we should either remove trim margins or someone should fix all 
> its bugs

BTW: Where is the code that determines what the margin is?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 416229] Zooming out with CTRL+mousewheel does not work correctly anymore

2020-01-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=416229

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |DUPLICATE
 Status|NEEDSINFO   |RESOLVED

--- Comment #7 from Albert Astals Cid  ---
I guess then we can mark it as duplicate.

At some point we should either remove trim margins or someone should fix all
its bugs

*** This bug has been marked as a duplicate of bug 342003 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 416229] Zooming out with CTRL+mousewheel does not work correctly anymore

2020-01-15 Thread John van Spaandonk
https://bugs.kde.org/show_bug.cgi?id=416229

--- Comment #6 from John van Spaandonk  ---
(In reply to Yuri Chornoivan from comment #2)
> Can you tell if the "View -> Trim view -> Trim margins" menu item is
> selected?
> 
> Thanks in advance for your answer.

[this reply might be double with another reply I did via email but I changed it
a bit]
Yes indeed, If I deselect "Trim Margins" and also do not select "Trim to
selection" it works as expected.

Please close this bug report if you do not agree to the suggestion below.

I still think this is a usability issue.
While I now understand the behavior, my honest expectation was that the
keyboard controls for zoom would always mirror the behavior of the "zoom level"
box, so overriding any trim views. 

I think it makes perfect sense if the keyboard controls just mirror making a
selection in the "zoom level" window. Therefore they should have the same
freedom in entering another zoom level, irrespective of the selected "zoom to"
option.
ps. I am very happy that you react instantaneously to this bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 416229] Zooming out with CTRL+mousewheel does not work correctly anymore

2020-01-15 Thread John van Spaandonk
https://bugs.kde.org/show_bug.cgi?id=416229

--- Comment #5 from John van Spaandonk  ---
On 2020-01-14 18:17, Yuri Chornoivan wrote:
> https://bugs.kde.org/show_bug.cgi?id=416229
>
> Yuri Chornoivan  changed:
>
> What|Removed |Added
> 
>   CC||yurc...@ukr.net
>
> --- Comment #2 from Yuri Chornoivan  ---
> Can you tell if the "View -> Trim view -> Trim margins" menu item is selected?
>
> Thanks in advance for your answer.
>
Yes indeed, If I deselect "Trim Margins" and also do not select "Trim to 
selection" it works as expected.
I will close this report then.
In all honesty, while I now understand the behavior, my honest 
expectation was that the keyboard controls for zoom would always zoom, 
overriding / disabling any trim views. But I understand why you see the 
keyboard controls as mirroring the behavior of the "zoom level" window, 
and not overriding other settings.
ps. I am very happy that you react instantaneously to this bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 416229] Zooming out with CTRL+mousewheel does not work correctly anymore

2020-01-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=416229

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

--- Comment #4 from Nate Graham  ---
Works for me too with git master when not using Trim Margins.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 416229] Zooming out with CTRL+mousewheel does not work correctly anymore

2020-01-14 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=416229

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #3 from Albert Astals Cid  ---
waiting for the trim margins answer

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 416229] Zooming out with CTRL+mousewheel does not work correctly anymore

2020-01-14 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=416229

Yuri Chornoivan  changed:

   What|Removed |Added

 CC||yurc...@ukr.net

--- Comment #2 from Yuri Chornoivan  ---
Can you tell if the "View -> Trim view -> Trim margins" menu item is selected?

Thanks in advance for your answer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 416229] Zooming out with CTRL+mousewheel does not work correctly anymore

2020-01-14 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=416229

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #1 from Oliver Sander  ---
I cannot reproduce this with Okular from the current git master.  Zoom with
ctrl+mouse wheel seems to work as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.