[okular] [Bug 479942] Okular crashes when saving a document

2024-01-25 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=479942

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/okular/-/commit/12e40e |hics/okular/-/commit/f0e98b
   |0d360f9912eee1b162d61e3f183 |d5315232f7dc86edc1002d7fdf2
   |676ea5a |2181413

--- Comment #6 from Albert Astals Cid  ---
Git commit f0e98bd5315232f7dc86edc1002d7fdf22181413 by Albert Astals Cid, on
behalf of Sune Vuorela.
Committed on 25/01/2024 at 23:17.
Pushed by aacid into branch 'release/24.02'.

Button groups can span multiple pages

The code needs to be aware of that.
(cherry picked from commit 12e40e0d360f9912eee1b162d61e3f183676ea5a)

M  +17   -2core/documentcommands.cpp
M  +1-0core/documentcommands_p.h
M  +13   -2part/formwidgets.cpp

https://invent.kde.org/graphics/okular/-/commit/f0e98bd5315232f7dc86edc1002d7fdf22181413

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-25 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=479942

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/-/commit/12e40e
   ||0d360f9912eee1b162d61e3f183
   ||676ea5a
 Status|ASSIGNED|RESOLVED

--- Comment #5 from Albert Astals Cid  ---
Git commit 12e40e0d360f9912eee1b162d61e3f183676ea5a by Albert Astals Cid, on
behalf of Sune Vuorela.
Committed on 25/01/2024 at 23:14.
Pushed by aacid into branch 'master'.

Button groups can span multiple pages

The code needs to be aware of that.

M  +17   -2core/documentcommands.cpp
M  +1-0core/documentcommands_p.h
M  +13   -2part/formwidgets.cpp

https://invent.kde.org/graphics/okular/-/commit/12e40e0d360f9912eee1b162d61e3f183676ea5a

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=479942

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/graphics/okular/-/merge_requests/915

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479942

Sune Vuorela  changed:

   What|Removed |Added

   Keywords|qt6 |

--- Comment #3 from Sune Vuorela  ---
not qt6 specific, bug janitor.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=479942

Bug Janitor Service  changed:

   What|Removed |Added

   Keywords||qt6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479942

Sune Vuorela  changed:

   What|Removed |Added

   Keywords|qt6 |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479942

Sune Vuorela  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from Sune Vuorela  ---
So. I guess I need to discuss this with Albert and maybe read the pdf standard. 
The following becomes a bit technical:

But apparantly the 4 options is in a 'button group' and okular assumes that all
buttons on a button group is in the same page. But 4 is  on a page of itself.
And Okular gets confused by this (and
EditFormButtonsCommand::refreshInternalPageReferences fails (It looks for the
form elements on the wrong page) to succeed) and after that, okular seems to be
in a bad state and starts crashing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=479942

Bug Janitor Service  changed:

   What|Removed |Added

   Keywords||qt6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479942

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
   Keywords|qt6 |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=479942

Bug Janitor Service  changed:

   What|Removed |Added

   Keywords||qt6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Sune Vuorela
https://bugs.kde.org/show_bug.cgi?id=479942

Sune Vuorela  changed:

   What|Removed |Added

 CC||k...@pusling.com

--- Comment #1 from Sune Vuorela  ---
Also reproducible in 22.12.

-- 
You are receiving this mail because:
You are the assignee for the bug.