D12001: use correct filepath
This revision was automatically updated to reflect the committed changes. Closed by commit R223:f8f7a77fedc0: use correct filepath (authored by fabiank). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12001?vs=31528=31534 REVISION DETAIL https://phabricator.kde.org/D12001 AFFECTED FILES ui/pageviewannotator.cpp To: fabiank, #okular, hetzenecker, aacid Cc: aacid, #okular, michaelweghorn, ngraham
D12001: use correct filepath
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Ouch :D REPOSITORY R223 Okular BRANCH fixWarnings REVISION DETAIL https://phabricator.kde.org/D12001 To: fabiank, #okular, hetzenecker, aacid Cc: aacid, #okular, michaelweghorn, ngraham
D12001: use correct filepath
fabiank added reviewers: Okular, hetzenecker. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12001 To: fabiank, #okular, hetzenecker Cc: #okular, michaelweghorn, ngraham, aacid
D12001: use correct filepath
fabiank created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. fabiank requested review of this revision. REVISION SUMMARY Seems like someone forgot to consistently apply a change. Maybe the path construction should be factored into a reusable lambda? TEST PLAN Open Okular, open settings > configure Okular. Without the patch, you'll get a "QFSFileEngine::open: No file name specified" warning, with the patch it disappears. Note that there is also an unrelated "Illegal icon group: 7" warning from KIconThemes, but I'm 99% certain that this is on KIconThemes doing a bogus check in KIconEffect::apply, not on Okular REPOSITORY R223 Okular BRANCH fixWarnings REVISION DETAIL https://phabricator.kde.org/D12001 AFFECTED FILES ui/pageviewannotator.cpp To: fabiank Cc: #okular, michaelweghorn, ngraham, aacid
