D22903: Improve search field

2019-08-04 Thread Jonah Brüchert 
jbbgameich closed this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham, apol
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

2019-08-04 Thread Aleix Pol Gonzalez 
apol accepted this revision.

REPOSITORY
  R223 Okular

BRANCH
  improve-searchfield

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham, apol
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

2019-08-04 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM!

REPOSITORY
  R223 Okular

BRANCH
  improve-searchfield

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

2019-08-04 Thread Jonah Brüchert 
jbbgameich updated this revision to Diff 63084.
jbbgameich added a comment.


  Update searchField text to defaults of Kirigami.SearchField

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22903?vs=63039=63084

BRANCH
  improve-searchfield

REVISION DETAIL
  https://phabricator.kde.org/D22903

AFFECTED FILES
  mobile/app/package/contents/ui/Thumbnails.qml

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

2019-08-04 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> Thumbnails.qml:33
>  id: searchField
> -anchors.fill: parent
> +placeholderText: i18n("Search in document…")
>  enabled: documentItem ? documentItem.supportsSearching : false

Placeholder text should just be "Search..."

Use three dots instead of the ellipsis character

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

2019-08-04 Thread Jonah Brüchert 
jbbgameich updated this revision to Diff 63039.
jbbgameich added a comment.


  revert back to Controls TextField

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22903?vs=63015=63039

BRANCH
  improve-searchfield

REVISION DETAIL
  https://phabricator.kde.org/D22903

AFFECTED FILES
  mobile/app/package/contents/ui/Thumbnails.qml

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

2019-08-03 Thread Nathaniel Graham 
ngraham added a comment.


  Sigh, I guess so

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

2019-08-03 Thread Jonah Brüchert 
jbbgameich added a comment.


  I see. @ngraham should I revert the change to use Kirigami.SearchField again 
then?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

2019-08-03 Thread Carl Schwan 
ognarb added a comment.


  See discussion in D18658 , Okular depends 
on Framework 5.44

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ognarb, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, 
tfella, darcyshen, aacid

D22903: Improve search field

2019-08-03 Thread Jonah Brüchert 
jbbgameich updated this revision to Diff 63015.
jbbgameich added a comment.


  actually remove unrelated changes

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22903?vs=63014=63015

BRANCH
  improve-searchfield

REVISION DETAIL
  https://phabricator.kde.org/D22903

AFFECTED FILES
  mobile/app/package/contents/ui/Thumbnails.qml

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen, aacid

D22903: Improve search field

2019-08-03 Thread Jonah Brüchert 
jbbgameich updated this revision to Diff 63014.
jbbgameich added a comment.


  Remove unrelated changes

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22903?vs=63012=63014

BRANCH
  improve-searchfield

REVISION DETAIL
  https://phabricator.kde.org/D22903

AFFECTED FILES
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/ThumbnailsBase.qml

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen, aacid

D22903: Improve search field

2019-08-03 Thread Jonah Brüchert 
jbbgameich updated this revision to Diff 63012.
jbbgameich added a comment.


  Use Kirigami.SearchField

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22903?vs=63003=63012

BRANCH
  improve-searchfield

REVISION DETAIL
  https://phabricator.kde.org/D22903

AFFECTED FILES
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/ThumbnailsBase.qml

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen, aacid

D22903: Improve search field

2019-08-02 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Use `Kirigami.SearchField` instead; it takes care of everything for you. 
You'll need to import Kirigami 2.8 or later for this.
  
  Also the changes to `ThumbnailsBase.qml` are unrelated to the subject; please 
do them in another patch (or just commit directly since it's so minor).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile, ngraham
Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, 
darcyshen, aacid

D22903: Improve search field

2019-08-02 Thread Jonah Brüchert 
jbbgameich added reviewers: Okular, Plasma: Mobile.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22903

To: jbbgameich, #okular, #plasma:_mobile
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid

D22903: Improve search field

2019-08-02 Thread Jonah Brüchert 
jbbgameich created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Adds a placeholder text and uses contentItem

REPOSITORY
  R223 Okular

BRANCH
  improve-searchfield

REVISION DETAIL
  https://phabricator.kde.org/D22903

AFFECTED FILES
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/ThumbnailsBase.qml

To: jbbgameich
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid