D23911: Port SearchLineWidget to use KBusyIndicatorWidget

2019-12-05 Thread Kai Uwe Broulik 
broulik abandoned this revision.
broulik added a comment.


  Moved to GitLab: https://invent.kde.org/kde/okular/merge_requests/71

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23911

To: broulik, #okular, aacid
Cc: sander, sitter, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D23911: Port SearchLineWidget to use KBusyIndicatorWidget

2019-09-13 Thread Albert Astals Cid 
aacid added a comment.


  Please use invent.
  
  The CI there will tell you if the change is acceptable regarding dependency 
versions

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23911

To: broulik, #okular, aacid
Cc: sander, sitter, okular-devel, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D23911: Port SearchLineWidget to use KBusyIndicatorWidget

2019-09-12 Thread Oliver Sander 
sander added a comment.


  The code looks promising, but I cannot test it because that 
kbusyindicatorwidget.h is so new it's not in my Debian yet. I am not sure we 
want to unconditionally  depend on something so new.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23911

To: broulik, #okular, aacid
Cc: sander, sitter, okular-devel, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D23911: Port SearchLineWidget to use KBusyIndicatorWidget

2019-09-12 Thread Harald Sitter 
sitter added a comment.


  It's marvelous!

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23911

To: broulik, #okular, aacid
Cc: sitter, okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, 
joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D23911: Port SearchLineWidget to use KBusyIndicatorWidget

2019-09-12 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Okular, aacid.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It's a lot nicer than manually painting a `KPixmapSequence` and supports high 
dpi out of the box.

TEST PLAN
  T11637 
  It is pretty new, so maybe too new for the frameworks dep of KDE Applications 
/ Okular
  
  - Busy indicator is prety now
  
  F7344007: Screenshot_20190912_182434.png 


REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D23911

AFFECTED FILES
  ui/searchlineedit.cpp
  ui/searchlineedit.h

To: broulik, #okular, aacid
Cc: okular-devel, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, 
kezik, tfella, ngraham, darcyshen, aacid