[Okular-devel] [okular] [Bug 346259] [feature] zoom to selected area
https://bugs.kde.org/show_bug.cgi?id=346259 --- Comment #2 from Cade ahx2...@gmail.com --- Use cases. * Zoom to one column of multi-column document (fit to column width). * Zoom to part of image (picture, sketch, map, photo, chart, etc) (view details). -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 123363: Fix the export header not being found in interfaces/*.h
On abr. 17, 2015, 10:02 p.m., Albert Astals Cid wrote:
Sorry, but i don't see why such lot of changes are needed in the frameworks
branch if this used to work, please explain what has changed and why all
this is needed, since it would seem to me that if it worked before it
should work now without any change.
Alex Richardson wrote:
I think this is all related to the use of generate_export_header() and
the fact that previously consumers would
`include_directories(${INCLUDE_DIR}/okular/core
${INCLUDE_DIR}/okular/interfaces)` so that the headers in interfaces/ would
find the okularcore_export.h in core/.
We could add this to the INTERFACE_INCLUDE_DIRECTORIES, but I don't like
the fact that this adds headers such as global.h, utils.h and version.h which
might conflict with other headers. Ideally the user should #include
okular/core/global.h instead. I think changing the interfaces #include to
../core/okularcore_export.h is the cleaner solution here.
any reason it can't just be #include core/okularcore_export.h ?
- Albert
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123363/#review79148
---
On abr. 15, 2015, 11:55 p.m., Alex Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123363/
---
(Updated abr. 15, 2015, 11:55 p.m.)
Review request for Okular.
Repository: okular
Description
---
Fix the export header not being found in interfaces/*.h
Diffs
-
CMakeLists.txt 836b1912f29a5a83b52f40eb52ab6bfee327dd68
interfaces/configinterface.h d5e64336e7015a4b3068e10b2ce1caea77015da0
interfaces/guiinterface.h 4b4dca0c839fb32eb28c3d710f7b06401e9c4440
interfaces/printinterface.h 460d33eb4e25e09e89a11bbbd126a5d610472f7d
interfaces/saveinterface.h 8ae1bea648ab6a0452ea0964dbf20ca3e9fb8fc6
interfaces/viewerinterface.h c174059d78b5f4c329232406cacb5e5f49bf7f44
Diff: https://git.reviewboard.kde.org/r/123363/diff/
Testing
---
Kile compiles now.
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 283477] Missing language specific characters when filling in forms
https://bugs.kde.org/show_bug.cgi?id=283477 --- Comment #12 from Albert Astals Cid aa...@kde.org --- Please, give us a break, we do as much as we can on our free time to make the world a better place by coding free software for all of the humanity to use, you complaining about us not caring is not fair, we do care, the world is just how it is and we do not have the time to get this particular bug fixed. If you really want this fixed, you can always get some money and hire someone to fix it, or you can try learn coding and fix it yourself, but i guess you as many, don't have enough time for that. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 123363: Fix the export header not being found in interfaces/*.h
On abr. 17, 2015, 10:02 p.m., Albert Astals Cid wrote:
Sorry, but i don't see why such lot of changes are needed in the frameworks
branch if this used to work, please explain what has changed and why all
this is needed, since it would seem to me that if it worked before it
should work now without any change.
Alex Richardson wrote:
I think this is all related to the use of generate_export_header() and
the fact that previously consumers would
`include_directories(${INCLUDE_DIR}/okular/core
${INCLUDE_DIR}/okular/interfaces)` so that the headers in interfaces/ would
find the okularcore_export.h in core/.
We could add this to the INTERFACE_INCLUDE_DIRECTORIES, but I don't like
the fact that this adds headers such as global.h, utils.h and version.h which
might conflict with other headers. Ideally the user should #include
okular/core/global.h instead. I think changing the interfaces #include to
../core/okularcore_export.h is the cleaner solution here.
Albert Astals Cid wrote:
any reason it can't just be #include core/okularcore_export.h ?
Alex Richardson wrote:
That all depends on how the Okular headers are supposed to be included by
other applications: Is it 1. `#include okular/core/document.h`, 2.
`#include core/document.h` or 3. `#include document.h`?
As it is currently only $PREFIX/include is added to the include dirs
(option 1). Of course the OkularConfig.cmake file could be changed to option
2, then it can be #include core/okularcore_export.h or we add
include/okular/core to the INTERFACE_INCLUDE_DIRECTORIES then #nclude
okularcore_export.h still works.
I would personally prefer if third party applications have to use
#include okular/core/document.h and more importantly #include
okular/interfaces/configinterface.h since there is e.g.
ktexteditor/configinterface.h as well (although I think that needs to be
included as ktexteditor/configinterface.h so there should be no problem).
Also #include okular/core/utils.h makes it explicit what library the
header comes from as opposed to #include core/utils.h which could be
anything.
But I am happy to use whatever solution you prefer, I just want to get
kile to compile again.
frameworks branch should be just a port of master to KF5, not have new
features, changes or improvements, so applications are supposed to include
Okular frameworks the same way they are supposed to include Okular master,
which honestly i don't know which way it is :D
Now if you want to improve this in master, i can agree that certainly #include
okular/core/document.h does make sense as it is more obvious on what is being
included.
- Albert
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123363/#review79148
---
On abr. 15, 2015, 11:55 p.m., Alex Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123363/
---
(Updated abr. 15, 2015, 11:55 p.m.)
Review request for Okular.
Repository: okular
Description
---
Fix the export header not being found in interfaces/*.h
Diffs
-
CMakeLists.txt 836b1912f29a5a83b52f40eb52ab6bfee327dd68
interfaces/configinterface.h d5e64336e7015a4b3068e10b2ce1caea77015da0
interfaces/guiinterface.h 4b4dca0c839fb32eb28c3d710f7b06401e9c4440
interfaces/printinterface.h 460d33eb4e25e09e89a11bbbd126a5d610472f7d
interfaces/saveinterface.h 8ae1bea648ab6a0452ea0964dbf20ca3e9fb8fc6
interfaces/viewerinterface.h c174059d78b5f4c329232406cacb5e5f49bf7f44
Diff: https://git.reviewboard.kde.org/r/123363/diff/
Testing
---
Kile compiles now.
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 283477] Missing language specific characters when filling in forms
https://bugs.kde.org/show_bug.cgi?id=283477 speedytux speedy...@posteo.net changed: What|Removed |Added CC||speedy...@posteo.net --- Comment #10 from speedytux speedy...@posteo.net --- I have the same problem with romanian characters in a pdf form. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 283477] Missing language specific characters when filling in forms
https://bugs.kde.org/show_bug.cgi?id=283477 --- Comment #11 from BuxarNET buxar...@gmail.com --- problem known since at least 2011, but unfortunately or anyone to care no. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 123393: FindLibSpectre: Use FindPkgConfig instead of UsePkgConfig
On abr. 18, 2015, 11:08 p.m., Albert Astals Cid wrote: Ship It! Please commit to 15.04 and merge to master. - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123393/#review79184 --- On abr. 18, 2015, 9:53 a.m., Heiko Becker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123393/ --- (Updated abr. 18, 2015, 9:53 a.m.) Review request for Okular. Repository: okular Description --- The latter is deprecated and doesn't respect the PKG_CONFIG environment variable which makes it easy to deal with differently named pkg-config executables, e.g. arch-prefixed ones. Diffs - cmake/modules/FindLibSpectre.cmake 8d5dc76 Diff: https://git.reviewboard.kde.org/r/123393/diff/ Testing --- Configured and built okular successfully and checked that it links to libspectre. Thanks, Heiko Becker ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 123393: FindLibSpectre: Use FindPkgConfig instead of UsePkgConfig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123393/#review79184 --- Ship it! Ship It! - Albert Astals Cid On abr. 18, 2015, 9:53 a.m., Heiko Becker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123393/ --- (Updated abr. 18, 2015, 9:53 a.m.) Review request for Okular. Repository: okular Description --- The latter is deprecated and doesn't respect the PKG_CONFIG environment variable which makes it easy to deal with differently named pkg-config executables, e.g. arch-prefixed ones. Diffs - cmake/modules/FindLibSpectre.cmake 8d5dc76 Diff: https://git.reviewboard.kde.org/r/123393/diff/ Testing --- Configured and built okular successfully and checked that it links to libspectre. Thanks, Heiko Becker ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 123363: Fix the export header not being found in interfaces/*.h
On April 17, 2015, 11:02 p.m., Albert Astals Cid wrote:
Sorry, but i don't see why such lot of changes are needed in the frameworks
branch if this used to work, please explain what has changed and why all
this is needed, since it would seem to me that if it worked before it
should work now without any change.
Alex Richardson wrote:
I think this is all related to the use of generate_export_header() and
the fact that previously consumers would
`include_directories(${INCLUDE_DIR}/okular/core
${INCLUDE_DIR}/okular/interfaces)` so that the headers in interfaces/ would
find the okularcore_export.h in core/.
We could add this to the INTERFACE_INCLUDE_DIRECTORIES, but I don't like
the fact that this adds headers such as global.h, utils.h and version.h which
might conflict with other headers. Ideally the user should #include
okular/core/global.h instead. I think changing the interfaces #include to
../core/okularcore_export.h is the cleaner solution here.
Albert Astals Cid wrote:
any reason it can't just be #include core/okularcore_export.h ?
That all depends on how the Okular headers are supposed to be included by other
applications: Is it 1. `#include okular/core/document.h`, 2. `#include
core/document.h` or 3. `#include document.h`?
As it is currently only $PREFIX/include is added to the include dirs (option
1). Of course the OkularConfig.cmake file could be changed to option 2, then it
can be #include core/okularcore_export.h or we add include/okular/core to the
INTERFACE_INCLUDE_DIRECTORIES then #nclude okularcore_export.h still works.
I would personally prefer if third party applications have to use #include
okular/core/document.h and more importantly #include
okular/interfaces/configinterface.h since there is e.g.
ktexteditor/configinterface.h as well (although I think that needs to be
included as ktexteditor/configinterface.h so there should be no problem).
Also #include okular/core/utils.h makes it explicit what library the header
comes from as opposed to #include core/utils.h which could be anything.
But I am happy to use whatever solution you prefer, I just want to get kile to
compile again.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123363/#review79148
---
On April 16, 2015, 12:55 a.m., Alex Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123363/
---
(Updated April 16, 2015, 12:55 a.m.)
Review request for Okular.
Repository: okular
Description
---
Fix the export header not being found in interfaces/*.h
Diffs
-
CMakeLists.txt 836b1912f29a5a83b52f40eb52ab6bfee327dd68
interfaces/configinterface.h d5e64336e7015a4b3068e10b2ce1caea77015da0
interfaces/guiinterface.h 4b4dca0c839fb32eb28c3d710f7b06401e9c4440
interfaces/printinterface.h 460d33eb4e25e09e89a11bbbd126a5d610472f7d
interfaces/saveinterface.h 8ae1bea648ab6a0452ea0964dbf20ca3e9fb8fc6
interfaces/viewerinterface.h c174059d78b5f4c329232406cacb5e5f49bf7f44
Diff: https://git.reviewboard.kde.org/r/123363/diff/
Testing
---
Kile compiles now.
Thanks,
Alex Richardson
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 123393: FindLibSpectre: Use FindPkgConfig instead of UsePkgConfig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123393/ --- (Updated April 18, 2015, 9:53 vorm.) Review request for Okular. Changes --- Added an else branch to if(not win32) Repository: okular Description --- The latter is deprecated and doesn't respect the PKG_CONFIG environment variable which makes it easy to deal with differently named pkg-config executables, e.g. arch-prefixed ones. Diffs (updated) - cmake/modules/FindLibSpectre.cmake 8d5dc76 Diff: https://git.reviewboard.kde.org/r/123393/diff/ Testing --- Configured and built okular successfully and checked that it links to libspectre. Thanks, Heiko Becker ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
