Re: [onap-discuss] [Release] Adoption of Commit Process Practices

[Alexis de Talhouët]

Good stuff. Thanks for sharing Gildas.

> On Jul 18, 2017, at 7:15 PM, Gildas Lanilis  wrote:
> 
> Hi All,
>  
> During TSC Meeting on July 13 TSC 
> , the TSC has approved 
> a set of Development Best Practices 
> .
>  
> One of them is in regards to the Commit Process which is defined in wiki 
> athttps://wiki.onap.org/display/DW/Commit+Messages 
> 
>  
> Key Points (among others) for you to keep in your radar:
> 1. It is now mandatory to establish a link from the Commit Message 
> BODY to a Jira Issue ID. Linux Foundation is setting up a plugin to enforce 
> this.
> 2. Do NOT have Jira Issue ID in the header
> 3. Header is 50 char max. Linux Foundation is setting up a plugin to 
> enforce this
> 4. Body is 72 char max. Linux Foundation is setting up a plugin to 
> enforce this
> 5.  Self-commits are NOT allowed. In other word, a committer cannot 
> approve its own work

That could be enforced as well.

> 6.  NEVER embed jar, war, tar, gz, gzip, zip in Gerrit. This is a bad 
> practice. In case your repo already contains such files, please take actions 
> to remove them asap
> 7.  There are other practices describing the why and other do and don’t, 
> that I strongly encourage to read 
> .
> These practices cannot all be enforced by a tool. In the quest of looking 
> good and acting as a good citizens, it is expected the community will 
> self-check and auto-regulate.
>  
> Wish you all the best commits for the Amsterdam Release.
>  
> Let me know if you have any questions, I will be glad to help.
>  
> Thanks,
> Gildas
>  
> 
> Gildas Lanilis
> ONAP Release Manager
> Santa Clara CA, USA
> gildas.lani...@huawei.com 
> Mobile: 1 415 238 6287
>  
> ___
> onap-discuss mailing list
> onap-discuss@lists.onap.org 
> https://lists.onap.org/mailman/listinfo/onap-discuss 
> 
___
onap-discuss mailing list
onap-discuss@lists.onap.org
https://lists.onap.org/mailman/listinfo/onap-discuss

[onap-discuss] [Release] Adoption of Commit Process Practices

[Gildas Lanilis]

Hi All,

During TSC Meeting on July 13 
TSC, the TSC has approved 
a set of Development Best 
Practices.

One of them is in regards to the Commit Process which is defined in wiki at 
https://wiki.onap.org/display/DW/Commit+Messages

Key Points (among others) for you to keep in your radar:

1. It is now mandatory to establish a link from the Commit Message BODY 
to a Jira Issue ID. Linux Foundation is setting up a plugin to enforce this.

2. Do NOT have Jira Issue ID in the header

3. Header is 50 char max. Linux Foundation is setting up a plugin to 
enforce this

4. Body is 72 char max. Linux Foundation is setting up a plugin to 
enforce this
5.  Self-commits are NOT allowed. In other word, a committer cannot approve 
its own work
6.  NEVER embed jar, war, tar, gz, gzip, zip in Gerrit. This is a bad 
practice. In case your repo already contains such files, please take actions to 
remove them asap
7.  There are other practices describing the why and other do and don't, 
that I strongly encourage to 
read.
These practices cannot all be enforced by a tool. In the quest of looking good 
and acting as a good citizens, it is expected the community will self-check and 
auto-regulate.

Wish you all the best commits for the Amsterdam Release.

Let me know if you have any questions, I will be glad to help.

Thanks,
Gildas

[HuaweiLogowithName]
Gildas Lanilis
ONAP Release Manager
Santa Clara CA, USA
gildas.lani...@huawei.com
Mobile: 1 415 238 6287

___
onap-discuss mailing list
onap-discuss@lists.onap.org
https://lists.onap.org/mailman/listinfo/onap-discuss