Re: [DISCUSS]: I would like to propose a new conversion mode parameter
+1 2012/8/21 Lei Wang lei.wang.l...@gmail.com On Tue, Aug 21, 2012 at 4:18 AM, Marcus (OOo) marcus.m...@wtnet.de wrote: Am 08/20/2012 04:54 PM, schrieb Jürgen Schmidt: OpenOffice is not only used as desktop application but also as hidden part of other software and often as a conversion engine in the backend. OpenOffice has very good filters for many file formats and the usage as a conversion engine is straight forward. And the conversion from one format into another can be improved and optimized by some special handling of parts of the document. For example external linked parts can be ignored and don't have to be loaded during conversion, embedded images can be simply copied etc. I would like to improve AOO for this kind of usage by introducing a new parameter -conversionmode. It's not comparable with the command line parameter -headless or the hidden property for loadComponentFromUrl(). The intention of this new global option is to have it available everywhere in the underlying code to optimize the performance of the conversion. Sounds reasonable. However, especially with the previous paragraph I don't know if I understood right. Do you want to simply make the import/export of docs faster when AOO isn't running in graphical mode? Would be great if you can fill this with some more details. For some enterprise user, AOO is used as a document conversion service in backend. For an example, convert MS 2003 binary file format to ODF file format. This conversion service does not need GUI. And user can not interrupt the process, which bring performance improvement opportunity which Jurgen mentioned. This should have no influence/impact on the normal workflow but will help to make AOO potentially more attractive for backend usage. Means it will help to grow the broader eco-system around AOO. Thanks Marcus -- Best regards Lei De Bin
Re: [Call for review]Bug 120236 - when decrease indent for bullet,the bullet will go out of page range
Hi, Weike, I volunteered to review the fixed. Can you explain more details for the fix in bugzilla? Thx a lot. 2012/8/15 Liang Weike weike.li...@cs2c.com.cn Hi all, I have fixed Bug 120236 and committed the patch. Could anyone help me to review it? Thanks in advance! https://issues.apache.org/ooo/show_bug.cgi?id=120236 -- Regards, Liang Weike China Standard Software Co., Ltd -- Best regards Lei De Bin
Re: [Call for review]Bug 120236 - when decrease indent for bullet,the bullet will go out of page range
weike, pls check the comments from Oliver. Thx a lot! 2012/8/15 Liang Weike weike.li...@cs2c.com.cn Hi Debin, OK. I have added my comments for this bug in bugzilla. And your suggestions will be appreciated. Hi, Weike, I volunteered to review the fixed. Can you explain more details for the fix in bugzilla? Thx a lot. 2012/8/15 Liang Weike weike.li...@cs2c.com.cn Hi all, I have fixed Bug 120236 and committed the patch. Could anyone help me to review it? Thanks in advance! https://issues.apache.org/ooo/**show_bug.cgi?id=120236https://issues.apache.org/ooo/show_bug.cgi?id=120236 -- Regards, Liang Weike China Standard Software Co., Ltd -- Regards, Liang Weike China Standard Software Co., Ltd -- Best regards Lei De Bin
Re: [REQUEST][VCLAuto]Create two new modules under SRC_ROOT to place vclauto code.
The VCLAuto code had copy from symphony to the trunk and re-factory as
design[1].
Also the license for these files had updated to ASF 2.0.
Thanks Liu Zhe's great work, everyone can enjoy the new automation GUI test
framework now !
[1] http://wiki.services.openoffice.org/wiki/Test_Refactor
2012/6/25 De Bin Lei debin@gmail.com
2012/6/25 Zhe Liu aliu...@gmail.com
2012/6/25 Andre Fischer a...@a-w-f.de:
On 25.06.2012 10:46, Zhe Liu wrote:
2012/6/25 Andre Fischer a...@a-w-f.de:
On 25.06.2012 10:00, Zhe Liu wrote:
2012/6/25 Andre Fischer a...@a-w-f.de:
Hi Zhe Liu,
we already have four test related modules under main/ (test,
testautomation,
testgraphical, testtools).
Would one of these be a good place to add two sub-directories for
the
new
testing code?
Are you concerned about too many modules?
Yes.
The new 2 modules are top level modules. qadevoo and testoo depend
on testcommon.
qadevoo-testcommon
testoo - testcommon
If
qadevoo-test/testcommon
test/testoo -test/testcommon
I don't know if it works according to the current build system. In
addition, I don't want to overwrite the existing code. They are
totally different. The 4 modules is maintained by nobody and can be
removed in future, I said it in
http://wiki.services.openoffice.org/wiki/Test_Refactor
I see. The goal is to remove the modules test, testautomation,
testgraphical, testtools? Then it is OK to ignore them for now.
But then my question is: why not one new module and place testcommon
and
testoo as subdirectories into it?
Do you mean the code structure like the following?
test/testcommon
test/testoo
Jürgen suggested the same code layout. Actually I also prefer to it. I
have one question. test/testoo depends on test/testcommon.
cd test/testoo
build
Is testcommon built automatically? If yes, it's ok.
We have main/test/prj/build.lst for that. There is one line for each
directory that is to be build, together with dependencies on other
modules
(in the first line) and on other directories in the same module (on each
line after the '-')
You would probably add two lines similar to these:
te test\source\testcommon nmake - all te_testcommon NULL
te test\source\testoo nmake - all te_testoo te_testcommon NULL
Which state that te_testoo depends on te_testcommon.
Then build the module with
cd main/test
build
(please note that you build in main/test/, not in main/test/testoo or
main/test/testcommon)
-Andre
OK. I accept. Thanks for your advice, Andre.
De Bin, what's your opinion?
Both are ok for me.
Besides, has the naming scheme (test{common/oo}) anything to do with
the
now
obsolete distinction between oo and so (the Sun only code parts)?
No! Do you have better name?
-Andre
--
Best Regards
From aliu...@gmail.com
--
Best regards
Lei De Bin
--
Best regards
Lei De Bin
Re: [Discussion]Active Doc/Sheet protection password related blocks
Steve, Thanks your deep explanation very much. Your information is very useful. I agree with you to enable it in AOO. Thank you again. 2012/6/28 Steve Yin steve.yin@gmail.com Hi all, This feature has been tested and enabled in Symphony over 2 years. It does work. And The hash algorithm is correct. I remember Kohei's aim was to implement almost all protection features like MS Excel includes different privileges. One possible reason is the current implementation is not complete for Kohei, So he disable the feature by default at that time. However. I think we can enable it safely now. On Thu, Jun 28, 2012 at 3:35 PM, Lei Wang lei.wang.l...@gmail.com wrote: Hi Jian Yuan, The file tabprotection.hxx is created by CWS scheetprotection02. I go through the comments when this CWS integrated into the trunk. But I do not find any useful information. If Excel use another hash algorithm, AOO can not unprotect the sheet/doc even user input the right password. To avoid this bad situation, I guess the developer disable related function. On Wed, Jun 27, 2012 at 3:12 PM, Oliver-Rainer Wittmann orwittm...@googlemail.com wrote: Hi, On 26.06.2012 08:44, Jianyuan Li wrote: Hi, all, In ../sc/inc/tabprotection.hxx, a macro is defined as below: #define ENABLE_SHEET_PROTECTION 0 So all blocks controlled by it will not be executed: 1. Import/export Sheet/Doc protection password for a protected xls file. 2. Import a protected xls file and show unpassword dlg to input password when unprotect the sheet/doc. 2. Import a ods/xls file and export it as a xls/ods file. Show password retype dlg. And there is an issue related to it: https://issues.apache.org/ooo/**show_bug.cgi?id=119552 https://issues.apache.org/ooo/show_bug.cgi?id=119552. I have added some comments for it. I had a simple test to set the macro as 1 and checked all above scenarios. It works well. So here I want to set the macro as 1. Any comments? Or does anyone know the initial thought for the value 0 of ENABLE_SHEET_PROTECTION? I do not know anything about this code. But may be a look in the hg repository - still available at [1] - would help. May be the one or the other commit log message by which this macro has been introduced would give some answers. [1] http://hg.services.openoffice.**org/ http://hg.services.openoffice.org/ Best regards, Oliver. -- Best Regards, Steve Yin -- Best regards Lei De Bin
Re: [Discussion]Active Doc/Sheet protection password related blocks
2012/6/28 Jürgen Schmidt jogischm...@googlemail.com On 6/28/12 11:14 AM, Steve Yin wrote: Hi all, This feature has been tested and enabled in Symphony over 2 years. It does work. And The hash algorithm is correct. I remember Kohei's aim was to implement almost all protection features like MS Excel includes different privileges. One possible reason is the current implementation is not complete for Kohei, So he disable the feature by default at that time. However. I think we can enable it safely now. we should track it then as a new feature for 3.5. I suggest that we create a feature task for it. Thank you for your suggestion, I will help to track it as a feature and commit the code. Juergen On Thu, Jun 28, 2012 at 3:35 PM, Lei Wang lei.wang.l...@gmail.com wrote: Hi Jian Yuan, The file tabprotection.hxx is created by CWS scheetprotection02. I go through the comments when this CWS integrated into the trunk. But I do not find any useful information. If Excel use another hash algorithm, AOO can not unprotect the sheet/doc even user input the right password. To avoid this bad situation, I guess the developer disable related function. On Wed, Jun 27, 2012 at 3:12 PM, Oliver-Rainer Wittmann orwittm...@googlemail.com wrote: Hi, On 26.06.2012 08:44, Jianyuan Li wrote: Hi, all, In ../sc/inc/tabprotection.hxx, a macro is defined as below: #define ENABLE_SHEET_PROTECTION 0 So all blocks controlled by it will not be executed: 1. Import/export Sheet/Doc protection password for a protected xls file. 2. Import a protected xls file and show unpassword dlg to input password when unprotect the sheet/doc. 2. Import a ods/xls file and export it as a xls/ods file. Show password retype dlg. And there is an issue related to it: https://issues.apache.org/ooo/**show_bug.cgi?id=119552 https://issues.apache.org/ooo/show_bug.cgi?id=119552. I have added some comments for it. I had a simple test to set the macro as 1 and checked all above scenarios. It works well. So here I want to set the macro as 1. Any comments? Or does anyone know the initial thought for the value 0 of ENABLE_SHEET_PROTECTION? I do not know anything about this code. But may be a look in the hg repository - still available at [1] - would help. May be the one or the other commit log message by which this macro has been introduced would give some answers. [1] http://hg.services.openoffice.**org/ http://hg.services.openoffice.org/ Best regards, Oliver. -- Best regards Lei De Bin
Re: [RELEASE][3.4.1]: proposing Bug 118057 [filter] word 2003 XML (wordml) filters broken as release blocker
2012/6/25 Pedro Giffuni p...@apache.org --- Dom 24/6/12, Lin Yuan yuanlin@gmail.com ha scritto: Da: Lin Yuan yuanlin@gmail.com Oggetto: Re: [RELEASE][3.4.1]: proposing Bug 118057 [filter] word 2003 XML (wordml) filters broken as release blocker A: ooo-dev@incubator.apache.org, p...@apache.org Data: Domenica 24 giugno 2012, 22:18 2012/6/25 Pedro Giffuni p...@apache.org Ugh ... --- Dom 24/6/12, De Bin Lei debin@gmail.com ha scritto: Da: De Bin Lei debin@gmail.com Oggetto: Re: [RELEASE][3.4.1]: proposing Bug 118057 [filter] word 2003 XML (wordml) filters broken as release blocker A: ooo-dev@incubator.apache.org Data: Domenica 24 giugno 2012, 20:14 2012/6/20 Jürgen Schmidt jogischm...@googlemail.com On 6/20/12 10:14 AM, debin lei wrote: 2012/6/20 Jürgen Schmidt jogischm...@googlemail.com On 6/20/12 8:21 AM, debin lei wrote: +1 from my view. I have checked the fix. It has a very high benefit to risk ratio it could be good for AOO 3.4.1. fix available and reviewed, so it looks fine for me to include it for 3.4.1. Debin, Will you take care of the fix for 3.4.1 on the AOO34 branch ones you have the commit rights ;-) Ok, I will take care of the fix for 3.4.1, when I have the right. perfect, please add the revision of the branch in the issue when you have fixed it. It helps to track it. DONE. The code have checked in 3.4.1 and revision is 1353370. I see the issue appears RESOLVED - FIXED. Was the issue fixed in trunk? In general all fixes should go to trunk first. So the code changes in 3.4.1 branch will not be merged to main trunk automaticly after 3.4.1 released? Not automatically: someone has to do it and if the bug is labelled RESOLVED - FIXED it's likely that someone will forget to do it. That's one of the reasons it's preferable to commit the patches to trunk first. Another reason is that using svn merge will keep track of the revisions that have been merged. Thank your reminder and explanation. I checked the fix in trunk now, the rev is 1353389. Cheers, Pedro. -- Best regards Lei De Bin
Re: [QE]About bug 119337 is reproduced in AOO3.4.1 snapshot build
Hi, Xue Fei The fix is in trunk rev. 1344156. But I can't find the fix in 3.4.1, so you can reproduce it. 2012/6/25 Xue Fei Duan duanx...@gmail.com Hi, For bug 119337[1], it's marked as AOO3.4.1 blocker flag. I can reproduce it on Mac 10.7 version using AOO 3.4.1- 1351960. Anyone can tell me if the bug has been fixed in this build? [1]https://issues.apache.org/ooo/show_bug.cgi?id=119337 -- Best regards Lei De Bin
Re: [REQUEST][VCLAuto]Create two new modules under SRC_ROOT to place vclauto code.
2012/6/25 Zhe Liu aliu...@gmail.com
2012/6/25 Andre Fischer a...@a-w-f.de:
On 25.06.2012 10:46, Zhe Liu wrote:
2012/6/25 Andre Fischer a...@a-w-f.de:
On 25.06.2012 10:00, Zhe Liu wrote:
2012/6/25 Andre Fischer a...@a-w-f.de:
Hi Zhe Liu,
we already have four test related modules under main/ (test,
testautomation,
testgraphical, testtools).
Would one of these be a good place to add two sub-directories for the
new
testing code?
Are you concerned about too many modules?
Yes.
The new 2 modules are top level modules. qadevoo and testoo depend
on testcommon.
qadevoo-testcommon
testoo - testcommon
If
qadevoo-test/testcommon
test/testoo -test/testcommon
I don't know if it works according to the current build system. In
addition, I don't want to overwrite the existing code. They are
totally different. The 4 modules is maintained by nobody and can be
removed in future, I said it in
http://wiki.services.openoffice.org/wiki/Test_Refactor
I see. The goal is to remove the modules test, testautomation,
testgraphical, testtools? Then it is OK to ignore them for now.
But then my question is: why not one new module and place testcommon
and
testoo as subdirectories into it?
Do you mean the code structure like the following?
test/testcommon
test/testoo
Jürgen suggested the same code layout. Actually I also prefer to it. I
have one question. test/testoo depends on test/testcommon.
cd test/testoo
build
Is testcommon built automatically? If yes, it's ok.
We have main/test/prj/build.lst for that. There is one line for each
directory that is to be build, together with dependencies on other
modules
(in the first line) and on other directories in the same module (on each
line after the '-')
You would probably add two lines similar to these:
te test\source\testcommon nmake - all te_testcommon NULL
te test\source\testoo nmake - all te_testoo te_testcommon NULL
Which state that te_testoo depends on te_testcommon.
Then build the module with
cd main/test
build
(please note that you build in main/test/, not in main/test/testoo or
main/test/testcommon)
-Andre
OK. I accept. Thanks for your advice, Andre.
De Bin, what's your opinion?
Both are ok for me.
Besides, has the naming scheme (test{common/oo}) anything to do with
the
now
obsolete distinction between oo and so (the Sun only code parts)?
No! Do you have better name?
-Andre
--
Best Regards
From aliu...@gmail.com
--
Best regards
Lei De Bin
Re: About Bug 118057 - [filter] word 2003 XML (wordml) filters broken
Yes, It is a 3.4.1 release broker issue and I will take care it. 2012/6/24 RGB ES rgb.m...@gmail.com I do not have a real use for those filters, but every now and then there are questions on the forums about this regression: https://issues.apache.org/ooo/show_bug.cgi?id=118057 In fact, just tried the last development build for 3.4.1 and if you go to Writer → Save as → select Microsoft Word 2003 XML (.xml), Writer freeze for some seconds and then give an error. There is a patch on the issue, but according to the comments it needs to be updated. Will the fix be part of 3.4.1? Regards Ricardo -- Best regards Lei De Bin
Re: About Bug 118057 - [filter] word 2003 XML (wordml) filters broken
2012/6/24 RGB ES rgb.m...@gmail.com 2012/6/24 De Bin Lei debin@gmail.com: Yes, It is a 3.4.1 release broker issue and I will take care it. 2012/6/24 RGB ES rgb.m...@gmail.com I do not have a real use for those filters, but every now and then there are questions on the forums about this regression: https://issues.apache.org/ooo/show_bug.cgi?id=118057 In fact, just tried the last development build for 3.4.1 and if you go to Writer → Save as → select Microsoft Word 2003 XML (.xml), Writer freeze for some seconds and then give an error. There is a patch on the issue, but according to the comments it needs to be updated. Will the fix be part of 3.4.1? Regards Ricardo -- Best regards Lei De Bin Thanks. Note that the issue is not marked as release blocker yet. Thanks for your reminder, I have marked it as release blocker. And the code checked in 3.4.1 stream, revision is 1353370. Ricardo -- Best regards Lei De Bin
Re: [RELEASE][3.4.1]: proposing Bug 118057 [filter] word 2003 XML (wordml) filters broken as release blocker
2012/6/20 Jürgen Schmidt jogischm...@googlemail.com On 6/20/12 10:14 AM, debin lei wrote: 2012/6/20 Jürgen Schmidt jogischm...@googlemail.com On 6/20/12 8:21 AM, debin lei wrote: +1 from my view. I have checked the fix. It has a very high benefit to risk ratio it could be good for AOO 3.4.1. fix available and reviewed, so it looks fine for me to include it for 3.4.1. Debin, Will you take care of the fix for 3.4.1 on the AOO34 branch ones you have the commit rights ;-) Ok, I will take care of the fix for 3.4.1, when I have the right. perfect, please add the revision of the branch in the issue when you have fixed it. It helps to track it. DONE. The code have checked in 3.4.1 and revision is 1353370. Thanks again Juergen +1 for the fix Juergen 2012/6/20 Lin Yuan yuanlin@gmail.com This is a regression introduced in OOo 3.4 beta in cws sw34bf03. Now in AOO 3.4, import and export as Microsoft Word 2003 XML format can not work completely. This issue is critical for UOF file format support and the user who wants to load/save MS Word 2003 XML format files. Michael Stahlm...@openoffice.org already fix it and the patch is attached in Bug 118057. I have updated the patch for lastest AOO 3.4 source code. The root cause is simple: in cws sw34bf03, it moved XSLTFilterOLEExtracter.java but didn't update all the path in .xsl files. So I think the fix effort and risk is low for this bug. [1] https://issues.apache.org/ooo/show_bug.cgi?id=118057 [2] cws sw34bf03: http://hg.services.openoffice.org/OOO340/rev/d75f5b0f6217 Lin Yuan -- Best regards Lei De Bin
Re: [REQUEST][VCLAuto]Create two new modules under SRC_ROOT to place vclauto code.
I am volunteered to review the code and help to commit. Zhe, pls update the patch for the issue 119998 based your new requirement. 2012/6/25 Zhe Liu aliu...@gmail.com Hi all, Since VCLAuto code is ready, I request to create two new modules under SRC_ROOT to place the code. testcommon: It collects reusable code for testing, e.g. utilities, UNO API helpers and VCLAuto API. Not include any test case. testoo: It stores GUI test cases for OpenOffice. After the code committed in SVN, users can use the following commands to start testing after building AOO. source LinuxX86Env.Set.sh cd testoo ant I created one issue to track it. https://issues.apache.org/ooo/show_bug.cgi?id=119998 Vclauto guide http://wiki.services.openoffice.org/wiki/QA/vclauto If nobody have objection to it, I ask for some committer to help me to commit the code. In addition, I plan to refactor testing code step by step in future after vclauto is ready. The target is to unify the existing testing code, reduce the modules and make code clearer. I wrote a wiki to explain it. http://wiki.services.openoffice.org/wiki/Test_Refactor If you find something wrong or have any objection, pls reply me. -- Best Regards From aliu...@gmail.com -- Best regards Lei De Bin
Re: 3.4.1_release_blocker requested: [Bug 120045] Format case change crashes OOo
Got it. so it is a crash and regression one. +1 for 3.4.1 release blocker from my view, thx. 2012/6/21 Ji Yan yanji...@gmail.com DeBin, Yes, it's a regression issue. The problem doesn't exist in OO 3.3 2012/6/21 De Bin Lei debin@gmail.com Hi, Ji Is it a regression one? 2012/6/21 Yan Ji yanji...@gmail.com I propose bug 120045[1] as 3.4.1 release blocker. AOO crashed easily while trying to lowercase a word which contains uppercase in Mac OS. [1] https://issues.apache.org/ooo/show_bug.cgi?id=120045 Thanks Best Regards, Yan Ji Begin forwarded message: From: bugzi...@apache.org Subject: 3.4.1_release_blocker requested: [Bug 120045] Format case change crashes OOo Date: June 21, 2012 11:31:50 AM GMT+08:00 To: ooo-iss...@incubator.apache.org Reply-To: ooo-iss...@incubator.apache.org Yan Ji yanji...@gmail.com has asked for 3.4.1_release_blocker: Bug 120045: Format case change crashes OOo https://issues.apache.org/ooo/show_bug.cgi?id=120045 --- Additional Comments from Yan Ji yanji...@gmail.com The problem happened to Mac platform when changing to lower case with word contains upper case characters. It's obviously serious problem. Propose 3.4.1 release blocker -- Best regards Lei De Bin -- Thanks Best Regards, Yan Ji -- Best regards Lei De Bin
Re: 3.4.1_release_blocker requested: [Bug 120045] Format case change crashes OOo
2012/6/21 Jürgen Schmidt jogischm...@googlemail.com On 6/21/12 8:02 AM, De Bin Lei wrote: Got it. so it is a crash and regression one. +1 for 3.4.1 release blocker from my view, thx. +1, I will set the release blocker flag for 3.4.1. Debin, Will you merge it in the AOO340 branch? Yes, I will. However, there is no fix for it. Anyway I will take care of the code check in for 3.4.1 branch. Juergen 2012/6/21 Ji Yan yanji...@gmail.com DeBin, Yes, it's a regression issue. The problem doesn't exist in OO 3.3 2012/6/21 De Bin Lei debin@gmail.com Hi, Ji Is it a regression one? 2012/6/21 Yan Ji yanji...@gmail.com I propose bug 120045[1] as 3.4.1 release blocker. AOO crashed easily while trying to lowercase a word which contains uppercase in Mac OS. [1] https://issues.apache.org/ooo/show_bug.cgi?id=120045 Thanks Best Regards, Yan Ji Begin forwarded message: From: bugzi...@apache.org Subject: 3.4.1_release_blocker requested: [Bug 120045] Format case change crashes OOo Date: June 21, 2012 11:31:50 AM GMT+08:00 To: ooo-iss...@incubator.apache.org Reply-To: ooo-iss...@incubator.apache.org Yan Ji yanji...@gmail.com has asked for 3.4.1_release_blocker: Bug 120045: Format case change crashes OOo https://issues.apache.org/ooo/show_bug.cgi?id=120045 --- Additional Comments from Yan Ji yanji...@gmail.com The problem happened to Mac platform when changing to lower case with word contains upper case characters. It's obviously serious problem. Propose 3.4.1 release blocker -- Best regards Lei De Bin -- Thanks Best Regards, Yan Ji -- Best regards Lei De Bin
Re: 3.4.1_release_blocker requested: [Bug 120045] Format case change crashes OOo
Zhe, I will help to commit the code, thanks your excellent work! 2012/6/21 Zhe Liu aliu...@gmail.com The scenario can be covered by automated testing. I will write a testcase to verify the defect based on VCLAuto. But, until now, no one help me to commit the VCLAuto code. I has attached it to https://issues.apache.org/ooo/show_bug.cgi?id=119998 2012/6/21 Yan Ji yanji...@gmail.com: I propose bug 120045[1] as 3.4.1 release blocker. AOO crashed easily while trying to lowercase a word which contains uppercase in Mac OS. [1] https://issues.apache.org/ooo/show_bug.cgi?id=120045 Thanks Best Regards, Yan Ji Begin forwarded message: From: bugzi...@apache.org Subject: 3.4.1_release_blocker requested: [Bug 120045] Format case change crashes OOo Date: June 21, 2012 11:31:50 AM GMT+08:00 To: ooo-iss...@incubator.apache.org Reply-To: ooo-iss...@incubator.apache.org Yan Ji yanji...@gmail.com has asked for 3.4.1_release_blocker: Bug 120045: Format case change crashes OOo https://issues.apache.org/ooo/show_bug.cgi?id=120045 --- Additional Comments from Yan Ji yanji...@gmail.com The problem happened to Mac platform when changing to lower case with word contains upper case characters. It's obviously serious problem. Propose 3.4.1 release blocker -- Best Regards From aliu...@gmail.com -- Best regards Lei De Bin
Re: [DISCUSS]What is the criteria for 3.4.1 release blocker?
Juergen, thank for your comments, now the criteria is more clear, thanks again. 2012/6/21 Jürgen Schmidt jogischm...@googlemail.com On 6/21/12 5:51 AM, Dennis E. Hamilton wrote: I think safety is of high value. That includes security issues and also data loss/corruption. The last includes crashers that result in unrecoverable loss of work. Hidden loss of work and document corruption that does not appear until the document is opened later is particularly serious. We used in general the following criteria (details where we are more less based on can be foud under [2]) - crashes (including data loss/corruption) - security fixes - regressions I would also include - memory leaks when a fix is available and it is well tested that nothing else breaks - maintenance issues (like updating reference type library, version strings, images, ...) A micro release like 3.4.1 is only for fixing serious problems and not to introduce new features. Excepting new translations. Minor releases, eg. 3.5, can include any kind of fix, features and improvements. Bigger UI changes should be discussed and probably better included in a major release. See also [1] and especially [2] We should update these pages on demand to reflect our guideline how we want handle this in the future. A common understanding is of course important here. Juergen [1] http://wiki.services.openoffice.org/wiki/Release_criteria [2] http://wiki.services.openoffice.org/wiki/Stopper - Dennis -Original Message- From: dongjun zong [mailto:zongdj...@gmail.com] Sent: Wednesday, June 20, 2012 20:31 To: ooo-dev@incubator.apache.org Subject: Re: [DISCUSS]What is the criteria for 3.4.1 release blocker? I think high severity regression issue, common usage function related issue should be considered as release blocker. 2012/6/21 Ji Yan yanji...@gmail.com From my point of view, security and high usability issue should be set as blocker 2012/6/21 debin lei le...@apache.org Hi, All I noticed that there are some issues, which are proposed as 3.4.1 release blocker recently. However, I am not sure what is the criteria for the release blocker? Is it regression or impact serious ? Or high benefit to risk ratio from dev view ? I think maybe consider more things, but not sure. So if you can give your criteria and discuss here to make the things more clear will be very helpful. Thanks. Best regards. Lei De Bin -- Thanks Best Regards, Yan Ji -- Best regards Lei De Bin
