Re: [Call-for-​Review] Bug 119948 [Windows 8 certification]Windows App Certification Kit - Test for Section 5 Apps must support a clean, reversible installation is failed.

2012-06-27 Thread Huaidong Qiu
Add a new patch per Rob's information to replace the old one, please review.

Just changed the Attributes for font files in the component table
to msidbComponentAttributesSharedDllRefCount, the font will be deinstallled
when the ref count of the files down to 0, so other apps can use those
fonts as well when AOO installed.


On Tue, Jun 26, 2012 at 7:10 PM, O.Felka olaf-openoff...@gmx.de wrote:

 Hi,


  Please review the patch for 119948, for the win 8 certification check.


 Issue link:
 https://issues.apache.org/ooo/**show_bug.cgi?id=119948https://issues.apache.org/ooo/show_bug.cgi?id=119948


 Thanks.


 As I have commented in the issue I still don't think that it's a good idea
 to move the fonts to the program directory.
 I also don't like the idea that the installer removes the installed fonts.
 But this option is not as bad as having them in program/fonts.

 Registering fonts to the system is an essential feature of an Office Suite
 as it has system wide impact.

 Is there no way to change the MSI that the fonts will be removed at
 uninstall?
 Do we know what is MS Office doing?

 Groetjes,
 Olaf



Re: [Call-for-​Review] Bug 119948 [Windows 8 certification]Windows App Certification Kit - Test for Section 5 Apps must support a clean, reversible installation is failed.

2012-06-26 Thread O.Felka

Hi,

 Please review the patch for 119948, for the win 8 certification check.


Issue link:
https://issues.apache.org/ooo/show_bug.cgi?id=119948


Thanks.



As I have commented in the issue I still don't think that it's a good 
idea to move the fonts to the program directory.
I also don't like the idea that the installer removes the installed 
fonts. But this option is not as bad as having them in program/fonts.


Registering fonts to the system is an essential feature of an Office 
Suite as it has system wide impact.


Is there no way to change the MSI that the fonts will be removed at 
uninstall?

Do we know what is MS Office doing?

Groetjes,
Olaf


[Call-for-​Review] Bug 119948 [Windows 8 certification]Windows App Certification Kit - Test for Section 5 Apps must support a clean, reversible installation is failed.

2012-06-25 Thread Huaidong Qiu
Please review the patch for 119948, for the win 8 certification check.

Issue link:
https://issues.apache.org/ooo/show_bug.cgi?id=119948


Thanks.