Re: [Call for review] improvements for linear/axial gradients #120604 and #120957

2012-10-01 Thread Kevin Grignon
Any impact on the UI here?

On Sat, Sep 29, 2012 at 12:32 AM, Armin Le Grand armin.le.gr...@me.comwrote:

 Hi Regina,


 On 26.09.2012 17:34, Armin Le Grand wrote:

  Hi Regina,

 On 25.09.2012 20:50, Regina Henschel wrote:

 Hi all,

 I have attached patches to
 https://issues.apache.org/ooo/**show_bug.cgi?id=120957https://issues.apache.org/ooo/show_bug.cgi?id=120957and
 https://issues.apache.org/ooo/**show_bug.cgi?id=120604https://issues.apache.org/ooo/show_bug.cgi?id=120604

 They change the blending so, that first color is start color, last color
 is end color and they set the number of steps to 2 * number in UI in
 case of style 'axial', as discussed here some time ago.


 Good :-)

  My coding skills are not professional and the Draw module is confusing,
 so please have a look.


 You are doing really well in the meantime (really!).
 I'll take a look and check it. Give me some time, patches are not small
 :-)


 I'm on it...


  Kind regards
 Regina


 Sincerely,
  Armin
 --
 ALG





Re: [Call for review] improvements for linear/axial gradients #120604 and #120957

2012-10-01 Thread Armin Le Grand

Hi Kevin,

On 01.10.2012 17:38, Kevin Grignon wrote:

Any impact on the UI here?


No, just corrections in painted representations :-)


On Sat, Sep 29, 2012 at 12:32 AM, Armin Le Grand armin.le.gr...@me.comwrote:


 Hi Regina,


On 26.09.2012 17:34, Armin Le Grand wrote:


  Hi Regina,

On 25.09.2012 20:50, Regina Henschel wrote:


Hi all,

I have attached patches to
https://issues.apache.org/ooo/**show_bug.cgi?id=120957https://issues.apache.org/ooo/show_bug.cgi?id=120957and
https://issues.apache.org/ooo/**show_bug.cgi?id=120604https://issues.apache.org/ooo/show_bug.cgi?id=120604

They change the blending so, that first color is start color, last color
is end color and they set the number of steps to 2 * number in UI in
case of style 'axial', as discussed here some time ago.



Good :-)

  My coding skills are not professional and the Draw module is confusing,

so please have a look.



You are doing really well in the meantime (really!).
I'll take a look and check it. Give me some time, patches are not small
:-)



I'm on it...


  Kind regards

Regina



Sincerely,
  Armin
--
ALG







Sincerely,
Armin
--
ALG


Re: [Call for review] improvements for linear/axial gradients #120604 and #120957

2012-10-01 Thread Kevin Grignon
Good stuff. Thanks.

I'm a big fan of gradient fills UI ;)

On Tue, Oct 2, 2012 at 12:23 AM, Armin Le Grand armin.le.gr...@me.comwrote:

 Hi Kevin,


 On 01.10.2012 17:38, Kevin Grignon wrote:

 Any impact on the UI here?


 No, just corrections in painted representations :-)

  On Sat, Sep 29, 2012 at 12:32 AM, Armin Le Grand armin.le.gr...@me.com
 wrote:

   Hi Regina,


 On 26.09.2012 17:34, Armin Le Grand wrote:

Hi Regina,

 On 25.09.2012 20:50, Regina Henschel wrote:

  Hi all,

 I have attached patches to
 https://issues.apache.org/ooo/show_bug.cgi?id=120957https://issues.apache.org/ooo/**show_bug.cgi?id=120957
 https**://issues.apache.org/ooo/show_**bug.cgi?id=120957https://issues.apache.org/ooo/show_bug.cgi?id=120957
 and
 https://issues.apache.org/ooo/show_bug.cgi?id=120604https://issues.apache.org/ooo/**show_bug.cgi?id=120604
 https**://issues.apache.org/ooo/show_**bug.cgi?id=120604https://issues.apache.org/ooo/show_bug.cgi?id=120604
 


 They change the blending so, that first color is start color, last
 color
 is end color and they set the number of steps to 2 * number in UI in
 case of style 'axial', as discussed here some time ago.


 Good :-)

   My coding skills are not professional and the Draw module is
 confusing,

 so please have a look.


 You are doing really well in the meantime (really!).
 I'll take a look and check it. Give me some time, patches are not small
 :-)


 I'm on it...


   Kind regards

 Regina


  Sincerely,
   Armin
 --
 ALG




  Sincerely,
 Armin
 --
 ALG



Re: [Call for review] improvements for linear/axial gradients #120604 and #120957

2012-09-28 Thread Armin Le Grand

Hi Regina,

On 26.09.2012 17:34, Armin Le Grand wrote:

 Hi Regina,

On 25.09.2012 20:50, Regina Henschel wrote:

Hi all,

I have attached patches to
https://issues.apache.org/ooo/show_bug.cgi?id=120957 and
https://issues.apache.org/ooo/show_bug.cgi?id=120604

They change the blending so, that first color is start color, last color
is end color and they set the number of steps to 2 * number in UI in
case of style 'axial', as discussed here some time ago.


Good :-)


My coding skills are not professional and the Draw module is confusing,
so please have a look.


You are doing really well in the meantime (really!).
I'll take a look and check it. Give me some time, patches are not small :-)


I'm on it...


Kind regards
Regina



Sincerely,
 Armin
--
ALG





Re: [Call for review] improvements for linear/axial gradients #120604 and #120957

2012-09-26 Thread Armin Le Grand

Hi Regina,

On 25.09.2012 20:50, Regina Henschel wrote:

Hi all,

I have attached patches to
https://issues.apache.org/ooo/show_bug.cgi?id=120957 and
https://issues.apache.org/ooo/show_bug.cgi?id=120604

They change the blending so, that first color is start color, last color
is end color and they set the number of steps to 2 * number in UI in
case of style 'axial', as discussed here some time ago.


Good :-)


My coding skills are not professional and the Draw module is confusing,
so please have a look.


You are doing really well in the meantime (really!).
I'll take a look and check it. Give me some time, patches are not small :-)


Kind regards
Regina



Sincerely,
Armin
--
ALG