Re: svn commit: r1388877 - in /incubator/ooo/trunk/main: cui/source/dialogs/ cui/source/inc/ default_images/introabout/ default_images/res/ desktop/zipintro/ sd/source/ui/slideshow/ sfx2/inc/sfx2/ sfx
Hi, Before I notice this discussion, I have already committed the fix code for this problem by revision 1389717. I also don't have an idea why it doesn't work. The fix code build passed on both Mac and Linux. Let me know if you have any concerns. regards, zhangjf On Tue, Sep 25, 2012 at 7:12 PM, Andre Fischer wrote: > On 24.09.2012 21:12, Pavel Janík wrote: >>> >>> * and the using declaration: >>> >>> using namespace com::sun::star; >>> >>> The compiler should detect that system::XSystemShellExecute is >>> com::sun::star::system::XSystemShellExecute and so on, unless it >>> collides with a system namespace on the system's headers ? >>> >>> Anyway feel free to commit it, if this solves your problem. > > > Your change looks fine. Please commit it. > > >> I'll wait for other's opinions, because I too thought that it should work >> as written (using c:s:s), weird. >> >> Other parts of the code use >> >> namespace css = com::sun::star; >> uno::Reference< css::system::XSystemShellExecute> xSystemShell(... >> >> despite the fact that using namespace com::sun::star is there as well. >> Maybe "system" is somehow strange. >> >> Any ideas about the strangeness? ;-) > > > Hm, the only thing I can think of is the Koenig lookup that may be > implemented differently on your compilers. But I assume that the two of you > both tried this on Linux and thus probably on very similar compilers. > > -Andre > >
Re: svn commit: r1388877 - in /incubator/ooo/trunk/main: cui/source/dialogs/ cui/source/inc/ default_images/introabout/ default_images/res/ desktop/zipintro/ sd/source/ui/slideshow/ sfx2/inc/sfx2/ sfx
> Hm, the only thing I can think of is the Koenig lookup that may be > implemented differently on your compilers. But I assume that the two of you > both tried this on Linux and thus probably on very similar compilers. I use Mac OS X, gcc 4.2.1 on the build machine. -- Pavel Janík
Re: svn commit: r1388877 - in /incubator/ooo/trunk/main: cui/source/dialogs/ cui/source/inc/ default_images/introabout/ default_images/res/ desktop/zipintro/ sd/source/ui/slideshow/ sfx2/inc/sfx2/ sfx
On 24.09.2012 21:12, Pavel Janík wrote: * and the using declaration: using namespace com::sun::star; The compiler should detect that system::XSystemShellExecute is com::sun::star::system::XSystemShellExecute and so on, unless it collides with a system namespace on the system's headers ? Anyway feel free to commit it, if this solves your problem. Your change looks fine. Please commit it. I'll wait for other's opinions, because I too thought that it should work as written (using c:s:s), weird. Other parts of the code use namespace css = com::sun::star; uno::Reference< css::system::XSystemShellExecute> xSystemShell(... despite the fact that using namespace com::sun::star is there as well. Maybe "system" is somehow strange. Any ideas about the strangeness? ;-) Hm, the only thing I can think of is the Koenig lookup that may be implemented differently on your compilers. But I assume that the two of you both tried this on Linux and thus probably on very similar compilers. -Andre
Re: svn commit: r1388877 - in /incubator/ooo/trunk/main: cui/source/dialogs/ cui/source/inc/ default_images/introabout/ default_images/res/ desktop/zipintro/ sd/source/ui/slideshow/ sfx2/inc/sfx2/ sfx
> * and the using declaration: > > using namespace com::sun::star; > > The compiler should detect that system::XSystemShellExecute is > com::sun::star::system::XSystemShellExecute and so on, unless it > collides with a system namespace on the system's headers ? > > Anyway feel free to commit it, if this solves your problem. I'll wait for other's opinions, because I too thought that it should work as written (using c:s:s), weird. Other parts of the code use namespace css = com::sun::star; uno::Reference< css::system::XSystemShellExecute > xSystemShell(... despite the fact that using namespace com::sun::star is there as well. Maybe "system" is somehow strange. Any ideas about the strangeness? ;-) -- Pavel Janík
Re: svn commit: r1388877 - in /incubator/ooo/trunk/main: cui/source/dialogs/ cui/source/inc/ default_images/introabout/ default_images/res/ desktop/zipintro/ sd/source/ui/slideshow/ sfx2/inc/sfx2/ sfx
Hi Pavel,
On Mon, Sep 24, 2012 at 08:31:35PM +0200, Pavel Janík wrote:
>
> On Sep 24, 2012, at 8:28 PM, Pavel Janík wrote:
>
> > Hi,
> >
> > the following change made about.cxx uncompilable on my system:
> >
> > Compiling: cui/source/dialogs/about.cxx
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx: In
> > member function ‘long int
> > AboutDialog::OpenLinkHdl_Impl(svt::FixedHyperlink*)’:
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537:
> > error: ‘system’ has not been declared
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537:
> > error: ‘XSystemShellExecute’ was not declared in this scope
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537:
> > error: template argument 1 is invalid
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537:
> > error: invalid type in declaration before ‘(’ token
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:541:
> > error: initializer expression list treated as compound expression
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:542:
> > error: request for member ‘is’ in ‘xSystemShell’, which is of non-class
> > type ‘int’
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543:
> > error: base operand of ‘->’ is not a pointer
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543:
> > error: ‘system’ has not been declared
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543:
> > error: ‘DEFAULTS’ was not declared in this scope
> > dmake: Error code 1, while making '../../unxmacxi.pro/slo/about.obj'
> > ERROR: error 65280 occurred while making
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs
>
> The following made it compile again:
>
> Index: about.cxx
> ===
> --- about.cxx (revision 1389508)
> +++ about.cxx (working copy)
> @@ -534,13 +534,13 @@
> {
> uno::Reference< uno::XComponentContext > xContext =
> ::comphelper::getProcessComponentContext();
> -uno::Reference< system::XSystemShellExecute > xSystemShell(
> +uno::Reference< com::sun::star::system::XSystemShellExecute >
> xSystemShell(
it looks like this change shouldn't be needed at all:
* there are the include directives:
#include
#include
* and the using declaration:
using namespace com::sun::star;
The compiler should detect that system::XSystemShellExecute is
com::sun::star::system::XSystemShellExecute and so on, unless it
collides with a system namespace on the system's headers ?
Anyway feel free to commit it, if this solves your problem.
Regards
--
Ariel Constenla-Haile
La Plata, Argentina
pgpTEaytWp3OJ.pgp
Description: PGP signature
Re: svn commit: r1388877 - in /incubator/ooo/trunk/main: cui/source/dialogs/ cui/source/inc/ default_images/introabout/ default_images/res/ desktop/zipintro/ sd/source/ui/slideshow/ sfx2/inc/sfx2/ sfx
On Sep 24, 2012, at 8:28 PM, Pavel Janík wrote:
> Hi,
>
> the following change made about.cxx uncompilable on my system:
>
> Compiling: cui/source/dialogs/about.cxx
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx: In
> member function ‘long int
> AboutDialog::OpenLinkHdl_Impl(svt::FixedHyperlink*)’:
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537:
> error: ‘system’ has not been declared
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537:
> error: ‘XSystemShellExecute’ was not declared in this scope
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537:
> error: template argument 1 is invalid
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537:
> error: invalid type in declaration before ‘(’ token
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:541:
> error: initializer expression list treated as compound expression
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:542:
> error: request for member ‘is’ in ‘xSystemShell’, which is of non-class type
> ‘int’
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543:
> error: base operand of ‘->’ is not a pointer
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543:
> error: ‘system’ has not been declared
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543:
> error: ‘DEFAULTS’ was not declared in this scope
> dmake: Error code 1, while making '../../unxmacxi.pro/slo/about.obj'
> ERROR: error 65280 occurred while making
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs
The following made it compile again:
Index: about.cxx
===
--- about.cxx (revision 1389508)
+++ about.cxx (working copy)
@@ -534,13 +534,13 @@
{
uno::Reference< uno::XComponentContext > xContext =
::comphelper::getProcessComponentContext();
-uno::Reference< system::XSystemShellExecute > xSystemShell(
+uno::Reference< com::sun::star::system::XSystemShellExecute >
xSystemShell(
xContext->getServiceManager()->createInstanceWithContext(
rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(
"com.sun.star.system.SystemShellExecute" ) ),
xContext ),
uno::UNO_QUERY_THROW );
if ( xSystemShell.is() )
-xSystemShell->execute( sURL, rtl::OUString(),
system::SystemShellExecuteFlags::DEFAULTS );
+ xSystemShell->execute( sURL, rtl::OUString(),
com::sun::star::system::SystemShellExecuteFlags::DEFAULTS );
}
catch( const uno::Exception& e )
{
--
Pavel Janík
Re: svn commit: r1388877 - in /incubator/ooo/trunk/main: cui/source/dialogs/ cui/source/inc/ default_images/introabout/ default_images/res/ desktop/zipintro/ sd/source/ui/slideshow/ sfx2/inc/sfx2/ sfx
Hi, the following change made about.cxx uncompilable on my system: Compiling: cui/source/dialogs/about.cxx /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx: In member function ‘long int AboutDialog::OpenLinkHdl_Impl(svt::FixedHyperlink*)’: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537: error: ‘system’ has not been declared /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537: error: ‘XSystemShellExecute’ was not declared in this scope /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537: error: template argument 1 is invalid /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537: error: invalid type in declaration before ‘(’ token /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:541: error: initializer expression list treated as compound expression /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:542: error: request for member ‘is’ in ‘xSystemShell’, which is of non-class type ‘int’ /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543: error: base operand of ‘->’ is not a pointer /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543: error: ‘system’ has not been declared /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543: error: ‘DEFAULTS’ was not declared in this scope dmake: Error code 1, while making '../../unxmacxi.pro/slo/about.obj' ERROR: error 65280 occurred while making /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs On Sep 22, 2012, at 9:38 PM, arie...@apache.org wrote: > Author: arielch > Date: Sat Sep 22 19:38:56 2012 > New Revision: 1388877 > > URL: http://svn.apache.org/viewvc?rev=1388877&view=rev > Log: > #i119418# - About Dialog improvements -- Pavel Janík
