Re: [OPEN-ILS-DEV] Permission List i18n-ized

[Dan Scott]

2008/10/29 Craig [EMAIL PROTECTED]:
 Patch Description:
 This patch i18n-izes the perm_list.html and perm_list.js files in conify.

 Files changed are:
 - Open-ILS/web/conify/global/permission/perm_list.html
 - Open-ILS/web/conify/global/permission/perm_list.js
 - Open-ILS/web/opac/locale/en-US/conify.dtd

 Files added are:
 - Open-ILS/web/js/dojo/openils/conify/nls/prml.js


 Developer's Certificate of Origin 1.1
 By making a contribution to this project, I certify that:

 (a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

 (b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

 (c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

 (d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

 Signed-off-by: Craig Ricciuto - [EMAIL PROTECTED]

Hi Craig:

Thanks for the patch. I made a few modifications, some of which were
necessary, some which were more-or-less cosmetic but in keeping with
the style of the other Conify i18n patches:

  * (style) changed prml to pgt throughout to use the
permission.grp_tree class hint from fm_IDL.xml
  * (required) added a dojo.requireLocalization() clause to
perm_list.js to register the localization resource
  * (style) removed dojo.string.substitute() calls for strings that
have no parameters to substitute
  * (required) added clauses to the build/i18n/Makefile to roundtrip
the pgt.js resource from JSON to POT and back

I also noticed that some strings still needed to be i18n-ized in
perm_list.html, but I'll deal with those separately. Otherwise, I have
applied the patch. Thanks very much for the patch!

-- 
Dan Scott
Laurentian University

[OPEN-ILS-DEV] Permission List i18n-ized

[Craig]

Patch Description:
This patch i18n-izes the grp_tree.html and grp_tree.js files in conify.

Files changed are:
- Open-ILS/web/conify/global/permission/grp_tree.html
- Open-ILS/web/conify/global/permission/grp_tree.js
- Open-ILS/web/opac/locale/en-US/conify.dtd

Files added are:
- Open-ILS/web/js/dojo/openils/conify/nls/pgt.js


Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

Signed-off-by: Craig Ricciuto - [EMAIL PROTECTED]
=== modified file 'Open-ILS/web/conify/global/permission/grp_tree.html'
--- Open-ILS/web/conify/global/permission/grp_tree.html	2008-10-08 05:19:39 +
+++ Open-ILS/web/conify/global/permission/grp_tree.html	2008-10-29 16:58:53 +
@@ -14,7 +14,7 @@
 --
 html xmlns=http://www.w2.org/1999/xhtml;
 	head
-		titleConify :: Global :: Permission :: Group Tree/title
+		titleconify.grp_tree.group_tree.title;/title
 
 		style type=text/css
 			@import url('/js/dojo/dojox/grid/_grid/tundraGrid.css');
@@ -82,7 +82,7 @@
 method : 'open-ils.permacrud.search.pgt.atomic',
 timeout : 10,
 params : [ ses, { id : { != : null } }, { order_by : { pgt : 'name' } } ],
-onerror : function (r) { status_update('Problem fetching groups') },
+onerror : function (r) { status_update( pgt_strings.ERROR_FETCHING_GROUPS ) },
 oncomplete : function (r) {
 window._group_list = r.recv().content();
 window._group_data = pgt.toStoreData( window._group_list );
@@ -102,10 +102,7 @@
 });
 
 if (dirtyStore.length  0) {
-var confirmation = confirm(
-'There are unsaved modified Groups!  '+
-'OK to save these changes, Cancel to abandon them.'
-);
+var confirmation = confirm( pgt_strings.CONFIRM EXIT );
 
 if (confirmation) {
 for (var i in window.dirtyStore) {
@@ -122,7 +119,7 @@
 server.actor.request({
 method : 'open-ils.actor.org_types.retrieve',
 timeout : 10,
-onerror : function (r) { status_update('Problem fetching types') },
+onerror : function (r) { status_update( pgt_strings.ERROR_FETCHING_TYPES ) },
 oncomplete : function (r) {
 window._ou_type_list = r.recv().content();
 window._ou_type_data = aout.toStoreData( window._ou_type_list );
@@ -133,7 +130,7 @@
 server.actor.request({
 method : 'open-ils.actor.permissions.retrieve',
 timeout : 10,
-onerror : function (r) { status_update('Problem fetching perms') },
+onerror : function (r) { status_update( pgt_strings.ERROR_FETCHING_PERMS ) },
 oncomplete : function (r) {
 
 window._perm_list = r.recv().content();
@@ -152,7 +149,7 @@
 method : 'open-ils.permacrud.search.pgpm.atomic',
 timeout : 10,
 params : [ ses, { id : { != : null } } ],
-onerror : function (r) { status_update('Problem fetching perm maps') },
+onerror : function (r) { status_update( pgt_strings.ERROR_FETCHING_PERM_MAPS ) },
 oncomplete : function (r) {
 window._perm_map_list = r.recv().content();
 window._perm_map_data = pgpm.toStoreData( window._perm_map_list, 'id' );
@@ -176,7