Re: [OPEN-ILS-DEV] Request: include bug numbers in commit messages
Is this something you want applied retroactively to branches that are waiting to go into master now, or is this request more for future branches that get created? I can see this causing some headaches if it is to be applied to existing branches with more than a handful of commits. -- Jason Stephenson Assistant Director for Technology Services Merrimack Valley Library Consortium 1600 Osgood ST, Suite 2094 North Andover, MA 01845 Phone: 978-557-5891 Email: jstephen...@mvlc.org
Re: [OPEN-ILS-DEV] Request: include bug numbers in commit messages
Hi, On Tue, Feb 18, 2014 at 9:23 AM, Jason Stephenson jstephen...@mvlc.org wrote: Is this something you want applied retroactively to branches that are waiting to go into master now, or is this request more for future branches that get created? Better now than never. I won't stamp my feet if it doesn't get applied retroactively for branches that are yet to be merged, but on the other hand, git filter-branch --msg-filter can be used to edit the commit messages in a branch without having to touch each patch during an interactive rebase. For example: git filter-branch -f --msg-filter 'sed 1 s/^/lp12345: /' range-of-commits Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: g...@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web:http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org http://evergreen-ils.org
Re: [OPEN-ILS-DEV] Request: include bug numbers in commit messages
+1. -b On Mon, Feb 17, 2014 at 1:06 PM, Galen Charlton g...@esilibrary.com wrote: Hi, I'd like to request that we all get in the habit of including bug numbers in commit messages -- specifically, in the first line. Doing this will make it easier to work backwards from a commit to the description of the bug it fixes without having to fight LP's search engine. It will also make it easier to identify related patches, particularly in cases where a patch series does not get pushed all at once for whatever reason. Since essentially all patches [1] go through Launchpad anyway, I don't think this will be much of a burden. For patches that that have already been pullrequested, or for cases where a patch gets written before a LP ticket is opened, I propose that whoever pushes a patch feel free to edit the commit message to add the bug number. [1] With the obvious exception of patches written during release-cutting. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: g...@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web:http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org http://evergreen-ils.org -- Bill Erickson | Senior Software Developer | phone: 877-OPEN-ILS (673-6457) | email: ber...@esilibrary.com | web: http://esilibrary.com | Equinox Software, Inc. / The Open Source Experts
Re: [OPEN-ILS-DEV] Request: include bug numbers in commit messages
+1 This would be very helpful tracking the rationale behind certain changes we encounter. - Original Message - From: Bill Erickson ber...@esilibrary.com To: Evergreen Development Discussion List open-ils-dev@list.georgialibraries.org Sent: Monday, February 17, 2014 1:50:09 PM Subject: Re: [OPEN-ILS-DEV] Request: include bug numbers in commit messages +1. -b On Mon, Feb 17, 2014 at 1:06 PM, Galen Charlton g...@esilibrary.com wrote: Hi, I'd like to request that we all get in the habit of including bug numbers in commit messages -- specifically, in the first line. Doing this will make it easier to work backwards from a commit to the description of the bug it fixes without having to fight LP's search engine. It will also make it easier to identify related patches, particularly in cases where a patch series does not get pushed all at once for whatever reason. Since essentially all patches [1] go through Launchpad anyway, I don't think this will be much of a burden. For patches that that have already been pullrequested, or for cases where a patch gets written before a LP ticket is opened, I propose that whoever pushes a patch feel free to edit the commit message to add the bug number. [1] With the obvious exception of patches written during release-cutting. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: g...@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org http://evergreen-ils.org -- Bill Erickson | Senior Software Developer | phone: 877-OPEN-ILS (673-6457) | email: ber...@esilibrary.com | web: http://esilibrary.com | Equinox Software, Inc. / The Open Source Experts -- Chris Sharp PINES System Administrator Georgia Public Library Service 1800 Century Place, Suite 150 Atlanta, Georgia 30345 (404) 235-7147 csh...@georgialibraries.org http://pines.georgialibraries.org/
