Re: [OPEN-ILS-GENERAL] apostrophe in title search causing problems(Bug #744513)
MVLC uses git to maintain a branch specifically for changes to the default skin. We thus use default with those changes. Might documenting how we are (or rather, I am) doing this be of benefit? Note that we have an easier time of this, as we install off of git, not off of tarballs. Thomas Berezansky Merrimack Valley Library Consortium Quoting Dan Scott : On Tue, Jul 19, 2011 at 3:34 PM, Gordana Vitez wrote: Hi everyone, Thanks to all for providing information and feedback. The patch has been applied successfully for the libraries of the Niagara Evergreen Consortium. Don't you just love it when things work so well, so quickly?!? Applying the "what can we learn from this" test - perhaps skin-level patches need to be called out separately in the release notes for each release? Without diving into everyone's catalogues, I can't say for sure, but I bet (& hope!) that most sites don't use /opac/skin/default/. The default skin is, of course, what we developers test, so a nice out-of-the-box install of Evergreen will have its bugs fixed, but most other Evergreen instances will not get bug fixes at upgrade time without special attention. The release notes section could look something like: Bug fixes - catalog --- The following list of catalog bugs were fixed in this release. When you upgrade to this release, your catalog will only benefit from these bug fixes if you are using the 'default' skin; if you are using a customized skin, you will need to apply the same fixes to your own customized version of the listed files. * 744513 - Do not strip apostrophes from advanced searches ** opac/skin/default/js/adv_global.js * ### - Some other bug ** File 1 ** File 2 This would take a fair amount of effort to pull together, but might be worthwhile if someone(s) is/are willing to step up and do the work.
Re: [OPEN-ILS-GENERAL] apostrophe in title search causing problems(Bug #744513)
On Tue, Jul 19, 2011 at 3:34 PM, Gordana Vitez wrote: > Hi everyone, > > Thanks to all for providing information and feedback. The patch has been > applied successfully for the libraries of the Niagara Evergreen Consortium. > > Don't you just love it when things work so well, so quickly?!? Applying the "what can we learn from this" test - perhaps skin-level patches need to be called out separately in the release notes for each release? Without diving into everyone's catalogues, I can't say for sure, but I bet (& hope!) that most sites don't use /opac/skin/default/. The default skin is, of course, what we developers test, so a nice out-of-the-box install of Evergreen will have its bugs fixed, but most other Evergreen instances will not get bug fixes at upgrade time without special attention. The release notes section could look something like: Bug fixes - catalog --- The following list of catalog bugs were fixed in this release. When you upgrade to this release, your catalog will only benefit from these bug fixes if you are using the 'default' skin; if you are using a customized skin, you will need to apply the same fixes to your own customized version of the listed files. * 744513 - Do not strip apostrophes from advanced searches ** opac/skin/default/js/adv_global.js * ### - Some other bug ** File 1 ** File 2 This would take a fair amount of effort to pull together, but might be worthwhile if someone(s) is/are willing to step up and do the work.
Re: [OPEN-ILS-GENERAL] apostrophe in title search causing problems(Bug #744513)
Hi everyone,
Thanks to all for providing information and feedback. The patch has been
applied successfully for the libraries of the Niagara Evergreen Consortium.
Don't you just love it when things work so well, so quickly?!?
Thanks again!
Gordana
>>> Dan Scott 7/19/2011 1:27 PM >>>
On Tue, Jul 19, 2011 at 1:04 PM, Dan Wells wrote:
> Hello Gordana,
>
> This was a skin level fix, so since you are using a custom skin ('nc'), it
> must be applied manually to your skin after upgrading. Since the fix is
> simply deleting a single line, it should be pretty simple to take care of.
> See here to view the actual change needed:
>
> http://git.evergreen-ils.org/?p=Evergreen.git;a=blobdiff;f=Open-ILS/web/opac/skin/default/js/adv_global.js;h=897b1ea057cac0fc7b1c022c34e654ce2efe9dcf;hp=a6311b7ccdb76a85232a8f006eea08ff6971b21a;hb=04a9a2aaf7d17ce84a78ddf132fdb20486aa4218;hpb=f466fd7c66570af8f80e8ee085ff9c945aee8ffd
>
>
> Note, though, that there may be other skin fixes between 2.0.2 and 2.0.7, so
> you may want to be more systematic about looking at all the 'default' skin
> changes from 2.0.2 to 2.0.7 and applying them to your custom skin.
Yep, and the Niagara skin currently includes in line 310 of adv_global.js:
string = string.replace(/'/g,' ');
... which is what is introducing the space-instead-of-an-apostrophe
problem in the advanced search.
Re: [OPEN-ILS-GENERAL] apostrophe in title search causing problems (Bug #744513)
On Tue, Jul 19, 2011 at 1:04 PM, Dan Wells wrote:
> Hello Gordana,
>
> This was a skin level fix, so since you are using a custom skin ('nc'), it
> must be applied manually to your skin after upgrading. Since the fix is
> simply deleting a single line, it should be pretty simple to take care of.
> See here to view the actual change needed:
>
> http://git.evergreen-ils.org/?p=Evergreen.git;a=blobdiff;f=Open-ILS/web/opac/skin/default/js/adv_global.js;h=897b1ea057cac0fc7b1c022c34e654ce2efe9dcf;hp=a6311b7ccdb76a85232a8f006eea08ff6971b21a;hb=04a9a2aaf7d17ce84a78ddf132fdb20486aa4218;hpb=f466fd7c66570af8f80e8ee085ff9c945aee8ffd
>
> Note, though, that there may be other skin fixes between 2.0.2 and 2.0.7, so
> you may want to be more systematic about looking at all the 'default' skin
> changes from 2.0.2 to 2.0.7 and applying them to your custom skin.
Yep, and the Niagara skin currently includes in line 310 of adv_global.js:
string = string.replace(/'/g,' ');
... which is what is introducing the space-instead-of-an-apostrophe
problem in the advanced search.
Re: [OPEN-ILS-GENERAL] apostrophe in title search causing problems (Bug #744513)
Ben: I'm with the Niagara Evergreen Consortium, along with Gordana (Version 2.0.7). When I do a search for "King's Speech", I get zero hits returned, and the search term has the apostrophe stripped from it, "King s speech". When I do a search for "Kings speech", I get the proper results. James Wagner Technical Services Co-ordinator Lincoln Public Library Vineland ON 905-563-2799 ext 216 wag...@lincoln.library.on.ca -Original Message- From: open-ils-general-boun...@list.georgialibraries.org [mailto:open-ils-general-boun...@list.georgialibraries.org] On Behalf Of Ben Shum Sent: Tuesday, July 19, 2011 12:57 PM To: open-ils-general@list.georgialibraries.org Subject: Re: [OPEN-ILS-GENERAL] apostrophe in title search causing problems (Bug #744513) Hi Gordana, We're using 2.0.6, but we've applied by hand several patches from 2.0.7 and the upcoming 2.0.8. Trying a search on our system for a title with an apostrophe such as "boys don't cry" worked just fine without any change to the search terms. I tested this in our staff client and OPAC and both were fine. What I did notice however, is that if one were to hit the advanced search after completing the initial search, it would construct the next screen with my search terms without an apostrophe so: "boys don t cry" would show up instead. Running that search still retrieved some results on our system, but not as many. I'll do some more tests and add a note to the bug ticket if I can replicate the behavior consistently. In the meantime, I would verify that you have cleared the cache on your web browsers and staff client (admin --> for developers --> clear cache) to make sure that there aren't strange remnants in the code from before your upgrade. Then try again. -- Ben On 07/19/2011 12:16 PM, Gordana Vitez wrote: > Hi everyone, > > We recently upgraded to 2.0.7 and noticed that a search using an apostrophe in the staff client or the advanced search screen returns no results. For example: searching "cops don't cry" in Niagara College's catalogue returns the following results: > > http://niagaracollege.niagaraevergreen.ca/opac/en-CA/skin/nc/xml/rresu > lt.xml?if=&it=&bl=&lf=&a=&la=&cl=&d=1&l=2&s=rel&sd=asc&adt=ml&tp=&t=ke > yword%3A%20cops%20don%20t%20cry&av=&rt=multi&ol=2 > > You'll notice that there is a space where the apostrophe should be. > > I did find the following Bug #744513 that shows a fix was committed for 2.0.6. Is it possible that the fix wasn't committed to 2.0.7 or wasn't included in upgrade instructions? Our upgrade was from 2.0.2 to 2.0.7. > > Thanks! > Gordana > > Gordana Vitez > Library Services & Systems Coordinator NC Libraries and Learning > Commons Niagara College 300 Woodlawn Rd Welland Ontario L3C 7L3 > Phone: (905) 735 2211 ext 7404 > Fax: (905) 736 6021 > gvi...@niagaracollege.ca > > > -- Benjamin Shum Open Source Software Coordinator Bibliomation, Inc. 32 Crest Road Middlebury, CT 06762 203-577-4070, ext. 113
Re: [OPEN-ILS-GENERAL] apostrophe in title search causing problems (Bug #744513)
Hello Gordana,
This was a skin level fix, so since you are using a custom skin ('nc'), it must
be applied manually to your skin after upgrading. Since the fix is simply
deleting a single line, it should be pretty simple to take care of. See here
to view the actual change needed:
http://git.evergreen-ils.org/?p=Evergreen.git;a=blobdiff;f=Open-ILS/web/opac/skin/default/js/adv_global.js;h=897b1ea057cac0fc7b1c022c34e654ce2efe9dcf;hp=a6311b7ccdb76a85232a8f006eea08ff6971b21a;hb=04a9a2aaf7d17ce84a78ddf132fdb20486aa4218;hpb=f466fd7c66570af8f80e8ee085ff9c945aee8ffd
Note, though, that there may be other skin fixes between 2.0.2 and 2.0.7, so
you may want to be more systematic about looking at all the 'default' skin
changes from 2.0.2 to 2.0.7 and applying them to your custom skin.
Good luck!
Dan
--
*
Daniel Wells, Library Programmer Analyst d...@calvin.edu
Hekman Library at Calvin College
616.526.7133
>>> On 7/19/2011 at 12:16 PM, "Gordana Vitez" wrote:
> Hi everyone,
>
> We recently upgraded to 2.0.7 and noticed that a search using an apostrophe
> in the staff client or the advanced search screen returns no results. For
> example: searching "cops don't cry" in Niagara College's catalogue returns
> the following results:
>
> http://niagaracollege.niagaraevergreen.ca/opac/en-CA/skin/nc/xml/rresult.xml?
> if=&it=&bl=&lf=&a=&la=&cl=&d=1&l=2&s=rel&sd=asc&adt=ml&tp=&t=keyword%3A%20cops%20don%20t%2
> 0cry&av=&rt=multi&ol=2
>
> You'll notice that there is a space where the apostrophe should be.
>
> I did find the following Bug #744513 that shows a fix was committed for
> 2.0.6. Is it possible that the fix wasn't committed to 2.0.7 or wasn't
> included in upgrade instructions? Our upgrade was from 2.0.2 to 2.0.7.
>
> Thanks!
> Gordana
>
> Gordana Vitez
> Library Services & Systems Coordinator
> NC Libraries and Learning Commons
> Niagara College
> 300 Woodlawn Rd
> Welland Ontario
> L3C 7L3
> Phone: (905) 735 2211 ext 7404
> Fax: (905) 736 6021
> gvi...@niagaracollege.ca
Re: [OPEN-ILS-GENERAL] apostrophe in title search causing problems(Bug #744513)
Hi Ben, Thanks for you suggestion. Just after the upgrade to 2.0.7, all of our computers were upgrade to Windows 7 so everything was wiped clean. Nevertheless, I did try clearing the cache for staff client and web browsers and still came up with the problem. I'll follow the bug ticket as well. Thanks! Gordana >>> Ben Shum 7/19/2011 12:57 PM >>> Hi Gordana, We're using 2.0.6, but we've applied by hand several patches from 2.0.7 and the upcoming 2.0.8. Trying a search on our system for a title with an apostrophe such as "boys don't cry" worked just fine without any change to the search terms. I tested this in our staff client and OPAC and both were fine. What I did notice however, is that if one were to hit the advanced search after completing the initial search, it would construct the next screen with my search terms without an apostrophe so: "boys don t cry" would show up instead. Running that search still retrieved some results on our system, but not as many. I'll do some more tests and add a note to the bug ticket if I can replicate the behavior consistently. In the meantime, I would verify that you have cleared the cache on your web browsers and staff client (admin --> for developers --> clear cache) to make sure that there aren't strange remnants in the code from before your upgrade. Then try again. -- Ben On 07/19/2011 12:16 PM, Gordana Vitez wrote: > Hi everyone, > > We recently upgraded to 2.0.7 and noticed that a search using an apostrophe > in the staff client or the advanced search screen returns no results. For > example: searching "cops don't cry" in Niagara College's catalogue returns > the following results: > > http://niagaracollege.niagaraevergreen.ca/opac/en-CA/skin/nc/xml/rresult.xml?if=&it=&bl=&lf=&a=&la=&cl=&d=1&l=2&s=rel&sd=asc&adt=ml&tp=&t=keyword%3A%20cops%20don%20t%20cry&av=&rt=multi&ol=2 > > > You'll notice that there is a space where the apostrophe should be. > > I did find the following Bug #744513 that shows a fix was committed for > 2.0.6. Is it possible that the fix wasn't committed to 2.0.7 or wasn't > included in upgrade instructions? Our upgrade was from 2.0.2 to 2.0.7. > > Thanks! > Gordana > > Gordana Vitez > Library Services & Systems Coordinator > NC Libraries and Learning Commons > Niagara College > 300 Woodlawn Rd > Welland Ontario > L3C 7L3 > Phone: (905) 735 2211 ext 7404 > Fax: (905) 736 6021 > gvi...@niagaracollege.ca > > > -- Benjamin Shum Open Source Software Coordinator Bibliomation, Inc. 32 Crest Road Middlebury, CT 06762 203-577-4070, ext. 113
Re: [OPEN-ILS-GENERAL] apostrophe in title search causing problems (Bug #744513)
Hi Gordana, We're using 2.0.6, but we've applied by hand several patches from 2.0.7 and the upcoming 2.0.8. Trying a search on our system for a title with an apostrophe such as "boys don't cry" worked just fine without any change to the search terms. I tested this in our staff client and OPAC and both were fine. What I did notice however, is that if one were to hit the advanced search after completing the initial search, it would construct the next screen with my search terms without an apostrophe so: "boys don t cry" would show up instead. Running that search still retrieved some results on our system, but not as many. I'll do some more tests and add a note to the bug ticket if I can replicate the behavior consistently. In the meantime, I would verify that you have cleared the cache on your web browsers and staff client (admin --> for developers --> clear cache) to make sure that there aren't strange remnants in the code from before your upgrade. Then try again. -- Ben On 07/19/2011 12:16 PM, Gordana Vitez wrote: > Hi everyone, > > We recently upgraded to 2.0.7 and noticed that a search using an apostrophe > in the staff client or the advanced search screen returns no results. For > example: searching "cops don't cry" in Niagara College's catalogue returns > the following results: > > http://niagaracollege.niagaraevergreen.ca/opac/en-CA/skin/nc/xml/rresult.xml?if=&it=&bl=&lf=&a=&la=&cl=&d=1&l=2&s=rel&sd=asc&adt=ml&tp=&t=keyword%3A%20cops%20don%20t%20cry&av=&rt=multi&ol=2 > > You'll notice that there is a space where the apostrophe should be. > > I did find the following Bug #744513 that shows a fix was committed for > 2.0.6. Is it possible that the fix wasn't committed to 2.0.7 or wasn't > included in upgrade instructions? Our upgrade was from 2.0.2 to 2.0.7. > > Thanks! > Gordana > > Gordana Vitez > Library Services & Systems Coordinator > NC Libraries and Learning Commons > Niagara College > 300 Woodlawn Rd > Welland Ontario > L3C 7L3 > Phone: (905) 735 2211 ext 7404 > Fax: (905) 736 6021 > gvi...@niagaracollege.ca > > > -- Benjamin Shum Open Source Software Coordinator Bibliomation, Inc. 32 Crest Road Middlebury, CT 06762 203-577-4070, ext. 113
[OPEN-ILS-GENERAL] apostrophe in title search causing problems (Bug #744513)
Hi everyone, We recently upgraded to 2.0.7 and noticed that a search using an apostrophe in the staff client or the advanced search screen returns no results. For example: searching "cops don't cry" in Niagara College's catalogue returns the following results: http://niagaracollege.niagaraevergreen.ca/opac/en-CA/skin/nc/xml/rresult.xml?if=&it=&bl=&lf=&a=&la=&cl=&d=1&l=2&s=rel&sd=asc&adt=ml&tp=&t=keyword%3A%20cops%20don%20t%20cry&av=&rt=multi&ol=2 You'll notice that there is a space where the apostrophe should be. I did find the following Bug #744513 that shows a fix was committed for 2.0.6. Is it possible that the fix wasn't committed to 2.0.7 or wasn't included in upgrade instructions? Our upgrade was from 2.0.2 to 2.0.7. Thanks! Gordana Gordana Vitez Library Services & Systems Coordinator NC Libraries and Learning Commons Niagara College 300 Woodlawn Rd Welland Ontario L3C 7L3 Phone: (905) 735 2211 ext 7404 Fax: (905) 736 6021 gvi...@niagaracollege.ca
