Re: [PATCH] iBFT 'origin' is an enum, not a string
On 7/10/15, 2:08 PM, leeman.dun...@gmail.com wrote: From: Lee Duncan ldun...@suse.com The iBFT 'origin' value is read in one place correctly as an integer. This fixes the place where it was treated as a string. --- utils/fwparam_ibft/fwparam_ibft_sysfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/utils/fwparam_ibft/fwparam_ibft_sysfs.c b/utils/fwparam_ibft/fwparam_ibft_sysfs.c index 2dc6f6d5fe54..019fc19184bb 100644 --- a/utils/fwparam_ibft/fwparam_ibft_sysfs.c +++ b/utils/fwparam_ibft/fwparam_ibft_sysfs.c @@ -201,8 +201,7 @@ static int fill_nic_context(char *id, struct boot_context *context) sizeof(context-secondary_dns)); sysfs_get_str(id, IBFT_SUBSYS, dhcp, context-dhcp, sizeof(context-dhcp)); - sysfs_get_str(id, IBFT_SUBSYS, origin, context-origin, - sizeof(context-origin)); + sysfd_get_int(id, IBFT_SUBSYS, origin, context-origin); return 0; } Merged in commit cab532bab9886f666518e18a6ef6b56b09d73864. Thanks. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
Re: [PATCH 0/2] Remove local open-isns, using system-installed version
On 7/14/15, 4:01 PM, leeman.dun...@gmail.com wrote: From: Lee Duncanldun...@suse.com This set of patches tells open-iscsi to use the system-resident open-isns files instead of the ones in utils/open-isns. This patch*requires* that you've installed open-isns (from g...@github.com:gonzoleeman/open-isns.git). The first patch tells open-iscsi to use the system-resident include files and library from open-isns. The second patch removes the local copy of same. Questions: - Should the documentation be updated? I didn't find anything that referenced open-isns Yeah, I can update the README to point to your github tree and wherever you are going to put releases. Let me know the link for the latter. - Is it perhaps time to bump the minor version of open-iscsi? It's been a while. Yeah, I am going to make a release soon now. There is just one regression that I wanted to fix. I think commit 36a8b41de43749d91dfd52f9c8ad4a454c9a8f15 added a bug that slows down setup of multiple sessions. Note: it is my intention to create an open-isns package for SUSE. I assume other platforms will have to do the same before they could incorporate this patch. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
