Re: [PATCH] libiscsi: Fix use-after-free race during iscsi_session_teardown
Hi Khazhismel, [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on v4.12 next-20170713] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Khazhismel-Kumykov/libiscsi-Fix-use-after-free-race-during-iscsi_session_teardown/20170713-231300 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=xtensa All warnings (new ones prefixed by >>): drivers//scsi/libiscsi.c: In function 'iscsi_session_teardown': >> drivers//scsi/libiscsi.c:2863:2: warning: passing argument 1 of >> 'iscsi_remove_session' from incompatible pointer type iscsi_remove_session(session); ^ In file included from drivers//scsi/libiscsi.c:41:0: include/scsi/scsi_transport_iscsi.h:435:13: note: expected 'struct iscsi_cls_session *' but argument is of type 'struct iscsi_session *' extern void iscsi_remove_session(struct iscsi_cls_session *session); ^ vim +/iscsi_remove_session +2863 drivers//scsi/libiscsi.c 2850 2851 /** 2852 * iscsi_session_teardown - destroy session, host, and cls_session 2853 * @cls_session: iscsi session 2854 */ 2855 void iscsi_session_teardown(struct iscsi_cls_session *cls_session) 2856 { 2857 struct iscsi_session *session = cls_session->dd_data; 2858 struct module *owner = cls_session->transport->owner; 2859 struct Scsi_Host *shost = session->host; 2860 2861 iscsi_pool_free(>cmdpool); 2862 > 2863 iscsi_remove_session(session); 2864 2865 kfree(session->password); 2866 kfree(session->password_in); 2867 kfree(session->username); 2868 kfree(session->username_in); 2869 kfree(session->targetname); 2870 kfree(session->targetalias); 2871 kfree(session->initiatorname); 2872 kfree(session->boot_root); 2873 kfree(session->boot_nic); 2874 kfree(session->boot_target); 2875 kfree(session->ifacename); 2876 kfree(session->portal_type); 2877 kfree(session->discovery_parent_type); 2878 2879 iscsi_free_session(cls_session); 2880 2881 iscsi_host_dec_session_cnt(shost); 2882 module_put(owner); 2883 } 2884 EXPORT_SYMBOL_GPL(iscsi_session_teardown); 2885 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. .config.gz Description: application/gzip
Re: [PATCH] libiscsi: Fix use-after-free race during iscsi_session_teardown
Hi Khazhismel, [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on v4.12 next-20170713] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Khazhismel-Kumykov/libiscsi-Fix-use-after-free-race-during-iscsi_session_teardown/20170713-231300 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: i386-randconfig-x018-201728 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers//scsi/libiscsi.c: In function 'iscsi_session_teardown': >> drivers//scsi/libiscsi.c:2863:23: error: passing argument 1 of >> 'iscsi_remove_session' from incompatible pointer type >> [-Werror=incompatible-pointer-types] iscsi_remove_session(session); ^~~ In file included from drivers//scsi/libiscsi.c:41:0: include/scsi/scsi_transport_iscsi.h:435:13: note: expected 'struct iscsi_cls_session *' but argument is of type 'struct iscsi_session *' extern void iscsi_remove_session(struct iscsi_cls_session *session); ^~~~ cc1: some warnings being treated as errors vim +/iscsi_remove_session +2863 drivers//scsi/libiscsi.c 2850 2851 /** 2852 * iscsi_session_teardown - destroy session, host, and cls_session 2853 * @cls_session: iscsi session 2854 */ 2855 void iscsi_session_teardown(struct iscsi_cls_session *cls_session) 2856 { 2857 struct iscsi_session *session = cls_session->dd_data; 2858 struct module *owner = cls_session->transport->owner; 2859 struct Scsi_Host *shost = session->host; 2860 2861 iscsi_pool_free(>cmdpool); 2862 > 2863 iscsi_remove_session(session); 2864 2865 kfree(session->password); 2866 kfree(session->password_in); 2867 kfree(session->username); 2868 kfree(session->username_in); 2869 kfree(session->targetname); 2870 kfree(session->targetalias); 2871 kfree(session->initiatorname); 2872 kfree(session->boot_root); 2873 kfree(session->boot_nic); 2874 kfree(session->boot_target); 2875 kfree(session->ifacename); 2876 kfree(session->portal_type); 2877 kfree(session->discovery_parent_type); 2878 2879 iscsi_free_session(cls_session); 2880 2881 iscsi_host_dec_session_cnt(shost); 2882 module_put(owner); 2883 } 2884 EXPORT_SYMBOL_GPL(iscsi_session_teardown); 2885 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. .config.gz Description: application/gzip
Re: [PATCH] libiscsi: Remove iscsi_destroy_session
Hi Khazhismel, [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on v4.12 next-20170713] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Khazhismel-Kumykov/libiscsi-Remove-iscsi_destroy_session/20170713-185526 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: blackfin-allyesconfig (attached as .config) compiler: bfin-uclinux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=blackfin All errors (new ones prefixed by >>): drivers/scsi/libiscsi.c: In function 'iscsi_session_teardown': >> drivers/scsi/libiscsi.c:2880:2: error: implicit declaration of function >> 'iscsi_destroy_session' [-Werror=implicit-function-declaration] iscsi_destroy_session(cls_session); ^ cc1: some warnings being treated as errors vim +/iscsi_destroy_session +2880 drivers/scsi/libiscsi.c 7996a778 Mike Christie2006-04-06 2850 7996a778 Mike Christie2006-04-06 2851 /** 7996a778 Mike Christie2006-04-06 2852 * iscsi_session_teardown - destroy session, host, and cls_session 75613521 Mike Christie2008-05-21 2853 * @cls_session: iscsi session 7996a778 Mike Christie2006-04-06 2854 * 75613521 Mike Christie2008-05-21 2855 * The driver must have called iscsi_remove_session before 75613521 Mike Christie2008-05-21 2856 * calling this. 75613521 Mike Christie2008-05-21 2857 */ 7996a778 Mike Christie2006-04-06 2858 void iscsi_session_teardown(struct iscsi_cls_session *cls_session) 7996a778 Mike Christie2006-04-06 2859 { 75613521 Mike Christie2008-05-21 2860 struct iscsi_session *session = cls_session->dd_data; 63f75cc8 Mike Christie2006-07-24 2861 struct module *owner = cls_session->transport->owner; e5bd7b54 Mike Christie2008-09-24 2862 struct Scsi_Host *shost = session->host; 7996a778 Mike Christie2006-04-06 2863 6320377f Olaf Kirch 2007-12-13 2864 iscsi_pool_free(>cmdpool); 7996a778 Mike Christie2006-04-06 2865 b2c64167 Mike Christie2007-05-30 2866 kfree(session->password); b2c64167 Mike Christie2007-05-30 2867 kfree(session->password_in); b2c64167 Mike Christie2007-05-30 2868 kfree(session->username); b2c64167 Mike Christie2007-05-30 2869 kfree(session->username_in); f3ff0c36 Mike Christie2006-07-24 2870 kfree(session->targetname); 3c5c4801 Vikas Chaudhary 2012-01-19 2871 kfree(session->targetalias); 88dfd340 Mike Christie2008-05-21 2872 kfree(session->initiatorname); 3b9373e9 Eddie Wai2013-06-20 2873 kfree(session->boot_root); 3b9373e9 Eddie Wai2013-06-20 2874 kfree(session->boot_nic); 3b9373e9 Eddie Wai2013-06-20 2875 kfree(session->boot_target); 88dfd340 Mike Christie2008-05-21 2876 kfree(session->ifacename); f8525eb4 Adheer Chandravanshi 2013-07-01 2877 kfree(session->portal_type); f8525eb4 Adheer Chandravanshi 2013-07-01 2878 kfree(session->discovery_parent_type); f3ff0c36 Mike Christie2006-07-24 2879 75613521 Mike Christie2008-05-21 @2880 iscsi_destroy_session(cls_session); e5bd7b54 Mike Christie2008-09-24 2881 iscsi_host_dec_session_cnt(shost); 63f75cc8 Mike Christie2006-07-24 2882 module_put(owner); 7996a778 Mike Christie2006-04-06 2883 } 7996a778 Mike Christie2006-04-06 2884 EXPORT_SYMBOL_GPL(iscsi_session_teardown); 7996a778 Mike Christie2006-04-06 2885 :: The code at line 2880 was first introduced by commit :: 756135215ec743be6fdce2bdebe8cdb9f8a231f6 [SCSI] iscsi: remove session and host binding in libiscsi :: TO: Mike Christie:: CC: James Bottomley --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. .config.gz Description: application/gzip
Re: [PATCH 2/7] scsi/scsi_transport_iscsi: Update ep_connect to include iface.
Hi Robert, [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on v4.12-rc4 next-20170608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Robert-LeBlanc/Enable-iSCSI-offload-drivers-to-use-information-from-iface/20170607-211934 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=ia64 All errors (new ones prefixed by >>): >> drivers/scsi//qedi/qedi_iscsi.c:1402:16: error: initialization from >> incompatible pointer type [-Werror=incompatible-pointer-types] .ep_connect = qedi_ep_connect, ^~~ drivers/scsi//qedi/qedi_iscsi.c:1402:16: note: (near initialization for 'qedi_iscsi_transport.ep_connect') cc1: some warnings being treated as errors vim +1402 drivers/scsi//qedi/qedi_iscsi.c ace7f46b Manish Rangankar 2016-12-01 1386 .destroy_session = qedi_session_destroy, ace7f46b Manish Rangankar 2016-12-01 1387 .create_conn = qedi_conn_create, ace7f46b Manish Rangankar 2016-12-01 1388 .bind_conn = qedi_conn_bind, ace7f46b Manish Rangankar 2016-12-01 1389 .start_conn = qedi_conn_start, ace7f46b Manish Rangankar 2016-12-01 1390 .stop_conn = iscsi_conn_stop, ace7f46b Manish Rangankar 2016-12-01 1391 .destroy_conn = qedi_conn_destroy, ace7f46b Manish Rangankar 2016-12-01 1392 .set_param = iscsi_set_param, ace7f46b Manish Rangankar 2016-12-01 1393 .get_ep_param = qedi_ep_get_param, ace7f46b Manish Rangankar 2016-12-01 1394 .get_conn_param = iscsi_conn_get_param, ace7f46b Manish Rangankar 2016-12-01 1395 .get_session_param = iscsi_session_get_param, ace7f46b Manish Rangankar 2016-12-01 1396 .get_host_param = qedi_host_get_param, ace7f46b Manish Rangankar 2016-12-01 1397 .send_pdu = iscsi_conn_send_pdu, ace7f46b Manish Rangankar 2016-12-01 1398 .get_stats = qedi_conn_get_stats, ace7f46b Manish Rangankar 2016-12-01 1399 .xmit_task = qedi_task_xmit, ace7f46b Manish Rangankar 2016-12-01 1400 .cleanup_task = qedi_cleanup_task, ace7f46b Manish Rangankar 2016-12-01 1401 .session_recovery_timedout = iscsi_session_recovery_timedout, ace7f46b Manish Rangankar 2016-12-01 @1402 .ep_connect = qedi_ep_connect, ace7f46b Manish Rangankar 2016-12-01 1403 .ep_poll = qedi_ep_poll, ace7f46b Manish Rangankar 2016-12-01 1404 .ep_disconnect = qedi_ep_disconnect, ace7f46b Manish Rangankar 2016-12-01 1405 .set_path = qedi_set_path, ace7f46b Manish Rangankar 2016-12-01 1406 .attr_is_visible = qedi_attr_is_visible, ace7f46b Manish Rangankar 2016-12-01 1407 }; ace7f46b Manish Rangankar 2016-12-01 1408 ace7f46b Manish Rangankar 2016-12-01 1409 void qedi_start_conn_recovery(struct qedi_ctx *qedi, ace7f46b Manish Rangankar 2016-12-01 1410struct qedi_conn *qedi_conn) :: The code at line 1402 was first introduced by commit :: ace7f46ba5fde7273207c7122b0650ceb72510e0 scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework. :: TO: Manish Rangankar:: CC: Martin K. Petersen --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. .config.gz Description: application/gzip
Re: [PATCH 1/7] scsi/scsi_transport_iscsi: Add iface struct to kernel.
Hi Robert, [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on v4.12-rc4 next-20170608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Robert-LeBlanc/Enable-iSCSI-offload-drivers-to-use-information-from-iface/20170607-211934 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=ia64 All errors (new ones prefixed by >>): In file included from include/scsi/libiscsi.h:35:0, from drivers/scsi/be2iscsi/be_iscsi.c:15: >> include/scsi/scsi_transport_iscsi.h:308:16: error: 'IFNAMSIZ' undeclared >> here (not in a function) char netdev[IFNAMSIZ]; ^~~~ vim +/IFNAMSIZ +308 include/scsi/scsi_transport_iscsi.h 302 struct iface_rec { 303 struct list_headlist; 304 /* iscsi iface record name */ 305 charname[ISCSI_MAX_IFACE_LEN]; 306 uint32_tiface_num; 307 /* network layer iface name (eth0) */ > 308 charnetdev[IFNAMSIZ]; 309 charipaddress[NI_MAXHOST]; 310 charsubnet_mask[NI_MAXHOST]; 311 chargateway[NI_MAXHOST]; --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. .config.gz Description: application/gzip
Re: [PATCH 2/7] scsi/scsi_transport_iscsi: Update ep_connect to include iface.
Hi Robert, [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on v4.12-rc4 next-20170608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Robert-LeBlanc/Enable-iSCSI-offload-drivers-to-use-information-from-iface/20170607-211934 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-kexec (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: the linux-review/Robert-LeBlanc/Enable-iSCSI-offload-drivers-to-use-information-from-iface/20170607-211934 HEAD 9d84638ec1dd56cf18d796045165770d741fe422 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): >> drivers/scsi/qla4xxx/ql4_os.c:236:17: error: initialization from >> incompatible pointer type [-Werror=incompatible-pointer-types] .ep_connect = qla4xxx_ep_connect, ^~ drivers/scsi/qla4xxx/ql4_os.c:236:17: note: (near initialization for 'qla4xxx_iscsi_transport.ep_connect') cc1: some warnings being treated as errors vim +236 drivers/scsi/qla4xxx/ql4_os.c b3a271a9 Manish Rangankar 2011-07-25 220 .caps = CAP_TEXT_NEGO | b3a271a9 Manish Rangankar 2011-07-25 221 CAP_DATA_PATH_OFFLOAD | CAP_HDRDGST | b3a271a9 Manish Rangankar 2011-07-25 222 CAP_DATADGST | CAP_LOGIN_OFFLOAD | b3a271a9 Manish Rangankar 2011-07-25 223 CAP_MULTI_R2T, 5e9bcec7 Vikas Chaudhary 2012-08-22 224 .attr_is_visible= qla4_attr_is_visible, b3a271a9 Manish Rangankar 2011-07-25 225 .create_session = qla4xxx_session_create, b3a271a9 Manish Rangankar 2011-07-25 226 .destroy_session= qla4xxx_session_destroy, b3a271a9 Manish Rangankar 2011-07-25 227 .start_conn = qla4xxx_conn_start, b3a271a9 Manish Rangankar 2011-07-25 228 .create_conn= qla4xxx_conn_create, b3a271a9 Manish Rangankar 2011-07-25 229 .bind_conn = qla4xxx_conn_bind, b3a271a9 Manish Rangankar 2011-07-25 230 .stop_conn = iscsi_conn_stop, b3a271a9 Manish Rangankar 2011-07-25 231 .destroy_conn = qla4xxx_conn_destroy, b3a271a9 Manish Rangankar 2011-07-25 232 .set_param = iscsi_set_param, afaf5a2d David Somayajulu 2006-09-19 233 .get_conn_param = qla4xxx_conn_get_param, fca9f04d Mike Christie2012-02-27 234 .get_session_param = qla4xxx_session_get_param, b3a271a9 Manish Rangankar 2011-07-25 235 .get_ep_param = qla4xxx_get_ep_param, b3a271a9 Manish Rangankar 2011-07-25 @236 .ep_connect = qla4xxx_ep_connect, b3a271a9 Manish Rangankar 2011-07-25 237 .ep_poll= qla4xxx_ep_poll, b3a271a9 Manish Rangankar 2011-07-25 238 .ep_disconnect = qla4xxx_ep_disconnect, b3a271a9 Manish Rangankar 2011-07-25 239 .get_stats = qla4xxx_conn_get_stats, b3a271a9 Manish Rangankar 2011-07-25 240 .send_pdu = iscsi_conn_send_pdu, b3a271a9 Manish Rangankar 2011-07-25 241 .xmit_task = qla4xxx_task_xmit, b3a271a9 Manish Rangankar 2011-07-25 242 .cleanup_task = qla4xxx_task_cleanup, b3a271a9 Manish Rangankar 2011-07-25 243 .alloc_pdu = qla4xxx_alloc_pdu, b3a271a9 Manish Rangankar 2011-07-25 244 :: The code at line 236 was first introduced by commit :: b3a271a94d0034dd3bab10b8d8cd432843be629e [SCSI] qla4xxx: support iscsiadm session mgmt :: TO: Manish Rangankar:: CC: James Bottomley --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. .config.gz Description: application/gzip
Re: [PATCH 4/26] dm crypt: Use skcipher and ahash
Hi Herbert, [auto build test ERROR on net/master] [also build test ERROR on v4.4 next-20160122] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Herbert-Xu/crypto-Use-skcipher-and-ahash-shash-where-possible/20160124-212323 config: x86_64-randconfig-x014-201604 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/md/dm-crypt.c: In function 'crypt_iv_essiv_init': >> drivers/md/dm-crypt.c:278:2: error: implicit declaration of function >> 'ahash_request_zero' [-Werror=implicit-function-declaration] ahash_request_zero(req); ^ cc1: some warnings being treated as errors vim +/ahash_request_zero +278 drivers/md/dm-crypt.c 272 sg_init_one(, cc->key, cc->key_size); 273 ahash_request_set_tfm(req, essiv->hash_tfm); 274 ahash_request_set_callback(req, CRYPTO_TFM_REQ_MAY_SLEEP, NULL, NULL); 275 ahash_request_set_crypt(req, , essiv->salt, cc->key_size); 276 277 err = crypto_ahash_digest(req); > 278 ahash_request_zero(req); 279 if (err) 280 return err; 281 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. .config.gz Description: Binary data
Re: [PATCH 24/26] nfsd: Use shash
Hi Herbert, [auto build test ERROR on net/master] [also build test ERROR on v4.4 next-20160122] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Herbert-Xu/crypto-Use-skcipher-and-ahash-shash-where-possible/20160124-212323 config: x86_64-randconfig-x009-201604 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): fs/nfsd/nfs4recover.c: In function 'nfs4_make_rec_clidname': >> fs/nfsd/nfs4recover.c:133:3: error: implicit declaration of function >> 'shash_desc_zero' [-Werror=implicit-function-declaration] shash_desc_zero(desc); ^ cc1: some warnings being treated as errors vim +/shash_desc_zero +133 fs/nfsd/nfs4recover.c 127 128 desc->tfm = tfm; 129 desc->flags = CRYPTO_TFM_REQ_MAY_SLEEP; 130 131 status = crypto_shash_digest(desc, clname->data, clname->len, 132 cksum.data); > 133 shash_desc_zero(desc); 134 } 135 136 if (status) --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. .config.gz Description: Binary data
Re: [PATCH 1/26] block: cryptoloop - Use new skcipher interface
Hi Herbert, [auto build test ERROR on net/master] [also build test ERROR on v4.4 next-20160122] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Herbert-Xu/crypto-Use-skcipher-and-ahash-shash-where-possible/20160124-212323 config: x86_64-randconfig-x014-201604 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/block/cryptoloop.c: In function 'cryptoloop_transfer': >> drivers/block/cryptoloop.c:167:2: error: implicit declaration of function >> 'skcipher_request_zero' [-Werror=implicit-function-declaration] skcipher_request_zero(req); ^ cc1: some warnings being treated as errors vim +/skcipher_request_zero +167 drivers/block/cryptoloop.c 161 out_offs += sz; 162 } 163 164 err = 0; 165 166 out: > 167 skcipher_request_zero(req); 168 return err; 169 } 170 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. .config.gz Description: Binary data
Re: [PATCH 15/26] Bluetooth: Use skcipher and hash
Hi Herbert, [auto build test ERROR on net/master] [also build test ERROR on v4.4 next-20160122] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Herbert-Xu/crypto-Use-skcipher-and-ahash-shash-where-possible/20160124-212323 config: x86_64-randconfig-x014-201604 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): net/bluetooth/smp.c: In function 'aes_cmac': >> net/bluetooth/smp.c:201:2: error: implicit declaration of function >> 'shash_desc_zero' [-Werror=implicit-function-declaration] shash_desc_zero(desc); ^ net/bluetooth/smp.c: In function 'smp_e': >> net/bluetooth/smp.c:397:2: error: implicit declaration of function >> 'skcipher_request_zero' [-Werror=implicit-function-declaration] skcipher_request_zero(req); ^ cc1: some warnings being treated as errors vim +/shash_desc_zero +201 net/bluetooth/smp.c 195 if (err) { 196 BT_ERR("cipher setkey failed: %d", err); 197 return err; 198 } 199 200 err = crypto_shash_digest(desc, msg_msb, len, mac_msb); > 201 shash_desc_zero(desc); 202 if (err) { 203 BT_ERR("Hash computation error %d", err); 204 return err; 205 } 206 207 swap_buf(mac_msb, mac, 16); 208 209 SMP_DBG("mac %16phN", mac); 210 211 return 0; 212 } 213 214 static int smp_f4(struct crypto_shash *tfm_cmac, const u8 u[32], 215const u8 v[32], const u8 x[16], u8 z, u8 res[16]) 216 { 217 u8 m[65]; 218 int err; 219 220 SMP_DBG("u %32phN", u); 221 SMP_DBG("v %32phN", v); 222 SMP_DBG("x %16phN z %02x", x, z); 223 224 m[0] = z; 225 memcpy(m + 1, v, 32); 226 memcpy(m + 33, u, 32); 227 228 err = aes_cmac(tfm_cmac, x, m, sizeof(m), res); 229 if (err) 230 return err; 231 232 SMP_DBG("res %16phN", res); 233 234 return err; 235 } 236 237 static int smp_f5(struct crypto_shash *tfm_cmac, const u8 w[32], 238const u8 n1[16], const u8 n2[16], const u8 a1[7], 239const u8 a2[7], u8 mackey[16], u8 ltk[16]) 240 { 241 /* The btle, salt and length "magic" values are as defined in 242 * the SMP section of the Bluetooth core specification. In ASCII 243 * the btle value ends up being 'btle'. The salt is just a 244 * random number whereas length is the value 256 in little 245 * endian format. 246 */ 247 const u8 btle[4] = { 0x65, 0x6c, 0x74, 0x62 }; 248 const u8 salt[16] = { 0xbe, 0x83, 0x60, 0x5a, 0xdb, 0x0b, 0x37, 0x60, 2490x38, 0xa5, 0xf5, 0xaa, 0x91, 0x83, 0x88, 0x6c }; 250 const u8 length[2] = { 0x00, 0x01 }; 251 u8 m[53], t[16]; 252 int err; 253 254 SMP_DBG("w %32phN", w); 255 SMP_DBG("n1 %16phN n2 %16phN", n1, n2); 256 SMP_DBG("a1 %7phN a2 %7phN", a1, a2); 257 258 err = aes_cmac(tfm_cmac, salt, w, 32, t); 259 if (err) 260 return err; 261 262 SMP_DBG("t %16phN", t); 263 264 memcpy(m, length, 2); 265 memcpy(m + 2, a2, 7); 266 memcpy(m + 9, a1, 7); 267 memcpy(m + 16, n2, 16); 268 memcpy(m + 32, n1, 16); 269 memcpy(m + 48, btle, 4); 270 271 m[52] = 0; /* Counter */ 272 273 err = aes_cmac(tfm_cmac, t, m, sizeof(m), mackey); 274 if (err) 275 return err; 276 277 SMP_DBG("mackey %16phN", mackey); 278 279 m[52] = 1; /* Counter */ 280 281 err = aes_cmac(tfm_cmac, t, m, sizeof(m), ltk); 282 if (err) 283 return err; 284 285 SMP_DBG("ltk %16phN", ltk); 286 287 return 0; 288 } 289 290 static int smp_f6(struct crypto_shash *tfm_cmac, const u8 w[16], 291const u8 n1[16], const u8 n2[16], const u8 r[16], 292const u8 io_cap[3], const u8 a1[7], const u8 a2[7], 293u8 res[16]) 294 { 295 u8 m[65]; 296 int err; 297 298 SMP_DBG("w %16phN", w); 299 SMP_DBG("n1 %16phN n2 %16phN", n1, n2); 300 SMP_DBG("r %16phN io_cap %3phN a1 %7phN a2 %7phN", r, io_cap, a1, a2); 301 302 memcpy(m, a2, 7); 303 memcpy(m + 7, a1, 7); 304
Re: [PATCH 19/26] ipsec: Use skcipher and ahash when probing algorithms
Hi Herbert, [auto build test ERROR on net/master] [also build test ERROR on v4.4 next-20160122] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Herbert-Xu/crypto-Use-skcipher-and-ahash-shash-where-possible/20160124-212323 config: x86_64-randconfig-x014-201604 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): net/xfrm/xfrm_algo.c: In function 'xfrm_probe_algs': >> net/xfrm/xfrm_algo.c:787:12: error: implicit declaration of function >> 'crypto_has_ahash' [-Werror=implicit-function-declaration] status = crypto_has_ahash(aalg_list[i].name, 0, 0); ^ cc1: some warnings being treated as errors vim +/crypto_has_ahash +787 net/xfrm/xfrm_algo.c 781 { 782 int i, status; 783 784 BUG_ON(in_softirq()); 785 786 for (i = 0; i < aalg_entries(); i++) { > 787 status = crypto_has_ahash(aalg_list[i].name, 0, 0); 788 if (aalg_list[i].available != status) 789 aalg_list[i].available = status; 790 } --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at https://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. .config.gz Description: Binary data