Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

[Willem Riede]

On Thu, May 2, 2019 at 7:19 AM Hannes Reinecke  wrote:

> On 5/2/19 2:53 PM, Christoph Hellwig wrote:
> > On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote:
> >> On 5/1/19 6:14 PM, Christoph Hellwig wrote:
> >>> osst.c is the only osst file missing licensing information.  Add a
> >>> GPLv2 tag for the default kernel license.
> >>>
> >>> Signed-off-by: Chriosstoph Hellwig 
> >
> > FYI, my s/st/osst/ on the commit message message up my signoff, this
> > should be:
> >
> > Signed-off-by: Christoph Hellwig 
> >
> Maybe it's time to kill osst.c for good ...
>

Yes. I've been thinking about doing just that. The devices it supports are
now thoroughly obsolete. The manufacturer has gone out of business. All my
test drives have broken down over time, so I can't even test any changes
any more.

Regards, Willem Riede, osst maintainer.


> Cheers,
>
> Hannes
> --
> Dr. Hannes ReineckeTeamlead Storage & Networking
> h...@suse.de   +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
> HRB 21284 (AG Nürnberg)
>

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/open-iscsi/CAKnBiiaSyW27tCqU4i6zStF3AoLPcndSL2gjz1b17LdoFddiiw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

[Willem Riede]

On Fri, May 3, 2019 at 1:05 AM Hannes Reinecke  wrote:

> On 5/2/19 9:55 PM, Willem Riede wrote:
> > On Thu, May 2, 2019 at 7:19 AM Hannes Reinecke  > > wrote:
> >
> >  >
> > Maybe it's time to kill osst.c for good ...
> >
> >
> > Yes. I've been thinking about doing just that. The devices it supports
> > are now thoroughly obsolete. The manufacturer has gone out of business.
> > All my test drives have broken down over time, so I can't even test any
> > changes any more.
> >
> Just when I thought to reach out to you :-)
>
> Thing is, we've done numerous changes to the 'st' driver in the course
> of the years, most of which seem to have avoided osst :-(
>
> So what's your suggestion here?
> Just drop it completely?
> Or can we somehow fold the OnStream-specific things back into st.c?
>
> I sincerely doubt anyone in the entire world still has an Onstream drive
working.
These days cheap flash drives have larger capacity and are way more
convenient.

I recommend to drop osst entirely and not to contaminate st.

Regards, Willem Riede.



> Cheers,
>
> Hannes
> --
> Dr. Hannes ReineckeTeamlead Storage & Networking
> h...@suse.de   +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
> HRB 21284 (AG Nürnberg)
>

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/open-iscsi/CAKnBiiYqwPNFU709s8bb%2BUhX18oqkTRyHpkO2pBAenisHiPUig%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

[Hannes Reinecke]

On 5/2/19 9:55 PM, Willem Riede wrote:
On Thu, May 2, 2019 at 7:19 AM Hannes Reinecke > wrote:


On 5/2/19 2:53 PM, Christoph Hellwig wrote:
 > On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote:
 >> On 5/1/19 6:14 PM, Christoph Hellwig wrote:
 >>> osst.c is the only osst file missing licensing information.  Add a
 >>> GPLv2 tag for the default kernel license.
 >>>
 >>> Signed-off-by: Chriosstoph Hellwig mailto:h...@losst.de>>
 >
 > FYI, my s/st/osst/ on the commit message message up my signoff, this
 > should be:
 >
 > Signed-off-by: Christoph Hellwig mailto:h...@lst.de>>
 >
Maybe it's time to kill osst.c for good ...


Yes. I've been thinking about doing just that. The devices it supports 
are now thoroughly obsolete. The manufacturer has gone out of business. 
All my test drives have broken down over time, so I can't even test any 
changes any more.



Just when I thought to reach out to you :-)

Thing is, we've done numerous changes to the 'st' driver in the course 
of the years, most of which seem to have avoided osst :-(


So what's your suggestion here?
Just drop it completely?
Or can we somehow fold the OnStream-specific things back into st.c?

Cheers,

Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

--
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

[Hannes Reinecke]

On 5/2/19 2:53 PM, Christoph Hellwig wrote:

On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote:

On 5/1/19 6:14 PM, Christoph Hellwig wrote:

osst.c is the only osst file missing licensing information.  Add a
GPLv2 tag for the default kernel license.

Signed-off-by: Chriosstoph Hellwig 


FYI, my s/st/osst/ on the commit message message up my signoff, this
should be:

Signed-off-by: Christoph Hellwig 


Maybe it's time to kill osst.c for good ...

Cheers,

Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

--
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

[Christoph Hellwig]

On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote:
> On 5/1/19 6:14 PM, Christoph Hellwig wrote:
>> osst.c is the only osst file missing licensing information.  Add a
>> GPLv2 tag for the default kernel license.
>>
>> Signed-off-by: Chriosstoph Hellwig 

FYI, my s/st/osst/ on the commit message message up my signoff, this
should be:

Signed-off-by: Christoph Hellwig 

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

[Hannes Reinecke]

On 5/1/19 6:14 PM, Christoph Hellwig wrote:

osst.c is the only osst file missing licensing information.  Add a
GPLv2 tag for the default kernel license.

Signed-off-by: Chriosstoph Hellwig 
---
  drivers/scsi/osst.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index be3c73ebbfde..fe4f0e7d6359 100644
--- a/drivers/scsi/osst.c
+++ b/drivers/scsi/osst.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
  /*
SCSI Tape Driver for Linux version 1.1 and newer. See the accompanying
file Documentation/scsi/st.txt for more information.


Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

--
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

[PATCH 24/24] osst: add a SPDX tag to osst.c

[Christoph Hellwig]

osst.c is the only osst file missing licensing information.  Add a
GPLv2 tag for the default kernel license.

Signed-off-by: Chriosstoph Hellwig 
---
 drivers/scsi/osst.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index be3c73ebbfde..fe4f0e7d6359 100644
--- a/drivers/scsi/osst.c
+++ b/drivers/scsi/osst.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
   SCSI Tape Driver for Linux version 1.1 and newer. See the accompanying
   file Documentation/scsi/st.txt for more information.
-- 
2.20.1

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.