[PATCH 6/8] BNX2I: Added jumbo MTU support for the no shost case
For scenarios where the shost is not being passed to bnx2i for the
iSCSI offload connection request, the code would consult the routing
table to select the CNIC device.
This code path will erroneously error out if the corresponding L2
interface's MTU has been setup to 1500.
Signed-off-by: Eddie Wai eddie@broadcom.com
---
drivers/scsi/bnx2i/bnx2i.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i.h b/drivers/scsi/bnx2i/bnx2i.h
index cc7ebc1..bd64ba3 100644
--- a/drivers/scsi/bnx2i/bnx2i.h
+++ b/drivers/scsi/bnx2i/bnx2i.h
@@ -360,7 +360,7 @@ struct bnx2i_hba {
#define ADAPTER_STATE_LINK_DOWN 2
#define ADAPTER_STATE_INIT_FAILED 31
unsigned int mtu_supported;
- #define BNX2I_MAX_MTU_SUPPORTED 1500
+ #define BNX2I_MAX_MTU_SUPPORTED 9000
struct Scsi_Host *shost;
--
1.7.0.5
--
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To post to this group, send email to open-is...@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 6/8] BNX2I: Added jumbo MTU support for the no shost case
On 01/05/2011 02:44 PM, Eddie Wai wrote: For scenarios where the shost is not being passed to bnx2i for the iSCSI offload connection request, the code would consult the routing table to select the CNIC device. This code path will erroneously error out if the corresponding L2 interface's MTU has been setup to 1500. When have you guys actually hit this? What tools and what version does this? -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 6/8] BNX2I: Added jumbo MTU support for the no shost case
On Wed, 2011-01-05 at 12:50 -0800, Mike Christie wrote: On 01/05/2011 02:44 PM, Eddie Wai wrote: For scenarios where the shost is not being passed to bnx2i for the iSCSI offload connection request, the code would consult the routing table to select the CNIC device. This code path will erroneously error out if the corresponding L2 interface's MTU has been setup to 1500. When have you guys actually hit this? What tools and what version does this? I believe we had run into this case in the past by not specifying the ifacename parameter in a static node but use transport of bnx2i. I would have to go back and revisit that for verification. But its a scenario our driver has supports for in the past. The jumbo MTU support was added to the shost case a while back. Adding this is more for completeness. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 6/8] BNX2I: Added jumbo MTU support for the no shost case
On 01/05/2011 04:58 PM, Eddie Wai wrote: On Wed, 2011-01-05 at 12:50 -0800, Mike Christie wrote: On 01/05/2011 02:44 PM, Eddie Wai wrote: For scenarios where the shost is not being passed to bnx2i for the iSCSI offload connection request, the code would consult the routing table to select the CNIC device. This code path will erroneously error out if the corresponding L2 interface's MTU has been setup to 1500. When have you guys actually hit this? What tools and what version does this? I believe we had run into this case in the past by not specifying the ifacename parameter in a static node but use transport of bnx2i. I would have to go back and revisit that for verification. But its a scenario our driver has supports for in the past. The jumbo MTU support was added to the shost case a while back. Adding this is more for completeness. Hey, Let me know what version is doing this next time you see it (do not waste time on it now). We used to support it a long time ago, but the current tools do not now. We took it out a long time ago, because the sysfs code and a bunch of other things do not handle if the session were to move hosts (like if we were in recovery and disconnected then reconnected using a different host). Pointers and refcounting goes kablewy. Other drivers fail in ep_connect if a shost is not passed in. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
