Re: [PATCH] BNX2I: Removed the reference to the netdev-base_addr

2012-07-03 Thread Eddie Wai
Thanks, Mike.

Hello James,

This patch is actually a critical bug fix as the 1G bnx2 driver no
longer supports the netdev-base_addr in the current kernel of the scsi
tree.  This means that Broadcom's 1G Linux iSCSI offload solution would
not work at all without this patch.  If at all possible, please consider
including this patch into the fixes branch.

Thanks,
Eddie

On Fri, 2012-06-29 at 21:41 -0500, Mike Christie wrote:
 On 06/29/2012 06:37 PM, Eddie Wai wrote:
  The netdev-base_addr parameter has been deprecated in the L2 bnx2
  driver.  This is used by bnx2i for the BARn iomapping.
 
  This patch will directly reference the pci_resource_start instead
  of using the deprecated netdev-base_addr.
 
  Signed-off-by: Eddie Wai eddie@broadcom.com
 
 
 Looks ok to me
 
 Reviewed-by: Mike Christie micha...@cs.wisc.edu
 


-- 
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.



Re: [PATCH] BNX2I: Removed the reference to the netdev-base_addr

2012-06-29 Thread Mike Christie

On 06/29/2012 06:37 PM, Eddie Wai wrote:

The netdev-base_addr parameter has been deprecated in the L2 bnx2
driver.  This is used by bnx2i for the BARn iomapping.

This patch will directly reference the pci_resource_start instead
of using the deprecated netdev-base_addr.

Signed-off-by: Eddie Wai eddie@broadcom.com



Looks ok to me

Reviewed-by: Mike Christie micha...@cs.wisc.edu

--
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.