date:20130424

[OE-core] debugedit: canonicalization unexpectedly shrank by one character

2013-04-24 Thread Martin Jansa

Hi,

with debugedit errors now catched and shown after:
commit 262a69ffd33e9d001a7a15fc73671a015e3b5dd1
Author: Richard Purdie richard.pur...@linuxfoundation.org
Date:   Mon Mar 25 16:52:07 2013 +

package.bbclass: Handle subprocess errors correctly

If an error occurs in subprocess.call() we currently don't catch it. In 
particular
we have issues where debugedit is segfaulting unnoticed. This fixes up
various code paths to catch the errors.

I get couple of recipes failing with errors like:

NOTE: Running task 4179 of 4962 (ID: 2136, 
/OE/webos/owpb/openwebos-ports/meta-smartphone/meta-android/recipes-multimedia/android-audiosystem/android-audiosystem_bzr.bb,
 do_package)
NOTE: recipe android-audiosystem-1.8+bzr43-r0: task do_package: Started
ERROR: debugedit failed with exit code 1 (cmd was 
'/OE/webos/owpb/openwebos-ports/tmp-eglibc/sysroots/x86_64-linux/usr/lib/rpm/bin/debugedit'
 -b 
'/OE/webos/owpb/openwebos-ports/tmp-eglibc/work/armv7a-vfp-neon-webos-linux-gnueabi'
 -d '/usr/src/debug' -i -l 
'/OE/webos/owpb/openwebos-ports/tmp-eglibc/work/armv7a-vfp-neon-webos-linux-gnueabi/android-audiosystem/1.8+bzr43-r0/debugsources.list'
 
'/OE/webos/owpb/openwebos-ports/tmp-eglibc/work/armv7a-vfp-neon-webos-linux-gnueabi/android-audiosystem/1.8+bzr43-r0/package/usr/lib/libwaudio.so.1.0')
ERROR: Function failed: split_and_strip_files
ERROR: Logfile of failure stored in: 
/OE/webos/owpb/openwebos-ports/tmp-eglibc/work/armv7a-vfp-neon-webos-linux-gnueabi/android-audiosystem/1.8+bzr43-r0/temp/log.do_package.3450
NOTE: recipe android-audiosystem-1.8+bzr43-r0: task do_package: Failed
ERROR: Task 2136 
(/OE/webos/owpb/openwebos-ports/meta-smartphone/meta-android/recipes-multimedia/android-audiosystem/android-audiosystem_bzr.bb,
 do_package) failed with exit code '1'

Unfortunately this error does not show stdout/stderr from debugedit, but 
running it manually:
'/OE/webos/owpb/openwebos-ports/tmp-eglibc/sysroots/x86_64-linux/usr/lib/rpm/bin/debugedit'
 -b 
'/OE/webos/owpb/openwebos-ports/tmp-eglibc/work/armv7a-vfp-neon-webos-linux-gnueabi'
 -d '/usr/src/debug' -i -l 
'/OE/webos/owpb/openwebos-ports/tmp-eglibc/work/armv7a-vfp-neon-webos-linux-gnueabi/android-audiosystem/1.8+bzr43-r0/debugsources.list'
 
'/OE/webos/owpb/openwebos-ports/tmp-eglibc/work/armv7a-vfp-neon-webos-linux-gnueabi/android-audiosystem/1.8+bzr43-r0/package/usr/lib/libwaudio.so.1.0'
/OE/webos/owpb/openwebos-ports/tmp-eglibc/sysroots/x86_64-linux/usr/lib/rpm/bin/debugedit:
 canonicalization unexpectedly shrank by one character

This leads to 
https://bugzilla.redhat.com/show_bug.cgi?id=304121
https://bugs.launchpad.net/rpm/+bug/638633
https://qa.mandriva.com/show_bug.cgi?id=62391

but no clear solution (it would be nice to show which path triggered that 
message 
as suggested in redhat bugzilla)

I can INHIBIT_PACKAGE_DEBUG_SPLIT in failing recipes or adding slash 
to -d '/usr/src/debug/' works in this case too..

Other ideas?

-- 
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com


signature.asc
Description: Digital signature
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] eglibc: Add gettext-native to DEPENDS

2013-04-24 Thread Phil Blundell

On Tue, 2013-04-23 at 22:45 +0100, Richard Purdie wrote:
 On Tue, 2013-04-23 at 17:44 +0100, Phil Blundell wrote:
   # nptl needs unwind support in gcc, which can't be built without glibc.
  -DEPENDS = virtual/${TARGET_PREFIX}gcc-initial linux-libc-headers 
  virtual/${TARGET_PREFIX}libc-initial
  +DEPENDS = virtual/${TARGET_PREFIX}gcc-initial linux-libc-headers 
  virtual/${TARGET_PREFIX}libc-initial gettext-native
   # nptl needs libgcc but dlopens it, so our shlibs code doesn't detect this
   #RDEPENDS_${PN} += ${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}
   PROVIDES = virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc
 
 This will have a significant adverse affect on build speed due to build
 dependency bottlenecks :(
 
 Are there any good options for avoiding this?

Well, obviously folks who do have it in the host environment can set
ASSUME_PROVIDED.  I assume most people do have that installed, otherwise
this would be failing all the time.

Other than that, I think your options are:

1. figure out a way to defer catalog building to later, e.g. put it in
eglibc-locale instead.  This would probably involve some hacking of the
eglibc makefiles but I don't think it would be especially hard.

2. find a way to disable catalog generation entirely for folks who don't
want it.  That might involve inventing DISTRO_FEATURES=l10n or
something and patching (albeit trivial) to both configure.in and the
makefiles.  I imagine that change would be upstreamable in eglibc.

3. reimplement msgcat as a python script or something else that doesn't
need compiling, or pull out msgcat.c into its own recipe that just
builds this single file (avoiding the autotools overhead that
gettext-native has).

I can't think of any other obvious choices offhand but I'm sure there
are more.

The thing that does seem a bit puzzling is that this problem didn't use
to happen with older versions of oe-core (in particular, I never saw it
with my previous snapshot which used eglibc 2.16).  I'm not quite sure
what changed to make it suddenly become an issue.

p.



___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [oe] OpenEmbedded TSC 8 April 2013

2013-04-24 Thread Richard Purdie

On Wed, 2013-04-24 at 08:43 +0200, Martin Jansa wrote:
On Tue, Apr 23, 2013 at 02:47:56PM -0700, Jeff Osier-Mixon wrote:
OpenEmbedded Technical Steering Committee
8 April 2013

b. document whitespace changes to the shell
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
http://www.openembedded.org/wiki/Styleguide
https://wiki.yoctoproject.org/wiki/Recipe_%26_Patch_Style_Guide
= still need to de-dup these, need a volunteer
ask for volunteers after 1.4 (jefro)

Someone probably noticed, but all meta-openembedded layers are now using
consistent indentation:
http://git.openembedded.org/meta-openembedded/commit/?id=a45830a39bb47a9eab27980d52966226c9504ea4

Can we reevaluate decision to keep styleguide promoting different
indentation for python and shell tasks? Otherwise we should mention
different rules for oe-core and other layers.

The TSC talked about it and agreed a particular direction. Its clear
that some people don't like the direction so they just ignored it and do
their own thing anyway.

This is the wrong way to go about making decisions and I'm extremely
disappointed people are doing this.

There were specific technical reasons I suggested we not do this. One of
the asks of the Yocto members is some kind of stability, whatever that
is. Whitespace changes like this are *extremely* disruptive to patch
flow. I think its clear there are people out there using older versions
of the codebase yet they pick patches off master and backport them for a
variety of reasons. As soon as you get changes like this involved, it
breaks their ability to do that. With the python change, there was a
good technical reason we did it. Despite that I was personally literally
backed into a corner and shouted at by some rather upset people last
time this happened with the python change. I can see their point too.
For changing shell, we don't have any good technical reason other than
cosmetics. I've made this argument before.

You know what, thanks for the support guys :(

At this point I assume I'm free to ignore the TSC since we now have
precedent for it?

Richard

___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] [oe] OpenEmbedded TSC 8 April 2013

2013-04-24 Thread Martin Jansa

On Wed, Apr 24, 2013 at 09:01:06AM +0100, Richard Purdie wrote:
On Wed, 2013-04-24 at 08:43 +0200, Martin Jansa wrote:
On Tue, Apr 23, 2013 at 02:47:56PM -0700, Jeff Osier-Mixon wrote:
OpenEmbedded Technical Steering Committee
8 April 2013

Someone probably noticed, but all meta-openembedded layers are now using
consistent indentation:
http://git.openembedded.org/meta-openembedded/commit/?id=a45830a39bb47a9eab27980d52966226c9504ea4

Can we reevaluate decision to keep styleguide promoting different
indentation for python and shell tasks? Otherwise we should mention
different rules for oe-core and other layers.

The TSC talked about it and agreed a particular direction. Its clear
that some people don't like the direction so they just ignored it and do
their own thing anyway.

This is the wrong way to go about making decisions and I'm extremely
disappointed people are doing this.

Hi,

I'm sorry you feel that way about it, I'll try to make it a bit better:

1) it was discussed and acked by major meta-openembedded contributors
and maintainers:
http://lists.linuxtogo.org/pipermail/openembedded-devel/2013-April/044989.html

2) it was done just before we'll branch dylan, so that backporting issue
is only for people backporting over 2 releases (from after-dylan-master
to danny). And even if someone gets whitespace wrong in backport, then
there is no real harm, because as you say, it's only cosmetic now and
meta-openembedded layers were very inconsistent about it (tabs were used
only in minority of recipes).

Cheers,

--
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com

signature.asc
Description: Digital signature
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

[OE-core] [PATCH v2] rpm: change arch scoring items

2013-04-24 Thread Bogdan Marinescu

Don't add the first line of /etc/rpm/platform to the list of patterns
to match when computing an arch score, use it just for getting
information about the platform (cpu/vendor/os).

[YOCTO #3864]

Signed-off-by: Bogdan Marinescu bogdan.a.marine...@intel.com
---
 .../rpm/rpm/rpm-platform-file-fix.patch|   28 
 meta/recipes-devtools/rpm/rpm_5.4.9.bb |3 ++-
 2 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/rpm/rpm/rpm-platform-file-fix.patch

diff --git a/meta/recipes-devtools/rpm/rpm/rpm-platform-file-fix.patch 
b/meta/recipes-devtools/rpm/rpm/rpm-platform-file-fix.patch
new file mode 100644
index 000..0f391d2
--- /dev/null
+++ b/meta/recipes-devtools/rpm/rpm/rpm-platform-file-fix.patch
@@ -0,0 +1,28 @@
+Don't add the first line of /etc/rpm/platform to the list of patterns
+to match when computing an arch score, use it just for getting
+information about the platform (cpu/vendor/os). Fixes #3864.
+
+Upstream-Status: Inappropriate [embedded specific]
+
+diff --git a/lib/rpmrc.c b/lib/rpmrc.c
+index e676601..9140bbe 100644
+--- a/lib/rpmrc.c
 b/lib/rpmrc.c
+@@ -510,6 +510,7 @@ static rpmRC rpmPlatform(const char * platform)
+ #endif
+   }
+ 
++#if !defined(RPM_VENDOR_POKY) /* Skip the explicit-platform */
+ #if defined(RPM_VENDOR_OPENPKG) /* explicit-platform */
+   /* do not use vendor and GNU attribution */
+   p = rpmExpand(%{_host_cpu}-%{_host_os}, NULL);
+@@ -520,7 +521,8 @@ static rpmRC rpmPlatform(const char * platform)
+ #endif
+   xx = mireAppend(RPMMIRE_STRCMP, 0, p, NULL, mi_re, mi_nre);
+   p = _free(p);
+-  
++#endif
++
+   init_platform++;
+ }
+ rc = (init_platform ? RPMRC_OK : RPMRC_FAIL);
diff --git a/meta/recipes-devtools/rpm/rpm_5.4.9.bb 
b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
index 7d2cba4..112d11d 100644
--- a/meta/recipes-devtools/rpm/rpm_5.4.9.bb
+++ b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
@@ -43,7 +43,7 @@ LICENSE = LGPLv2.1
 LIC_FILES_CHKSUM = file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1
 
 DEPENDS = libpcre attr acl popt ossp-uuid file bison-native
-PR = r62
+PR = r63
 
 # rpm2cpio is a shell script, which is part of the rpm src.rpm.  It is needed
 # in order to extract the distribution SRPM into a format we can extract...
@@ -86,6 +86,7 @@ SRC_URI = 
http://www.rpm5.org/files/rpm/rpm-5.4/rpm-5.4.9-0.20120508.src.rpm;ex
   file://rpm-platform2.patch \
   file://rpm-remove-sykcparse-decl.patch \
   file://debugedit-segv.patch \
+ file://rpm-platform-file-fix.patch \
  
 
 # Uncomment the following line to enable platform score debugging
-- 
1.7.10.4


___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

[OE-core] Reexecuting do_fetch after do_unpack failed with reference is not a tree

2013-04-24 Thread Martin Jansa

Hi,

I guess this will be hard to fix correctly, but please comment if I've
overlooked something:

1) update foo git repository with new commit ABCD, but forget to push it
2) bump SRCREV in foo.bb to ABCD
3) run bitbake foo, it will run do_fetch to catch new changes in remote
   repo, but ABCD is not there, so do_unpack will fail like this:

   NOTE: Running task 2289 of 4227 (ID: 1185, foo.bb, do_unpack)
   NOTE: recipe foo-1.0+gitr2+ABCD: task do_unpack: Started
   ERROR: Function failed: Fetcher failure: Fetch command failed with exit code 
128, output:
   fatal: reference is not a tree: ABCD

4) realize missing git push in step 1) and push it now
5) run bitbake foo again, but do_unpack is still failing, because
   do_fetch checksums is the same (nothing changed in metadata) so stamp
   is still valid.

6) fix it with bitbake -c fetch -f foo, but that could be complicated
   if bump SRCREV was pushed already and possibly many builders already
   executed do_fetch, so maybe push PR bump or something like that.

Only better solution than 6) I can think of, is to detect 
fatal: reference is not a tree in do_unpack and if it's git repository
then remove do_fetch stamp and hope it was fixed in remote git repo.

-- 
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com


signature.asc
Description: Digital signature
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [OE-core] Reexecuting do_fetch after do_unpack failed with reference is not a tree

2013-04-24 Thread Richard Purdie

On Wed, 2013-04-24 at 10:46 +0200, Martin Jansa wrote:
 Hi,
 
 I guess this will be hard to fix correctly, but please comment if I've
 overlooked something:
 
 1) update foo git repository with new commit ABCD, but forget to push it
 2) bump SRCREV in foo.bb to ABCD
 3) run bitbake foo, it will run do_fetch to catch new changes in remote
repo, but ABCD is not there, so do_unpack will fail like this:
 
NOTE: Running task 2289 of 4227 (ID: 1185, foo.bb, do_unpack)
NOTE: recipe foo-1.0+gitr2+ABCD: task do_unpack: Started
ERROR: Function failed: Fetcher failure: Fetch command failed with exit 
 code 128, output:
fatal: reference is not a tree: ABCD
 
 4) realize missing git push in step 1) and push it now
 5) run bitbake foo again, but do_unpack is still failing, because
do_fetch checksums is the same (nothing changed in metadata) so stamp
is still valid.
 
 6) fix it with bitbake -c fetch -f foo, but that could be complicated
if bump SRCREV was pushed already and possibly many builders already
executed do_fetch, so maybe push PR bump or something like that.
 
 Only better solution than 6) I can think of, is to detect 
 fatal: reference is not a tree in do_unpack and if it's git repository
 then remove do_fetch stamp and hope it was fixed in remote git repo.

I'd say do_fetch should detect that the specified revision isn't present
and fail there and then in do_fetch.

Cheers,

Richard


___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

79 matches

Mail list logo