Re: [OE-core] [PATCH] kexec: ARM: fix align issue of add_buffer_phys_virt() for LPAE kernel.

[Bai, Haiqing]

Hi, Ross:

  I clone the branch (poky-contrib:ross/mut) and did’t find the fix in 
2.0.14,  so this fix is still required.  Thanks

B,R
Haiqing Bai
From: Burton, Ross [mailto:ross.bur...@intel.com]
Sent: 2017年1月4日 22:32
To: Bai, Haiqing
Cc: OE-core
Subject: Re: [OE-core] [PATCH] kexec: ARM: fix align issue of 
add_buffer_phys_virt() for LPAE kernel.

An upgrade to 2.0.14 was recently posted on the list (and is now in 
poky-contrib:ross/mut), can you verify that this patch is still required with 
that release and rebase?

Ross

On 3 January 2017 at 09:05, Haiqing Bai 
> wrote:
If LPAE is enabled, 3 level page table is used and the 'SECTION_SIZE'
is (1<<21), so add_buffer_phys_virt() should align to (1 << 21).

Signed-off-by: Haiqing Bai 
>
---
 ...-ARM-fix-add_buffer_phys_virt-align-issue.patch | 52 ++
 meta/recipes-kernel/kexec/kexec-tools_2.0.12.bb  
  |  1 +
 2 files changed, 53 insertions(+)
 create mode 100644 
meta/recipes-kernel/kexec/kexec-tools/kexec-ARM-fix-add_buffer_phys_virt-align-issue.patch

diff --git 
a/meta/recipes-kernel/kexec/kexec-tools/kexec-ARM-fix-add_buffer_phys_virt-align-issue.patch
 
b/meta/recipes-kernel/kexec/kexec-tools/kexec-ARM-fix-add_buffer_phys_virt-align-issue.patch
new file mode 100644
index 000..7d1f95e
--- /dev/null
+++ 
b/meta/recipes-kernel/kexec/kexec-tools/kexec-ARM-fix-add_buffer_phys_virt-align-issue.patch
@@ -0,0 +1,52 @@
+From 380019f68e19ac863cf32dc7ff6784e8fe1d751f Mon Sep 17 00:00:00 2001
+From: Haiqing Bai >
+Date: Mon, 19 Dec 2016 14:52:02 +0800
+Subject: [PATCH] kexec: ARM: Fix add_buffer_phys_virt() align issue.
+
+When "CONFIG_ARM_LPAE" is enabled,3 level page table
+is used by MMU, the "SECTION_SIZE" is defined with
+(1 << 21), but 'add_buffer_phys_virt()' hardcode this
+to (1 << 20).
+
+Upstream-Status: Pending
+
+Suggested-By:fredrik.markst...@gmail.com
+Signed-off-by: Haiqing Bai 
>
+---
+ kexec/arch/arm/crashdump-arm.c | 5 -
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/kexec/arch/arm/crashdump-arm.c b/kexec/arch/arm/crashdump-arm.c
+index 38a1401..e41b7fb 100644
+--- a/kexec/arch/arm/crashdump-arm.c
 b/kexec/arch/arm/crashdump-arm.c
+@@ -271,6 +271,7 @@ int load_crashdump_segments(struct kexec_info *info, char 
*mod_cmdline)
+   void *buf;
+   int err;
+   int last_ranges;
++  unsigned short align_bit_shift = 20;
+
+   /*
+* First fetch all the memory (RAM) ranges that we are going to pass to
+@@ -295,6 +296,7 @@ int load_crashdump_segments(struct kexec_info *info, char 
*mod_cmdline)
+
+   /* for support LPAE enabled kernel*/
+   elf_info.class = ELFCLASS64;
++  align_bit_shift = 21;
+
+   err = crash_create_elf64_headers(info, _info,
+usablemem_rgns.ranges,
+@@ -315,8 +317,9 @@ int load_crashdump_segments(struct kexec_info *info, char 
*mod_cmdline)
+* 1MB) so that available memory passed in kernel command line will be
+* aligned to 1MB. This is because kernel create_mapping() wants memory
+* regions to be aligned to SECTION_SIZE.
++ * The SECTION_SIZE of LPAE kernel is '1UL << 21' defined in 
pgtable-3level.h
+*/
+-  elfcorehdr = add_buffer_phys_virt(info, buf, bufsz, bufsz, 1 << 20,
++  elfcorehdr = add_buffer_phys_virt(info, buf, bufsz, bufsz, 1 << 
align_bit_shift,
+ crash_reserved_mem.start,
+ crash_reserved_mem.end, -1, 0);
+
+--
+1.9.1
+
diff --git 
a/meta/recipes-kernel/kexec/kexec-tools_2.0.12.bb 
b/meta/recipes-kernel/kexec/kexec-tools_2.0.12.bb
index 59376c8..3e38923 100644
--- 
a/meta/recipes-kernel/kexec/kexec-tools_2.0.12.bb
+++ 
b/meta/recipes-kernel/kexec/kexec-tools_2.0.12.bb
@@ -8,6 +8,7 @@ SRC_URI += " \
 
file://0002-powerpc-change-the-memory-size-limit.patch
 \
 
file://0001-purgatory-Pass-r-directly-to-linker.patch
 \
 
file://0001-vmcore-dmesg-Define-_GNU_SOURCE.patch
 \
+
file://kexec-ARM-fix-add_buffer_phys_virt-align-issue.patch
 \
  "

 SRC_URI[md5sum] = "10ddaae0e86af54407b164a1f5a39cc3"
--
1.9.1

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
___
Openembedded-core mailing list

Re: [OE-core] [PATCH 1/1] busybox: upgrade to 1.26.1

[ChenQi]

On 01/05/2017 06:21 PM, Burton, Ross wrote:


On 4 January 2017 at 03:22, Chen Qi > wrote:


Upgrade busybox to 1.26.1. Also upgrade the git version to the
corresponding
commit.


Did you examine the changes that this introduces?

The packages grow a fairly large amount, and a number of new symlinks 
are introduced. Interestingly /bin/sh is now provided by both 
busybox.nosuid and busybox.suid.


Ross



Hi Ross,

When I made this patch, my criteria are:

1) image with systemd as init manager and busybox installed works well

2) image with sysvinit as init manager and busybox installed works well

3) image with busybox as init manager works well

I didn't check the package size of busybox, nor did I check the symlinks.

I'll compare the old version of busybox and the new version ASAP to find 
out whether there would be potential problems in our system.


Best Regards,

Chen Qi

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 2/2] image_types.bbclass: IMAGE_TYPEDEP_ now adds deps for conversion types

[Randy Witt]

Previously if IMAGE_TYPEDEP_* contained a conversion type of the form,
"foo.bar", the dependency on CONVERSION_DEPENDS_bar would not get added
to the task depends for do_rootfs.

[YOCTO #10883]

Signed-off-by: Randy Witt 
---
 meta/classes/image_types.bbclass | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index 8f04849..c2ad141 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -17,17 +17,25 @@ def imagetypes_getdepends(d):
 d += ":do_populate_sysroot"
 deps.add(d)
 
+# Take a type in the form of foo.bar.car and split it into the items
+# needed for the image deps "foo", and the conversion deps ["bar", "car"]
+def split_types(typestring):
+types = typestring.split(".")
+return types[0], types[1:]
+
 fstypes = set((d.getVar('IMAGE_FSTYPES') or "").split())
 fstypes |= set((d.getVar('IMAGE_FSTYPES_DEBUGFS') or "").split())
 
 deps = set()
 for typestring in fstypes:
-types = typestring.split(".")
-basetype, resttypes = types[0], types[1:]
-
+basetype, resttypes = split_types(typestring)
 adddep(d.getVar('IMAGE_DEPENDS_%s' % basetype) , deps)
+
 for typedepends in (d.getVar("IMAGE_TYPEDEP_%s" % basetype) or 
"").split():
+base, rest = split_types(typedepends)
+resttypes += rest
 adddep(d.getVar('IMAGE_DEPENDS_%s' % typedepends) , deps)
+
 for ctype in resttypes:
 adddep(d.getVar("CONVERSION_DEPENDS_%s" % ctype), deps)
 adddep(d.getVar("COMPRESS_DEPENDS_%s" % ctype), deps)
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 1/2] image_typedep.py: Add a test that ensures conversion type deps get added

[Randy Witt]

Add a test that ensures if IMAGE_TYPEDEP_* contains a conversion type,
that the corresponding CONVERSION_DEPENDS_ for that type gets added to
the dependency tree for do_rootfs.

Signed-off-by: Randy Witt 
---
 meta/lib/oeqa/selftest/image_typedep.py | 51 +
 1 file changed, 51 insertions(+)
 create mode 100644 meta/lib/oeqa/selftest/image_typedep.py

diff --git a/meta/lib/oeqa/selftest/image_typedep.py 
b/meta/lib/oeqa/selftest/image_typedep.py
new file mode 100644
index 000..256142d25
--- /dev/null
+++ b/meta/lib/oeqa/selftest/image_typedep.py
@@ -0,0 +1,51 @@
+import os
+
+from oeqa.selftest.base import oeSelfTest
+from oeqa.utils.commands import bitbake
+
+class ImageTypeDepTests(oeSelfTest):
+
+# Verify that when specifying a IMAGE_TYPEDEP_ of the form "foo.bar" that
+# the conversion type bar gets added as a dep as well
+def test_conversion_typedep_added(self):
+
+self.write_recipeinc('emptytest', """
+# Try to empty out the default dependency list
+PACKAGE_INSTALL = ""
+DISTRO_EXTRA_RDEPENDS=""
+
+LICENSE = "MIT"
+IMAGE_FSTYPES = "testfstype"
+
+IMAGE_TYPES_MASKED += "testfstype"
+IMAGE_TYPEDEP_testfstype = "tar.bz2"
+
+inherit image
+
+""")
+# First get the dependency that should exist for bz2, it will look
+# like CONVERSION_DEPENDS_bz2="somedep"
+result = bitbake('-e emptytest')
+
+for line in result.output.split('\n'):
+if line.startswith('CONVERSION_DEPENDS_bz2'):
+dep = line.split('=')[1].strip('"')
+break
+
+# Now get the dependency task list and check for the expected task
+# dependency
+bitbake('-g emptytest')
+
+taskdependsfile = os.path.join(self.builddir, 'task-depends.dot')
+dep =  dep + ".do_populate_sysroot"
+depfound = False
+expectedline = '"emptytest.do_rootfs" -> "{}"'.format(dep)
+
+with open(taskdependsfile, "r") as f:
+for line in f:
+if line.strip() == expectedline:
+depfound = True
+break
+
+if not depfound:
+raise AssertionError("\"{}\" not found".format(expectedline))
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 0/2] Fix depends for conversion types in IMAGE_TYPEDEP_*

[Randy Witt]

Fix conversion type dependencies missing when set in IMAGE_TYPEDEP_*. This
also adds a test.

The following changes since commit 9f6a1043f68580ed9604e750fd0f993f933bb66e:

  bitbake: prserv/serv: Tweak stdout manipulation to be stream safe (2017-01-05 
13:54:07 +)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib rewitt/image_typedep
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rewitt/image_typedep

Randy Witt (2):
  image_typedep.py: Add a test that ensures conversion type deps get
added
  image_types.bbclass: IMAGE_TYPEDEP_ now adds deps for conversion types

 meta/classes/image_types.bbclass| 14 +++--
 meta/lib/oeqa/selftest/image_typedep.py | 51 +
 2 files changed, 62 insertions(+), 3 deletions(-)
 create mode 100644 meta/lib/oeqa/selftest/image_typedep.py

-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 09/16] boost: drop flags bits, fix for x32

[Christopher Larson]

On Thu, Jan 5, 2017 at 1:29 PM, Burton, Ross  wrote:

> On 5 January 2017 at 19:46, Christopher Larson  wrote:
>
>> +Upstream-Status: Pending
>>
>
> I think Inappropriate is more fitting here, but you're brave for daring to
> look into bjam. :)
>

That’s a good point, I’ll fix it on the branch. Thanks!
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 09/16] boost: drop flags bits, fix for x32

[Burton, Ross]

On 5 January 2017 at 19:46, Christopher Larson  wrote:

> +Upstream-Status: Pending
>

I think Inappropriate is more fitting here, but you're brave for daring to
look into bjam. :)

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] linux-dtb: strip DTB extension properly in postinst/postrm

[Denys Dmytriyenko]

Ping.

On Wed, Dec 21, 2016 at 03:20:17PM -0500, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko 
> 
> The use of awk -F "." in do_install/do_deploy to strip filename extension
> was deprecated long time ago in 72980d5bb465f0640ed451d1ebb9c5d2a210ad0c.
> 
> Make a similar change in postinst/postrm to properly use basename command.
> 
> Otherwise DTB files that contain dots in the name result in broken symlinks
> that point to non-existent truncated files.
> 
> Signed-off-by: Denys Dmytriyenko 
> ---
>  meta/recipes-kernel/linux/linux-dtb.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc 
> b/meta/recipes-kernel/linux/linux-dtb.inc
> index 8528d64..2f378a1 100644
> --- a/meta/recipes-kernel/linux/linux-dtb.inc
> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> @@ -68,7 +68,7 @@ pkg_postinst_kernel-devicetree () {
>   for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
>   symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
>   DTB_EXT=${DTB##*.}
> - DTB_BASE_NAME=`basename ${DTB} | awk -F "." '{print 
> $1}'`
> + DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`
>   DTB_SYMLINK_NAME=`echo ${symlink_name} | sed 
> "s/${MACHINE}/${DTB_BASE_NAME}/g"`
>   update-alternatives --install 
> /${KERNEL_IMAGEDEST}/${DTB_BASE_NAME}.${DTB_EXT} ${DTB_BASE_NAME}.${DTB_EXT} 
> /boot/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT} ${KERNEL_PRIORITY} || true
>   done
> @@ -81,7 +81,7 @@ pkg_postrm_kernel-devicetree () {
>   for type in ${KERNEL_IMAGETYPE_FOR_MAKE}; do
>   symlink_name=${type}"-"${KERNEL_IMAGE_SYMLINK_NAME}
>   DTB_EXT=${DTB##*.}
> - DTB_BASE_NAME=`basename ${DTB} | awk -F "." '{print 
> $1}'`
> + DTB_BASE_NAME=`basename ${DTB} ."${DTB_EXT}"`
>   DTB_SYMLINK_NAME=`echo ${symlink_name} | sed 
> "s/${MACHINE}/${DTB_BASE_NAME}/g"`
>   update-alternatives --remove 
> ${DTB_BASE_NAME}.${DTB_EXT} /boot/devicetree-${DTB_SYMLINK_NAME}.${DTB_EXT} 
> ${KERNEL_PRIORITY} || true
>   done
> -- 
> 2.7.4
> 
> -- 
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 14/16] libunwind: apply a patch to fix x32

[Christopher Larson]

From: Christopher Larson 

Apply patch to fix the X32 build from https://github.com/sjnewbury/x32

Signed-off-by: Christopher Larson 
---
 .../libunwind/libunwind/libunwind-1.1-x32.patch| 31 ++
 meta/recipes-support/libunwind/libunwind_git.bb|  1 +
 2 files changed, 32 insertions(+)
 create mode 100644 
meta/recipes-support/libunwind/libunwind/libunwind-1.1-x32.patch

diff --git a/meta/recipes-support/libunwind/libunwind/libunwind-1.1-x32.patch 
b/meta/recipes-support/libunwind/libunwind/libunwind-1.1-x32.patch
new file mode 100644
index 000..3251646
--- /dev/null
+++ b/meta/recipes-support/libunwind/libunwind/libunwind-1.1-x32.patch
@@ -0,0 +1,31 @@
+From 506bd37bd580d7382d7c58257dac4b1e502a887c Mon Sep 17 00:00:00 2001
+From: Christopher Larson 
+Date: Tue, 13 Dec 2016 09:50:34 -0700
+Subject: [PATCH] Fix for X32
+
+Apply patch to fix the X32 build from https://github.com/sjnewbury/x32.
+
+Upstream-Status: Pending
+Signed-off-by: Christopher Larson 
+---
+ src/x86_64/Gos-linux.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/x86_64/Gos-linux.c b/src/x86_64/Gos-linux.c
+index 9e1acfc..8169d5a 100644
+--- a/src/x86_64/Gos-linux.c
 b/src/x86_64/Gos-linux.c
+@@ -143,8 +143,8 @@ x86_64_sigreturn (unw_cursor_t *cursor)
+ 
+   Debug (8, "resuming at ip=%llx via sigreturn(%p)\n",
+  (unsigned long long) c->dwarf.ip, sc);
+-  __asm__ __volatile__ ("mov %0, %%rsp;"
+-"mov %1, %%rax;"
++  __asm__ __volatile__ ("mov %q0, %%rsp;"
++"mov %q1, %%rax;"
+ "syscall"
+ :: "r"(sc), "i"(SYS_rt_sigreturn)
+ : "memory");
+-- 
+2.8.0
+
diff --git a/meta/recipes-support/libunwind/libunwind_git.bb 
b/meta/recipes-support/libunwind/libunwind_git.bb
index 4249430..b637c5c 100644
--- a/meta/recipes-support/libunwind/libunwind_git.bb
+++ b/meta/recipes-support/libunwind/libunwind_git.bb
@@ -11,6 +11,7 @@ SRC_URI = "git://git.sv.gnu.org/libunwind.git \
file://0001-Fix-build-on-mips-musl.patch \
file://0001-add-knobs-to-disable-enable-tests.patch \

file://0001-ppc32-Consider-ucontext-mismatches-between-glibc-and.patch \
+   file://libunwind-1.1-x32.patch \
"
 
 SRC_URI_append_libc-musl = " file://musl-header-conflict.patch"
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 12/16] x264: for x32, disable asm and pass -mx32

[Christopher Larson]

From: Christopher Larson 

We should probably patch it to stop adding the -m argument to CFLAGS/LDFLAGS
in the first place, since we pass it in via CC, but this will do for now.

Signed-off-by: Christopher Larson 
---
 .../x264/x264/Fix-X32-build-by-disabling-asm.patch | 53 ++
 meta/recipes-multimedia/x264/x264_git.bb   |  1 +
 2 files changed, 54 insertions(+)
 create mode 100644 
meta/recipes-multimedia/x264/x264/Fix-X32-build-by-disabling-asm.patch

diff --git 
a/meta/recipes-multimedia/x264/x264/Fix-X32-build-by-disabling-asm.patch 
b/meta/recipes-multimedia/x264/x264/Fix-X32-build-by-disabling-asm.patch
new file mode 100644
index 000..087a448
--- /dev/null
+++ b/meta/recipes-multimedia/x264/x264/Fix-X32-build-by-disabling-asm.patch
@@ -0,0 +1,53 @@
+From 66b120079fb21ed38cab0900c63360b0a7853eaa Mon Sep 17 00:00:00 2001
+From: Christopher Larson 
+Date: Tue, 13 Dec 2016 14:22:32 -0700
+Subject: [PATCH] Fix X32 build by disabling asm
+
+This applies gentoo's x32 patch, adjusted slightly, which disables asm support
+for x32 as well as correcting -m.
+
+Debian has a different patch which does the same, and there's a superior yet
+out of date patch series on the x264 list which keeps asm support enabled, but
+doesn't successfully build at this time, and my assembly is very rusty.
+
+Upstream-Status: Pending
+Signed-off-by: Christopher Larson 
+---
+ configure | 14 --
+ 1 file changed, 12 insertions(+), 2 deletions(-)
+
+diff --git a/configure b/configure
+index 3109ec4..844aeae 100755
+--- a/configure
 b/configure
+@@ -703,7 +703,13 @@ case $host_cpu in
+ AS_EXT=".asm"
+ ASFLAGS="$ASFLAGS -DARCH_X86_64=1 -I\$(SRCPATH)/common/x86/"
+ stack_alignment=16
+-[ $compiler = GNU ] && CFLAGS="-m64 $CFLAGS" && LDFLAGS="-m64 
$LDFLAGS"
++if [ $compiler = GNU ]; then
++if cpp_check "" "" "__ILP32__" ; then
++CFLAGS="-mx32 $CFLAGS" && LDFLAGS="-mx32 $LDFLAGS"
++else
++CFLAGS="-m64 $CFLAGS" && LDFLAGS="-m64 $LDFLAGS"
++fi
++fi
+ if [ "$SYS" = MACOSX ]; then
+ ASFLAGS="$ASFLAGS -f macho64 -DPIC -DPREFIX"
+ if cc_check '' "-arch x86_64"; then
+@@ -722,7 +728,11 @@ case $host_cpu in
+ RCFLAGS="--target=pe-x86-64 $RCFLAGS"
+ fi
+ else
+-ASFLAGS="$ASFLAGS -f elf64"
++if cpp_check "" "" "__ILP32__" ; then
++asm=no
++else
++ASFLAGS="$ASFLAGS -f elf64"
++fi
+ fi
+ ;;
+ powerpc*)
+-- 
+2.8.0
+
diff --git a/meta/recipes-multimedia/x264/x264_git.bb 
b/meta/recipes-multimedia/x264/x264_git.bb
index 1dafdd5..64193dc 100644
--- a/meta/recipes-multimedia/x264/x264_git.bb
+++ b/meta/recipes-multimedia/x264/x264_git.bb
@@ -10,6 +10,7 @@ DEPENDS = "yasm-native"
 
 SRC_URI = "git://github.com/mirror/x264;branch=stable \
file://don-t-default-to-cortex-a9-with-neon.patch \
+   file://Fix-X32-build-by-disabling-asm.patch \
"
 
 SRCREV = "86b71982e131eaa70125f8d0e725fcade9c4c677"
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 15/16] gnome-desktop3: fix for x32

[Christopher Larson]

From: Christopher Larson 

Explicitly use strftime+strptime rather than snprintf+atol. This fixes the
build for X32, where long's size doesn't match that of time_t.

Signed-off-by: Christopher Larson 
---
 ...op-thumbnail-don-t-convert-time_t-to-long.patch | 72 ++
 .../gnome-desktop/gnome-desktop3_3.22.2.bb |  2 +
 2 files changed, 74 insertions(+)
 create mode 100644 
meta/recipes-gnome/gnome-desktop/gnome-desktop/gnome-desktop-thumbnail-don-t-convert-time_t-to-long.patch

diff --git 
a/meta/recipes-gnome/gnome-desktop/gnome-desktop/gnome-desktop-thumbnail-don-t-convert-time_t-to-long.patch
 
b/meta/recipes-gnome/gnome-desktop/gnome-desktop/gnome-desktop-thumbnail-don-t-convert-time_t-to-long.patch
new file mode 100644
index 000..18a069f
--- /dev/null
+++ 
b/meta/recipes-gnome/gnome-desktop/gnome-desktop/gnome-desktop-thumbnail-don-t-convert-time_t-to-long.patch
@@ -0,0 +1,72 @@
+From adfa0c8f9fec1faac4bea6a94d947ea32e585923 Mon Sep 17 00:00:00 2001
+From: Christopher Larson 
+Date: Tue, 13 Dec 2016 20:39:51 -0700
+Subject: [PATCH] gnome-desktop-thumbnail: don't convert time_t to long
+
+Explicitly use strftime+strptime rather than snprintf+atol. This fixes the
+build for X32, where long's size doesn't match that of time_t.
+
+Upstream-Status: Pending
+Signed-off-by: Christopher Larson 
+---
+ libgnome-desktop/gnome-desktop-thumbnail.c | 16 ++--
+ 1 file changed, 14 insertions(+), 2 deletions(-)
+
+diff --git a/libgnome-desktop/gnome-desktop-thumbnail.c 
b/libgnome-desktop/gnome-desktop-thumbnail.c
+index 3946309..b756333 100644
+--- a/libgnome-desktop/gnome-desktop-thumbnail.c
 b/libgnome-desktop/gnome-desktop-thumbnail.c
+@@ -126,6 +126,8 @@
+  * Since: 2.2
+  */
+ 
++#define _XOPEN_SOURCE
++
+ #include 
+ #include 
+ #include 
+@@ -1483,6 +1485,7 @@ save_thumbnail (GdkPixbuf  *pixbuf,
+   char *tmp_path = NULL;
+   int tmp_fd;
+   char mtime_str[21];
++  struct tm *tmp_mtime = NULL;
+   gboolean ret = FALSE;
+   GError *error = NULL;
+   const char *width, *height;
+@@ -1502,7 +1505,11 @@ save_thumbnail (GdkPixbuf  *pixbuf,
+ goto out;
+   close (tmp_fd);
+ 
+-  g_snprintf (mtime_str, 21, "%ld",  mtime);
++  tmp_mtime = localtime ();
++  if (!tmp_mtime)
++goto out;
++  strftime (mtime_str, 21, "%s", tmp_mtime);
++  free (tmp_mtime);
+   width = gdk_pixbuf_get_option (pixbuf, "tEXt::Thumb::Image::Width");
+   height = gdk_pixbuf_get_option (pixbuf, "tEXt::Thumb::Image::Height");
+ 
+@@ -1695,6 +1702,7 @@ gnome_desktop_thumbnail_is_valid (GdkPixbuf  
*pixbuf,
+ {
+   const char *thumb_uri, *thumb_mtime_str;
+   time_t thumb_mtime;
++  struct tm tmp_mtime;
+   
+   thumb_uri = gdk_pixbuf_get_option (pixbuf, "tEXt::Thumb::URI");
+   if (!thumb_uri)
+@@ -1705,7 +1713,11 @@ gnome_desktop_thumbnail_is_valid (GdkPixbuf  
*pixbuf,
+   thumb_mtime_str = gdk_pixbuf_get_option (pixbuf, "tEXt::Thumb::MTime");
+   if (!thumb_mtime_str)
+ return FALSE;
+-  thumb_mtime = atol (thumb_mtime_str);
++  if (!strptime (thumb_mtime_str, "%s", _mtime))
++return FALSE;
++  thumb_mtime = mktime (_mtime);
++  if (!thumb_mtime)
++return FALSE;
+   if (mtime != thumb_mtime)
+ return FALSE;
+   
+-- 
+2.8.0
+
diff --git a/meta/recipes-gnome/gnome-desktop/gnome-desktop3_3.22.2.bb 
b/meta/recipes-gnome/gnome-desktop/gnome-desktop3_3.22.2.bb
index e4e9d2f..e72c6ce 100644
--- a/meta/recipes-gnome/gnome-desktop/gnome-desktop3_3.22.2.bb
+++ b/meta/recipes-gnome/gnome-desktop/gnome-desktop3_3.22.2.bb
@@ -10,6 +10,8 @@ inherit gnome pkgconfig upstream-version-is-even 
gobject-introspection
 SRC_URI[archive.md5sum] = "3d7222d5305f3db022eca31d8108e02d"
 SRC_URI[archive.sha256sum] = 
"51d7ebf7a6c359be14c3dd7a022213e931484653815eb10b0131bef4c8979e1c"
 
+SRC_URI += "file://gnome-desktop-thumbnail-don-t-convert-time_t-to-long.patch"
+
 DEPENDS += "intltool-native gnome-common-native gsettings-desktop-schemas 
gconf virtual/libx11 gtk+3 glib-2.0 startup-notification xkeyboard-config 
iso-codes udev"
 
 inherit distro_features_check gtk-doc
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 13/16] nss: fix for x32

[Christopher Larson]

From: Christopher Larson 

This was casting to a pointer, and the pointer sizes are 32-bit on X32, not
64-bit. Adjust as appropriate.

Signed-off-by: Christopher Larson 
---
 .../nss/nss/Fix-compilation-for-X32.patch  | 31 ++
 meta/recipes-support/nss/nss_3.27.1.bb |  1 +
 2 files changed, 32 insertions(+)
 create mode 100644 meta/recipes-support/nss/nss/Fix-compilation-for-X32.patch

diff --git a/meta/recipes-support/nss/nss/Fix-compilation-for-X32.patch 
b/meta/recipes-support/nss/nss/Fix-compilation-for-X32.patch
new file mode 100644
index 000..f7f2c21
--- /dev/null
+++ b/meta/recipes-support/nss/nss/Fix-compilation-for-X32.patch
@@ -0,0 +1,31 @@
+From c8eadfcdfbc1d5a4799e9a264b0f859cb5954c05 Mon Sep 17 00:00:00 2001
+From: Christopher Larson 
+Date: Tue, 13 Dec 2016 11:40:47 -0700
+Subject: [PATCH 7/7] Fix compilation for X32
+
+X32 uses 32-bit pointers, not 64-bit.
+
+Signed-off-by: Christopher Larson 
+---
+ nss/lib/freebl/poly1305-donna-x64-sse2-incremental-source.c | 4 
+ 1 file changed, 4 insertions(+)
+
+diff --git a/nss/lib/freebl/poly1305-donna-x64-sse2-incremental-source.c 
b/nss/lib/freebl/poly1305-donna-x64-sse2-incremental-source.c
+index 2a3301e..d4ade41 100644
+--- a/nss/lib/freebl/poly1305-donna-x64-sse2-incremental-source.c
 b/nss/lib/freebl/poly1305-donna-x64-sse2-incremental-source.c
+@@ -87,7 +87,11 @@ static poly1305_state_internal INLINE
+ *
+ poly1305_aligned_state(poly1305_state *state)
+ {
++#ifdef __ILP32__
++return (poly1305_state_internal *)(((uint32_t)state + 63) & ~63);
++#else
+ return (poly1305_state_internal *)(((uint64_t)state + 63) & ~63);
++#endif
+ }
+ 
+ /* copy 0-63 bytes */
+-- 
+2.8.0
+
diff --git a/meta/recipes-support/nss/nss_3.27.1.bb 
b/meta/recipes-support/nss/nss_3.27.1.bb
index 0917938..0b4b5f9 100644
--- a/meta/recipes-support/nss/nss_3.27.1.bb
+++ b/meta/recipes-support/nss/nss_3.27.1.bb
@@ -22,6 +22,7 @@ SRC_URI = "\
 file://nss-fix-nsinstall-build.patch \
 file://disable-Wvarargs-with-clang.patch \
 file://pqg.c-ULL_addend.patch \
+file://Fix-compilation-for-X32.patch \
 file://nss.pc.in \
 file://signlibs.sh \
 "
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 16/16] webkitgtk: patch & disable JIT for x32

[Christopher Larson]

From: Christopher Larson 

It might not be speedy, but it does build now.

Signed-off-by: Christopher Larson 
---
 .../webkit/webkitgtk/x32_support.patch | 22 ++
 meta/recipes-sato/webkit/webkitgtk_2.14.2.bb   |  7 +++
 2 files changed, 29 insertions(+)
 create mode 100644 meta/recipes-sato/webkit/webkitgtk/x32_support.patch

diff --git a/meta/recipes-sato/webkit/webkitgtk/x32_support.patch 
b/meta/recipes-sato/webkit/webkitgtk/x32_support.patch
new file mode 100644
index 000..fea4c27
--- /dev/null
+++ b/meta/recipes-sato/webkit/webkitgtk/x32_support.patch
@@ -0,0 +1,22 @@
+From: Daniel Schepler 
+Subject: Fix FTBFS in x32
+Bug-Debian: https://bugs.debian.org/700795
+Upstream-Status: Pending
+Signed-off-by: Christopher Larson 
+Index: webkitgtk/Source/WTF/wtf/Platform.h
+===
+--- webkitgtk.orig/Source/WTF/wtf/Platform.h
 webkitgtk/Source/WTF/wtf/Platform.h
+@@ -182,8 +182,12 @@
+ /* CPU(X86_64) - AMD64 / Intel64 / x86_64 64-bit */
+ #if   defined(__x86_64__) \
+ || defined(_M_X64)
++#ifdef __ILP32__
++#define WTF_CPU_X86_64_32 1
++#else
+ #define WTF_CPU_X86_64 1
+ #endif
++#endif
+ 
+ /* CPU(ARM64) - Apple */
+ #if (defined(__arm64__) && defined(__APPLE__)) || defined(__aarch64__)
diff --git a/meta/recipes-sato/webkit/webkitgtk_2.14.2.bb 
b/meta/recipes-sato/webkit/webkitgtk_2.14.2.bb
index 46b5468..9720432 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.14.2.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.14.2.bb
@@ -20,6 +20,7 @@ SRC_URI = 
"http://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz \

file://0001-Tweak-gtkdoc-settings-so-that-gtkdoc-generation-work.patch \
file://0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch \
file://detect_atomics.patch \
+   file://x32_support.patch \
"
 
 SRC_URI[md5sum] = "2fe3cadbc546d93ca68a13756c2be015"
@@ -85,6 +86,12 @@ EXTRA_OECMAKE_append_toolchain-clang = " -DUSE_LD_GOLD=OFF "
 # JIT not supported on MIPS either
 EXTRA_OECMAKE_append_mipsarch = " -DENABLE_JIT=OFF "
 
+# JIT not supported on X32
+# An attempt was made to upstream JIT support for x32 in
+# https://bugs.webkit.org/show_bug.cgi?id=100450, but this was closed as
+# unresolved due to limited X32 adoption.
+EXTRA_OECMAKE_append_linux-gnux32 = " -DENABLE_JIT=OFF"
+
 SECURITY_CFLAGS_remove_aarch64 = "-fpie"
 SECURITY_CFLAGS_append_aarch64 = " -fPIE"
 
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 11/16] ffmpeg: disable asm for x32

[Christopher Larson]

From: Christopher Larson 

This is the usual way this is handled in desktop distros (see debian, gentoo).
I wasn't able to track down a patch to add proper x32 support to ffmpeg. There
was, however, a libav patch series which may be worth investigating.

Signed-off-by: Christopher Larson 
---
 meta/recipes-multimedia/ffmpeg/ffmpeg_3.2.2.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_3.2.2.bb 
b/meta/recipes-multimedia/ffmpeg/ffmpeg_3.2.2.bb
index 4fac46b..66718c4 100644
--- a/meta/recipes-multimedia/ffmpeg/ffmpeg_3.2.2.bb
+++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_3.2.2.bb
@@ -92,6 +92,8 @@ EXTRA_OECONF = " \
 ${@bb.utils.contains('AVAILTUNES', 'mips32r2', '', '--disable-mipsdsp 
--disable-mipsdspr2', d)} \
 "
 
+EXTRA_OECONF_append_linux-gnux32 = " --disable-asm"
+
 do_configure() {
 ${S}/configure ${EXTRA_OECONF}
 }
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 03/16] grub-efi: ignore arch mismatch for x32

[Christopher Larson]

From: Christopher Larson 

Ordinary 64-bit binaries are expected for the bootloader.

Signed-off-by: Christopher Larson 
---
 meta/recipes-bsp/grub/grub-efi_2.00.bb | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-bsp/grub/grub-efi_2.00.bb 
b/meta/recipes-bsp/grub/grub-efi_2.00.bb
index 531482b..03d273d 100644
--- a/meta/recipes-bsp/grub/grub-efi_2.00.bb
+++ b/meta/recipes-bsp/grub/grub-efi_2.00.bb
@@ -65,5 +65,8 @@ FILES_${PN} += "${libdir}/grub/${GRUB_TARGET}-efi \
 ${datadir}/grub \
 "
 
-BBCLASSEXTEND = "native"
+# 64-bit binaries are expected for the bootloader with an x32 userland
+INSANE_SKIP_${PN}_append_linux-gnux32 = " arch"
+INSANE_SKIP_${PN}-dbg_append_linux-gnux32 = " arch"
 
+BBCLASSEXTEND = "native"
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 10/16] gstreamer1.0-libav: disable asm for x32

[Christopher Larson]

From: Christopher Larson 

The included libav lacks support for x32, so disable the assembly
optimizations.

Signed-off-by: Christopher Larson 
---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-libav.inc | 4 
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav.inc 
b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav.inc
index ea01163..c228306 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav.inc
@@ -30,6 +30,10 @@ LIBAV_EXTRA_CONFIGURE_COMMON_ARG = "--target-os=linux \
   ${GSTREAMER_1_0_DEBUG} \
   --cross-prefix='${HOST_PREFIX}'"
 
+# Disable assembly optimizations for X32, as this libav lacks the support
+PACKAGECONFIG_remove_linux-gnux32 = "yasm"
+LIBAV_EXTRA_CONFIGURE_COMMON_ARG_append_linux-gnux32 = " --disable-asm"
+
 LIBAV_EXTRA_CONFIGURE_COMMON = \
 '${LIBAV_EXTRA_CONFIGURE}="${LIBAV_EXTRA_CONFIGURE_COMMON_ARG}"'
 
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 09/16] boost: drop flags bits, fix for x32

[Christopher Larson]

From: Christopher Larson 

boost was adding -march/-mcpu itself, and adding -m32/-m64 itself as well.
Patch that behavior out, apply another similar patch from elsewhere, and
adjust BJAM_OPTS to fix the x32 build.

Signed-off-by: Christopher Larson 
---
 meta/recipes-support/boost/boost.inc   |   3 +
 ...-Apply-boost-1.62.0-no-forced-flags.patch.patch | 101 +++
 ...Don-t-set-up-m32-m64-we-do-that-ourselves.patch |  98 ++
 ...p-arch-instruction-set-flags-we-do-that-o.patch | 144 +
 meta/recipes-support/boost/boost_1.62.0.bb |   3 +
 5 files changed, 349 insertions(+)
 create mode 100644 
meta/recipes-support/boost/boost/0001-Apply-boost-1.62.0-no-forced-flags.patch.patch
 create mode 100644 
meta/recipes-support/boost/boost/0002-Don-t-set-up-m32-m64-we-do-that-ourselves.patch
 create mode 100644 
meta/recipes-support/boost/boost/0003-Don-t-set-up-arch-instruction-set-flags-we-do-that-o.patch

diff --git a/meta/recipes-support/boost/boost.inc 
b/meta/recipes-support/boost/boost.inc
index a1a6a90..0b2b17d 100644
--- a/meta/recipes-support/boost/boost.inc
+++ b/meta/recipes-support/boost/boost.inc
@@ -177,6 +177,9 @@ BJAM_OPTS= '${BOOST_PARALLEL_MAKE} -d+2 -q \
 # Native compilation of bzip2 isn't working
 BJAM_OPTS_append_class-native = ' -sNO_BZIP2=1'
 
+# Adjust the build for x32
+BJAM_OPTS_append_linux-gnux32 = " abi=x32 address-model=64"
+
 do_configure() {
cp -f ${S}/boost/config/platform/linux.hpp 
${S}/boost/config/platform/linux-gnueabi.hpp
 
diff --git 
a/meta/recipes-support/boost/boost/0001-Apply-boost-1.62.0-no-forced-flags.patch.patch
 
b/meta/recipes-support/boost/boost/0001-Apply-boost-1.62.0-no-forced-flags.patch.patch
new file mode 100644
index 000..8cd6ceb
--- /dev/null
+++ 
b/meta/recipes-support/boost/boost/0001-Apply-boost-1.62.0-no-forced-flags.patch.patch
@@ -0,0 +1,101 @@
+From 8845a786598f1d9e83aa1b7d2966b0d1eb765ba0 Mon Sep 17 00:00:00 2001
+From: Christopher Larson 
+Date: Tue, 13 Dec 2016 10:14:31 -0700
+Subject: [PATCH 1/3] Apply boost-1.62.0-no-forced-flags.patch
+
+Upstream-Status: Pending
+Signed-off-by: Christopher Larson 
+---
+ libs/log/build/Jamfile.v2   |  4 ++--
+ libs/log/config/x86-ext/Jamfile.jam | 16 
+ libs/log/src/dump_avx2.cpp  |  4 
+ libs/log/src/dump_ssse3.cpp |  4 
+ 4 files changed, 18 insertions(+), 10 deletions(-)
+
+diff --git a/libs/log/build/Jamfile.v2 b/libs/log/build/Jamfile.v2
+index 4abbdbc..b3016fc 100644
+--- a/libs/log/build/Jamfile.v2
 b/libs/log/build/Jamfile.v2
+@@ -373,7 +373,7 @@ rule avx2-targets-cond ( properties * )
+ }
+ else if clang in $(properties)
+ {
+-result = "-mavx -mavx2" ;
++result =  ;
+ }
+ else if intel in $(properties)
+ {
+@@ -383,7 +383,7 @@ rule avx2-targets-cond ( properties * )
+ }
+ else
+ {
+-result = "-xCORE-AVX2 -fabi-version=0" ;
++result = "-fabi-version=0" ;
+ }
+ }
+ else if msvc in $(properties)
+diff --git a/libs/log/config/x86-ext/Jamfile.jam 
b/libs/log/config/x86-ext/Jamfile.jam
+index 0e9695a..dcc394d 100644
+--- a/libs/log/config/x86-ext/Jamfile.jam
 b/libs/log/config/x86-ext/Jamfile.jam
+@@ -15,19 +15,19 @@ project /boost/log/x86-extensions
+ 
+ obj ssse3 : ssse3.cpp
+ :
+-gcc:"-msse -msse2 -msse3 -mssse3"
+-clang:"-msse -msse2 -msse3 -mssse3"
+-intel-linux:"-xSSSE3"
+-intel-darwin:"-xSSSE3"
++gcc:
++clang:
++intel-linux:
++intel-darwin:
+ intel-win:"/QxSSSE3"
+ ;
+ 
+ obj avx2 : avx2.cpp
+ :
+-gcc:"-mavx -mavx2 -fabi-version=0"
+-clang:"-mavx -mavx2"
+-intel-linux:"-xCORE-AVX2 -fabi-version=0"
+-intel-darwin:"-xCORE-AVX2 -fabi-version=0"
++gcc:"-fabi-version=0"
++clang:
++intel-linux:"-fabi-version=0"
++intel-darwin:"-fabi-version=0"
+ intel-win:"/arch:CORE-AVX2"
+ msvc:"/arch:AVX"
+ ;
+diff --git a/libs/log/src/dump_avx2.cpp b/libs/log/src/dump_avx2.cpp
+index 4ab1250..610fc6d 100644
+--- a/libs/log/src/dump_avx2.cpp
 b/libs/log/src/dump_avx2.cpp
+@@ -22,6 +22,10 @@
+ #include 
+ #include 
+ 
++#if !defined(__AVX2__)
++#error "AVX2 Unsupported!"
++#endif
++
+ #if defined(__x86_64) || defined(__x86_64__) || \
+ defined(__amd64__) || defined(__amd64) || \
+ defined(_M_X64)
+diff --git a/libs/log/src/dump_ssse3.cpp b/libs/log/src/dump_ssse3.cpp
+index 1325b49..60d4112 100644
+--- a/libs/log/src/dump_ssse3.cpp
 b/libs/log/src/dump_ssse3.cpp
+@@ -22,6 +22,10 @@
+ #include 
+ #include 
+ 
++#if !defined(__SSSE3__)
++#error "SSSE3 Unsupported!"
++#endif
++
+ #if 

[OE-core] [PATCH 08/16] ltp: fix build for x32

[Christopher Larson]

From: Christopher Larson 

We need to use the correct time() definition with time_t rather than a long,
since long is 32-bit on x32.

Signed-off-by: Christopher Larson 
---
 .../ltp/fcntl-fix-the-time-def-to-use-time_t.patch | 28 ++
 meta/recipes-extended/ltp/ltp_20160126.bb  |  1 +
 2 files changed, 29 insertions(+)
 create mode 100644 
meta/recipes-extended/ltp/ltp/fcntl-fix-the-time-def-to-use-time_t.patch

diff --git 
a/meta/recipes-extended/ltp/ltp/fcntl-fix-the-time-def-to-use-time_t.patch 
b/meta/recipes-extended/ltp/ltp/fcntl-fix-the-time-def-to-use-time_t.patch
new file mode 100644
index 000..f7e805a
--- /dev/null
+++ b/meta/recipes-extended/ltp/ltp/fcntl-fix-the-time-def-to-use-time_t.patch
@@ -0,0 +1,28 @@
+From 9590d073d3abe02fe0783ef8c530aef2e873ba9b Mon Sep 17 00:00:00 2001
+From: Christopher Larson 
+Date: Tue, 13 Dec 2016 12:48:29 -0700
+Subject: [PATCH] fcntl: fix the time() def to use time_t
+
+This fixes the build on X32, where long is 32-bit rather than 64-bit.
+
+Signed-off-by: Christopher Larson 
+---
+ testcases/kernel/syscalls/fcntl/fcntl14.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/testcases/kernel/syscalls/fcntl/fcntl14.c 
b/testcases/kernel/syscalls/fcntl/fcntl14.c
+index 3b36572..65ac8fa 100644
+--- a/testcases/kernel/syscalls/fcntl/fcntl14.c
 b/testcases/kernel/syscalls/fcntl/fcntl14.c
+@@ -789,7 +789,7 @@ void dochild(void)
+ 
+ void run_test(int file_flag, int file_mode, int seek, int start, int end)
+ {
+-  extern long time();
++  extern time_t time();
+ 
+   /* reset fail to 0 for each run_test call */
+   fail = 0;
+-- 
+2.8.0
+
diff --git a/meta/recipes-extended/ltp/ltp_20160126.bb 
b/meta/recipes-extended/ltp/ltp_20160126.bb
index 6e2ceac..72d465b 100644
--- a/meta/recipes-extended/ltp/ltp_20160126.bb
+++ b/meta/recipes-extended/ltp/ltp_20160126.bb
@@ -65,6 +65,7 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git \

file://0036-testcases-network-nfsv4-acl-acl1.c-Security-fix-on-s.patch \
file://0037-containers-netns_netlink-Avoid-segmentation-fault.patch 
\
file://0038-run-posix-option-group-test-replace-CWD-qith-PWD.patch \
+   file://fcntl-fix-the-time-def-to-use-time_t.patch \
"
 
 S = "${WORKDIR}/git"
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 05/16] gnu-efi: build 64-bit for x32

[Christopher Larson]

From: Christopher Larson 

We're targeting the x86_64 EFI ABI.

Signed-off-by: Christopher Larson 
---
 meta/recipes-bsp/gnu-efi/gnu-efi_3.0.4.bb | 9 +
 1 file changed, 9 insertions(+)

diff --git a/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.4.bb 
b/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.4.bb
index 9ddc4ba..e55ab7f 100644
--- a/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.4.bb
+++ b/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.4.bb
@@ -52,3 +52,12 @@ BBCLASSEXTEND = "native"
 # CFLAGS += -mno-mmx -mno-sse
 # So also remove -mfpmath=sse from TUNE_CCARGS
 TUNE_CCARGS_remove = "-mfpmath=sse"
+
+python () {
+ccargs = d.getVar('TUNE_CCARGS', True).split()
+if '-mx32' in ccargs:
+# use x86_64 EFI ABI
+ccargs.remove('-mx32')
+ccargs.append('-m64')
+d.setVar('TUNE_CCARGS', ' '.join(ccargs))
+}
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 01/16] valgrind: skip for linux-gnux32

[Christopher Larson]

From: Christopher Larson 

valgrind doesn't support x32 at this time, so skip it for that host.

Signed-off-by: Christopher Larson 
---
 meta/recipes-devtools/valgrind/valgrind_3.12.0.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb 
b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
index 3385ef7..a4a3e72 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb
@@ -37,6 +37,9 @@ COMPATIBLE_HOST_armv4 = 'null'
 COMPATIBLE_HOST_armv5 = 'null'
 COMPATIBLE_HOST_armv6 = 'null'
 
+# X32 isn't supported by valgrind at this time
+COMPATIBLE_HOST_linux-gnux32 = 'null'
+
 # Disable for some MIPS variants
 COMPATIBLE_HOST_mipsarcho32 = "${@bb.utils.contains("TARGET_FPU", "soft", 
"null", ".*-linux", d)}"
 COMPATIBLE_HOST_mipsarchn32 = 'null'
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 06/16] gnu-efi: ignore arch mismatch for x32

[Christopher Larson]

From: Christopher Larson 

Signed-off-by: Christopher Larson 
---
 meta/recipes-bsp/gnu-efi/gnu-efi_3.0.4.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.4.bb 
b/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.4.bb
index e55ab7f..f95029a 100644
--- a/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.4.bb
+++ b/meta/recipes-bsp/gnu-efi/gnu-efi_3.0.4.bb
@@ -46,6 +46,9 @@ do_install() {
 
 FILES_${PN} += "${libdir}/*.lds"
 
+# 64-bit binaries are expected for EFI when targeting X32
+INSANE_SKIP_${PN}-dev_append_linux-gnux32 = " arch"
+
 BBCLASSEXTEND = "native"
 
 # It doesn't support sse, its make.defaults sets:
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 04/16] lttng-tools: fix for x32

[Christopher Larson]

From: Christopher Larson 

Signed-off-by: Christopher Larson 
---
 meta/recipes-kernel/lttng/lttng-tools/x32.patch | 16 
 meta/recipes-kernel/lttng/lttng-tools_git.bb|  1 +
 2 files changed, 17 insertions(+)
 create mode 100644 meta/recipes-kernel/lttng/lttng-tools/x32.patch

diff --git a/meta/recipes-kernel/lttng/lttng-tools/x32.patch 
b/meta/recipes-kernel/lttng/lttng-tools/x32.patch
new file mode 100644
index 000..b1bb8e4
--- /dev/null
+++ b/meta/recipes-kernel/lttng/lttng-tools/x32.patch
@@ -0,0 +1,16 @@
+Fix build for x32
+
+Upstream-Status: Pending
+Signed-off-by: Christopher Larson 
+
+--- lttng-tools-2.6.0/src/bin/lttng/utils.c~   2015-01-26 18:17:15.0 
+0100
 lttng-tools-2.6.0/src/bin/lttng/utils.c2015-07-30 19:45:25.632045712 
+0200
+@@ -130,7 +130,7 @@
+ #define HAS_FLS_U32
+ #endif
+ 
+-#if defined(__x86_64)
++#if defined(__x86_64) && !defined(__ILP32__)
+ static inline
+ unsigned int fls_u64(uint64_t x)
+ {
diff --git a/meta/recipes-kernel/lttng/lttng-tools_git.bb 
b/meta/recipes-kernel/lttng/lttng-tools_git.bb
index 0d2bd00..29fd75b 100644
--- a/meta/recipes-kernel/lttng/lttng-tools_git.bb
+++ b/meta/recipes-kernel/lttng/lttng-tools_git.bb
@@ -31,6 +31,7 @@ PACKAGECONFIG_remove_libc-musl = "lttng-ust"
 
 SRC_URI = "git://git.lttng.org/lttng-tools.git;branch=stable-2.8 \
file://0001-Fix-error.h-common-error.h.patch \
+   file://x32.patch \
file://run-ptest"
 
 S = "${WORKDIR}/git"
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 07/16] gummiboot: fix for x32 from systemd-boot

[Christopher Larson]

From: Christopher Larson 

Signed-off-by: Christopher Larson 
---
 .../gummiboot/configure-allow-setting-EFI_CC.patch | 28 ++
 meta/recipes-bsp/gummiboot/gummiboot_git.bb|  1 +
 2 files changed, 29 insertions(+)
 create mode 100644 
meta/recipes-bsp/gummiboot/gummiboot/configure-allow-setting-EFI_CC.patch

diff --git 
a/meta/recipes-bsp/gummiboot/gummiboot/configure-allow-setting-EFI_CC.patch 
b/meta/recipes-bsp/gummiboot/gummiboot/configure-allow-setting-EFI_CC.patch
new file mode 100644
index 000..59997f2
--- /dev/null
+++ b/meta/recipes-bsp/gummiboot/gummiboot/configure-allow-setting-EFI_CC.patch
@@ -0,0 +1,28 @@
+From e18c86d8eb1fb6166b8c386446123790e503d28c Mon Sep 17 00:00:00 2001
+From: Marc-Antoine Perennou 
+Date: Wed, 8 Apr 2015 22:33:53 +0200
+Subject: [PATCH] configure: allow setting EFI_CC
+
+Upstream-Status: Backport [from systemd-boot]
+Signed-off-by: Christopher Larson 
+---
+ configure.ac | 3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 27bbe1d..3efb810 100644
+--- a/configure.ac
 b/configure.ac
+@@ -37,8 +37,7 @@ AC_SYS_LARGEFILE
+ AC_PROG_CC
+ 
+ dnl Don't try to use things like -std=c99 for efi compilation
+-EFI_CC=$CC
+-AC_SUBST([EFI_CC])
++AC_CHECK_TOOL(EFI_CC, gcc)
+ 
+ AC_PROG_CC_C99
+ AM_PROG_CC_C_O
+-- 
+2.8.0
+
diff --git a/meta/recipes-bsp/gummiboot/gummiboot_git.bb 
b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
index c684b83..d7d6c28 100644
--- a/meta/recipes-bsp/gummiboot/gummiboot_git.bb
+++ b/meta/recipes-bsp/gummiboot/gummiboot_git.bb
@@ -14,6 +14,7 @@ SRCREV = "2bcd919c681c952eb867ef1bdb458f1bc49c2d55"
 SRC_URI = "git://anongit.freedesktop.org/gummiboot \
file://fix-objcopy.patch \

file://0001-console-Fix-C-syntax-errors-for-function-declaration.patch \
+   file://configure-allow-setting-EFI_CC.patch \
   "
 
 PACKAGECONFIG[manpages] = "--enable-manpages, --disable-manpages, 
libxslt-native xmlto-native"
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 02/16] packagegroup-core-tools-profile: exclude valgrind for x32

[Christopher Larson]

From: Christopher Larson 

valgrind doesn't seem to support x32 at this time, even in current upstream.

Signed-off-by: Christopher Larson 
---
 meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb 
b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
index 31ad82b..946c947 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
@@ -68,6 +68,7 @@ VALGRIND_armv4 = ""
 VALGRIND_armv5 = ""
 VALGRIND_armv6 = ""
 VALGRIND_aarch64 = ""
+VALGRIND_linux-gnux32 = ""
 
 RDEPENDS_${PN} = "\
 ${PROFILETOOLS} \
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 00/16] Various fixes for x32

[Christopher Larson]

From: Christopher Larson 

Tested both qemux86-64 and intel-corei7-64 (plus the meta-intel fix) with:

DEFAULTTUNE_intel-corei7-64 = "corei7-64-x32"
DEFAULTTUNE_qemux86-64 = "core2-64-x32"

The following changes since commit af330fc0087692039d4256a6fb1e122742e8ec1a:

  packagegroup-core-lsb: add opengl to REQUIRED_DISTRO_FEATURES (2017-01-05 
13:53:45 +)

are available in the git repository at:

  git://github.com/kergoth/openembedded-core x32
  https://github.com/kergoth/openembedded-core/tree/x32

Christopher Larson (16):
  valgrind: skip for linux-gnux32
  packagegroup-core-tools-profile: exclude valgrind for x32
  grub-efi: ignore arch mismatch for x32
  lttng-tools: fix for x32
  gnu-efi: build 64-bit for x32
  gnu-efi: ignore arch mismatch for x32
  gummiboot: fix for x32 from systemd-boot
  ltp: fix build for x32
  boost: drop flags bits, fix for x32
  gstreamer1.0-libav: disable asm for x32
  ffmpeg: disable asm for x32
  x264: for x32, disable asm and pass -mx32
  nss: fix for x32
  libunwind: apply a patch to fix x32
  gnome-desktop3: fix for x32
  webkitgtk: patch & disable JIT for x32

 meta/recipes-bsp/gnu-efi/gnu-efi_3.0.4.bb  |  12 ++
 meta/recipes-bsp/grub/grub-efi_2.00.bb |   5 +-
 .../gummiboot/configure-allow-setting-EFI_CC.patch |  28 
 meta/recipes-bsp/gummiboot/gummiboot_git.bb|   1 +
 .../packagegroup-core-tools-profile.bb |   1 +
 meta/recipes-devtools/valgrind/valgrind_3.12.0.bb  |   3 +
 .../ltp/fcntl-fix-the-time-def-to-use-time_t.patch |  28 
 meta/recipes-extended/ltp/ltp_20160126.bb  |   1 +
 ...op-thumbnail-don-t-convert-time_t-to-long.patch |  72 +++
 .../gnome-desktop/gnome-desktop3_3.22.2.bb |   2 +
 meta/recipes-kernel/lttng/lttng-tools/x32.patch|  16 +++
 meta/recipes-kernel/lttng/lttng-tools_git.bb   |   1 +
 meta/recipes-multimedia/ffmpeg/ffmpeg_3.2.2.bb |   2 +
 .../gstreamer/gstreamer1.0-libav.inc   |   4 +
 .../x264/x264/Fix-X32-build-by-disabling-asm.patch |  53 
 meta/recipes-multimedia/x264/x264_git.bb   |   1 +
 .../webkit/webkitgtk/x32_support.patch |  22 
 meta/recipes-sato/webkit/webkitgtk_2.14.2.bb   |   7 +
 meta/recipes-support/boost/boost.inc   |   3 +
 ...-Apply-boost-1.62.0-no-forced-flags.patch.patch | 101 +++
 ...Don-t-set-up-m32-m64-we-do-that-ourselves.patch |  98 ++
 ...p-arch-instruction-set-flags-we-do-that-o.patch | 144 +
 meta/recipes-support/boost/boost_1.62.0.bb |   3 +
 .../libunwind/libunwind/libunwind-1.1-x32.patch|  31 +
 meta/recipes-support/libunwind/libunwind_git.bb|   1 +
 .../nss/nss/Fix-compilation-for-X32.patch  |  31 +
 meta/recipes-support/nss/nss_3.27.1.bb |   1 +
 27 files changed, 671 insertions(+), 1 deletion(-)
 create mode 100644 
meta/recipes-bsp/gummiboot/gummiboot/configure-allow-setting-EFI_CC.patch
 create mode 100644 
meta/recipes-extended/ltp/ltp/fcntl-fix-the-time-def-to-use-time_t.patch
 create mode 100644 
meta/recipes-gnome/gnome-desktop/gnome-desktop/gnome-desktop-thumbnail-don-t-convert-time_t-to-long.patch
 create mode 100644 meta/recipes-kernel/lttng/lttng-tools/x32.patch
 create mode 100644 
meta/recipes-multimedia/x264/x264/Fix-X32-build-by-disabling-asm.patch
 create mode 100644 meta/recipes-sato/webkit/webkitgtk/x32_support.patch
 create mode 100644 
meta/recipes-support/boost/boost/0001-Apply-boost-1.62.0-no-forced-flags.patch.patch
 create mode 100644 
meta/recipes-support/boost/boost/0002-Don-t-set-up-m32-m64-we-do-that-ourselves.patch
 create mode 100644 
meta/recipes-support/boost/boost/0003-Don-t-set-up-arch-instruction-set-flags-we-do-that-o.patch
 create mode 100644 
meta/recipes-support/libunwind/libunwind/libunwind-1.1-x32.patch
 create mode 100644 meta/recipes-support/nss/nss/Fix-compilation-for-X32.patch

-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] webkitgtk: add missing python-native dep

[Christopher Larson]

From: Christopher Larson 

Since we can't inherit pythonnative, we need this dep explicitly.

Signed-off-by: Christopher Larson 
---
 meta/recipes-sato/webkit/webkitgtk_2.14.2.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.14.2.bb 
b/meta/recipes-sato/webkit/webkitgtk_2.14.2.bb
index 46b5468..3059e17 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.14.2.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.14.2.bb
@@ -40,6 +40,7 @@ DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt 
libidn gnutls \
   pango icu bison-native gawk intltool-native libwebp \
   atk udev harfbuzz jpeg libpng pulseaudio librsvg libtheora libvorbis 
libxcomposite libxtst \
   ruby-native libnotify gstreamer1.0-plugins-bad \
+  python-native \
   "
 
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', 
'wayland' ,d)} \
-- 
2.8.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] attr/ea-acl: pass --disable-gettext when USE_NLS=no

[Denys Dmytriyenko]

Ping.

On Fri, Dec 23, 2016 at 02:34:31PM -0500, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko 
> 
> Fixes following error in configure:
>   FATAL ERROR: msgfmt does not seem to be installed.
>   attr cannot be built without a working gettext installation.
> 
> Signed-off-by: Denys Dmytriyenko 
> ---
>  meta/recipes-support/attr/ea-acl.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-support/attr/ea-acl.inc 
> b/meta/recipes-support/attr/ea-acl.inc
> index 8750c3b..e77cf3e 100644
> --- a/meta/recipes-support/attr/ea-acl.inc
> +++ b/meta/recipes-support/attr/ea-acl.inc
> @@ -10,6 +10,7 @@ inherit autotools-brokensep gettext
>  EXTRA_AUTORECONF += "--exclude=autoheader"
>  EXTRA_OECONF = "INSTALL_USER=root INSTALL_GROUP=root"
>  EXTRA_OECONF_append_class-native = " --enable-gettext=no"
> +EXTRA_OECONF_append_class-target = "${@['', ' --disable-gettext 
> '][(d.getVar('USE_NLS') == 'no')]}"
>  
>  EXTRA_OEMAKE = "PKG_LIB_DIR=${base_libdir} PKG_DEVLIB_DIR=${libdir}"
>  
> -- 
> 2.7.4
> 
> -- 
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [morty][PATCH] systemtap: remove explicit msgfmt check

[Denys Dmytriyenko]

Ping.

On Thu, Dec 22, 2016 at 03:19:00PM -0500, Denys Dmytriyenko wrote:
> From: Ross Burton 
> 
> Passing --disable-nls should be enough to disable the requirement for a full
> gettext to be present, but the upstream configure explicitly checks for msgfmt
> even if it isn't going to be used.  To avoid having to depend on 
> gettext-native,
> patch this check out.
> 
> (From OE-Core rev: 2f8d2a74f73490c1ae35131d3eb3592f7ee0a1e4)
> 
> Signed-off-by: Ross Burton 
> Signed-off-by: Denys Dmytriyenko 
> ---
>  .../systemtap/systemtap/no-msgfmt-check.patch | 15 
> +++
>  meta/recipes-kernel/systemtap/systemtap_git.inc   |  1 +
>  2 files changed, 16 insertions(+)
>  create mode 100644 
> meta/recipes-kernel/systemtap/systemtap/no-msgfmt-check.patch
> 
> diff --git a/meta/recipes-kernel/systemtap/systemtap/no-msgfmt-check.patch 
> b/meta/recipes-kernel/systemtap/systemtap/no-msgfmt-check.patch
> new file mode 100644
> index 000..471e62c
> --- /dev/null
> +++ b/meta/recipes-kernel/systemtap/systemtap/no-msgfmt-check.patch
> @@ -0,0 +1,15 @@
> +There is no need to explicitly check that msgfmt was found as the gettext 
> macros
> +handle this for us if NLS is enabled.
> +
> +Upstream-Status: Pending
> +Signed-off-by: Ross Burton 
> +
> +diff --git a/configure.ac b/configure.ac
> +index e56079a..284bbe0 100644
> +--- a/configure.ac
>  b/configure.ac
> +@@ -39,4 +38,0 @@ AM_GNU_GETTEXT_VERSION([0.19.4])
> +-if test "x$GMSGFMT" = "x:"; then
> +-   AC_MSG_ERROR([missing gnu /usr/bin/msgfmt])
> +-fi
> +-
> diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc 
> b/meta/recipes-kernel/systemtap/systemtap_git.inc
> index 304eb99..34cf227 100644
> --- a/meta/recipes-kernel/systemtap/systemtap_git.inc
> +++ b/meta/recipes-kernel/systemtap/systemtap_git.inc
> @@ -9,6 +9,7 @@ SRC_URI = "git://sourceware.org/git/systemtap.git \
> file://configure-allow-to-disable-libvirt.patch \
> file://x32_abi_time.patch \
> file://monitor-option.patch \
> +   file://no-msgfmt-check.patch \
>"
>  
>  # systemtap doesn't support mips
> -- 
> 2.7.4
> 
> -- 
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2] linux-firmware: Modify firmware installation path

[Denys Dmytriyenko]

> -
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki 
> Business Identity Code: 0357606 - 4 
> Domiciled in Helsinki 
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 
> -- 

Please stop posting any confidential material to the public mailing list!

-- 
Denys
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] zlib: update SRC_URI to fix fetching

[Joshua Lock]

Upstream have removed the file from zlib.net as a new version has
been released, switch to fetching from the official sourceforge
mirror.

[YOCTO #10879]

Signed-off-by: Joshua Lock 
---
 meta/recipes-core/zlib/zlib_1.2.8.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/zlib/zlib_1.2.8.bb 
b/meta/recipes-core/zlib/zlib_1.2.8.bb
index 9470adb..913c703 100644
--- a/meta/recipes-core/zlib/zlib_1.2.8.bb
+++ b/meta/recipes-core/zlib/zlib_1.2.8.bb
@@ -6,7 +6,7 @@ SECTION = "libs"
 LICENSE = "Zlib"
 LIC_FILES_CHKSUM = 
"file://zlib.h;beginline=4;endline=23;md5=fde612df1e5933c428b73844a0c494fd"
 
-SRC_URI = "http://www.zlib.net/${BPN}-${PV}.tar.xz \
+SRC_URI = "${SOURCEFORGE_MIRROR}/libpng/${BPN}/${PV}/${BPN}-${PV}.tar.xz \
file://remove.ldconfig.call.patch \
file://Makefile-runtests.patch \
file://ldflags-tests.patch \
-- 
2.9.3

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/2] kernel: Modify kernel modules installation path.

[Burton, Ross]

On 4 January 2017 at 11:58, Amarnath Valluri 
wrote:

> Use ${base_libdir}/modules inplace of /lib/modules for kernel modules
> installation path.
>

Does the kernel actually respect ${base_libdir}?

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 1/1] rootfs-postcommands.bbclass: sort passwd entries

[Patrick Ohly]

The /etc passwd files in a rootfs consist of the default entries from
base-passwd plus anything that gets added by preinst scripts or
extrausers.bbclass.

The execution order of preinst scripts is not perfectly deterministic,
or at least unrelated changes caused it to change in a
non-deterministic way, resulting in irrelevant changes in the order of
passwd entries.

Such re-ordering is bad for reproducible builds and file-based update
mechanisms like swupd which work best if changes are as minimal as
possible.

To achieve that, the files get sorted in a post-processing command,
enabled by default. It would be slightly nicer to keep entries from
base-passwd at the beginning of the files, but that's harder to
implement.

The order of the entries should not matter, but in obscure cases where
it does (like having multiple entries for the same numeric ID) this
behavior can be disabled by setting SORT_PASSWD_POSTPROCESS_COMMAND to
an empty string.

Fixes: YOCTO #10520

Signed-off-by: Patrick Ohly 
---
 meta/classes/rootfs-postcommands.bbclass | 20 
 1 file changed, 20 insertions(+)

diff --git a/meta/classes/rootfs-postcommands.bbclass 
b/meta/classes/rootfs-postcommands.bbclass
index 8d48a2d..4ca031f 100644
--- a/meta/classes/rootfs-postcommands.bbclass
+++ b/meta/classes/rootfs-postcommands.bbclass
@@ -30,6 +30,13 @@ ROOTFS_POSTPROCESS_COMMAND += 'empty_var_volatile;'
 SSH_DISABLE_DNS_LOOKUP ?= " ssh_disable_dns_lookup ; "
 ROOTFS_POSTPROCESS_COMMAND_append_qemuall = "${SSH_DISABLE_DNS_LOOKUP}"
 
+# Sort the user and group entries in /etc in order to make the content
+# deterministic. Package installs are not deterministic, causing the ordering
+# of entries to change between builds. In case that this isn't desired,
+# the command can be overridden.
+SORT_PASSWD_POSTPROCESS_COMMAND ??= "sort_passwd; "
+ROOTFS_POSTPROCESS_COMMAND += "${SORT_PASSWD_POSTPROCESS_COMMAND}"
+
 systemd_create_users () {
for conffile in ${IMAGE_ROOTFS}/usr/lib/sysusers.d/systemd.conf 
${IMAGE_ROOTFS}/usr/lib/sysusers.d/systemd-remote.conf; do
[ -e $conffile ] || continue
@@ -146,6 +153,19 @@ ssh_disable_dns_lookup () {
fi
 }
 
+sort_passwd () {
+   for i in passwd shadow group gshadow; do
+   for suffix in "" "-"; do
+   file="${IMAGE_ROOTFS}/${sysconfdir}/$i$suffix"
+   if [ -f $file ]; then
+   sort $file >$file.tmp
+   cat $file.tmp >$file
+   rm $file.tmp
+   fi
+   done
+   done
+}
+
 #
 # Enable postinst logging if debug-tweaks is enabled
 #
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] OpenEmbedded Stand at FOSDEM

[Philip Balister]

On 01/03/2017 08:13 PM, Andreas Müller wrote:
> On Tue, Jan 3, 2017 at 4:32 PM, Philip Balister  wrote:
>> Every year since 2007, OpenEmbedded has a stand at FOSDEM
>> (http://www.fosdem.org)
>>
>> From the first year:
>>
>> https://www.flickr.com/photos/32615155@N00/405229708/in/album-72157594561002629/
>>
>> Belen and I are sort of organizing this, but both of us are also
>> involved in devrooms, so we will need a lot of help manning the stand
>> and getting some demos together.
>>
>> Demos should try and show how the project makes embedded work easier, by
>> showing tools and/or cool examples of devices using Linux built with
>> OpenEmbedded. In previous years, we've shown toaster with data collected
>> from demos on the table. Collections of devices running images built
>> from the same recipe and interesting products using Linux by OpenEmbedded.
>>
>> I'm happy to try and organize demos and staffing, but I could really use
>> some help this year, so if you are in a position to tak ethe lead on
>> operating the stand, that would be a huge help to me and the rest of the
>> project.
>>
>> Thanks,
>>
>> Philip
>> --
> I could bring along
> 
> 1. Raspi2 + Hifiberry + Speakers + Midi-Keyboard + Xbox-controller
> 2. a SDCard full of desktops/multimedia/office/games using 1.
> 3. 2 days time
> 4. ?? - let me know

I've created a wiki page:

http://www.openembedded.org/wiki/FOSDEM_2017

to help get things organized. If you need an account sign up and ping me
to approve it.

Philip


> 
> Andreas
> 
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] oe-selftest: Improve BUILDDIR environment handling

[Ed Bartosh]

On Thu, Jan 05, 2017 at 10:10:50AM +, Richard Purdie wrote:
> On Thu, 2017-01-05 at 11:40 +0200, Ed Bartosh wrote:
> > On Wed, Jan 04, 2017 at 11:48:53PM +, Richard Purdie wrote:
> > > 
> > > Its possible something (like bitbake/tinfoil2) may mess around with
> > > the
> > > environment and using the enviroment as a global variable store
> > > isn't
> > > particularly nice anyway.
> > > 
> > > This patch changes the BUILDDIR usages so that the environment
> > > isn't used
> > > as a global store and a global variable is used instead. Whilst
> > > that
> > > is still not perfect, it does avoid the current double and triple
> > > backtraces
> > > we're seeing where tinfoil2/bitbake has trampled the enviroment
> > > leading
> > > to failures of failures making debugging even harder.
> > > 
> > > Signed-off-by: Richard Purdie 
> > > ---
> > >  scripts/oe-selftest | 19 +--
> > >  1 file changed, 13 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/scripts/oe-selftest b/scripts/oe-selftest
> > > index bfcea66..e166521 100755
> > > --- a/scripts/oe-selftest
> > > +++ b/scripts/oe-selftest
> > > @@ -111,9 +111,13 @@ def get_args_parser():
> > >  help='Submit test results to a
> > > repository')
> > >  return parser
> > >  
> > > +builddir = None
> > > +
> > >  
> > >  def preflight_check():
> > >  
> > > +global builddir
> > > +
> > >  log.info("Checking that everything is in order before running
> > > the tests")
> > >  
> > >  if not os.environ.get("BUILDDIR"):
> > > @@ -135,7 +139,7 @@ def preflight_check():
> > >  return True
> > >  
> > >  def add_include():
> > > -builddir = os.environ.get("BUILDDIR")
> > > +global builddir
> > You don't need to use 'global' here. It's only mandatory if
> > you change variable value:
> > https://docs.python.org/3/reference/simple_stmts.html#the-global-stat
> > ement
> 
> In this case I did it purely for readability to make it clear how we
> were expecting it to work and to match the other uses. It doesn't hurt
> anything afaik.
> 
> > Would it be more readable to use name in upper case: BUILDDIR?
> 
> Not sure, that isn't something we've used as a style anywhere else so
> it doesn't really match any other style. Is that a python convention?
No, it's not. I thought it would be more readable as uppercase name
is the same as environment variable name. And it would be different
from local variable names, so you wouldn't need to use 'global'.

--
Regards,
Ed
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [morty][PATCH 0/1] Fix building apache2 on morty branch

[Burton, Ross]

On 5 January 2017 at 10:35, Piotr Lewicki  wrote:

> Patch from master that fixes building of apache2 on morty.
>

Wrong list, you want openembedded-devel@.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [morty][PATCH 1/1] apache2: always use the archive.apache.org to ensure older releases are always available

[Piotr Lewicki]

From: Derek Straka 

Signed-off-by: Derek Straka 
Signed-off-by: Martin Jansa 
Signed-off-by: Piotr Lewicki 
---
 meta-webserver/recipes-httpd/apache2/apache2-native_2.4.23.bb | 2 +-
 meta-webserver/recipes-httpd/apache2/apache2_2.4.23.bb| 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-webserver/recipes-httpd/apache2/apache2-native_2.4.23.bb 
b/meta-webserver/recipes-httpd/apache2/apache2-native_2.4.23.bb
index b227f19..aa26cc7 100644
--- a/meta-webserver/recipes-httpd/apache2/apache2-native_2.4.23.bb
+++ b/meta-webserver/recipes-httpd/apache2/apache2-native_2.4.23.bb
@@ -8,7 +8,7 @@ LICENSE = "Apache-2.0"
 
 inherit autotools pkgconfig native
 
-SRC_URI = "http://www.apache.org/dist/httpd/httpd-${PV}.tar.bz2 \
+SRC_URI = "http://archive.apache.org/dist/httpd/httpd-${PV}.tar.bz2 \
file://0001-configure-use-pkg-config-for-PCRE-detection.patch \
   "
 
diff --git a/meta-webserver/recipes-httpd/apache2/apache2_2.4.23.bb 
b/meta-webserver/recipes-httpd/apache2/apache2_2.4.23.bb
index 96f21dd..0cd762e 100644
--- a/meta-webserver/recipes-httpd/apache2/apache2_2.4.23.bb
+++ b/meta-webserver/recipes-httpd/apache2/apache2_2.4.23.bb
@@ -6,7 +6,7 @@ DEPENDS = "libtool-native apache2-native openssl expat pcre apr 
apr-util"
 SECTION = "net"
 LICENSE = "Apache-2.0"
 
-SRC_URI = "http://www.apache.org/dist/httpd/httpd-${PV}.tar.bz2 \
+SRC_URI = "http://archive.apache.org/dist/httpd/httpd-${PV}.tar.bz2 \
file://server-makefile.patch \
file://httpd-2.4.1-corelimit.patch \
file://httpd-2.4.4-export.patch \
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 0/6] Add opengl to REQUIRED_DISTRO_FEATURES for some recipes

[Patrick Ohly]

On Thu, 2017-01-05 at 08:51 +, Richard Purdie wrote:
> On Thu, 2017-01-05 at 08:32 +0100, Patrick Ohly wrote:
> > On Wed, 2017-01-04 at 23:49 +, Burton, Ross wrote:
> > > 
> > > 
> > > On 4 January 2017 at 22:57, Christopher Larson 
> > > wrote:
> > > These aren't buildable without it, and adding it fixes oe-
> > > core
> > > world builds
> > > with nodistro (which does not have the opengl feature by
> > > default).
> > > 
> > > 
> > > Am I still the only person who thinks skipping of recipes should be
> > > recursive, so if say libx11 throws a SkipRecipe then everything
> > > else
> > > that depends on it is also magically skipped?
> > Not at all, I'd also prefer that. If recipe "foo" has some obscure
> > conditions when it can be built, then repeating those conditions in
> > any
> > recipe depending on "foo" is a maintenance headache.
> > 
> > Last time I brought this up, it was mentioned as advantage of the
> > current approach that conditions are explicit and thus less
> > surprising.
> > There's some truth to that, but I don't believe that it outweighs the
> > disadvantages.
> 
> Imagine for example that we accidentally add some condition which
> results in 50% of the recipes being skipped. "bitbake world" would pass
> if this auto-skipping functionality was implemented. I worry that it
> would make it really easy to hide some subset of completely a non-
> buildable recipes which we can't even easily identify other than
> directly trying to build each target. We added something to avoid that
> (the world target).

Shouldn't it be caught by QA when expected functionality suddenly
disappears? But I guess that would only work in a perfect world; in
practice, QA coverage isn't sufficient and some recipes are indeed
merely in a "we know it compiles" state.

> The second problem is the actual implementation of it. I've never come
> up with a sane way to address this problem and give errors where people
> would want them yet hide the cases where people really don't want to be
> bothered, its very hard to make it work well at the bitbake level and
> the code is already complex/fragile enough.

How about a compromise: instead of repeating some (potentially complex)
checks in every recipe affected by this, could we have a "skip recipe
foo if dependencies are unavailable" check?

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.



-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [morty][PATCH 0/1] Fix building apache2 on morty branch

[Piotr Lewicki]

Patch from master that fixes building of apache2 on morty.

Derek Straka (1):
  apache2: always use the archive.apache.org to ensure older releases
are always available

 meta-webserver/recipes-httpd/apache2/apache2-native_2.4.23.bb | 2 +-
 meta-webserver/recipes-httpd/apache2/apache2_2.4.23.bb| 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/1] busybox: upgrade to 1.26.1

[Burton, Ross]

On 4 January 2017 at 03:22, Chen Qi  wrote:

> Upgrade busybox to 1.26.1. Also upgrade the git version to the
> corresponding
> commit.
>

Did you examine the changes that this introduces?

The packages grow a fairly large amount, and a number of new symlinks are
introduced.  Interestingly /bin/sh is now provided by both busybox.nosuid
and busybox.suid.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v2] wic/isoimage-isohybrid: check for grub-mkimage

[Ioan-Adrian Ratiu]

Hi

On Wed, 04 Jan 2017, Ed Bartosh  wrote:
> On Wed, Jan 04, 2017 at 10:12:55PM +0200, Ed Bartosh wrote:
>> On Wed, Jan 04, 2017 at 09:04:43PM +0200, Ioan-Adrian Ratiu wrote:
>> > The isohybrid plugin uses grub-mkimage but doesn't make sure it gets built.
>> > Add a check to avoid the following error:
>> > 
>> > Error: A native program grub-mkimage required to build the image was not 
>> > found (see details above).
>> > 
>> > Wic failed to find a recipe to build native grub-mkimage. Please file a 
>> > bug against wic.
>> > 
>> > Signed-off-by: Ioan-Adrian Ratiu 
>> > ---
>> >  scripts/lib/wic/plugins/source/isoimage-isohybrid.py | 5 +
>> >  1 file changed, 5 insertions(+)
>> > 
>> > diff --git a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py 
>> > b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
>> > index 849fd8bea3..d616316d61 100644
>> > --- a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
>> > +++ b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
>> > @@ -242,6 +242,11 @@ class IsoImagePlugin(SourcePlugin):
>> >  msger.info("Building mtools-native...\n")
>> >  exec_cmd("bitbake mtools-native")
>> >  
>> > +# Make sure grub-mkimage is available in native sysroot
>> > +if not os.path.isfile("%s/usr/bin/grub-mkimage" % native_sysroot):
>> > +msger.info("Building grub-native...\n")
>> > +exec_cmd("bitbake grub-native")
>> > +
>> >  @classmethod
>> >  def do_configure_partition(cls, part, source_params, creator, 
>> > cr_workdir,
>> > oe_builddir, bootimg_dir, kernel_dir,
>> 
>> Unfortunately this approach will not work if wic is run from bitbake.
>> 
>> I'd suggest to simply add grub-native to NATIVE_RECIPES dictionary in
>> scripts/lib/wic/utils/oe/misc.py
>> It will make error message more informative and useful.
>> 
> The same should probably be done with the rest of native tools called from
> this module. It's better to avoid building them implicitly.

Thank you for the feedback. I agree. I will send another patch.

Ionel

>
> --
> Regards,
> Ed
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] oe-selftest: Improve BUILDDIR environment handling

[Richard Purdie]

On Thu, 2017-01-05 at 11:40 +0200, Ed Bartosh wrote:
> On Wed, Jan 04, 2017 at 11:48:53PM +, Richard Purdie wrote:
> > 
> > Its possible something (like bitbake/tinfoil2) may mess around with
> > the
> > environment and using the enviroment as a global variable store
> > isn't
> > particularly nice anyway.
> > 
> > This patch changes the BUILDDIR usages so that the environment
> > isn't used
> > as a global store and a global variable is used instead. Whilst
> > that
> > is still not perfect, it does avoid the current double and triple
> > backtraces
> > we're seeing where tinfoil2/bitbake has trampled the enviroment
> > leading
> > to failures of failures making debugging even harder.
> > 
> > Signed-off-by: Richard Purdie 
> > ---
> >  scripts/oe-selftest | 19 +--
> >  1 file changed, 13 insertions(+), 6 deletions(-)
> > 
> > diff --git a/scripts/oe-selftest b/scripts/oe-selftest
> > index bfcea66..e166521 100755
> > --- a/scripts/oe-selftest
> > +++ b/scripts/oe-selftest
> > @@ -111,9 +111,13 @@ def get_args_parser():
> >  help='Submit test results to a
> > repository')
> >  return parser
> >  
> > +builddir = None
> > +
> >  
> >  def preflight_check():
> >  
> > +global builddir
> > +
> >  log.info("Checking that everything is in order before running
> > the tests")
> >  
> >  if not os.environ.get("BUILDDIR"):
> > @@ -135,7 +139,7 @@ def preflight_check():
> >  return True
> >  
> >  def add_include():
> > -builddir = os.environ.get("BUILDDIR")
> > +global builddir
> You don't need to use 'global' here. It's only mandatory if
> you change variable value:
> https://docs.python.org/3/reference/simple_stmts.html#the-global-stat
> ement

In this case I did it purely for readability to make it clear how we
were expecting it to work and to match the other uses. It doesn't hurt
anything afaik.

> Would it be more readable to use name in upper case: BUILDDIR?

Not sure, that isn't something we've used as a style anywhere else so
it doesn't really match any other style. Is that a python convention?

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] oe-selftest: Improve BUILDDIR environment handling

[Ed Bartosh]

On Wed, Jan 04, 2017 at 11:48:53PM +, Richard Purdie wrote:
> Its possible something (like bitbake/tinfoil2) may mess around with the
> environment and using the enviroment as a global variable store isn't
> particularly nice anyway.
> 
> This patch changes the BUILDDIR usages so that the environment isn't used
> as a global store and a global variable is used instead. Whilst that
> is still not perfect, it does avoid the current double and triple backtraces
> we're seeing where tinfoil2/bitbake has trampled the enviroment leading
> to failures of failures making debugging even harder.
> 
> Signed-off-by: Richard Purdie 
> ---
>  scripts/oe-selftest | 19 +--
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/scripts/oe-selftest b/scripts/oe-selftest
> index bfcea66..e166521 100755
> --- a/scripts/oe-selftest
> +++ b/scripts/oe-selftest
> @@ -111,9 +111,13 @@ def get_args_parser():
>  help='Submit test results to a repository')
>  return parser
>  
> +builddir = None
> +
>  
>  def preflight_check():
>  
> +global builddir
> +
>  log.info("Checking that everything is in order before running the tests")
>  
>  if not os.environ.get("BUILDDIR"):
> @@ -135,7 +139,7 @@ def preflight_check():
>  return True
>  
>  def add_include():
> -builddir = os.environ.get("BUILDDIR")
> +global builddir
You don't need to use 'global' here. It's only mandatory if
you change variable value:
https://docs.python.org/3/reference/simple_stmts.html#the-global-statement

Would it be more readable to use name in upper case: BUILDDIR?

>  if "#include added by oe-selftest.py" \
>  not in ftools.read_file(os.path.join(builddir, "conf/local.conf")):
>  log.info("Adding: \"include selftest.inc\" in local.conf")
> @@ -149,7 +153,7 @@ def add_include():
>  "\n#include added by oe-selftest.py\ninclude 
> bblayers.inc")
>  
>  def remove_include():
> -builddir = os.environ.get("BUILDDIR")
> +global builddir
>  if builddir is None:
>  return
>  if "#include added by oe-selftest.py" \
> @@ -165,18 +169,21 @@ def remove_include():
>  "\n#include added by oe-selftest.py\ninclude 
> bblayers.inc")
>  
>  def remove_inc_files():
> +global builddir
> +if builddir is None:
> +return
>  try:
> -os.remove(os.path.join(os.environ.get("BUILDDIR"), 
> "conf/selftest.inc"))
> +os.remove(os.path.join(builddir, "conf/selftest.inc"))
>  for root, _, files in os.walk(get_test_layer()):
>  for f in files:
>  if f == 'test_recipe.inc':
>  os.remove(os.path.join(root, f))
> -except (AttributeError, OSError,) as e:# AttributeError may happen 
> if BUILDDIR is not set
> +except OSError as e:
>  pass
>  
>  for incl_file in ['conf/bblayers.inc', 'conf/machine.inc']:
>  try:
> -os.remove(os.path.join(os.environ.get("BUILDDIR"), incl_file))
> +os.remove(os.path.join(builddir, incl_file))
>  except:
>  pass
>  
> @@ -394,7 +401,7 @@ def coverage_setup(coverage_source, coverage_include, 
> coverage_omit):
>  """ Set up the coverage measurement for the testcases to be run """
>  import datetime
>  import subprocess
> -builddir = os.environ.get("BUILDDIR")
> +global builddir
>  pokydir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
>  curcommit= subprocess.check_output(["git", "--git-dir", 
> os.path.join(pokydir, ".git"), "rev-parse", "HEAD"]).decode('utf-8')
>  coveragerc = "%s/.coveragerc" % builddir
> -- 
> 2.7.4
> 
> -- 
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
--
Regards,
Ed
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 8/8] oeqa.utils.metadata: add bitbake revision information

[Markus Lehtonen]

On 04/01/2017, 17.45, "Mariano Lopez" 
wrote:
>On 28/12/16 07:02, Markus Lehtonen wrote:
>> [YOCTO #10590]
>>
>> Signed-off-by: Markus Lehtonen 
>> ---
>>  meta/lib/oeqa/utils/metadata.py | 32 +++-
>>  1 file changed, 19 insertions(+), 13 deletions(-)
>>
>> diff --git a/meta/lib/oeqa/utils/metadata.py
>>b/meta/lib/oeqa/utils/metadata.py
>> index 6331c21..23449fc 100644
>> --- a/meta/lib/oeqa/utils/metadata.py
>> +++ b/meta/lib/oeqa/utils/metadata.py
>> @@ -10,6 +10,8 @@ from collections.abc import MutableMapping
>>  from xml.dom.minidom import parseString
>>  from xml.etree.ElementTree import Element, tostring
>>  
>> +from git import Repo, InvalidGitRepositoryError, NoSuchPathError
>> +
>
>It seems not every user running selftest appreciated the requirement of
>gitpython, so there was a patch to keep this dependency out. This will
>introduce the need of gitpython again.

Yes. I don't know why I moved this import to module level in the first
place. A corrected version of the patch in now found  in my
oe-core-contrib branch
(git://git.openembedded.org/openembedded-core-contrib marquiz/oeqa-metaxml)


Thanks,
  Markus


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 7/8] oeqa.utils.metadata: have layer name as an attribute in xml

[Markus Lehtonen]

On 04/01/2017, 17.43, "Mariano Lopez" 
wrote:
>
>On 28/12/16 07:02, Markus Lehtonen wrote:
>> -def dict_to_XML(tag, dictionary):
>> +def dict_to_XML(tag, dictionary, **kwargs):
>>  """ Return XML element converting dicts recursively. """
>>  
>> -elem = Element(tag)
>> +elem = Element(tag, **kwargs)
>>  for key, val in dictionary.items():
>> -if isinstance(val, MutableMapping):
>> +if tag == 'layers':
>> +child = (dict_to_XML('layer', val, name=key))
>> +elif isinstance(val, MutableMapping):
>>  child = (dict_to_XML(key, val))
>>  else:
>>  child = Element(key)
>
>I was thinking that this function would be more generic, adding a
>comparison to a tag name surely won't keep the function generic, is
>there another way to implement this keeping this function generic enough?

I don't think it's possible to make a nice generic json to xml converter.
The formats are just so different. I think the current method just
generates bad xml. In the future, it would probably be better to just get
rid of the json-to-xml conversion completely and make metadata_from_bb()
to directly return an ElementTree.

Thanks, 
  Markus


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 3/8] oeqa.utils.metadata: drop 'unknown' git data elements

[Markus Lehtonen]

On 04/01/2017, 17.30, "Mariano Lopez" 
wrote:
>On 28/12/16 07:02, Markus Lehtonen wrote:
>> It's better just to not have the xml elements than to have elements with
>> faux data. One could have git branch named 'unknown', for example.
>>
>>
>
>I don't think is a good idea to completely remove the layer from the
>metadata when such layer is not a repository, it would remove valuable
>information for later analysis. And if you ask would do such a thing, I
>would, I have my own debug layers that can mess with testing.

I'm not removing the entire layer. I'm just removing the
unknown and unknown elements. So the
layer elements are still there.

Thanks,
   Markus


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 0/6] Add opengl to REQUIRED_DISTRO_FEATURES for some recipes

[Richard Purdie]

On Wed, 2017-01-04 at 23:49 +, Burton, Ross wrote:
> 
> On 4 January 2017 at 22:57, Christopher Larson 
> wrote:
> > These aren't buildable without it, and adding it fixes oe-core
> > world builds
> > with nodistro (which does not have the opengl feature by default).
> > 
> Am I still the only person who thinks skipping of recipes should be
> recursive, so if say libx11 throws a SkipRecipe then everything else
> that depends on it is also magically skipped?

Just to highlight the challenge here, the provider of virtual/libc
raises a SkipRecipe, therefore every target recipe which isn't allarch
gets skipped and "bitbake world" returns success. We have SkipRecipe
code in the libcs so this isn't even that unlikely. I suspect you'd
argue that is broken.

How do you tell the difference between this case which is a clear error
and your case of X11 being disabled?

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 0/6] Add opengl to REQUIRED_DISTRO_FEATURES for some recipes

[Richard Purdie]

On Thu, 2017-01-05 at 08:32 +0100, Patrick Ohly wrote:
> On Wed, 2017-01-04 at 23:49 +, Burton, Ross wrote:
> > 
> > 
> > On 4 January 2017 at 22:57, Christopher Larson 
> > wrote:
> > These aren't buildable without it, and adding it fixes oe-
> > core
> > world builds
> > with nodistro (which does not have the opengl feature by
> > default).
> > 
> > 
> > Am I still the only person who thinks skipping of recipes should be
> > recursive, so if say libx11 throws a SkipRecipe then everything
> > else
> > that depends on it is also magically skipped?
> Not at all, I'd also prefer that. If recipe "foo" has some obscure
> conditions when it can be built, then repeating those conditions in
> any
> recipe depending on "foo" is a maintenance headache.
> 
> Last time I brought this up, it was mentioned as advantage of the
> current approach that conditions are explicit and thus less
> surprising.
> There's some truth to that, but I don't believe that it outweighs the
> disadvantages.

Imagine for example that we accidentally add some condition which
results in 50% of the recipes being skipped. "bitbake world" would pass
if this auto-skipping functionality was implemented. I worry that it
would make it really easy to hide some subset of completely a non-
buildable recipes which we can't even easily identify other than
directly trying to build each target. We added something to avoid that
(the world target).

The second problem is the actual implementation of it. I've never come
up with a sane way to address this problem and give errors where people
would want them yet hide the cases where people really don't want to be
bothered, its very hard to make it work well at the bitbake level and
the code is already complex/fragile enough.

Considering this, marking things up explicitly has always seemed like
the right thing to do ever time I've looked further into this. If
someone has the time and wants to propose a solution, sure, but I think
there are other more important/pressing things to do.

Cheers,

Richard
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core