Re: [OE-core] [PATCH] toolchain-scripts: make rpm work in toolchain

2019-05-27 Thread Lei, Maohui 
ping

> -Original Message-
> From: openembedded-core-boun...@lists.openembedded.org [mailto:openembedded-
> core-boun...@lists.openembedded.org] On Behalf Of Lei, Maohui
> Sent: Tuesday, May 14, 2019 2:31 PM
> To: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] toolchain-scripts: make rpm work in toolchain
> 
> Hi,
> 
> This patch hasn't been merged yet. Are there any suggestions?
> 
> Best regards
> Lei
> 
> > -Original Message-
> > From: openembedded-core-boun...@lists.openembedded.org [mailto:openembedded-
> > core-boun...@lists.openembedded.org] On Behalf Of Lei, Maohui
> > Sent: Wednesday, May 08, 2019 11:36 AM
> > To: openembedded-core@lists.openembedded.org
> > Subject: Re: [OE-core] [PATCH] toolchain-scripts: make rpm work in toolchain
> >
> > Ping
> >
> > > -Original Message-
> > > From: openembedded-core-boun...@lists.openembedded.org
> [mailto:openembedded-
> > > core-boun...@lists.openembedded.org] On Behalf Of Lei, Maohui
> > > Sent: Friday, April 26, 2019 1:56 PM
> > > To: openembedded-core@lists.openembedded.org
> > > Subject: Re: [OE-core] [PATCH] toolchain-scripts: make rpm work in
> toolchain
> > >
> > > Hi,
> > >
> > > I noticed that " dnf: Enable nativesdk " has been merged into master-next.
> > This
> > > patch is necessary for dnf-nativesdk, so please merge too.
> > >
> > > Best regards
> > > Lei
> > >
> > >
> > > > -Original Message-
> > > > From: openembedded-core-boun...@lists.openembedded.org
> > [mailto:openembedded-
> > > > core-boun...@lists.openembedded.org] On Behalf Of Zheng, Ruoqin
> > > > Sent: Friday, April 19, 2019 10:55 AM
> > > > To: openembedded-core@lists.openembedded.org
> > > > Subject: Re: [OE-core] [PATCH] toolchain-scripts: make rpm work in
> > toolchain
> > > >
> > > > ping
> > > >
> > > > --
> > > > Zheng Ruoqin
> > > > Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
> > > > ADDR.: No.6 Wenzhu Road, Software Avenue,
> > > >Nanjing, 210012, China
> > > > MAIL : zhengrq.f...@cn.fujistu.com
> > > >
> > > >
> > > > > -Original Message-
> > > > > From: Zheng, Ruoqin
> > > > > Sent: Saturday, April 13, 2019 10:37 PM
> > > > > To: openembedded-core@lists.openembedded.org
> > > > > Cc: Zheng, Ruoqin 
> > > > > Subject: [OE-core][PATCH] toolchain-scripts: make rpm work in 
> > > > > toolchain
> > > > >
> > > > > Rpm need to read the arch info, but $script did not provide it, so add
> it.
> > > > >
> > > > > Signed-off-by: Zheng Ruoqin 
> > > > > ---
> > > > >  meta/classes/toolchain-scripts.bbclass | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/meta/classes/toolchain-scripts.bbclass
> > > b/meta/classes/toolchain-
> > > > > scripts.bbclass
> > > > > index 1a2ec4f..de50b7e 100644
> > > > > --- a/meta/classes/toolchain-scripts.bbclass
> > > > > +++ b/meta/classes/toolchain-scripts.bbclass
> > > > > @@ -101,6 +101,7 @@ toolchain_shared_env_script () {
> > > > >   echo 'export CPPFLAGS="${TARGET_CPPFLAGS}"' >> $script
> > > > >   echo 'export KCFLAGS="--sysroot=$SDKTARGETSYSROOT"' >> $script
> > > > >   echo 'export OECORE_DISTRO_VERSION="${DISTRO_VERSION}"' >>
> > > > > $script
> > > > > + echo 'export MACHINE_ARCH=${MACHINE_ARCH}' >> $script
> > > > >   echo 'export OECORE_SDK_VERSION="${SDK_VERSION}"' >> $script
> > > > >   echo 'export ARCH=${ARCH}' >> $script
> > > > >   echo 'export CROSS_COMPILE=${TARGET_PREFIX}' >> $script
> > > > > --
> > > > > 1.8.3.1
> > > >
> > > >
> > > >
> > > > --
> > > > ___
> > > > Openembedded-core mailing list
> > > > Openembedded-core@lists.openembedded.org
> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > >
> > >
> > > --
> > > ___
> > > Openembedded-core mailing list
> > > Openembedded-core@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
> >
> > --
> > ___
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 5/5] lsbtest: add initscripts-functions as rconflict

2019-05-27 Thread changqing.li 
From: Changqing Li 

lsbtest rdepend on lsb, lsb rdepend on lsbinitscripts,
lsbinitscripts rconflict with initscripts-functions. so also add
rconflict for this one.

Signed-off-by: Changqing Li 
---
 meta/recipes-extended/lsb/lsbtest_1.0.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-extended/lsb/lsbtest_1.0.bb 
b/meta/recipes-extended/lsb/lsbtest_1.0.bb
index a90c023..d1526ba 100644
--- a/meta/recipes-extended/lsb/lsbtest_1.0.bb
+++ b/meta/recipes-extended/lsb/lsbtest_1.0.bb
@@ -11,6 +11,7 @@ SRC_URI = "file://LSB_Test.sh \
   file://session \
   "
 RDEPENDS_${PN} = "lsb rpm"
+RCONFLICTS_${PN} = "initscripts-functions"
 
 S = "${WORKDIR}"
 
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 3/5] bootchart2: add initscripts-functions as rconflict

2019-05-27 Thread changqing.li 
From: Changqing Li 

bootchart2 rdepend on lsb, lsb rdepend on lsbinitscripts,
lsbinitscripts rconflict with initscripts-functions. so also add
rconflict for this one.

Signed-off-by: Changqing Li 
---
 meta/recipes-devtools/bootchart2/bootchart2_0.14.8.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/bootchart2/bootchart2_0.14.8.bb 
b/meta/recipes-devtools/bootchart2/bootchart2_0.14.8.bb
index 396d0ec..36092e6 100644
--- a/meta/recipes-devtools/bootchart2/bootchart2_0.14.8.bb
+++ b/meta/recipes-devtools/bootchart2/bootchart2_0.14.8.bb
@@ -143,6 +143,7 @@ RDEPENDS_pybootchartgui = "python3-pycairo 
python3-compression python3-image pyt
 RDEPENDS_${PN}_class-target += "${@bb.utils.contains('DISTRO_FEATURES', 
'sysvinit', 'sysvinit-pidof', 'procps', d)}"
 RDEPENDS_${PN}_class-target += "lsb"
 DEPENDS_append_class-native = " python3-pycairo-native"
+RCONFLICTS_${PN}_class-target = "initscripts-functions"
 
 PACKAGES =+ "bootchartd-stop-initscript"
 FILES_bootchartd-stop-initscript += "${sysconfdir}/init.d ${sysconfdir}/rc*.d"
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 0/5] add rconflicts for serval packages

2019-05-27 Thread changqing.li 
From: Changqing Li 

Changqing Li (5):
  connman: add networkmanager as rconflict
  dropbear: add openssh/openssh-sshd as rconflict
  bootchart2: add initscripts-functions as rconflict
  lsb: add initscripts-functions as rconflict
  lsbtest: add initscripts-functions as rconflict

 meta/recipes-connectivity/connman/connman_1.37.bb | 1 +
 meta/recipes-core/dropbear/dropbear.inc   | 1 +
 meta/recipes-devtools/bootchart2/bootchart2_0.14.8.bb | 1 +
 meta/recipes-extended/lsb/lsb_5.0.bb  | 1 +
 meta/recipes-extended/lsb/lsbtest_1.0.bb  | 1 +
 5 files changed, 5 insertions(+)

-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 2/5] dropbear: add openssh/openssh-sshd as rconflict

2019-05-27 Thread changqing.li 
From: Changqing Li 

Signed-off-by: Changqing Li 
---
 meta/recipes-core/dropbear/dropbear.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/dropbear/dropbear.inc 
b/meta/recipes-core/dropbear/dropbear.inc
index 2537603..b74d186 100644
--- a/meta/recipes-core/dropbear/dropbear.inc
+++ b/meta/recipes-core/dropbear/dropbear.inc
@@ -9,6 +9,7 @@ LIC_FILES_CHKSUM = 
"file://LICENSE;md5=a5ec40cafba26fc4396d0b550f824e01"
 
 DEPENDS = "zlib virtual/crypt"
 RPROVIDES_${PN} = "ssh sshd"
+RCONFLICTS_${PN} = "openssh-sshd openssh"
 
 DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
 
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 4/5] lsb: add initscripts-functions as rconflict

2019-05-27 Thread changqing.li 
From: Changqing Li 

lsb rdepend on lsbinitscripts, lsbinitscripts rconflict with 
initscripts-functions.
so also add rconflict for this one.

Signed-off-by: Changqing Li 
---
 meta/recipes-extended/lsb/lsb_5.0.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-extended/lsb/lsb_5.0.bb 
b/meta/recipes-extended/lsb/lsb_5.0.bb
index d1de334..6f352dc 100644
--- a/meta/recipes-extended/lsb/lsb_5.0.bb
+++ b/meta/recipes-extended/lsb/lsb_5.0.bb
@@ -10,6 +10,7 @@ RPROVIDES_${PN} += "${LSB_CORE}"
 
 # lsb_release needs getopt, lsbinitscripts
 RDEPENDS_${PN} += "${VIRTUAL-RUNTIME_getopt} lsbinitscripts"
+RCONFLICTS_${PN} = "initscripts-functions"
 
 LIC_FILES_CHKSUM = "file://README;md5=12da544b1a3a5a1795a21160b49471cf"
 
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 1/5] connman: add networkmanager as rconflict

2019-05-27 Thread changqing.li 
From: Changqing Li 

Signed-off-by: Changqing Li 
---
 meta/recipes-connectivity/connman/connman_1.37.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-connectivity/connman/connman_1.37.bb 
b/meta/recipes-connectivity/connman/connman_1.37.bb
index 1265032..00852bf 100644
--- a/meta/recipes-connectivity/connman/connman_1.37.bb
+++ b/meta/recipes-connectivity/connman/connman_1.37.bb
@@ -14,3 +14,4 @@ SRC_URI[md5sum] = "75012084f14fb63a84b116e66c6e94fb"
 SRC_URI[sha256sum] = 
"6ce29b3eb0bb16a7387bc609c39455fd13064bdcde5a4d185fab3a0c71946e16"
 
 RRECOMMENDS_${PN} = "connman-conf"
+RCONFLICTS_${PN} = "networkmanager"
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] perl: Preserve attributes when applying cross files

2019-05-27 Thread Joshua Watt 
The file attributes (specifically the timestamps) must be preserved when
applying the cross files to have reproducible builds. Otherwise, the
cross files get the timestamp from when they are copied in the do_unpack
task, and the reproducible_build class uses this timestamp since it is
the youngest one in the source tree.

Signed-off-by: Joshua Watt 
---
 meta/recipes-devtools/perl-sanity/perl_5.28.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/perl-sanity/perl_5.28.2.bb 
b/meta/recipes-devtools/perl-sanity/perl_5.28.2.bb
index 12b220a4d80..f175e87a12e 100644
--- a/meta/recipes-devtools/perl-sanity/perl_5.28.2.bb
+++ b/meta/recipes-devtools/perl-sanity/perl_5.28.2.bb
@@ -43,7 +43,7 @@ do_unpack_append() {
 }
 
 do_copy_perlcross() {
-cp -rf ${WORKDIR}/perl-cross*/* ${S}
+cp -rfp ${WORKDIR}/perl-cross*/* ${S}
 }
 
 do_configure_class-target() {
-- 
2.21.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] vim: Move PACKAGECONFIG[gtkgui] from GTK 2 to GTK 3

2019-05-27 Thread Tom Rini 
On Mon, May 27, 2019 at 11:39:17PM +0300, Adrian Bunk wrote:

> Signed-off-by: Adrian Bunk 

Reviewed-by: Tom Rini 

-- 
Tom
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH v2] Revert "pigz: pigz is not gzip"

2019-05-27 Thread Anuj Mittal 
This reverts commit a54c59f2a24904daffe51582b6863eebd071db0d.

The compatibility issues have since been resolved [1][2] and pigz 2.4
annoucement also states that this can be considered as a drop-in
replacemment [3] now.

[1] 
https://github.com/madler/pigz/commit/33c140e5fdc5cd639d1e7cc3c5e52ec016aa8a65
[2] 
https://github.com/madler/pigz/commit/6fda8570f633ec582ba72ea00dad2bbac825bc17
[3] https://zlib.net/pipermail/pigz-announce_zlib.net/2017-December/28.html

Signed-off-by: Anuj Mittal 
---
 .../conf/distro/include/default-providers.inc |  1 +
 meta/recipes-extended/pigz/pigz_2.4.bb| 21 ++-
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/meta/conf/distro/include/default-providers.inc 
b/meta/conf/distro/include/default-providers.inc
index 21419038f0..2be3378773 100644
--- a/meta/conf/distro/include/default-providers.inc
+++ b/meta/conf/distro/include/default-providers.inc
@@ -42,6 +42,7 @@ PREFERRED_PROVIDER_opkg ?= "opkg"
 PREFERRED_PROVIDER_opkg-native ?= "opkg-native"
 PREFERRED_PROVIDER_nativesdk-opkg ?= "nativesdk-opkg"
 PREFERRED_PROVIDER_console-tools ?= "kbd"
+PREFERRED_PROVIDER_gzip-native ?= "pigz-native"
 PREFERRED_PROVIDER_udev ?= 
"${@bb.utils.contains('DISTRO_FEATURES','systemd','systemd','eudev',d)}"
 PREFERRED_RPROVIDER_bluez-hcidump ?= 
"${@bb.utils.contains('DISTRO_FEATURES','bluetooth 
bluez5','bluez5','bluez-hcidump',d)}"
 # Alternative is ltp-ddt in meta-oe: 
meta-oe/recipes-devtools/ltp-ddt/ltp-ddt_0.0.4.bb
diff --git a/meta/recipes-extended/pigz/pigz_2.4.bb 
b/meta/recipes-extended/pigz/pigz_2.4.bb
index 6e6da9c3c5..974c035147 100644
--- a/meta/recipes-extended/pigz/pigz_2.4.bb
+++ b/meta/recipes-extended/pigz/pigz_2.4.bb
@@ -11,6 +11,8 @@ LIC_FILES_CHKSUM = 
"file://pigz.c;md5=9ae6dee8ceba9610596ed0ada493d142;beginline
 SRC_URI = "http://zlib.net/${BPN}/fossils/${BP}.tar.gz;
 SRC_URI[md5sum] = "def2f6e19d9d8231445adc1349d346df"
 SRC_URI[sha256sum] = 
"a4f816222a7b4269bd232680590b579ccc72591f1bb5adafcd7208ca77e14f73"
+PROVIDES_class-native += "gzip-native"
+
 # Point this at the homepage in case /fossils/ isn't updated
 UPSTREAM_CHECK_URI = "http://zlib.net/${BPN}/;
 UPSTREAM_CHECK_REGEX = "pigz-(?P.*)\.tar"
@@ -19,7 +21,9 @@ DEPENDS = "zlib"
 
 EXTRA_OEMAKE = "-e MAKEFLAGS="
 
-do_install() {
+inherit update-alternatives
+
+do_install_class-target() {
# Install files into /bin (FHS), which is typical place for gzip
install -d ${D}${base_bindir}
install ${B}/pigz ${D}${base_bindir}/pigz
@@ -27,4 +31,19 @@ do_install() {
ln -nsf pigz ${D}${base_bindir}/pigzcat
 }
 
+do_install() {
+   install -d ${D}${bindir}
+   install ${B}/pigz ${D}${bindir}/gzip
+   ln -nsf gzip ${D}${bindir}/gunzip
+   ln -nsf gzip ${D}${bindir}/zcat
+}
+
+ALTERNATIVE_PRIORITY = "80"
+ALTERNATIVE_${PN} = "gunzip gzip zcat"
+ALTERNATIVE_${PN}_class-nativesdk = ""
+ALTERNATIVE_LINK_NAME[gunzip] = "${base_bindir}/gunzip"
+ALTERNATIVE_LINK_NAME[gzip] = "${base_bindir}/gzip"
+ALTERNATIVE_LINK_NAME[zcat] = "${base_bindir}/zcat"
+ALTERNATIVE_TARGET = "${base_bindir}/pigz"
+
 BBCLASSEXTEND = "native nativesdk"
-- 
2.20.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 08/11] gstreamer1.0-vaapi: upgrade to version 1.16.0

2019-05-27 Thread Mittal, Anuj 
Looks like this needs a dependency on wayland-scanner and wayland-
protocols as well for this version?

Error log from autobuilder:

https://errors.yoctoproject.org/Errors/Details/247143/

Thanks
Anuj

On Sun, 2019-05-26 at 13:06 +0200, Carlos Rafael Giani wrote:
> Signed-off-by: Philippe Normand 
> Signed-off-by: Carlos Rafael Giani 
> ---
>  .../0001-vaapsink-downgrade-to-marginal.patch | 4
> ++--
>  ...reamer1.0-vaapi_1.14.4.bb => gstreamer1.0-vaapi_1.16.0.bb} | 4
> ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>  rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-
> vaapi_1.14.4.bb => gstreamer1.0-vaapi_1.16.0.bb} (93%)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-
> vaapi/0001-vaapsink-downgrade-to-marginal.patch b/meta/recipes-
> multimedia/gstreamer/gstreamer1.0-vaapi/0001-vaapsink-downgrade-to-
> marginal.patch
> index c861f3bed2..7945a923c9 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi/0001-
> vaapsink-downgrade-to-marginal.patch
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi/0001-
> vaapsink-downgrade-to-marginal.patch
> @@ -24,7 +24,7 @@ diff --git a/gst/vaapi/gstvaapi.c
> b/gst/vaapi/gstvaapi.c
>  index 9a82454..4d94f2b 100644
>  --- a/gst/vaapi/gstvaapi.c
>  +++ b/gst/vaapi/gstvaapi.c
> -@@ -210,7 +210,6 @@ plugin_init (GstPlugin * plugin)
> +@@ -195,7 +195,6 @@ plugin_init (GstPlugin * plugin)
>   {
> GstVaapiDisplay *display;
> GArray *decoders;
> @@ -32,7 +32,7 @@ index 9a82454..4d94f2b 100644
>   
> plugin_add_dependencies (plugin);
>   
> -@@ -235,10 +234,7 @@ plugin_init (GstPlugin * plugin)
> +@@ -220,10 +219,7 @@ plugin_init (GstPlugin * plugin)
> gst_element_register (plugin, "vaapidecodebin",
> GST_RANK_PRIMARY + 2, GST_TYPE_VAAPI_DECODE_BIN);
>   
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-
> vaapi_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-
> vaapi_1.16.0.bb
> similarity index 93%
> rename from meta/recipes-multimedia/gstreamer/gstreamer1.0-
> vaapi_1.14.4.bb
> rename to meta/recipes-multimedia/gstreamer/gstreamer1.0-
> vaapi_1.16.0.bb
> index 3896434104..4d7382a101 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.14.4.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.16.0.bb
> @@ -13,8 +13,8 @@ SRC_URI = "
> https://gstreamer.freedesktop.org/src/${REALPN}/${REALPN}-${PV}.tar.x
> file://0001-vaapsink-downgrade-to-marginal.patch \
> "
>  
> -SRC_URI[md5sum] = "2fae3442f5f23e7354a0c592bc7b9065"
> -SRC_URI[sha256sum] =
> "ce18dbfe961c6a8d31270231686075586bf7a7df62b778c8e7f5ec148251d0a3"
> +SRC_URI[md5sum] = "8c3f9ee3e47cbdb75a94f7183460b721"
> +SRC_URI[sha256sum] =
> "4e7fce626ee0590dca74b5a8341d25bac76307945131a970b414fc5895f5171f"
>  
>  S = "${WORKDIR}/${REALPN}-${PV}"
>  DEPENDS = "libva gstreamer1.0 gstreamer1.0-plugins-base
> gstreamer1.0-plugins-bad"
> -- 
> 2.17.1
> 

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] go: Remove INSANE_SKIP_* textrel that are now handled in go.bbclass

2019-05-27 Thread Adrian Bunk 
Signed-off-by: Adrian Bunk 
---
 meta/recipes-devtools/go/go-dep_0.5.0.bb | 10 --
 1 file changed, 10 deletions(-)

diff --git a/meta/recipes-devtools/go/go-dep_0.5.0.bb 
b/meta/recipes-devtools/go/go-dep_0.5.0.bb
index cfc2186b31..a4d631f8ea 100644
--- a/meta/recipes-devtools/go/go-dep_0.5.0.bb
+++ b/meta/recipes-devtools/go/go-dep_0.5.0.bb
@@ -19,16 +19,6 @@ RDEPENDS_${PN}-dev += "bash"
 
 BBCLASSEXTEND = "native nativesdk"
 
-# for x86 ends with textrel in ${PN}
-# http://errors.yoctoproject.org/Errors/Details/185630/
-# ERROR: QA Issue: ELF binary 
'/work/i586-oe-linux/go-dep/0.4.1-r0/packages-split/go-dep/usr/bin/dep' has 
relocations in .text [textrel]
-INSANE_SKIP_${PN} += "textrel"
-
-# for aarch64 ends with textrel in ${PN}-ptest
-# http://errors.yoctoproject.org/Errors/Details/185632/
-# ERROR: QA Issue: ELF binary 
'/work/aarch64-oe-linux/go-dep/0.4.1-r0/packages-split/go-dep-ptest/usr/lib/go-dep/ptest/github.com/golang/dep/cmd/dep/dep.test'
 has relocations in .text [textrel]  
-INSANE_SKIP_${PN}-ptest += "textrel"
-
 # For compiling ptest on mips and mips64, the current go-dep version fails 
with the go 1.11 toolchain.
 # error message: vet config not found
 PTEST_ENABLED_mips = "0"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] Remove Go 1.11

2019-05-27 Thread Adrian Bunk 
There doesn't seem to be a reason to keep it in addition to 1.12 now.

Signed-off-by: Adrian Bunk 
---
 meta/recipes-devtools/go/go-1.11.inc  |  23 --
 ...ow-CC-and-CXX-to-have-multiple-words.patch |  31 --
 ...ent-based-hash-generation-less-pedan.patch | 218 --
 ...-to-be-overridden-in-the-environment.patch |  48 ---
 ...4-ld-add-soname-to-shareable-objects.patch |  45 ---
 ...de-CC-when-building-dist-and-go_boot.patch |  37 ---
 ...dist-separate-host-and-target-builds.patch | 282 --
 ...d-go-make-GOROOT-precious-by-default.patch | 106 ---
 ...008-use-GOBUILDMODE-to-set-buildmode.patch |  37 ---
 ...place-glibc-dynamic-linker-with-musl.patch | 128 
 .../go/go-cross-canadian_1.11.bb  |   2 -
 meta/recipes-devtools/go/go-cross_1.11.bb |   2 -
 meta/recipes-devtools/go/go-crosssdk_1.11.bb  |   2 -
 meta/recipes-devtools/go/go-native_1.11.bb|   2 -
 meta/recipes-devtools/go/go-runtime_1.11.bb   |   2 -
 meta/recipes-devtools/go/go_1.11.bb   |  14 -
 16 files changed, 979 deletions(-)
 delete mode 100644 meta/recipes-devtools/go/go-1.11.inc
 delete mode 100644 
meta/recipes-devtools/go/go-1.11/0001-allow-CC-and-CXX-to-have-multiple-words.patch
 delete mode 100644 
meta/recipes-devtools/go/go-1.11/0002-cmd-go-make-content-based-hash-generation-less-pedan.patch
 delete mode 100644 
meta/recipes-devtools/go/go-1.11/0003-allow-GOTOOLDIR-to-be-overridden-in-the-environment.patch
 delete mode 100644 
meta/recipes-devtools/go/go-1.11/0004-ld-add-soname-to-shareable-objects.patch
 delete mode 100644 
meta/recipes-devtools/go/go-1.11/0005-make.bash-override-CC-when-building-dist-and-go_boot.patch
 delete mode 100644 
meta/recipes-devtools/go/go-1.11/0006-cmd-dist-separate-host-and-target-builds.patch
 delete mode 100644 
meta/recipes-devtools/go/go-1.11/0007-cmd-go-make-GOROOT-precious-by-default.patch
 delete mode 100644 
meta/recipes-devtools/go/go-1.11/0008-use-GOBUILDMODE-to-set-buildmode.patch
 delete mode 100644 
meta/recipes-devtools/go/go-1.11/0009-ld-replace-glibc-dynamic-linker-with-musl.patch
 delete mode 100644 meta/recipes-devtools/go/go-cross-canadian_1.11.bb
 delete mode 100644 meta/recipes-devtools/go/go-cross_1.11.bb
 delete mode 100644 meta/recipes-devtools/go/go-crosssdk_1.11.bb
 delete mode 100644 meta/recipes-devtools/go/go-native_1.11.bb
 delete mode 100644 meta/recipes-devtools/go/go-runtime_1.11.bb
 delete mode 100644 meta/recipes-devtools/go/go_1.11.bb

diff --git a/meta/recipes-devtools/go/go-1.11.inc 
b/meta/recipes-devtools/go/go-1.11.inc
deleted file mode 100644
index d03e26cea0..00
--- a/meta/recipes-devtools/go/go-1.11.inc
+++ /dev/null
@@ -1,23 +0,0 @@
-require go-common.inc
-
-GO_BASEVERSION = "1.11"
-GO_MINOR = ".4"
-PV .= "${GO_MINOR}"
-FILESEXTRAPATHS_prepend := "${FILE_DIRNAME}/go-${GO_BASEVERSION}:"
-
-LIC_FILES_CHKSUM = "file://LICENSE;md5=5d4950ecb7b26d2c5e4e7b4e0dd74707"
-
-SRC_URI += "\
-file://0001-allow-CC-and-CXX-to-have-multiple-words.patch \
-file://0002-cmd-go-make-content-based-hash-generation-less-pedan.patch \
-file://0003-allow-GOTOOLDIR-to-be-overridden-in-the-environment.patch \
-file://0004-ld-add-soname-to-shareable-objects.patch \
-file://0005-make.bash-override-CC-when-building-dist-and-go_boot.patch \
-file://0006-cmd-dist-separate-host-and-target-builds.patch \
-file://0007-cmd-go-make-GOROOT-precious-by-default.patch \
-file://0008-use-GOBUILDMODE-to-set-buildmode.patch \
-"
-SRC_URI_append_libc-musl = " 
file://0009-ld-replace-glibc-dynamic-linker-with-musl.patch"
-
-SRC_URI[main.md5sum] = "a77697673215be465d1b583680ef2318"
-SRC_URI[main.sha256sum] = 
"4cfd42720a6b1e79a8024895fa6607b69972e8e32446df76d6ce79801bbadb15"
diff --git 
a/meta/recipes-devtools/go/go-1.11/0001-allow-CC-and-CXX-to-have-multiple-words.patch
 
b/meta/recipes-devtools/go/go-1.11/0001-allow-CC-and-CXX-to-have-multiple-words.patch
deleted file mode 100644
index 4442858c83..00
--- 
a/meta/recipes-devtools/go/go-1.11/0001-allow-CC-and-CXX-to-have-multiple-words.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From 7cc519aa5f84cf8fc7ac8c10fc69aa8040330ea0 Mon Sep 17 00:00:00 2001
-From: Matt Madison 
-Date: Mon, 19 Feb 2018 08:49:33 -0800
-Subject: [PATCH] allow CC and CXX to have multiple words
-
-Upstream-Status: Inappropriate [OE specific]
-
-Signed-off-by: Matt Madison 
-

- src/cmd/go/internal/envcmd/env.go | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/src/cmd/go/internal/envcmd/env.go 
b/src/cmd/go/internal/envcmd/env.go
-index afadbad..cedbfbf 100644
 a/src/cmd/go/internal/envcmd/env.go
-+++ b/src/cmd/go/internal/envcmd/env.go
-@@ -85,11 +85,11 @@ func MkEnv() []cfg.EnvVar {
- 
-   cc := cfg.DefaultCC(cfg.Goos, cfg.Goarch)
-   if env := strings.Fields(os.Getenv("CC")); len(env) > 0 {
--  cc = env[0]
-+  cc = strings.Join(env, " ")
-   }
-   cxx := cfg.DefaultCXX(cfg.Goos, cfg.Goarch)
-   if env

[OE-core] [PATCH] vim: Move PACKAGECONFIG[gtkgui] from GTK 2 to GTK 3

2019-05-27 Thread Adrian Bunk 
Signed-off-by: Adrian Bunk 
---
 meta/recipes-support/vim/vim.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/vim/vim.inc b/meta/recipes-support/vim/vim.inc
index 433f233448..5f9f3d79de 100644
--- a/meta/recipes-support/vim/vim.inc
+++ b/meta/recipes-support/vim/vim.inc
@@ -52,7 +52,7 @@ PACKAGECONFIG += " \
 ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 gtkgui', '', d)} \
 "
 
-PACKAGECONFIG[gtkgui] = "--enable-gui=gtk2,--enable-gui=no,gtk+,"
+PACKAGECONFIG[gtkgui] = "--enable-gui=gtk3,--enable-gui=no,gtk+3"
 PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
 PACKAGECONFIG[x11] = "--with-x,--without-x,xt,"
 PACKAGECONFIG[tiny] = "--with-features=tiny,--with-features=big,,"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH v3] bluez5: manage udev dependency with PACKAGECONFIG

2019-05-27 Thread David Frey 
udev is an optional dependency of bluez5, so use PACKAGECONFIG to give
users the ability to build bluez5 without udev support.

Signed-off-by: David Frey 
---
 meta/recipes-connectivity/bluez5/bluez5.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc 
b/meta/recipes-connectivity/bluez5/bluez5.inc
index aaf2af975d..93d1b4d8b0 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -6,7 +6,7 @@ LICENSE = "GPLv2+ & LGPLv2.1+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
 file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
 
file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e"
-DEPENDS = "udev dbus-glib glib-2.0"
+DEPENDS = "dbus-glib glib-2.0"
 PROVIDES += "bluez-hcidump"
 RPROVIDES_${PN} += "bluez-hcidump"
 
@@ -22,6 +22,7 @@ PACKAGECONFIG ??= "obex-profiles \
 hog-profiles \
 tools \
 deprecated \
+udev \
 "
 PACKAGECONFIG[obex-profiles] = "--enable-obex,--disable-obex,libical"
 PACKAGECONFIG[readline] = "--enable-client,--disable-client,readline,"
@@ -43,6 +44,7 @@ PACKAGECONFIG[threads] = "--enable-threads,--disable-threads"
 PACKAGECONFIG[deprecated] = "--enable-deprecated,--disable-deprecated"
 PACKAGECONFIG[mesh] = "--enable-mesh,--disable-mesh, json-c ell"
 PACKAGECONFIG[btpclient] = "--enable-btpclient,--disable-btpclient, ell"
+PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
 
 SRC_URI = "\
 ${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
-- 
2.21.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v2] bluez5: remove udev dependency

2019-05-27 Thread David Frey 
On 5/25/2019 8:51 AM, Burton, Ross wrote:
> The commit message and the patch disagree: you're not removing the
> udev dependency but allowing the user to remove it.
> 
> A better message would be 'bluez5: allow udev dependency to be
> disabled with PACKAGECONFIG'

Thanks for your feedback.  I will send v3 with a clearer commit message.

David

> 
> Ross
> 
> On Thu, 23 May 2019 at 17:42, David Frey  wrote:
>>
>> udev is an optional dependency of bluez5, so use PACKAGECONFIG to allow
>> users to decide if they want udev support.
>>
>> Signed-off-by: David Frey 
>> ---
>>  meta/recipes-connectivity/bluez5/bluez5.inc | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc 
>> b/meta/recipes-connectivity/bluez5/bluez5.inc
>> index aaf2af975d..93d1b4d8b0 100644
>> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
>> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
>> @@ -6,7 +6,7 @@ LICENSE = "GPLv2+ & LGPLv2.1+"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>>  file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 
>> \
>>  
>> file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e"
>> -DEPENDS = "udev dbus-glib glib-2.0"
>> +DEPENDS = "dbus-glib glib-2.0"
>>  PROVIDES += "bluez-hcidump"
>>  RPROVIDES_${PN} += "bluez-hcidump"
>>
>> @@ -22,6 +22,7 @@ PACKAGECONFIG ??= "obex-profiles \
>>  hog-profiles \
>>  tools \
>>  deprecated \
>> +udev \
>>  "
>>  PACKAGECONFIG[obex-profiles] = "--enable-obex,--disable-obex,libical"
>>  PACKAGECONFIG[readline] = "--enable-client,--disable-client,readline,"
>> @@ -43,6 +44,7 @@ PACKAGECONFIG[threads] = 
>> "--enable-threads,--disable-threads"
>>  PACKAGECONFIG[deprecated] = "--enable-deprecated,--disable-deprecated"
>>  PACKAGECONFIG[mesh] = "--enable-mesh,--disable-mesh, json-c ell"
>>  PACKAGECONFIG[btpclient] = "--enable-btpclient,--disable-btpclient, ell"
>> +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
>>
>>  SRC_URI = "\
>>  ${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
>> --
>> 2.21.0
>>
>> --
>> ___
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/2] Revert "pigz: pigz is not gzip"

2019-05-27 Thread Adrian Bunk 
On Mon, May 27, 2019 at 09:44:18PM +0800, Anuj Mittal wrote:
> This reverts commit a54c59f2a24904daffe51582b6863eebd071db0d.
>...
>  # Point this at the homepage in case /fossils/ isn't updated
> +PROVIDES_class-native += "gzip-native"
> +
>  UPSTREAM_CHECK_URI = "http://zlib.net/${BPN}/;
>  UPSTREAM_CHECK_REGEX = "pigz-(?P.*)\.tar"
>...

This moves the comment to the wrong place.

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] base.bbclass: add named SRCREVs to the sstate hash

2019-05-27 Thread Martin Jansa 
Hi Michael,

sorry I wasn't clear in the reply, I meant that it's easy to work around
this issue, but it's error prone.

Your patch does it automatically and I don't see any cases where we
wouldn't want all the SRCREVs included in do_fetch signature, so I like
your patch.

+1 from me.

Cheers,

On Mon, May 27, 2019 at 6:34 PM  wrote:

> Hi Martin,
>
>
>
> It seems a little tricky though to need to know about the sstate hashing
> in order to use named
> source revisions and it could be a bit confusing that using a normal
> SRCREV doesn’t require any
> extra effort but named SRCREVs require additional lines of metadata. As
> you can see in the
> commit message of my patches, the vulkan-demos recipe in poky also has
> this issue so it might
> be quite easy to forget.
>
>
>
> Thanks for the feedback. If the patch idea isn’t good, let me know if you
> think I should instead
> post a patch for the documentation to try to more explicitly note the need
> for the additional vardeps
> statements when using named SRCREVs.
>
>
>
> Thanks.
>
>
>
> Kind regards,
>
> Michael
>
>
>
> --
>
> *BMW Car IT GmbH*
> Michael Ho
> Spezialist Entwicklung – Build and Release Engineering
> Lise-Meitner-Straße 14
> 89081 Ulm
>
> Tel.: ­+49-731-37804-071
>
> Mobil: +49-152-54980-471
> Fax: +49-731-37804-001
> Mail: michael...@bmw-carit.de
> Web: http://www.bmw-carit.de
> -
> BMW Car IT GmbH
> Geschäftsführer: Kai-Uwe Balszuweit und Christian Salzmann
> Sitz und Registergericht: München HRB 134810
> -
>
>
>
>
>
> *From: *Martin Jansa 
> *Date: *Monday, 27 May 2019 at 5:44 pm
> *To: *"Ho Michael, JC-3UL" 
> *Cc: *Chris Larson , Patches and discussions about the
> oe-core layer 
> *Subject: *Re: [OE-core] [PATCH] base.bbclass: add named SRCREVs to the
> sstate hash
>
>
>
> In those recipes which don't include SRCPV in PV (for whatever reason) we
> usually add them explicitly with:
>
> do_fetch[vardeps] += "SRCREV_common"
>
> it's not ideal as people sometimes forget about this. Good practice is to
> add this next to the SRCREV_FORMAT (if you set one, to clearly show which
> revs are and aren't included).
>
>
>
> On Mon, May 27, 2019 at 5:37 PM  wrote:
>
> Hi Christopher,
>
>
>
> Thank you for the feedback. Since SRCPV is not always enforced (correct me
> if I’m wrong), it seems easy to trip over this bug when just following the
> documentation on multiple named source uri’s (also if you purposely don’t
> want to include the secondary source revisions in the package version).
> I’ll give it another shot to make it more efficient. If it’s not expected
> to be an encounterable bug case you can ignore the patch.
>
>
>
> Thanks.
>
>
>
> Kind regards,
>
> Michael
>
>
>
> --
>
> *BMW Car IT GmbH*
> Michael Ho
> Spezialist Entwicklung – Build and Release Engineering
> Lise-Meitner-Straße 14
> 89081 Ulm
>
> Tel.: ­+49-731-37804-071
>
> Mobil: +49-152-54980-471
> Fax: +49-731-37804-001
> Mail: michael...@bmw-carit.de
> Web: http://www.bmw-carit.de
> -
> BMW Car IT GmbH
> Geschäftsführer: Kai-Uwe Balszuweit und Christian Salzmann
> Sitz und Registergericht: München HRB 134810
> -
>
>
>
>
>
> *From: *Christopher Larson 
> *Date: *Wednesday, 8 May 2019 at 5:17 pm
> *To: *"Ho Michael, JC-3UL" 
> *Cc: *Patches and discussions about the oe-core layer <
> openembedded-core@lists.openembedded.org>
> *Subject: *Re: [OE-core] [PATCH] base.bbclass: add named SRCREVs to the
> sstate hash
>
>
>
> Does SRCPV not already cover this in the majority of cases? SRCREV_FORMAT
> controls how the multiple revs end up in PV, and the change to PV results
> in rebuilding anyway. And iterating over d.keys() is inefficient, *if*
> you’re going to do this, operate on SRCREV, gather up the name= parameters
> from scm urls, and use that to drive it.
>
>
>
> On Wed, May 8, 2019 at 7:10 AM Michael Ho  wrote:
>
> Several fetchers support named sources that require setting a SRCREV with
> the source name as a suffix. These named SRCREV variables are not captured
> in the sstate hash calculation because they're only referenced within the
> bitbake fetcher function.
>
> Add a snippet to the base.bbclass anonymous python to add all named SRCREV
> variables to the vardeps of do_fetch to capture them in the sstate hash
> calculation.
>
> Testing of the bug can be shown by running the following bitbake commands
> with this patch set not applied:
>
> bitbake vulkan-demos | tee
> sed -i 's/SRCREV_gli = ".*"/SRCREV_gli = "xxx"/' \
>   ../meta/recipes-graphics/vulkan/vulkan-demos_git.bb
> bitbake vulkan-demos | tee;
>
> Results in no errors despite a broken SRCREV because the vulkan-demos is
> considered unchanged.
>
> After applying this patch the above commands instead result in a fetcher
> error which is

Re: [OE-core] [PATCH V2 1/4] pam_systemd: Include missing.h for secure_getenv

2019-05-27 Thread Khem Raj 
ping^1 for the whole series ..

On Wed, May 22, 2019 at 4:40 PM Khem Raj  wrote:
>
> 'secure_getenv' api is not uniformly implemented across all C libraries
> therefore its good to include missing.h so it can use the alternative
> implementation where its not awvailable
>
> Fixes
> ../git/src/login/pam_systemd.c:344:13: error: implicit declaration of 
> function 'secure_getenv' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
> v = secure_getenv(key);
>
> Signed-off-by: Khem Raj 
> ---
> v2: Rebased
>
>  ...missing.h-check-for-missing-strndupa.patch | 71 +++
>  1 file changed, 10 insertions(+), 61 deletions(-)
>
> diff --git 
> a/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
>  
> b/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
> index a2e25a97df..df1043b27d 100644
> --- 
> a/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
> +++ 
> b/meta/recipes-core/systemd/systemd/0005-src-basic-missing.h-check-for-missing-strndupa.patch
> @@ -43,8 +43,6 @@ Signed-off-by: Andrej Valek 
>   src/udev/udev-rules.c  |  1 +
>   29 files changed, 40 insertions(+)
>
> -diff --git a/meson.build b/meson.build
> -index 79195c9..80d9564 100644
>  --- a/meson.build
>  +++ b/meson.build
>  @@ -572,6 +572,7 @@ foreach ident : [
> @@ -55,8 +53,6 @@ index 79195c9..80d9564 100644
>   ]
>
>   have = cc.has_function(ident[0], prefix : ident[1], args : 
> '-D_GNU_SOURCE')
> -diff --git a/src/backlight/backlight.c b/src/backlight/backlight.c
> -index dfd6805..c2b2ace 100644
>  --- a/src/backlight/backlight.c
>  +++ b/src/backlight/backlight.c
>  @@ -17,6 +17,7 @@
> @@ -67,8 +63,6 @@ index dfd6805..c2b2ace 100644
>
>   static int find_pci_or_platform_parent(sd_device *device, sd_device **ret) {
>   const char *subsystem, *sysname, *value;
> -diff --git a/src/basic/env-util.c b/src/basic/env-util.c
> -index fd449dc..e2b0722 100644
>  --- a/src/basic/env-util.c
>  +++ b/src/basic/env-util.c
>  @@ -16,6 +16,7 @@
> @@ -79,8 +73,6 @@ index fd449dc..e2b0722 100644
>
>   #define VALID_CHARS_ENV_NAME\
>   DIGITS LETTERS  \
> -diff --git a/src/basic/missing_stdlib.h b/src/basic/missing_stdlib.h
> -index 188a8d4..1e16ec2 100644
>  --- a/src/basic/missing_stdlib.h
>  +++ b/src/basic/missing_stdlib.h
>  @@ -11,3 +11,15 @@
> @@ -99,8 +91,6 @@ index 188a8d4..1e16ec2 100644
>  +(char *)memcpy(__new, __old, __len); \
>  +  })
>  +#endif
> -diff --git a/src/basic/mkdir.c b/src/basic/mkdir.c
> -index 6b82eab..51c6b78 100644
>  --- a/src/basic/mkdir.c
>  +++ b/src/basic/mkdir.c
>  @@ -14,6 +14,7 @@
> @@ -111,8 +101,6 @@ index 6b82eab..51c6b78 100644
>
>   int mkdir_safe_internal(const char *path, mode_t mode, uid_t uid, gid_t 
> gid, MkdirFlags flags, mkdir_func_t _mkdir) {
>   struct stat st;
> -diff --git a/src/basic/parse-util.c b/src/basic/parse-util.c
> -index 87724af..d9c53bc 100644
>  --- a/src/basic/parse-util.c
>  +++ b/src/basic/parse-util.c
>  @@ -19,6 +19,7 @@
> @@ -123,8 +111,6 @@ index 87724af..d9c53bc 100644
>
>   int parse_boolean(const char *v) {
>   if (!v)
> -diff --git a/src/basic/proc-cmdline.c b/src/basic/proc-cmdline.c
> -index 1670001..b51feaa 100644
>  --- a/src/basic/proc-cmdline.c
>  +++ b/src/basic/proc-cmdline.c
>  @@ -15,6 +15,7 @@
> @@ -135,8 +121,6 @@ index 1670001..b51feaa 100644
>
>   int proc_cmdline(char **ret) {
>   const char *e;
> -diff --git a/src/basic/procfs-util.c b/src/basic/procfs-util.c
> -index 7aaf95b..42ce53d 100644
>  --- a/src/basic/procfs-util.c
>  +++ b/src/basic/procfs-util.c
>  @@ -11,6 +11,7 @@
> @@ -147,8 +131,6 @@ index 7aaf95b..42ce53d 100644
>
>   int procfs_tasks_get_limit(uint64_t *ret) {
>   _cleanup_free_ char *value = NULL;
> -diff --git a/src/basic/time-util.c b/src/basic/time-util.c
> -index daf952b..374b97f 100644
>  --- a/src/basic/time-util.c
>  +++ b/src/basic/time-util.c
>  @@ -28,6 +28,7 @@
> @@ -159,8 +141,6 @@ index daf952b..374b97f 100644
>
>   static clockid_t map_clock_id(clockid_t c) {
>
> -diff --git a/src/core/dbus-cgroup.c b/src/core/dbus-cgroup.c
> -index 4615aea..bc1364f 100644
>  --- a/src/core/dbus-cgroup.c
>  +++ b/src/core/dbus-cgroup.c
>  @@ -15,6 +15,7 @@
> @@ -171,8 +151,6 @@ index 4615aea..bc1364f 100644
>
>   static BUS_DEFINE_PROPERTY_GET_ENUM(property_get_cgroup_device_policy, 
> cgroup_device_policy, CGroupDevicePolicy);
>
> -diff --git a/src/core/dbus-util.c b/src/core/dbus-util.c
> -index f4fbb72..0a1e3b5 100644
>  --- a/src/core/dbus-util.c
>  +++ b/src/core/dbus-util.c
>  @@ -7,6 +7,7 @@
> @@ -183,8 +161,6 @@ index f4fbb72..0a1e3b5 100644
>
>   int bus_property_get_triggered_unit(
>   sd_bus *bus,
> -diff --git a/src/core/kmod-setup.c b/src/core/kmod-setup.c
> -index a91cfeb..a459610 100644
>  --- a/src/core/kmod-setup.c
>  +++ b/src/core/kmod-setup.c
>

Re: [OE-core] [PATCH] base.bbclass: add named SRCREVs to the sstate hash

2019-05-27 Thread Michael.Ho 
Hi Martin,

It seems a little tricky though to need to know about the sstate hashing in 
order to use named
source revisions and it could be a bit confusing that using a normal SRCREV 
doesn’t require any
extra effort but named SRCREVs require additional lines of metadata. As you can 
see in the
commit message of my patches, the vulkan-demos recipe in poky also has this 
issue so it might
be quite easy to forget.

Thanks for the feedback. If the patch idea isn’t good, let me know if you think 
I should instead
post a patch for the documentation to try to more explicitly note the need for 
the additional vardeps
statements when using named SRCREVs.

Thanks.

Kind regards,
Michael

--
BMW Car IT GmbH
Michael Ho
Spezialist Entwicklung – Build and Release Engineering
Lise-Meitner-Straße 14
89081 Ulm

Tel.: ­+49-731-37804-071
Mobil: +49-152-54980-471
Fax: +49-731-37804-001
Mail: michael...@bmw-carit.de
Web: http://www.bmw-carit.de
-
BMW Car IT GmbH
Geschäftsführer: Kai-Uwe Balszuweit und Christian Salzmann
Sitz und Registergericht: München HRB 134810
-


From: Martin Jansa 
Date: Monday, 27 May 2019 at 5:44 pm
To: "Ho Michael, JC-3UL" 
Cc: Chris Larson , Patches and discussions about the oe-core 
layer 
Subject: Re: [OE-core] [PATCH] base.bbclass: add named SRCREVs to the sstate 
hash

In those recipes which don't include SRCPV in PV (for whatever reason) we 
usually add them explicitly with:
do_fetch[vardeps] += "SRCREV_common"
it's not ideal as people sometimes forget about this. Good practice is to add 
this next to the SRCREV_FORMAT (if you set one, to clearly show which revs are 
and aren't included).

On Mon, May 27, 2019 at 5:37 PM mailto:michael...@bmw.de>> 
wrote:
Hi Christopher,

Thank you for the feedback. Since SRCPV is not always enforced (correct me if 
I’m wrong), it seems easy to trip over this bug when just following the 
documentation on multiple named source uri’s (also if you purposely don’t want 
to include the secondary source revisions in the package version). I’ll give it 
another shot to make it more efficient. If it’s not expected to be an 
encounterable bug case you can ignore the patch.

Thanks.

Kind regards,
Michael

--
BMW Car IT GmbH
Michael Ho
Spezialist Entwicklung – Build and Release Engineering
Lise-Meitner-Straße 14
89081 Ulm

Tel.: ­+49-731-37804-071
Mobil: +49-152-54980-471
Fax: +49-731-37804-001
Mail: michael...@bmw-carit.de
Web: http://www.bmw-carit.de
-
BMW Car IT GmbH
Geschäftsführer: Kai-Uwe Balszuweit und Christian Salzmann
Sitz und Registergericht: München HRB 134810
-


From: Christopher Larson mailto:kerg...@gmail.com>>
Date: Wednesday, 8 May 2019 at 5:17 pm
To: "Ho Michael, JC-3UL" mailto:michael...@bmw.de>>
Cc: Patches and discussions about the oe-core layer 
mailto:openembedded-core@lists.openembedded.org>>
Subject: Re: [OE-core] [PATCH] base.bbclass: add named SRCREVs to the sstate 
hash

Does SRCPV not already cover this in the majority of cases? SRCREV_FORMAT 
controls how the multiple revs end up in PV, and the change to PV results in 
rebuilding anyway. And iterating over d.keys() is inefficient, *if* you’re 
going to do this, operate on SRCREV, gather up the name= parameters from scm 
urls, and use that to drive it.

On Wed, May 8, 2019 at 7:10 AM Michael Ho 
mailto:michael...@bmw.de>> wrote:
Several fetchers support named sources that require setting a SRCREV with
the source name as a suffix. These named SRCREV variables are not captured
in the sstate hash calculation because they're only referenced within the
bitbake fetcher function.

Add a snippet to the base.bbclass anonymous python to add all named SRCREV
variables to the vardeps of do_fetch to capture them in the sstate hash
calculation.

Testing of the bug can be shown by running the following bitbake commands
with this patch set not applied:

bitbake vulkan-demos | tee
sed -i 's/SRCREV_gli = ".*"/SRCREV_gli = "xxx"/' \
  
../meta/recipes-graphics/vulkan/vulkan-demos_git.bb
bitbake vulkan-demos | tee;

Results in no errors despite a broken SRCREV because the vulkan-demos is
considered unchanged.

After applying this patch the above commands instead result in a fetcher
error which is correct.
---
 meta/classes/base.bbclass | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 1636c6e..84a27f5 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -638,6 +638,16 @@ python () {

 if needsrcrev:
 d.setVar("SRCPV", "${@bb.fetch2.get_srcrev(d)}")
+# Gather all SRCREV_*

Re: [OE-core] [PATCH] wic: bootimg-efi: add label source parameter

2019-05-27 Thread Richard Purdie 
On Mon, 2019-05-27 at 09:26 +0800, chee.yang@intel.com wrote:
> From: Chee Yang Lee 
> 
> Add new source parameter label to allow boot.conf/grub.cfg label option
> to set as "install-efi", so far it's hardcoded to "Boot".
> 
> The label remain to "Boot" for systemd-boot or blank for grub-efi whenever
> label are not "install-efi".
> 
> when label set to "install-efi" the image can boot into image installation.
> 
> Signed-off-by: Chee Yang Lee 
> ---
>  scripts/lib/wic/plugins/source/bootimg-efi.py | 20 +++-
>  1 file changed, 15 insertions(+), 5 deletions(-)
> 
> diff --git a/scripts/lib/wic/plugins/source/bootimg-efi.py 
> b/scripts/lib/wic/plugins/source/bootimg-efi.py
> index 652323f..9b324d3 100644
> --- a/scripts/lib/wic/plugins/source/bootimg-efi.py
> +++ b/scripts/lib/wic/plugins/source/bootimg-efi.py
> @@ -72,9 +72,14 @@ class BootimgEFIPlugin(SourcePlugin):
>  grubefi_conf += "menuentry '%s'{\n" % (title if title else 
> "boot")
>  
>  kernel = "/bzImage"
> +label = source_params.get('label')
>  
> -grubefi_conf += "linux %s root=%s rootwait %s\n" \
> -% (kernel, creator.rootdev, bootloader.append)
> +if label == "install-efi":
> +grubefi_conf += "linux %s LABEL=%s rootwait %s\n" \
> +% (kernel, label, bootloader.append)
> +else:
> +grubefi_conf += "linux %s root=%s rootwait %s\n" \
> +% (kernel, creator.rootdev, bootloader.append)

I could be missing something as I don't know the wider code but
wouldn't it make more sense to have:

label = source_params.get('label')
label_conf = "root=%s" % creator.rootdev
if label:
label_conf = "LABEL=%s" % label

grubefi_conf += "linux %s %s rootwait %s\n" \
% (kernel, label_conf,
bootloader.append)

Which would then allow custom labels rather than a special case magic 
value? (and also reduce code duplication)

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] nginx: fix kill path in nginx systemd unit file

2019-05-27 Thread nick83ola 
Thanks (and sorry again)

On Fri, 24 May 2019 at 17:27, akuster808  wrote:
>
>
>
> On 5/24/19 7:36 AM, Nicola Lunghi wrote:
> > Signed-off-by: Nicola Lunghi 
> > ---
> >  meta-webserver/recipes-httpd/nginx/files/nginx.service | 2 +-
> >  meta-webserver/recipes-httpd/nginx/nginx.inc   | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
>
> Wrong mailing list.
>
> please send to openembedded-de...@lists.openembedded.org
>
> >
> > diff --git a/meta-webserver/recipes-httpd/nginx/files/nginx.service 
> > b/meta-webserver/recipes-httpd/nginx/files/nginx.service
> > index c6fc0495f..9a6ca9651 100644
> > --- a/meta-webserver/recipes-httpd/nginx/files/nginx.service
> > +++ b/meta-webserver/recipes-httpd/nginx/files/nginx.service
> > @@ -8,7 +8,7 @@ PIDFile=/run/nginx/nginx.pid
> >  ExecStartPre=@SBINDIR@/nginx -t
> >  ExecStart=@SBINDIR@/nginx
> >  ExecReload=@SBINDIR@/nginx -s reload
> > -ExecStop=@BINDIR@/kill -s QUIT $MAINPID
> > +ExecStop=@BASE_BINDIR@/kill -s QUIT $MAINPID
> >  PrivateTmp=true
> >
> >  [Install]
> > diff --git a/meta-webserver/recipes-httpd/nginx/nginx.inc 
> > b/meta-webserver/recipes-httpd/nginx/nginx.inc
> > index 29e7efc14..c4c776e37 100644
> > --- a/meta-webserver/recipes-httpd/nginx/nginx.inc
> > +++ b/meta-webserver/recipes-httpd/nginx/nginx.inc
> > @@ -134,7 +134,7 @@ do_install () {
> >  sed -i -e 's,@SYSCONFDIR@,${sysconfdir},g' \
> >  -e 's,@LOCALSTATEDIR@,${localstatedir},g' \
> >  -e 's,@SBINDIR@,${sbindir},g' \
> > --e 's,@BINDIR@,${bindir},g' \
> > +-e 's,@BASE_BINDIR@,${base_bindir},g' \
> >  ${D}${systemd_unitdir}/system/nginx.service
> >  fi
> >  }
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] base.bbclass: add named SRCREVs to the sstate hash

2019-05-27 Thread Martin Jansa 
In those recipes which don't include SRCPV in PV (for whatever reason) we
usually add them explicitly with:
do_fetch[vardeps] += "SRCREV_common"
it's not ideal as people sometimes forget about this. Good practice is to
add this next to the SRCREV_FORMAT (if you set one, to clearly show which
revs are and aren't included).

On Mon, May 27, 2019 at 5:37 PM  wrote:

> Hi Christopher,
>
>
>
> Thank you for the feedback. Since SRCPV is not always enforced (correct me
> if I’m wrong), it seems easy to trip over this bug when just following the
> documentation on multiple named source uri’s (also if you purposely don’t
> want to include the secondary source revisions in the package version).
> I’ll give it another shot to make it more efficient. If it’s not expected
> to be an encounterable bug case you can ignore the patch.
>
>
>
> Thanks.
>
>
>
> Kind regards,
>
> Michael
>
>
>
> --
>
> *BMW Car IT GmbH*
> Michael Ho
> Spezialist Entwicklung – Build and Release Engineering
> Lise-Meitner-Straße 14
> 89081 Ulm
>
> Tel.: ­+49-731-37804-071
>
> Mobil: +49-152-54980-471
> Fax: +49-731-37804-001
> Mail: michael...@bmw-carit.de
> Web: http://www.bmw-carit.de
> -
> BMW Car IT GmbH
> Geschäftsführer: Kai-Uwe Balszuweit und Christian Salzmann
> Sitz und Registergericht: München HRB 134810
> -
>
>
>
>
>
> *From: *Christopher Larson 
> *Date: *Wednesday, 8 May 2019 at 5:17 pm
> *To: *"Ho Michael, JC-3UL" 
> *Cc: *Patches and discussions about the oe-core layer <
> openembedded-core@lists.openembedded.org>
> *Subject: *Re: [OE-core] [PATCH] base.bbclass: add named SRCREVs to the
> sstate hash
>
>
>
> Does SRCPV not already cover this in the majority of cases? SRCREV_FORMAT
> controls how the multiple revs end up in PV, and the change to PV results
> in rebuilding anyway. And iterating over d.keys() is inefficient, *if*
> you’re going to do this, operate on SRCREV, gather up the name= parameters
> from scm urls, and use that to drive it.
>
>
>
> On Wed, May 8, 2019 at 7:10 AM Michael Ho  wrote:
>
> Several fetchers support named sources that require setting a SRCREV with
> the source name as a suffix. These named SRCREV variables are not captured
> in the sstate hash calculation because they're only referenced within the
> bitbake fetcher function.
>
> Add a snippet to the base.bbclass anonymous python to add all named SRCREV
> variables to the vardeps of do_fetch to capture them in the sstate hash
> calculation.
>
> Testing of the bug can be shown by running the following bitbake commands
> with this patch set not applied:
>
> bitbake vulkan-demos | tee
> sed -i 's/SRCREV_gli = ".*"/SRCREV_gli = "xxx"/' \
>   ../meta/recipes-graphics/vulkan/vulkan-demos_git.bb
> bitbake vulkan-demos | tee;
>
> Results in no errors despite a broken SRCREV because the vulkan-demos is
> considered unchanged.
>
> After applying this patch the above commands instead result in a fetcher
> error which is correct.
> ---
>  meta/classes/base.bbclass | 10 ++
>  1 file changed, 10 insertions(+)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index 1636c6e..84a27f5 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -638,6 +638,16 @@ python () {
>
>  if needsrcrev:
>  d.setVar("SRCPV", "${@bb.fetch2.get_srcrev(d)}")
> +# Gather all SRCREV_* references to add to the sstate hash
> calculation
> +# This may capture SRCREVs not used but it's difficult to try to
> restrict it
> +# to only what is needed
> +for dkey in d.keys():
> +if dkey.startswith("SRCREV_"):
> +# This anonymous python snippet is called multiple times
> so we
> +# need to be careful to not double up the appends here
> and cause
> +# the base hash to mismatch the task hash
> +if dkey not in (d.getVarFlag("do_fetch", "vardeps") or
> '').split():
> +d.appendVarFlag("do_fetch", "vardeps", "
> {}".format(dkey))
>
>  set_packagetriplet(d)
>
> --
> 2.7.4
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
>
> --
>
> Christopher Larson
> kergoth at gmail dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Senior Software Engineer, Mentor Graphics
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH v2] base.bbclass: add named SRCREVs to the sstate hash

2019-05-27 Thread Michael Ho 
Several fetchers support named sources that require setting a SRCREV with
the source name as a suffix. These named SRCREV variables are not captured
in the sstate hash calculation because they're only referenced within the
bitbake fetcher function. Several recipes avoid this bug by adding the
different SRCREVs to their packaging versioning but this is not enforced so
it is very trivial to trip this bug case.

Add a snippet to the base.bbclass anonymous python to add all named SRCREV
variables to the vardeps of do_fetch to capture them in the sstate hash
calculation.

Testing of the bug can be shown by running the following bitbake commands
with this patch set not applied:

bitbake vulkan-demos | tee
sed -i 's/SRCREV_gli = ".*"/SRCREV_gli = "xxx"/' \
  ../meta/recipes-graphics/vulkan/vulkan-demos_git.bb
bitbake vulkan-demos | tee;

The above results in no errors despite a broken SRCREV because the recipe  is
considered unchanged by the bitbake sstate hash.

After applying this patch the above commands instead result in a fetcher
error which is correct.
---
 meta/classes/base.bbclass | 12 
 1 file changed, 12 insertions(+)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 1636c6e..25d5fff 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -639,6 +639,18 @@ python () {
 if needsrcrev:
 d.setVar("SRCPV", "${@bb.fetch2.get_srcrev(d)}")
 
+# Gather all named SRCREVs to add to the sstate hash calculation
+# This anonymous python snippet is called multiple times so we
+# need to be careful to not double up the appends here and cause
+# the base hash to mismatch the task hash
+for uri in srcuri.split():
+parm = bb.fetch.decodeurl(uri)[5]
+uri_names = parm.get("name", "").split(",")
+for uri_name in filter(None, uri_names):
+srcrev_name = "SRCREV_{}".format(uri_name)
+if srcrev_name not in (d.getVarFlag("do_fetch", "vardeps") or 
"").split():
+d.appendVarFlag("do_fetch", "vardeps", " 
{}".format(srcrev_name))
+
 set_packagetriplet(d)
 
 # 'multimachine' handling
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] base.bbclass: add named SRCREVs to the sstate hash

2019-05-27 Thread Michael.Ho 
Hi Christopher,

Thank you for the feedback. Since SRCPV is not always enforced (correct me if 
I’m wrong), it seems easy to trip over this bug when just following the 
documentation on multiple named source uri’s (also if you purposely don’t want 
to include the secondary source revisions in the package version). I’ll give it 
another shot to make it more efficient. If it’s not expected to be an 
encounterable bug case you can ignore the patch.

Thanks.

Kind regards,
Michael

--
BMW Car IT GmbH
Michael Ho
Spezialist Entwicklung – Build and Release Engineering
Lise-Meitner-Straße 14
89081 Ulm

Tel.: ­+49-731-37804-071
Mobil: +49-152-54980-471
Fax: +49-731-37804-001
Mail: michael...@bmw-carit.de
Web: http://www.bmw-carit.de
-
BMW Car IT GmbH
Geschäftsführer: Kai-Uwe Balszuweit und Christian Salzmann
Sitz und Registergericht: München HRB 134810
-


From: Christopher Larson 
Date: Wednesday, 8 May 2019 at 5:17 pm
To: "Ho Michael, JC-3UL" 
Cc: Patches and discussions about the oe-core layer 

Subject: Re: [OE-core] [PATCH] base.bbclass: add named SRCREVs to the sstate 
hash

Does SRCPV not already cover this in the majority of cases? SRCREV_FORMAT 
controls how the multiple revs end up in PV, and the change to PV results in 
rebuilding anyway. And iterating over d.keys() is inefficient, *if* you’re 
going to do this, operate on SRCREV, gather up the name= parameters from scm 
urls, and use that to drive it.

On Wed, May 8, 2019 at 7:10 AM Michael Ho 
mailto:michael...@bmw.de>> wrote:
Several fetchers support named sources that require setting a SRCREV with
the source name as a suffix. These named SRCREV variables are not captured
in the sstate hash calculation because they're only referenced within the
bitbake fetcher function.

Add a snippet to the base.bbclass anonymous python to add all named SRCREV
variables to the vardeps of do_fetch to capture them in the sstate hash
calculation.

Testing of the bug can be shown by running the following bitbake commands
with this patch set not applied:

bitbake vulkan-demos | tee
sed -i 's/SRCREV_gli = ".*"/SRCREV_gli = "xxx"/' \
  
../meta/recipes-graphics/vulkan/vulkan-demos_git.bb
bitbake vulkan-demos | tee;

Results in no errors despite a broken SRCREV because the vulkan-demos is
considered unchanged.

After applying this patch the above commands instead result in a fetcher
error which is correct.
---
 meta/classes/base.bbclass | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 1636c6e..84a27f5 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -638,6 +638,16 @@ python () {

 if needsrcrev:
 d.setVar("SRCPV", "${@bb.fetch2.get_srcrev(d)}")
+# Gather all SRCREV_* references to add to the sstate hash calculation
+# This may capture SRCREVs not used but it's difficult to try to 
restrict it
+# to only what is needed
+for dkey in d.keys():
+if dkey.startswith("SRCREV_"):
+# This anonymous python snippet is called multiple times so we
+# need to be careful to not double up the appends here and 
cause
+# the base hash to mismatch the task hash
+if dkey not in (d.getVarFlag("do_fetch", "vardeps") or 
'').split():
+d.appendVarFlag("do_fetch", "vardeps", " {}".format(dkey))

 set_packagetriplet(d)

--
2.7.4

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


--
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 1/2] Revert "pigz: pigz is not gzip"

2019-05-27 Thread Anuj Mittal 
This reverts commit a54c59f2a24904daffe51582b6863eebd071db0d.

The compatibility issues have since been resolved [1][2] and pigz 2.4
annoucement also states that this can be considered as a drop-in
replacemment [3] now.

[1] 
https://github.com/madler/pigz/commit/33c140e5fdc5cd639d1e7cc3c5e52ec016aa8a65
[2] 
https://github.com/madler/pigz/commit/6fda8570f633ec582ba72ea00dad2bbac825bc17
[3] https://zlib.net/pipermail/pigz-announce_zlib.net/2017-December/28.html

Signed-off-by: Anuj Mittal 
---
 .../conf/distro/include/default-providers.inc |  1 +
 meta/recipes-extended/pigz/pigz_2.4.bb| 21 ++-
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/meta/conf/distro/include/default-providers.inc 
b/meta/conf/distro/include/default-providers.inc
index 21419038f0..2be3378773 100644
--- a/meta/conf/distro/include/default-providers.inc
+++ b/meta/conf/distro/include/default-providers.inc
@@ -42,6 +42,7 @@ PREFERRED_PROVIDER_opkg ?= "opkg"
 PREFERRED_PROVIDER_opkg-native ?= "opkg-native"
 PREFERRED_PROVIDER_nativesdk-opkg ?= "nativesdk-opkg"
 PREFERRED_PROVIDER_console-tools ?= "kbd"
+PREFERRED_PROVIDER_gzip-native ?= "pigz-native"
 PREFERRED_PROVIDER_udev ?= 
"${@bb.utils.contains('DISTRO_FEATURES','systemd','systemd','eudev',d)}"
 PREFERRED_RPROVIDER_bluez-hcidump ?= 
"${@bb.utils.contains('DISTRO_FEATURES','bluetooth 
bluez5','bluez5','bluez-hcidump',d)}"
 # Alternative is ltp-ddt in meta-oe: 
meta-oe/recipes-devtools/ltp-ddt/ltp-ddt_0.0.4.bb
diff --git a/meta/recipes-extended/pigz/pigz_2.4.bb 
b/meta/recipes-extended/pigz/pigz_2.4.bb
index 6e6da9c3c5..89ad82ea91 100644
--- a/meta/recipes-extended/pigz/pigz_2.4.bb
+++ b/meta/recipes-extended/pigz/pigz_2.4.bb
@@ -12,6 +12,8 @@ SRC_URI = "http://zlib.net/${BPN}/fossils/${BP}.tar.gz;
 SRC_URI[md5sum] = "def2f6e19d9d8231445adc1349d346df"
 SRC_URI[sha256sum] = 
"a4f816222a7b4269bd232680590b579ccc72591f1bb5adafcd7208ca77e14f73"
 # Point this at the homepage in case /fossils/ isn't updated
+PROVIDES_class-native += "gzip-native"
+
 UPSTREAM_CHECK_URI = "http://zlib.net/${BPN}/;
 UPSTREAM_CHECK_REGEX = "pigz-(?P.*)\.tar"
 
@@ -19,7 +21,9 @@ DEPENDS = "zlib"
 
 EXTRA_OEMAKE = "-e MAKEFLAGS="
 
-do_install() {
+inherit update-alternatives
+
+do_install_class-target() {
# Install files into /bin (FHS), which is typical place for gzip
install -d ${D}${base_bindir}
install ${B}/pigz ${D}${base_bindir}/pigz
@@ -27,4 +31,19 @@ do_install() {
ln -nsf pigz ${D}${base_bindir}/pigzcat
 }
 
+do_install() {
+   install -d ${D}${bindir}
+   install ${B}/pigz ${D}${bindir}/gzip
+   ln -nsf gzip ${D}${bindir}/gunzip
+   ln -nsf gzip ${D}${bindir}/zcat
+}
+
+ALTERNATIVE_PRIORITY = "80"
+ALTERNATIVE_${PN} = "gunzip gzip zcat"
+ALTERNATIVE_${PN}_class-nativesdk = ""
+ALTERNATIVE_LINK_NAME[gunzip] = "${base_bindir}/gunzip"
+ALTERNATIVE_LINK_NAME[gzip] = "${base_bindir}/gzip"
+ALTERNATIVE_LINK_NAME[zcat] = "${base_bindir}/zcat"
+ALTERNATIVE_TARGET = "${base_bindir}/pigz"
+
 BBCLASSEXTEND = "native nativesdk"
-- 
2.20.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 2/2] Revert "image_types: use pigz to create .gz files"

2019-05-27 Thread Anuj Mittal 
This reverts commit a559ffab30b7b45849ace023808c1fb20811d43d.

This is not needed now that pigz has been marked as a drop-in
replacement.

Signed-off-by: Anuj Mittal 
---
 meta/classes/image_types.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index 1c44ec4a80..fd98a7d1bd 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -284,7 +284,7 @@ COMPRESSIONTYPES ?= ""
 
 CONVERSIONTYPES = "gz bz2 lzma xz lz4 lzo zip sum md5sum sha1sum sha224sum 
sha256sum sha384sum sha512sum bmap u-boot vmdk vdi qcow2 base64 
${COMPRESSIONTYPES}"
 CONVERSION_CMD_lzma = "lzma -k -f -7 ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"
-CONVERSION_CMD_gz = "pigz -f -9 -n -c 
${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > 
${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz"
+CONVERSION_CMD_gz = "gzip -f -9 -n -c 
${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > 
${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz"
 CONVERSION_CMD_bz2 = "pbzip2 -f -k ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}"
 CONVERSION_CMD_xz = "xz -f -k -c ${XZ_COMPRESSION_LEVEL} ${XZ_DEFAULTS} 
--check=${XZ_INTEGRITY_CHECK} ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} > 
${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.xz"
 CONVERSION_CMD_lz4 = "lz4 -9 -z -l ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type} 
${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.lz4"
-- 
2.20.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] libpam: Upgrade 1.3.0 -> 1.3.1

2019-05-27 Thread Adrian Bunk 
ping

Thanks
Adrian

On Mon, May 20, 2019 at 07:30:52PM +0300, Adrian Bunk wrote:
> Remove patch applied upstream.
> Upstream tarball location changed.
> 
> Signed-off-by: Adrian Bunk 
> ---
>  ...libpam-xtests-remove-bash-dependency.patch | 226 --
>  .../pam/{libpam_1.3.0.bb => libpam_1.3.1.bb}  |   9 +-
>  2 files changed, 3 insertions(+), 232 deletions(-)
>  delete mode 100644 
> meta/recipes-extended/pam/libpam/libpam-xtests-remove-bash-dependency.patch
>  rename meta/recipes-extended/pam/{libpam_1.3.0.bb => libpam_1.3.1.bb} (95%)
> 
> diff --git 
> a/meta/recipes-extended/pam/libpam/libpam-xtests-remove-bash-dependency.patch 
> b/meta/recipes-extended/pam/libpam/libpam-xtests-remove-bash-dependency.patch
> deleted file mode 100644
> index 680029ae0d..00
> --- 
> a/meta/recipes-extended/pam/libpam/libpam-xtests-remove-bash-dependency.patch
> +++ /dev/null
> @@ -1,226 +0,0 @@
> -From 555407ff6e2f742df64ae93859f14a0fc1397829 Mon Sep 17 00:00:00 2001
> -From: Wenzong Fan 
> -Date: Fri, 12 Sep 2014 05:35:05 -0400
> -Subject: [PATCH] libpam/xtests: remove bash dependency
> -
> -There's not bash specific syntax in the xtest scripts:
> -
> -  # after below patches applied:
> -  $ cd Linux-PAM-1.1.6/xtests
> -  $ checkbashisms *.sh
> -  No output
> -
> -Just remove the runtime dependency to bash.
> -
> -Upstream-Status: Pending
> -
> -Signed-off-by: Wenzong Fan 
> 
> - xtests/run-xtests.sh |2 +-
> - xtests/tst-pam_access1.sh|2 +-
> - xtests/tst-pam_access2.sh|2 +-
> - xtests/tst-pam_access3.sh|2 +-
> - xtests/tst-pam_access4.sh|2 +-
> - xtests/tst-pam_assemble_line1.sh |2 +-
> - xtests/tst-pam_group1.sh |2 +-
> - xtests/tst-pam_limits1.sh|2 +-
> - xtests/tst-pam_pwhistory1.sh |2 +-
> - xtests/tst-pam_substack1.sh  |2 +-
> - xtests/tst-pam_substack2.sh  |2 +-
> - xtests/tst-pam_substack3.sh  |2 +-
> - xtests/tst-pam_substack4.sh  |2 +-
> - xtests/tst-pam_substack5.sh  |2 +-
> - xtests/tst-pam_succeed_if1.sh|2 +-
> - xtests/tst-pam_unix1.sh  |2 +-
> - xtests/tst-pam_unix2.sh  |2 +-
> - xtests/tst-pam_unix3.sh  |2 +-
> - xtests/tst-pam_unix4.sh  |2 +-
> - 19 files changed, 19 insertions(+), 19 deletions(-)
> -
> -diff --git a/xtests/run-xtests.sh b/xtests/run-xtests.sh
> -index 3a89057..1cf8684 100755
>  a/xtests/run-xtests.sh
> -+++ b/xtests/run-xtests.sh
> -@@ -1,4 +1,4 @@
> --#!/bin/bash
> -+#!/bin/sh
> - 
> - SRCDIR=$1
> - shift 1
> -diff --git a/xtests/tst-pam_access1.sh b/xtests/tst-pam_access1.sh
> -index 180d256..70521d2 100755
>  a/xtests/tst-pam_access1.sh
> -+++ b/xtests/tst-pam_access1.sh
> -@@ -1,4 +1,4 @@
> --#!/bin/bash
> -+#!/bin/sh
> - 
> - /usr/sbin/groupadd tstpamaccess
> - /usr/sbin/useradd -G tstpamaccess -p '!!' tstpamaccess1
> -diff --git a/xtests/tst-pam_access2.sh b/xtests/tst-pam_access2.sh
> -index 0a30275..7e3e60f 100755
>  a/xtests/tst-pam_access2.sh
> -+++ b/xtests/tst-pam_access2.sh
> -@@ -1,4 +1,4 @@
> --#!/bin/bash
> -+#!/bin/sh
> - 
> - /usr/sbin/groupadd tstpamaccess
> - /usr/sbin/useradd -p '!!' tstpamaccess2
> -diff --git a/xtests/tst-pam_access3.sh b/xtests/tst-pam_access3.sh
> -index 348e0c3..3630e2e 100755
>  a/xtests/tst-pam_access3.sh
> -+++ b/xtests/tst-pam_access3.sh
> -@@ -1,4 +1,4 @@
> --#!/bin/bash
> -+#!/bin/sh
> - 
> - /usr/sbin/useradd -p '!!' tstpamaccess3
> - ./tst-pam_access3
> -diff --git a/xtests/tst-pam_access4.sh b/xtests/tst-pam_access4.sh
> -index 61e7b44..4538df4 100755
>  a/xtests/tst-pam_access4.sh
> -+++ b/xtests/tst-pam_access4.sh
> -@@ -1,4 +1,4 @@
> --#!/bin/bash
> -+#!/bin/sh
> - 
> - /usr/sbin/useradd -p '!!' tstpamaccess4
> - ./tst-pam_access4
> -diff --git a/xtests/tst-pam_assemble_line1.sh 
> b/xtests/tst-pam_assemble_line1.sh
> -index 248d47e..dc2a675 100755
>  a/xtests/tst-pam_assemble_line1.sh
> -+++ b/xtests/tst-pam_assemble_line1.sh
> -@@ -1,3 +1,3 @@
> --#!/bin/bash
> -+#!/bin/sh
> - 
> - exec ./tst-pam_authfail tst-pam_assemble_line1
> -diff --git a/xtests/tst-pam_group1.sh b/xtests/tst-pam_group1.sh
> -index b76377f..44faca9 100755
>  a/xtests/tst-pam_group1.sh
> -+++ b/xtests/tst-pam_group1.sh
> -@@ -1,4 +1,4 @@
> --#!/bin/bash
> -+#!/bin/sh
> - 
> - /usr/sbin/groupadd tstpamgrpg
> - /usr/sbin/useradd -p '!!' tstpamgrp
> -diff --git a/xtests/tst-pam_limits1.sh b/xtests/tst-pam_limits1.sh
> -index 4faa822..32c021d 100755
>  a/xtests/tst-pam_limits1.sh
> -+++ b/xtests/tst-pam_limits1.sh
> -@@ -1,4 +1,4 @@
> --#!/bin/bash
> -+#!/bin/sh
> - 
> - /usr/sbin/useradd -p '!!' tstpamlimits
> - ./tst-pam_limits1
> -diff --git a/xtests/tst-pam_pwhistory1.sh b/xtests/tst-pam_pwhistory1.sh
> -index ddb3b8b..0f212e2 100644
>  a/xtests/tst-pam_pwhistory1.sh
> -+++ b/xtests/tst-pam_pwhistory1.sh
> -@@ -1,4 +1,4 @@
> --#!/bin/bash
> -+#!/bin/sh
> - 
> - /usr/sbin/useradd tstpampwhistory
> -

Re: [OE-core] [oe][meta-webserver][PATCH 1/2] nginx: update to version 1.17.0

2019-05-27 Thread nick83ola 
Done

Thanks
Nicola Lunghi

On Fri, 24 May 2019 at 17:14, Randy MacLeod  wrote:
>
> Nicola,
>
> Please re-send to:
> openembedded-de...@lists.openembedded.org
> rather than:
> openembedded-core@lists.openembedded.org
>
> Did you read:
>   https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
> If so maybe we need to improve the howto.
>
> Thanks.
> ../Randy
>
> On 5/24/19 10:44 AM, Nicola Lunghi wrote:
> > Signed-off-by: Nicola Lunghi 
> > ---
> >   meta-webserver/recipes-httpd/nginx/nginx_1.15.7.bb | 6 --
> >   meta-webserver/recipes-httpd/nginx/nginx_1.17.0.bb | 6 ++
> >   2 files changed, 6 insertions(+), 6 deletions(-)
> >   delete mode 100644 meta-webserver/recipes-httpd/nginx/nginx_1.15.7.bb
> >   create mode 100644 meta-webserver/recipes-httpd/nginx/nginx_1.17.0.bb
> >
> > diff --git a/meta-webserver/recipes-httpd/nginx/nginx_1.15.7.bb 
> > b/meta-webserver/recipes-httpd/nginx/nginx_1.15.7.bb
> > deleted file mode 100644
> > index 5e6dc33e9..0
> > --- a/meta-webserver/recipes-httpd/nginx/nginx_1.15.7.bb
> > +++ /dev/null
> > @@ -1,6 +0,0 @@
> > -require nginx.inc
> > -
> > -LIC_FILES_CHKSUM = "file://LICENSE;md5=3691402cc54ce09f800ca348634a2dfe"
> > -
> > -SRC_URI[md5sum] = "719b2e3d416f111fecc9db6625553658"
> > -SRC_URI[sha256sum] = 
> > "8f22ea2f6c0e0a221b6ddc02b6428a3ff708e2ad55f9361102b1c9f4142bdf93"
> > diff --git a/meta-webserver/recipes-httpd/nginx/nginx_1.17.0.bb 
> > b/meta-webserver/recipes-httpd/nginx/nginx_1.17.0.bb
> > new file mode 100644
> > index 0..8774a87ff
> > --- /dev/null
> > +++ b/meta-webserver/recipes-httpd/nginx/nginx_1.17.0.bb
> > @@ -0,0 +1,6 @@
> > +require nginx.inc
> > +
> > +LIC_FILES_CHKSUM = "file://LICENSE;md5=52e384aaac868b755b93ad5535e2d075"
> > +
> > +SRC_URI[md5sum] = "56767fd62302508295b31adc48b99a59"
> > +SRC_URI[sha256sum] = 
> > "e21b5d06cd53e86afb94f0b3678e0abb0c0f011433471fa3d895cefa65ae0fab"
> >
>
>
> --
> # Randy MacLeod
> # Wind River Linux
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] OE-Core status with gcc9

2019-05-27 Thread Khem Raj 
On Sun, May 26, 2019 at 10:17 AM Khem Raj  wrote:
>
> On Mon, May 13, 2019 at 8:39 PM Khem Raj  wrote:
> >
> > On Sun, May 12, 2019 at 1:14 PM Khem Raj  wrote:
> > >
> > > On Sun, May 12, 2019 at 6:21 AM Richard Purdie
> > >  wrote:
> > > >
> > > > I've run some tests and think we're now down to one remaining issue
> > > > with gcc 9:
> > > >
> > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/579
> > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/55/builds/145
> > > >
> > >
> > > Assembler is not liking what gcc9 is generating
> > >
> > > HOSTCC scripts/kconfig/conf.o
> > > /tmp/ccnMW5be.s: Assembler messages:
> > > /tmp/ccnMW5be.s: Internal error (Segmentation fault).
> > >
> > > I wonder if its a common case or specific here?
> > > I will try to reproduce it as well
> > >
> >
> > I am able to get a .s file which crashes assembler on
> > qemu. Same file assembles ok with mips cross assembler
> > so next I want to get hold of a mips hardware and try
> > it on the real h/w, meanwhile if someone has easy access
> > to mips and can load core-image-sato-sdk on it then I can
> > provide the asm file which crashes assembler
> >
> got some more time to narrow it down.
> works with musl+gcc-9
> works with glibc+clang-8
> works with musl+Clang-8
>
> so only glibc+gcc-9 combo is one which exhibits the issue
>

I have sent a workaound for this which we can try out.
https://patchwork.openembedded.org/patch/161674/

> > > > which is a kernel "make scripts" segfaulting on target on mips and
> > > > hence failing to build kernel modules. If we can get that one fixed
> > > > we're good from an OE-Core perspective to move to gcc 9.
> > > >
> > > > I have to recognise the work Khem has put in getting us this close!
> > > >
> > > > Cheers,
> > > >
> > > > Richard
> > > >
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] musl: Upgrade to master tip

2019-05-27 Thread Khem Raj 
Changes
https://git.musl-libc.org/cgit/musl/log/?qt=range=65c8be380431eebe4d70d130bd38563f8df9a7d7..ac304227bb3ea1787d581f17d76a5f5f3abff51f

Signed-off-by: Khem Raj 
---
 meta/recipes-core/musl/musl_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/musl/musl_git.bb 
b/meta/recipes-core/musl/musl_git.bb
index 1e324804e1..a7fae4a656 100644
--- a/meta/recipes-core/musl/musl_git.bb
+++ b/meta/recipes-core/musl/musl_git.bb
@@ -4,7 +4,7 @@
 require musl.inc
 inherit linuxloader
 
-SRCREV = "65c8be380431eebe4d70d130bd38563f8df9a7d7"
+SRCREV = "ac304227bb3ea1787d581f17d76a5f5f3abff51f"
 
 BASEVER = "1.1.22"
 
-- 
2.21.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] binutils: Workaround mips assembler crash on target

2019-05-27 Thread Khem Raj 
assembler ends up crashing on target sometimes due to
segfaults in libbfd, therefore avoid using -O2 for now

Signed-off-by: Khem Raj 
---
 meta/recipes-devtools/binutils/binutils_2.32.bb | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/meta/recipes-devtools/binutils/binutils_2.32.bb 
b/meta/recipes-devtools/binutils/binutils_2.32.bb
index 51a9748906..89315915c4 100644
--- a/meta/recipes-devtools/binutils/binutils_2.32.bb
+++ b/meta/recipes-devtools/binutils/binutils_2.32.bb
@@ -20,6 +20,11 @@ EXTRA_OECONF_class-native = "--enable-targets=all \
  --enable-install-libbfd \
  --disable-werror"
 
+# gcc9.0 end up mis-compiling libbfd.so with O2 which then crashes on target
+# So remove -O2 and use -Os as workaround
+SELECTED_OPTIMIZATION_remove_mipsarch = "-O2"
+SELECTED_OPTIMIZATION_append_mipsarch = " -Os"
+
 do_install_class-native () {
autotools_do_install
 
@@ -47,3 +52,4 @@ PACKAGE_BEFORE_PN += "libbfd"
 FILES_libbfd = "${libdir}/libbfd-*.so"
 
 BBCLASSEXTEND = "native nativesdk"
+
-- 
2.21.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core