[OE-core] [PATCH 2/2] runqemu: add an option to enable guest-agent virtio device

2022-04-07 Thread Brenda Streiff
Add support to the runqemu script for a new option, 'guestagent', that
enables the virtio serial port for host-to-guest communication.

Signed-off-by: Brenda Streiff 
---
 scripts/runqemu | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/scripts/runqemu b/scripts/runqemu
index 2f77a7bd0f..c25764b28e 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -82,6 +82,7 @@ of the following environment variables (in any order):
 kvm-vhost - enable KVM with vhost when running x86/x86_64 (VT-capable CPU 
required)
 publicvnc - enable a VNC server open to all hosts
 audio - enable audio
+guestagent - enable guest agent communication
 [*/]ovmf* - OVMF firmware file or base name for booting with UEFI
   tcpserial= - specify tcp serial port number
   qemuparams= - specify custom parameters to QEMU
@@ -214,6 +215,8 @@ class BaseConfig(object):
 self.cleaned = False
 # Files to cleanup after run
 self.cleanup_files = []
+self.guest_agent = False
+self.guest_agent_sockpath = '/tmp/qga.sock'
 
 def acquire_taplock(self, error=True):
 logger.debug("Acquiring lockfile %s..." % self.taplock)
@@ -522,6 +525,10 @@ class BaseConfig(object):
 self.snapshot = True
 elif arg == 'publicvnc':
 self.qemu_opt_script += ' -vnc :0'
+elif arg == 'guestagent':
+self.guest_agent = True
+elif arg.startswith('guestagent-sockpath='):
+self.guest_agent_sockpath = '%s' % 
arg[len('guestagent-sockpath='):]
 elif arg.startswith('tcpserial='):
 self.tcpserial_portnum = '%s' % arg[len('tcpserial='):]
 elif arg.startswith('qemuparams='):
@@ -1348,6 +1355,12 @@ class BaseConfig(object):
 raise RunQemuError("Failed to boot, QB_SYSTEM_NAME is NULL!")
 self.qemu_system = qemu_system
 
+def setup_guest_agent(self):
+if self.guest_agent == True:
+self.qemu_opt += ' -chardev socket,path=' + 
self.guest_agent_sockpath + ',server,nowait,id=qga0 '
+self.qemu_opt += ' -device virtio-serial '
+self.qemu_opt += ' -device 
virtserialport,chardev=qga0,name=org.qemu.guest_agent.0 '
+
 def setup_vga(self):
 if self.nographic == True:
 if self.sdl == True:
@@ -1459,6 +1472,7 @@ class BaseConfig(object):
 if self.snapshot:
 self.qemu_opt += " -snapshot"
 
+self.setup_guest_agent()
 self.setup_serial()
 self.setup_vga()
 
-- 
2.20.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164143): 
https://lists.openembedded.org/g/openembedded-core/message/164143
Mute This Topic: https://lists.openembedded.org/mt/90321829/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 1/2] qemu: split out qemu-guest-agent, add startup scripts

2022-04-07 Thread Brenda Streiff
Split out the QEMU guest agent into a separate package. The agent is
intended to be installed within a QEMU VM guest where a user is likely
to not want to have the rest of the QEMU installation within it.

Additionally, an initscript, udev rules file, and systemd unit file are
added to the package so that the guest agent can start automatically;
the former two come from Debian's packaging for qemu-guest-agent.

Signed-off-by: Brenda Streiff 
---
 meta/recipes-devtools/qemu/qemu.inc   | 35 +++-
 .../qemu/qemu/qemu-guest-agent.init   | 84 +++
 .../qemu/qemu/qemu-guest-agent.udev   |  2 +
 3 files changed, 120 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/qemu/qemu/qemu-guest-agent.init
 create mode 100644 meta/recipes-devtools/qemu/qemu/qemu-guest-agent.udev

diff --git a/meta/recipes-devtools/qemu/qemu.inc 
b/meta/recipes-devtools/qemu/qemu.inc
index 9f2fa4322e..bd1d1ea010 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -9,7 +9,7 @@ LICENSE = "GPL-2.0-only & LGPL-2.1-only"
 RDEPENDS:${PN}-ptest = "bash"
 
 require qemu-targets.inc
-inherit pkgconfig ptest python3-dir
+inherit pkgconfig ptest python3-dir update-rc.d systemd
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \
 
file://COPYING.LIB;endline=24;md5=8c5efda6cf1e1b03dcfd0e6c0d271c7f"
@@ -32,6 +32,8 @@ SRC_URI = "https://download.qemu.org/${BPN}-${PV}.tar.xz \

file://0001-Define-MAP_SYNC-and-MAP_SHARED_VALIDATE-on-needed-li.patch \

file://0001-vhost-vsock-detach-the-virqueue-element-in-case-of-e.patch \

file://0002-virtio-net-fix-map-leaking-on-error-during-receive.patch \
+   file://qemu-guest-agent.init \
+   file://qemu-guest-agent.udev \
"
 UPSTREAM_CHECK_REGEX = "qemu-(?P\d+(\.\d+)+)\.tar"
 
@@ -127,6 +129,20 @@ do_configure[cleandirs] += "${B}"
 do_install () {
export STRIP=""
oe_runmake 'DESTDIR=${D}' install
+
+   # If we built the guest agent, also install startup/udev rules
+   if [ -e "${D}${bindir}/qemu-ga" ]; then
+   install -d ${D}${sysconfdir}/init.d/
+   install -m 0755 ${WORKDIR}/qemu-guest-agent.init 
${D}${sysconfdir}/init.d/qemu-guest-agent
+   sed -i 's:@bindir@:${bindir}:' 
${D}${sysconfdir}/init.d/qemu-guest-agent
+
+   install -d ${D}${sysconfdir}/udev/rules.d/
+   install -m 0644 ${WORKDIR}/qemu-guest-agent.udev 
${D}${sysconfdir}/udev/rules.d/60-qemu-guest-agent.rules
+
+   install -d ${D}${systemd_unitdir}/system/
+   install -m 0644 ${S}/contrib/systemd/qemu-guest-agent.service 
${D}${systemd_unitdir}/system
+   sed -i -e 's,-/usr/bin/,-${bindir}/,g' 
${D}${systemd_unitdir}/system/qemu-guest-agent.service
+   fi
 }
 
 # The following fragment will create a wrapper for qemu-mips user emulation
@@ -199,3 +215,20 @@ PACKAGECONFIG[selinux] = 
"--enable-selinux,--disable-selinux"
 INSANE_SKIP:${PN} = "arch"
 
 FILES:${PN} += "${datadir}/icons"
+
+# Put the guest agent in a separate package
+PACKAGES =+ "${PN}-guest-agent"
+SUMMARY:${PN}-guest-agent = "QEMU guest agent"
+FILES:${PN}-guest-agent += " \
+${bindir}/qemu-ga \
+${sysconfdir}/udev/rules.d/60-qemu-guest-agent.rules \
+${sysconfdir}/init.d/qemu-guest-agent \
+${systemd_unitdir}/system/qemu-guest-agent.service \
+"
+
+INITSCRIPT_PACKAGES = "${PN}-guest-agent"
+INITSCRIPT_NAME:${PN}-guest-agent = "qemu-guest-agent"
+INITSCRIPT_PARAMS:${PN}-guest-agent = "defaults"
+
+SYSTEMD_PACKAGES = "${PN}-guest-agent"
+SYSTEMD_SERVICE:${PN}-guest-agent = "${PN}-guest-agent.service"
diff --git a/meta/recipes-devtools/qemu/qemu/qemu-guest-agent.init 
b/meta/recipes-devtools/qemu/qemu/qemu-guest-agent.init
new file mode 100644
index 00..493da0ef1a
--- /dev/null
+++ b/meta/recipes-devtools/qemu/qemu/qemu-guest-agent.init
@@ -0,0 +1,84 @@
+#!/bin/sh
+### BEGIN INIT INFO
+# Provides:qemu-guest-agent
+# Required-Start:  $remote_fs $syslog
+# Required-Stop:   $remote_fs $syslog
+# Default-Start:   2 3 4 5
+# Default-Stop:0 1 6
+# Short-Description:   QEMU Guest Agent
+### END INIT INFO
+#
+# Do not configure this file. Edit /etc/default/qemu-guest-agent
+#
+
+set -e
+
+. /etc/init.d/functions
+
+PATH=/sbin:/usr/sbin:/bin:/usr/bin
+DESC="QEMU Guest Agent"
+NAME=qemu-ga
+DAEMON=@bindir@/$NAME
+PIDFILE=/var/run/$NAME.pid
+
+# config
+DAEMON_ARGS=""
+# default transport
+TRANSPORT=virtio-serial:/dev/virtio-ports/org.qemu.guest_agent.0
+NO_START=0
+
+test ! -r /etc/default/qemu-guest-agent || . /etc/default/qemu-guest-agent
+test "$NO_START" = "0"