Re: [OE-core] ✗ patchtest: failure for ltp: make copyFrom scp command non-fatal (rev4)
Richard Purdie writes: > On Wed, 2020-08-05 at 15:23 -0400, Matthew wrote: >> My poky master is the latest commit (5e1bc3ef5a * net-tools: fix >> upstream version check) and my patch applies perfectly. Why is >> Patchwork complaining? > > FWIW I just tried to apply the patch and it doesn't apply for me :(. > > (Stripping trailing CRs from patch; use --binary to disable.) > patching file meta/lib/oeqa/core/target/ssh.py > (Stripping trailing CRs from patch; use --binary to disable.) > patching file meta/lib/oeqa/runtime/cases/ltp.py > Hunk #1 FAILED at 78. > 1 out of 1 hunk FAILED -- saving rejects to file > meta/lib/oeqa/runtime/cases/ltp.py.rej > > The difference is trailing whitespace which is present on the line: > > remote_src = "/opt/ltp/results/%s" % ltp_group > > but has been stripped in your patch. Arghh, I configured automatic remove trailing whitespace on save, that must be the issue. Patch with the whitespace sent. > > Cheers, > > Richard -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141259): https://lists.openembedded.org/g/openembedded-core/message/141259 Mute This Topic: https://lists.openembedded.org/mt/76013995/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCHv5] ltp: make copyFrom scp command non-fatal
[YOCTO #13802] Make the scp failure non-fatal so the ltp tests continue to run and the rest of the logs will be available to see afterwards. Signed-off-by: Mingde (Matthew) Zeng --- meta/lib/oeqa/core/target/ssh.py | 7 +-- meta/lib/oeqa/runtime/cases/ltp.py | 5 +++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/meta/lib/oeqa/core/target/ssh.py b/meta/lib/oeqa/core/target/ssh.py index 090b40a814..aefb576805 100644 --- a/meta/lib/oeqa/core/target/ssh.py +++ b/meta/lib/oeqa/core/target/ssh.py @@ -107,13 +107,16 @@ class OESSHTarget(OETarget): scpCmd = self.scp + [localSrc, remotePath] return self._run(scpCmd, ignore_status=False) -def copyFrom(self, remoteSrc, localDst): +def copyFrom(self, remoteSrc, localDst, warn_on_failure=False): """ Copy file from target. """ remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) scpCmd = self.scp + [remotePath, localDst] -return self._run(scpCmd, ignore_status=False) +(status, output) = self._run(scpCmd, ignore_status=warn_on_failure) +if warn_on_failure and status: +self.logger.warning("Copy returned non-zero exit status %d:\n%s" % (status, output)) +return (status, output) def copyDirTo(self, localSrc, remoteDst): """ diff --git a/meta/lib/oeqa/runtime/cases/ltp.py b/meta/lib/oeqa/runtime/cases/ltp.py index 6dc5ef22ad..a66d5d13d7 100644 --- a/meta/lib/oeqa/runtime/cases/ltp.py +++ b/meta/lib/oeqa/runtime/cases/ltp.py @@ -78,9 +78,10 @@ class LtpTest(LtpTestBase): # copy nice log from DUT dst = os.path.join(self.ltptest_log_dir, "%s" % ltp_group ) remote_src = "/opt/ltp/results/%s" % ltp_group -(status, output) = self.target.copyFrom(remote_src, dst) +(status, output) = self.target.copyFrom(remote_src, dst, True) msg = 'File could not be copied. Output: %s' % output -self.assertEqual(status, 0, msg=msg) +if status: +self.target.logger.warning(msg) parser = LtpParser() results, sections = parser.parse(dst) -- 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141258): https://lists.openembedded.org/g/openembedded-core/message/141258 Mute This Topic: https://lists.openembedded.org/mt/76015435/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] ✗ patchtest: failure for ltp: make copyFrom scp command non-fatal (rev4)
My poky master is the latest commit (5e1bc3ef5a * net-tools: fix upstream version check) and my patch applies perfectly. Why is Patchwork complaining? Patchwork writes: > == Series Details == > > Series: ltp: make copyFrom scp command non-fatal (rev4) > Revision: 4 > URL : https://patchwork.openembedded.org/series/25475/ > State : failure > > == Summary == > > > Thank you for submitting this patch series to OpenEmbedded Core. This is > an automated response. Several tests have been executed on the proposed > series by patchtest resulting in the following failures: > > > > * Issue Series does not apply on top of target branch > [test_series_merge_on_head] > Suggested fixRebase your series on top of targeted branch > Targeted branch master (currently at 10221e578f) > > > > If you believe any of these test results are incorrect, please reply to the > mailing list (openembedded-core@lists.openembedded.org) raising your concerns. > Otherwise we would appreciate you correcting the issues and submitting a new > version of the patchset if applicable. Please ensure you add/increment the > version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> > [PATCH v3] -> ...). > > --- > Guidelines: > https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines > Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest > Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141256): https://lists.openembedded.org/g/openembedded-core/message/141256 Mute This Topic: https://lists.openembedded.org/mt/76013995/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCHv4] ltp: make copyFrom scp command non-fatal
[YOCTO #13802] Make the scp failure non-fatal so the ltp tests continue to run and the rest of the logs will be available to see afterwards. Signed-off-by: Mingde (Matthew) Zeng --- meta/lib/oeqa/core/target/ssh.py | 7 +-- meta/lib/oeqa/runtime/cases/ltp.py | 5 +++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/meta/lib/oeqa/core/target/ssh.py b/meta/lib/oeqa/core/target/ssh.py index 090b40a814..aefb576805 100644 --- a/meta/lib/oeqa/core/target/ssh.py +++ b/meta/lib/oeqa/core/target/ssh.py @@ -107,13 +107,16 @@ class OESSHTarget(OETarget): scpCmd = self.scp + [localSrc, remotePath] return self._run(scpCmd, ignore_status=False) -def copyFrom(self, remoteSrc, localDst): +def copyFrom(self, remoteSrc, localDst, warn_on_failure=False): """ Copy file from target. """ remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) scpCmd = self.scp + [remotePath, localDst] -return self._run(scpCmd, ignore_status=False) +(status, output) = self._run(scpCmd, ignore_status=warn_on_failure) +if warn_on_failure and status: +self.logger.warning("Copy returned non-zero exit status %d:\n%s" % (status, output)) +return (status, output) def copyDirTo(self, localSrc, remoteDst): """ diff --git a/meta/lib/oeqa/runtime/cases/ltp.py b/meta/lib/oeqa/runtime/cases/ltp.py index 6dc5ef22ad..a66d5d13d7 100644 --- a/meta/lib/oeqa/runtime/cases/ltp.py +++ b/meta/lib/oeqa/runtime/cases/ltp.py @@ -78,9 +78,10 @@ class LtpTest(LtpTestBase): # copy nice log from DUT dst = os.path.join(self.ltptest_log_dir, "%s" % ltp_group ) remote_src = "/opt/ltp/results/%s" % ltp_group -(status, output) = self.target.copyFrom(remote_src, dst) +(status, output) = self.target.copyFrom(remote_src, dst, True) msg = 'File could not be copied. Output: %s' % output -self.assertEqual(status, 0, msg=msg) +if status: +self.target.logger.warning(msg) parser = LtpParser() results, sections = parser.parse(dst) -- 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141251): https://lists.openembedded.org/g/openembedded-core/message/141251 Mute This Topic: https://lists.openembedded.org/mt/76013802/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCHv3] ltp: make copyFrom scp command non-fatal
Richard Purdie writes: > On Wed, 2020-08-05 at 14:33 -0400, Mingde (Matthew) Zeng wrote: >> Richard Purdie writes: >> >> > On Wed, 2020-08-05 at 14:10 -0400, Matthew wrote: >> > > [YOCTO #13802] >> > > >> > > Make the scp failure non-fatal so the ltp tests continue to run and >> > > the rest of the logs will be available to see afterwards. >> > > >> > > Signed-off-by: Mingde (Matthew) Zeng >> > > --- >> > > meta/lib/oeqa/core/target/ssh.py | 7 +-- >> > > meta/lib/oeqa/runtime/cases/ltp.py | 2 +- >> > > 2 files changed, 6 insertions(+), 3 deletions(-) >> > > >> > > diff --git a/meta/lib/oeqa/core/target/ssh.py >> > > b/meta/lib/oeqa/core/target/ssh.py >> > > index 090b40a814..aefb576805 100644 >> > > --- a/meta/lib/oeqa/core/target/ssh.py >> > > +++ b/meta/lib/oeqa/core/target/ssh.py >> > > @@ -107,13 +107,16 @@ class OESSHTarget(OETarget): >> > > scpCmd = self.scp + [localSrc, remotePath] >> > > return self._run(scpCmd, ignore_status=False) >> > > >> > > -def copyFrom(self, remoteSrc, localDst): >> > > +def copyFrom(self, remoteSrc, localDst, warn_on_failure=False): >> > > """ >> > > Copy file from target. >> > > """ >> > > remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) >> > > scpCmd = self.scp + [remotePath, localDst] >> > > -return self._run(scpCmd, ignore_status=False) >> > > +(status, output) = self._run(scpCmd, >> > > ignore_status=warn_on_failure) >> > > +if warn_on_failure and status: >> > > +self.logger.warning("Copy returned non-zero exit status >> > > %d:\n%s" % (status, output)) >> > > +return (status, output) >> > > >> > > def copyDirTo(self, localSrc, remoteDst): >> > > """ >> > > diff --git a/meta/lib/oeqa/runtime/cases/ltp.py >> > > b/meta/lib/oeqa/runtime/cases/ltp.py >> > > index 6dc5ef22ad..da529ce482 100644 >> > > --- a/meta/lib/oeqa/runtime/cases/ltp.py >> > > +++ b/meta/lib/oeqa/runtime/cases/ltp.py >> > > @@ -78,7 +78,7 @@ class LtpTest(LtpTestBase): >> > > # copy nice log from DUT >> > > dst = os.path.join(self.ltptest_log_dir, "%s" % ltp_group ) >> > > remote_src = "/opt/ltp/results/%s" % ltp_group >> > > -(status, output) = self.target.copyFrom(remote_src, dst) >> > > +(status, output) = self.target.copyFrom(remote_src, dst, >> > > True) >> > > msg = 'File could not be copied. Output: %s' % output >> > > self.assertEqual(status, 0, msg=msg) >> > >> > The idea of this change is so "the ltp tests continue to run" yet if I >> > understand that code, a copy failure will throw the assertEqual and >> > hence stop the test so we don't get all the other logging information? >> >> When warn_on_failure=True, so is ignore_status. Then 'status and not >> ignore_status' evaluates to false, and 'raise AssertionError("Command >> '%s' returned non-zero exit ...)' will not run. > > Sure, but status will be non-zero and the code says: > > (status, output) = self.target.copyFrom(remote_src, dst, True) > msg = 'File could not be copied. Output: %s' % output > self.assertEqual(status, 0, msg=msg) > > so > > self.assertEqual(status, 0, msg=msg) > > will fail if copyFrom() fails? Right, I'll comment that line out as well. Also, I received the Patchwork email complaining a conflict, however I successfully applied my patch after git pulling a couple times, do you know what's wrong? > > Cheers, > > Richard -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141250): https://lists.openembedded.org/g/openembedded-core/message/141250 Mute This Topic: https://lists.openembedded.org/mt/76013023/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCHv3] ltp: make copyFrom scp command non-fatal
Richard Purdie writes: > On Wed, 2020-08-05 at 14:10 -0400, Matthew wrote: >> [YOCTO #13802] >> >> Make the scp failure non-fatal so the ltp tests continue to run and >> the rest of the logs will be available to see afterwards. >> >> Signed-off-by: Mingde (Matthew) Zeng >> --- >> meta/lib/oeqa/core/target/ssh.py | 7 +-- >> meta/lib/oeqa/runtime/cases/ltp.py | 2 +- >> 2 files changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/meta/lib/oeqa/core/target/ssh.py >> b/meta/lib/oeqa/core/target/ssh.py >> index 090b40a814..aefb576805 100644 >> --- a/meta/lib/oeqa/core/target/ssh.py >> +++ b/meta/lib/oeqa/core/target/ssh.py >> @@ -107,13 +107,16 @@ class OESSHTarget(OETarget): >> scpCmd = self.scp + [localSrc, remotePath] >> return self._run(scpCmd, ignore_status=False) >> >> -def copyFrom(self, remoteSrc, localDst): >> +def copyFrom(self, remoteSrc, localDst, warn_on_failure=False): >> """ >> Copy file from target. >> """ >> remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) >> scpCmd = self.scp + [remotePath, localDst] >> -return self._run(scpCmd, ignore_status=False) >> +(status, output) = self._run(scpCmd, ignore_status=warn_on_failure) >> +if warn_on_failure and status: >> +self.logger.warning("Copy returned non-zero exit status >> %d:\n%s" % (status, output)) >> +return (status, output) >> >> def copyDirTo(self, localSrc, remoteDst): >> """ >> diff --git a/meta/lib/oeqa/runtime/cases/ltp.py >> b/meta/lib/oeqa/runtime/cases/ltp.py >> index 6dc5ef22ad..da529ce482 100644 >> --- a/meta/lib/oeqa/runtime/cases/ltp.py >> +++ b/meta/lib/oeqa/runtime/cases/ltp.py >> @@ -78,7 +78,7 @@ class LtpTest(LtpTestBase): >> # copy nice log from DUT >> dst = os.path.join(self.ltptest_log_dir, "%s" % ltp_group ) >> remote_src = "/opt/ltp/results/%s" % ltp_group >> -(status, output) = self.target.copyFrom(remote_src, dst) >> +(status, output) = self.target.copyFrom(remote_src, dst, True) >> msg = 'File could not be copied. Output: %s' % output >> self.assertEqual(status, 0, msg=msg) > > The idea of this change is so "the ltp tests continue to run" yet if I > understand that code, a copy failure will throw the assertEqual and > hence stop the test so we don't get all the other logging information? When warn_on_failure=True, so is ignore_status. Then 'status and not ignore_status' evaluates to false, and 'raise AssertionError("Command '%s' returned non-zero exit ...)' will not run. > > Cheers, > > Richard > > -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141248): https://lists.openembedded.org/g/openembedded-core/message/141248 Mute This Topic: https://lists.openembedded.org/mt/76013023/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCHv3] ltp: make copyFrom scp command non-fatal
[YOCTO #13802] Make the scp failure non-fatal so the ltp tests continue to run and the rest of the logs will be available to see afterwards. Signed-off-by: Mingde (Matthew) Zeng --- meta/lib/oeqa/core/target/ssh.py | 7 +-- meta/lib/oeqa/runtime/cases/ltp.py | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/meta/lib/oeqa/core/target/ssh.py b/meta/lib/oeqa/core/target/ssh.py index 090b40a814..aefb576805 100644 --- a/meta/lib/oeqa/core/target/ssh.py +++ b/meta/lib/oeqa/core/target/ssh.py @@ -107,13 +107,16 @@ class OESSHTarget(OETarget): scpCmd = self.scp + [localSrc, remotePath] return self._run(scpCmd, ignore_status=False) -def copyFrom(self, remoteSrc, localDst): +def copyFrom(self, remoteSrc, localDst, warn_on_failure=False): """ Copy file from target. """ remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) scpCmd = self.scp + [remotePath, localDst] -return self._run(scpCmd, ignore_status=False) +(status, output) = self._run(scpCmd, ignore_status=warn_on_failure) +if warn_on_failure and status: +self.logger.warning("Copy returned non-zero exit status %d:\n%s" % (status, output)) +return (status, output) def copyDirTo(self, localSrc, remoteDst): """ diff --git a/meta/lib/oeqa/runtime/cases/ltp.py b/meta/lib/oeqa/runtime/cases/ltp.py index 6dc5ef22ad..da529ce482 100644 --- a/meta/lib/oeqa/runtime/cases/ltp.py +++ b/meta/lib/oeqa/runtime/cases/ltp.py @@ -78,7 +78,7 @@ class LtpTest(LtpTestBase): # copy nice log from DUT dst = os.path.join(self.ltptest_log_dir, "%s" % ltp_group ) remote_src = "/opt/ltp/results/%s" % ltp_group -(status, output) = self.target.copyFrom(remote_src, dst) +(status, output) = self.target.copyFrom(remote_src, dst, True) msg = 'File could not be copied. Output: %s' % output self.assertEqual(status, 0, msg=msg) -- 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141245): https://lists.openembedded.org/g/openembedded-core/message/141245 Mute This Topic: https://lists.openembedded.org/mt/76013023/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCHv2] ltp: make copyFrom scp command non-fatal
Richard Purdie writes: > On Wed, 2020-08-05 at 13:15 -0400, Mingde (Matthew) Zeng wrote: >> [YOCTO #13802] >> >> Make the scp failure non-fatal so the ltp tests continue to run and >> the rest of the logs will be available to see afterwards. >> >> Signed-off-by: Mingde (Matthew) Zeng >> --- >> meta/lib/oeqa/core/target/ssh.py | 11 +++ >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/meta/lib/oeqa/core/target/ssh.py >> b/meta/lib/oeqa/core/target/ssh.py >> index 090b40a814..e891a4bbfa 100644 >> --- a/meta/lib/oeqa/core/target/ssh.py >> +++ b/meta/lib/oeqa/core/target/ssh.py >> @@ -50,7 +50,7 @@ class OESSHTarget(OETarget): >> def stop(self, **kwargs): >> pass >> >> -def _run(self, command, timeout=None, ignore_status=True): >> +def _run(self, command, timeout=None, ignore_status=True, >> ignore_error=False): >> """ >> Runs command in target using SSHProcess. >> """ >> @@ -62,8 +62,11 @@ class OESSHTarget(OETarget): >> "" % (status, time.time() - starttime)) >> >> if status and not ignore_status: >> -raise AssertionError("Command '%s' returned non-zero exit " >> - "status %d:\n%s" % (command, status, >> output)) >> +if ignore_error: >> +self.logger.warning("Command '%s' returned non-zero exit >> status %d:\n%s" % (command, status, output)) >> +else: >> +raise AssertionError("Command '%s' returned non-zero exit " >> + "status %d:\n%s" % (command, status, >> output)) >> >> return (status, output) >> >> @@ -113,7 +116,7 @@ class OESSHTarget(OETarget): >> """ >> remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) >> scpCmd = self.scp + [remotePath, localDst] >> -return self._run(scpCmd, ignore_status=False) >> +return self._run(scpCmd, ignore_error=True) >> >> def copyDirTo(self, localSrc, remoteDst): >> """ > > That isn't what I meant, I mean something like: > > diff --git a/meta/lib/oeqa/core/target/ssh.py > b/meta/lib/oeqa/core/target/ssh.py > index 090b40a8143..cbc56f2e0ad 100644 > --- a/meta/lib/oeqa/core/target/ssh.py > +++ b/meta/lib/oeqa/core/target/ssh.py > @@ -107,13 +107,16 @@ class OESSHTarget(OETarget): > scpCmd = self.scp + [localSrc, remotePath] > return self._run(scpCmd, ignore_status=False) > > -def copyFrom(self, remoteSrc, localDst): > +def copyFrom(self, remoteSrc, localDst, warn_on_failure=False): > """ > Copy file from target. > """ > remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) > scpCmd = self.scp + [remotePath, localDst] > -return self._run(scpCmd, ignore_status=False) > +(status, output) = self._run(scpCmd, ignore_status=warn_on_failure) > +if warn_on_failure and not status: > +self.logger.warning("Copy X returned non-zero exit status > %d:\n%s" % (XXX, status, output)) > +return (status, output) > > def copyDirTo(self, localSrc, remoteDst): > """ > > so that we enable this in the specific case og the copy we might accept > failure for. This works too, my implementation is not as specific as this, however it enables warning when the optional parameter ignore_error=True, which is only specified in the copyFrom function. I'll adjust my patch. > > Cheers, > > Richard -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141244): https://lists.openembedded.org/g/openembedded-core/message/141244 Mute This Topic: https://lists.openembedded.org/mt/76012000/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCHv2] ltp: make copyFrom scp command non-fatal
Richard Purdie writes: > On Wed, 2020-08-05 at 13:15 -0400, Mingde (Matthew) Zeng wrote: >> [YOCTO #13802] >> >> Make the scp failure non-fatal so the ltp tests continue to run and >> the rest of the logs will be available to see afterwards. >> >> Signed-off-by: Mingde (Matthew) Zeng >> --- >> meta/lib/oeqa/core/target/ssh.py | 11 +++ >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/meta/lib/oeqa/core/target/ssh.py >> b/meta/lib/oeqa/core/target/ssh.py >> index 090b40a814..e891a4bbfa 100644 >> --- a/meta/lib/oeqa/core/target/ssh.py >> +++ b/meta/lib/oeqa/core/target/ssh.py >> @@ -50,7 +50,7 @@ class OESSHTarget(OETarget): >> def stop(self, **kwargs): >> pass >> >> -def _run(self, command, timeout=None, ignore_status=True): >> +def _run(self, command, timeout=None, ignore_status=True, >> ignore_error=False): >> """ >> Runs command in target using SSHProcess. >> """ >> @@ -62,8 +62,11 @@ class OESSHTarget(OETarget): >> "" % (status, time.time() - starttime)) >> >> if status and not ignore_status: >> -raise AssertionError("Command '%s' returned non-zero exit " >> - "status %d:\n%s" % (command, status, >> output)) >> +if ignore_error: >> +self.logger.warning("Command '%s' returned non-zero exit >> status %d:\n%s" % (command, status, output)) >> +else: >> +raise AssertionError("Command '%s' returned non-zero exit " >> + "status %d:\n%s" % (command, status, >> output)) >> >> return (status, output) >> >> @@ -113,7 +116,7 @@ class OESSHTarget(OETarget): >> """ >> remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) >> scpCmd = self.scp + [remotePath, localDst] >> -return self._run(scpCmd, ignore_status=False) >> +return self._run(scpCmd, ignore_error=True) >> >> def copyDirTo(self, localSrc, remoteDst): >> """ > > That isn't what I meant, I mean something like: > > diff --git a/meta/lib/oeqa/core/target/ssh.py > b/meta/lib/oeqa/core/target/ssh.py > index 090b40a8143..cbc56f2e0ad 100644 > --- a/meta/lib/oeqa/core/target/ssh.py > +++ b/meta/lib/oeqa/core/target/ssh.py > @@ -107,13 +107,16 @@ class OESSHTarget(OETarget): > scpCmd = self.scp + [localSrc, remotePath] > return self._run(scpCmd, ignore_status=False) > > -def copyFrom(self, remoteSrc, localDst): > +def copyFrom(self, remoteSrc, localDst, warn_on_failure=False): > """ > Copy file from target. > """ > remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) > scpCmd = self.scp + [remotePath, localDst] > -return self._run(scpCmd, ignore_status=False) > +(status, output) = self._run(scpCmd, ignore_status=warn_on_failure) > +if warn_on_failure and not status: > +self.logger.warning("Copy X returned non-zero exit status > %d:\n%s" % (XXX, status, output)) > +return (status, output) > > def copyDirTo(self, localSrc, remoteDst): > """ > > so that we enable this in the specific case og the copy we might accept > failure for. This works too, my implementation is not as specific as this but it still enables warning only when the optional parameter ignore_error=True, which is what I specified in the copyFrom function only. I'll adjust my patch. > > Cheers, > > Richard -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141243): https://lists.openembedded.org/g/openembedded-core/message/141243 Mute This Topic: https://lists.openembedded.org/mt/76012000/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCHv2] ltp: make copyFrom scp command non-fatal
[YOCTO #13802] Make the scp failure non-fatal so the ltp tests continue to run and the rest of the logs will be available to see afterwards. Signed-off-by: Mingde (Matthew) Zeng --- meta/lib/oeqa/core/target/ssh.py | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/meta/lib/oeqa/core/target/ssh.py b/meta/lib/oeqa/core/target/ssh.py index 090b40a814..e891a4bbfa 100644 --- a/meta/lib/oeqa/core/target/ssh.py +++ b/meta/lib/oeqa/core/target/ssh.py @@ -50,7 +50,7 @@ class OESSHTarget(OETarget): def stop(self, **kwargs): pass -def _run(self, command, timeout=None, ignore_status=True): +def _run(self, command, timeout=None, ignore_status=True, ignore_error=False): """ Runs command in target using SSHProcess. """ @@ -62,8 +62,11 @@ class OESSHTarget(OETarget): "" % (status, time.time() - starttime)) if status and not ignore_status: -raise AssertionError("Command '%s' returned non-zero exit " - "status %d:\n%s" % (command, status, output)) +if ignore_error: +self.logger.warning("Command '%s' returned non-zero exit status %d:\n%s" % (command, status, output)) +else: +raise AssertionError("Command '%s' returned non-zero exit " + "status %d:\n%s" % (command, status, output)) return (status, output) @@ -113,7 +116,7 @@ class OESSHTarget(OETarget): """ remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) scpCmd = self.scp + [remotePath, localDst] -return self._run(scpCmd, ignore_status=False) +return self._run(scpCmd, ignore_error=True) def copyDirTo(self, localSrc, remoteDst): """ -- 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141237): https://lists.openembedded.org/g/openembedded-core/message/141237 Mute This Topic: https://lists.openembedded.org/mt/76012000/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] ltp: make copyFrom scp command non-fatal
Richard Purdie writes: > On Wed, 2020-08-05 at 11:50 -0400, Matthew wrote: >> [YOCTO #13802] >> >> Make the scp failure non-fatal so the ltp tests continue to run and >> the rest of the logs will be available to see afterwards. >> >> Signed-off-by: Mingde (Matthew) Zeng >> --- >> meta/lib/oeqa/core/target/ssh.py | 11 +++ >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/meta/lib/oeqa/core/target/ssh.py >> b/meta/lib/oeqa/core/target/ssh.py >> index 090b40a814..1b78e830d4 100644 >> --- a/meta/lib/oeqa/core/target/ssh.py >> +++ b/meta/lib/oeqa/core/target/ssh.py >> @@ -61,9 +61,12 @@ class OESSHTarget(OETarget): >> self.logger.debug("[Command returned '%d' after %.2f seconds]" >> "" % (status, time.time() - starttime)) >> >> -if status and not ignore_status: >> -raise AssertionError("Command '%s' returned non-zero exit " >> - "status %d:\n%s" % (command, status, >> output)) >> +if status: >> +if not ignore_status: >> +raise AssertionError("Command '%s' returned non-zero exit " >> + "status %d:\n%s" % (command, status, >> output)) >> +else: >> +self.logger.warning("Command '%s' returned non-zero exit >> status %d:\n%s" % (command, status, output)) >> >> return (status, output) >> >> @@ -113,7 +116,7 @@ class OESSHTarget(OETarget): >> """ >> remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) >> scpCmd = self.scp + [remotePath, localDst] >> -return self._run(scpCmd, ignore_status=False) >> +return self._run(scpCmd, ignore_status=True) >> >> def copyDirTo(self, localSrc, remoteDst): >> """ > > I'm a little worried that these warnings may appear from places we > don't expect them. I can run the test on the autobuilder and see if > other tests trigger this I guess, I wondered if you'd looked into that? > You're right, the better way might be adding an additional optional parameter ignore_error, so it won't break any existing behavior. I'll quickly create a new patch and let you have a look. > An alternative may be to set ignore_status=True but check the return > code at a higher level and issue the warning there? > > Cheers, > Richard -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141236): https://lists.openembedded.org/g/openembedded-core/message/141236 Mute This Topic: https://lists.openembedded.org/mt/76010223/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCHv2] ltp: remove OOM tests from runtest/mm
Richard Purdie writes: > On Wed, 2020-07-29 at 09:09 -0400, Matthew wrote: >> Fixes [YOCTO #13802] > > Thanks, we can reference the bug but I don't think we can yet claim it > fixes it. > > The missing log issue happened again: > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908 > so I think there are multiple issues at play here. > > Is there any way to have the logging logged to disk straight away > rather than stuck internally in oeqa's logging buffers? That way we > could see which tests had run before a hang? Ltp comes with zoo file already, is it what you're looking for? > > Also, could we make the scp failure non-fatal, maybe a warning so that > when it fails we can look at the rest of the logs? I submitted a patch that I think should achieve this idea, please have a look. > > Cheers, > > Richard > >> Remove the OOM tests, since they might cause oeqa ssh >> connection lost. >> >> Signed-off-by: Mingde (Matthew) Zeng >> --- >> ...001-Remove-OOM-tests-from-runtest-mm.patch | 33 >> +++ >> meta/recipes-extended/ltp/ltp_20200515.bb | 1 + >> 2 files changed, 34 insertions(+) >> create mode 100644 meta/recipes-extended/ltp/ltp/0001-Remove-OOM- >> tests-from-runtest-mm.patch >> >> diff --git a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests- >> from-runtest-mm.patch b/meta/recipes-extended/ltp/ltp/0001-Remove- >> OOM-tests-from-runtest-mm.patch >> new file mode 100644 >> index 00..2d8262be78 >> --- /dev/null >> +++ b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from- >> runtest-mm.patch >> @@ -0,0 +1,33 @@ >> +From 373b21dcf7a2879c27cc3dbeac5d83f5d45d22ae Mon Sep 17 00:00:00 >> 2001 >> +From: "Mingde (Matthew) Zeng" >> +Date: Wed, 29 Jul 2020 08:47:09 -0400 >> +Subject: [PATCH] Remove OOM tests from runtest/mm >> + >> +Disable OOM tests, as they might cause oeqa ssh connection lost >> + >> +Upstream-Status: Inappropriate [oe-core specific] >> +Signed-off-by: Mingde (Matthew) Zeng >> +--- >> + runtest/mm | 6 -- >> + 1 file changed, 6 deletions(-) >> + >> +diff --git a/runtest/mm b/runtest/mm >> +index 4701a14bd..2f9888ec6 100644 >> +--- a/runtest/mm >> b/runtest/mm >> +@@ -75,12 +75,6 @@ ksm06_2 ksm06 -n 1 >> + >> + cpuset01 cpuset01 >> + >> +-oom01 oom01 >> +-oom02 oom02 >> +-oom03 oom03 >> +-oom04 oom04 >> +-oom05 oom05 >> +- >> + swapping01 swapping01 -i 5 >> + >> + thp01 thp01 -I 120 >> +-- >> +2.27.0 >> + >> diff --git a/meta/recipes-extended/ltp/ltp_20200515.bb >> b/meta/recipes-extended/ltp/ltp_20200515.bb >> index ece3acf0f9..0c7044d044 100644 >> --- a/meta/recipes-extended/ltp/ltp_20200515.bb >> +++ b/meta/recipes-extended/ltp/ltp_20200515.bb >> @@ -37,6 +37,7 @@ SRC_URI = "git://github.com/linux-test- >> project/ltp.git \ >> file://0001-ptrace01-Fix-missing-format-string.patch \ >> file://0001-sigwaitinfo-Do-not-run-invalid-undefined- >> test-cases.patch \ >> file://0001-syscalls-copy_file_range02-Expect-EFBIG-in- >> subcase-m.patch \ >> + file://0001-Remove-OOM-tests-from-runtest-mm.patch \ >> " >> >> S = "${WORKDIR}/git" >> -- >> 2.27.0 >> -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141231): https://lists.openembedded.org/g/openembedded-core/message/141231 Mute This Topic: https://lists.openembedded.org/mt/75864108/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] ltp: make copyFrom scp command non-fatal
[YOCTO #13802] Make the scp failure non-fatal so the ltp tests continue to run and the rest of the logs will be available to see afterwards. Signed-off-by: Mingde (Matthew) Zeng --- meta/lib/oeqa/core/target/ssh.py | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/meta/lib/oeqa/core/target/ssh.py b/meta/lib/oeqa/core/target/ssh.py index 090b40a814..1b78e830d4 100644 --- a/meta/lib/oeqa/core/target/ssh.py +++ b/meta/lib/oeqa/core/target/ssh.py @@ -61,9 +61,12 @@ class OESSHTarget(OETarget): self.logger.debug("[Command returned '%d' after %.2f seconds]" "" % (status, time.time() - starttime)) -if status and not ignore_status: -raise AssertionError("Command '%s' returned non-zero exit " - "status %d:\n%s" % (command, status, output)) +if status: +if not ignore_status: +raise AssertionError("Command '%s' returned non-zero exit " + "status %d:\n%s" % (command, status, output)) +else: +self.logger.warning("Command '%s' returned non-zero exit status %d:\n%s" % (command, status, output)) return (status, output) @@ -113,7 +116,7 @@ class OESSHTarget(OETarget): """ remotePath = '%s@%s:%s' % (self.user, self.ip, remoteSrc) scpCmd = self.scp + [remotePath, localDst] -return self._run(scpCmd, ignore_status=False) +return self._run(scpCmd, ignore_status=True) def copyDirTo(self, localSrc, remoteDst): """ -- 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141230): https://lists.openembedded.org/g/openembedded-core/message/141230 Mute This Topic: https://lists.openembedded.org/mt/76010223/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCHv2] ltp: remove OOM tests from runtest/mm
Khem Raj writes: > On Wed, Jul 29, 2020 at 8:27 PM Mingde (Matthew) Zeng > wrote: >> >> >> Khem Raj writes: >> >> > on master-next I am also seeing >> > >> > step1b: WARNING: ltp-20200515-r0 do_patch: QA Issue: Patch log >> > indicates that patches do not apply cleanly. [patch-fuzz] >> > >> > I wonder if its related to this as well. >> >> My bad. >> >> Just a couple days ago ltp master introduced a commit directly effected the >> line above my change, resulting the diff to look slightly different. >> >> I could send a patch on top of this commit, or is it possible to revert this >> merged commit altogether and I will send a new patch, to keep the git log >> clean. Whichever preferred by YP. >> > > its not in master yet so please send a v2. Done. > >> >> Matthew >> >> > >> > On Wed, Jul 29, 2020 at 6:43 AM Richard Purdie >> > wrote: >> >> >> >> On Wed, 2020-07-29 at 09:41 -0400, Mingde (Matthew) Zeng wrote: >> >> > Richard Purdie writes: >> >> > >> >> > > On Wed, 2020-07-29 at 09:09 -0400, Matthew wrote: >> >> > > > Fixes [YOCTO #13802] >> >> > > >> >> > > Thanks, we can reference the bug but I don't think we can yet claim >> >> > > it >> >> > > fixes it. >> >> > >> >> > Sure, would something like the following work? >> >> > >> >> > Reference [YOCTO #13802] >> >> >> >> Simply "[YOCTO #13802]" is fine (I'll tweak the commit message as I >> >> merge). >> >> >> >> > > The missing log issue happened again: >> >> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908 >> >> > > so I think there are multiple issues at play here. >> >> > >> >> > Can you attach this build's log.do_testimage so I can have a further >> >> > look? >> >> >> >> Sorry, that build directory has been reused in this case :( Next time >> >> that happens I'll try and spot/grab it. >> >> >> >> > > Is there any way to have the logging logged to disk straight away >> >> > > rather than stuck internally in oeqa's logging buffers? That way we >> >> > > could see which tests had run before a hang? >> >> > > >> >> > > Also, could we make the scp failure non-fatal, maybe a warning so >> >> > > that >> >> > > when it fails we can look at the rest of the logs? >> >> > >> >> > I'll further investigate this idea. >> >> >> >> Thanks! >> >> >> >> Cheers, >> >> >> >> Richard >> >> >> >> >> >> >> -- >> Mingde (Matthew) Zeng -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141113): https://lists.openembedded.org/g/openembedded-core/message/141113 Mute This Topic: https://lists.openembedded.org/mt/75864108/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCHv3] ltp: remove OOM tests from runtest/mm
[YOCTO #13802] Remove the OOM tests, since they might cause oeqa ssh connection lost. Signed-off-by: Mingde (Matthew) Zeng --- ...001-Remove-OOM-tests-from-runtest-mm.patch | 34 +++ meta/recipes-extended/ltp/ltp_20200515.bb | 1 + 2 files changed, 35 insertions(+) create mode 100644 meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch diff --git a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch new file mode 100644 index 00..529065d979 --- /dev/null +++ b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch @@ -0,0 +1,34 @@ +From 13ef88cdccfe3f58c53d57806866b91e310eb272 Mon Sep 17 00:00:00 2001 +From: "Mingde (Matthew) Zeng" +Date: Wed, 29 Jul 2020 08:47:09 -0400 +Subject: [PATCH] Remove OOM tests from runtest/mm + +Disable OOM tests, as they might cause oeqa ssh connection lost + +Upstream-Status: Inappropriate [oe-core specific] +Signed-off-by: Mingde (Matthew) Zeng + +--- + runtest/mm | 6 -- + 1 file changed, 6 deletions(-) + +diff --git a/runtest/mm b/runtest/mm +index a09f39c1e..76fa82754 100644 +--- a/runtest/mm b/runtest/mm +@@ -73,12 +73,6 @@ ksm06 ksm06 + ksm06_1 ksm06 -n 10 + ksm06_2 ksm06 -n 1 + +-oom01 oom01 +-oom02 oom02 +-oom03 oom03 +-oom04 oom04 +-oom05 oom05 +- + swapping01 swapping01 -i 5 + + thp01 thp01 -I 120 +-- +2.27.0 + diff --git a/meta/recipes-extended/ltp/ltp_20200515.bb b/meta/recipes-extended/ltp/ltp_20200515.bb index ece3acf0f9..0c7044d044 100644 --- a/meta/recipes-extended/ltp/ltp_20200515.bb +++ b/meta/recipes-extended/ltp/ltp_20200515.bb @@ -37,6 +37,7 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git \ file://0001-ptrace01-Fix-missing-format-string.patch \ file://0001-sigwaitinfo-Do-not-run-invalid-undefined-test-cases.patch \ file://0001-syscalls-copy_file_range02-Expect-EFBIG-in-subcase-m.patch \ + file://0001-Remove-OOM-tests-from-runtest-mm.patch \ " S = "${WORKDIR}/git" -- 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141112): https://lists.openembedded.org/g/openembedded-core/message/141112 Mute This Topic: https://lists.openembedded.org/mt/75880209/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCHv2] ltp: remove OOM tests from runtest/mm
Khem Raj writes: > on master-next I am also seeing > > step1b: WARNING: ltp-20200515-r0 do_patch: QA Issue: Patch log > indicates that patches do not apply cleanly. [patch-fuzz] > > I wonder if its related to this as well. My bad. Just a couple days ago ltp master introduced a commit directly effected the line above my change, resulting the diff to look slightly different. I could send a patch on top of this commit, or is it possible to revert this merged commit altogether and I will send a new patch, to keep the git log clean. Whichever preferred by YP. Matthew > > On Wed, Jul 29, 2020 at 6:43 AM Richard Purdie > wrote: >> >> On Wed, 2020-07-29 at 09:41 -0400, Mingde (Matthew) Zeng wrote: >> > Richard Purdie writes: >> > >> > > On Wed, 2020-07-29 at 09:09 -0400, Matthew wrote: >> > > > Fixes [YOCTO #13802] >> > > >> > > Thanks, we can reference the bug but I don't think we can yet claim >> > > it >> > > fixes it. >> > >> > Sure, would something like the following work? >> > >> > Reference [YOCTO #13802] >> >> Simply "[YOCTO #13802]" is fine (I'll tweak the commit message as I >> merge). >> >> > > The missing log issue happened again: >> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908 >> > > so I think there are multiple issues at play here. >> > >> > Can you attach this build's log.do_testimage so I can have a further >> > look? >> >> Sorry, that build directory has been reused in this case :( Next time >> that happens I'll try and spot/grab it. >> >> > > Is there any way to have the logging logged to disk straight away >> > > rather than stuck internally in oeqa's logging buffers? That way we >> > > could see which tests had run before a hang? >> > > >> > > Also, could we make the scp failure non-fatal, maybe a warning so >> > > that >> > > when it fails we can look at the rest of the logs? >> > >> > I'll further investigate this idea. >> >> Thanks! >> >> Cheers, >> >> Richard >> >> -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141109): https://lists.openembedded.org/g/openembedded-core/message/141109 Mute This Topic: https://lists.openembedded.org/mt/75864108/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCHv2] ltp: remove OOM tests from runtest/mm
Richard Purdie writes: > On Wed, 2020-07-29 at 09:09 -0400, Matthew wrote: >> Fixes [YOCTO #13802] > > Thanks, we can reference the bug but I don't think we can yet claim it > fixes it. Sure, would something like the following work? Reference [YOCTO #13802] > > The missing log issue happened again: > https://autobuilder.yoctoproject.org/typhoon/#/builders/96/builds/908 > so I think there are multiple issues at play here. Can you attach this build's log.do_testimage so I can have a further look? > > Is there any way to have the logging logged to disk straight away > rather than stuck internally in oeqa's logging buffers? That way we > could see which tests had run before a hang? > > Also, could we make the scp failure non-fatal, maybe a warning so that > when it fails we can look at the rest of the logs? I'll further investigate this idea. Matthew > > Cheers, > > Richard > >> Remove the OOM tests, since they might cause oeqa ssh >> connection lost. >> >> Signed-off-by: Mingde (Matthew) Zeng >> --- >> ...001-Remove-OOM-tests-from-runtest-mm.patch | 33 >> +++ >> meta/recipes-extended/ltp/ltp_20200515.bb | 1 + >> 2 files changed, 34 insertions(+) >> create mode 100644 meta/recipes-extended/ltp/ltp/0001-Remove-OOM- >> tests-from-runtest-mm.patch >> >> diff --git a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests- >> from-runtest-mm.patch b/meta/recipes-extended/ltp/ltp/0001-Remove- >> OOM-tests-from-runtest-mm.patch >> new file mode 100644 >> index 00..2d8262be78 >> --- /dev/null >> +++ b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from- >> runtest-mm.patch >> @@ -0,0 +1,33 @@ >> +From 373b21dcf7a2879c27cc3dbeac5d83f5d45d22ae Mon Sep 17 00:00:00 >> 2001 >> +From: "Mingde (Matthew) Zeng" >> +Date: Wed, 29 Jul 2020 08:47:09 -0400 >> +Subject: [PATCH] Remove OOM tests from runtest/mm >> + >> +Disable OOM tests, as they might cause oeqa ssh connection lost >> + >> +Upstream-Status: Inappropriate [oe-core specific] >> +Signed-off-by: Mingde (Matthew) Zeng >> +--- >> + runtest/mm | 6 -- >> + 1 file changed, 6 deletions(-) >> + >> +diff --git a/runtest/mm b/runtest/mm >> +index 4701a14bd..2f9888ec6 100644 >> +--- a/runtest/mm >> b/runtest/mm >> +@@ -75,12 +75,6 @@ ksm06_2 ksm06 -n 1 >> + >> + cpuset01 cpuset01 >> + >> +-oom01 oom01 >> +-oom02 oom02 >> +-oom03 oom03 >> +-oom04 oom04 >> +-oom05 oom05 >> +- >> + swapping01 swapping01 -i 5 >> + >> + thp01 thp01 -I 120 >> +-- >> +2.27.0 >> + >> diff --git a/meta/recipes-extended/ltp/ltp_20200515.bb >> b/meta/recipes-extended/ltp/ltp_20200515.bb >> index ece3acf0f9..0c7044d044 100644 >> --- a/meta/recipes-extended/ltp/ltp_20200515.bb >> +++ b/meta/recipes-extended/ltp/ltp_20200515.bb >> @@ -37,6 +37,7 @@ SRC_URI = "git://github.com/linux-test- >> project/ltp.git \ >> file://0001-ptrace01-Fix-missing-format-string.patch \ >> file://0001-sigwaitinfo-Do-not-run-invalid-undefined- >> test-cases.patch \ >> file://0001-syscalls-copy_file_range02-Expect-EFBIG-in- >> subcase-m.patch \ >> + file://0001-Remove-OOM-tests-from-runtest-mm.patch \ >> " >> >> S = "${WORKDIR}/git" >> -- >> 2.27.0 >> -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141092): https://lists.openembedded.org/g/openembedded-core/message/141092 Mute This Topic: https://lists.openembedded.org/mt/75864108/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCHv2] ltp: remove OOM tests from runtest/mm
Fixes [YOCTO #13802] Remove the OOM tests, since they might cause oeqa ssh connection lost. Signed-off-by: Mingde (Matthew) Zeng --- ...001-Remove-OOM-tests-from-runtest-mm.patch | 33 +++ meta/recipes-extended/ltp/ltp_20200515.bb | 1 + 2 files changed, 34 insertions(+) create mode 100644 meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch diff --git a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch new file mode 100644 index 00..2d8262be78 --- /dev/null +++ b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch @@ -0,0 +1,33 @@ +From 373b21dcf7a2879c27cc3dbeac5d83f5d45d22ae Mon Sep 17 00:00:00 2001 +From: "Mingde (Matthew) Zeng" +Date: Wed, 29 Jul 2020 08:47:09 -0400 +Subject: [PATCH] Remove OOM tests from runtest/mm + +Disable OOM tests, as they might cause oeqa ssh connection lost + +Upstream-Status: Inappropriate [oe-core specific] +Signed-off-by: Mingde (Matthew) Zeng +--- + runtest/mm | 6 -- + 1 file changed, 6 deletions(-) + +diff --git a/runtest/mm b/runtest/mm +index 4701a14bd..2f9888ec6 100644 +--- a/runtest/mm b/runtest/mm +@@ -75,12 +75,6 @@ ksm06_2 ksm06 -n 1 + + cpuset01 cpuset01 + +-oom01 oom01 +-oom02 oom02 +-oom03 oom03 +-oom04 oom04 +-oom05 oom05 +- + swapping01 swapping01 -i 5 + + thp01 thp01 -I 120 +-- +2.27.0 + diff --git a/meta/recipes-extended/ltp/ltp_20200515.bb b/meta/recipes-extended/ltp/ltp_20200515.bb index ece3acf0f9..0c7044d044 100644 --- a/meta/recipes-extended/ltp/ltp_20200515.bb +++ b/meta/recipes-extended/ltp/ltp_20200515.bb @@ -37,6 +37,7 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git \ file://0001-ptrace01-Fix-missing-format-string.patch \ file://0001-sigwaitinfo-Do-not-run-invalid-undefined-test-cases.patch \ file://0001-syscalls-copy_file_range02-Expect-EFBIG-in-subcase-m.patch \ + file://0001-Remove-OOM-tests-from-runtest-mm.patch \ " S = "${WORKDIR}/git" -- 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141089): https://lists.openembedded.org/g/openembedded-core/message/141089 Mute This Topic: https://lists.openembedded.org/mt/75864108/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] ltp: remove OOM tests from runtest/mm
Error, please ignore. Matthew writes: > Fixes [YOCTO #13802] > > Temporarily remove the OOM tests, since they might cause oeqa ssh > connection lost. > > Let's wait for a week or two to see if the error stops occuring. > > Signed-off-by: Mingde (Matthew) Zeng > --- > ...001-Remove-OOM-tests-from-runtest-mm.patch | 33 +++ > 1 file changed, 33 insertions(+) > create mode 100644 > meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch > > diff --git > a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch > b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch > new file mode 100644 > index 00..3a58986288 > --- /dev/null > +++ > b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch > @@ -0,0 +1,33 @@ > +From e49c4bc6e8b5c1d6f3e9763751e1fb656788709b Mon Sep 17 00:00:00 2001 > +From: "Mingde (Matthew) Zeng" > +Date: Wed, 29 Jul 2020 08:47:09 -0400 > +Subject: [PATCH] Remove OOM tests from runtest/mm > + > +Disable OOM tests, as they might cause oeqa ssh connection lost > + > +Upstream-Status: Inappropriate [oe-core specific] > +Signed-off-by: Mingde (Matthew) Zeng > +--- > + runtest/mm | 6 -- > + 1 file changed, 6 deletions(-) > + > +diff --git a/runtest/mm b/runtest/mm > +index 4701a14bd..2f9888ec6 100644 > +--- a/runtest/mm > b/runtest/mm > +@@ -75,12 +75,6 @@ ksm06_2 ksm06 -n 1 > + > + cpuset01 cpuset01 > + > +-oom01 oom01 > +-oom02 oom02 > +-oom03 oom03 > +-oom04 oom04 > +-oom05 oom05 > +- > + swapping01 swapping01 -i 5 > + > + thp01 thp01 -I 120 > +-- > +2.27.0 > + -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141087): https://lists.openembedded.org/g/openembedded-core/message/141087 Mute This Topic: https://lists.openembedded.org/mt/75863878/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] ltp: remove OOM tests from runtest/mm
Fixes [YOCTO #13802] Temporarily remove the OOM tests, since they might cause oeqa ssh connection lost. Let's wait for a week or two to see if the error stops occuring. Signed-off-by: Mingde (Matthew) Zeng --- ...001-Remove-OOM-tests-from-runtest-mm.patch | 33 +++ 1 file changed, 33 insertions(+) create mode 100644 meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch diff --git a/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch new file mode 100644 index 00..3a58986288 --- /dev/null +++ b/meta/recipes-extended/ltp/ltp/0001-Remove-OOM-tests-from-runtest-mm.patch @@ -0,0 +1,33 @@ +From e49c4bc6e8b5c1d6f3e9763751e1fb656788709b Mon Sep 17 00:00:00 2001 +From: "Mingde (Matthew) Zeng" +Date: Wed, 29 Jul 2020 08:47:09 -0400 +Subject: [PATCH] Remove OOM tests from runtest/mm + +Disable OOM tests, as they might cause oeqa ssh connection lost + +Upstream-Status: Inappropriate [oe-core specific] +Signed-off-by: Mingde (Matthew) Zeng +--- + runtest/mm | 6 -- + 1 file changed, 6 deletions(-) + +diff --git a/runtest/mm b/runtest/mm +index 4701a14bd..2f9888ec6 100644 +--- a/runtest/mm b/runtest/mm +@@ -75,12 +75,6 @@ ksm06_2 ksm06 -n 1 + + cpuset01 cpuset01 + +-oom01 oom01 +-oom02 oom02 +-oom03 oom03 +-oom04 oom04 +-oom05 oom05 +- + swapping01 swapping01 -i 5 + + thp01 thp01 -I 120 +-- +2.27.0 + -- 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141084): https://lists.openembedded.org/g/openembedded-core/message/141084 Mute This Topic: https://lists.openembedded.org/mt/75863878/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] ltp.py: remove mm from ltp_groups
Fixes [YOCTO #13802] Temporary disable mm test for a while, since it calls the OOM tests. See ltp-git/runtest/mm: oom01 oom01 oom02 oom02 oom03 oom03 oom04 oom04 oom05 oom05 Let's wait for a week or two to see if the error stops occuring. Signed-off-by: Mingde (Matthew) Zeng --- meta/lib/oeqa/runtime/cases/ltp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/lib/oeqa/runtime/cases/ltp.py b/meta/lib/oeqa/runtime/cases/ltp.py index cfac29c153..9ac7bb15f6 100644 --- a/meta/lib/oeqa/runtime/cases/ltp.py +++ b/meta/lib/oeqa/runtime/cases/ltp.py @@ -57,7 +57,7 @@ class LtpTestBase(OERuntimeTestCase): class LtpTest(LtpTestBase): -ltp_groups = ["math", "syscalls", "dio", "io", "mm", "ipc", "sched", "nptl", "pty", "containers", "controllers", "filecaps", "cap_bounds", "fcntl-locktests", "connectors", "commands", "net.ipv6_lib", "input","fs_perms_simple"] +ltp_groups = ["math", "syscalls", "dio", "io", "ipc", "sched", "nptl", "pty", "containers", "controllers", "filecaps", "cap_bounds", "fcntl-locktests", "connectors", "commands", "net.ipv6_lib", "input","fs_perms_simple"] ltp_fs = ["fs", "fsx", "fs_bind"] # skip kernel cpuhotplug -- 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#141068): https://lists.openembedded.org/g/openembedded-core/message/141068 Mute This Topic: https://lists.openembedded.org/mt/75852805/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] ltp.py: compare dmesg before and after test
Hi, I'm working on bugzilla 13802 by removing OOM killer test execution. Randy was suggesting before running ltp, we should clear the dmesg ring buffer, run the test, and then collect dmesg ring buffer again afterwards. Initially we would only print out the log, we could decide that a non-empty string indicating an error. Does this make sense for ltp and does it make sense to do it for each oeqa test? This is entirely a proof-of-concept draft patch, any tips on where to insert dmesg clear and collect code would be greatly appreciated. FYI: we've also considered adding a configure option (ie. --without-oom) to ltp that prevents the OOM tests (ltp/testcases/kernel/mem/oom) from compiling entirely. I talked with the upstream, and they suggested just skipping these tests using: runltp -S SKIPFILE Skip tests specified in SKIPFILE Signed-off-by: Mingde (Matthew) Zeng --- meta/lib/oeqa/runtime/cases/ltp.py | 11 +++ 1 file changed, 11 insertions(+) diff --git a/meta/lib/oeqa/runtime/cases/ltp.py b/meta/lib/oeqa/runtime/cases/ltp.py index 6dc5ef22ad..1e90df2086 100644 --- a/meta/lib/oeqa/runtime/cases/ltp.py +++ b/meta/lib/oeqa/runtime/cases/ltp.py @@ -65,11 +65,22 @@ class LtpTest(LtpTestBase): ltp_groups += ltp_fs def runltp(self, ltp_group): +(status, dmesg_c_output) = self.target.run("dmesg -c") +print("dmesg -c output:") +print(dmesg_c_output) + cmd = '/opt/ltp/runltp -f %s -p -q -r /opt/ltp -l /opt/ltp/results/%s -I 1 -d /opt/ltp' % (ltp_group, ltp_group) starttime = time.time() (status, output) = self.target.run(cmd) endtime = time.time() +(status, output) = self.target.run("stat /proc/sysrq-trigger && echo f > /proc/sysrq-trigger || echo '/proc/sysrq-trigger does not exist'") +if output != '/proc/sysrq-trigger does not exist': +(status, dmesg_output) = self.target.run("dmesg") +print("dmesg output:") +print(dmesg_output) +self.assertEqual(dmesg_c_output, dmesg_output) + with open(os.path.join(self.ltptest_log_dir, "%s-raw.log" % ltp_group), 'w') as f: f.write(output) -- 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#140935): https://lists.openembedded.org/g/openembedded-core/message/140935 Mute This Topic: https://lists.openembedded.org/mt/75770422/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] ltp: remove --with-power-management-testsuite from EXTRA_OECONF
Commit [b74bbed51b0c0d44b70b136326a8a23cbc64db01 power_management: compile testcases/kernel/power_management by default] from ltp upstream removed --with-power-management-testsuite option, it's on by default. Signed-off-by: Mingde (Matthew) Zeng --- meta/recipes-extended/ltp/ltp_20200515.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-extended/ltp/ltp_20200515.bb b/meta/recipes-extended/ltp/ltp_20200515.bb index b283add12f..ece3acf0f9 100644 --- a/meta/recipes-extended/ltp/ltp_20200515.bb +++ b/meta/recipes-extended/ltp/ltp_20200515.bb @@ -50,7 +50,7 @@ export exec_prefix = "/opt/${PN}" PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl," EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4" -EXTRA_OECONF = " --with-power-management-testsuite --with-realtime-testsuite --with-open-posix-testsuite " +EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite " # ltp network/rpc test cases ftbfs when libtirpc is found EXTRA_OECONF += " --without-tirpc " -- 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#140873): https://lists.openembedded.org/g/openembedded-core/message/140873 Mute This Topic: https://lists.openembedded.org/mt/75732146/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/2] quilt: do not test patch-wrapper as it is not enabled
Can we get an update regarding the status of this patch? It is to fix https://bugzilla.yoctoproject.org/show_bug.cgi?id=13841 which the target milestone is set to 3.1 M4. Thanks, Matthew Alexander Kanavin writes: > Upstream only enables the test if --with-patch-wrapper > was supplied to ./configure, and so should we. > > Signed-off-by: Alexander Kanavin > --- > meta/recipes-devtools/quilt/quilt.inc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta/recipes-devtools/quilt/quilt.inc > b/meta/recipes-devtools/quilt/quilt.inc > index d6d06c049c..d2db079e0b 100644 > --- a/meta/recipes-devtools/quilt/quilt.inc > +++ b/meta/recipes-devtools/quilt/quilt.inc > @@ -71,6 +71,9 @@ do_install_ptest() { > tar -c --exclude=mail.test --exclude=delete.test test/ | ( cd > ${D}${PTEST_PATH} && tar -xf - && chmod 777 test) > cp ${WORKDIR}/Makefile ${D}${PTEST_PATH} > cp ${WORKDIR}/test.sh ${D}${PTEST_PATH} > + > + # This is specifically excluded when --with-patch-wrapper is absent > during ./configure > + rm ${D}${PTEST_PATH}/test/patch-wrapper.test > } > > PACKAGES += "guards guards-doc" -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#137246): https://lists.openembedded.org/g/openembedded-core/message/137246 Mute This Topic: https://lists.openembedded.org/mt/72528131/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] avahi: add LICENSE for individual packages
Fixes [YOCTO #13609] avahi_0.7.bb defines 9 PACKAGES. However, avahi.inc generically sets LICENSE to "GPLv2+ & LGPLv2.1+". The library specific packages should be LGPLv2.1+ only. Signed-off-by: Matthew Zeng --- meta/recipes-connectivity/avahi/avahi_0.7.bb | 10 ++ 1 file changed, 10 insertions(+) diff --git a/meta/recipes-connectivity/avahi/avahi_0.7.bb b/meta/recipes-connectivity/avahi/avahi_0.7.bb index 2e04d304c7..24523c7f81 100644 --- a/meta/recipes-connectivity/avahi/avahi_0.7.bb +++ b/meta/recipes-connectivity/avahi/avahi_0.7.bb @@ -10,6 +10,16 @@ inherit update-rc.d systemd useradd PACKAGES =+ "libavahi-gobject avahi-daemon libavahi-common libavahi-core libavahi-client avahi-dnsconfd libavahi-glib avahi-autoipd avahi-utils" +LICENSE_libavahi-gobject = "LGPLv2.1+" +LICENSE_avahi-daemon = "LGPLv2.1+" +LICENSE_libavahi-common = "LGPLv2.1+" +LICENSE_libavahi-core = "LGPLv2.1+" +LICENSE_avahi-client = "LGPLv2.1+" +LICENSE_avahi-dnsconfd = "LGPLv2.1+" +LICENSE_libavahi-glib = "LGPLv2.1+" +LICENSE_avahi-autoipd = "LGPLv2.1+" +LICENSE_avahi-utils = "LGPLv2.1+" + # As avahi doesn't put any files into PN, clear the files list to avoid problems # if extra libraries appear. FILES_${PN} = "" -- Mingde (Matthew) Zeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#136801): https://lists.openembedded.org/g/openembedded-core/message/136801 Mute This Topic: https://lists.openembedded.org/mt/72591668/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] perl: fix lib/warnings test on core-image-sato
Fixes [YOCTO #13296] The lib/warnings test fails on certain images such as core-image-sato. The upstream has already fixed this issue, thus submitting the relevent backport patch. Signed-off-by: Matthew Zeng -- Mingde (Matthew) Zeng --- ...rl-134117-Close-DATA-in-loc_tools.pl.patch | 30 +++ meta/recipes-devtools/perl/perl_5.30.1.bb | 2 +- 2 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch diff --git a/meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch b/meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch new file mode 100644 index 00..79cae0d6fa --- /dev/null +++ b/meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch @@ -0,0 +1,30 @@ +From a04a75f20f03aa08ce8118b3b0b3f93eb3e997c5 Mon Sep 17 00:00:00 2001 +From: Richard Leach +Date: Sun, 19 May 2019 20:16:41 + +Subject: [PATCH] PATCH: [perl #134117] Close DATA in loc_tools.pl + +This prevents unexpected text and fixes test lib/warnings.t + +Upstream-Status: Backport [a04a75f20f03aa08ce8118b3b0b3f93eb3e997c5] + +Signed-off-by: Matthew Zeng + +--- + t/loc_tools.pl | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/t/loc_tools.pl b/t/loc_tools.pl +index c76e29388a..beebd98d88 100644 +--- a/t/loc_tools.pl b/t/loc_tools.pl +@@ -421,7 +421,7 @@ sub find_locales ($;$) { + } + + # The rest of the locales are in this file. +-push @Data, ; ++push @Data, ; close DATA; + + foreach my $line (@Data) { + my ($locale_name, $language_codes, $country_codes, $encodings) = +-- +2.25.0 diff --git a/meta/recipes-devtools/perl/perl_5.30.1.bb b/meta/recipes-devtools/perl/perl_5.30.1.bb index 4869012b1a..9d747aa5b4 100644 --- a/meta/recipes-devtools/perl/perl_5.30.1.bb +++ b/meta/recipes-devtools/perl/perl_5.30.1.bb @@ -21,6 +21,7 @@ SRC_URI = "https://www.cpan.org/src/5.0/perl-${PV}.tar.gz;name=perl \ file://0001-enc2xs-Add-environment-variable-to-suppress-comments.patch \ file://0002-Constant-Fix-up-shebang.patch \ file://0001-tests-adjust-to-correctly-exclude-unbuilt-extensions.patch \ + file://0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch \ file://determinism.patch \ file://racefix.patch \ " @@ -388,4 +389,3 @@ EOF chmod 0755 ${SYSROOT_DESTDIR}${bindir}/nativeperl cat ${SYSROOT_DESTDIR}${bindir}/nativeperl } - -- 2.24.0 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] perl: fix lib/warnings test on core-image-sato
Fixes [YOCTO #13296] The lib/warnings test fails on certain images such as core-image-sato. The upstream has already fixed this issue, thus submitting the relevent backport patch. Signed-off-by: Matthew Zeng -- Mingde (Matthew) Zeng --- ...rl-134117-Close-DATA-in-loc_tools.pl.patch | 30 +++ meta/recipes-devtools/perl/perl_5.30.1.bb | 2 +- 2 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch diff --git a/meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch b/meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch new file mode 100644 index 00..2ca9f35f4a --- /dev/null +++ b/meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch @@ -0,0 +1,30 @@ +From a04a75f20f03aa08ce8118b3b0b3f93eb3e997c5 Mon Sep 17 00:00:00 2001 +From: Richard Leach +Date: Sun, 19 May 2019 20:16:41 + +Subject: [PATCH] PATCH: [perl #134117] Close DATA in loc_tools.pl + +This prevents unexpected text and fixes test lib/warnings.t + +Upstream Status: Backport [a04a75f20f03aa08ce8118b3b0b3f93eb3e997c5] + +Signed-off-By: Matthew Zeng + +--- + t/loc_tools.pl | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/t/loc_tools.pl b/t/loc_tools.pl +index c76e29388a..beebd98d88 100644 +--- a/t/loc_tools.pl b/t/loc_tools.pl +@@ -421,7 +421,7 @@ sub find_locales ($;$) { + } + + # The rest of the locales are in this file. +-push @Data, ; ++push @Data, ; close DATA; + + foreach my $line (@Data) { + my ($locale_name, $language_codes, $country_codes, $encodings) = +-- +2.25.0 diff --git a/meta/recipes-devtools/perl/perl_5.30.1.bb b/meta/recipes-devtools/perl/perl_5.30.1.bb index 4869012b1a..9d747aa5b4 100644 --- a/meta/recipes-devtools/perl/perl_5.30.1.bb +++ b/meta/recipes-devtools/perl/perl_5.30.1.bb @@ -21,6 +21,7 @@ SRC_URI = "https://www.cpan.org/src/5.0/perl-${PV}.tar.gz;name=perl \ file://0001-enc2xs-Add-environment-variable-to-suppress-comments.patch \ file://0002-Constant-Fix-up-shebang.patch \ file://0001-tests-adjust-to-correctly-exclude-unbuilt-extensions.patch \ + file://0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch \ file://determinism.patch \ file://racefix.patch \ " @@ -388,4 +389,3 @@ EOF chmod 0755 ${SYSROOT_DESTDIR}${bindir}/nativeperl cat ${SYSROOT_DESTDIR}${bindir}/nativeperl } - -- 2.24.0 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] perl: fix lib/warnings test on core-image-sato
Fixes [YOCTO #13296] The lib/warnings test fails on certain images such as core-image-sato. The upstream has already fixed this issue, thus submitting the relevent backport patch. Signed-off-by: Matthew Zeng -- Mingde (Matthew) Zeng --- ...rl-134117-Close-DATA-in-loc_tools.pl.patch | 30 +++ meta/recipes-devtools/perl/perl_5.30.1.bb | 2 +- 2 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch diff --git a/meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch b/meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch new file mode 100644 index 00..2ca9f35f4a --- /dev/null +++ b/meta/recipes-devtools/perl/files/0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch @@ -0,0 +1,30 @@ +From a04a75f20f03aa08ce8118b3b0b3f93eb3e997c5 Mon Sep 17 00:00:00 2001 +From: Richard Leach +Date: Sun, 19 May 2019 20:16:41 + +Subject: [PATCH] PATCH: [perl #134117] Close DATA in loc_tools.pl + +This prevents unexpected text and fixes test lib/warnings.t + +Upstream Status: Backport [a04a75f20f03aa08ce8118b3b0b3f93eb3e997c5] + +Signed-off-By: Matthew Zeng + +--- + t/loc_tools.pl | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/t/loc_tools.pl b/t/loc_tools.pl +index c76e29388a..beebd98d88 100644 +--- a/t/loc_tools.pl b/t/loc_tools.pl +@@ -421,7 +421,7 @@ sub find_locales ($;$) { + } + + # The rest of the locales are in this file. +-push @Data, ; ++push @Data, ; close DATA; + + foreach my $line (@Data) { + my ($locale_name, $language_codes, $country_codes, $encodings) = +-- +2.25.0 diff --git a/meta/recipes-devtools/perl/perl_5.30.1.bb b/meta/recipes-devtools/perl/perl_5.30.1.bb index 4869012b1a..9d747aa5b4 100644 --- a/meta/recipes-devtools/perl/perl_5.30.1.bb +++ b/meta/recipes-devtools/perl/perl_5.30.1.bb @@ -21,6 +21,7 @@ SRC_URI = "https://www.cpan.org/src/5.0/perl-${PV}.tar.gz;name=perl \ file://0001-enc2xs-Add-environment-variable-to-suppress-comments.patch \ file://0002-Constant-Fix-up-shebang.patch \ file://0001-tests-adjust-to-correctly-exclude-unbuilt-extensions.patch \ + file://0001-PATCH-perl-134117-Close-DATA-in-loc_tools.pl.patch \ file://determinism.patch \ file://racefix.patch \ " @@ -388,4 +389,3 @@ EOF chmod 0755 ${SYSROOT_DESTDIR}${bindir}/nativeperl cat ${SYSROOT_DESTDIR}${bindir}/nativeperl } - -- 2.24.0 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [zeus][PATCH] openssh: backport patch to fix "cert not yet valid" test
Alex Kiernan writes: > On Fri, Feb 21, 2020 at 11:28 AM Richard Purdie > wrote: >> >> On Fri, 2020-02-21 at 11:29 +0800, Anuj Mittal wrote: >> > Fixes [YOCTO #13796] >> > >> > Signed-off-by: Anuj Mittal >> >> Is this issue already addressed in master (maybe through upgrade)? >> > > We already had that patch in master which I dropped that patch as part > of the move to 8.2p1 (was > 0001-Manually-applied-upstream-fix-for-openssh-test.patch) Right, there was an upgrade to 8.2p1. We can do the same for zeus. > > -- > Alex Kiernan -- Mingde (Matthew) Zeng -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [zeus][PATCH] openssh: backport patch to fix "cert not yet valid" test
>> Fixes [YOCTO #13796] > Could you please take ownership of the bug. Its weird we both worked on > the same issue and had a fix done about the same time. What's weirder is that we three worked on this same issue, and it was merged to master last month. https://git.openembedded.org/openembedded-core/commit/meta/recipes-connectivity/openssh?id=f0a949fe33da47fd0a587abb942ff60f0a56ed0d > > Ill replace my version in stable/zeus-nut with this patch. > > - Armin I think it's reasonable to simply port this commit from master into zeus. Regards, Matthew >> >> Signed-off-by: Anuj Mittal >> --- >> ...at-bozo-decided-to-use-2020-as-a-future-d.patch | 46 >> ++ >> meta/recipes-connectivity/openssh/openssh_8.0p1.bb | 1 + >> 2 files changed, 47 insertions(+) >> create mode 100644 >> meta/recipes-connectivity/openssh/openssh/0001-upstream-what-bozo-decided-to-use-2020-as-a-future-d.patch >> >> diff --git >> a/meta/recipes-connectivity/openssh/openssh/0001-upstream-what-bozo-decided-to-use-2020-as-a-future-d.patch >> >> b/meta/recipes-connectivity/openssh/openssh/0001-upstream-what-bozo-decided-to-use-2020-as-a-future-d.patch >> new file mode 100644 >> index 000..e2930c3 >> --- /dev/null >> +++ >> b/meta/recipes-connectivity/openssh/openssh/0001-upstream-what-bozo-decided-to-use-2020-as-a-future-d.patch >> @@ -0,0 +1,46 @@ >> +From 30a2ab597b8273bddf08e9a3cc5551d7e530 Mon Sep 17 00:00:00 2001 >> +From: "d...@openbsd.org" >> +Date: Fri, 3 Jan 2020 03:02:26 + >> +Subject: [PATCH] upstream: what bozo decided to use 2020 as a future date >> in a >> + regress >> + >> +test? >> + >> +OpenBSD-Regress-ID: 3b953df5a7e14081ff6cf495d4e8d40e153cbc3a >> + >> +Upstream-Status: Backport >> [https://github.com/openssh/openssh-portable/commit/ff31f15773ee173502eec4d7861ec56f26bba381] >> + >> +[Dropped the script version and copyright year change at the top] >> + >> +Signed-off-by: Anuj Mittal >> +--- >> + regress/cert-hostkey.sh | 2 +- >> + regress/cert-userkey.sh | 2 +- >> + 2 files changed, 2 insertions(+), 2 deletions(-) >> + >> +diff --git a/regress/cert-hostkey.sh b/regress/cert-hostkey.sh >> +index 3ce7779..74d5a53 100644 >> +--- a/regress/cert-hostkey.sh >> b/regress/cert-hostkey.sh >> +@@ -248,7 +248,7 @@ test_one() { >> + test_one "user-certificate"failure "-n $HOSTS" >> + test_one "empty principals"success "-h" >> + test_one "wrong principals"failure "-h -n foo" >> +-test_one "cert not yet valid" failure "-h -V20200101:20300101" >> ++test_one "cert not yet valid" failure "-h -V20300101:20320101" >> + test_one "cert expired"failure "-h -V19800101:19900101" >> + test_one "cert valid interval" success "-h -V-1w:+2w" >> + test_one "cert has constraints"failure "-h -Oforce-command=false" >> +diff --git a/regress/cert-userkey.sh b/regress/cert-userkey.sh >> +index 6849e99..de455b8 100644 >> +--- a/regress/cert-userkey.sh >> b/regress/cert-userkey.sh >> +@@ -327,7 +327,7 @@ test_one() { >> + test_one "correct principal" success "-n ${USER}" >> + test_one "host-certificate"failure "-n ${USER} -h" >> + test_one "wrong principals"failure "-n foo" >> +-test_one "cert not yet valid" failure "-n ${USER} -V20200101:20300101" >> ++test_one "cert not yet valid" failure "-n ${USER} -V20300101:20320101" >> + test_one "cert expired"failure "-n ${USER} -V19800101:19900101" >> + test_one "cert valid interval" success "-n ${USER} -V-1w:+2w" >> + test_one "wrong source-address"failure "-n ${USER} >> -Osource-address=10.0.0.0/8" >> diff --git a/meta/recipes-connectivity/openssh/openssh_8.0p1.bb >> b/meta/recipes-connectivity/openssh/openssh_8.0p1.bb >> index 2ffbc9a..3d16f9d 100644 >> --- a/meta/recipes-connectivity/openssh/openssh_8.0p1.bb >> +++ b/meta/recipes-connectivity/openssh/openssh_8.0p1.bb >> @@ -25,6 +25,7 @@ SRC_URI = >> "http://ftp.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-${PV}.tar >> file://sshd_check_keys \ >> file://add-test-support-for-busybox.patch \ >> >> file://0001-upstream-fix-integer-overflow-in-XMSS-private-key-pa.patch \ >> + >> file://0001-upstream-what-bozo-decided-to-use-2020-as-a-future-d.patch \ >> " >> SRC_URI[md5sum] = "bf050f002fe510e1daecd39044e1122d" >> SRC_URI[sha256sum] = >> "bd943879e69498e8031eb6b7f44d08cdc37d59a7ab689aa0b437320c3481fd68" -- Mingde (Matthew) Zeng -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v2] glib-2.0: add dependencies to fix ptest failures
There are a number of ptest failures due to executables not found in the image. Since these executables are in FILES_${PN}-dev, depending all of -dev which is an overkill. We take them out of -dev and put in -utils, then depend on the latter instead. When starting a glib ptest but decided to Ctrl-c interrupt midway, ./run-ptest cannot be restarted unless running `userdel glib2-test` manually. Therefore adding a check prior to ptest will ensure the ptest can be restarted. Signed-off-by: Matthew Zeng --- meta/recipes-core/glib-2.0/glib-2.0/run-ptest | 3 +++ meta/recipes-core/glib-2.0/glib.inc | 12 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/meta/recipes-core/glib-2.0/glib-2.0/run-ptest b/meta/recipes-core/glib-2.0/glib-2.0/run-ptest index fc50082c8e..7a231b514b 100644 --- a/meta/recipes-core/glib-2.0/glib-2.0/run-ptest +++ b/meta/recipes-core/glib-2.0/glib-2.0/run-ptest @@ -1,6 +1,9 @@ #! /bin/sh set -eux +if id -u glib2-test; then + userdel glib2-test +fi useradd glib2-test su glib2-test -c 'gnome-desktop-testing-runner glib' userdel glib2-test diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc index f4aff297e5..23c347dbf7 100644 --- a/meta/recipes-core/glib-2.0/glib.inc +++ b/meta/recipes-core/glib-2.0/glib.inc @@ -58,13 +58,15 @@ FILES_${PN} = "${libdir}/lib*${SOLIBS} \ ${libdir}/gio \ ${libexecdir}/*gio-querymodules \ ${datadir}/glib-2.0/schemas" + +FILES_${PN}-utils += "${bindir}/glib-genmarshal \ + ${bindir}/glib-gettextize \ + ${bindir}/glib-mkenums \ + ${bindir}/glib-compile-resources" + FILES_${PN}-dev += "${libdir}/glib-2.0/include \ ${libdir}/gio/modules/lib*${SOLIBSDEV} \ ${libdir}/gio/modules/*.la \ -${bindir}/glib-genmarshal \ -${bindir}/glib-gettextize \ -${bindir}/glib-mkenums \ -${bindir}/glib-compile-resources \ ${datadir}/glib-2.0/gettext/po/Makefile.in.in \ ${datadir}/glib-2.0/schemas/gschema.dtd \ ${datadir}/glib-2.0/valgrind/glib.supp \ @@ -138,6 +140,8 @@ CODEGEN_PYTHON_RDEPENDS_mingw32 = "" RDEPENDS_${PN}-codegen += "${CODEGEN_PYTHON_RDEPENDS}" +RDEPENDS_${PN}-ptest += "${PN}-utils" + RDEPENDS_${PN}-ptest += "\ coreutils \ libgcc \ -- 2.24.0 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] glib-2.0: add -dev dependencies to fix ptest failures
There are a number of ptest failures due to glib-genmarshal, glib-mkenums and couple other executables not in the image. Since these executables are in FILES_${PN}-dev, we add ${PN}-dev to ptest RDEPENDS. When starting a glib ptest but decided to Ctrl-c interrupt midway, ./run-ptest cannot be restarted unless running `userdel glib2-test` manually. Therefore adding a check prior to ptest will ensure the ptest can be restarted. Signed-off-by: Matthew Zeng --- meta/recipes-core/glib-2.0/glib-2.0/run-ptest | 3 +++ meta/recipes-core/glib-2.0/glib.inc | 3 +++ 2 files changed, 6 insertions(+) diff --git a/meta/recipes-core/glib-2.0/glib-2.0/run-ptest b/meta/recipes-core/glib-2.0/glib-2.0/run-ptest index fc50082c8e..7a231b514b 100644 --- a/meta/recipes-core/glib-2.0/glib-2.0/run-ptest +++ b/meta/recipes-core/glib-2.0/glib-2.0/run-ptest @@ -1,6 +1,9 @@ #! /bin/sh set -eux +if id -u glib2-test; then + userdel glib2-test +fi useradd glib2-test su glib2-test -c 'gnome-desktop-testing-runner glib' userdel glib2-test diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc index f4aff297e5..7204fc908a 100644 --- a/meta/recipes-core/glib-2.0/glib.inc +++ b/meta/recipes-core/glib-2.0/glib.inc @@ -138,6 +138,9 @@ CODEGEN_PYTHON_RDEPENDS_mingw32 = "" RDEPENDS_${PN}-codegen += "${CODEGEN_PYTHON_RDEPENDS}" +RDEPENDS_${PN}-ptest += "${PN}-dev" +INSANE_SKIP_${PN}-ptest += "dev-deps" + RDEPENDS_${PN}-ptest += "\ coreutils \ libgcc \ -- 2.24.0 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCHv2] kbd: make libkbdfile-test08 ptest work for multilib
This patch fixes kbd ptest libkbdfile-test08 failure in 64-bit images. ```sh root@intel-x86-64:/usr/lib64/kbd/ptest# ./run-ptest make: Entering directory '/usr/lib64/kbd/ptest/tests' make[1]: Entering directory '/usr/lib64/kbd/ptest/tests' PASS: libkbdfile-test01 PASS: libkbdfile-test02 PASS: libkbdfile-test03 PASS: libkbdfile-test04 PASS: libkbdfile-test05 PASS: libkbdfile-test06 PASS: libkbdfile-test07 FAIL: libkbdfile-test08 PASS: libkbdfile-test09 ... ``` `DATADIR` and `ABS_DATADIR` are compile flags defined in ./kbd/tests/Makefile.am. `DATADIR` is the relative directory of kbd, i.e `./kbd/ptest/tests` whereas `ABS_DATADIR` is the full directory path, i.e `/usr/lib/kbd/ptest/tests`. The latter has a problem when building ptests for a 64-bit image, because the tests folder is located at `/usr/lib64/kbd/ptest/tests` instead. Therefore `ABS_DATADIR` is changed to `DATADIR`, also consistent with what *every other* kbd test is doing. The test searches DATADIR recursively for a file named `test0.map`, but it finds the wrong file at `/findfile/test_0/keymaps/test0.map`, while it actually needs `/findfile/test_0/keymaps/i386/qwerty/test0.map`. Thus appending `/i386` to `dirpath` so that `libkbdfile-test08.c` finds the right test file. Signed-off-by: Matthew Zeng --- ...append-i386-to-fix-libkbdfile-test08.patch | 45 +++ meta/recipes-core/kbd/kbd_2.2.0.bb| 1 + 2 files changed, 46 insertions(+) create mode 100644 meta/recipes-core/kbd/kbd/0001-Use-DATADIR-and-append-i386-to-fix-libkbdfile-test08.patch diff --git a/meta/recipes-core/kbd/kbd/0001-Use-DATADIR-and-append-i386-to-fix-libkbdfile-test08.patch b/meta/recipes-core/kbd/kbd/0001-Use-DATADIR-and-append-i386-to-fix-libkbdfile-test08.patch new file mode 100644 index 00..54e4dc9034 --- /dev/null +++ b/meta/recipes-core/kbd/kbd/0001-Use-DATADIR-and-append-i386-to-fix-libkbdfile-test08.patch @@ -0,0 +1,45 @@ +From 4c12f76f4177cfd560cf708a16774ebfadbd41a5 Mon Sep 17 00:00:00 2001 +From: "Mingde (Matthew) Zeng" +Date: Wed, 22 Jan 2020 11:02:17 -0500 +Subject: [PATCH] Use DATADIR and append i386 to fix libkbdfile-test08 ptest + failure + +Replace ABS_DATADIR with DATADIR and append i386 to dirpath. + +Upstream-Status: Inappropriate [OE specific] + +This OE specific patch applies to kbd v2.2.0 for now, the upstream +made drastic changes since v2.2.0, in fact they got rid of ABS_DATADIR +in commit 5b6df5c along with a series of other commits which may or +may not fix this issue. We will find out in future releases. + +Signed-off-by: Matthew Zeng +--- + tests/libkbdfile-test08.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/tests/libkbdfile-test08.c b/tests/libkbdfile-test08.c +index bf41707..5e287f1 100644 +--- a/tests/libkbdfile-test08.c b/tests/libkbdfile-test08.c +@@ -14,14 +14,14 @@ main(int __attribute__((unused)) argc, char **argv) + if (!fp) + kbd_error(EXIT_FAILURE, 0, "unable to create kbdfile"); + +- const char *const dirpath[] = { "", DATADIR "/findfile/test_0/keymaps/**", 0 }; ++ const char *const dirpath[] = { "", DATADIR "/findfile/test_0/keymaps/i386/**", 0 }; + const char *const suffixes[] = { "", ".map", ".kmap", 0 }; + +- const char *expect = ABS_DATADIR "/findfile/test_0/keymaps/i386/qwerty/test0.map"; ++ const char *expect = DATADIR "/findfile/test_0/keymaps/i386/qwerty/test0.map"; + + int rc = 0; + +- rc = kbdfile_find((char *)(ABS_DATADIR "/findfile/test_0/keymaps/i386/qwerty/test0"), (char **) dirpath, (char **) suffixes, fp); ++ rc = kbdfile_find((char *)"test0", (char **) dirpath, (char **) suffixes, fp); + + if (rc != 0) + kbd_error(EXIT_FAILURE, 0, "unable to find file"); +-- +2.24.1 + diff --git a/meta/recipes-core/kbd/kbd_2.2.0.bb b/meta/recipes-core/kbd/kbd_2.2.0.bb index df9b0bb90b..e13cea7634 100644 --- a/meta/recipes-core/kbd/kbd_2.2.0.bb +++ b/meta/recipes-core/kbd/kbd_2.2.0.bb @@ -16,6 +16,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/${BPN}/${BP}.tar.xz \ file://run-ptest \ ${@bb.utils.contains('DISTRO_FEATURES', 'ptest', 'file://set-proper-path-of-resources.patch', '', d)} \ file://0001-analyze.l-add-missing-string-format.patch \ + file://0001-Use-DATADIR-and-append-i386-to-fix-libkbdfile-test08.patch \ " SRC_URI[md5sum] = "d1d7ae0b5fb875dc082731e09cd0c8bc" -- 2.24.0 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] kbd: fix ptest libkbdfile-test08
`DATADIR` and `ABS_DATADIR` are compile flags defined in ./kbd/tests/Makefile.am. `DATADIR` is the relative directory of kbd, i.e `./kbd/ptest/tests` whereas `ABS_DATADIR` is the full directory path, i.e `/usr/lib/kbd/ptest/tests`. The latter has a problem when building ptests for a 64-bit image, because the tests folder is located at `/usr/lib64/kbd/ptest/tests` instead. Therefore `ABS_DATADIR` is changed to `DATADIR`, also consistent with what *every other* kbd test is doing. The test searches DATADIR recursively for a file named `test0.map`, but it finds the wrong file at `/findfile/test_0/keymaps/i386/qwerty/test0.map`, while it actually needs `/findfile/test_0/keymaps/i386/qwerty/test0.map`. Thus appending `/i386` to `dirpath` so that `libkbdfile-test08.c` finds the right test file. Signed-off-by: Matthew Zeng --- ...append-i386-to-fix-libkbdfile-test08.patch | 44 +++ meta/recipes-core/kbd/kbd_2.2.0.bb| 1 + 2 files changed, 45 insertions(+) create mode 100644 meta/recipes-core/kbd/kbd/0001-Use-DATADIR-and-append-i386-to-fix-libkbdfile-test08.patch diff --git a/meta/recipes-core/kbd/kbd/0001-Use-DATADIR-and-append-i386-to-fix-libkbdfile-test08.patch b/meta/recipes-core/kbd/kbd/0001-Use-DATADIR-and-append-i386-to-fix-libkbdfile-test08.patch new file mode 100644 index 00..ec40764c1d --- /dev/null +++ b/meta/recipes-core/kbd/kbd/0001-Use-DATADIR-and-append-i386-to-fix-libkbdfile-test08.patch @@ -0,0 +1,44 @@ +From 92c0fb720cf7b9966494e5eaa1f7a4ea8e0a34d2 Mon Sep 17 00:00:00 2001 +From: "Mingde (Matthew) Zeng" +Date: Wed, 22 Jan 2020 11:02:17 -0500 +Subject: [PATCH] Use DATADIR and append i386 to fix libkbdfile-test08 ptest + failure + +Replace ABS_DATADIR with DATADIR and append i386 to dirpath. + +Upstream-Status: Inappropriate [OE specific] + +This OE specific patch applies to kbd v2.2.0 for now, the upstream +made drastic changes since v2.2.0 which may or may not fix this +issue, we will find out in future releases. + +Signed-off-by: Matthew Zeng +--- + tests/libkbdfile-test08.c | 8 +++- + 1 file changed, 3 insertions(+), 5 deletions(-) + +diff --git a/tests/libkbdfile-test08.c b/tests/libkbdfile-test08.c +index bf41707..993fedc 100644 +--- a/tests/libkbdfile-test08.c b/tests/libkbdfile-test08.c +@@ -14,14 +14,12 @@ main(int __attribute__((unused)) argc, char **argv) + if (!fp) + kbd_error(EXIT_FAILURE, 0, "unable to create kbdfile"); + +- const char *const dirpath[] = { "", DATADIR "/findfile/test_0/keymaps/**", 0 }; ++ const char *const dirpath[] = { "", DATADIR "/findfile/test_0/keymaps/i386/**", 0 }; + const char *const suffixes[] = { "", ".map", ".kmap", 0 }; + +- const char *expect = ABS_DATADIR "/findfile/test_0/keymaps/i386/qwerty/test0.map"; ++ const char *expect = DATADIR "/findfile/test_0/keymaps/i386/qwerty/test0.map"; + +- int rc = 0; +- +- rc = kbdfile_find((char *)(ABS_DATADIR "/findfile/test_0/keymaps/i386/qwerty/test0"), (char **) dirpath, (char **) suffixes, fp); ++ int rc = kbdfile_find((char *)"test0", (char **) dirpath, (char **) suffixes, fp); + + if (rc != 0) + kbd_error(EXIT_FAILURE, 0, "unable to find file"); +-- +2.24.1 + diff --git a/meta/recipes-core/kbd/kbd_2.2.0.bb b/meta/recipes-core/kbd/kbd_2.2.0.bb index df9b0bb90b..e13cea7634 100644 --- a/meta/recipes-core/kbd/kbd_2.2.0.bb +++ b/meta/recipes-core/kbd/kbd_2.2.0.bb @@ -16,6 +16,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/utils/${BPN}/${BP}.tar.xz \ file://run-ptest \ ${@bb.utils.contains('DISTRO_FEATURES', 'ptest', 'file://set-proper-path-of-resources.patch', '', d)} \ file://0001-analyze.l-add-missing-string-format.patch \ + file://0001-Use-DATADIR-and-append-i386-to-fix-libkbdfile-test08.patch \ " SRC_URI[md5sum] = "d1d7ae0b5fb875dc082731e09cd0c8bc" -- 2.24.0 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] openssh: skip unit tests to avoid Makefile errors
> I think I have a better patch for this: > http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=akanavin/package-version-updates=c2fc852501414b06e6587d97d3bc944a4650906e > > Rather than hardcode upstream-specific targets, my patch uses a variable that > upstream uses to skip the tests. Sounds good, your patch should be merged instead. I do not see that there is already a patch available. Matthew -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] openssh: skip unit tests to avoid Makefile errors
As per do_compile_ptest first appeared in commit 1f7aaf76f4aa7875f05f4b838a5ec4594a4c35dc, regress/unittests/ binaries are already skipped. This will trigger a Makefile error when running ptest: ```sh /bin/sh: line 4: /usr/lib/openssh/ptest/regress/unittests/sshbuf/test_sshbuf: No such file or directory make: *** [Makefile:243: unit] Error 127 make: Target 'tests' not remade because of errors. ``` openssh/regress/Makefile: ``` tests: prep file-tests t-exec unit ``` Therefore we do not `make tests` as it consists of unit tests, we `make prep file-tests t-exec` instead. Signed-off-by: Matthew Zeng --- meta/recipes-connectivity/openssh/openssh/run-ptest | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/recipes-connectivity/openssh/openssh/run-ptest b/meta/recipes-connectivity/openssh/openssh/run-ptest index daf62cca5b..e5270ceade 100755 --- a/meta/recipes-connectivity/openssh/openssh/run-ptest +++ b/meta/recipes-connectivity/openssh/openssh/run-ptest @@ -4,7 +4,8 @@ export TEST_SHELL=sh cd regress sed -i "/\t\tagent-ptrace /d" Makefile -make -k .OBJDIR=`pwd` .CURDIR=`pwd` SUDO="sudo" tests \ + +make -k .OBJDIR=`pwd` .CURDIR=`pwd` SUDO="sudo" prep file-tests t-exec \ | sed -u -e 's/^skipped/SKIP: /g' -e 's/^ok /PASS: /g' -e 's/^failed/FAIL: /g' SSHAGENT=`which ssh-agent` @@ -41,4 +42,3 @@ EOF ${SSHAGENT} -k > /dev/null fi userdel openssh-test - -- 2.24.0 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [pyro][PATCH] staging.bbclass: handle postinst-useradd-* fixmes
From: Mikko YlinenAfter 02457ef7f600ce954874e2d11e74b1c6daaa3bfc, PSEUDO for postinst-useradd-* scripts get to use only one PSEUDO_LOCALSTATEDIR which is set under recipes ${WORKDIR}. When the those scripts are run in a clean build environment that is built from the sstate (populate_sysroot_setscene run for postinst-useradd-* providers), pseudo fails to run because it cannot access the PSEUDO_LOCALSTATEDIR (recipe ${WORKDIR}s do not exist). This triggers a sysroot staging error. Previously, the PSEUDO_LOCALSTATEDIR setting in useradd.bbclass worked because the RSS sstate/staging logic automagically processed ${STAGING_DIR_TARGET} in postinst-useradd-* scripts to point under the sysroot being built. The fix uses the same fixme processing by adding PSEUDO_LOCALSTATEDIR variable to it. Furthermore, LOGFIFO is added to be able to use the logging fifo of the recipe that actually runs postinst-useradd-*. Signed-off-by: Mikko Ylinen Signed-off-by: Ross Burton --- meta/classes/staging.bbclass | 2 +- meta/classes/useradd.bbclass | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/meta/classes/staging.bbclass b/meta/classes/staging.bbclass index a90cf43c94..984051d6aa 100644 --- a/meta/classes/staging.bbclass +++ b/meta/classes/staging.bbclass @@ -249,7 +249,7 @@ def staging_processfixme(fixme, target, recipesysroot, recipesysrootnative, d): if not fixme: return cmd = "sed -e 's:^[^/]*/:%s/:g' %s | xargs sed -i -e 's:FIXMESTAGINGDIRTARGET:%s:g; s:FIXMESTAGINGDIRHOST:%s:g'" % (target, " ".join(fixme), recipesysroot, recipesysrootnative) -for fixmevar in ['COMPONENTS_DIR', 'HOSTTOOLS_DIR', 'PKGDATA_DIR']: +for fixmevar in ['COMPONENTS_DIR', 'HOSTTOOLS_DIR', 'PKGDATA_DIR', 'PSEUDO_LOCALSTATEDIR', 'LOGFIFO']: fixme_path = d.getVar(fixmevar) cmd += " -e 's:FIXME_%s:%s:g'" % (fixmevar, fixme_path) bb.debug(2, cmd) diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass index 0f51e5522b..0f551b50f3 100644 --- a/meta/classes/useradd.bbclass +++ b/meta/classes/useradd.bbclass @@ -133,9 +133,10 @@ useradd_sysroot () { } # The export of PSEUDO in useradd_sysroot() above contains references to -# ${COMPONENTS_DIR}. These need to be handled when restoring +# ${COMPONENTS_DIR} and ${PSEUDO_LOCALSTATEDIR}. Additionally, the logging +# shell functions use ${LOGFIFO}. These need to be handled when restoring # postinst-useradd-${PN} from the sstate cache. -EXTRA_STAGING_FIXMES += "COMPONENTS_DIR" +EXTRA_STAGING_FIXMES += "COMPONENTS_DIR PSEUDO_LOCALSTATEDIR LOGFIFO" python useradd_sysroot_sstate () { task = d.getVar("BB_CURRENTTASK") -- 2.14.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] musl: prevent errors if do_install is run more than once
On Fri, Dec 1, 2017 at 2:13 PM, Khem Rajwrote: > On Fri, Dec 1, 2017 at 11:30 AM, Andre McCurdy wrote: >> On Fri, Dec 1, 2017 at 3:07 AM, Burton, Ross wrote: >>> Extend lnr to have a --force option? >> >> Is there ever a case where we want lnr to fail if the target already exists? >> >> There are plenty of existing examples in oe-core where rm is run >> before lnr (and in the cases where it's not, it's perhaps just a bug >> or an oversight). >> >> So I think either leave the v1 patch as-is and run rm before lnr in >> musl do_install as we already do elsewhere, or update lnr so that it >> unconditionally removes any pre-existing target? > > I like Ross'es suggestion to modify lnr implementation as an > independent patch and > rebase your patch on top. Maybe a cleanup later to remove all rm cmds > that are used > before lnr Do we keep the lnr filename? Change to ln-python and add -r and -f? The above question wasn't answered. Should we just always force it and emit a WARNING if it's being replaced? -M -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v2] u-boot: add workaround patch for missing python dev
Per the comments in the included patch: tools: disable _libfdt.so (swig present, python-dev missing breakage) This is probing for tools and enabling if swig is found, however Python libraries might be absent per the comment. This is just a host tool so let's just disable it entirely for the now. Signed-off-by: Matthew McClintock <msm-...@mcclintock.net> --- Notes: v2: added usptream status ...le-_libfdt.so-swig-present-python-dev-mis.patch | 34 ++ meta/recipes-bsp/u-boot/u-boot_2017.05.bb | 2 ++ 2 files changed, 36 insertions(+) create mode 100644 meta/recipes-bsp/u-boot/files/0001-tools-disable-_libfdt.so-swig-present-python-dev-mis.patch diff --git a/meta/recipes-bsp/u-boot/files/0001-tools-disable-_libfdt.so-swig-present-python-dev-mis.patch b/meta/recipes-bsp/u-boot/files/0001-tools-disable-_libfdt.so-swig-present-python-dev-mis.patch new file mode 100644 index 00..a71bb91894 --- /dev/null +++ b/meta/recipes-bsp/u-boot/files/0001-tools-disable-_libfdt.so-swig-present-python-dev-mis.patch @@ -0,0 +1,34 @@ +From 562ef1104558387d73365b50b86488f2d9aff653 Mon Sep 17 00:00:00 2001 +From: Matthew McClintock <msm-...@mcclintock.net> +Date: Thu, 6 Jul 2017 13:05:32 -0500 +Subject: [PATCH] tools: disable _libfdt.so (swig present, python-dev missing + breakage) + +This is probing for tools and enabling if swig is found, however Python +libraries might be absent per the comment. This is just a host tool so +let's just disable it entirely for the now. + +Signed-off-by: Matthew McClintock <msm-...@mcclintock.net> +Upstream-Status: Pending +--- + tools/Makefile | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/tools/Makefile b/tools/Makefile +index 2fc4a58..ac30086 100644 +--- a/tools/Makefile b/tools/Makefile +@@ -114,8 +114,8 @@ fit_check_sign-objs := $(dumpimage-mkimage-objs) fit_check_sign.o + + # Build a libfdt Python module if swig is available + # Use 'sudo apt-get install swig libpython-dev' to enable this +-hostprogs-y += \ +- $(if $(shell which swig 2> /dev/null),_libfdt.so) ++#hostprogs-y += \ ++# $(if $(shell which swig 2> /dev/null),_libfdt.so) + _libfdt.so-sharedobjs += $(LIBFDT_OBJS) + libfdt: + +-- +2.13.1 + diff --git a/meta/recipes-bsp/u-boot/u-boot_2017.05.bb b/meta/recipes-bsp/u-boot/u-boot_2017.05.bb index 37c21dcaa3..16d9563ce6 100644 --- a/meta/recipes-bsp/u-boot/u-boot_2017.05.bb +++ b/meta/recipes-bsp/u-boot/u-boot_2017.05.bb @@ -2,3 +2,5 @@ require u-boot-common_${PV}.inc require u-boot.inc DEPENDS += "bc-native dtc-native" + +SRC_URI += "file://0001-tools-disable-_libfdt.so-swig-present-python-dev-mis.patch" -- 2.13.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] u-boot: add workaround patch for missing python dev
Per the comments in the included patch: tools: disable _libfdt.so (swig present, python-dev missing breakage) This is probing for tools and enabling if swig is found, however Python libraries might be absent per the comment. This is just a host tool so let's just disable it entirely for the now. Signed-off-by: Matthew McClintock <msm-...@mcclintock.net> --- ...le-_libfdt.so-swig-present-python-dev-mis.patch | 33 ++ meta/recipes-bsp/u-boot/u-boot_2017.05.bb | 2 ++ 2 files changed, 35 insertions(+) create mode 100644 meta/recipes-bsp/u-boot/files/0001-tools-disable-_libfdt.so-swig-present-python-dev-mis.patch diff --git a/meta/recipes-bsp/u-boot/files/0001-tools-disable-_libfdt.so-swig-present-python-dev-mis.patch b/meta/recipes-bsp/u-boot/files/0001-tools-disable-_libfdt.so-swig-present-python-dev-mis.patch new file mode 100644 index 00..ac4b7b3032 --- /dev/null +++ b/meta/recipes-bsp/u-boot/files/0001-tools-disable-_libfdt.so-swig-present-python-dev-mis.patch @@ -0,0 +1,33 @@ +From 562ef1104558387d73365b50b86488f2d9aff653 Mon Sep 17 00:00:00 2001 +From: Matthew McClintock <msm-...@mcclintock.net> +Date: Thu, 6 Jul 2017 13:05:32 -0500 +Subject: [PATCH] tools: disable _libfdt.so (swig present, python-dev missing + breakage) + +This is probing for tools and enabling if swig is found, however Python +libraries might be absent per the comment. This is just a host tool so +let's just disable it entirely for the now. + +Signed-off-by: Matthew McClintock <msm-...@mcclintock.net> +--- + tools/Makefile | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/tools/Makefile b/tools/Makefile +index 2fc4a58..ac30086 100644 +--- a/tools/Makefile b/tools/Makefile +@@ -114,8 +114,8 @@ fit_check_sign-objs := $(dumpimage-mkimage-objs) fit_check_sign.o + + # Build a libfdt Python module if swig is available + # Use 'sudo apt-get install swig libpython-dev' to enable this +-hostprogs-y += \ +- $(if $(shell which swig 2> /dev/null),_libfdt.so) ++#hostprogs-y += \ ++# $(if $(shell which swig 2> /dev/null),_libfdt.so) + _libfdt.so-sharedobjs += $(LIBFDT_OBJS) + libfdt: + +-- +2.13.1 + diff --git a/meta/recipes-bsp/u-boot/u-boot_2017.05.bb b/meta/recipes-bsp/u-boot/u-boot_2017.05.bb index 37c21dcaa3..16d9563ce6 100644 --- a/meta/recipes-bsp/u-boot/u-boot_2017.05.bb +++ b/meta/recipes-bsp/u-boot/u-boot_2017.05.bb @@ -2,3 +2,5 @@ require u-boot-common_${PV}.inc require u-boot.inc DEPENDS += "bc-native dtc-native" + +SRC_URI += "file://0001-tools-disable-_libfdt.so-swig-present-python-dev-mis.patch" -- 2.13.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] Fwd: Recipe [patch] modification to generate a static library instead of shared library
On Thu, Apr 6, 2017 at 9:20 AM, Ravi chandra reddywrote: > Hi, > Is there any hidden pointer within these static dev packages. i > expected the library to be .a format. what can i understand from these > static dev packages, plz let me know. Can you expand on what you're trying to accomplish? Are you trying to build a static binary? I don't think you actually are trying to install libxml2.a on the running image are you? Maybe you really want an SDK with a sysroot populated with static libraries so you can link against them? -M -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] Fwd: Recipe [patch] modification to generate a static library instead of shared library
Do you have the staticdev packages in your TMPDIR? E.g. tmp/work/cortexa15t2hf-neon-rdk-linux-gnueabi/libxml2/2.9.4-r0/deploy-ipks/cortexa15t2hf-neon/libxml2-staticdev_2.9.4-r0_cortexa15t2hf-neon.ipk -M On Wed, Apr 5, 2017 at 1:09 PM, Ravi chandra reddy <vlsire...@gmail.com> wrote: > Hi, > Let me thank you guys for quick reply. > let me put my email in correct steps > > 1. below local/local.conf changes makes bitbake fail. > > IMAGE_INSTALL_append = "lib32-glibc lib32-libgcc > lib32-libstdc++ libedit libxml2-staticdev" > > error:= > == i get the following > errors== > ERROR: core-image-minimal-1.0-r0 do_rootfs: Function failed: do_rootfs > ERROR: Logfile of failure stored in: > /home/polar/zcu_yocto/poky/build/tmp/work/zcu102_zynqmp-poky-linux/core-image-minimal/1.0-r0/temp/log.do_rootfs.17721 > ERROR: Task 9 > (/home/polar/zcu_yocto/poky/meta/recipes-core/images/core-image-minimal.bb, > do_rootfs) failed with exit code '1' > NOTE: Tasks Summary: Attempted 2144 tasks of which 2143 didn't need to be > rerun and 1 failed. > === > > 2. without staticdev changes [in local/local.conf], it > [bitbake-core-image-minimal] goes through and it builds [but there is only > .so [dynamic library] generated] > > IMAGE_INSTALL_append = "lib32-glibc lib32-libgcc lib32-libstdc++ libedit > libxml2" > > > 3. i ran the search and found that all "no-static" lines are commented > > bitbake -e | grep static-libs > > > and all the "no-static-libs.inc" are commented [#] > > Thanks > RC > > On Wed, Apr 5, 2017 at 2:04 PM, Ravi chandra reddy <vlsire...@gmail.com> > wrote: >> >> Hi, >>in local/local.conf it [bitbake core-image-minimal] fails, if i use >> libxml2-staticdev >> >> # Specify the 32-bit libraries to be added to all images >> IMAGE_INSTALL_append = "lib32-glibc lib32-libgcc lib32-libstdc++ libedit >> libxml2-staticdev" >> >> == i get the following >> errors== >> ERROR: core-image-minimal-1.0-r0 do_rootfs: Function failed: do_rootfs >> ERROR: Logfile of failure stored in: >> /home/polar/zcu_yocto/poky/build/tmp/work/zcu102_zynqmp-poky-linux/core-image-minimal/1.0-r0/temp/log.do_rootfs.17721 >> ERROR: Task 9 >> (/home/polar/zcu_yocto/poky/meta/recipes-core/images/core-image-minimal.bb, >> do_rootfs) failed with exit code '1' >> NOTE: Tasks Summary: Attempted 2144 tasks of which 2143 didn't need to be >> rerun and 1 failed. >> === >> >> if i use as below, there is no issue. however there is no .so >> >> # Specify the 32-bit libraries to be added to all images >> IMAGE_INSTALL_append = "lib32-glibc lib32-libgcc lib32-libstdc++ libedit >> libxml2" >> >> i ran >> >> bitbake -e | grep static-libs >> >> and all the "no-static-libs.inc" are commented [#] >> >> Thanks >> RC >> >> >> >> On Wed, Apr 5, 2017 at 11:48 AM, Richard Purdie >> <richard.pur...@linuxfoundation.org> wrote: >>> >>> On Wed, 2017-04-05 at 10:33 -0500, Matthew McClintock wrote: >>> > On Wed, Apr 5, 2017 at 10:18 AM, Ravi chandra reddy <vlsireddy@gmail. >>> > com> wrote: >>> > > >>> > > Hi All, >>> > > I am using meta-oe to generate libxml2 library using >>> > > AARCH64 >>> > > compiler. However it generates shared object [.so] library. >>> > > >>> > > is there any setting in recipe to modify this, to generate static >>> > > library >>> > > [instead of shared library] >>> > > >>> > > if so, please point me to the recipe/file to change. >>> > > >>> > > if not, i will try to add it as patch, plz point me to appropriate >>> > > files to >>> > > change >>> > Is the ${PN}-staticdev package getting generated for you? >>> >>> Its possible you have conf/distro/include/no-static-libs.inc included >>> in your build (bitbake -e would tell you). >>> >>> If so, you could remove that include or set: >>> >>> DISABLE_STATIC = "" >>> >>> as it would currently be set to this if that include file is included: >>> >>> DISABLE_STATIC = " --disable-static" >>> >>> We tend not to build static libraries as they're a waste of space/time >>> on the most part. >>> >>> Cheers, >>> >>> Richard >> >> > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] Fwd: Recipe [patch] modification to generate a static library instead of shared library
On Wed, Apr 5, 2017 at 10:18 AM, Ravi chandra reddywrote: > Hi All, > I am using meta-oe to generate libxml2 library using AARCH64 > compiler. However it generates shared object [.so] library. > > is there any setting in recipe to modify this, to generate static library > [instead of shared library] > > if so, please point me to the recipe/file to change. > > if not, i will try to add it as patch, plz point me to appropriate files to > change Is the ${PN}-staticdev package getting generated for you? -M -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] utility-task: Add do_patchall task
Posted an alternate patch to bitbake mailing list. -M On Tue, Mar 7, 2017 at 4:33 PM, Paul Eggleton <paul.eggle...@linux.intel.com> wrote: > On Wednesday, 8 March 2017 9:47:23 AM NZDT Richard Purdie wrote: >> On Tue, 2017-03-07 at 13:48 -0600, Matthew McClintock wrote: >> > This is useful in a few scenarios: >> > >> > 1) A developer wants to be able to grep all the code in a particular >> > without having to run patch on various components until they guess >> > the >> > right one (e.g. which component is generating an error/warning?) >> > >> > 2) Other code scanning tools that can be run without requiring a full >> > image to be built (legal, static code analysis, etc) >> > >> > Signed-off-by: Matthew McClintock <msm-...@mcclintock.net> >> > --- >> > meta/classes/utility-tasks.bbclass | 7 +++ >> > meta/conf/documentation.conf | 1 + >> > 2 files changed, 8 insertions(+) >> >> I have mixed feelings on this. Whilst I can see the attraction, extra >> tasks like this do actually have a parsing overhead. We already have a >> lot of them and its only a question of time before someone wants >> another XXXall task adding. >> >> I'm wondering if we can solve this at the bitbake level instead with a >> new parameter instead? That would allow us to delete tasks and speed up >> parsing rather than slow things down. > > FYI there is a bug open for this (currently assigned to me, but it's in the > "new" state so anyone's welcome to take it): > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=7733 > > I suspect most of this would need to be handled in lib/bb/runqueue.py; > actually adding the option would be in main.py. > > Cheers, > Paul > > -- > > Paul Eggleton > Intel Open Source Technology Centre -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] utility-task: Add do_patchall task
On Tue, Mar 7, 2017 at 2:47 PM, Richard Purdie <richard.pur...@linuxfoundation.org> wrote: > On Tue, 2017-03-07 at 13:48 -0600, Matthew McClintock wrote: >> This is useful in a few scenarios: >> >> 1) A developer wants to be able to grep all the code in a particular >> without having to run patch on various components until they guess >> the >> right one (e.g. which component is generating an error/warning?) >> >> 2) Other code scanning tools that can be run without requiring a full >> image to be built (legal, static code analysis, etc) >> >> Signed-off-by: Matthew McClintock <msm-...@mcclintock.net> >> --- >> meta/classes/utility-tasks.bbclass | 7 +++ >> meta/conf/documentation.conf | 1 + >> 2 files changed, 8 insertions(+) > > I have mixed feelings on this. Whilst I can see the attraction, extra > tasks like this do actually have a parsing overhead. We already have a > lot of them and its only a question of time before someone wants > another XXXall task adding. > > I'm wondering if we can solve this at the bitbake level instead with a > new parameter instead? That would allow us to delete tasks and speed up > parsing rather than slow things down. Can you drop a few hints as to where to look to add this to bitbake? I can look at it a bit further. One other thing we were thinking about was doing for only things that will run on or be on the target (e.g. skipping the toolchain side). -M -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] utility-task: Add do_patchall task
This is useful in a few scenarios: 1) A developer wants to be able to grep all the code in a particular without having to run patch on various components until they guess the right one (e.g. which component is generating an error/warning?) 2) Other code scanning tools that can be run without requiring a full image to be built (legal, static code analysis, etc) Signed-off-by: Matthew McClintock <msm-...@mcclintock.net> --- meta/classes/utility-tasks.bbclass | 7 +++ meta/conf/documentation.conf | 1 + 2 files changed, 8 insertions(+) diff --git a/meta/classes/utility-tasks.bbclass b/meta/classes/utility-tasks.bbclass index da69c3a..b922685 100644 --- a/meta/classes/utility-tasks.bbclass +++ b/meta/classes/utility-tasks.bbclass @@ -64,3 +64,10 @@ do_fetchall[recideptask] = "do_${BB_DEFAULT_TASK}" do_fetchall() { : } + +addtask patchall after do_patch +do_patchall[recrdeptask] = "do_patchall do_patch" +do_patchall[recideptask] = "do_${BB_DEFAULT_TASK}" +do_patchall() { + : +} diff --git a/meta/conf/documentation.conf b/meta/conf/documentation.conf index 06527cb..5f4593c 100644 --- a/meta/conf/documentation.conf +++ b/meta/conf/documentation.conf @@ -40,6 +40,7 @@ do_package_write_rpm[doc] = "Creates the actual RPM packages and places them in do_package_write_tar[doc] = "Creates tar archives for packages and places them in the Package Feed area" do_packagedata[doc] = "Creates package metadata used by the build system to generate the final packages" do_patch[doc] = "Locates patch files and applies them to the source code" +do_patchall[doc] = "Fetches, unpacks, and patches the source for all the components in a particular target" do_populate_lic[doc] = "Writes license information for the recipe that is collected later when the image is constructed" do_populate_sdk[doc] = "Creates the file and directory structure for an installable SDK" do_populate_sysroot[doc] = "Copies a subset of files installed by do_install into the sysroot in order to make them available to other recipes" -- 2.7.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [oe] OEDAM - Portland 2017
I think some folks where going to try to get a ride share from the HIlton hotel. -M On Sun, Feb 19, 2017 at 4:12 AM, Trevor Woernerwrote: > Does anyone have any recommendations for how to get from the > conference venue to the Mentor Graphics office? > -- > ___ > Openembedded-devel mailing list > openembedded-de...@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] Fwd: Hello everyone
Hello all, If you need to contact me, please use this new email address msm-...@mcclintock.net, instead of m...@freescale.com or b29...@freescale.com. Thanks! -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH 4/4] oprofile: update patch for powerpc64
This is a more appropriate follow up patch from upstream. Also, only powerpc64 requires libpfm4 currently for this specific version of oprofile (x86, sparc can make use of libpfm but don't make use of it here) Additionally, this patch from upstream requires some more patches to be pulled into oprofile Signed-off-by: Matthew McClintock m...@freescale.com --- ...-events-to-be-specified-with-or-without-_.patch | 206 ...pecific-libpfm-usage-so-it-doesn-t-break-.patch | 130 .../0001-fix-powerpc-cross-compiling.patch | 35 ...p-lists-events-Fix-doc-URL-for-ppc64-arch.patch | 34 meta/recipes-kernel/oprofile/oprofile_0.9.8.bb |7 +- 5 files changed, 374 insertions(+), 38 deletions(-) create mode 100644 meta/recipes-kernel/oprofile/oprofile/0001-Allow-ppc64-events-to-be-specified-with-or-without-_.patch create mode 100644 meta/recipes-kernel/oprofile/oprofile/0001-Fix-PPC64-specific-libpfm-usage-so-it-doesn-t-break-.patch delete mode 100644 meta/recipes-kernel/oprofile/oprofile/0001-fix-powerpc-cross-compiling.patch create mode 100644 meta/recipes-kernel/oprofile/oprofile/0001-ophelp-lists-events-Fix-doc-URL-for-ppc64-arch.patch diff --git a/meta/recipes-kernel/oprofile/oprofile/0001-Allow-ppc64-events-to-be-specified-with-or-without-_.patch b/meta/recipes-kernel/oprofile/oprofile/0001-Allow-ppc64-events-to-be-specified-with-or-without-_.patch new file mode 100644 index 000..5eb8b8f --- /dev/null +++ b/meta/recipes-kernel/oprofile/oprofile/0001-Allow-ppc64-events-to-be-specified-with-or-without-_.patch @@ -0,0 +1,206 @@ +From 3602803297695f52e856f21920012fd64f79 Mon Sep 17 00:00:00 2001 +From: Maynard Johnson mayna...@us.ibm.com +Date: Fri, 11 Jan 2013 13:29:57 -0600 +Subject: [PATCH] Allow ppc64 events to be specified with or without _GRPn + suffix + +All events for IBM PowerPC server processors (except CYCLES) have +a _GRPn suffix. This is because the legacy opcontrol profiler +can only profile events in the same group (i.e., having the same +_GRPn suffix). But operf has no such restriction because it +can multiplex events; thus, so we should allow the user to pass +event names without the _GRPn suffix. + +Signed-off-by: Maynard Johnson mayna...@us.ibm.com +--- + doc/operf.1.in |6 +++ + doc/oprofile.xml | 12 +- + pe_profiling/operf.cpp | 107 + utils/ophelp.c |4 ++ + 4 files changed, 127 insertions(+), 2 deletions(-) + +diff --git a/doc/operf.1.in b/doc/operf.1.in +index b109324..03027ca 100644 +--- a/doc/operf.1.in b/doc/operf.1.in +@@ -110,6 +110,12 @@ be specified using the symbolic name. If no unit mask is specified, 0x0 will be + used as the default. + .P + .RS ++On IBM PowerPC systems, events may be specified with or without the ++.I _GRPn ++suffix. If no group number suffix is given, one will be automatically ++assigned; thus, OProfile post-processing tools will always show real event ++names that include the group number suffix. ++.P + When no event specification is given, the default event for the running + processor type will be used for profiling. + Use +diff --git a/doc/oprofile.xml b/doc/oprofile.xml +index 0ae2b0b..0f74726 100644 +--- a/doc/oprofile.xml b/doc/oprofile.xml +@@ -1106,10 +1106,18 @@ shown by the output of commandophelp/command. Unit masks with extra: para + specified using the symbolic name. + /para + notepara +-When using legacy mode commandopcontrol/command on PowerPC platforms, all events specified must be in the same group; ++When using legacy mode commandopcontrol/command on IBM PowerPC platforms, all events specified must be in the same group; + i.e., the group number appended to the event name (e.g. constantlt;emphasissome-event-name/emphasisgt;_GRP9 + /constant) must be the same. +-/para/note ++/para ++para ++When profiling with commandoperf/command on IBM PowerPC platforms, the above restriction ++regarding the same group number does not apply, and events may be ++specified with or without the group number suffix. If no group number suffix is given, one will be automatically ++assigned; thus, OProfile post-processing tools will always show real event ++names that include the group number suffix. ++/para ++/note + para + If OProfile is using timer-interrupt mode, there is no event configuration possible. + /para +diff --git a/pe_profiling/operf.cpp b/pe_profiling/operf.cpp +index 4416b29..a776e71 100644 +--- a/pe_profiling/operf.cpp b/pe_profiling/operf.cpp +@@ -1146,6 +1146,108 @@ static void _get_event_code(operf_event_t * event) + event-evt_code = config; + } + ++#if (defined(__powerpc__) || defined(__powerpc64__)) ++/* All ppc64 events (except CYCLES) have a _GRPn suffix. This is ++ * because the legacy opcontrol profiler can only profile events in ++ * the same group (i.e., having the same _GRPn suffix). But operf ++ * can multiplex events, so we should allow
[OE-core] [PATCH 2/4] gcc-common.inc: handle case where tune is not defined
Signed-off-by: Matthew McClintock m...@freescale.com --- meta/recipes-devtools/gcc/gcc-common.inc |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc index ad96989..6b61800 100644 --- a/meta/recipes-devtools/gcc/gcc-common.inc +++ b/meta/recipes-devtools/gcc/gcc-common.inc @@ -38,7 +38,7 @@ def get_gcc_multiarch_setting(bb, d): def get_tune_parameters(tune, d): availtunes = d.getVar('AVAILTUNES', True) if tune not in availtunes.split(): -bb.error('The tune: %s is not one of the available tunes: %s', tune, availtunes) +bb.error('The tune: %s is not one of the available tunes: %s', tune or None, availtunes) localdata = bb.data.createCopy(d) override = ':tune-' + tune -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [denzil 11/18] qemu-0.15.1: add patch to fix compilatation problems on powerpc
On Thu, Feb 7, 2013 at 5:56 PM, Mark Hatle mark.ha...@windriver.com wrote: From: Matthew McClintock m...@freescale.com ERROR: Function failed: do_compile (see /opt/yocto/cache-build/p5020ds-64b/build_p5020ds-64b_release/tmp/work/ppc64e5500-fsl-linux/qemu-0.15.1-r6/temp/log.do_compile.28447 for further information) ERROR: Logfile of failure stored in: /opt/yocto/cache-build/p5020ds-64b/build_p5020ds-64b_release/tmp/work/ppc64e5500-fsl-linux/qemu-0.15.1-r6/temp/log.do_compile.28447 Log data follows: | DEBUG: SITE files ['endian-big', 'bit-64', 'powerpc-common', 'common-linux', 'common-glibc', 'powerpc-linux', 'powerpc64-linux', 'common'] | ERROR: Function failed: do_compile (see /opt/yocto/cache-build/p5020ds-64b/build_p5020ds-64b_release/tmp/work/ppc64e5500-fsl-linux/qemu-0.15.1-r6/temp/log.do_compile.28447 for further information) | NOTE: make -j 24 | LINK ppc-linux-user/qemu-ppc | /opt/yocto/cache-build/p5020ds-64b/build_p5020ds-64b_release/tmp/sysroots/x86_64-linux/usr/libexec/ppc64e5500-fsl-linux/gcc/powerpc64-fsl-linux/4.6.4/ld:/opt/yocto/cache-build/p5020ds-64b/build_p5020ds-64b_release/tmp/work/ppc64e5500-fsl-linux/qemu-0.15.1-r6/qemu-0.15.1/ppc64.ld:84: syntax error | collect2: ld returned 1 exit status | make[1]: *** [qemu-ppc] Error 1 | make: *** [subdir-ppc-linux-user] Error 2 | make: *** Waiting for unfinished jobs | ERROR: oe_runmake failed Signed-off-by: Matthew McClintock m...@freescale.com (master rev: a9207aad5b163a071cd8298517d61514c587e0ed) Signed-off-by: Mark Hatle mark.ha...@windriver.com --- meta/recipes-devtools/qemu/qemu_0.15.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-devtools/qemu/qemu_0.15.1.bb b/meta/recipes-devtools/qemu/qemu_0.15.1.bb index b3fb354..2cc59f6 100644 --- a/meta/recipes-devtools/qemu/qemu_0.15.1.bb +++ b/meta/recipes-devtools/qemu/qemu_0.15.1.bb @@ -3,7 +3,7 @@ require qemu.inc LIC_FILES_CHKSUM = file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \ file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913 -PR = r8 +PR = r9 FILESPATH = ${FILE_DIRNAME}/qemu-${PV} FILESDIR = ${WORKDIR} -- 1.8.1.2.545.g2f19ada Missing a patch? -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] libpfm4: exclude from world
On Thu, Feb 7, 2013 at 4:43 PM, Saul Wold s...@linux.intel.com wrote: On 02/07/2013 06:33 AM, Martin Jansa wrote: Signed-off-by: Martin Jansa martin.ja...@gmail.com --- meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb b/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb index 460029f..438dbc3 100644 --- a/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb +++ b/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb @@ -24,3 +24,6 @@ S = ${WORKDIR}/libpfm-${PV} do_install () { oe_runmake install } + +# oprofile depends on it only for ppc* and it fails to build on arm +EXCLUDE_FROM_WORLD = 1 Should it be EXCLUDE_FROM_WORLD or COMPATIBLE_MACHINE= (*ppc*|mpc*) Since for a ppc world build it would be valid. We really need COMPATIBLE_ARCH here... Actually I've found since I tried to upstream my last patches that libpfm is only a req for ppc64. I'm going to submit some follow up patches once I hear back from the oprofile person I've been chatting with -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] libpfm4: exclude from world
On Tue, Feb 12, 2013 at 11:19 AM, Phil Blundell p...@pbcl.net wrote: On Tue, 2013-02-12 at 17:14 +, McClintock Matthew-B29882 wrote: We really need COMPATIBLE_ARCH here... Why can't you use COMPATIBLE_HOST? Yes, that's what it's called ;) -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH 3/5] libpfm4_4.3.0.bb: add libpfm4 recipe needed by oprofile for ppc
Signed-off-by: Matthew McClintock m...@freescale.com --- meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb diff --git a/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb b/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb new file mode 100644 index 000..460029f --- /dev/null +++ b/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb @@ -0,0 +1,26 @@ +SUMMARY = Monitoring tools exploiting the performance monitoring events +DESCRIPTION = This package provides a library, called libpfm4 which is used to develop \ +monitoring tools exploiting the performance monitoring events such as those \ +provided by the Performance Monitoring Unit (PMU) of modern processors. +HOMEPAGE = http://perfmon2.sourceforge.net/; +BUGTRACKER = http://sourceforge.net/tracker/?group_id=144822atid=759953source=navbar; + +LICENSE = MIT +LIC_FILES_CHKSUM = file://COPYING;md5=0de488f3bd4424e308e2e399cb99c788 + +SECTION = devel + +SRC_URI = http://downloads.sourceforge.net/project/perfmon2/libpfm4/libpfm-4.3.0.tar.gz; + +SRC_URI[md5sum] = 0ab272dbdbb759b852ba8bd06db030ef +SRC_URI[sha256sum] = a23eb9affbff279e13563a39317c0ad71c4de28908d4243c8bc109138430cc3b + +EXTRA_OEMAKE = DESTDIR=\${D}\ PREFIX=\${prefix}\ LIBDIR=\${libdir}\ LDCONFIG=\true\ +EXTRA_OEMAKE_append_powerpc = ARCH=\powerpc\ +EXTRA_OEMAKE_append_powerpc64 = ARCH=\powerpc\ BITMODE=\64\ + +S = ${WORKDIR}/libpfm-${PV} + +do_install () { + oe_runmake install +} -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH 5/5] oprofile: fix cross compile on powerpc and add libpfm4 dep
Fixes [YOCTO #3717] Signed-off-by: Matthew McClintock m...@freescale.com --- .../0001-fix-powerpc-cross-compiling.patch | 35 meta/recipes-kernel/oprofile/oprofile_0.9.8.bb |7 ++-- 2 files changed, 40 insertions(+), 2 deletions(-) create mode 100644 meta/recipes-kernel/oprofile/oprofile/0001-fix-powerpc-cross-compiling.patch diff --git a/meta/recipes-kernel/oprofile/oprofile/0001-fix-powerpc-cross-compiling.patch b/meta/recipes-kernel/oprofile/oprofile/0001-fix-powerpc-cross-compiling.patch new file mode 100644 index 000..d4dffb1 --- /dev/null +++ b/meta/recipes-kernel/oprofile/oprofile/0001-fix-powerpc-cross-compiling.patch @@ -0,0 +1,35 @@ +Upstream-Status: Submitted + +From cd8aafe5ca48e8d809188df6e42f20efd5cbefd1 Mon Sep 17 00:00:00 2001 +From: Matthew McClintock m...@freescale.com +Date: Tue, 5 Feb 2013 11:05:00 -0600 +Subject: [PATCH] fix powerpc cross compiling + +You can't determine the target for running on by running uname +on the build machine. Use a better method instead. + +Signed-off-by: Matthew McClintock m...@freescale.com +--- + configure.ac |4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/configure.ac b/configure.ac +index a9b1ee4..4b73cdd 100644 +--- a/configure.ac b/configure.ac +@@ -155,10 +155,10 @@ fi + + AC_DEFINE_UNQUOTED(HAVE_PERF_EVENTS, $HAVE_PERF_EVENTS, [Kernel support for perf_events exists]) + ++AC_CANONICAL_HOST + if test $HAVE_PERF_EVENTS = 1; then + PFM_LIB= +- arch=`uname -m` +- if test $arch = ppc64 || test $arch = ppc; then ++ if test $host_cpu = powerpc; then + AC_CHECK_HEADER(perfmon/pfmlib.h,,[AC_MSG_ERROR([pfmlib.h not found; usually provided in papi devel package])]) + AC_CHECK_LIB(pfm,pfm_get_os_event_encoding, HAVE_LIBPFM3='0'; HAVE_LIBPFM='1', [ + AC_CHECK_LIB(pfm, pfm_get_event_name, HAVE_LIBPFM3='1'; HAVE_LIBPFM='1', +-- +1.7.9.7 + diff --git a/meta/recipes-kernel/oprofile/oprofile_0.9.8.bb b/meta/recipes-kernel/oprofile/oprofile_0.9.8.bb index 6075163..79363a6 100644 --- a/meta/recipes-kernel/oprofile/oprofile_0.9.8.bb +++ b/meta/recipes-kernel/oprofile/oprofile_0.9.8.bb @@ -1,15 +1,18 @@ require oprofile.inc -PR = ${INC_PR}.1 +PR = ${INC_PR}.2 DEPENDS += virtual/kernel +DEPENDS_append_powerpc = libpfm4 +DEPENDS_append_powerpc64 = libpfm4 SRC_URI += ${SOURCEFORGE_MIRROR}/${BPN}/${BPN}-${PV}.tar.gz \ file://0001-Add-rmb-definition-for-AArch64-architecture.patch \ file://0001-OProfile-doesn-t-build-for-32-bit-ppc-the-operf_util.patch \ file://0001-Handle-early-perf_events-kernel-without-PERF_RECORD_.patch \ file://0001-Fix-up-configure-to-handle-architectures-that-do-not.patch \ - file://0001-Change-configure-to-look-for-libpfm4-function-first-.patch + file://0001-Change-configure-to-look-for-libpfm4-function-first-.patch \ +file://0001-fix-powerpc-cross-compiling.patch SRC_URI[md5sum] = 6d127023af1dd1cf24e15411229f3cc8 SRC_URI[sha256sum] = ab45900fa1a23e5d5badf3c0a55f26c17efe6e184efcf00b371433751fa761bc -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH 1/5] glib: disable selinux for native builds
This improves reusabiliy of sstate-cache across different hosts Signed-off-by: Matthew McClintock m...@freescale.com --- meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb |2 +- meta/recipes-core/glib-2.0/glib.inc |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb index e1d44e2..fe50220 100644 --- a/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb +++ b/meta/recipes-core/glib-2.0/glib-2.0_2.34.3.bb @@ -1,6 +1,6 @@ require glib.inc -PR = r1 +PR = r2 PE = 1 DEPENDS += libffi python-argparse-native zlib diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc index 53b20b6..cb391a2 100644 --- a/meta/recipes-core/glib-2.0/glib.inc +++ b/meta/recipes-core/glib-2.0/glib.inc @@ -29,7 +29,7 @@ CORECONF = --disable-dtrace --disable-fam --disable-libelf --disable-systemtap PTEST_CONF = ${@base_contains('DISTRO_FEATURES', 'ptest', '', '--disable-modular-tests', d)} EXTRA_OECONF = --enable-included-printf=no ${CORECONF} ${PTEST_CONF} -EXTRA_OECONF_class-native = ${CORECONF} +EXTRA_OECONF_class-native = ${CORECONF} --disable-selinux EXTRA_OECONF_linuxstdbase = --enable-included-printf=no ${CORECONF} FILES_${PN} = ${libdir}/lib*${SOLIBS} ${datadir}/glib-2.0/schemas \ -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH 2/5] quota_4.01.bb: add e2fsprogs in DEPENDS
Fixes: | /local/home/mattsm/git/poky/build-master/tmp/sysroots/x86_64-linux/usr/libexec/ppce300c3-poky-linux/gcc/powerpc-poky-linux/4.7.2/ld: cannot find -lext2fs Signed-off-by: Matthew McClintock m...@freescale.com --- meta/recipes-extended/quota/quota_4.01.bb |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/recipes-extended/quota/quota_4.01.bb b/meta/recipes-extended/quota/quota_4.01.bb index 1cb6650..80159a9 100644 --- a/meta/recipes-extended/quota/quota_4.01.bb +++ b/meta/recipes-extended/quota/quota_4.01.bb @@ -6,7 +6,7 @@ LICENSE = BSD GPLv2+ LGPLv2.1+ LIC_FILES_CHKSUM = file://quota.c;beginline=1;endline=33;md5=331c7d77744bfe0ad24027f0651028ec \ file://rquota_server.c;beginline=1;endline=20;md5=fe7e0d7e11c6f820f8fa62a5af71230f \ file://svc_socket.c;beginline=1;endline=17;md5=24d5a8792da45910786eeac750be8ceb -PR = r0 +PR = r1 SRC_URI = ${SOURCEFORGE_MIRROR}/project/linuxquota/quota-tools/${PV}/quota-${PV}.tar.gz @@ -15,7 +15,7 @@ SRC_URI[sha256sum] = a36300bbc126b79b745bf937245092808b4585aa3309ef3335d4ab9d87 S = ${WORKDIR}/quota-tools -DEPENDS = gettext-native +DEPENDS = gettext-native e2fsprogs inherit autotools gettext -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH 4/5] kernel-arch.bbclass: don't pass extra args to KERNEL_{CC, LD, AR}
Commit a3ca06c3b45c791dd38dbf154ad0fc62b4063475 added extra args to KERNEL_CC, these revert that bit while maintaining machine additions in TARGET_??_KERNEL_ARCH Signed-off-by: Matthew McClintock m...@freescale.com --- meta/classes/kernel-arch.bbclass |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/classes/kernel-arch.bbclass b/meta/classes/kernel-arch.bbclass index a51e82b..b3b71ba 100644 --- a/meta/classes/kernel-arch.bbclass +++ b/meta/classes/kernel-arch.bbclass @@ -52,7 +52,7 @@ HOST_LD_KERNEL_ARCH ?= ${TARGET_LD_KERNEL_ARCH} TARGET_AR_KERNEL_ARCH ?= HOST_AR_KERNEL_ARCH ?= ${TARGET_AR_KERNEL_ARCH} -KERNEL_CC = ${CC} ${HOST_CC_KERNEL_ARCH} -KERNEL_LD = ${LD} ${HOST_LD_KERNEL_ARCH} -KERNEL_AR = ${AR} ${HOST_AR_KERNEL_ARCH} +KERNEL_CC = ${CCACHE}${HOST_PREFIX}gcc ${HOST_CC_KERNEL_ARCH} +KERNEL_LD = ${CCACHE}${HOST_PREFIX}ld ${HOST_LD_KERNEL_ARCH} +KERNEL_AR = ${CCACHE}${HOST_PREFIX}ar ${HOST_AR_KERNEL_ARCH} -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core] oprofile: avoid processing files under .pc
On Fri, Feb 1, 2013 at 4:40 PM, Chris Larson clar...@kergoth.com wrote: On Fri, Feb 1, 2013 at 1:16 PM, McClintock Matthew-B29882 b29...@freescale.com wrote: On Fri, Feb 1, 2013 at 4:12 AM, b28...@freescale.com wrote: From: Ting Liu b28...@freescale.com Fix the below issue: | DEBUG: Executing shell function do_configure | sed: can't read ./.pc/opstart.patch/doc/opstop.1.in: Permission denied | sed: can't read ./.pc/opstart.patch/doc/opstart.1.in: Permission denied | sed: can't read ./.pc/opstart.patch/utils/opstart.c: Permission denied | ERROR: Function failed: do_configure Permissions are messed up on these files, obviously: $ ls -alh .pc/opstart.patch/doc/ total 12K drwxr-sr-x 2 jenkins jenkins 4.0K Jan 31 20:49 . drwxr-sr-x 4 jenkins jenkins 4.0K Jan 31 20:49 .. -rw-r--r-- 1 jenkins jenkins 2.5K Jan 31 20:49 Makefile.am -- 1 jenkins jenkins0 Jan 31 20:49 opstart.1.in -- 1 jenkins jenkins0 Jan 31 20:49 opstop.1.in But this was only occurring on one machine (our CentOS box). So, I've actually isolated this down to the version of patch we were using which is creating these new files with odd permissions. So, I'm not sure how to handle this - do we actually require a newer version of patch? patch-native is assume provided and we can't just remove that since we will get circular deps. Should we require the user upgrade patch on this old CentOS 5.x box? I need to leave now so I'm leaving the problem here for now to see if anyone else has a comment. This seems like a silly reason to require a newer patch version, when it's trivial to fix the recipe to not enter .pc, IMO. Nothing should be modifying files in there directly anyway. Sounds good to me. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/4] kernel.bbclass, module-base.bbclass: Use CC to form KERNEL_CC
On Sat, Jan 19, 2013 at 4:40 PM, Khem Raj raj.k...@gmail.com wrote: kernel compiler is not special and we currently have it so we want to pass -march and -mtune options as CFLAGS to kernel build so that compiler picks the right subarch flags when compiling assembly files in particular. Otherwise defaults are chosen which may not be right in many case e.g. when compiling kernel for collie machine we should use arch=armv4 but it uses toolchain/as defaults which is armv5te in some case e.g. thumb1 we know that kernel can not be compiled in thumb1 mode so we can provide that information e.g. -marm option through KERNEL_HOST_CC_ARCH variable as we do now Signed-off-by: Khem Raj raj.k...@gmail.com --- meta/classes/kernel-arch.bbclass | 13 + meta/classes/kernel.bbclass | 16 +--- meta/classes/module-base.bbclass | 16 3 files changed, 14 insertions(+), 31 deletions(-) diff --git a/meta/classes/kernel-arch.bbclass b/meta/classes/kernel-arch.bbclass index b3b78b6..a51e82b 100644 --- a/meta/classes/kernel-arch.bbclass +++ b/meta/classes/kernel-arch.bbclass @@ -43,3 +43,16 @@ def map_uboot_arch(a, d): export UBOOT_ARCH = ${@map_uboot_arch(d.getVar('ARCH', True), d)} +# Set TARGET_??_KERNEL_ARCH in the machine .conf to set architecture +# specific options necessary for building the kernel and modules. +TARGET_CC_KERNEL_ARCH ?= +HOST_CC_KERNEL_ARCH ?= ${TARGET_CC_KERNEL_ARCH} +TARGET_LD_KERNEL_ARCH ?= +HOST_LD_KERNEL_ARCH ?= ${TARGET_LD_KERNEL_ARCH} +TARGET_AR_KERNEL_ARCH ?= +HOST_AR_KERNEL_ARCH ?= ${TARGET_AR_KERNEL_ARCH} + +KERNEL_CC = ${CC} ${HOST_CC_KERNEL_ARCH} Why change to ${CC} from ${CCACHE}${HOST_PREFIX}gcc${KERNEL_CCSUFFIX}? It breaks some kernel builds we have... -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/4] kernel.bbclass, module-base.bbclass: Use CC to form KERNEL_CC
On Mon, Feb 4, 2013 at 4:51 PM, Khem Raj raj.k...@gmail.com wrote: On Mon, Feb 4, 2013 at 12:13 PM, McClintock Matthew-B29882 b29...@freescale.com wrote: + +KERNEL_CC = ${CC} ${HOST_CC_KERNEL_ARCH} Why change to ${CC} from ${CCACHE}${HOST_PREFIX}gcc${KERNEL_CCSUFFIX}? It breaks some kernel builds we have... you did not tell what exactly breaks. Shame on me. Our kernel gets built wrong if we pass the extra -march or -mtune to the compiler during the kernel build. It might be exposing another issue but not sure exactly. I need to dig up a log so I can send that over later. Here was my fix: http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=mattsm/masterid=f008446117106831585ed371453d1f052cdfd9eb -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [oe-core] oprofile: avoid processing files under .pc
On Fri, Feb 1, 2013 at 4:12 AM, b28...@freescale.com wrote: From: Ting Liu b28...@freescale.com Fix the below issue: | DEBUG: Executing shell function do_configure | sed: can't read ./.pc/opstart.patch/doc/opstop.1.in: Permission denied | sed: can't read ./.pc/opstart.patch/doc/opstart.1.in: Permission denied | sed: can't read ./.pc/opstart.patch/utils/opstart.c: Permission denied | ERROR: Function failed: do_configure Permissions are messed up on these files, obviously: $ ls -alh .pc/opstart.patch/doc/ total 12K drwxr-sr-x 2 jenkins jenkins 4.0K Jan 31 20:49 . drwxr-sr-x 4 jenkins jenkins 4.0K Jan 31 20:49 .. -rw-r--r-- 1 jenkins jenkins 2.5K Jan 31 20:49 Makefile.am -- 1 jenkins jenkins0 Jan 31 20:49 opstart.1.in -- 1 jenkins jenkins0 Jan 31 20:49 opstop.1.in But this was only occurring on one machine (our CentOS box). So, I've actually isolated this down to the version of patch we were using which is creating these new files with odd permissions. So, I'm not sure how to handle this - do we actually require a newer version of patch? patch-native is assume provided and we can't just remove that since we will get circular deps. Should we require the user upgrade patch on this old CentOS 5.x box? I need to leave now so I'm leaving the problem here for now to see if anyone else has a comment. -M Signed-off-by: Ting Liu b28...@freescale.com --- meta/recipes-kernel/oprofile/oprofile.inc |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/recipes-kernel/oprofile/oprofile.inc b/meta/recipes-kernel/oprofile/oprofile.inc index d6d20ae..b09aaf8 100644 --- a/meta/recipes-kernel/oprofile/oprofile.inc +++ b/meta/recipes-kernel/oprofile/oprofile.inc @@ -19,7 +19,7 @@ FILES_${PN} = ${bindir} ${libdir}/${BPN}/lib*${SOLIBS} ${datadir}/${BPN} FILES_${PN}-dev += ${libdir}/${BPN}/lib*${SOLIBSDEV} ${libdir}/${BPN}/lib*.la FILES_${PN}-staticdev += ${libdir}/${BPN}/lib*.a -INC_PR = r1 +INC_PR = r2 SRC_URI = file://opstart.patch \ file://oprofile-no-query-modules.patch \ @@ -30,7 +30,7 @@ inherit autotools EXTRA_OECONF = --with-kernel=${STAGING_KERNEL_DIR} --without-x do_configure () { - find . -type f | xargs sed -i 's#ROOTHOME#${ROOT_HOME}#' + find . -wholename './.pc' -prune -o -type f -print | xargs sed -i 's#ROOTHOME#${ROOT_HOME}#' cp ${WORKDIR}/acinclude.m4 ${S}/ autotools_do_configure } -- 1.7.5.4 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] linux-dtb: Add extra padding to the blob.
On Mon, Jan 28, 2013 at 9:00 AM, Otavio Salvador ota...@ossystems.com.br wrote: On Mon, Jan 28, 2013 at 12:24 PM, Vakul Garg va...@freescale.com wrote: U-boot patches portal devices for adding new properties in portal nodes. T4 devices such as T4240 have large number of portals. This requires extra space in device tree blob. The large number of portals need more padding space to be added. Signed-off-by: Vakul Garg va...@freescale.com This might be overridable so it could be overrided in the machine and do not change the default for everyone. What do you think? Agreed. I suggest just making this change: -KERNEL_DEVICETREE_FLAGS = -R 8 -p 0x3000 +KERNEL_DEVICETREE_FLAGS ?= -R 8 -p 0x3000 Then the machines/distros themselves can override this var. -M -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [for-denzil 1/3] bitbake: command: add error to return of runCommand
From: Christopher Larson chris_lar...@mentor.com Currently, command.py can return an error message from runCommand, due to being unable to run the command, yet few of our UIs (just hob) can handle it today. This can result in seeing a TypeError with traceback in certain rare circumstances. To resolve this, we need a clean way to get errors back from runCommand, without having to isinstance() the return value. This implements such a thing by making runCommand also return an error (or None if no error occurred). As runCommand now has a method of returning errors, we can also alter the getCmdLineAction bits such that the returned value is just the action, not an additional message. If a sync command wants to return an error, it raises CommandError(message), and the message will be passed to the caller appropriately. Example Usage: result, error = server.runCommand(...) if error: log.error('Unable to run command: %s' % error) return 1 (Bitbake rev: 717831b8315cb3904d9b590e633000bc897e8fb6) Signed-off-by: Christopher Larson chris_lar...@mentor.com Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org --- bitbake/lib/bb/command.py | 43 +++-- bitbake/lib/bb/server/process.py|2 +- bitbake/lib/bb/ui/crumbs/hobeventhandler.py |5 ++- bitbake/lib/bb/ui/depexp.py | 38 ++ bitbake/lib/bb/ui/goggle.py | 17 +- bitbake/lib/bb/ui/knotty.py | 45 ++- bitbake/lib/bb/ui/ncurses.py| 21 - 7 files changed, 112 insertions(+), 59 deletions(-) diff --git a/bitbake/lib/bb/command.py b/bitbake/lib/bb/command.py index fd8912a..00b854e 100644 --- a/bitbake/lib/bb/command.py +++ b/bitbake/lib/bb/command.py @@ -44,6 +44,9 @@ class CommandFailed(CommandExit): self.error = message CommandExit.__init__(self, 1) +class CommandError(Exception): +pass + class Command: A queue of asynchronous commands for bitbake @@ -57,21 +60,25 @@ class Command: self.currentAsyncCommand = None def runCommand(self, commandline): -try: -command = commandline.pop(0) -if command in CommandsSync.__dict__: -# Can run synchronous commands straight away -return getattr(CommandsSync, command)(self.cmds_sync, self, commandline) -if self.currentAsyncCommand is not None: -return Busy (%s in progress) % self.currentAsyncCommand[0] -if command not in CommandsAsync.__dict__: -return No such command -self.currentAsyncCommand = (command, commandline) -self.cooker.server_registration_cb(self.cooker.runCommands, self.cooker) -return True -except: -import traceback -return traceback.format_exc() +command = commandline.pop(0) +if hasattr(CommandsSync, command): +# Can run synchronous commands straight away +command_method = getattr(self.cmds_sync, command) +try: +result = command_method(self, commandline) +except CommandError as exc: +return None, exc.args[0] +except Exception: +return None, traceback.format_exc() +else: +return result, None +if self.currentAsyncCommand is not None: +return None, Busy (%s in progress) % self.currentAsyncCommand[0] +if command not in CommandsAsync.__dict__: +return None, No such command +self.currentAsyncCommand = (command, commandline) +self.cooker.server_registration_cb(self.cooker.runCommands, self.cooker) +return True, None def runAsyncCommand(self): try: @@ -139,7 +146,11 @@ class CommandsSync: Get any command parsed from the commandline -return command.cooker.commandlineAction +cmd_action = command.cooker.commandlineAction +if cmd_action['msg']: +raise CommandError(msg) +else: +return cmd_action['action'] def getVariable(self, command, params): diff --git a/bitbake/lib/bb/server/process.py b/bitbake/lib/bb/server/process.py index ba91336..3ae9ede 100644 --- a/bitbake/lib/bb/server/process.py +++ b/bitbake/lib/bb/server/process.py @@ -48,7 +48,7 @@ class ServerCommunicator(): if self.connection.poll(.5): return self.connection.recv() else: -return None +return None, Timeout while attempting to communicate with bitbake server except KeyboardInterrupt: pass diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py index 52acec1..21bea23 100644 ---
[OE-core] [for-denzil 3/3] bitbake: command: Fix getCmdLineAction bugs
From: Richard Purdie richard.pur...@linuxfoundation.org Executing bitbake doesn't get a sane message since the None return value wasn't being handled correctly. Also fix msg - cmd_action['msg'] as otherwise an invalid variable is accessed which then crashes the server due to the previous bug. (Bitbake rev: c6211291ae07410832031a5274690437cc2b09a6) Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org --- bitbake/lib/bb/command.py |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bitbake/lib/bb/command.py b/bitbake/lib/bb/command.py index c08e2ce..a143aed 100644 --- a/bitbake/lib/bb/command.py +++ b/bitbake/lib/bb/command.py @@ -148,8 +148,10 @@ class CommandsSync: Get any command parsed from the commandline cmd_action = command.cooker.commandlineAction -if cmd_action['msg']: -raise CommandError(msg) +if cmd_action is None: +return None +elif 'msg' in cmd_action and cmd_action['msg']: +raise CommandError(cmd_action['msg']) else: return cmd_action['action'] -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [for-denzil 2/3] bitbake: command: Add missing import traceback
From: Richard Purdie richard.pur...@linuxfoundation.org Without this, if an exception occurs the server will silently crash with no feedback to the user about why (since traceback isn't imported). (Bitbake rev: e637a635bf7b5a9a2e9dc20afc18aceec98d578f) Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org --- bitbake/lib/bb/command.py |1 + 1 file changed, 1 insertion(+) diff --git a/bitbake/lib/bb/command.py b/bitbake/lib/bb/command.py index 00b854e..c08e2ce 100644 --- a/bitbake/lib/bb/command.py +++ b/bitbake/lib/bb/command.py @@ -69,6 +69,7 @@ class Command: except CommandError as exc: return None, exc.args[0] except Exception: +import traceback return None, traceback.format_exc() else: return result, None -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] anyone interested in CentOS 5 fixes for dpkg-native?
On Tue, Jan 8, 2013 at 11:56 AM, Donn Seeley donn.see...@windriver.com wrote: We recently tried to build using 'PACKAGE_CLASSES = package_deb' and found that our ancient CentOS 5 build VMs couldn't compile and link dpkg-native. (We support CentOS 5 for very conservative customers, so we run test builds with it regularly.) Given that package_deb isn't used frequently and that CentOS 5 is so old, I thought that I would ask first before submitting fixes for that configuration. Do we want the patches in oe-core? I vote yes, additionally these patches don't look too complex or intrusive. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [for-denzil] bitbake: command: add error to return of runCommand
On Tue, Dec 18, 2012 at 3:28 PM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Tue, 2012-12-18 at 11:18 -0600, Matthew McClintock wrote: From: Christopher Larson chris_lar...@mentor.com Currently, command.py can return an error message from runCommand, due to being unable to run the command, yet few of our UIs (just hob) can handle it today. This can result in seeing a TypeError with traceback in certain rare circumstances. To resolve this, we need a clean way to get errors back from runCommand, without having to isinstance() the return value. This implements such a thing by making runCommand also return an error (or None if no error occurred). As runCommand now has a method of returning errors, we can also alter the getCmdLineAction bits such that the returned value is just the action, not an additional message. If a sync command wants to return an error, it raises CommandError(message), and the message will be passed to the caller appropriately. Example Usage: result, error = server.runCommand(...) if error: log.error('Unable to run command: %s' % error) return 1 (Bitbake rev: 717831b8315cb3904d9b590e633000bc897e8fb6) This patch has bugs in it. See recent fixes in master. Signed-off-by: Christopher Larson chris_lar...@mentor.com Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org --- bitbake/lib/bb/command.py | 43 +++-- bitbake/lib/bb/server/process.py|2 +- bitbake/lib/bb/ui/crumbs/hobeventhandler.py |5 ++- bitbake/lib/bb/ui/depexp.py | 38 ++ bitbake/lib/bb/ui/goggle.py | 17 +- bitbake/lib/bb/ui/knotty.py | 45 ++- bitbake/lib/bb/ui/ncurses.py| 21 - 7 files changed, 112 insertions(+), 59 deletions(-) diff --git a/bitbake/lib/bb/command.py b/bitbake/lib/bb/command.py index fd8912a..00b854e 100644 --- a/bitbake/lib/bb/command.py +++ b/bitbake/lib/bb/command.py @@ -44,6 +44,9 @@ class CommandFailed(CommandExit): self.error = message CommandExit.__init__(self, 1) +class CommandError(Exception): +pass + class Command: A queue of asynchronous commands for bitbake @@ -57,21 +60,25 @@ class Command: self.currentAsyncCommand = None def runCommand(self, commandline): -try: -command = commandline.pop(0) -if command in CommandsSync.__dict__: -# Can run synchronous commands straight away -return getattr(CommandsSync, command)(self.cmds_sync, self, commandline) -if self.currentAsyncCommand is not None: -return Busy (%s in progress) % self.currentAsyncCommand[0] -if command not in CommandsAsync.__dict__: -return No such command -self.currentAsyncCommand = (command, commandline) -self.cooker.server_registration_cb(self.cooker.runCommands, self.cooker) -return True -except: -import traceback -return traceback.format_exc() +command = commandline.pop(0) +if hasattr(CommandsSync, command): +# Can run synchronous commands straight away +command_method = getattr(self.cmds_sync, command) +try: +result = command_method(self, commandline) +except CommandError as exc: +return None, exc.args[0] +except Exception: +return None, traceback.format_exc() Missing import traceback. +else: +return result, None +if self.currentAsyncCommand is not None: +return None, Busy (%s in progress) % self.currentAsyncCommand[0] +if command not in CommandsAsync.__dict__: +return None, No such command +self.currentAsyncCommand = (command, commandline) +self.cooker.server_registration_cb(self.cooker.runCommands, self.cooker) +return True, None def runAsyncCommand(self): try: @@ -139,7 +146,11 @@ class CommandsSync: Get any command parsed from the commandline -return command.cooker.commandlineAction +cmd_action = command.cooker.commandlineAction +if cmd_action['msg']: +raise CommandError(msg) Error, msg not defined. Thanks, will look for these and add them / send to list as well. Look for another patch when I get to it. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [for-denzil] bitbake: command: add error to return of runCommand
From: Christopher Larson chris_lar...@mentor.com Currently, command.py can return an error message from runCommand, due to being unable to run the command, yet few of our UIs (just hob) can handle it today. This can result in seeing a TypeError with traceback in certain rare circumstances. To resolve this, we need a clean way to get errors back from runCommand, without having to isinstance() the return value. This implements such a thing by making runCommand also return an error (or None if no error occurred). As runCommand now has a method of returning errors, we can also alter the getCmdLineAction bits such that the returned value is just the action, not an additional message. If a sync command wants to return an error, it raises CommandError(message), and the message will be passed to the caller appropriately. Example Usage: result, error = server.runCommand(...) if error: log.error('Unable to run command: %s' % error) return 1 (Bitbake rev: 717831b8315cb3904d9b590e633000bc897e8fb6) Signed-off-by: Christopher Larson chris_lar...@mentor.com Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org --- bitbake/lib/bb/command.py | 43 +++-- bitbake/lib/bb/server/process.py|2 +- bitbake/lib/bb/ui/crumbs/hobeventhandler.py |5 ++- bitbake/lib/bb/ui/depexp.py | 38 ++ bitbake/lib/bb/ui/goggle.py | 17 +- bitbake/lib/bb/ui/knotty.py | 45 ++- bitbake/lib/bb/ui/ncurses.py| 21 - 7 files changed, 112 insertions(+), 59 deletions(-) diff --git a/bitbake/lib/bb/command.py b/bitbake/lib/bb/command.py index fd8912a..00b854e 100644 --- a/bitbake/lib/bb/command.py +++ b/bitbake/lib/bb/command.py @@ -44,6 +44,9 @@ class CommandFailed(CommandExit): self.error = message CommandExit.__init__(self, 1) +class CommandError(Exception): +pass + class Command: A queue of asynchronous commands for bitbake @@ -57,21 +60,25 @@ class Command: self.currentAsyncCommand = None def runCommand(self, commandline): -try: -command = commandline.pop(0) -if command in CommandsSync.__dict__: -# Can run synchronous commands straight away -return getattr(CommandsSync, command)(self.cmds_sync, self, commandline) -if self.currentAsyncCommand is not None: -return Busy (%s in progress) % self.currentAsyncCommand[0] -if command not in CommandsAsync.__dict__: -return No such command -self.currentAsyncCommand = (command, commandline) -self.cooker.server_registration_cb(self.cooker.runCommands, self.cooker) -return True -except: -import traceback -return traceback.format_exc() +command = commandline.pop(0) +if hasattr(CommandsSync, command): +# Can run synchronous commands straight away +command_method = getattr(self.cmds_sync, command) +try: +result = command_method(self, commandline) +except CommandError as exc: +return None, exc.args[0] +except Exception: +return None, traceback.format_exc() +else: +return result, None +if self.currentAsyncCommand is not None: +return None, Busy (%s in progress) % self.currentAsyncCommand[0] +if command not in CommandsAsync.__dict__: +return None, No such command +self.currentAsyncCommand = (command, commandline) +self.cooker.server_registration_cb(self.cooker.runCommands, self.cooker) +return True, None def runAsyncCommand(self): try: @@ -139,7 +146,11 @@ class CommandsSync: Get any command parsed from the commandline -return command.cooker.commandlineAction +cmd_action = command.cooker.commandlineAction +if cmd_action['msg']: +raise CommandError(msg) +else: +return cmd_action['action'] def getVariable(self, command, params): diff --git a/bitbake/lib/bb/server/process.py b/bitbake/lib/bb/server/process.py index ba91336..3ae9ede 100644 --- a/bitbake/lib/bb/server/process.py +++ b/bitbake/lib/bb/server/process.py @@ -48,7 +48,7 @@ class ServerCommunicator(): if self.connection.poll(.5): return self.connection.recv() else: -return None +return None, Timeout while attempting to communicate with bitbake server except KeyboardInterrupt: pass diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py index 52acec1..21bea23 100644 ---
Re: [OE-core] [PATCH] gcc-cross: Explicitly depend on linux-libc-headers
On Thu, Nov 22, 2012 at 3:36 PM, Richard Purdie richard.pur...@linuxfoundation.org wrote: gcc-cross cannot build without linux-libc-headers but doesn't explicitly depend on it relying on the implied dependency through libc. With cases where pieces can be installed through sstate, we now need this explicit dependency to ensure builds with partial sstate work. Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org --- diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc b/meta/recipes-devtools/gcc/gcc-cross.inc index 6d160d6..cde08ee 100644 --- a/meta/recipes-devtools/gcc/gcc-cross.inc +++ b/meta/recipes-devtools/gcc/gcc-cross.inc @@ -1,6 +1,6 @@ inherit cross -DEPENDS = virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}libc-for-gcc ${NATIVEDEPS} +DEPENDS = virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}libc-for-gcc linux-libc-headers ${NATIVEDEPS} How would you suggest not forcing a rebuild of all components if the linux headers signature changes? During our normal development we change Linux headers for things that would in no way effect gcc or even libc. It's painful to watch a complete rebuild occur because of this. Just have a different recipe for headers for some components? -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [yocto] meta-freescale general mailing list
On Mon, Nov 19, 2012 at 7:05 AM, Leon Woestenberg sidebranch.openembed...@gmail.com wrote: Hello Otavio, all, On Sun, Nov 18, 2012 at 9:00 PM, Otavio Salvador ota...@ossystems.com.br wrote: On Thu, Nov 15, 2012 at 3:02 PM, Otavio Salvador ota...@ossystems.com.br wrote: On Thu, Nov 15, 2012 at 1:36 PM, Philip Balister phi...@balister.org wrote: On 11/14/2012 11:58 AM, McClintock Matthew-B29882 wrote: Do we have a standard for yocto/OE list names on gmane? I tried to add it but it did not work. It is now done. You can see it at http://blog.gmane.org/gmane.linux.embedded.yocto.meta-freescale Regards, Otavio Thanks. There is a small typo in the gmane: Leyers vs Layers. -Freescale OpenEmbedded/Yocto Leyers discussion list () +Freescale OpenEmbedded/Yocto Layers discussion list () I've sent a request to fix this. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] OE Changelog since 2012-11-11 until 2012-11-18
: fix udevd in the live boot init scripts mesa-demos: fix --with-glut check default-providers: add default provider for make cmake.bbclass: use DEPENDS_prepend instead of += for cmake-native Saul Wold (6): pulse: fix Bashism in string test mx: Update to 1.4.7 kconfig-frontends: Update to 3.6 psmisc: Update to 22.20 packagegroup-self-hosted: add sftp server less: Update to 451 Changelog for meta-openembedded: Andrea Adami (2): klibc: refactor runtime deps for shared utils klibc: upgrade from 2.0.1 to 2.0.2 Andreas Müller (5): lighttpd: move systemd appends since recipe is in oe-core gvfs: fix build gvfs-gdu-volume-monitor: fix build after oe-core's libexecdir transition gnome-desktop: copy omf.make from ${STAGING_DATADIR_NATIVE} instead ${STAGIN thunar: add xfce4-panel to dependencies to ensure trash-plugin (tpa) is buil Bruce Ashfield (1): kernel.bbclass: remove explicit version.h target Eric BENARD (1): mercurial-native: fix install Holger Hans Peter Freyther (1): systemd: Make the main systemd files proper CONFFILES Jack Mitchell (2): hiawatha: update to 8.6 hiawatha: disable caching by default Martin Jansa (1): omgps: add patch to fix build with latest glib from oe-core Stefan Herbrechtsmeier (1): python-numpy: Move static libraries to -staticdev Changelog for meta-angstrom: Changelog for meta-arago: Denys Dmytriyenko (9): external-arago-sdk-toolchain: package up gdb from the toolchain as well task-arago-cross-canadian: add crosssdk gdb to the devkit meta-toolchain-arago: special case for gdb to be built as part of canadian-c external-arago-sdk-toolchain: provide and package gdb conditionally meta-toolchain-arago: improve shell stubs to atomatically source env-setup s arago.conf: abstract setting external Arago toolchain toolchain-external-linaro: add seetings for selecting Linaro toolchain arago-tisdk-image,task-arago-tisdk-addons: move arago-test out of addons arago-headless-tisdk-image: provide a headless version ot TISDK image Franklin S. Cooper Jr (12): linux-am335x: Update psp 04.06.00.08 recipe linux-am335x_3.2.0-psp05.06.00.00: Disable CONFIG_LOCALVERSION_AUTO option arago.conf: Setting PREFERRED_VERSIONS gst-ffmpeg: Select a non GPLv3 license qt4-tools-nativesdk: Select LGPLv2.1 license u-boot: Add PSP version 05.06.00.00 of u-boot u-boot_2012.10-psp05.06.00.00: Fix mmc boot environment settings u-boot_2012.10-psp05.06.00.00: Add NAND environment variables u-boot_2012.10-psp05.06.00.00: Add SPI environment variables u-boot_2012.10-psp05.06.00.00: Add NET environment variables arago.conf: Switch to latest PSP u-boot release meta-toolchain-arago-qte: Fix mkspecs location Changelog for meta-beagleboard: Koen Kooi (1): common-bsp: linux-mainline: add recipe for 3.7.0-rc5 Changelog for meta-browser: Changelog for meta-bug: Changelog for meta-chicken: Changelog for meta-efikamx: Changelog for meta-ettus: Changelog for meta-fsl-arm: Otavio Salvador (1): README: Update to point to the newer mailing list Changelog for meta-fsl-ppc: Matthew McClintock (1): u-boot_git.bb: use upstream u-boot for e6500 parts for now Changelog for meta-guacamayo: Ross Burton (1): Move the Poky tag to the 1.3 release Tomas Frydrych (2): Updated Rygel to 0.16.2 Move preferred versions out of our layer.conf into the distro conf Changelog for meta-gumstix: Changelog for meta-gumstix-community: Changelog for meta-handheld: Changelog for meta-igep: Javier Martinez Canillas (1): igep00x0: add u-boot config option to built with NAND support Changelog for meta-intel: Tom Zanussi (1): meta-intel: remove explicit kernel SRCREVs Changelog for meta-ivi: Andrei Gherzan (1): linux-yocto: Fix af bus patch to be usable with poky master version Florin Sarbu (4): eglibc_2.16_bbappend: Use FILESEXTRAPATHS_prepend so that other bbappends fo README.md: Add
[OE-core] meta-freescale general mailing list
YoctoProject.org is now hosting a meta-freescale mailing list that are going to unify the communities of meta-fsl-ppc and meta-fsl-arm. From now on all patches affecting meta-fsl-ppc and meta-fsl-arm can be sent to meta-freesc...@yoctoproject.org and have the respective tag in the patch. Please check the README in respective layer about the command line to use for git format-patch. Please subscribe here: https://lists.yoctoproject.org/listinfo/meta-freescale Archives here: https://lists.yoctoproject.org/pipermail/meta-freescale/ -Matthew ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] classes: Be consistent about sstate-inputdirs/outputdirs ending with '/'
On Wed, Nov 14, 2012 at 9:59 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Wed, 2012-11-14 at 16:22 +0100, Martin Jansa wrote: On Wed, Nov 14, 2012 at 04:09:45PM +0100, Martin Jansa wrote: On Tue, Nov 13, 2012 at 02:05:00PM +, Richard Purdie wrote: If sstate-inputdirs and sstate-outputdirs don't match with ending '/' characters, the manifest file can end up corrupted. This change ensures the metadata is consistent in ending do_populate_root tasks with this character to avoid manifest file corruption. diff --git a/meta/recipes-devtools/gcc/gcc-cross-initial.inc b/meta/recipes-devtools/gcc/gcc-cross-initial.inc index ff6556c..1ac1db6 100644 --- a/meta/recipes-devtools/gcc/gcc-cross-initial.inc +++ b/meta/recipes-devtools/gcc/gcc-cross-initial.inc @@ -74,6 +74,6 @@ sysroot_stage_all() { mv ${SYSROOT_DESTDIR}${target_libdir}/* ${SYSROOT_DESTDIR}${STAGING_DIR_TARGET}${target_libdir}/ || true } -do_populate_sysroot[sstate-inputdirs] = ${SYSROOT_DESTDIR}/${STAGING_DIR_HOST} ${SYSROOT_DESTDIR}/${STAGING_DIR_TARGET}/${target_base_libdir} -do_populate_sysroot[sstate-outputdirs] = ${STAGING_DIR_HOST} ${STAGING_DIR_TCBOOTSTRAP}/${target_base_libdir} +do_populate_sysroot[sstate-inputdirs] = ${SYSROOT_DESTDIR}/${STAGING_DIR_HOST}/ ${SYSROOT_DESTDIR}/${STAGING_DIR_TARGET}/${target_base_libdir}/ +do_populate_sysroot[sstate-outputdirs] = ${STAGING_DIR_HOST}/ ${STAGING_DIR_TCBOOTSTRAP}/${target_base_libdir}/ Not sure if it can be caused by this, but building from scratch fails today with: with some added debug output it looks like trying to move the same directory twice: WARNING: Moving /OE/oe-core/tmp-eglibc/work/x86_64-oe-linux/gcc-cross-initial-4.7.2-r13/sstate-install-populate-sysroot/ to /OE/oe-core/tmp-eglibc/work/x86_64-oe-linux/gcc-cross-initial-4.7.2-r13/sysroot-destdir///OE/oe-core/tmp-eglibc/sysroots/x86_64-linux/ WARNING: Moving /OE/oe-core/tmp-eglibc/work/x86_64-oe-linux/gcc-cross-initial-4.7.2-r13/sstate-install-populate-sysroot/ to /OE/oe-core/tmp-eglibc/work/x86_64-oe-linux/gcc-cross-initial-4.7.2-r13/sysroot-destdir///OE/oe-core/tmp-eglibc/sysroots/qemux86-64//lib/ ERROR: Error executing a python function in /OE/oe-core/openembedded-core/meta/recipes-devtools/gcc/gcc-cross-initial_4.7.bb: There is something missing from after sstate-install-populate-sysroot/. I've pushed a fix into master. Its only appearing when installing from sstate. I've seen this on older releases also... -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCHv2] cryptodev kernel module recipe
On Tue, Nov 13, 2012 at 5:45 PM, Chris Larson clar...@kergoth.com wrote: On Fri, Nov 2, 2012 at 3:15 PM, Yashpal Dutta yashpal.du...@freescale.com wrote: This is a /dev/crypto device driver, equivalent to those in OpenBSD or FreeBSD. The main idea is to access of existing ciphers in kernel space from userspace, thus enabling re-use of a hardware implementation of a cipher. Signed-off-by: Yashpal Dutta yashpal.du...@freescale.com I would think that patches which add recipes to oe-core would do more than describe what it is, but also provide justification for its inclusion in oe-core vs some other layer. If that was already covered in a previous thread, that's fine, but I wanted to make sure it was explicit. Honestly, I'm not really sure why it should be in OE-core other than that ocf-linux which is semi-equivalent is here also. Maybe we should look at a meta-crypto layer or just keep this our own layer. Not sure, opening for discussion here. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [for-denzil] bitbake: compile tar-replacement firstly
From: Roy.Li rongqing...@windriver.com Compiling tar-replacement or not is decided by version of host tar, if the host tar version is lower than 1.23, Compiling tar-replacement is needed. When doing popoluate tar-replacement sysroot to write the tar to sysroot, but writing is not finished. other packages probably use the being written tar to unzip file, which will lead to failure and report the below error: bitbake_build/tmp/sysroots/x86_64-linux/usr/bin/tar: Text file busy Now we compile tar-replacement firstly to ensure that a being written tar command will not be used. (From OE-Core rev: 3c1c4719fc96f6f1fbb257413d6baf3d91fdf4e8) Signed-off-by: Roy.Li rongqing...@windriver.com Signed-off-by: Saul Wold s...@linux.intel.com Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org --- scripts/bitbake |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/bitbake b/scripts/bitbake index 3772d82..c52d5d2 100755 --- a/scripts/bitbake +++ b/scripts/bitbake @@ -134,7 +134,12 @@ if [ $buildpseudo -gt 0 ]; then fi done done -bitbake pseudo-native $TARTARGET $additionalopts -c populate_sysroot + +if [ $needtar = 1 ]; then + bitbake $TARTARGET -c populate_sysroot +fi + +bitbake pseudo-native $additionalopts -c populate_sysroot ret=$? if [ $ret != 0 ]; then exit 1 -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] cryptodev kernel module recipe
On Wed, Oct 31, 2012 at 12:11 PM, Bruce Ashfield bruce.ashfi...@gmail.com wrote: On Tue, Oct 30, 2012 at 2:50 PM, McClintock Matthew-B29882 b29...@freescale.com wrote: On Thu, Oct 18, 2012 at 8:33 AM, Bruce Ashfield bruce.ashfi...@gmail.com wrote: On Thu, Oct 18, 2012 at 5:57 AM, Yashpal Dutta yashpal.du...@freescale.com wrote: This is a /dev/crypto device driver, equivalent to those in OpenBSD or FreeBSD. The main idea is to access of existing ciphers in kernel space from userspace, thus enabling re-use of a hardware implementation of a cipher. I always use OCF for an overlapping set of functionality. To make this external module gracefully deal with a situation such as this, maybe a check for OCF in the kernel config ? The same thing could be said about having a kernel with this functionality already integrated (I have several of those as well). That's a more general question about what's the best way to gracefully deal with out of tree modules detecting that they are being built against a kernel that already has the functionality merged. The easy answer is that it's something the distro maintainer needs to know, and manage, and maybe that's the final answer. But I'm more wondering about this with respect to inter-operability of layers, if something in a layer depends/rdepends on this module, it will be pulled in, and won't that limit the mix/match/stacking of the various layers ? I added Richard for comment on the above. But that of course raises the question, why should this be in oe-core versus something like OCF ? This is definitely simpler, but OCF has it's use cases and advantages as well, that are an overlapping set of functionality. I don't have all the answers, just plenty of questions :) I'm not overly familiar with OCF. Does this just RCONFLICT with ocf-linux? I missed this yesterday, sorry about that. gmail just left this in the thread and not in my inbox .. but anyway. I only see parts ocf in oe-core, but maybe I'm just not understanding what the recipe is doing (are you seeing more) ? i.e. ocf-linux is buried under the open-ssl recipe, and really looks to be just providing headers. I'm doing some builds now to learn more .. which I just did .. and from what I can see, it is just the headers, which isn't all that useful without the kernel underpinning. ocf-linux recipe does infact appear to be just headers. As far as what it's used for I'm not even sure. I'll ask the crypto guys to chime in here. OCF does definitely accelerate openssl when properly used in both the kernel and userspace, but I'm not seeing the full offload kernel framework anywhere. Can't comment what others do, it would be ideal if we got all users talking here though. I wonder if anyone actually uses it :) Good question, it was added by Saul so maybe he can chime in here. But yes AFAIC, if you had a full OCF, you need these to conflict, since they'll both try and enable/provide cryptodev. Yashpal, You should to add RCONFLICTS_${PN} = ocf-linux and/or maybe RCONFLICTS_${PN}-dev = ocf-linux-dev to your v2 of the patch. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] cryptodev kernel module recipe
On Thu, Oct 18, 2012 at 8:33 AM, Bruce Ashfield bruce.ashfi...@gmail.com wrote: On Thu, Oct 18, 2012 at 5:57 AM, Yashpal Dutta yashpal.du...@freescale.com wrote: This is a /dev/crypto device driver, equivalent to those in OpenBSD or FreeBSD. The main idea is to access of existing ciphers in kernel space from userspace, thus enabling re-use of a hardware implementation of a cipher. I always use OCF for an overlapping set of functionality. To make this external module gracefully deal with a situation such as this, maybe a check for OCF in the kernel config ? The same thing could be said about having a kernel with this functionality already integrated (I have several of those as well). That's a more general question about what's the best way to gracefully deal with out of tree modules detecting that they are being built against a kernel that already has the functionality merged. The easy answer is that it's something the distro maintainer needs to know, and manage, and maybe that's the final answer. But I'm more wondering about this with respect to inter-operability of layers, if something in a layer depends/rdepends on this module, it will be pulled in, and won't that limit the mix/match/stacking of the various layers ? I added Richard for comment on the above. But that of course raises the question, why should this be in oe-core versus something like OCF ? This is definitely simpler, but OCF has it's use cases and advantages as well, that are an overlapping set of functionality. I don't have all the answers, just plenty of questions :) I'm not overly familiar with OCF. Does this just RCONFLICT with ocf-linux? -M Cheers, Bruce Signed-off-by: Yashpal Dutta yashpal.du...@freescale.com --- meta/recipes-kernel/cryptodev/cryptodev_1.5.bb | 18 + .../cryptodev/files/makefile_fixup.patch | 26 2 files changed, 44 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-kernel/cryptodev/cryptodev_1.5.bb create mode 100644 meta/recipes-kernel/cryptodev/files/makefile_fixup.patch diff --git a/meta/recipes-kernel/cryptodev/cryptodev_1.5.bb b/meta/recipes-kernel/cryptodev/cryptodev_1.5.bb new file mode 100644 index 000..5125710 --- /dev/null +++ b/meta/recipes-kernel/cryptodev/cryptodev_1.5.bb @@ -0,0 +1,18 @@ +SECTION = devel +SUMMARY = Linux Cryptodev KERNEL MODULE +DESCRIPTION = The Cryptodev package contains the kernel /dev/crypto module +LICENSE = GPLv2 +LIC_FILES_CHKSUM = file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 + +DEPENDS = virtual/kernel + +inherit module + +SRCREV = 1c24a0aa996630518d47826a2e3fea129ea094c7 + +SRC_URI = git://repo.or.cz/cryptodev-linux.git;protocol=git \ + file://makefile_fixup.patch + +EXTRA_OEMAKE='KERNEL_DIR=${STAGING_KERNEL_DIR} PREFIX=${D}' + +S = ${WORKDIR}/git diff --git a/meta/recipes-kernel/cryptodev/files/makefile_fixup.patch b/meta/recipes-kernel/cryptodev/files/makefile_fixup.patch new file mode 100644 index 000..323aacd --- /dev/null +++ b/meta/recipes-kernel/cryptodev/files/makefile_fixup.patch @@ -0,0 +1,26 @@ +diff --git a/Makefile b/Makefile +index 2be8825..b36d68c 100644 +--- a/Makefile b/Makefile +@@ -1,6 +1,7 @@ + KBUILD_CFLAGS += -I$(src) + KERNEL_DIR = /lib/modules/$(shell uname -r)/build + VERSION = 1.5 ++PREFIX = + + cryptodev-objs = ioctl.o main.o cryptlib.o authenc.o zc.o util.o + +@@ -12,10 +13,10 @@ build: version.h + version.h: Makefile + @echo #define VERSION \$(VERSION)\ version.h + +-install: ++modules_install: + make -C $(KERNEL_DIR) SUBDIRS=`pwd` modules_install +- @echo Installing cryptodev.h in /usr/include/crypto ... +- @install -D crypto/cryptodev.h /usr/include/crypto/cryptodev.h ++ @echo Installing cryptodev.h in $(PREFIX)/usr/include/crypto ... ++ @install -D crypto/cryptodev.h $(PREFIX)/usr/include/crypto/cryptodev.h + + clean: + make -C $(KERNEL_DIR) SUBDIRS=`pwd` clean -- 1.7.0.4 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core -- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] cryptodev kernel module recipe
On Thu, Oct 18, 2012 at 3:16 PM, Darren Hart dvh...@linux.intel.com wrote: +++ b/meta/recipes-kernel/cryptodev/cryptodev_1.5.bb @@ -0,0 +1,18 @@ +SECTION = devel +SUMMARY = Linux Cryptodev KERNEL MODULE +DESCRIPTION = The Cryptodev package contains the kernel /dev/crypto module +LICENSE = GPLv2 +LIC_FILES_CHKSUM = file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 + +DEPENDS = virtual/kernel This DEPENDS in inherited from the module.bbclass, no need to duplicate + +inherit module + +SRCREV = 1c24a0aa996630518d47826a2e3fea129ea094c7 + +SRC_URI = git://repo.or.cz/cryptodev-linux.git;protocol=git \ + file://makefile_fixup.patch Tabs to indent, spaces to align. Spaces here please. Yashpal, Can you address these two comments and submit a v2 of the patch if required. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] u-boot.inc: update linker arguments to pass --sysroot arg (BUILD BREAKAGE)
On Mon, Oct 29, 2012 at 4:26 AM, Steffen Sledz sl...@dresearch-fe.de wrote: On 29.07.2012 11:29, Richard Purdie wrote: On Thu, 2012-07-26 at 11:21 -0500, Matthew McClintock wrote: If we are building from sstate-cache it's possible to be building from another folder on another machine, therefore the linker requires that a proper --sysroot is passed too it so it can find things like libgcc.a and avoid errors such as: | arm-poky-linux-gnueabi-gcc -g -O2 -fno-common -ffixed-r8 -msoft-float -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x80008000 -I/local/yocto/upstream/label/ubuntu1204-64b/machine/beagleboard/poky/edison/tmp/work/beagleboard-poky-linux-gnueabi/u-boot-v2011.06+git5+b1af6f532e0d348b153d5c148369229d24af361a-r0/git/include -fno-builtin -ffreestanding -nostdinc -isystem /local/yocto/upstream/label/ubuntu1204-64b/machine/beagleboard/poky/edison/tmp/sysroots/x86_64-linux/usr/bin/armv7a-vfp-neon-poky-linux-gnueabi/../../lib/armv7a-vfp-neon-poky-linux-gnueabi/gcc/arm-poky-linux-gnueabi/4.6.3/include -pipe -DCONFIG_ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-interwork -march=armv5 -Wall -Wstrict-prototypes -fno-stack-protector -fno-toplevel-reorder -o hello_world.o hello_world.c -c | arm-poky-linux-gnueabi-gcc -g -O2 -fno-common -ffixed-r8 -msoft-float -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x80008000 -I/local/yocto/upstream/label/ubuntu1204-64b/machine/beagleboard/poky/edison/tmp/work/beagleboard-poky-linux-gnueabi/u-boot-v2011.06+git5+b1af6f532e0d348b153d5c148369229d24af361a-r0/git/include -fno-builtin -ffreestanding -nostdinc -isystem /local/yocto/upstream/label/ubuntu1204-64b/machine/beagleboard/poky/edison/tmp/sysroots/x86_64-linux/usr/bin/armv7a-vfp-neon-poky-linux-gnueabi/../../lib/armv7a-vfp-neon-poky-linux-gnueabi/gcc/arm-poky-linux-gnueabi/4.6.3/include -pipe -DCONFIG_ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-interwork -march=armv5 -Wall -Wstrict-prototypes -fno-stack-protector -fno-toplevel-reorder -o stubs.o stubs.c -c | arm-poky-linux-gnueabi-ld -r -o libstubs.o stubs.o | arm-poky-linux-gnueabi-ld -g -Ttext 0x8030 \ |-o hello_world -e hello_world hello_world.o libstubs.o \ |-L. -lgcc | arm-poky-linux-gnueabi-ld: cannot find -lgcc | make[1]: *** [hello_world] Error 1 Signed-off-by: Matthew McClintock m...@freescale.com --- meta/recipes-bsp/u-boot/u-boot.inc |2 +- meta/recipes-bsp/u-boot/u-boot_2011.03.bb|2 +- meta/recipes-bsp/u-boot/u-boot_2011.06.bb|2 +- meta/recipes-bsp/u-boot/u-boot_2012.04.01.bb |1 + 4 files changed, 4 insertions(+), 3 deletions(-) Merged to master, thanks. While trying to migrate the u-boot support for our machine from oe-classic i hit a problem with this patch. :( The EXTRA_OEMAKE = 'CROSS_COMPILE=${TARGET_PREFIX} CC=${TARGET_PREFIX}gcc ${TOOLCHAIN_OPTIONS}' in u-boot.inc leads to compiling problems with some build support tools. The tools (e.g. bmp_logo) are now compiled with the target compiler (arm-oe-linux-gnueabi-gcc in our case) instead of the host compiler. This results in build errors like | ./bmp_logo logos/denx.bmp /pm/sledz/oe-core/build/tmp-eglibc/work/hipox-oe-linux-gnueabi/u-boot-v2009.03+git91+e60beb13cf0135dc71c541021487b5ccc4d269cb-r8/git/include/bmp_logo.h | /bin/sh: ./bmp_logo: cannot execute binary file Reverting to EXTRA_OEMAKE = 'CROSS_COMPILE=${TARGET_PREFIX}' seems to fix this problem. That however will break building from sstate... we might need to patch u-boot's Makefiles here... -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] u-boot.inc: update linker arguments to pass --sysroot arg (BUILD BREAKAGE)
On Mon, Oct 29, 2012 at 9:36 AM, Matthew McClintock m...@freescale.com wrote: On Mon, Oct 29, 2012 at 4:26 AM, Steffen Sledz sl...@dresearch-fe.de wrote: On 29.07.2012 11:29, Richard Purdie wrote: On Thu, 2012-07-26 at 11:21 -0500, Matthew McClintock wrote: If we are building from sstate-cache it's possible to be building from another folder on another machine, therefore the linker requires that a proper --sysroot is passed too it so it can find things like libgcc.a and avoid errors such as: | arm-poky-linux-gnueabi-gcc -g -O2 -fno-common -ffixed-r8 -msoft-float -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x80008000 -I/local/yocto/upstream/label/ubuntu1204-64b/machine/beagleboard/poky/edison/tmp/work/beagleboard-poky-linux-gnueabi/u-boot-v2011.06+git5+b1af6f532e0d348b153d5c148369229d24af361a-r0/git/include -fno-builtin -ffreestanding -nostdinc -isystem /local/yocto/upstream/label/ubuntu1204-64b/machine/beagleboard/poky/edison/tmp/sysroots/x86_64-linux/usr/bin/armv7a-vfp-neon-poky-linux-gnueabi/../../lib/armv7a-vfp-neon-poky-linux-gnueabi/gcc/arm-poky-linux-gnueabi/4.6.3/include -pipe -DCONFIG_ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-interwork -march=armv5 -Wall -Wstrict-prototypes -fno-stack-protector -fno-toplevel-reorder -o hello_world.o hello_world.c -c | arm-poky-linux-gnueabi-gcc -g -O2 -fno-common -ffixed-r8 -msoft-float -D__KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x80008000 -I/local/yocto/upstream/label/ubuntu1204-64b/machine/beagleboard/poky/edison/tmp/work/beagleboard-poky-linux-gnueabi/u-boot-v2011.06+git5+b1af6f532e0d348b153d5c148369229d24af361a-r0/git/include -fno-builtin -ffreestanding -nostdinc -isystem /local/yocto/upstream/label/ubuntu1204-64b/machine/beagleboard/poky/edison/tmp/sysroots/x86_64-linux/usr/bin/armv7a-vfp-neon-poky-linux-gnueabi/../../lib/armv7a-vfp-neon-poky-linux-gnueabi/gcc/arm-poky-linux-gnueabi/4.6.3/include -pipe -DCONFIG_ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-interwork -march=armv5 -Wall -Wstrict-prototypes -fno-stack-protector -fno-toplevel-reorder -o stubs.o stubs.c -c | arm-poky-linux-gnueabi-ld -r -o libstubs.o stubs.o | arm-poky-linux-gnueabi-ld -g -Ttext 0x8030 \ |-o hello_world -e hello_world hello_world.o libstubs.o \ |-L. -lgcc | arm-poky-linux-gnueabi-ld: cannot find -lgcc | make[1]: *** [hello_world] Error 1 Signed-off-by: Matthew McClintock m...@freescale.com --- meta/recipes-bsp/u-boot/u-boot.inc |2 +- meta/recipes-bsp/u-boot/u-boot_2011.03.bb|2 +- meta/recipes-bsp/u-boot/u-boot_2011.06.bb|2 +- meta/recipes-bsp/u-boot/u-boot_2012.04.01.bb |1 + 4 files changed, 4 insertions(+), 3 deletions(-) Merged to master, thanks. While trying to migrate the u-boot support for our machine from oe-classic i hit a problem with this patch. :( The EXTRA_OEMAKE = 'CROSS_COMPILE=${TARGET_PREFIX} CC=${TARGET_PREFIX}gcc ${TOOLCHAIN_OPTIONS}' in u-boot.inc leads to compiling problems with some build support tools. The tools (e.g. bmp_logo) are now compiled with the target compiler (arm-oe-linux-gnueabi-gcc in our case) instead of the host compiler. This results in build errors like | ./bmp_logo logos/denx.bmp /pm/sledz/oe-core/build/tmp-eglibc/work/hipox-oe-linux-gnueabi/u-boot-v2009.03+git91+e60beb13cf0135dc71c541021487b5ccc4d269cb-r8/git/include/bmp_logo.h | /bin/sh: ./bmp_logo: cannot execute binary file Reverting to EXTRA_OEMAKE = 'CROSS_COMPILE=${TARGET_PREFIX}' seems to fix this problem. That however will break building from sstate... we might need to patch u-boot's Makefiles here... Looking closer you are using a really old u-boot. Can you update? The Makefile for bmp_logo uses HOSTCC so this should not be an issue with a recent u-boot. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] Using SSTATE_MIRRORS with sstate subdirectories
On Fri, Oct 19, 2012 at 11:57 AM, Mike Crowe m...@mcrowe.com wrote: On Fri, Oct 19, 2012 at 08:46:23AM -0700, Chris Larson wrote: On Fri, Oct 19, 2012 at 8:38 AM, Mike Crowe m...@mcrowe.com wrote: I'm having trouble using SSTATE_MIRRORS as suggested at https://wiki.yoctoproject.org/wiki/Enable_sstate_cache : SSTATE_MIRRORS ?= file://.* file:///private/sstate-cache/ SSTATE_MIRRORS ?= file://.* file:///private/sstate-cache/PATH Thanks for your reply. Although that works for the simple case, if I try and do something more adventurous like: SSTATE_MIRRORS = \ file://Debian-testing/.* file:///private/sstate-cache/Debian-6.0.6/PATH \n \ file://.* file:///private/sstate-cache/PATH \n \ Then I get paths like: DEBUG: For url file://Debian-testing/8c/sstate-tar-replacement-native-x86_64-linux-1.26-r3-x86_64-2-8cc4342260b064ace38e0aa1acf2f618_populate-sysroot.tgz returning file:///private/sstate-cache/Debian-6.0.6/Debian-testing/8c/sstate-tar-replacement-native-x86_64-linux-1.26-r3-x86_64-2-8cc4342260b064ace38e0aa1acf2f618_populate-sysroot.tgz so I really would like to be able to say: file://Debian-testing/(.*) file:///private/sstate-cache/Debian-6.0.6/\1 Something like this might be what you are looking for: SSTATE_MIRRORS = file://.*/(.*)/(.*) http://linux.freescale.net/yocto/sstate-cache/CentOS-5.8/\1/\2 \n This maps all native sstate-cache to my CentOS-5 box. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] Can we trust to sstate-cache?
On Thu, Oct 18, 2012 at 8:36 AM, Marcin Juszkiewicz marcin.juszkiew...@linaro.org wrote: Today I bumped gcc-linaro from 4.7-r5 to 4.7-r6. First version was plain 2012.10 release while second one was tarball from bzr repository with huge set of ICE related fixes for AArch64 architecture. To do fast clean build I removed TMPDIR and started new build of core-image-minimal target. But then I noticed ugly thing: 0: eglibc-2.16-r18+svnr20393 do_populate_sysroot_setscene (pid 30106) 1: eglibc-2.16-r18+svnr20393 do_package_setscene (pid 30107) 3: eglibc-initial-2.16-r18+svnr20393 do_package_setscene (pid 28921) Why eglibc was taken from sstate-cache instead of being rebuilt (like it was with 'db')? This makes me sad as it shows that I cannot trust sstate-cache so each new build will take hours instead of minutes. Or maybe I am wrong? Did the signatures for eglibc change after making your gcc-linaro change? You can run bitbake -S before and after and see which ones have new stamps. Then you can start using bitbake-diffsigs to back track (or presumably if nothing changed add a proper dependency) -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] cryptodev kernel module recipe
On Thu, Oct 18, 2012 at 2:59 PM, Darren Hart dvh...@linux.intel.com wrote: On 10/18/2012 02:14 AM, Khem Raj wrote: On Oct 18, 2012, at 2:57 AM, Yashpal Dutta yashpal.du...@freescale.com wrote: +-install: ++modules_install: +make -C $(KERNEL_DIR) SUBDIRS=`pwd` modules_install +- @echo Installing cryptodev.h in /usr/include/crypto ... +- @install -D crypto/cryptodev.h /usr/include/crypto/cryptodev.h ++ @echo Installing cryptodev.h in $(PREFIX)/usr/include/crypto ... ++ @install -D crypto/cryptodev.h $(PREFIX)/usr/include/crypto/cryptodev.h + why is it installing linux headers under /usr/include shouldn't they be under usr/include/linux ? And shouldn't /usr/include be one of those ${*dir} variables? That's a patch to a Makefile... not a recipe. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] cryptodev kernel module recipe
On Thu, Oct 18, 2012 at 3:16 PM, Darren Hart dvh...@linux.intel.com wrote: On 10/18/2012 05:57 AM, Yashpal Dutta wrote: This is a /dev/crypto device driver, equivalent to those in OpenBSD or FreeBSD. The main idea is to access of existing ciphers in kernel space from userspace, thus enabling re-use of a hardware implementation of a cipher. Signed-off-by: Yashpal Dutta yashpal.du...@freescale.com --- meta/recipes-kernel/cryptodev/cryptodev_1.5.bb | 18 + .../cryptodev/files/makefile_fixup.patch | 26 2 files changed, 44 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-kernel/cryptodev/cryptodev_1.5.bb create mode 100644 meta/recipes-kernel/cryptodev/files/makefile_fixup.patch diff --git a/meta/recipes-kernel/cryptodev/cryptodev_1.5.bb b/meta/recipes-kernel/cryptodev/cryptodev_1.5.bb new file mode 100644 index 000..5125710 --- /dev/null +++ b/meta/recipes-kernel/cryptodev/cryptodev_1.5.bb @@ -0,0 +1,18 @@ +SECTION = devel +SUMMARY = Linux Cryptodev KERNEL MODULE +DESCRIPTION = The Cryptodev package contains the kernel /dev/crypto module +LICENSE = GPLv2 +LIC_FILES_CHKSUM = file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 + +DEPENDS = virtual/kernel This DEPENDS in inherited from the module.bbclass, no need to duplicate + +inherit module + +SRCREV = 1c24a0aa996630518d47826a2e3fea129ea094c7 + +SRC_URI = git://repo.or.cz/cryptodev-linux.git;protocol=git \ + file://makefile_fixup.patch Tabs to indent, spaces to align. Spaces here please. + +EXTRA_OEMAKE='KERNEL_DIR=${STAGING_KERNEL_DIR} PREFIX=${D}' modules.bbclass already sets KERNEL_PATH and KERNEL_SRC, perhaps you could use one of those? cryptodev Makefile does not use these it uses KERNEL_DIR in it's Makefile for whatever reason. Getting an upstream project to change is more difficult. If you just use ${includedir} in your install I believe you can skip PREFIX here and get the /usr part right there. This is more changes to the upstream Makefile + +S = ${WORKDIR}/git diff --git a/meta/recipes-kernel/cryptodev/files/makefile_fixup.patch b/meta/recipes-kernel/cryptodev/files/makefile_fixup.patch new file mode 100644 index 000..323aacd --- /dev/null +++ b/meta/recipes-kernel/cryptodev/files/makefile_fixup.patch @@ -0,0 +1,26 @@ +diff --git a/Makefile b/Makefile +index 2be8825..b36d68c 100644 +--- a/Makefile b/Makefile +@@ -1,6 +1,7 @@ + KBUILD_CFLAGS += -I$(src) + KERNEL_DIR = /lib/modules/$(shell uname -r)/build + VERSION = 1.5 ++PREFIX = + + cryptodev-objs = ioctl.o main.o cryptlib.o authenc.o zc.o util.o + +@@ -12,10 +13,10 @@ build: version.h + version.h: Makefile + @echo #define VERSION \$(VERSION)\ version.h + +-install: ++modules_install: + make -C $(KERNEL_DIR) SUBDIRS=`pwd` modules_install Current kernels recommend using M= instead of SUBDIRS=: SRC := $(shell pwd) make -C $(KERNEL_SRC) M=$(SRC) modules_install See the hello-mod example in meta-skeleton/recipes-kernel/hello-mod for a minimal example. +-@echo Installing cryptodev.h in /usr/include/crypto ... +-@install -D crypto/cryptodev.h /usr/include/crypto/cryptodev.h ++@echo Installing cryptodev.h in $(PREFIX)/usr/include/crypto ... ++@install -D crypto/cryptodev.h $(PREFIX)/usr/include/crypto/cryptodev.h Use ${includedir} here You can't use this bitbake variable in a Makefile... or am I missing something? We are making small changes the Makefile for things like prefix so we can install to locations other than the hosts /usr/include which is hard coded. -M + + clean: + make -C $(KERNEL_DIR) SUBDIRS=`pwd` clean M= Is changing upstream cryptodev is one thing (e.g. SUBDIR= vs. M=), how far do you want a patch to a Makefile to change the way a project builds? -M -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] cryptodev kernel module recipe
On Thu, Oct 18, 2012 at 3:38 PM, Darren Hart dvh...@linux.intel.com wrote: +EXTRA_OEMAKE='KERNEL_DIR=${STAGING_KERNEL_DIR} PREFIX=${D}' modules.bbclass already sets KERNEL_PATH and KERNEL_SRC, perhaps you could use one of those? cryptodev Makefile does not use these it uses KERNEL_DIR in it's Makefile for whatever reason. Getting an upstream project to change is more difficult. I think this is the second reference to KERNEL_DIR in an external module, perhaps module.bbclass should add that to it's list of predefined names for the STAGING_KERNEL_DIR. Fine with me, but not sure how its worth it quite yet... ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] Recipes with disabled parallel make
On Thu, Mar 8, 2012 at 7:34 AM, Andreas Oberritter o...@opendreambox.org wrote: On 02.03.2012 23:29, Yury Bushmelev wrote: 2012/2/10 Khem Raj raj.k...@gmail.com: Hi Just grepped for the occurances of disabled parallel make and I see around 40 cases on oe-core git grep PARALLEL_MAKE.*=.*\\ recipes* | grep -v # If someone has time to kill then it would help to see if some of these are fixed by time or can be fixed it can help in paralleling the build a bit more. Well, I have some first results! :) 1. Recipes (files) confirmed to fail with P_M enabled (need to have P_M disabled as it is now): meta/recipes-connectivity/bind/bind_9.8.1.bb meta/recipes-extended/slang/slang_2.2.4.bb meta/recipes-extended/tcp-wrappers/tcp-wrappers_7.6.bb meta/recipes-support/js/js_1.7.0+1.8.0rc1.bb meta/recipes-support/pth/pth_2.0.7.bb meta/recipes-devtools/libtool/libtool_2.4.2.bb might need disabled P_M, too: | ./mipsel-oe-linux-libtool --tag=CC --mode=compile ccache mipsel-oe-linux-gcc -mel -mabi=32 -mhard-float -march=mips32 --sysroot=.../tmp/sysroots/dm7020hd -DHAVE_CONFIG_H -I. -DLTDLOPEN=libltdl -DLT_CONFIG_H='config.h' -DLTDL -I. -I. -Ilibltdl -I./libltdl -I./libltdl/libltdl -Os -pipe -g -feliminate-unused-debug-types -c -o libltdl/libltdl_libltdl_la-slist.lo `test -f 'libltdl/slist.c' || echo './'`libltdl/slist.c | /bin/sh: ./mipsel-oe-linux-libtool: /bin/sh: bad interpreter: Text file busy | make[2]: *** [libltdl/libltdl_libltdl_la-slist.lo] Error 126 | make[2]: *** Waiting for unfinished jobs This was a fresh build with clean tmp and sstate-cache. I've just seen this failue for the first time. BB_NUMBER_THREADS = 4 PARALLEL_MAKE = -j 4 I'm seeing this on denzil on Ubuntu 10.04.2 LTS 32-bit. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/6] denzil pull request 3
On Fri, Oct 5, 2012 at 2:52 PM, Scott Garman scott.a.gar...@intel.com wrote: nightly-ppc-lsb: kernel compile failure http://autobuilder.yoctoproject.org:8010/builders/nightly-ppc-lsb/builds/82 kernel do_compile failure for mpc8315e_rdb-poky-linux: | BOOTCC arch/powerpc/boot/cuboot-pq2.o | In file included from /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc-lsb/build/build/tmp/work/mpc8315e_rdb-poky-linux/linux-yocto-3.0.32+git1+34e0d2b4b4e9778b31f9ea99ca43f0dc71a7ee23_1+83f422f718cf15633cb4c2d309aa041c3c354f65-r4/linux/arch/powerpc/boot/epapr.c:20:0: | arch/powerpc/boot/libfdt.h:854:1: error: unterminated comment | arch/powerpc/boot/libfdt.h:1:0: error: unterminated #ifndef | BOOTCC arch/powerpc/boot/cuboot-sequoia.o | make[3]: *** [arch/powerpc/boot/epapr.o] Error 1 | make[3]: *** Waiting for unfinished jobs | make[2]: *** [uImage] Error 2 | make[1]: *** [sub-make] Error 2 | make: *** [all] Error 2 | ERROR: oe_runmake failed NOTE: package linux-yocto-3.0.32+git1+34e0d2b4b4e9778b31f9ea99ca43f0dc71a7ee23_1+83f422f718cf15633cb4c2d309aa041c3c354f65-r4: task do_compile: Failed I heard from Matthew McClintock that a fix for this has been sent upstream, sounds like we need to get this merged to our kernel tree. FYI, http://patchwork.ozlabs.org/patch/182260/ -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] RFC: Secondary Toolchain
On Thu, Oct 4, 2012 at 1:02 PM, Mark Hatle mark.ha...@windriver.com wrote: We have an issue where we'd like to have an alternative toolchain (assembler, linker, compiler) available for our customers to selectively use. However, before we just go off and implement something, I'd like at least some basic consensus on what the best practice is for doing this work. Below is my attempt at an early proposal. Background Many companies have commercial / highly optimized toolchains for specific purpose, such as ICC from Intel, LLVM, ARM specific toolchain, etc.. For (potentially) better performance with some applications a mechanism to both provide the hooks for the alternative toolchain as well as a way to active it per-package is desired. This work assumes that the third party toolchain is generally compatible with the idea of sysroots, linking to the libc provided by OE, and generally compatible with GNU conventions. However, as part of the third party toolchain, it may not be GNU compatible. This means many Open Source applications simply may not work with this toolchain. That means that we need to have a way for a toolchain to blacklist (or whitelist) specific recipes. This way only supported components can be built by the user, avoiding numerous complaints. Currently OE has a method to generate an SDK based on the GNU toolchain. We would like to be able to also export the external toolchain along with the SDK, effectively providing both the GNU toolchain and the third party toolchain using the common sysroot. We need a way to active the third party toolchain on a per-package basis. This activation will need to use the existing sysroot, but be able to pass different C, C++, LD, AS and other flags as specified by the third party toolchain. Finally third party toolchains should be implemented as layers that can easily plug into OE. Implementation - Add an OVERRIDE to specify the alternative toolchain. Can this be done within the layer by doing something like: OVERRIDE_append = :toolchain-${TOOLCHAIN} TOOLCHAIN = gnu (or icc) To activate the toolchain you would use things like: TOOLCHAIN_pn-bash = 'icc' To define the correct behavior for the toolchain, the following would need to be defined (with _toolchain-toolchain): TARGET_CPPFLAGS TARGET_CFLAGS TARGET_CXXFLAGS TARGET_LDFLAGS CC CXX F77 CPP LD CCLD AR AS RANLIB STRIP OBJCOPY OBJDUMP NM FULL_OPTIMIZATIONS DEBUG_OPTIMIZATION Is anyone aware of any other items that may require additional items? Will the above actually work? Using the override of the TOOLCHAIN_… will that actually change the override values or do we get stuck? This seems orthogonal to actually implementing the recipe which would procide 'icc'? -M Comments/suggestions appreciated! --Mark ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2 10/10] libx11.inc: fix build issues for older CentOS distros
On Fri, Sep 28, 2012 at 10:03 AM, Matthew McClintock m...@freescale.com wrote: On Fri, Sep 28, 2012 at 9:52 AM, Burton, Ross ross.bur...@intel.com wrote: On 28 September 2012 02:33, Matthew McClintock m...@freescale.com wrote: Fixes these sorts of issues present on older gcc (CentOS 5.x in this case) | cc1: error: unrecognized command line option -Werror=implicit | cc1: error: unrecognized command line option -Werror=nonnull Took me a minute to realise why this happens. This happens when cross-building because although configure is checking that the flags it uses are supported by the compiler, it's only doing that for the cross and not the host compiler. Right? (upstream bug alert) Yea, I suppose the the host compiler should be checked by autotools if it supports these warning flags. Should this block applying this patch to oe-core or will there be upstream fixes before 1.3? -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] chrpath: We should provide chrpath-replacement-native and install into a native specific directory
Docs need to be updated, there was also a build warning if it was not installed - did that get removed too? -M On Tue, Oct 2, 2012 at 8:13 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: chrpath is assumed to be provided by the build host system. This means we need to provide a replacement version and install into a specific directory to avoid races. Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org --- diff --git a/meta/recipes-devtools/chrpath/chrpath_0.14.bb b/meta/recipes-devtools/chrpath/chrpath_0.14.bb index 679f1aa..bb9b4b6 100644 --- a/meta/recipes-devtools/chrpath/chrpath_0.14.bb +++ b/meta/recipes-devtools/chrpath/chrpath_0.14.bb @@ -20,4 +20,7 @@ inherit autotools # relocatable, so use the one we've just built CHRPATH_BIN_virtclass-native = ${S}/chrpath +PROVIDES_append_virtclass-native = chrpath-replacement-native +NATIVE_PACKAGE_PATH_SUFFIX = /${PN} + BBCLASSEXTEND = native nativesdk ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] chrpath: We should provide chrpath-replacement-native and install into a native specific directory
On Tue, Oct 2, 2012 at 11:29 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Tue, 2012-10-02 at 16:22 +, McClintock Matthew-B29882 wrote: Docs need to be updated, there was also a build warning if it was not installed - did that get removed too? You still need chrpath installed, this just avoids a different set of problems in nativesdk and corrected ASSUME_PROVIDED. You still need it installed on your host? -M Cheers, Richard ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] sstate: Add detail to shared area warning
On Tue, Oct 2, 2012 at 5:22 PM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Wed, 2012-10-03 at 00:11 +0200, Martin Jansa wrote: On Tue, Oct 02, 2012 at 11:00:53PM +0100, Phil Blundell wrote: On Tue, 2012-10-02 at 15:00 -0700, Saul Wold wrote: -bb.warn(The recipe is trying to install files into a shared area when those files already exist. Those files are:\n %s % \n .join(match)) +bb.warn(The %s recipe is trying to install files into a shared area when those files already exist (please fix %s). Those files are:\n %s % (d.getVar('PN', True), d.getVar('FILE', True), \n .join(match))) That seems potentially misleading: the file that needs fixing isn't necessarily the one that triggers this warning. What would be ideal would be to have it output the names of all recipes that have tried to stage the files in question so that the user can make an informed decision about which one ought to be putting them there. Maybe something like master.list was before http://git.openembedded.org/openembedded-core/commit/?id=603daf343ad3f18c8adb799e3625ae2a18d94f56 with added recipe name, but that doesn't detect files already We can list any sstate manifest files (tmp/sstate-control) also adding that file which may or may not have a listing of it. We might as well just grep those files and print matches. We are not going back to a master.list file, its a performance headache. I had to do this manually recently, so this error would be very useful ;) -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2 09/10] binutils.inc: add vardep on multiarch DISTRO_FEATURE
On Fri, Sep 28, 2012 at 5:32 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Thu, 2012-09-27 at 20:33 -0500, Matthew McClintock wrote: binutils will build differently if this feature is enabled, so make the do_configure step depend on it Signed-off-by: Matthew McClintock m...@freescale.com --- Not sure if we should try to fix via configure options v2: update commit message a bit meta/recipes-devtools/binutils/binutils.inc |2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc index ee748a4..ff64882 100644 --- a/meta/recipes-devtools/binutils/binutils.inc +++ b/meta/recipes-devtools/binutils/binutils.inc @@ -80,6 +80,8 @@ export CC_FOR_BUILD = LD_LIBRARY_PATH= ${BUILD_CC} export CPP_FOR_BUILD = ${BUILD_CPP} export CFLAGS_FOR_BUILD = ${BUILD_CFLAGS} +MULTIARCH := ${@bb.utils.contains(DISTRO_FEATURES, multiarch, yes, no, d)} +do_configure[vardeps] += MULTIARCH do_configure () { (cd ${S}; gnu-configize) || die Failed to run gnu-configize oe_runconf This doesn't make sense. oe_runconf should depend on EXTRA_OECONF and that should depend on DISTRO_FEATURES so the dependency should already exist? OK, maybe... let me just explain what I did to see an issue. Let's say I did a build without MULTIARCH and everything went fine. Then I went back and added mutliarch. binutils would not rebuild with the new features and things would break. With this patch, after added multiarch binutils would rebuild and the the build work OK. As you say though, if this was an actual dep it should have rebuilt already? Has anything changed in this area very recently? -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2 10/10] libx11.inc: fix build issues for older CentOS distros
On Fri, Sep 28, 2012 at 9:52 AM, Burton, Ross ross.bur...@intel.com wrote: On 28 September 2012 02:33, Matthew McClintock m...@freescale.com wrote: Fixes these sorts of issues present on older gcc (CentOS 5.x in this case) | cc1: error: unrecognized command line option -Werror=implicit | cc1: error: unrecognized command line option -Werror=nonnull Took me a minute to realise why this happens. This happens when cross-building because although configure is checking that the flags it uses are supported by the compiler, it's only doing that for the cross and not the host compiler. Right? (upstream bug alert) Yea, I suppose the the host compiler should be checked by autotools if it supports these warning flags. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2 09/10] binutils.inc: add vardep on multiarch DISTRO_FEATURE
On Fri, Sep 28, 2012 at 10:06 AM, Matthew McClintock m...@freescale.com wrote: On Fri, Sep 28, 2012 at 5:32 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Thu, 2012-09-27 at 20:33 -0500, Matthew McClintock wrote: binutils will build differently if this feature is enabled, so make the do_configure step depend on it Signed-off-by: Matthew McClintock m...@freescale.com --- Not sure if we should try to fix via configure options v2: update commit message a bit meta/recipes-devtools/binutils/binutils.inc |2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc index ee748a4..ff64882 100644 --- a/meta/recipes-devtools/binutils/binutils.inc +++ b/meta/recipes-devtools/binutils/binutils.inc @@ -80,6 +80,8 @@ export CC_FOR_BUILD = LD_LIBRARY_PATH= ${BUILD_CC} export CPP_FOR_BUILD = ${BUILD_CPP} export CFLAGS_FOR_BUILD = ${BUILD_CFLAGS} +MULTIARCH := ${@bb.utils.contains(DISTRO_FEATURES, multiarch, yes, no, d)} +do_configure[vardeps] += MULTIARCH do_configure () { (cd ${S}; gnu-configize) || die Failed to run gnu-configize oe_runconf This doesn't make sense. oe_runconf should depend on EXTRA_OECONF and that should depend on DISTRO_FEATURES so the dependency should already exist? OK, maybe... let me just explain what I did to see an issue. Let's say I did a build without MULTIARCH and everything went fine. Then I went back and added mutliarch. binutils would not rebuild with the new features and things would break. With this patch, after added multiarch binutils would rebuild and the the build work OK. As you say though, if this was an actual dep it should have rebuilt already? Has anything changed in this area very recently? Looking closer it seems like EXTRA_OECONF does not do this quite right when resolving base_contains parameters: List of dependencies for variable EXTRA_OECONF is set(['gettext_oeconf', 'STAGING_DIR_TARGET', 'base_contains', 'TARGET_PREFIX']) -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] gcc-common.inc: Consider multilib when renaming libgcc for debian'ness
On Wed, Sep 26, 2012 at 5:55 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Tue, 2012-09-25 at 18:07 +, McClintock Matthew-B29882 wrote: This should probably go in denzil as well. Lets hold off that as I think we need to fix this in a better way at the core level... This? Where there follow up fixes also? -M commit 42e8c8056719326b68b1602e0699eba00a924d2b Author: Richard Purdie richard.pur...@linuxfoundation.org Date: Wed Sep 26 12:56:58 2012 +0100 packagedata/multilib: Fix search patch for multilib builds The current multilib search path code for packagedata is flawed since it doesn't correctly handle changes in the TARGET_VENDOR/TARGET_OS that multilib may make. This patch enhances the code to correctly build the search paths so multilib packagedata is found correctly. (From OE-Core rev: f50c5d36b2da9b36d56d95a7d89404509a1a3e9b) Signed-off-by: Richard Purdie richard.pur...@linuxfoundation.org Cheers, Richard ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] autotools.bbclass: Add functionality to force a clean of ${B} when reconfiguring (and ${S} != ${B})
On Fri, Sep 28, 2012 at 8:23 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Wed, 2012-09-26 at 18:07 +0100, Phil Blundell wrote: On Tue, 2012-09-11 at 15:22 +0100, Richard Purdie wrote: Unfortunately whilst rerunning configure and make against a project will mostly work there are situations where it does not correctly do the right thing. In particular, eglibc and gcc will fail out with errors where settings do not match a previously built configuration. It could be argued they are broken but the situation is what it is. There is the possibility of more subtle errors too. FWIW, I just encountered another instance of what appears to be a similar problem (with this patch applied). I had changed my CFLAGS to work around a compiler problem and then just reran the build, which led eventually to: ERROR: Function failed: do_siteconfig_gencache (see /tmp-eglibc/work/mips32el-oe-linux/eglibc/2.16-r11.micro1 +svnr20393/temp/log.do_populate_sysroot.6005 for further information) ERROR: Logfile of failure stored in: /tmp-eglibc/work/mips32el-oe-linux/eglibc/2.16-r11.micro1 +svnr20393/temp/log.do_populate_sysroot.6005 Log data follows: | DEBUG: Executing python function sstate_task_prefunc [...] | DEBUG: Executing shell function do_siteconfig_gencache | configure: WARNING: unrecognized options: --disable-silent-rules, --disable-dependency-tracking, --with-libtool-sysroot | configure: loading cache eglibc_cache | configure: error: `CFLAGS' has changed since the previous run: | configure: former value: `...' | configure: current value: `...' | configure: error: in `/.../tmp-eglibc/work/mips32el-oe-linux/eglibc/2.16-r11.micro1 +svnr20393/site_config_cheetah': | configure: error: changes in the environment can compromise the build | configure: error: run `make distclean' and/or `rm eglibc_cache' and start over | DEBUG: Python function siteconfig_do_siteconfig finished | DEBUG: Python function autotools_do_siteconfig finished | DEBUG: Python function do_siteconfig finished | DEBUG: Python function sstate_task_postfunc finished ERROR: Task 30 (.../oe-core/meta/recipes-core/eglibc/eglibc_2.16.bb, do_populate_sysroot) failed with exit code '1' I also ran into this and have posted a fix (to siteconfig.bbclass) which once applied let my build continue. I've seen this now: ERROR: Logfile of failure stored in: /local/yocto/upstream/label/fedora17-64b/machine/beagleboard/poky/master/tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/flex-2.5.35-r3/temp/log.do_configure.26311 Log data follows: | DEBUG: Executing python function sysroot_cleansstate | DEBUG: Removing manifest: /local/yocto/upstream/label/fedora17-64b/machine/beagleboard/poky/master/tmp/sysroots/beagleboard/usr/include/FlexLexer.h | DEBUG: Removing manifest: /local/yocto/upstream/label/fedora17-64b/machine/beagleboard/poky/master/tmp/sysroots/beagleboard/usr/lib/libfl.a | DEBUG: Removing manifest: /local/yocto/upstream/label/fedora17-64b/machine/beagleboard/poky/master/tmp/sysroots/beagleboard/usr/lib/libfl_pic.a | DEBUG: Removing manifest: /local/yocto/upstream/label/fedora17-64b/machine/beagleboard/poky/master/tmp/sysroots/beagleboard/usr/include/ | DEBUG: Removing manifest: /local/yocto/upstream/label/fedora17-64b/machine/beagleboard/poky/master/tmp/sysroots/beagleboard/usr/share/ | DEBUG: Removing manifest: /local/yocto/upstream/label/fedora17-64b/machine/beagleboard/poky/master/tmp/sysroots/beagleboard/usr/lib/ | DEBUG: Removing manifest: /local/yocto/upstream/label/fedora17-64b/machine/beagleboard/poky/master/tmp/sysroots/beagleboard/usr/ | DEBUG: Python function sysroot_cleansstate finished | DEBUG: SITE files ['endian-little', 'bit-32', 'arm-common', 'common-linux', 'common-glibc', 'arm-linux', 'arm-linux-gnueabi', 'common'] | DEBUG: Executing shell function autotools_preconfigure | DEBUG: Shell function autotools_preconfigure finished | DEBUG: Executing shell function do_configure | automake (GNU automake) 1.12.3 | Copyright (C) 2012 Free Software Foundation, Inc. | License GPLv2+: GNU GPL version 2 or later http://gnu.org/licenses/gpl-2.0.html | This is free software: you are free to change and redistribute it. | There is NO WARRANTY, to the extent permitted by law. | | Written by Tom Tromey tro...@redhat.com |and Alexandre Duret-Lutz a...@gnu.org. | AUTOV is 1.12 | NOTE: Executing autoreconf --verbose --install --force --exclude=autopoint -I /local/yocto/upstream/label/fedora17-64b/machine/beagleboard/poky/master/tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/flex-2.5.35-r3/flex-2.5.35/m4/ -I/local/yocto/upstream/label/fedora17-64b/machine/beagleboard/poky/master/tmp/sysroots/x86_64-linux/usr/share/aclocal-1.12 -I /local/yocto/upstream/label/fedora17-64b/machine/beagleboard/poky/master/tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/flex-2.5.35-r3/flex-2.5.35/aclocal-copy/ | autoreconf: Entering directory `.' | autoreconf: running: aclocal -I
[OE-core] [PATCH v2 09/10] binutils.inc: add vardep on multiarch DISTRO_FEATURE
binutils will build differently if this feature is enabled, so make the do_configure step depend on it Signed-off-by: Matthew McClintock m...@freescale.com --- Not sure if we should try to fix via configure options v2: update commit message a bit meta/recipes-devtools/binutils/binutils.inc |2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc index ee748a4..ff64882 100644 --- a/meta/recipes-devtools/binutils/binutils.inc +++ b/meta/recipes-devtools/binutils/binutils.inc @@ -80,6 +80,8 @@ export CC_FOR_BUILD = LD_LIBRARY_PATH= ${BUILD_CC} export CPP_FOR_BUILD = ${BUILD_CPP} export CFLAGS_FOR_BUILD = ${BUILD_CFLAGS} +MULTIARCH := ${@bb.utils.contains(DISTRO_FEATURES, multiarch, yes, no, d)} +do_configure[vardeps] += MULTIARCH do_configure () { (cd ${S}; gnu-configize) || die Failed to run gnu-configize oe_runconf -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH v2 05/10] arch-powerpc.inc: add altivec as a valid tune feature
Signed-off-by: Matthew McClintock m...@freescale.com --- v2: no changes This patch and the others should fix Yocto bug #3072 meta/conf/machine/include/powerpc/arch-powerpc.inc |2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc index 12909d9..ae81cde 100644 --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc @@ -19,6 +19,8 @@ TUNEVALID[fpu-soft] = Use software FPU. TUNE_CCARGS += ${@bb.utils.contains(TUNE_FEATURES, fpu-soft, -msoft-float, , d)} TARGET_FPU .= ${@bb.utils.contains(TUNE_FEATURES, fpu-soft, soft, , d)} +TUNEVALID[altivec] = Altivec + # Basic tune definitions AVAILTUNES += powerpc powerpc-nf TUNE_FEATURES_tune-powerpc-nf = m32 fpu-soft -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core