Re: [OE-core] Debugging rust oe-selftest failures

2024-05-14 Thread Randy MacLeod via lists.openembedded.org

On 2024-04-05 7:28 a.m., Alex Kiernan via lists.openembedded.org wrote:

On Thu, Apr 4, 2024 at 10:07 AM Yash Shinde via lists.openembedded.org
  wrote:

On Wed, Apr 3, 2024 at 05:51 PM, Alex Kiernan wrote:

Hi Sundeep (or anyone else with insight on this!)

How do you go about debugging rust oe-selftest failures? I've bumped
everything up to 1.77 (https://github.com/akiernan/poky) but
oe-selftest fails for reasons that aren't immediately obvious to me...

https://gist.github.com/akiernan/6cc6131c1ec3af866098a9318679cf1b

Any clues?

--
Alex Kiernan




Hi Alex,

I faced the same errors when I was working on to upgrade rust from 1.75 to 
1.76. I discussed it with rust upstream 
here,https://github.com/rust-lang/rust/issues/122075  and the following change 
solves those failures,

https://github.com/rust-lang/rust/issues/122075#issuecomment-1985153524

PR-https://github.com/rust-lang/rust/pull/122205/commits/5aece7fad06baaa745784d118db862b3e3ccf7f8





After this change was backported to poky, the rust build was successful but it 
was seen that not all the tests are executed.

While discussing upstream, it was known that removing the --doc option from python3 
src/bootstrap/bootstrap.py test --exclude --doc 
--no-fail-fast --bless --target x86_64-poky-linux-gnu  cmd in 
oeqa/selftest/cases/rust.py file execute the other tests also.





But, while doing so another set of failures are observed as mentioned 
inhttps://github.com/rust-lang/rust/issues/122285

Complete log using --doc 
option-https://gist.github.com/Yashinde145/7db6bd4a064021bf756b0c0dd6c8777c

Complete log without using --doc 
option-https://gist.github.com/Yashinde145/036a934f0523307859f7c855b83ecfd6  
(this file is truncated in gist due to large size, please see Complete raw file)

I am not very familiar to these failures but  trying to understand them.


Feels like you're way ahead of me. I'll have a bit more of a poke at
it when I've some time, but it feels like we may be mostly waiting on
upstream (and a big +1 for getting them engaged!)


FYI,

Sundeep and Yashe have Rust 1.77 (8?) compiling reproducibly.
They found some problems with the rust test suite and
are working on fixing or avoiding those errors before submitting a patch.


../Randy










--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199262): 
https://lists.openembedded.org/g/openembedded-core/message/199262
Mute This Topic: https://lists.openembedded.org/mt/105307188/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2 07/11] kea: Remove -fvisibility-inlines-hidden from C++ flags

2024-05-14 Thread Randy MacLeod via lists.openembedded.org

On 2024-05-07 3:56 p.m., Alexander Kanavin via lists.openembedded.org wrote:

On Tue, 7 May 2024 at 18:13, Khem Raj  wrote:

Firstly I am inclined towards removing it if we can, since I think it should be
packages to decide to use it, then they can maintain it better from testing POV,
However, there is something
to consider w.r.t. to this option. This does help in optimizing loading DSOs
by reducing the number of PLTs and improves loading time for DSOs which might
be quite meaningful for embedded devices that we target. However, we only
enable hidden visibility only for inlines so it won't be full benefits but we do
have better default compatibility.

Since we have had this option for a long time and it still seems
relevant, I would
think it would make sense to do some benchmarking on a sizeable C++ program
perhaps chromium or webkit, and see the difference in DSOs sizes with
and without
this option and also benchmark the loading time of the resulting
chromium package.

maybe we will find that the gains are not as significant, in that case
we might drop
it from defaults.

I digged deeper and this is where I think it originated:
https://git.openembedded.org/openembedded/commit/?id=ddd6d1fd26416a3766d754eeda4237a680a65520

Ah the simpler times of oe-classic, when one could bundle four
unrelated changes into one commit and explain none of them.

Benchmarking I have no time for right now, just wanted to point out
that adding the flag was never justified in commit log. Can you
experiment with webkit?



I tried to build chromium with and without this flag but ran into build 
problems - sigh.


I pulled out the next most-bloated single executable that I could think 
of: nodejs


The bottom line is that the flag reduces the nodejs executable size  by ~6%.
Actual sizes:

>>> 37333922 - 35245092
2088830

so 2 MB out of 37 MB !

Chromium has been updated over the weekend so I'll try that next.

What else would people like to see to assess the utility of this 
compiler option?



../Randy

Original build:

❯ size 
../chromium-poky-m-aab1335523/tmp/work/core2-64-poky-linux/nodejs/20.12.2/packages-split/nodejs/usr/bin/node 


   text    data bss dec hex filename
35245092 628548  154792 36028432    225c010 
../chromium-poky-m-aab1335523/tmp/work/core2-64-poky-linux/nodejs/20.12.2/packages-split/nodejs/usr/bin/node


With this patch:

❯ git diff
diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_20.12.2.bb 
b/meta-oe/recipes-devtools/nodejs/nodejs_20.12.2.bb

index d86c38f2f..50cff533f 100644
--- a/meta-oe/recipes-devtools/nodejs/nodejs_20.12.2.bb
+++ b/meta-oe/recipes-devtools/nodejs/nodejs_20.12.2.bb
@@ -42,6 +42,8 @@ S = "${WORKDIR}/node-v${PV}"

 CVE_PRODUCT += "node.js"

+CXXFLAGS:remove = "-fvisibility-inlines-hidden"
+
 # v8 errors out if you have set CCACHE
 CCACHE = ""


❯ size 
tmp/work/core2-64-poky-linux/nodejs/20.12.2/packages-split/nodejs/usr/bin/node 


   text    data bss dec hex filename
37333922 628548  154792 38117262    2459f8e 
tmp/work/core2-64-poky-linux/nodejs/20.12.2/packages-split/nodejs/usr/bin/node


❯ python3
Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> 35245092.0/37333922.0*100.0
94.40500786389386





Alex





--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199260): 
https://lists.openembedded.org/g/openembedded-core/message/199260
Mute This Topic: https://lists.openembedded.org/mt/105955497/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2 0/5] Improvements for performance test report view

2024-05-03 Thread Randy MacLeod via lists.openembedded.org

On 2024-05-03 10:43 a.m., Ninette Adhikari wrote:

This work is done according to "Milestone 9: Build performance test report 
view" as stated in the Scope of Work with Sovereign Tech Fund (STF) 
(https://www.sovereigntechfund.de/).
The current report can be accessed here:
Performance test report HTML 
(https://autobuilder.yocto.io/pub/non-release/20240117-15/testresults/buildperf-alma8/perf-alma8_master_20240117090048_663f180574.html)
The report is created using the `oe-build-perf-report` script in the poky 
repository. This script generates a performance test report in HTML format 
using the data from the yocto-buildstats 
(https://git.yoctoproject.org/yocto-buildstats/) repository.
The report displays the performance test results in line chart format. The 
chart x-axis represents the commit numbers, and the y-axis represents the test 
duration in minutes.
The report also includes a table that displays the measurement statistics data 
for each test. The report is interactive and allows users to zoom in on 
specific sections of the line chart.

The current report format required some updates to make it more interactive and 
user-friendly. And this patch addresses such improvements:

- Add [Apache echart](https://echarts.apache.org/en/index.html) library to 
create oe build performance report charts and make them interactive.
- Restructure data to time and value array format to be used by echarts. It 
also converts test duration to minutes and adds zoom to the charts.
- Update measurement statistics data to include `start_time` so that time can 
be displayed instead of commit numbers on the chart. It also updates default 
commit history length to 300.
- Add styling updates including page margin, labels for x and y axis, tooltip, 
and section descriptions.

The tooltips are very nice and useful so

- The charts are created as step charts instead of plain line charts.
- Add start time, size, and commit number to tooltip.
- Add dark mode view

Updated report screenshots:
https://github.com/neighbourhoodie/poky/assets/13760198/65a1890c-fd2a-40d4-ac90-f13055735e53
https://github.com/neighbourhoodie/poky/assets/13760198/b40c326b-17d2-42e2-8e41-72e52ed2c003
https://github.com/neighbourhoodie/poky/assets/13760198/cc7ec996-9dab-435a-8fdc-82a2a4193c0a
https://github.com/neighbourhoodie/poky/assets/13760198/6e0fe09d-50e5-4b0b-b70b-6943f71b5208



Very nice! Thanks for the work and the v2 improvements.


I applied the patches by saving them from email and there was a minor 
whitespace warning which
is really nothing to worry about but if you want to avoid such noise, 
you could send yourself
patches by email and then apply them in a different branch if you want 
to check for such problems.



❯ git am /tmp/ninette-v2/*
Applying: oe-build-perf-report: Add apache echarts to make report 
interactive
Applying: oe-build-perf-report: Display more than 300 commits and date 
instead of commit number

Applying: oe-build-perf-report: Improve report styling and add descriptions
.git/rebase-apply/patch:240: trailing whitespace.
    start_time = time
warning: 1 line adds whitespace errors.
Applying: oe-build-perf-report: Update chart tooltip and chart type
Applying: oe-build-perf-report: Add dark mode

poky.git on ninette-v2 [$?]
❯ ls /tmp/ninette-v2/*
'/tmp/ninette-v2/[OE-core] [PATCH v2 1_5] oe-build-perf-report: Add 
apache echarts to make report interactive - "Ninette Adhikari via 
lists.openembedded.org" 
 - 2024-05-03 1043.eml'
'/tmp/ninette-v2/[PATCH v2 2_5] oe-build-perf-report: Display more than 
300 commits and date instead of commit number - Ninette Adhikari 
 - 2024-05-03 1043.eml'
'/tmp/ninette-v2/[PATCH v2 3_5] oe-build-perf-report: Improve report 
styling and add descriptions - Ninette Adhikari 
 - 2024-05-03 1043.eml'
'/tmp/ninette-v2/[PATCH v2 4_5] oe-build-perf-report: Update chart 
tooltip and chart type - Ninette Adhikari  - 
2024-05-03 1043.eml'
'/tmp/ninette-v2/[PATCH v2 5_5] oe-build-perf-report: Add dark mode - 
Ninette Adhikari  - 2024-05-03 1043.eml'




For local setup, you can do the following:

1. Clone the yocto-buildstats (https://git.yoctoproject.org/yocto-buildstats/) 
and the poky repository (https://git.yoctoproject.org/poky/)

2. In the poky repository run the following to build the report HTML:
```bash
./scripts/oe-build-perf-report -r "LOCAL_PATH_TO_YOCTO_BUILDSTATS" --branch "master" --commit 
"663f1805742ff6fb6955719d0ab7846a425debcf" --branch2 "master" --html > test.html


These are the same setup step as last time I think and again, they 
aren't quite right but

the script tells you do do:

❯ git fetch origin 
refs/notes/buildstats/perf-debian11/master/qemux86:refs/notes/buildstats/perf-debian11/master/qemux86



and that works.



```
Note:
- Add your local path to the yocto-buildstats repo
- The above command builds the report in a file called `test.html`. You can 
access it in the root directory in poky.
- This exmaple report uses the commit 
`663f1805742ff6fb6955719d0ab7846a425debcf` 

Re: [OE-core] [PATCH 0/3] Improvements for performance test report view

2024-04-16 Thread Randy MacLeod via lists.openembedded.org

On 2024-04-15 10:41 a.m., Ninette Adhikari via lists.openembedded.org wrote:

This work is done according to "Milestone 9: Build performance test report 
view" as stated in the Scope of Work with Sovereign Tech Fund (STF) 
(https://www.sovereigntechfund.de/).
The current report can be accessed here:
Performance test report HTML 
(https://autobuilder.yocto.io/pub/non-release/20240117-15/testresults/buildperf-alma8/perf-alma8_master_20240117090048_663f180574.html)
The report is created using the `oe-build-perf-report` script in the poky 
repository. This script generates a performance test report in HTML format 
using the data from the yocto-buildstats 
(https://git.yoctoproject.org/yocto-buildstats/) repository.
The report displays the performance test results in line chart format. The 
chart x-axis represents the commit numbers, and the y-axis represents the test 
duration in minutes.
The report also includes a table that displays the measurement statistics data 
for each test. The report is interactive and allows users to zoom in on 
specific sections of the line chart.

The current report format required some updates to make it more interactive and 
user-friendly. And this patch addresses such improvements:

- Add Apache echart (https://echarts.apache.org/en/index.html) library to 
create oe build performance report charts and make them interactive.
- Restructure data to time and value array format to be used by echarts. It 
also converts test duration to minutes and adds zoom to the line charts.
- Update measurement statistics data to include `start_time` so that time can 
be displayed instead of commit numbers on the chart. It also updates default 
commit history length to 300.
- Add styling updates including page margin, labels for x and y axis, tooltip, 
and section descriptions.

Updated report screenshots:
https://github.com/neighbourhoodie/poky/assets/13760198/65a1890c-fd2a-40d4-ac90-f13055735e53
https://github.com/neighbourhoodie/poky/assets/13760198/1ed43876-73a9-487e-aed3-ca0edf97514c


Thanks for the nice, dynamic UI web graphs!
Overall, I find them useful and well-designed.


Would it be possible to present the data in a more discrete manner since
the interpolated view presented now, while nice to look at, does not always
reflect the underlying data trend?

For example, if I have this data plotted as 1) stair-steps or 2) line 
segments (I didn't take the time to do a spline fit),


I find that the line style for 1) is usually less misleading about what 
we really know about the data.



1) stair-step



2) straight lines:



and I'd like to see this data:


plotted in the stair-step style.

From:

http://autobuilder.yocto.io/pub/non-release/20240413-19/testresults/buildperf-debian11/perf-debian11_master-next_20240413064005_7116cd908d.html


For local setup, you can do the following:

1. Clone the yocto-buildstats (https://git.yoctoproject.org/yocto-buildstats/) 
and the poky repository (https://git.yoctoproject.org/poky/)

2. In the poky repository run the following to build the report HTML:
```bash
./scripts/oe-build-perf-report -r "LOCAL_PATH_TO_YOCTO_BUILDSTATS" --branch "master" --commit 
"663f1805742ff6fb6955719d0ab7846a425debcf" --branch2 "master" --html > test.html
```
Note:
- Add your local path to the yocto-buildstats repo
- The above command builds the report in a file called `test.html`. You can 
access it in the root directory in poky.
- This exmaple report uses the commit 
`663f1805742ff6fb6955719d0ab7846a425debcf` from `master` branch.


I tried that out:

❯ cd .../distro/yocto/yocto-bs-html

❯ ../poky.git/scripts/oe-build-perf-report -r 
"/media/rmacleod/gitter/rmacleod/src/distro/yocto/yocto-bs-html/../yocto-buildstats.git" 
--branch "master" --commit "663f1805742ff6fb6955719d0ab7846a425debcf" 
--branch2 "master" --html > test.html
ERROR: No buildstats found, please try running 'git fetch origin 
refs/notes/buildstats/perf-alma8/master/qemux86:refs/notes/buildstats/perf-alma8/master/qemux86' 
to fetch them from the remote


so I did that.  It was > 3 GB of data...  !!

Receiving objects:  89% (10568/11747), 2.03 GiB | 3.28 MiB/s6 MiB/s

❯ du -sh .
3.2G    .

Also, one shouldn't have to call bash just to run your script since you 
shell
does that already if you have the right #!/path/to/foo and you have made 
the script executable:


❯ file ../poky.git/scripts/oe-build-perf-report
../poky.git/scripts/oe-build-perf-report: Python script, ASCII text 
executable


❯ head -1 ../poky.git/scripts/oe-build-perf-report
#!/usr/bin/env python3


Anyway, that did generate a test.html file in ~ 10 seconds for me on my 
Pop!OS (Ubuntu-based) distro

and it rendered nicely in Firefox 124.0.1 (64-bit) so that's nice to see.


Thanks again,

../Randy






Ninette Adhikari (3):
   oe-build-perf-report: Add apache echarts to make report interactive
   oe-build-perf-report: Display more than 300 commits and date instead
 of commit number
   oe-build-perf-report: Improve report styling and 

Re: [OE-core] [PATCH 3/5] ninja: build modified version with GNU Make jobserver support

2024-04-08 Thread Randy MacLeod via lists.openembedded.org

On 2024-04-03 3:08 p.m., Martin Hundebøll wrote:

On Wed, 2024-04-03 at 17:58 +0200, Alexander Kanavin wrote:

We can't carry this mass of patches. It has to land upstream first.

Understandable.


Are you able/willing to drive the upstream pull request to
completion?

No, I don't think so. I'm not familiar with the ninja codebase, and the
pull requests has been lingering for too long.

Another option might be to propose adding the fifo feature to the
kitware fork of ninja:
https://github.com/Kitware/ninja

They have forked ninja to get the jobserver feature in, but haven't
taken the fifo part so far.

The kitware fork is also used by buildroot:
https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/ninja/ninja.mk

// Martin


I see that v2 has switched to kitware, which is fine in the short run.

I'm just back from vacation. I plan to test this patchset out.

I can spend some time convincing upstream ninja that a solution is 
needed for our use-case and
that perhaps the jobsever approach and the kitware fork is a good 
starting point.


Of course, I can't promise to "drive it to completion" but I'll hound 
the upstream devs for months or even years!


Thanks for re-submitting the patchset Martin!


--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#198018): 
https://lists.openembedded.org/g/openembedded-core/message/198018
Mute This Topic: https://lists.openembedded.org/mt/105304230/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] gstreamer: upgrade 1.22.10 -> 1.22.11

2024-03-28 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

Changelog:
   https://gstreamer.freedesktop.org/releases/1.22/#1.22.11

Change the Upstream-Status URL for patch:
   0002-ssaparse-enhance-SSA-text-lines-parsing.patch
since the bug tracker moved but the bug is not yet resolved.

Signed-off-by: Randy MacLeod 
---
 .../{gst-devtools_1.22.10.bb => gst-devtools_1.22.11.bb}| 2 +-
 ...reamer1.0-libav_1.22.10.bb => gstreamer1.0-libav_1.22.11.bb} | 2 +-
 ...{gstreamer1.0-omx_1.22.10.bb => gstreamer1.0-omx_1.22.11.bb} | 2 +-
 ...ugins-bad_1.22.10.bb => gstreamer1.0-plugins-bad_1.22.11.bb} | 2 +-
 .../0002-ssaparse-enhance-SSA-text-lines-parsing.patch  | 2 +-
 ...ins-base_1.22.10.bb => gstreamer1.0-plugins-base_1.22.11.bb} | 2 +-
 ...ins-good_1.22.10.bb => gstreamer1.0-plugins-good_1.22.11.bb} | 2 +-
 ...ins-ugly_1.22.10.bb => gstreamer1.0-plugins-ugly_1.22.11.bb} | 2 +-
 ...amer1.0-python_1.22.10.bb => gstreamer1.0-python_1.22.11.bb} | 2 +-
 ...sp-server_1.22.10.bb => gstreamer1.0-rtsp-server_1.22.11.bb} | 2 +-
 ...reamer1.0-vaapi_1.22.10.bb => gstreamer1.0-vaapi_1.22.11.bb} | 2 +-
 .../{gstreamer1.0_1.22.10.bb => gstreamer1.0_1.22.11.bb}| 2 +-
 12 files changed, 12 insertions(+), 12 deletions(-)
 rename meta/recipes-multimedia/gstreamer/{gst-devtools_1.22.10.bb => 
gst-devtools_1.22.11.bb} (95%)
 rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-libav_1.22.10.bb => 
gstreamer1.0-libav_1.22.11.bb} (91%)
 rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-omx_1.22.10.bb => 
gstreamer1.0-omx_1.22.11.bb} (95%)
 rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-plugins-bad_1.22.10.bb 
=> gstreamer1.0-plugins-bad_1.22.11.bb} (98%)
 rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-plugins-base_1.22.10.bb 
=> gstreamer1.0-plugins-base_1.22.11.bb} (98%)
 rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-plugins-good_1.22.10.bb 
=> gstreamer1.0-plugins-good_1.22.11.bb} (97%)
 rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-plugins-ugly_1.22.10.bb 
=> gstreamer1.0-plugins-ugly_1.22.11.bb} (94%)
 rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-python_1.22.10.bb => 
gstreamer1.0-python_1.22.11.bb} (91%)
 rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-rtsp-server_1.22.10.bb 
=> gstreamer1.0-rtsp-server_1.22.11.bb} (90%)
 rename meta/recipes-multimedia/gstreamer/{gstreamer1.0-vaapi_1.22.10.bb => 
gstreamer1.0-vaapi_1.22.11.bb} (95%)
 rename meta/recipes-multimedia/gstreamer/{gstreamer1.0_1.22.10.bb => 
gstreamer1.0_1.22.11.bb} (97%)

diff --git a/meta/recipes-multimedia/gstreamer/gst-devtools_1.22.10.bb 
b/meta/recipes-multimedia/gstreamer/gst-devtools_1.22.11.bb
similarity index 95%
rename from meta/recipes-multimedia/gstreamer/gst-devtools_1.22.10.bb
rename to meta/recipes-multimedia/gstreamer/gst-devtools_1.22.11.bb
index 363d12612f..2be406192f 100644
--- a/meta/recipes-multimedia/gstreamer/gst-devtools_1.22.10.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-devtools_1.22.11.bb
@@ -12,7 +12,7 @@ SRC_URI = 
"https://gstreamer.freedesktop.org/src/gst-devtools/gst-devtools-${PV}
file://0001-connect-has-a-different-signature-on-musl.patch \
"
 
-SRC_URI[sha256sum] = 
"0e1ec0d0b8f2d3d314a397399cd01dfc50c02ac088176996f934758119075ea9"
+SRC_URI[sha256sum] = 
"07766425ecb5bf857ab5ad3962321c55cd89f9386b720843f9df71c0a455eb9b"
 
 DEPENDS = "json-glib glib-2.0 glib-2.0-native gstreamer1.0 
gstreamer1.0-plugins-base"
 RRECOMMENDS:${PN} = "git"
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.22.10.bb 
b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.22.11.bb
similarity index 91%
rename from meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.22.10.bb
rename to meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.22.11.bb
index 818dbf4e5e..f3287efa96 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.22.10.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.22.11.bb
@@ -12,7 +12,7 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=69333daa044cb77e486cc36129f7a770 \
 "
 
 SRC_URI = 
"https://gstreamer.freedesktop.org/src/gst-libav/gst-libav-${PV}.tar.xz;
-SRC_URI[sha256sum] = 
"d6dda7aa38a44173278de675ccd92acff0abf473f7bc02e7d1cdd4ce0f3b7642"
+SRC_URI[sha256sum] = 
"6b13dcc9332ef27a7c1e7005c0196883874f91622f8aa6e52f218b05b15d2bf5"
 
 S = "${WORKDIR}/gst-libav-${PV}"
 
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.10.bb 
b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.11.bb
similarity index 95%
rename from meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.10.bb
rename to meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.11.bb
index 4cb83937dc..97348fb398 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.10.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.11.bb
@@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=4fbd65380cdd255951079008b364516c \
 
 SRC_URI = 

Re: [OE-core][kirkstone][PATCH] openssl: Improve FIPS RSA keygen performac

2024-03-26 Thread Randy MacLeod via lists.openembedded.org

On 2024-03-19 7:23 p.m., Steve Sakoman wrote:

On Tue, Mar 19, 2024 at 11:45 AM Randy MacLeod
  wrote:

Hi Haitao, et al,


Summary:

I think we could bring these two commits back to kirkstone even though upstream 
openssl mtc
does not plan to do so, at least not without "very good reasons".

but I have some comments and questions below that I'd like you to respond to 
before sending a v2.

../Randy



Typo in the subject:
[OE-core][kirkstone][PATCH] openssl: Improve FIPS RSA keygen performac
should be:
[OE-core][kirkstone][PATCH] openssl: Improve FIPS RSA keygen performance

On 2024-03-18 2:55 a.m., jason.lau via lists.openembedded.org wrote:

The ssh-keygen would take a long time to generate the entropy of a key

It's best to be more specific.

You mentioned in:

https://github.com/openssl/openssl/issues/23766

that "ssh-keygen (built with openssl3.0) is taking 1-2s to execute whereas in 
openssl3.1 it was hardly half a second"

so you should mention that in the commit log.

You should also include a link to the upstream issue you opened to explain that:

"Performance fixes are in general not eligible for backports to stable 
release branches.
 In specific cases an exception could be given by OTC but there would have to be 
very good reasons for such an exception."

I saw that comment last week and wondered if we should push harder for upstream 
to backport these commits but
I understand your reluctance to do that when it might make sense to just 
backport here in oe-core.

Note that the commits are only part of 3.2.0+:

❯ git tag --contains dd1d7bcb69994d81662e709b0ad838880b943870
openssl-3.2.0
openssl-3.2.0-alpha1
openssl-3.2.0-alpha2
openssl-3.2.0-beta1
openssl-3.2.1

❯ git tag --contains d2f6e66d2837bff1f5f7636bb2118e3a45c9df61
openssl-3.2.0
openssl-3.2.0-alpha1
openssl-3.2.0-alpha2
openssl-3.2.0-beta1
openssl-3.2.1

so they'd also have to be back-ported to nanbield technically:

https://git.openembedded.org/openembedded-core/tree/meta/recipes-connectivity/openssl/openssl_3.1.4.bb?h=nanbield

Steve,
Given that nanbield is a week or so away from EOL, is it worth doing that?

I'm going to close down changes to nanbield in the next day or so, so
there probably isn't time to get such a change in.

And I suspect that the kirkstone v2 patch won't make it through


Haitao,

Steve has NOT merged this to kirkstone:
https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/kirkstone-nut

https://git.openembedded.org/openembedded-core/log/?h=kirkstone


Please reply to and/or deal with my comments and send a v2.

Thanks!

../Randy



testing until after the nanbield final release is done, so I don't
have an issue with taking it.

Steve


Note that the original commits were from Nov 2, 2022 so they've had some time 
to ummm, bake but
the 3.2.0 release was 'only' on Nov 23, 2023:
https://www.openssl.org/source/old/3.2/index.html
so it's got 3 or 4 months of the public being able to test it.

I've taken a look at the commits and haven't seen a problem with the backport.

Haitao,
Did you have to adjust the patches at all? If so please explain what you did.

Your tests show that openssl is faster, have you tested for correctness at all?
Does it make sense to run: test/bntest.c ? Steve will likely run the ptests of 
course.

Do we need the oneline change: "Fix incorrect error branch in 
ossl_bn_rsa_fips186_4_derive_prime()"
from:
openssl.git on master
❯ git log --oneline crypto/bn/bn_rsa_fips186_4.c
da1c088f59 Copyright year updates
835b90a19c Fix incorrect error branch in ossl_bn_rsa_fips186_4_derive_prime()
d2f6e66d28 Improve FIPS RSA keygen performance.
dd1d7bcb69 Improve FIPS RSA keygen performance.


Are there any other changes to the files touched by these commits that would 
affect
the correctness or performance of the code introduced?

../Randy



The following commits have fixed the issue.
https://github.com/openssl/openssl/commit/dd1d7bcb69994d81662e709b0ad838880b943870
https://github.com/openssl/openssl/commit/d2f6e66d2837bff1f5f7636bb2118e3a45c9df61

Signed-off-by: Haitao Liu
---
  ...-Improve-FIPS-RSA-keygen-performance.patch | 271 ++
  ...-Improve-FIPS-RSA-keygen-performance.patch | 185 
  .../openssl/openssl_3.0.13.bb |   2 +
  3 files changed, 458 insertions(+)
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/0001-Improve-FIPS-RSA-keygen-performance.patch
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/0002-Improve-FIPS-RSA-keygen-performance.patch

diff --git 
a/meta/recipes-connectivity/openssl/openssl/0001-Improve-FIPS-RSA-keygen-performance.patch
 
b/meta/recipes-connectivity/openssl/openssl/0001-Improve-FIPS-RSA-keygen-performance.patch
new file mode 100644
index 00..aed0e1a5c1
--- /dev/null
+++ 
b/meta/recipes-connectivity/openssl/openssl/0001-Improve-FIPS-RSA-keygen-performance.patch
@@ -0,0 +1,271 @@
+From a940dfa152707ba82f3efc2c147f6313c28f7662 Mon Sep 17 00:00:00 2001

Re: [OE-core][kirkstone][PATCH] openssl: Improve FIPS RSA keygen performac

2024-03-19 Thread Randy MacLeod via lists.openembedded.org

Hi Haitao, et al,


Summary:

I think we could bring these two commits back to kirkstone even though 
upstream openssl mtc

does not plan to do so, at least not without "very good reasons".

but I have some comments and questions below that I'd like you to 
respond to before sending a v2.


../Randy



Typo in the subject:
   [OE-core][kirkstone][PATCH] openssl: Improve FIPS RSA keygen performac
should be:
   [OE-core][kirkstone][PATCH] openssl: Improve FIPS RSA keygen performance

On 2024-03-18 2:55 a.m., jason.lau via lists.openembedded.org wrote:

The ssh-keygen would take a long time to generate the entropy of a key


It's best to be more specific.

You mentioned in:

https://github.com/openssl/openssl/issues/23766

that "ssh-keygen (built with openssl3.0) is taking 1-2s to execute 
whereas in openssl3.1 it was hardly half a second"


so you should mention that in the commit log.

You should also include a link to the upstream issue you opened to 
explain that:


   "Performance fixes are in general not eligible for backports to 
stable release branches.
    In specific cases an exception could be given by OTC but there 
would have to be very good reasons for such an exception."


I saw that comment last week and wondered if we should push harder for 
upstream to backport these commits but
I understand your reluctance to do that when it might make sense to just 
backport here in oe-core.


Note that the commits are only part of 3.2.0+:

❯ git tag --contains dd1d7bcb69994d81662e709b0ad838880b943870
openssl-3.2.0
openssl-3.2.0-alpha1
openssl-3.2.0-alpha2
openssl-3.2.0-beta1
openssl-3.2.1

❯ git tag --contains d2f6e66d2837bff1f5f7636bb2118e3a45c9df61
openssl-3.2.0
openssl-3.2.0-alpha1
openssl-3.2.0-alpha2
openssl-3.2.0-beta1
openssl-3.2.1

so they'd also have to be back-ported to nanbield technically:
https://git.openembedded.org/openembedded-core/tree/meta/recipes-connectivity/openssl/openssl_3.1.4.bb?h=nanbield

Steve,
Given that nanbield is a week or so away from EOL, is it worth doing that?

Note that the original commits were from Nov 2, 2022 so they've had some 
time to ummm, bake but

the 3.2.0 release was 'only' on Nov 23, 2023:
https://www.openssl.org/source/old/3.2/index.html
so it's got 3 or 4 months of the public being able to test it.

I've taken a look at the commits and haven't seen a problem with the 
backport.


Haitao,
Did you have to adjust the patches at all? If so please explain what you 
did.


Your tests show that openssl is faster, have you tested for correctness 
at all?
Does it make sense to run: test/bntest.c ? Steve will likely run the 
ptests of course.


Do we need the oneline change: "Fix incorrect error branch in 
ossl_bn_rsa_fips186_4_derive_prime()"

from:
openssl.git on master
❯ git log --oneline crypto/bn/bn_rsa_fips186_4.c
da1c088f59 Copyright year updates
835b90a19c Fix incorrect error branch in 
ossl_bn_rsa_fips186_4_derive_prime()

d2f6e66d28 Improve FIPS RSA keygen performance.
dd1d7bcb69 Improve FIPS RSA keygen performance.


Are there any other changes to the files touched by these commits that 
would affect

the correctness or performance of the code introduced?

../Randy




The following commits have fixed the issue.
https://github.com/openssl/openssl/commit/dd1d7bcb69994d81662e709b0ad838880b943870
https://github.com/openssl/openssl/commit/d2f6e66d2837bff1f5f7636bb2118e3a45c9df61

Signed-off-by: Haitao Liu
---
  ...-Improve-FIPS-RSA-keygen-performance.patch | 271 ++
  ...-Improve-FIPS-RSA-keygen-performance.patch | 185 
  .../openssl/openssl_3.0.13.bb |   2 +
  3 files changed, 458 insertions(+)
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/0001-Improve-FIPS-RSA-keygen-performance.patch
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/0002-Improve-FIPS-RSA-keygen-performance.patch

diff --git 
a/meta/recipes-connectivity/openssl/openssl/0001-Improve-FIPS-RSA-keygen-performance.patch
 
b/meta/recipes-connectivity/openssl/openssl/0001-Improve-FIPS-RSA-keygen-performance.patch
new file mode 100644
index 00..aed0e1a5c1
--- /dev/null
+++ 
b/meta/recipes-connectivity/openssl/openssl/0001-Improve-FIPS-RSA-keygen-performance.patch
@@ -0,0 +1,271 @@
+From a940dfa152707ba82f3efc2c147f6313c28f7662 Mon Sep 17 00:00:00 2001
+From: slontis
+Date: Wed, 2 Nov 2022 12:01:34 +1000
+Subject: [PATCH 1/2] Improve FIPS RSA keygen performance.
+
+FIPS 186-4 has 5 different algorithms for key generation,
+and all of them rely on testing GCD(a,n) == 1 many times.
+
+Cachegrind was showing that during a RSA keygen operation,
+the function BN_gcd() was taking a considerable percentage
+of the total cycles.
+
+The default provider uses multiprime keygen, which seemed to
+be much faster. This is because it uses BN_mod_inverse()
+instead.
+
+For a 4096 bit key, the entropy of a key that was taking a
+long time to generate was recorded and fed back into subsequent
+runs. Roughly 40% of the cycle time was 

Re: [OE-core] [RFC PATCH V2 0/5] Fix persistent tmp

2024-03-12 Thread Randy MacLeod via lists.openembedded.org

Add Trevor who made the original commit:

commit d5d40479d706cbb382850b9479c5dd9bfb801c99
Author: Trevor Woerner 
Date:   Mon Feb 27 00:00:40 2023

    VOLATILE_TMP_DIR: add

    Provide a mechanism to allow users to choose whether the /tmp directory
    is on persistent storage (non-volatile) or a RAM-based tmpfs 
(volatile).

    The default is volatile.

    Works for both sysvinit-based and systemd-based systems.


and Ross who said he'd take a look at this RFC.


On 2024-02-03 9:58 p.m., Changqing Li via lists.openembedded.org wrote:

ping

On 12/11/23 08:58, Changqing Li wrote:

From: Changqing Li 

Hi, All

Currently, VOLATILE_TMP_DIR not works,
set VOLATILE_TMP_DIR="no", VOLATILE_LOG_DIR="no", after boot target,
/var/tmp still link to tmpfs /var/volatile/tmp

lrwxrwxrwx  1 root root   11 Mar  9  2018 lock -> ../run/lock
drwxr-xr-x  4 root root 1024 Dec  4 07:55 log
lrwxrwxrwx  1 root root    6 Mar  9  2018 run -> ../run
drwxr-xr-x  3 root root 1024 Mar  9  2018 spool
lrwxrwxrwx  1 root root   12 Mar  9  2018 tmp -> volatile/tmp
drwxrwxrwt  4 root root   80 Dec  4 07:55 volatile

So I do some research, fix this issue and do some other changes 
accordingly. Please

help to review this patch, thanks.

Targets:
1. Support persistent tmp,  For persistent tmp, only /var/tmp is 
persistent, /tmp is tmpfs,
    For volatile tmp, /tmp link to /var/tmp, /var/tmp link to 
/var/volatile/tmp

2. make systemd and SysVinit have the same directory structure.

Currently, systemd and SysVinit have different directory structure, 
the difference focus on how to handle /tmp.


when volatile is enabled, for sysVinit, /tmp link to /var/tmp, 
/var/tmp link to /var/volatile/tmp
refer [4][5]. but for systemd, /tmp is a directory, it is mounted by 
systemd as tmpfs. /var/tmp
linked to /var/volatile/tmp.  And for systemd, refer [6], set 
different age for /tmp and /var/tmp.


I find that structured text helps me understand things, so here's a 
structured version of the sentences above:



Currently, systemd and SysVinit have different directory structure; the 
difference focus on how to handle /tmp.


When volatile is enabled, for sysVinit:
      /tmp link to /var/tmp,
  /var/tmp link to /var/volatile/tmp
   refer [4][5]

but for systemd:
   /tmp is a directory, it is mounted by systemd as tmpfs.
  /var/tmp linked to /var/volatile/tmp

and for systemd, refer [6], set different age for /tmp and /var/tmp.






Since volatile disabled not works, ignore the difference when 
volatile is disabled.


With this patch, VOLATILE_TMP_DIR will behavior like this:
For both sysvinit and systemd:
1. VOLATILE_TMP_DIR="yes":
/tmp link to /var/tmp,  /var/tmp link to /var/volatile/log, 
/var/volatile is mounted as tmpfs
In this case, for systemd, /tmp and /var/tmp will set to the same 
age, 10d.


Compare to current behavior, there are 2 changes:
    1) for systemd,  /tmp changed from a directy to a symlink to 
/var/tmp

    2) age of /tmp and /var/tmp will be same



Okay but is an identical timestamp absolutely required or are you just 
trying to make things consistent


to reduce the chance that a different timestamp could cause problems?

I may have missed an explanation of why you want the 10d old timestamp 
anyway, that seems like

a separate change that should follow-up the re-org changes.




2. VOLATILE_TMP_DIR="no":
/tmp is a directory mounted as tmpfs, /var/tmp is a directory on 
persistent fs, and keep the age as [6]


Change like this in order to meet [1][2], also maybe [3] for systemd.

Compare to current behavior, there is one change:
    1) for sysVinit, /tmp changed from a symlink to a directory


You've carefully explained things but it does seem a bit complicated 
when you first read
the explaination. It may have been better to start your explaination 
with the last statement you

made, by saying something like this:

   This is going to be a detailed, lengthy explaination but the only 
change in runtime will be
   for sysVinit where /tmp is changed from a symlink to a directory to 
make it persistent.



Ross, Trevor,
Any comments or concerns ?

Changqing is no one replies today, please just rebase and repost your 
full RFC patch

to try to restart the discussion.


Thanks,

../Randy



[1] https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch03s18.html
[2] https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s15.html
[3] https://systemd.io/TEMPORARY_DIRECTORIES/
[4] 
https://git.openembedded.org/openembedded/tree/docs/usermanual/chapters/recipes.xml#n3535
[5] 
https://git.openembedded.org/openembedded-core/commit/?id=12c4acd7ac5a27cf3676065b60f1c8395c96854c

[6] https://github.com/systemd/systemd/blob/main/tmpfiles.d/tmp.conf
[7] 
https://www.freedesktop.org/software/systemd/man/latest/tmpfiles.d.html



Test Result of following cases:
1.
SysVinit
VOLATILE_TMP_DIR="yes"
VOLATILE_LOG_DIR="yes"

root@qemux86-64:~# ls -al /tmp
lrwxrwxrwx    1 root root 8 Dec  8 08:51 /tmp -> 
/var/tmp


[OE-core] [PATCH] valgrind: skip intermittently failing ptests

2024-03-06 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

Skip a few additional ptests that fail occasionally on the Yocto
autobuilder and remove those added to the remove-for-all list
if they were already in the remove-for-aarch64 list.

=== Test Summary ===
TOTAL: 774
PASSED: 755
FAILED: 0
SKIPPED: 19

Signed-off-by: Randy MacLeod 
---
 meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64 | 2 --
 meta/recipes-devtools/valgrind/valgrind/remove-for-all | 4 
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64 
b/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64
index 04f159d701..5bfba1c8d3 100644
--- a/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64
+++ b/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64
@@ -1,5 +1,4 @@
 drd/tests/annotate_sem
-drd/tests/boost_thread
 gdbserver_tests/hgtls
 helgrind/tests/hg05_race2
 helgrind/tests/tc20_verifywrap
@@ -15,7 +14,6 @@ memcheck/tests/atomic_incs
 memcheck/tests/bug464969_d_demangle
 memcheck/tests/cxx17_aligned_new
 memcheck/tests/demangle
-memcheck/tests/linux/timerfd-syscall
 memcheck/tests/long_namespace_xml
 memcheck/tests/mismatches
 memcheck/tests/mismatches_xml
diff --git a/meta/recipes-devtools/valgrind/valgrind/remove-for-all 
b/meta/recipes-devtools/valgrind/valgrind/remove-for-all
index 004589a7ea..8435a6d41d 100644
--- a/meta/recipes-devtools/valgrind/valgrind/remove-for-all
+++ b/meta/recipes-devtools/valgrind/valgrind/remove-for-all
@@ -1,8 +1,12 @@
 cachegrind/tests/wrap5
+drd/tests/boost_thread
 none/tests/amd64/fb_test_amd64
+none/tests/tls
 gdbserver_tests/hginfo
+gdbserver_tests/mcinvokeRU
 memcheck/tests/linux/dlclose_leak-no-keep
 memcheck/tests/linux/dlclose_leak
+memcheck/tests/linux/timerfd-syscall
 memcheck/tests/supp_unknown
 memcheck/tests/wrap1
 memcheck/tests/wrap2
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196760): 
https://lists.openembedded.org/g/openembedded-core/message/196760
Mute This Topic: https://lists.openembedded.org/mt/104780048/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] libc-locale: fix ASCII compatible warning cause build failure.

2024-02-26 Thread Randy MacLeod via lists.openembedded.org

On 2024-02-26 4:59 a.m., Xiangyu Chen via lists.openembedded.org wrote:

From: Xiangyu Chen

Some locales are not listed in glibc locales support list, but can be generated,
here using ja_JP.SHIFT_JIS as an example. We can add following line into 
local.conf
to enable and generate it:

GLIBC_GENERATE_LOCALES += "en_GB.UTF-8 en_US.UTF-8 ja_JP.UTF-8 ja_JP.SHIFT_JIS"
IMAGE_LINGUAS += "ja-jp en-us ja-jp.shift-jis"

The localedef tool would report a warning and exit with 1, that cause build 
failure,
error message as below:

[warning] character map `SHIFT_JIS' is not ASCII compatible, locale not ISO C 
compliant [--no-warnings=ascii]

So add a --no-warnings=ascii in libc-package.bbclass to fix build failure if 
someone needs those locale
in yocto.


For context, Xiangyu is changing the libc-package.bbclass so that we can 
generate a ja_JP.SJIS  / ja_JP.SHIFT_JIS locale

to make another of the bash ptests pass.

I don't know if that locale is commonly used these days but apparently 
it's not POSIX complaint:


https://discourse.nixos.org/t/building-unsupported-locales-ja-jp-sjis/3612


Richard, Mark, Sundeep, Jonathan, Khem,

Any idea if this is a change that we should be merging to master
rather than skipping the bash ptest?

Xiangyu,

Did you test musl? ( I don't know if musl even supports locales, 
off-hand! ;-)  )


../Randy




Signed-off-by: Xiangyu Chen
---
  meta/classes-recipe/libc-package.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/libc-package.bbclass 
b/meta/classes-recipe/libc-package.bbclass
index bf160b115d..c06a2ce90a 100644
--- a/meta/classes-recipe/libc-package.bbclass
+++ b/meta/classes-recipe/libc-package.bbclass
@@ -278,7 +278,7 @@ python package_do_split_gconvs () {
  bb.fatal("unknown arch:" + target_arch + " for 
locale_arch_options")
  
  localedef_opts += " --force --no-hard-links --no-archive --prefix=%s \

---inputfile=%s/%s/i18n/locales/%s --charmap=%s %s/%s" \
+--inputfile=%s/%s/i18n/locales/%s --charmap=%s %s/%s 
--no-warnings=ascii" \
  % (treedir, treedir, datadir, locale, encoding, outputpath, 
name)
  
  cmd = "PATH=\"%s\" I18NPATH=\"%s\" GCONV_PATH=\"%s\" cross-localedef %s" % \






--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196236): 
https://lists.openembedded.org/g/openembedded-core/message/196236
Mute This Topic: https://lists.openembedded.org/mt/104579284/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] sanity.bbclass: raise_sanity_error if /tmp is noexec

2024-02-21 Thread Randy MacLeod via lists.openembedded.org

On 2024-02-21 5:08 a.m., Alexander Kanavin via lists.openembedded.org wrote:

On Wed, 21 Feb 2024 at 10:48, Ross Burton  wrote:

You _can_ export TMPDIR but that has to be done on a per-recipe/class basis 
very carefully as TMPDIR means something else to Bitbake.

The problem is recipes that use mktemp to write files and execute them (be it 
shell scripts, or as a place to write C and then compile in the same 
directory).  These will be in /tmp (again, we can’t set TMPDIR because for 
foolish historical reasons, TMPDIR is used by bitbake).

We first noticed this with Meson where noexec /tmp meant the configure tests 
failed. We worked around it at the time by assigning TMPDIR when calling Meson, 
but since them Meson writes to its own build tree now.  This has been seen 
before though, but luckily noexec /tmp is fairly unusual so I doubt this will 
break many builds.

I'm actually curious where noexec /tmp can be observed. It does seem
rare, because I think it's the first time someone came up with a
sanity check for it. Perhaps it should be treated as a bug in that
respective environment/OS/container?



We've been using noexec /tmp since 2019 with few if any problems

using:

meta-anaconda
meta-aws
meta-browser
meta-clang
meta-cloud-services
meta-dpdk
meta-imx
meta-intel
meta-intel-qat
meta-iot-cloud
meta-lat
meta-mingw
meta-openembedded
meta-qt6
meta-raspberrypi
meta-realtime
meta-secure-core
meta-security
meta-selinux
meta-tensorflow
meta-virtualization
meta-xilinx
meta-xilinx-tools
meta-yocto


Michal, what problem are you seeing?

../Randy




Alex





--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#195998): 
https://lists.openembedded.org/g/openembedded-core/message/195998
Mute This Topic: https://lists.openembedded.org/mt/104258828/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] valgrind: Skip 22 arm64 ptests

2024-02-15 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

With the 3.22 upgrade 21 additional tests fail on qemuarm64.
Skip them until the problems are resolved. Tracked by:
   https://bugzilla.yoctoproject.org/show_bug.cgi?id=15399

Signed-off-by: Randy MacLeod 
---
 .../valgrind/valgrind/remove-for-aarch64  | 27 ---
 1 file changed, 24 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64 
b/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64
index 4477f39132..04f159d701 100644
--- a/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64
+++ b/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64
@@ -1,7 +1,9 @@
+drd/tests/annotate_sem
 drd/tests/boost_thread
 gdbserver_tests/hgtls
+helgrind/tests/hg05_race2
+helgrind/tests/tc20_verifywrap
 memcheck/tests/dw4
-memcheck/tests/leak_cpp_interior
 memcheck/tests/varinfo1
 memcheck/tests/varinfo2
 memcheck/tests/varinfo3
@@ -9,5 +11,24 @@ memcheck/tests/varinfo4
 memcheck/tests/varinfo5
 memcheck/tests/varinfo6
 memcheck/tests/varinforestrict
-helgrind/tests/hg05_race2
-helgrind/tests/tc20_verifywrap
+memcheck/tests/atomic_incs
+memcheck/tests/bug464969_d_demangle
+memcheck/tests/cxx17_aligned_new
+memcheck/tests/demangle
+memcheck/tests/linux/timerfd-syscall
+memcheck/tests/long_namespace_xml
+memcheck/tests/mismatches
+memcheck/tests/mismatches_xml
+memcheck/tests/new_aligned_delete_default
+memcheck/tests/new_delete_mismatch_size
+memcheck/tests/new_nothrow
+memcheck/tests/realloc_size_zero_mismatch
+memcheck/tests/sized_aligned_new_delete_args
+memcheck/tests/sized_aligned_new_delete_misaligned1
+memcheck/tests/sized_aligned_new_delete_misaligned1_xml
+memcheck/tests/sized_aligned_new_delete_misaligned2
+memcheck/tests/sized_aligned_new_delete_misaligned2_xml
+memcheck/tests/sized_aligned_new_delete_misaligned3
+memcheck/tests/sized_aligned_new_delete_misaligned3_xml
+memcheck/tests/sized_delete
+none/tests/bigcode
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#195542): 
https://lists.openembedded.org/g/openembedded-core/message/195542
Mute This Topic: https://lists.openembedded.org/mt/104375747/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2 1/5] rust: Fetch cargo from rust-snapshot dir.

2024-01-20 Thread Randy MacLeod via lists.openembedded.org

On 2024-01-19 10:09 a.m., yash.shi...@windriver.com wrote:

From: Yash Shinde

Fixes: Exception: no cargo executable found at
`${B}/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`

Fix the cargo binary path error on oe-selftest and path set to rust-snapshot 
dir.

Patch sent to upstream-https://github.com/rust-lang/rust/pull/120125



Good!

It's a bit worrying that the PR pipeline failed a number of tests.
Do you want to revise that and push a new commit there and do a v3 here?

../Randy



Signed-off-by: Yash Shinde
---
  .../rust/files/cargo-path.patch   | 37 +++
  1 file changed, 37 insertions(+)
  create mode 100644 meta/recipes-devtools/rust/files/cargo-path.patch

diff --git a/meta/recipes-devtools/rust/files/cargo-path.patch 
b/meta/recipes-devtools/rust/files/cargo-path.patch
new file mode 100644
index 00..547df353d2
--- /dev/null
+++ b/meta/recipes-devtools/rust/files/cargo-path.patch
@@ -0,0 +1,37 @@
+Fix the cargo binary path error and ensure that it is fetched
+during rustc bootstrap in rust oe-selftest.
+
+==
+ERROR: test_cargoflags (bootstrap_test.BuildBootstrap)
+--
+Traceback (most recent call last):
+  File 
"/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap_test.py",
 line 157, in test_cargoflags
+args, _ = self.build_args(env={"CARGOFLAGS": "--timings"})
+  File 
"/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap_test.py",
 line 154, in build_args
+return build.build_bootstrap_cmd(env), env
+  File 
"/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/src/bootstrap/bootstrap.py",
 line 960, in build_bootstrap_cmd
+raise Exception("no cargo executable found at `{}`".format(
+Exception: no cargo executable found at 
`/home/build-st/tmp/work/cortexa57-poky-linux/rust/1.74.1/rustc-1.74.1-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo`
+
+Upstream-Status: Submitted [https://github.com/rust-lang/rust/pull/120125]
+
+Signed-off-by: Yash Shinde
+---
+diff --git a/src/bootstrap/bootstrap.py b/src/bootstrap/bootstrap.py
+--- a/src/bootstrap/bootstrap.py
 b/src/bootstrap/bootstrap.py
+@@ -954,9 +954,11 @@
+ if deny_warnings:
+ env["RUSTFLAGS"] += " -Dwarnings"
+
+-env["PATH"] = os.path.join(self.bin_root(), "bin") + \
+-os.pathsep + env["PATH"]
+-if not os.path.isfile(self.cargo()):
++cargo_bin_path = os.path.join(self.bin_root(), "bin", "cargo")
++if not os.path.isfile(cargo_bin_path):
++cargo_bin_path = os.getenv("RUST_TARGET_PATH") + 
"rust-snapshot/bin/cargo"
++env["PATH"] = os.path.dirname(cargo_bin_path) + os.pathsep + 
env["PATH"]
++else:
+ raise Exception("no cargo executable found at `{}`".format(
+ self.cargo()))
+ args = [self.cargo(), "build", "--manifest-path",



--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194085): 
https://lists.openembedded.org/g/openembedded-core/message/194085
Mute This Topic: https://lists.openembedded.org/mt/103831444/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2 5/5] rust: Enable rust oe-selftest.

2024-01-20 Thread Randy MacLeod via lists.openembedded.org
I like that you have broken the original patch down into 5 patches that 
are easier to

understand.

On 2024-01-19 10:09 a.m., yash.shi...@windriver.com wrote:

From: Yash Shinde

Tests which are failing from below modules are added to exclude list
tests/run-make
tests/rustdoc
tests/mir-opt
tests/ui-fulldeps

* Redundent test cases whose parent dir is also present in  exclud list are 
removed.

* Newly addded tests are sorted and updated.

* Overall exclude tests count in exclude list is now reduced to 114.

We need to resolve the mips32 problems that Richard pointed out.

Should we skip all the rust tests for mips32?


Please submit a v3 with the mips fix/avoidance and split this exclude 
list commit down into 3 steps:


 1. Sort the existing list of tests
 2. Remove the test cases whose parent dir is also present in the 
exclude list


 3. Add the new tests that are to be excluded.

This may seem really pedantic but otherwise the changes are really hard 
to review.


The way I think about this is that someone looking at the commit log 
might be interested
in exactly which tests are in being added to the exclude list so that 
should be clear from 3.

1. won't really be of interest so most people will skip over that
2. also won't be of interest to most people
but you need 1 and 2 to make 3 be apparent to people who want that info 
quickly.


Thanks,

../Randy



* The testing is done on arm32, arm64, mips64, x86 and  x86_64 targets.

Signed-off-by: Yash Shinde
---
  meta/lib/oeqa/selftest/cases/rust.py   | 165 +
  meta/recipes-devtools/rust/rust-source.inc |   4 +
  2 files changed, 43 insertions(+), 126 deletions(-)

diff --git a/meta/lib/oeqa/selftest/cases/rust.py 
b/meta/lib/oeqa/selftest/cases/rust.py
index 6dbc517006..7d0efb1b01 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -40,7 +40,7 @@ def parse_results(filename):
  class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
  def test_rust(self, *args, **kwargs):
  # Disable Rust Oe-selftest
-self.skipTest("The Rust Oe-selftest is disabled.")
+#self.skipTest("The Rust Oe-selftest is disabled.")
  
  # build remote-test-server before image build
  recipe = "rust" @@ -73,156 +73,90 @@ class 
RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase): 
'src/librustdoc', 'src/rustdoc-json-types', 
'src/tools/compiletest/src/common.rs', + 'src/tools/jsondoclint', 
'src/tools/lint-docs', + 'src/tools/replace-version-placeholder', 
'src/tools/rust-analyzer', 'src/tools/rustdoc-themes', 
'src/tools/tidy', 'tests/assembly/asm/aarch64-outline-atomics.rs', + 
'tests/codegen/abi-efiapi.rs', + 'tests/codegen/abi-efiapi.rs', 
'tests/codegen/abi-main-signature-32bit-c-int.rs', 
'tests/codegen/abi-repr-ext.rs', + 'tests/codegen/abi-sysv64.rs', 
'tests/codegen/abi-x86-interrupt.rs', + 
'tests/codegen/align-byval.rs', + 'tests/codegen/align-fn.rs', + 
'tests/codegen/asm-powerpc-clobbers.rs', + 
'tests/codegen/async-fn-debug-awaitee-field.rs', + 
'tests/codegen/binary-search-index-no-bound-check.rs', 
'tests/codegen/branch-protection.rs', + 
'tests/codegen/call-metadata.rs', 'tests/codegen/catch-unwind.rs', 
'tests/codegen/cf-protection.rs', + 'tests/codegen/debug-column.rs', + 
'tests/codegen/debug-limited.rs', + 
'tests/codegen/debuginfo-generic-closure-env-names.rs', + 
'tests/codegen/drop.rs', + 
'tests/codegen/dst-vtable-align-nonzero.rs', + 
'tests/codegen/enable-lto-unit-splitting.rs', 
'tests/codegen/enum-bounds-check-derived-idx.rs', + 
'tests/codegen/enum/enum-u128.rs', + 
'tests/codegen/fn-impl-trait-self.rs', 
'tests/codegen/force-unwind-tables.rs', + 
'tests/codegen/inherit_overflow.rs', + 
'tests/codegen/inherit_overflow.rs', + 
'tests/codegen/inline-function-args-debug-info.rs', 
'tests/codegen/intrinsic-no-unnamed-attr.rs', + 
'tests/codegen/intrinsics/mask.rs', + 
'tests/codegen/intrinsics/transmute-niched.rs', 
'tests/codegen/issues/issue-103840.rs', 
'tests/codegen/issues/issue-47278.rs', + 
'tests/codegen/issues/issue-73258.rs', 
'tests/codegen/issues/issue-73827-bounds-check-index-in-subexpr.rs', + 
'tests/codegen/issues/issue-75546.rs', + 
'tests/codegen/issues/issue-77812.rs', + 
'tests/codegen/issues/issue-98156-const-arg-temp-lifetime.rs', 
'tests/codegen/lifetime_start_end.rs', + 
'tests/codegen/llvm-ident.rs', 
'tests/codegen/local-generics-in-exe-internalized.rs', + 
'tests/codegen/mainsubprogram.rs', 
'tests/codegen/match-unoptimized.rs', + 
'tests/codegen/move-operands.rs', 
'tests/codegen/noalias-rwlockreadguard.rs', 
'tests/codegen/non-terminate/nonempty-infinite-loop.rs', 
'tests/codegen/noreturn-uninhabited.rs', 
'tests/codegen/repr-transparent-aggregates-3.rs', + 
'tests/codegen/repr/transparent-mips64.rs', 
'tests/codegen/sse42-implies-crc32.rs', 
'tests/codegen/thread-local.rs', 'tests/codegen/uninit-consts.rs', + 
'tests/mir-opt/', 

Re: [OE-core] [kirkstone][PATCHv2] openssl: fix CVE-2023-6237 Excessive time spent checking invalid RSA public keys

2024-01-18 Thread Randy MacLeod via lists.openembedded.org

On 2024-01-17 11:09 a.m., Steve Sakoman via lists.openembedded.org wrote:

On Wed, Jan 17, 2024 at 1:47 AM Hitendra Prajapati via
lists.openembedded.org
wrote:

Upstream-Status: Backport 
fromhttps://github.com/openssl/openssl/commit/e09fc1d746a4fd15bb5c3d7bbbab950aadd005db

Signed-off-by: Hitendra Prajapati
---
  .../openssl/openssl/CVE-2023-6237.patch   | 127 ++
  .../openssl/openssl_3.0.12.bb |   3 +-
  2 files changed, 129 insertions(+), 1 deletion(-)
  create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2023-6237.patch

diff --git a/meta/recipes-connectivity/openssl/openssl/CVE-2023-6237.patch 
b/meta/recipes-connectivity/openssl/openssl/CVE-2023-6237.patch
new file mode 100644
index 00..621dc6b0ab
--- /dev/null
+++ b/meta/recipes-connectivity/openssl/openssl/CVE-2023-6237.patch
@@ -0,0 +1,127 @@
+rom e09fc1d746a4fd15bb5c3d7bbbab950aadd005db Mon Sep 17 00:00:00 2001
+From: Tomas Mraz
+Date: Fri, 22 Dec 2023 16:25:56 +0100
+Subject: [PATCH] Limit the execution time of RSA public key check
+
+Fixes CVE-2023-6237
+
+If a large and incorrect RSA public key is checked with
+EVP_PKEY_public_check() the computation could take very long time
+due to no limit being applied to the RSA public key size and
+unnecessarily high number of Miller-Rabin algorithm rounds
+used for non-primality check of the modulus.
+
+Now the keys larger than 16384 bits (OPENSSL_RSA_MAX_MODULUS_BITS)
+will fail the check with RSA_R_MODULUS_TOO_LARGE error reason.
+Also the number of Miller-Rabin rounds was set to 5.
+
+Reviewed-by: Neil Horman
+Reviewed-by: Matt Caswell
+(Merged fromhttps://github.com/openssl/openssl/pull/23243)
+
+Upstream-Status: Backport 
[https://github.com/openssl/openssl/commit/e09fc1d746a4fd15bb5c3d7bbbab950aadd005db]
+CVE: CVE-2023-6237
+Signed-off-by: Hitendra Prajapati
+---
+ crypto/rsa/rsa_sp800_56b_check.c  |  8 +++-
+ test/recipes/91-test_pkey_check.t |  2 +-
+ .../91-test_pkey_check_data/rsapub_17k.pem| 48 +++
+ 3 files changed, 56 insertions(+), 2 deletions(-)
+ create mode 100644 test/recipes/91-test_pkey_check_data/rsapub_17k.pem
+
+diff --git a/crypto/rsa/rsa_sp800_56b_check.c 
b/crypto/rsa/rsa_sp800_56b_check.c
+index fc8f19b..bcbdd24 100644
+--- a/crypto/rsa/rsa_sp800_56b_check.c
 b/crypto/rsa/rsa_sp800_56b_check.c
+@@ -289,6 +289,11 @@ int ossl_rsa_sp800_56b_check_public(const RSA *rsa)
+ return 0;
+
+ nbits = BN_num_bits(rsa->n);
++if (nbits > OPENSSL_RSA_MAX_MODULUS_BITS) {
++ERR_raise(ERR_LIB_RSA, RSA_R_MODULUS_TOO_LARGE);
++return 0;
++}
++
+ #ifdef FIPS_MODULE
+ /*
+  * (Step a): modulus must be 2048 or 3072 (caveat from SP800-56Br1)
+@@ -324,7 +329,8 @@ int ossl_rsa_sp800_56b_check_public(const RSA *rsa)
+ goto err;
+ }
+
+-ret = ossl_bn_miller_rabin_is_prime(rsa->n, 0, ctx, NULL, 1, );
++/* Highest number of MR rounds from FIPS 186-5 Section B.3 Table B.1 */
++ret = ossl_bn_miller_rabin_is_prime(rsa->n, 5, ctx, NULL, 1, );
+ #ifdef FIPS_MODULE
+ if (ret != 1 || status != BN_PRIMETEST_COMPOSITE_NOT_POWER_OF_PRIME) {
+ #else
+diff --git a/test/recipes/91-test_pkey_check.t 
b/test/recipes/91-test_pkey_check.t
+index dc7cc64..f8088df 100644
+--- a/test/recipes/91-test_pkey_check.t
 b/test/recipes/91-test_pkey_check.t
+@@ -70,7 +70,7 @@ push(@positive_tests, (
+ "dhpkey.pem"
+ )) unless disabled("dh");
+
+-my @negative_pubtests = ();
++my @negative_pubtests = ("rsapub_17k.pem");  # Too big RSA public key
+
+ push(@negative_pubtests, (
+ "dsapub_noparam.der"
+diff --git a/test/recipes/91-test_pkey_check_data/rsapub_17k.pem 
b/test/recipes/91-test_pkey_check_data/rsapub_17k.pem
+new file mode 100644
+index 000..9a2eaed
+--- /dev/null
 b/test/recipes/91-test_pkey_check_data/rsapub_17k.pem
+@@ -0,0 +1,48 @@
++-BEGIN PUBLIC KEY-
++MIIIbzANBgkqhkiG9w0BAQEFAAOCCFwAMIIIVwKCCE4Ang+cE5H+hg3RbapDAHqR
++B9lUnp2MlAwsZxQ/FhYepaR60bFQeumbu7817Eo5YLMObVI99hF1C4u/qcpD4Jph
++gZt87/JAYDbP+DIh/5gUXCL9m5Fp4u7mvZaZdnlcftBvR1uKUTCAwc9pZ/Cfr8W2
++GzrRODzsNYnk2DcZMfe2vRDuDZRopE+Y+I72rom2SZLxoN547N1daM/M/CL9KVQ/
++XMI/YOpJrBI0jI3brMRhLkvLckwies9joufydlGbJkeil9H7/grj3fQZtFkZ2Pkj
++b87XDzRVX7wsEpAgPJxskL3jApokCp1kQYKG+Uc3dKM9Ade6IAPK7VKcmbAQTYw2
++gZxsc28dtstazmfGz0ACCTSMrmbgWAM3oPL7RRzhrXDWgmYQ0jHefGh8SNTIgtPq
++TuHxPYkDMQNaf0LmDGCxqlnf4b5ld3YaU8zZ/RqIRx5v/+w0rJUvU53qY1bYSnL1
++vbqKSnN2mip0GYyQ4AUgkS1NBV4rGYU/VTvzEjLfkg02KOtHKandvEoUjmZPzCT0
++V2ZhGc8K1UJNGYlIiHqCdwCBoghvly/pYajTkDXyd6BsukzA5H3IkZB1xDgl035j
++/0Cr7QeZLEOdi9fPdSSaBT6OmD0WFuZfJF0wMr7ucRhWzPXvSensD9v7MBE7tNfH
++SLeTSx8tLt8UeWriiM+0CnkPR1IOqMOxubOyf1eV8NQqEWm5wEQG/0IskbOKnaHa
++PqLFJZn/bvyL3XK5OxVIJG3z6bnRDOMS9SzkjqgPdIO8tkySEHVSi/6iuGUltx3Y
++Fmq6ye/r34ekyHPbfn6UuTON7joM6SIXb5bHM64x4iMVWx4hMvDjfy0UqfywAUyu
++C1o7BExSMxxFG8GJcqR0K8akpPp7EM588PC+YuItoxzXgfUJnP3BQ1Beev2Ve7/J
++xeGZH0N4ntfr+cuaLAakAER9zDglwChWflw3NNFgIdAgSxXv3XXx5xDXpdP4lxUo

Patchtest results for [OE-core][kirkstone][PATCH 1/1] tiff: fix CVE-2023-6228

2024-01-18 Thread Randy MacLeod via lists.openembedded.org

Yogita,

Pleae tell people if you will send a v2 or if you plan to fix the 
warning in a follow-up commit.


I don't see your commit in Steve's kirkstone-nut repo so I think he's 
expecting a v2.


https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/kirkstone-nut

../Randy

 Forwarded Message 
Subject: 	Patchtest results for [OE-core][kirkstone][PATCH 1/1] tiff: 
fix CVE-2023-6228

Date:   Thu, 18 Jan 2024 11:03:04 +
From: 	Patchtest via lists.openembedded.org 


Reply-To:   patcht...@automation.yoctoproject.org
To: yurade 
CC: openembedded-core@lists.openembedded.org



Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch 
/home/patchtest/share/mboxes/kirkstone-1-1-tiff-fix-CVE-2023-6228.patch


FAIL: test CVE check ignore: CVE_CHECK_IGNORE is deprecated and should 
be replaced by CVE_STATUS (test_metadata.TestMetadata.test_cve_check_ignore)


PASS: pretest src uri left files 
(test_metadata.TestMetadata.pretest_src_uri_left_files)

PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence 
(test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Signed-off-by presence 
(test_patch.TestPatch.test_signed_off_by_presence)
PASS: test Upstream-Status presence 
(test_patch.TestPatch.test_upstream_status_presence_format)

PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence 
(test_mbox.TestMbox.test_commit_message_presence)
PASS: test lic files chksum modified not mentioned 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)

PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files 
(test_metadata.TestMetadata.test_src_uri_left_files)


SKIP: pretest pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.pretest_pylint)
SKIP: test bugzilla entry format: No bug ID found 
(test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other 
mailing lists (test_mbox.TestMbox.test_target_mailing_list)


---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193975): 
https://lists.openembedded.org/g/openembedded-core/message/193975
Mute This Topic: https://lists.openembedded.org/mt/103805851/3616765
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[randy.macl...@windriver.com]
-=-=-=-=-=-=-=-=-=-=-=-



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193999): 
https://lists.openembedded.org/g/openembedded-core/message/193999
Mute This Topic: https://lists.openembedded.org/mt/103805851/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] rust: Enable rust oe-selftest

2024-01-18 Thread Randy MacLeod via lists.openembedded.org

On 2024-01-18 5:57 a.m., yash.shi...@windriver.com wrote:

From: Yash Shinde

Enable rust oe-selftest for rust 1.74.1 version and
add target_cfg.patch to handle target configurations
for custom targets.


Hi Yashe,

Yay, getting the rust test suite working again great news!

We talked about this in today's YP bug review and decided NOT to merge this
until after the M2 build is taken care of over the next few days.

That gives me a chance to review the commit and ask some questions! ;-)

First, your commit log should be expanded to explain what has changed at 
a high level

to someone who is just reading "git log".

What you have is a good start but I'd like more info on what changed in:
meta/lib/oeqa/selftest/cases/rust.py

There are lots of tests added to the exclude list and some seem to have 
just moved.


Please explain why you did this and if there is any way to avoid the 
"noise" of moved tests in future updates. Could you also report on the 
number of newly disabled tests and try to summarize in the commit log 
what these tests are doing and


Ah, I see what you have done: 1. sort the exclude list 2. add the newly 
excluded tests. Please do that in separate commits so that it's easier 
to understand. This will reduce the size of the "Enable rust 
oe-selftest" diff for meta/lib/oeqa/selftest/cases/rust.py from: | 103 
- to: | 37 +++-


and let people easily see that most of the newly excluded tests are in 
tests/codegen .


That reminds me, do we really need to list directories in that exclude 
list or only list .rs files?


If I save the list to /tmp/jj, you can see that we could reduce the list 
by 34 lines:


❯ rg "\.rs" /tmp/jj | wc -l 203 ❯ rg -v "\.rs" /tmp/jj | wc -l 34

If we can do that, again do it as a separate commit since it should not 
affect the outcome of the test.



Also this backport link:
https://github.com/rust-lang/rust/pull/119619/commits
is actually 3 separate commits so it might be better to apply those 
individually

so that we can know when they can be dropped by running:
$ git tag --contains  on each commit

Also in the patches, please add you Signed-Off-By line but keep the 
upstream author's S-O-B line.




For anyone interested we did talk about the number of Rust tests that we 
are excluding and of course our goal is to work with the upstream Rust 
community to reduce the number of excluded tests over the coming months 
but for now, it's just nice to see the test working again!


If you update these things convince yourself that the changes are 
functionally identical, I don't think there's any need to re-do all the 
testing that you have done.


Thanks Yash,

../Randy



The testing is done on arm32, arm64, mips64, x86 and  x86_64 targets.

Signed-off-by: Yash Shinde
---
  meta/lib/oeqa/selftest/cases/rust.py  | 103 -
  .../rust/files/target_cfg.patch   | 144 ++
  meta/recipes-devtools/rust/rust-source.inc|   1 +
  3 files changed, 214 insertions(+), 34 deletions(-)
  create mode 100644 meta/recipes-devtools/rust/files/target_cfg.patch

diff --git a/meta/lib/oeqa/selftest/cases/rust.py 
b/meta/lib/oeqa/selftest/cases/rust.py
index 6dbc517006..216c73e5d1 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -40,7 +40,7 @@ def parse_results(filename):
  class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
  def test_rust(self, *args, **kwargs):
  # Disable Rust Oe-selftest
-self.skipTest("The Rust Oe-selftest is disabled.")
+#self.skipTest("The Rust Oe-selftest is disabled.")
  
  # build remote-test-server before image build

  recipe = "rust"
@@ -73,38 +73,71 @@ class RustSelfTestSystemEmulated(OESelftestTestCase, 
OEPTestResultTestCase):
  'src/librustdoc',
  'src/rustdoc-json-types',
  'src/tools/compiletest/src/common.rs',
+'src/tools/jsondoclint',
  'src/tools/lint-docs',
+'src/tools/replace-version-placeholder',
  'src/tools/rust-analyzer',
  'src/tools/rustdoc-themes',
  'src/tools/tidy',
  'tests/assembly/asm/aarch64-outline-atomics.rs',
+'tests/codegen/abi-efiapi.rs',
+'tests/codegen/abi-efiapi.rs',
  'tests/codegen/abi-main-signature-32bit-c-int.rs',
  'tests/codegen/abi-repr-ext.rs',
+'tests/codegen/abi-sysv64.rs',
  'tests/codegen/abi-x86-interrupt.rs',
+'tests/codegen/align-byval.rs',
+'tests/codegen/align-fn.rs',
+'tests/codegen/asm-powerpc-clobbers.rs',
+  

Re: [OE-core] [PATCH] rng-tools: Revert "rng-tools: move to meta-oe"

2024-01-18 Thread Randy MacLeod via lists.openembedded.org

Sorry for the noise and back and forth on rng-tools removal.
I'll avoid hastily cleaning up things for a while! ;-)


On 2024-01-18 11:59 a.m., Randy MacLeod via lists.openembedded.org wrote:

From: Randy MacLeod

This reverts commit d2b445384da3f3e6dab8577b6c56648b5244a788.

Revert this commit since:

  - some systems using oe-core master may still be using kernels from
before 5.6 pulled in the rng-tools algorithm, and

  - some hardware platforms may not have a hardware random number generator
and could therefore need to run rngd to avoid long boot-time initialization
due to a depleted entropy pool.



The additional context that doesn't belong in the commit log
is that we talked about this change in the YP bug review meeting
and decided that we would keep rng-tools in oe-core for 5.0-M2
for the two reasons given above. If we end up adding a test, as 
described below,

we may never move the recipe to meta-oe.


It seems to me that we need a test that checks if the entropy pool size
ever falls below a critical threshold for "too long" in the first N 
seconds of boot time.


Getting that test written so that:
 - qemu VMs and
 - real HW with and without /dev/hwrng

all pass without the test being too permissive may take some time.

I've created a bug to track adding such a test:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15360


Scott,
Do you have any info on the need for rngd on HW without /dev/hwrng but 
with a kernel >= 5.6 ?


../Randy




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193996): 
https://lists.openembedded.org/g/openembedded-core/message/193996
Mute This Topic: https://lists.openembedded.org/mt/103812401/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] rng-tools: Revert "rng-tools: move to meta-oe"

2024-01-18 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

This reverts commit d2b445384da3f3e6dab8577b6c56648b5244a788.

Revert this commit since:

 - some systems using oe-core master may still be using kernels from
   before 5.6 pulled in the rng-tools algorithm, and

 - some hardware platforms may not have a hardware random number generator
   and could therefore need to run rngd to avoid long boot-time initialization
   due to a depleted entropy pool.

Signed-off-by: Randy MacLeod 
---
 meta/conf/distro/include/maintainers.inc  |  1 +
 .../rng-tools/rng-tools/default   |  1 +
 meta/recipes-support/rng-tools/rng-tools/init | 42 +++
 .../rng-tools/rng-tools/rng-tools.service | 32 +
 .../rng-tools/rng-tools_6.16.bb   | 69 +++
 5 files changed, 145 insertions(+)
 create mode 100644 meta/recipes-support/rng-tools/rng-tools/default
 create mode 100644 meta/recipes-support/rng-tools/rng-tools/init
 create mode 100644 meta/recipes-support/rng-tools/rng-tools/rng-tools.service
 create mode 100644 meta/recipes-support/rng-tools/rng-tools_6.16.bb

diff --git a/meta/conf/distro/include/maintainers.inc 
b/meta/conf/distro/include/maintainers.inc
index 31023021ac..8dc63b138e 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -739,6 +739,7 @@ RECIPE_MAINTAINER:pn-repo = "Unassigned 
"
 RECIPE_MAINTAINER:pn-resolvconf = "Chen Qi "
 RECIPE_MAINTAINER:pn-rgb = "Unassigned "
 RECIPE_MAINTAINER:pn-rpcbind = "Hongxu Jia "
+RECIPE_MAINTAINER:pn-rng-tools = "Anuj Mittal "
 RECIPE_MAINTAINER:pn-rpcsvc-proto = "Khem Raj "
 RECIPE_MAINTAINER:pn-rpm = "Unassigned "
 RECIPE_MAINTAINER:pn-rsync = "Yi Zhao "
diff --git a/meta/recipes-support/rng-tools/rng-tools/default 
b/meta/recipes-support/rng-tools/rng-tools/default
new file mode 100644
index 00..b9f8e03635
--- /dev/null
+++ b/meta/recipes-support/rng-tools/rng-tools/default
@@ -0,0 +1 @@
+EXTRA_ARGS="-r /dev/hwrng"
diff --git a/meta/recipes-support/rng-tools/rng-tools/init 
b/meta/recipes-support/rng-tools/rng-tools/init
new file mode 100644
index 00..13f0ecd37c
--- /dev/null
+++ b/meta/recipes-support/rng-tools/rng-tools/init
@@ -0,0 +1,42 @@
+#!/bin/sh
+#
+# This is an init script for openembedded
+# Copy it to @SYSCONFDIR@/init.d/rng-tools and type
+# > update-rc.d rng-tools defaults 60
+#
+
+rngd=@SBINDIR@/rngd
+test -x "$rngd" || exit 1
+
+[ -r @SYSCONFDIR@/default/rng-tools ] && . "@SYSCONFDIR@/default/rng-tools"
+
+case "$1" in
+  start)
+echo -n "Starting random number generator daemon"
+start-stop-daemon -S -q -x $rngd -- $EXTRA_ARGS
+echo "."
+;;
+  stop)
+echo -n "Stopping random number generator daemon"
+start-stop-daemon -K -q -n rngd
+echo "."
+;;
+  reload|force-reload)
+echo -n "Signalling rng daemon restart"
+start-stop-daemon -K -q -s 1 -x $rngd
+start-stop-daemon -K -q -s 1 -x $rngd
+;;
+  restart)
+echo -n "Stopping random number generator daemon"
+start-stop-daemon -K -q -n rngd
+echo "."
+echo -n "Starting random number generator daemon"
+start-stop-daemon -S -q -x $rngd -- $EXTRA_ARGS
+echo "."
+;;
+  *)
+echo "Usage: @SYSCONFDIR@/init.d/rng-tools 
{start|stop|reload|restart|force-reload}"
+exit 1
+esac
+
+exit 0
diff --git a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service 
b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
new file mode 100644
index 00..5ae2fba215
--- /dev/null
+++ b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
@@ -0,0 +1,32 @@
+[Unit]
+Description=Hardware RNG Entropy Gatherer Daemon
+DefaultDependencies=no
+Conflicts=shutdown.target
+Before=sysinit.target shutdown.target
+ConditionVirtualization=!container
+
+[Service]
+EnvironmentFile=-@SYSCONFDIR@/default/rng-tools
+ExecStart=@SBINDIR@/rngd -f $EXTRA_ARGS
+CapabilityBoundingSet=CAP_SYS_ADMIN
+IPAddressDeny=any
+LockPersonality=yes
+MemoryDenyWriteExecute=yes
+NoNewPrivileges=yes
+PrivateTmp=yes
+ProtectControlGroups=yes
+ProtectHome=yes
+ProtectHostname=yes
+ProtectKernelModules=yes
+ProtectKernelLogs=yes
+ProtectSystem=strict
+RestrictAddressFamilies=AF_UNIX
+RestrictNamespaces=yes
+RestrictRealtime=yes
+RestrictSUIDSGID=yes
+SystemCallArchitectures=native
+SystemCallErrorNumber=EPERM
+SystemCallFilter=@system-service
+
+[Install]
+WantedBy=sysinit.target
diff --git a/meta/recipes-support/rng-tools/rng-tools_6.16.bb 
b/meta/recipes-support/rng-tools/rng-tools_6.16.bb
new file mode 100644
index 00..f0aa3ff93f
--- /dev/null
+++ b/meta/recipes-support/rng-tools/rng-tools_6.16.bb
@@ -0,0 +1,69 @@
+SUMMARY = "Random number generator daemon"
+DESCRIPTION = "Check and feed random data from hardware device to kernel"
+HOMEPAGE = "https://github.com/nhorman/rng-tools;
+BUGTRACKER = "https://github.com/nhorman/rng-tools/issues;
+LICENSE = "GPL-2.0-only"
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+DEPENDS = "openssl libcap"
+

Re: [OE-core] [PATCH] rng-tools: move to meta-oe

2024-01-15 Thread Randy MacLeod via lists.openembedded.org
On 2024-01-15 11:58 a.m., Alexandre Belloni via lists.openembedded.org 
wrote:

This is breaking meta-agl-core until this gets into meta-oe:

https://autobuilder.yoctoproject.org/typhoon/#/builders/120/builds/3849/steps/14/logs/stdio


Thanks Alexandre.


Stephane, Jan-Simon,

Is rng-tools actually still a requirement for meta-agl ?
It was added back in 2018 but the kernel algorithm improved as of 5.6:
https://lists.openembedded.org/g/openembedded-core/message/178518

../Randy

commit c55cb9e43a4ff26224cd917f91c057f15535ee3b
Author: Stephane Desneux 
Date:   Thu Sep 6 17:53:26 2018

    agl-profile-core/packagegroup-agl-core-boot: add rng-tools

    On some boards (typically Minnowboard Max), the kernel's random 
number entropy
    pool may fill too slowly.  As a consequence, if many processes ask 
for random
    data at the same time, the reads on /dev/random are blocked until 
the entropy

    pool has been filled.

    This patch adds rng-tools in the core images: the rngd daemon will 
start at boot

    and fill the entropy pool.

    Bug-AGL: SPEC-1655

    Change-Id: Icbcf6a9ea685774dd13e33597689a3fd05aaadf4
    Signed-off-by: Stephane Desneux 



On 10/01/2024 15:25:01-0500, Randy MacLeod via lists.openembedded.org wrote:

From: Randy MacLeod

Nothing in oe-core depends on rng-tools anymore:
e7e1bc43ca rng-tools: splitting the rng-tools systemd/sysvinit serivce as a 
package
so move it to meta-oe for people who still want to run rngd
as a service for some reason or for those who want to run rng-test.

Signed-off-by: Randy MacLeod
---
  meta/conf/distro/include/maintainers.inc  |  1 -
  .../rng-tools/rng-tools/default   |  1 -
  meta/recipes-support/rng-tools/rng-tools/init | 42 ---
  .../rng-tools/rng-tools/rng-tools.service | 32 -
  .../rng-tools/rng-tools_6.16.bb   | 69 ---
  5 files changed, 145 deletions(-)
  delete mode 100644 meta/recipes-support/rng-tools/rng-tools/default
  delete mode 100644 meta/recipes-support/rng-tools/rng-tools/init
  delete mode 100644 meta/recipes-support/rng-tools/rng-tools/rng-tools.service
  delete mode 100644 meta/recipes-support/rng-tools/rng-tools_6.16.bb

diff --git a/meta/conf/distro/include/maintainers.inc 
b/meta/conf/distro/include/maintainers.inc
index 8dc63b138e..31023021ac 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -739,7 +739,6 @@ RECIPE_MAINTAINER:pn-repo = 
"Unassigned"
  RECIPE_MAINTAINER:pn-resolvconf = "Chen Qi"
  RECIPE_MAINTAINER:pn-rgb = "Unassigned"
  RECIPE_MAINTAINER:pn-rpcbind = "Hongxu Jia"
-RECIPE_MAINTAINER:pn-rng-tools = "Anuj Mittal"
  RECIPE_MAINTAINER:pn-rpcsvc-proto = "Khem Raj"
  RECIPE_MAINTAINER:pn-rpm = "Unassigned"
  RECIPE_MAINTAINER:pn-rsync = "Yi Zhao"
diff --git a/meta/recipes-support/rng-tools/rng-tools/default 
b/meta/recipes-support/rng-tools/rng-tools/default
deleted file mode 100644
index b9f8e03635..00
--- a/meta/recipes-support/rng-tools/rng-tools/default
+++ /dev/null
@@ -1 +0,0 @@
-EXTRA_ARGS="-r /dev/hwrng"
diff --git a/meta/recipes-support/rng-tools/rng-tools/init 
b/meta/recipes-support/rng-tools/rng-tools/init
deleted file mode 100644
index 13f0ecd37c..00
--- a/meta/recipes-support/rng-tools/rng-tools/init
+++ /dev/null
@@ -1,42 +0,0 @@
-#!/bin/sh
-#
-# This is an init script for openembedded
-# Copy it to @SYSCONFDIR@/init.d/rng-tools and type
-# > update-rc.d rng-tools defaults 60
-#
-
-rngd=@SBINDIR@/rngd
-test -x "$rngd" || exit 1
-
-[ -r @SYSCONFDIR@/default/rng-tools ] && . "@SYSCONFDIR@/default/rng-tools"
-
-case "$1" in
-  start)
-echo -n "Starting random number generator daemon"
-start-stop-daemon -S -q -x $rngd -- $EXTRA_ARGS
-echo "."
-;;
-  stop)
-echo -n "Stopping random number generator daemon"
-start-stop-daemon -K -q -n rngd
-echo "."
-;;
-  reload|force-reload)
-echo -n "Signalling rng daemon restart"
-start-stop-daemon -K -q -s 1 -x $rngd
-start-stop-daemon -K -q -s 1 -x $rngd
-;;
-  restart)
-echo -n "Stopping random number generator daemon"
-start-stop-daemon -K -q -n rngd
-echo "."
-echo -n "Starting random number generator daemon"
-start-stop-daemon -S -q -x $rngd -- $EXTRA_ARGS
-echo "."
-;;
-  *)
-echo "Usage: @SYSCONFDIR@/init.d/rng-tools 
{start|stop|reload|restart|force-reload}"
-exit 1
-esac
-
-exit 0
diff --git a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service 
b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
deleted file mode 100644
index 5ae2fba215..00
--- a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
+++ /dev/null
@@ -1,32 +0,0 @@
-[Unit]
-Description=Hardware RNG Entropy G

Re: [OE-core] [kirkstone][PATCH] gdb [V2]: Fix CVE-2023-39130

2024-01-10 Thread Randy MacLeod via lists.openembedded.org

On 2024-01-09 6:17 a.m., sanjana.venkat...@windriver.com wrote:

From: Sanjana

Issue: LIN1022-4855

Signed-off-by: Sanjana
---
  meta/recipes-devtools/gdb/gdb.inc |   1 +
  .../gdb/gdb/0013-CVE-2023-39130.patch | 326 ++
  2 files changed, 327 insertions(+)
  create mode 100644 meta/recipes-devtools/gdb/gdb/0013-CVE-2023-39130.patch

diff --git a/meta/recipes-devtools/gdb/gdb.inc 
b/meta/recipes-devtools/gdb/gdb.inc
index 099bd2d8f5..62b813d5cb 100644
--- a/meta/recipes-devtools/gdb/gdb.inc
+++ b/meta/recipes-devtools/gdb/gdb.inc
@@ -15,5 +15,6 @@ SRC_URI = "${GNU_MIRROR}/gdb/gdb-${PV}.tar.xz \
 file://0009-Fix-invalid-sigprocmask-call.patch  \
 file://0010-gdbserver-ctrl-c-handling.patch  \
 file://0011-CVE-2023-39128.patch  \
+file://0013-CVE-2023-39130.patch  \
 "
  SRC_URI[sha256sum] = 
"1497c36a71881b8671a9a84a0ee40faab788ca30d7ba19d8463c3cc787152e32"
diff --git a/meta/recipes-devtools/gdb/gdb/0013-CVE-2023-39130.patch 
b/meta/recipes-devtools/gdb/gdb/0013-CVE-2023-39130.patch
new file mode 100644
index 00..c659f8a08c
--- /dev/null
+++ b/meta/recipes-devtools/gdb/gdb/0013-CVE-2023-39130.patch
@@ -0,0 +1,326 @@
+From 2db20b97f1dc3e5dce3d6ed74a8a62f0dede8c80 Mon Sep 17 00:00:00 2001
+From: Alan Modra
+Date: Wed, 9 Aug 2023 09:58:36 +0930
+Subject: [PATCH] gdb: warn unused result for bfd IO functions
+
+This fixes the compilation warnings introduced by my bfdio.c patch.
+
+The removed bfd_seeks in coff_symfile_read date back to 1994, commit
+7f4c859520, prior to which the file used stdio rather than bfd to read
+symbols.  Since it now uses bfd to read the file there should be no
+need to synchronise to bfd's idea of the file position.  I also fixed
+a potential uninitialised memory access.
+
+Approved-By: Andrew Burgess
+
+Upstream-Status: Backport from 
[https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=2db20b97f1dc3e5dce3d6ed74a8a62f0dede8c80]
+CVE: CVE-2023-39130
+Signed-off-by: Sanjana Venkatesh


Hi Sanjana,

I was looking in the gdb git repo to see if you had to adjust the commit 
at all
since it's a fairly large patch. It seems you didn't change anything 
which is good!


but...

I think you need this follow-up commit:

commit ec2479e820c32ef443382a622a1d555a71730f64
Author: Alan Modra 
Date:   Sat Aug 12 19:26:12 2023

    Re: gdb: warn unused result for bfd IO functions

    Add a missing return statement.

It would be nice to be able to test that these toolchain changes don't 
cause any regressions.


The code here is only "Used as a last resort if no debugging symbols 
recognized." so that's a bit of a challenge. What runtime testing, if 
any, did you do so far? Do you know or can you easily determine if any 
of the tests in gdb cover the code that changed here?


It looks like Steve already has your patch in his queue so unless he 
says otherwise, just send a commit to add the patch above.



../Randy


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193532): 
https://lists.openembedded.org/g/openembedded-core/message/193532
Mute This Topic: https://lists.openembedded.org/mt/103617733/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe-core][PATCH 1/1] eudev: modify predictable network if name search

2024-01-10 Thread Randy MacLeod via lists.openembedded.org

On 2024-01-10 4:12 p.m., joe.sla...@windriver.com wrote:

From: Joe Slater

Consider a name based on mac address in addition to
those based on slot or path.

Note that as of this commit predictable naming is
suppressed by eudev, but can be enabled by removing
/etc/udev/rules.d/80-net-name-slot.rules from the
root filesystem.


Thanks Joe.

For anyone wondering, this commit and:

   [oe-core][PATCH 1/1] init-ifupdown: add predictable interface names

are working on enabling predictable network interface names.

https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/


Is there anyone else in favour of or opposed to  making PNI be the 
default for Yocto

for both sysvinit and systemd images?

I think we'd need to modify runqemu and probably fix several other 
tests, right Joe?


../Randy





Signed-off-by: Joe Slater
---
  meta/recipes-core/udev/eudev/netifnames.patch | 17 +
  meta/recipes-core/udev/eudev_3.2.14.bb|  2 ++
  2 files changed, 19 insertions(+)
  create mode 100644 meta/recipes-core/udev/eudev/netifnames.patch

diff --git a/meta/recipes-core/udev/eudev/netifnames.patch 
b/meta/recipes-core/udev/eudev/netifnames.patch
new file mode 100644
index 00..a45b80118f
--- /dev/null
+++ b/meta/recipes-core/udev/eudev/netifnames.patch
@@ -0,0 +1,17 @@
+eudev: consider ID_NET_NAME_MAC as an interface name
+
+eudev might not create names based on slot or path.
+
+Upstream-Status: Pending
+
+Signed-off-by: Joe Slater
+
+--- a/rules/80-net-name-slot.rules
 b/rules/80-net-name-slot.rules
+@@ -10,5 +10,6 @@ ENV{net.ifnames}=="0", GOTO="net_name_sl
+ NAME=="", ENV{ID_NET_NAME_ONBOARD}!="", NAME="$env{ID_NET_NAME_ONBOARD}"
+ NAME=="", ENV{ID_NET_NAME_SLOT}!="", NAME="$env{ID_NET_NAME_SLOT}"
+ NAME=="", ENV{ID_NET_NAME_PATH}!="", NAME="$env{ID_NET_NAME_PATH}"
++NAME=="", ENV{ID_NET_NAME_MAC}!="", NAME="$env{ID_NET_NAME_MAC}"
+
+ LABEL="net_name_slot_end"
diff --git a/meta/recipes-core/udev/eudev_3.2.14.bb 
b/meta/recipes-core/udev/eudev_3.2.14.bb
index d0758691bd..ddb3c3340f 100644
--- a/meta/recipes-core/udev/eudev_3.2.14.bb
+++ b/meta/recipes-core/udev/eudev_3.2.14.bb
@@ -10,6 +10,7 @@ DEPENDS = "gperf-native"
  PROVIDES = "udev"
  
  SRC_URI = "${GITHUB_BASE_URI}/download/v${PV}/${BP}.tar.gz \

+file://netifnames.patch  \
 file://init  \
 file://local.rules  \
 "
@@ -50,6 +51,7 @@ do_install:append() {
  
  	# Use classic network interface naming scheme

touch ${D}${sysconfdir}/udev/rules.d/80-net-name-slot.rules
+
  }
  
  do_install:prepend:class-target () {



--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193531): 
https://lists.openembedded.org/g/openembedded-core/message/193531
Mute This Topic: https://lists.openembedded.org/mt/103650019/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] rng-tools: move to meta-oe

2024-01-10 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

Nothing in oe-core depends on rng-tools anymore:
   e7e1bc43ca rng-tools: splitting the rng-tools systemd/sysvinit serivce as a 
package
so move it to meta-oe for people who still want to run rngd
as a service for some reason or for those who want to run rng-test.

Signed-off-by: Randy MacLeod 
---
 meta/conf/distro/include/maintainers.inc  |  1 -
 .../rng-tools/rng-tools/default   |  1 -
 meta/recipes-support/rng-tools/rng-tools/init | 42 ---
 .../rng-tools/rng-tools/rng-tools.service | 32 -
 .../rng-tools/rng-tools_6.16.bb   | 69 ---
 5 files changed, 145 deletions(-)
 delete mode 100644 meta/recipes-support/rng-tools/rng-tools/default
 delete mode 100644 meta/recipes-support/rng-tools/rng-tools/init
 delete mode 100644 meta/recipes-support/rng-tools/rng-tools/rng-tools.service
 delete mode 100644 meta/recipes-support/rng-tools/rng-tools_6.16.bb

diff --git a/meta/conf/distro/include/maintainers.inc 
b/meta/conf/distro/include/maintainers.inc
index 8dc63b138e..31023021ac 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -739,7 +739,6 @@ RECIPE_MAINTAINER:pn-repo = "Unassigned 
"
 RECIPE_MAINTAINER:pn-resolvconf = "Chen Qi "
 RECIPE_MAINTAINER:pn-rgb = "Unassigned "
 RECIPE_MAINTAINER:pn-rpcbind = "Hongxu Jia "
-RECIPE_MAINTAINER:pn-rng-tools = "Anuj Mittal "
 RECIPE_MAINTAINER:pn-rpcsvc-proto = "Khem Raj "
 RECIPE_MAINTAINER:pn-rpm = "Unassigned "
 RECIPE_MAINTAINER:pn-rsync = "Yi Zhao "
diff --git a/meta/recipes-support/rng-tools/rng-tools/default 
b/meta/recipes-support/rng-tools/rng-tools/default
deleted file mode 100644
index b9f8e03635..00
--- a/meta/recipes-support/rng-tools/rng-tools/default
+++ /dev/null
@@ -1 +0,0 @@
-EXTRA_ARGS="-r /dev/hwrng"
diff --git a/meta/recipes-support/rng-tools/rng-tools/init 
b/meta/recipes-support/rng-tools/rng-tools/init
deleted file mode 100644
index 13f0ecd37c..00
--- a/meta/recipes-support/rng-tools/rng-tools/init
+++ /dev/null
@@ -1,42 +0,0 @@
-#!/bin/sh
-#
-# This is an init script for openembedded
-# Copy it to @SYSCONFDIR@/init.d/rng-tools and type
-# > update-rc.d rng-tools defaults 60
-#
-
-rngd=@SBINDIR@/rngd
-test -x "$rngd" || exit 1
-
-[ -r @SYSCONFDIR@/default/rng-tools ] && . "@SYSCONFDIR@/default/rng-tools"
-
-case "$1" in
-  start)
-echo -n "Starting random number generator daemon"
-start-stop-daemon -S -q -x $rngd -- $EXTRA_ARGS
-echo "."
-;;
-  stop)
-echo -n "Stopping random number generator daemon"
-start-stop-daemon -K -q -n rngd
-echo "."
-;;
-  reload|force-reload)
-echo -n "Signalling rng daemon restart"
-start-stop-daemon -K -q -s 1 -x $rngd
-start-stop-daemon -K -q -s 1 -x $rngd
-;;
-  restart)
-echo -n "Stopping random number generator daemon"
-start-stop-daemon -K -q -n rngd
-echo "."
-echo -n "Starting random number generator daemon"
-start-stop-daemon -S -q -x $rngd -- $EXTRA_ARGS
-echo "."
-;;
-  *)
-echo "Usage: @SYSCONFDIR@/init.d/rng-tools 
{start|stop|reload|restart|force-reload}"
-exit 1
-esac
-
-exit 0
diff --git a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service 
b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
deleted file mode 100644
index 5ae2fba215..00
--- a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service
+++ /dev/null
@@ -1,32 +0,0 @@
-[Unit]
-Description=Hardware RNG Entropy Gatherer Daemon
-DefaultDependencies=no
-Conflicts=shutdown.target
-Before=sysinit.target shutdown.target
-ConditionVirtualization=!container
-
-[Service]
-EnvironmentFile=-@SYSCONFDIR@/default/rng-tools
-ExecStart=@SBINDIR@/rngd -f $EXTRA_ARGS
-CapabilityBoundingSet=CAP_SYS_ADMIN
-IPAddressDeny=any
-LockPersonality=yes
-MemoryDenyWriteExecute=yes
-NoNewPrivileges=yes
-PrivateTmp=yes
-ProtectControlGroups=yes
-ProtectHome=yes
-ProtectHostname=yes
-ProtectKernelModules=yes
-ProtectKernelLogs=yes
-ProtectSystem=strict
-RestrictAddressFamilies=AF_UNIX
-RestrictNamespaces=yes
-RestrictRealtime=yes
-RestrictSUIDSGID=yes
-SystemCallArchitectures=native
-SystemCallErrorNumber=EPERM
-SystemCallFilter=@system-service
-
-[Install]
-WantedBy=sysinit.target
diff --git a/meta/recipes-support/rng-tools/rng-tools_6.16.bb 
b/meta/recipes-support/rng-tools/rng-tools_6.16.bb
deleted file mode 100644
index f0aa3ff93f..00
--- a/meta/recipes-support/rng-tools/rng-tools_6.16.bb
+++ /dev/null
@@ -1,69 +0,0 @@
-SUMMARY = "Random number generator daemon"
-DESCRIPTION = "Check and feed random data from hardware device to kernel"
-HOMEPAGE = "https://github.com/nhorman/rng-tools;
-BUGTRACKER = "https://github.com/nhorman/rng-tools/issues;
-LICENSE = "GPL-2.0-only"
-LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
-DEPENDS = "openssl libcap"
-
-SRC_URI = "git://github.com/nhorman/rng-tools.git;branch=master;protocol=https 
\
-   file://init \
-   

Re: [OE-core] [patch] packagegroups: Add perl modules to rdeps

2023-12-27 Thread Randy MacLeod via lists.openembedded.org

Also, your subject is to vague:
   [patch] packagegroups: Add perl modules to rdeps
it should be something like:
  [PATCH] nativesdk-packagegroup-sdk-host: Add perl modules to RDEPENDS


That's 62 characters so still under the limt, iirc.

It's better to be specific, since there are 27 packagegroup files in poky:
poky.git> fd packagegroup.*bb  | wc -l


--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192954): 
https://lists.openembedded.org/g/openembedded-core/message/192954
Mute This Topic: https://lists.openembedded.org/mt/103383878/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [patch] packagegroups: Add perl modules to rdeps

2023-12-27 Thread Randy MacLeod via lists.openembedded.org

On 2023-12-27 7:50 a.m., deepthi.hem...@windriver.com wrote:

From: Deepthi Hemraj

In SDK,running "x86_64-poky-linux-gp-display-html --help" fails due to missing 
perl modules which are required for it to work.

Fixes:Can't locate feature.pm in @INC (you may need to install the feature 
module) and also add all the perl modules to sdk.

Signed-off-by: Deepthi Hemraj
---
  .../packagegroups/nativesdk-packagegroup-sdk-host.bb  | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb 
b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
index 11e31dcba3..2561d79900 100644
--- a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
+++ b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
@@ -8,8 +8,6 @@ inherit packagegroup nativesdk
  
  PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"
  
-# autoconf pulls in nativesdk-perl but perl-module-integer is needed to

-# build some recent linux kernels (5.14+) for arm
  RDEPENDS:${PN} = "\
  nativesdk-pkgconfig \
  nativesdk-qemu \
@@ -28,7 +26,7 @@ RDEPENDS:${PN} = "\
  nativesdk-sdk-provides-dummy \
  nativesdk-bison \
  nativesdk-flex \
-nativesdk-perl-module-integer \
+nativesdk-perl-modules \
  "


perl-modules is a meta-package that pulls in *all* **726** (1) perl 
modules with each one

being ~100KB.

That's adding quite a bit of bloat for a feature that few people need ( 
gp-display-html --help 
https://manpages.debian.org/unstable/binutils-common/gp-display-html.1.en.html 
)


We just need perl-modue-feature to get features.pm.

tmp-glibc/work/core2-64-wrs-linux/perl/5.38.0/packages-split/perl-module-feature/usr/lib64/perl5/5.38.0/feature.pm

Can you try again to see if you can require fewer packages please?
If you can explain that you tried adding > 15 perl modules and you still 
don't have all the dependencies,

then we can talk about what to do.

Please confirm that you are able to use gp-display-html to view the 
results of a profiling run.


../Randy


1)

❯ ls tmp-glibc/work/core2-64-wrs-linux/perl/5.38.0/packages-split/ | rg 
module | wc -l

726


I
  
  RDEPENDS:${PN}:darwin = "\



--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192953): 
https://lists.openembedded.org/g/openembedded-core/message/192953
Mute This Topic: https://lists.openembedded.org/mt/103383878/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [meta-oe][PATCH v2] uninative-tarball.xz - reproducibility fix

2023-12-22 Thread Randy MacLeod via lists.openembedded.org

On 2023-06-30 9:14 a.m., Robert Berger via lists.openembedded.org wrote:

see:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15148

Signed-off-by: Robert Berger
---
  meta/classes-recipe/populate_sdk_base.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/populate_sdk_base.bbclass 
b/meta/classes-recipe/populate_sdk_base.bbclass
index b23ea26d40..24db703534 100644
--- a/meta/classes-recipe/populate_sdk_base.bbclass
+++ b/meta/classes-recipe/populate_sdk_base.bbclass
@@ -285,7 +285,7 @@ python check_sdk_sysroots() {
  dir_walk(SCAN_ROOT)
  }
  
-SDKTAROPTS = "--owner=root --group=root"

+SDKTAROPTS = "--owner=root --group=root --clamp-mtime 
--mtime=@${SOURCE_DATE_EPOCH}"
  
  fakeroot archive_sdk() {

# Package it up


Ping.

I think this patch was just missed back in late June.

../Randy








--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192878): 
https://lists.openembedded.org/g/openembedded-core/message/192878
Mute This Topic: https://lists.openembedded.org/mt/99872409/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] bitbake-server does not exit after build ends

2023-12-21 Thread Randy MacLeod via lists.openembedded.org

On 2023-12-21 1:56 p.m., Martin Jansa wrote:
On Thu, Dec 21, 2023 at 7:47 PM Randy MacLeod 
 wrote:


On 2023-11-28 4:26 a.m., Zoltan Boszormenyi via
lists.openembedded.org


wrote:

So it's not just Fedora, but Python 3.12 in general.

Googling for problem with threads + fork reveals that
it is indeed an issue even in C / POSIX: only the thread
executing fork() will become part of the new process,
but not the main process starting the thread or any
other threads from the original process.

The warning is justified, and apparently the issue
not occurring in bitbake with previous Python versions
is pure luck.


FYI: Fixed in Fedora 39 if you update to get python-3.12.1-1 or later.


But this fixes it only for bitbake master, right?

Even master might still have some problems.
I can do a simple build of a package but in doing:

$ bitbake -k world

I see:
NOTE: No reply from server in 30s (for command ping at 17:50:35.510798)

After some time.

I'm not going to try to debug it at this point in the day/year!



With bitbake 2.0 used in kirkstone I still see bitbake processes still 
running after the build is finished.


I didn't try kirkstone. Maybe Steve has that on his list of things to do 
in his spare time! ;-)


../Randy


--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192854): 
https://lists.openembedded.org/g/openembedded-core/message/192854
Mute This Topic: https://lists.openembedded.org/mt/102826186/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] bitbake-server does not exit after build ends

2023-12-21 Thread Randy MacLeod via lists.openembedded.org
On 2023-11-28 4:26 a.m., Zoltan Boszormenyi via lists.openembedded.org 
wrote:

So it's not just Fedora, but Python 3.12 in general.

Googling for problem with threads + fork reveals that
it is indeed an issue even in C / POSIX: only the thread
executing fork() will become part of the new process,
but not the main process starting the thread or any
other threads from the original process.

The warning is justified, and apparently the issue
not occurring in bitbake with previous Python versions
is pure luck.


FYI: Fixed in Fedora 39 if you update to get python-3.12.1-1 or later.


--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192844): 
https://lists.openembedded.org/g/openembedded-core/message/192844
Mute This Topic: https://lists.openembedded.org/mt/102826186/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-Core][PATCH 7/7] rust: Upgrade 1.73.0 -> 1.74.0

2023-12-12 Thread Randy MacLeod via lists.openembedded.org

On 2023-12-12 11:25 a.m., Randy MacLeod wrote:

On 2023-12-12 5:41 a.m., Alex Kiernan via lists.openembedded.org wrote:

On Sat, Dec 9, 2023 at 2:06 PM Alex Kiernan via lists.openembedded.org
  wrote:

On Sat, Dec 9, 2023 at 12:18 PM Alexandre Belloni
  wrote:

Hello Alex,

rust 1.74.0 is not reproducible:
https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20231208-rfbproj4/packages/diff-html/


Thanks, I think :)


One observation, which might be useful, these failures are all inside
the same module src/llvm-project/compiler-rt/lib/builtins which are
just a bunch of intrinsics. And as far as I can see it looks like it's
just the object name mangling that's not reproducible.


FYI:

In the weekly YP tech call, we talked about Rust and Richard said that 
he'd merge
1.71 to master since it's progress and it unblocks some ptest works 
that Tim was working on.


We can then just jump directly from 1.71 to 1.74 if ( when! ) we can 
make that reproducible.



Or even  to rust-1.74.1:

https://blog.rust-lang.org/2023/12/07/Rust-1.74.1.html

../Randy



Richard said that he started with 1.74 from Alex's patch-set and
when he found that it wasn't reproducible, he simply worked his way 
backward.


../Randy









--
# Randy MacLeod
# Wind River Linux



--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192236): 
https://lists.openembedded.org/g/openembedded-core/message/192236
Mute This Topic: https://lists.openembedded.org/mt/103055169/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-Core][PATCH 7/7] rust: Upgrade 1.73.0 -> 1.74.0

2023-12-12 Thread Randy MacLeod via lists.openembedded.org

On 2023-12-12 5:41 a.m., Alex Kiernan via lists.openembedded.org wrote:

On Sat, Dec 9, 2023 at 2:06 PM Alex Kiernan via lists.openembedded.org
  wrote:

On Sat, Dec 9, 2023 at 12:18 PM Alexandre Belloni
  wrote:

Hello Alex,

rust 1.74.0 is not reproducible:
https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20231208-rfbproj4/packages/diff-html/


Thanks, I think :)


One observation, which might be useful, these failures are all inside
the same module src/llvm-project/compiler-rt/lib/builtins which are
just a bunch of intrinsics. And as far as I can see it looks like it's
just the object name mangling that's not reproducible.


FYI:

In the weekly YP tech call, we talked about Rust and Richard said that 
he'd merge
1.71 to master since it's progress and it unblocks some ptest works that 
Tim was working on.


We can then just jump directly from 1.71 to 1.74 if ( when! ) we can 
make that reproducible.


Richard said that he started with 1.74 from Alex's patch-set and
when he found that it wasn't reproducible, he simply worked his way 
backward.


../Randy










--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192235): 
https://lists.openembedded.org/g/openembedded-core/message/192235
Mute This Topic: https://lists.openembedded.org/mt/103055169/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [kirkstone][PATCH] nativesdk-sdk-provides-dummy.bb: Update host tools for rust-cross-canadian

2023-12-11 Thread Randy MacLeod via lists.openembedded.org

On 2023-12-11 7:26 a.m., deepthi.hem...@windriver.com wrote:

From: Deepthi Hemraj

[YOCTO #15082]
Packagegroup-rust-cross-canadian package requires rust-cross-canadian, but the 
necessary libstdc++.so.6(GLIBCXX_3.4.30)(64bit) library is missing.
The fix adds the libstdc++.so.6(GLIBCXX_3.4.30)(64bit) library requirement to 
the  SDK dummy package, resolving the dependency conflict.

Signed-off-by: Deepthi Hemraj
---
  meta/recipes-core/meta/nativesdk-sdk-provides-dummy.bb | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/meta/nativesdk-sdk-provides-dummy.bb 
b/meta/recipes-core/meta/nativesdk-sdk-provides-dummy.bb
index 1d71f373a4..dc3ae1edaf 100644
--- a/meta/recipes-core/meta/nativesdk-sdk-provides-dummy.bb
+++ b/meta/recipes-core/meta/nativesdk-sdk-provides-dummy.bb
@@ -10,7 +10,8 @@ DUMMYPROVIDES = "\
  /usr/bin/env \
  libGL.so()(64bit) \
  libGL.so \
-"
+libstdc++.so.6(GLIBCXX_3.4.30)(64bit) \
+"
  
  require dummy-sdk-package.inc
  


This doesn't seem right to me...

Does the problem happen on master?

I haven't tried it but I suspect we want to add something like:

nativesdk-libstdc++

to:

DEPENDS:append:class-nativesdk = " nativesdk-rust-llvm"

in the rust bb file.

--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192175): 
https://lists.openembedded.org/g/openembedded-core/message/192175
Mute This Topic: https://lists.openembedded.org/mt/103107487/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 2/2] rust: Disable rust oe-selftest

2023-12-08 Thread Randy MacLeod via lists.openembedded.org

On 2023-12-08 9:46 a.m., Alexandre Belloni wrote:

On 08/12/2023 09:05:51-0500, Randy MacLeod wrote:

On 2023-12-08 5:48 a.m.,yash.shi...@windriver.com  wrote:

From: Yash Shinde

After rust is upgraded to 1.71 and later versions, the rust oe-selftest gives
build errors due to unstable nightly options(see the error mentioned below). 
Thus, disable the test suite
until the issue is fixed

error: the option `Z` is only accepted on the nightly compiler
thread 'main' panicked at 'failed to gather the target spec for 
x86_64-poky-linux-gnu', synthetic_targets.rs:66:9

Following issues are created in Yocto bugzilla and rust upstream to track this 
issue-

https://bugzilla.yoctoproject.org/show_bug.cgi?id=15275
https://github.com/rust-lang/rust/issues/115642
https://users.rust-lang.org/t/does-rust-test-suite-supports-nightly-options-during-bootstrapping-in-rust/103108
https://users.rust-lang.org/t/unable-to-read-target-specs-when-rust-1-73-is-bootstrapped-in-yocto-poky/102959

Signed-off-by: Yash Shinde
---
   meta/lib/oeqa/selftest/cases/rust.py | 3 +++
   1 file changed, 3 insertions(+)

diff --git a/meta/lib/oeqa/selftest/cases/rust.py 
b/meta/lib/oeqa/selftest/cases/rust.py
index 7d148142fc..6dbc517006 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -39,6 +39,9 @@ def parse_results(filename):
   @OETestTag("runqemu")
   class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
   def test_rust(self, *args, **kwargs):
+# Disable Rust Oe-selftest
+self.skipTest("The Rust Oe-selftest is disabled.")
+
   # build remote-test-server before image build
   recipe = "rust"
   start_time = time.time()

Thanks for the Rust update Yash and it's unfortunate that we haven't
resolved the problems
with the test suite. We decided to diskable the tests and do the update
because some changes
were blocked waiting for a newer version of Rust according to Tim.

Yash,
It would be better to disable (skip) the test suite first so that there
isn't a commit with the testsuite
broken.

Alex, the commits are independent, will you please re-order them before
merging?

Sure!

In case anyone doesn't read the other thread/messages, we're going with
Alex Kiernan's patchset that starts with Yash's patch:

   [OE-Core][PATCH 1/7] rust: Disable rust oe-selftest


../Randy




../Randy

--
# Randy MacLeod
# Wind River Linux



--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192076): 
https://lists.openembedded.org/g/openembedded-core/message/192076
Mute This Topic: https://lists.openembedded.org/mt/103052789/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 1/2] rust: Upgrade 1.70.0 -> 1.73.0

2023-12-08 Thread Randy MacLeod via lists.openembedded.org

On 2023-12-08 9:07 a.m., Alex Kiernan wrote:

On Fri, Dec 8, 2023 at 1:55 PM Richard Purdie
  wrote:

On Fri, 2023-12-08 at 13:47 +, Alex Kiernan wrote:

On Fri, Dec 8, 2023 at 9:56 AM Shinde, Yash via lists.openembedded.org
  wrote:

From: Yash Shinde

In rust 1.72.0 the 'mips*-unknown-linux-gnu*' support demoted from tier2 to 
tier3.
The mips bootstrap compiler is removed from src/stage0.json file and
so the same are removed from rust-snapshot.inc. 
[https://github.com/rust-lang/rust/releases/tag/1.72.0]

Drop bootstrap_fail.patch, getrandom-open64.patch
as they are merged in upstream rust.

]>

Signed-off-by: Yash Shinde
---

If we're going to go down the road of disabling the rust oe-selftest
(and I don't see a better option right now as we're well behind), I
have a series which steps us through each of the releases up to
1.74.0.

It also avoids the need for the library/test hack (upstream has a new
target we can use for libstd).

This sounds useful, particularly this last piece. Can you send it? We
could probably combine it with 2/2 in this series if Yash/Randy agree.


I've pulled that in as the first patch in the series so if you were
bisecting you wouldn't see the oe-selftest fail on upgrade to 1.71.
I was just about to ask you to do that! Thanks for being one step ahead 
of me!

It's on top of the cargo cleanups I posted yesterday, so I suspect
those are prerequisites (or I could combine the two into one series?)

I'm not sure, let's see it on the list and review there.


I've not tested every step extensively, but they all build and I've
tested cargo in most of them manually inside qemu.


Thanks Alex.

--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192072): 
https://lists.openembedded.org/g/openembedded-core/message/192072
Mute This Topic: https://lists.openembedded.org/mt/103052790/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 2/2] rust: Disable rust oe-selftest

2023-12-08 Thread Randy MacLeod via lists.openembedded.org

On 2023-12-08 5:48 a.m., yash.shi...@windriver.com wrote:

From: Yash Shinde

After rust is upgraded to 1.71 and later versions, the rust oe-selftest gives
build errors due to unstable nightly options(see the error mentioned below). 
Thus, disable the test suite
until the issue is fixed

error: the option `Z` is only accepted on the nightly compiler
thread 'main' panicked at 'failed to gather the target spec for 
x86_64-poky-linux-gnu', synthetic_targets.rs:66:9

Following issues are created in Yocto bugzilla and rust upstream to track this 
issue-

https://bugzilla.yoctoproject.org/show_bug.cgi?id=15275
https://github.com/rust-lang/rust/issues/115642
https://users.rust-lang.org/t/does-rust-test-suite-supports-nightly-options-during-bootstrapping-in-rust/103108
https://users.rust-lang.org/t/unable-to-read-target-specs-when-rust-1-73-is-bootstrapped-in-yocto-poky/102959

Signed-off-by: Yash Shinde
---
  meta/lib/oeqa/selftest/cases/rust.py | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/meta/lib/oeqa/selftest/cases/rust.py 
b/meta/lib/oeqa/selftest/cases/rust.py
index 7d148142fc..6dbc517006 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -39,6 +39,9 @@ def parse_results(filename):
  @OETestTag("runqemu")
  class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
  def test_rust(self, *args, **kwargs):
+# Disable Rust Oe-selftest
+self.skipTest("The Rust Oe-selftest is disabled.")
+
  # build remote-test-server before image build
  recipe = "rust"
  start_time = time.time()


Thanks for the Rust update Yash and it's unfortunate that we haven't 
resolved the problems
with the test suite. We decided to diskable the tests and do the update 
because some changes

were blocked waiting for a newer version of Rust according to Tim.

Yash,
It would be better to disable (skip) the test suite first so that there 
isn't a commit with the testsuite

broken.

Alex, the commits are independent, will you please re-order them before 
merging?


../Randy

--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192070): 
https://lists.openembedded.org/g/openembedded-core/message/192070
Mute This Topic: https://lists.openembedded.org/mt/103052789/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 1/5] classes: jobserver: support gnu make fifo jobserver

2023-11-17 Thread Randy MacLeod via lists.openembedded.org

Hi Martin,

I tested this RFC series briefly when it was posted but then some things 
came up and I haven't gotten back to it.


I was talking with Richard and he thought that his original poky-contrib 
branch commit, which it seems this work is based,
had a list of things to fix before the jobserver could be merged. Can 
you find and share that list here?


I may have time to do more testing but I think I had concluded that the 
default settings:

   INHERIT += "jobserver"
didn't have any impact on build performance, as expected, I suppose.

What testing have you done so far?

../Randy


On 2023-08-28 8:48 a.m., Martin Hundeb?ll via lists.openembedded.org wrote:

Add a class to implement the gnu make fifo style jobserver. The class
can be activated by symply adding an `INHERIT += "jobserver"` to the
local configuration.

Furthermore, one can configure an external jobserver (i.e. a server
shared between multiple builds), by configured the `JOBSERVER_FIFO`
variable to point at an existing jobserver fifo.

The jobserver class uses the fifo style jobserver, which doesn't require
passing open file descriptors around. It does, however, require
make-4.4, which isn't available in common distro yet. To work around
this, the class make all recipes (except make and its dependencies
itself) depend on `virtual/make-native`.

Signed-off-by: Martin Hundebøll
---
  meta/classes-global/jobserver.bbclass | 80 +++
  meta/conf/bitbake.conf|  2 +-
  2 files changed, 81 insertions(+), 1 deletion(-)
  create mode 100644 meta/classes-global/jobserver.bbclass

diff --git a/meta/classes-global/jobserver.bbclass 
b/meta/classes-global/jobserver.bbclass
new file mode 100644
index 00..c76909fe50
--- /dev/null
+++ b/meta/classes-global/jobserver.bbclass
@@ -0,0 +1,80 @@
+JOBSERVER_FIFO ?= ""
+JOBSERVER_FIFO[doc] = "Path to external jobserver fifo to use instead of creating a 
per-build server."
+
+addhandler jobserver_setup_fifo
+jobserver_setup_fifo[eventmask] = "bb.event.ConfigParsed"
+
+python jobserver_setup_fifo() {
+# don't setup a per-build fifo, if an external one is configured
+if d.getVar("JOBSERVER_FIFO"):
+return
+
+# don't use a job-server if no parallelism is configured
+jobs = oe.utils.parallel_make(d)
+if jobs in (None, 1):
+return
+
+# reduce jobs by one as a token has implicitly been handed to the
+# process requesting tokens
+jobs -= 1
+
+fifo = d.getVar("TMPDIR") + "/jobserver_fifo"
+
+# and old fifo might be lingering; remove it
+if os.path.exists(fifo):
+os.remove(fifo)
+
+# create a new fifo to use for communicating tokens
+os.mkfifo(fifo)
+
+# fill the fifo with the number of tokens to hand out
+wfd = os.open(fifo, os.O_RDWR)
+written = os.write(wfd, b"+" * jobs)
+if written != (jobs):
+bb.error("Failed to fil make fifo: {} != {}".format(written, jobs))
+
+# configure the per-build fifo path to use
+d.setVar("JOBSERVER_FIFO", fifo)
+}
+
+python () {
+# don't configure the fifo if none is defined
+fifo = d.getVar("JOBSERVER_FIFO")
+if not fifo:
+return
+
+# avoid making make-native or its dependencies depend on make-native itself
+if d.getVar("PN") in (
+"make-native",
+"libtool-native",
+"pkgconfig-native",
+"automake-native",
+"autoconf-native",
+"m4-native",
+"texinfo-dummy-native",
+"gettext-minimal-native",
+"quilt-native",
+"gnu-config-native",
+):
+return
+
+# don't make unwilling recipes depend on make-native
+if d.getVar('INHIBIT_DEFAULT_DEPS', False):
+return
+
+# make other recipes depend on make-native to make sure it is new enough to
+# support the --jobserver-auth=fifo: syntax (from make-4.4 and 
onwards)
+d.appendVar("DEPENDS", " virtual/make-native")
+
+# disable the "-j " flag, as that overrides the jobserver fifo tokens
+d.setVar("PARALLEL_MAKE", "")
+d.setVar("PARALLEL_MAKEINST", "")
+
+# set and export the jobserver in the environment
+d.appendVar("MAKEFLAGS", " --jobserver-auth=fifo:" + fifo)
+d.setVarFlag("MAKEFLAGS", "export", "1")
+
+# ignore the joberserver argument part of MAKEFLAGS in the hash, as that
+# shouldn't change the build output
+d.appendVarFlag("MAKEFLAGS", "vardepvalueexclude", "| 
--jobserver-auth=fifo:" + fifo)
+}
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index cf7ff3328c..8cf188270b 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -946,7 +946,7 @@ BB_HASHEXCLUDE_COMMON ?= "TMPDIR FILE PATH PWD BB_TASKHASH 
BBPATH BBSERVER DL_DI
  BB_WORKERCONTEXT BB_LIMITEDDEPS BB_UNIHASH extend_recipe_sysroot 
DEPLOY_DIR \
  SSTATE_HASHEQUIV_METHOD SSTATE_HASHEQUIV_REPORT_TASKDATA \
  SSTATE_HASHEQUIV_OWNER 

Re: [OE-core][kirkstone][PATCH] avahi: Fix for multiple CVE's

2023-11-17 Thread Randy MacLeod via lists.openembedded.org
Add Hari who will inform WR developers on his team once the CVE 
co-ordination scheme is available.

Add Marta.

On 2023-11-17 9:11 a.m., Meenali Gupta via lists.openembedded.org wrote:

Hi Ross,

As discussed with Vijay,  we'll cooperate on this CVE fixes.


Marta,


Do you have a wiki page set-up?


I see:

https://wiki.yoctoproject.org/wiki/Synchronization_CVEs

and it mentions, but does not point to, "A synchronization wiki page".



../Randy




Regards
Meenali

*From:* Vijay Anusuri 
*Sent:* 16 November 2023 21:31
*To:* jpuhl...@mvista.com ; Ross Burton 
; Gupta, Meenali 
*Cc:* openembedded-core@lists.openembedded.org 


*Subject:* Re: [OE-core][kirkstone][PATCH] avahi: Fix for multiple CVE's
**
*CAUTION: This email comes from a non Wind River email account!*
Do not click links or open attachments unless you recognize the sender 
and know the content is safe.

Hi Ross,

As discussed with Meenali, I agreed she was going to do this work.
She has already submitted patches for multiple branches ( master, 
mickledore and kirkstone ).


For CVE-2023-38469, we need to include 2 commits to fix the CVE. 
Meenali will send the v2 patch for CVE-2023-38469 which will include 2 
patches for all the branches.


Thank you Meenali for your timely response.

Thanks & Regards,
Vijay

On Thu, Nov 16, 2023 at 7:56 PM Jeremy Puhlman via 
lists.openembedded.org 
 
 wrote:




On 11/16/2023 3:22 AM, Ross Burton wrote:
> Hi Vijay and Meenali,
>
> Hopefully this will show everyone - especially WR and Montavista
- that we need to communicate better when working on CVEs.  In the
short term at least, Marta proposed a wiki page which can be
updated via a tool and when someone is working on an issue that
can be marked to avoid duplication of effort.  Would that be
acceptable to both of your companies?

Yeah, I think something like that would be great on our end, provided
its automated and the data can be extracted, so it can be
consolidated
in internal CVE tracking that we are currently required to.

>
> I’ve not checked that the fixes are identical, but apparently I
need to remind everyone that we take fixes in *master first* and
then backport to the releases in order.
There should also be an agree upon change decoration to indicate
non-applicability/differently addressed in earlier releases.

With 4 year LTS releases many issues are just not going to be
applicable
to master. Also there may well be very good reasons to fix a given
set
of CVEs in
completely different ways, but making sure they are addressed in
both is
important. Setting aside this example, in almost all cases on master
moving to the fixed version, is almost always the right answer,
where as
on say dunfell, moving to the new version may have too many knock on
effects to make sense.
In this instance, Khem has already indicated moving to the new
release
may make sense for both kirkstone and master.

>
> Luckily the avahi recipe is fairly untouched so this should be
trivial.  Can you both discuss and agree who is going to do this?
Vijay can you work with Meenali to consolidate this patch.
>
> Ross
>
>> On 16 Nov 2023, at 04:05, Vijay Anusuri via
lists.openembedded.org


 wrote:
>>
>> From: Vijay Anusuri 
>>
>> Patches to fix:
>> CVE-2023-38469
>> CVE-2023-38470
>> CVE-2023-38471
>> CVE-2023-38472
>> CVE-2023-38473
>>
>> Upstream-Status: Backport

[https://github.com/lathiat/avahi/commit/a337a1ba7d15853fb56deef1f464529af6e3a1cf


>> &
>>

https://github.com/lathiat/avahi/commit/c6cab87df290448a63323c8ca759baa516166237


>> &
>>

https://github.com/lathiat/avahi/commit/94cb6489114636940ac683515417990b55b5d66c


>> &
>>


Re: [OE-core] [RFC 1/5] valgrind: make ptest depend on all components

2023-11-15 Thread Randy MacLeod via lists.openembedded.org

On 2023-11-15 9:48 a.m., Alexander Kanavin wrote:

On Thu, 9 Nov 2023 at 03:00, Randy MacLeod  wrote:

As I said previously, I may not have time to get back to this until next week so
if anyone picks up this work, they might want to confirm that this is really 
required.

I should have just waited until I had time to complete the update before 
spamming the list.

Thanks Randy, I hope you find time to complete this, as I'm planning
to work on other updates.

Yes, I will get to it but I have some things happening outside of work
that will make this take longer than usual. I did make a bit more progress
on fixing the ptest regressions.

We're falling behind all over the place, as
seen in the latest AUH report. Rust would be nice to do too.


Indeed.

Yash and Sundeep have 1.72/1.73 updated and are working on

getting the test suite to work but struggling with that.
I asked him to track what's happening in:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15275

../Randy




Alex



--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#190736): 
https://lists.openembedded.org/g/openembedded-core/message/190736
Mute This Topic: https://lists.openembedded.org/mt/102477896/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC 1/5] valgrind: make ptest depend on all components

2023-11-08 Thread Randy MacLeod via lists.openembedded.org

On 2023-11-08 8:25 p.m., Randy MacLeod via lists.openembedded.org wrote:

From: Randy MacLeod

When the helper scripts were split into separate packages, they
weren't added as ptest dependencies. Fix that.


Well, this is embarrassing...

I'm no longer convinced that this is required.

I think I saw the ../cg_diff errors below:

PASS: memcheck/tests/vcpu_fbench
PASS: memcheck/tests/wcs
PASS: memcheck/tests/wcsncpy
PASS: memcheck/tests/wmemcmp
FAIL: memcheck/tests/wrap1
FAIL: memcheck/tests/wrap2
FAIL: memcheck/tests/wrap3
FAIL: memcheck/tests/wrap4
FAIL: memcheck/tests/wrap5
FAIL: memcheck/tests/wrap6
FAIL: memcheck/tests/wrap7
FAIL: memcheck/tests/wrap8
PASS: memcheck/tests/wrapmalloc
PASS: memcheck/tests/wrapmallocstatic
PASS: memcheck/tests/writev1
PASS: memcheck/tests/xml1
python3: can't open file 
'/usr/lib/valgrind/ptest/cachegrind/tests/../cg_diff': [Errno 2] No such 
file or directory
post check failed: python3 ../cg_diff --mod-funcname="s/main/MAIN/" 
ann1.cgout ann1b.cgout > ann-diff1.cgout && python3 ../cg_annotate 
--mod-filename="s/a.c/A.c/" --mod-funcname s/MAIN/Main/

PASS: cachegrind/tests/ann-diff1
python3: can't open file 
'/usr/lib/valgrind/ptest/cachegrind/tests/../cg_diff': [Errno 2] No such 
file or directory
post check failed: python3 ../cg_diff --mod-filename="s/.*aux\//aux\//i" 
--mod-funcname="s/(f[a-z]*)[0-9]/\1N/g" ann-diff2a.cgout 
ann-diff2b.cgout > ann-diff2c.cgout && python3 ../cg_annotat

PASS: cachegrind/tests/ann-diff2

and made an assumption that may not be valid. I think this problem is 
still present

even after this change.

As I said previously, I may not have time to get back to this until next 
week so
if anyone picks up this work, they might want to confirm that this is 
really required.


I should have just waited until I had time to complete the update before 
spamming the list.


../Randy

../Randy




Signed-off-by: Randy MacLeod
---
  meta/recipes-devtools/valgrind/valgrind_3.21.0.bb | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb 
b/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
index 68ab319a1b..a2feda6aae 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
@@ -139,7 +139,9 @@ RDEPENDS:${PN}-ptest += " bash coreutils curl file \
 perl-module-overloading perl-module-cwd perl-module-ipc-open3 \
 perl-module-carp perl-module-symbol \
 procps sed ${PN}-dbg ${PN}-src ${TCLIBC}-src gcc-runtime-dbg \
-   util-linux-taskset"
+   util-linux-taskset \
+   ${PN}-cachegrind ${PN}-massif ${PN}-callgrind \
+"
  RDEPENDS:${PN}-ptest:append:libc-glibc = " glibc-utils glibc-gconv-utf-32"
  
  # One of the tests contains a bogus interpreter path on purpose.






--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#190374): 
https://lists.openembedded.org/g/openembedded-core/message/190374
Mute This Topic: https://lists.openembedded.org/mt/102477896/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC 3/5] valgrind: drop context API musl patch

2023-11-08 Thread Randy MacLeod via lists.openembedded.org

On 2023-11-08 8:25 p.m., Randy MacLeod via lists.openembedded.org wrote:

From: Randy MacLeod

Drop 002-context-APIs-are-not-available-on-musl.patch
I tested the update to 3.22 including ptests and then did a careful 
review of the patches


so that's why these 'drop' commits come after the recipe update commit.


Strangely enough, the build/ptest results didn't change as I dropped 
each patch

since upstream took a different approach to each problem and the patches
were simply not required.

I _could_ squash all these 'drop' commits into the recipe update but
I prefer to do them one at a time.

../Randy



since this is handled in a different way by the following
upstream commits:
c9e88f345 configure, drd: Only build the swapcontext test if swapcontext() 
is available
7cd4d7816 memcheck/tests/linux/stack_changes: Only run this test if 
setcontext() is available
And the that tracked the error:
https://bugs.kde.org/show_bug.cgi?id=434775
is closed.

No regression in musl qemux86-64/kvm ptest resutls.:

Signed-off-by: Randy MacLeod
---
  ...ntext-APIs-are-not-available-on-musl.patch | 92 ---
  .../valgrind/valgrind_3.22.0.bb   |  1 -
  2 files changed, 93 deletions(-)
  delete mode 100644 
meta/recipes-devtools/valgrind/valgrind/0002-context-APIs-are-not-available-on-musl.patch

diff --git 
a/meta/recipes-devtools/valgrind/valgrind/0002-context-APIs-are-not-available-on-musl.patch
 
b/meta/recipes-devtools/valgrind/valgrind/0002-context-APIs-are-not-available-on-musl.patch
deleted file mode 100644
index 7f0e38cb95..00
--- 
a/meta/recipes-devtools/valgrind/valgrind/0002-context-APIs-are-not-available-on-musl.patch
+++ /dev/null
@@ -1,92 +0,0 @@
-From 26c104adf6c5162572b7aa2fac89d0835b7f8f0b Mon Sep 17 00:00:00 2001
-From: Randy MacLeod
-Date: Tue, 16 Oct 2018 21:27:46 -0400
-Subject: [PATCH] context APIs are not available on musl
-
-Updated patch for valgrind-3.14
-
-Signed-off-by: Khem Raj
-Signed-off-by: Randy MacLeod
-
-Apply same patch to drd/tests/swapcontext.c
-for valgrind-3.17.
-
-Upstream-Status: Submitted [https://bugs.kde.org/show_bug.cgi?id=434775]
-
-Signed-off-by: Yi Fan Yu

- drd/tests/swapcontext.c  | 6 ++
- memcheck/tests/linux/stack_changes.c | 7 ++-
- 2 files changed, 12 insertions(+), 1 deletion(-)
-
-diff --git a/drd/tests/swapcontext.c b/drd/tests/swapcontext.c
-index 622c70bc5..5e72bb0f3 100644
 a/drd/tests/swapcontext.c
-+++ b/drd/tests/swapcontext.c
-@@ -20,6 +20,7 @@
-
- #define STACKSIZE (PTHREAD_STACK_MIN + 4096)
-
-+#ifdef __GLIBC__
- typedef struct thread_local {
-   ucontext_t uc[3];
-   size_t nrsw;
-@@ -67,9 +68,11 @@ void *worker(void *data)
-   swapcontext(>uc[0], >uc[1]);
-   return NULL;
- }
-+#endif
-
- int main(int argc, char *argv[])
- {
-+#ifdef __GLIBC__
-   enum { NR = 32 };
-   thread_local_t tlocal[NR];
-   pthread_t thread[NR];
-@@ -94,6 +97,9 @@ int main(int argc, char *argv[])
-
-   for (i = 0; i < NR; i++)
- pthread_join(thread[i], NULL);
-+#else
-+printf("libc context call APIs e.g. getcontext() are deprecated by 
posix\n");
-+#endif
-
-   return 0;
- }
-diff --git a/memcheck/tests/linux/stack_changes.c 
b/memcheck/tests/linux/stack_changes.c
-index 7f97b90a5..a26cb4ae6 100644
 a/memcheck/tests/linux/stack_changes.c
-+++ b/memcheck/tests/linux/stack_changes.c
-@@ -10,6 +10,7 @@
- // This test is checking the libc context calls (setcontext, etc.) and
- // checks that Valgrind notices their stack changes properly.
-
-+#ifdef __GLIBC__
- typedef  ucontext_t  mycontext;
-
- mycontext ctx1, ctx2, oldc;
-@@ -51,9 +52,11 @@ int init_context(mycontext *uc)
-
- return ret;
- }
-+#endif
-
- int main(int argc, char **argv)
- {
-+#ifdef __GLIBC__
- int c1 = init_context();
- int c2 = init_context();
-
-@@ -66,6 +69,8 @@ int main(int argc, char **argv)
- //free(ctx1.uc_stack.ss_sp);
- VALGRIND_STACK_DEREGISTER(c2);
- //free(ctx2.uc_stack.ss_sp);
--
-+#else
-+printf("libc context call APIs e.g. getcontext() are deprecated by 
posix\n");
-+#endif
- return 0;
- }
---
-2.17.1
-
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb 
b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
index 6dcd028075..0ebf08eb28 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
@@ -25,7 +25,6 @@ SRC_URI = 
"https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2 \
 file://valgrind-make-ld-XXX.so-strlen-intercept-optional.patch  \
 
file://0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch  \
 file://0001-sigqueue-Rename-_sifields-to-__si_fields-on-musl.patch 
 \
-file://0002-context-APIs-are-not-available-on-musl.patch  \
 file://0003-correct-include-directive-path-for-config.h.patch  \
 file://0001-fix-opcode-not-supported-on-mips32-linux.patch  \
 
file://0001-Make-local-f

Re: [OE-core] [RFC 2/5] valgrind: update from 3.21.0 to 3.22.0

2023-11-08 Thread Randy MacLeod via lists.openembedded.org

On 2023-11-08 8:25 p.m., Randy MacLeod via lists.openembedded.org wrote:

From: Randy MacLeod

Full release notes:https://valgrind.org/docs/manual/dist.news.html

In summary, there is a new configure option: --with-gdbscripts-dir
that lets you install the gdb valgrind python monitor scripts in a specific 
location.
It's not used in the valgrind recipe yet. Also, there were a few Memcheck and 
Cachegrind
improvements made and many bugs fixed.

The update required removing the patch:
0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch
as it's dealt with by these commits:
f7e4bb4af Bug 382034 - Testcases build fixes for musl
306232d40 musl: another fix for building testcases
as described on:https://bugs.kde.org/show_bug.cgi?id=382034

Ptest Resutls for qemux86-64/kvm

glibc:
=== Test Summary ===
TOTAL: 792
PASSED: 759
FAILED: 14
I haven't checked but I think these are 14 *new* ptest failures so we 
shouldn't merge until they are fixed.


The tests that fail are:

root@qemux86-64:/usr/lib/valgrind/ptest# grep FAIL 
valgrind_ptest_20231109-001351.log

FAIL: memcheck/tests/linux/dlclose_leak-no-keep
FAIL: memcheck/tests/linux/dlclose_leak
FAIL: memcheck/tests/wrap1
FAIL: memcheck/tests/wrap2
FAIL: memcheck/tests/wrap3
FAIL: memcheck/tests/wrap4
FAIL: memcheck/tests/wrap5
FAIL: memcheck/tests/wrap6
FAIL: memcheck/tests/wrap7
FAIL: memcheck/tests/wrap8
FAIL: cachegrind/tests/wrap5
FAIL: massif/tests/bug469146
FAIL: massif/tests/new-cpp
FAIL: massif/tests/overloaded-new

I may not get time to work on them any more this week so I'm sending the 
update

in case anyone (Alex!) wants to take a look.

../Rnady


SKIPPED: 19

musl:
=== Test Summary ===
TOTAL: 792
PASSED: 559
FAILED: 211
SKIPPED: 22

Signed-off-by: Randy MacLeod
---
  ...inux-seg_override.c-add-missing-incl.patch | 30 ---
  ...{valgrind_3.21.0.bb => valgrind_3.22.0.bb} |  3 +-
  2 files changed, 1 insertion(+), 32 deletions(-)
  delete mode 100644 
meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch
  rename meta/recipes-devtools/valgrind/{valgrind_3.21.0.bb => 
valgrind_3.22.0.bb} (98%)

diff --git 
a/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch
 
b/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch
deleted file mode 100644
index 5e36c28523..00
--- 
a/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-From 978d9ed7f857f2cdcd2a8632f3c2feb56b99c825 Mon Sep 17 00:00:00 2001
-From: Alexander Kanavin
-Date: Mon, 8 May 2023 11:56:35 +0200
-Subject: [PATCH] none/tests/x86-linux/seg_override.c: add missing include for
- musl builds
-
-Otherwise SYS_modify_ldt is undefined.
-
-Upstream-Status: Submitted [https://bugs.kde.org/show_bug.cgi?id=382034]
-Signed-off-by: Alexander Kanavin
-

- none/tests/x86-linux/seg_override.c | 4 
- 1 file changed, 4 insertions(+)
-
-diff --git a/none/tests/x86-linux/seg_override.c 
b/none/tests/x86-linux/seg_override.c
-index ca8fbfe..4ef4394 100644
 a/none/tests/x86-linux/seg_override.c
-+++ b/none/tests/x86-linux/seg_override.c
-@@ -3,6 +3,10 @@
- #include 
- #include 
- #include "../../../config.h"
-+#if defined(MUSL_LIBC)
-+#include 
-+#include 
-+#endif
-
-
- /* Stuff from Wine. */
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb 
b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
similarity index 98%
rename from meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
rename to meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
index a2feda6aae..6dcd028075 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
@@ -36,9 +36,8 @@ SRC_URI ="https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2 \ 
file://0001-none-tests-fdleak_cmsg.stderr.exp-adjust-tmp-paths.patch \ 
file://0001-memcheck-tests-Fix-timerfd-syscall-test.patch \ 
file://0001-docs-Disable-manual-validation.patch \ - 
file://0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch \ "

-SRC_URI[sha256sum] = 
"10ce1618bb3e33fad16eb79552b0a3e1211762448a0d7fce11c8a6243b9ac971"
+SRC_URI[sha256sum] = 
"c811db5add2c5f729944caf47c4e7a65dcaabb9461e472b578765dd7bf6d2d4c"
  UPSTREAM_CHECK_REGEX = "valgrind-(?P\d+(\.\d+)+)\.tar"
  
  COMPATIBLE_HOST = '(i.86|x86_64|arm|aarch64|mips|powerpc|powerpc64).*-linux'






--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#190372): 
https://lists.openembedded.org/g/openembedded-core/message/190372
Mute This Topic: https://lists.openembedded.org/mt/102477976/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFC 3/5] valgrind: drop context API musl patch

2023-11-08 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

Drop 002-context-APIs-are-not-available-on-musl.patch
since this is handled in a different way by the following
upstream commits:
   c9e88f345 configure, drd: Only build the swapcontext test if swapcontext() 
is available
   7cd4d7816 memcheck/tests/linux/stack_changes: Only run this test if 
setcontext() is available
And the that tracked the error:
   https://bugs.kde.org/show_bug.cgi?id=434775
is closed.

No regression in musl qemux86-64/kvm ptest resutls.:

Signed-off-by: Randy MacLeod 
---
 ...ntext-APIs-are-not-available-on-musl.patch | 92 ---
 .../valgrind/valgrind_3.22.0.bb   |  1 -
 2 files changed, 93 deletions(-)
 delete mode 100644 
meta/recipes-devtools/valgrind/valgrind/0002-context-APIs-are-not-available-on-musl.patch

diff --git 
a/meta/recipes-devtools/valgrind/valgrind/0002-context-APIs-are-not-available-on-musl.patch
 
b/meta/recipes-devtools/valgrind/valgrind/0002-context-APIs-are-not-available-on-musl.patch
deleted file mode 100644
index 7f0e38cb95..00
--- 
a/meta/recipes-devtools/valgrind/valgrind/0002-context-APIs-are-not-available-on-musl.patch
+++ /dev/null
@@ -1,92 +0,0 @@
-From 26c104adf6c5162572b7aa2fac89d0835b7f8f0b Mon Sep 17 00:00:00 2001
-From: Randy MacLeod 
-Date: Tue, 16 Oct 2018 21:27:46 -0400
-Subject: [PATCH] context APIs are not available on musl
-
-Updated patch for valgrind-3.14
-
-Signed-off-by: Khem Raj 
-Signed-off-by: Randy MacLeod 
-
-Apply same patch to drd/tests/swapcontext.c
-for valgrind-3.17.
-
-Upstream-Status: Submitted [https://bugs.kde.org/show_bug.cgi?id=434775]
-
-Signed-off-by: Yi Fan Yu 

- drd/tests/swapcontext.c  | 6 ++
- memcheck/tests/linux/stack_changes.c | 7 ++-
- 2 files changed, 12 insertions(+), 1 deletion(-)
-
-diff --git a/drd/tests/swapcontext.c b/drd/tests/swapcontext.c
-index 622c70bc5..5e72bb0f3 100644
 a/drd/tests/swapcontext.c
-+++ b/drd/tests/swapcontext.c
-@@ -20,6 +20,7 @@
- 
- #define STACKSIZE (PTHREAD_STACK_MIN + 4096)
- 
-+#ifdef __GLIBC__
- typedef struct thread_local {
-   ucontext_t uc[3];
-   size_t nrsw;
-@@ -67,9 +68,11 @@ void *worker(void *data)
-   swapcontext(>uc[0], >uc[1]);
-   return NULL;
- }
-+#endif
- 
- int main(int argc, char *argv[])
- {
-+#ifdef __GLIBC__
-   enum { NR = 32 };
-   thread_local_t tlocal[NR];
-   pthread_t thread[NR];
-@@ -94,6 +97,9 @@ int main(int argc, char *argv[])
- 
-   for (i = 0; i < NR; i++)
- pthread_join(thread[i], NULL);
-+#else
-+printf("libc context call APIs e.g. getcontext() are deprecated by 
posix\n");
-+#endif
- 
-   return 0;
- }
-diff --git a/memcheck/tests/linux/stack_changes.c 
b/memcheck/tests/linux/stack_changes.c
-index 7f97b90a5..a26cb4ae6 100644
 a/memcheck/tests/linux/stack_changes.c
-+++ b/memcheck/tests/linux/stack_changes.c
-@@ -10,6 +10,7 @@
- // This test is checking the libc context calls (setcontext, etc.) and
- // checks that Valgrind notices their stack changes properly.
- 
-+#ifdef __GLIBC__
- typedef  ucontext_t  mycontext;
- 
- mycontext ctx1, ctx2, oldc;
-@@ -51,9 +52,11 @@ int init_context(mycontext *uc)
- 
- return ret;
- }
-+#endif
- 
- int main(int argc, char **argv)
- {
-+#ifdef __GLIBC__
- int c1 = init_context();
- int c2 = init_context();
- 
-@@ -66,6 +69,8 @@ int main(int argc, char **argv)
- //free(ctx1.uc_stack.ss_sp);
- VALGRIND_STACK_DEREGISTER(c2);
- //free(ctx2.uc_stack.ss_sp);
--
-+#else
-+printf("libc context call APIs e.g. getcontext() are deprecated by 
posix\n");
-+#endif
- return 0;
- }
--- 
-2.17.1
-
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb 
b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
index 6dcd028075..0ebf08eb28 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
@@ -25,7 +25,6 @@ SRC_URI = 
"https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2 \
file://valgrind-make-ld-XXX.so-strlen-intercept-optional.patch \

file://0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch \
file://0001-sigqueue-Rename-_sifields-to-__si_fields-on-musl.patch \
-   file://0002-context-APIs-are-not-available-on-musl.patch \
file://0003-correct-include-directive-path-for-config.h.patch \
file://0001-fix-opcode-not-supported-on-mips32-linux.patch \

file://0001-Make-local-functions-static-to-avoid-assembler-error.patch \
-- 
2.42.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#190370): 
https://lists.openembedded.org/g/openembedded-core/message/190370
Mute This Topic: https://lists.openembedded.org/mt/102477900/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFC 5/5] valgrind: drop Make-local-function-static patch

2023-11-08 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

Drop: 0001-Make-local-functions-static-to-avoid-assembler-error.patch
since this was fixed upstream by commit:
   d6da48fe5 mips: use local labels for do_acasW()
Confirmed with:
   MACHINE=qemumips TCLIBC=musl bitbake valgrind

Signed-off-by: Randy MacLeod 
---
 ...ions-static-to-avoid-assembler-error.patch | 182 --
 .../valgrind/valgrind_3.22.0.bb   |   1 -
 2 files changed, 183 deletions(-)
 delete mode 100644 
meta/recipes-devtools/valgrind/valgrind/0001-Make-local-functions-static-to-avoid-assembler-error.patch

diff --git 
a/meta/recipes-devtools/valgrind/valgrind/0001-Make-local-functions-static-to-avoid-assembler-error.patch
 
b/meta/recipes-devtools/valgrind/valgrind/0001-Make-local-functions-static-to-avoid-assembler-error.patch
deleted file mode 100644
index 8d2ca5733e..00
--- 
a/meta/recipes-devtools/valgrind/valgrind/0001-Make-local-functions-static-to-avoid-assembler-error.patch
+++ /dev/null
@@ -1,182 +0,0 @@
-From 2155c1b2cf00e744e280c493eb74bf457dfcc3b1 Mon Sep 17 00:00:00 2001
-From: Randy MacLeod 
-Date: Sun, 21 Oct 2018 15:09:31 -0400
-Subject: [PATCH] Make local functions static to avoid assembler error
-
-Avoid mips32 x-compiler warnings such as:
-
-| ../../../valgrind-3.14.0/helgrind/tests/annotate_hbefore.c:360:6: warning: 
no previous prototype for 'do_signal' [-Wmissing-prototypes]
-|  void do_signal ( UWord* w )
-|   ^
-
-by making functions and global variables that are file scope be static
-and more importantly also avoid an assembler error:
-
-/tmp/cce22iiw.s: Assembler messages:
-/tmp/cce22iiw.s:446: Error: symbol `exit_0' is already defined
-/tmp/cce22iiw.s:448: Error: symbol `exit' is already defined
-/tmp/cce22iiw.s:915: Error: symbol `exit_0' is already defined
-/tmp/cce22iiw.s:917: Error: symbol `exit' is already defined
-
-Upstream-Status: Submitted https://bugs.kde.org/show_bug.cgi?id=400164
-
-Signed-off-by: Randy MacLeod 

- helgrind/tests/annotate_hbefore.c | 34 +++
- 1 file changed, 17 insertions(+), 17 deletions(-)
-
-diff --git a/helgrind/tests/annotate_hbefore.c 
b/helgrind/tests/annotate_hbefore.c
-index e311714f7..f55514e45 100644
 a/helgrind/tests/annotate_hbefore.c
-+++ b/helgrind/tests/annotate_hbefore.c
-@@ -24,7 +24,7 @@ typedef  unsigned long int  UWord;
- 
- // ppc64
- /* return 1 if success, 0 if failure */
--UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
-+static UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- {
-   UWord old, success;
- 
-@@ -57,7 +57,7 @@ UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- 
- // ppc32
- /* return 1 if success, 0 if failure */
--UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
-+static UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- {
-   UWord old, success;
- 
-@@ -90,7 +90,7 @@ UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- 
- // amd64
- /* return 1 if success, 0 if failure */
--UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
-+static UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- {
-UWord block[4] = { (UWord)addr, expected, nyu, 2 };
-__asm__ __volatile__(
-@@ -113,7 +113,7 @@ UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- 
- // x86
- /* return 1 if success, 0 if failure */
--UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
-+static UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- {
-UWord block[4] = { (UWord)addr, expected, nyu, 2 };
-__asm__ __volatile__(
-@@ -138,7 +138,7 @@ UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- 
- // arm
- /* return 1 if success, 0 if failure */
--UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
-+static UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- {
-   UWord old, success;
-   UWord block[2] = { (UWord)addr, nyu };
-@@ -171,7 +171,7 @@ UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- 
- // arm64
- /* return 1 if success, 0 if failure */
--UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
-+static UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- {
-   UWord old, success;
-   UWord block[2] = { (UWord)addr, nyu };
-@@ -204,7 +204,7 @@ UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- 
- // s390x
- /* return 1 if success, 0 if failure */
--UWord do_acasW(UWord* addr, UWord expected, UWord nyu )
-+static UWord do_acasW(UWord* addr, UWord expected, UWord nyu )
- {
-int cc;
- 
-@@ -223,7 +223,7 @@ UWord do_acasW(UWord* addr, UWord expected, UWord nyu )
- 
- // mips32
- /* return 1 if success, 0 if failure */
--UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
-+static UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- {
-   UWord success;
-   UWord block[3] = { (UWord)addr, nyu, expected};
-@@ -256,7 +256,7 @@ UWord do_acasW ( UWord* addr, UWord expected, UWord nyu )
- 
- // mips64
- /* return 1 if success, 0 if failure */
--UWord do_acasW ( UWord* addr, 

[OE-core] [RFC 2/5] valgrind: update from 3.21.0 to 3.22.0

2023-11-08 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

Full release notes: https://valgrind.org/docs/manual/dist.news.html

In summary, there is a new configure option: --with-gdbscripts-dir
that lets you install the gdb valgrind python monitor scripts in a specific 
location.
It's not used in the valgrind recipe yet. Also, there were a few Memcheck and 
Cachegrind
improvements made and many bugs fixed.

The update required removing the patch:
   0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch
as it's dealt with by these commits:
   f7e4bb4af Bug 382034 - Testcases build fixes for musl
   306232d40 musl: another fix for building testcases
as described on: https://bugs.kde.org/show_bug.cgi?id=382034

Ptest Resutls for qemux86-64/kvm

glibc:
=== Test Summary ===
TOTAL: 792
PASSED: 759
FAILED: 14
SKIPPED: 19

musl:
=== Test Summary ===
TOTAL: 792
PASSED: 559
FAILED: 211
SKIPPED: 22

Signed-off-by: Randy MacLeod 
---
 ...inux-seg_override.c-add-missing-incl.patch | 30 ---
 ...{valgrind_3.21.0.bb => valgrind_3.22.0.bb} |  3 +-
 2 files changed, 1 insertion(+), 32 deletions(-)
 delete mode 100644 
meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch
 rename meta/recipes-devtools/valgrind/{valgrind_3.21.0.bb => 
valgrind_3.22.0.bb} (98%)

diff --git 
a/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch
 
b/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch
deleted file mode 100644
index 5e36c28523..00
--- 
a/meta/recipes-devtools/valgrind/valgrind/0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-From 978d9ed7f857f2cdcd2a8632f3c2feb56b99c825 Mon Sep 17 00:00:00 2001
-From: Alexander Kanavin 
-Date: Mon, 8 May 2023 11:56:35 +0200
-Subject: [PATCH] none/tests/x86-linux/seg_override.c: add missing include for
- musl builds
-
-Otherwise SYS_modify_ldt is undefined.
-
-Upstream-Status: Submitted [https://bugs.kde.org/show_bug.cgi?id=382034]
-Signed-off-by: Alexander Kanavin 
-

- none/tests/x86-linux/seg_override.c | 4 
- 1 file changed, 4 insertions(+)
-
-diff --git a/none/tests/x86-linux/seg_override.c 
b/none/tests/x86-linux/seg_override.c
-index ca8fbfe..4ef4394 100644
 a/none/tests/x86-linux/seg_override.c
-+++ b/none/tests/x86-linux/seg_override.c
-@@ -3,6 +3,10 @@
- #include 
- #include 
- #include "../../../config.h"
-+#if defined(MUSL_LIBC)
-+#include 
-+#include 
-+#endif
- 
- 
- /* Stuff from Wine. */
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb 
b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
similarity index 98%
rename from meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
rename to meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
index a2feda6aae..6dcd028075 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
@@ -36,9 +36,8 @@ SRC_URI = 
"https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2 \

file://0001-none-tests-fdleak_cmsg.stderr.exp-adjust-tmp-paths.patch \
file://0001-memcheck-tests-Fix-timerfd-syscall-test.patch \
file://0001-docs-Disable-manual-validation.patch \
-   
file://0001-none-tests-x86-linux-seg_override.c-add-missing-incl.patch \
"
-SRC_URI[sha256sum] = 
"10ce1618bb3e33fad16eb79552b0a3e1211762448a0d7fce11c8a6243b9ac971"
+SRC_URI[sha256sum] = 
"c811db5add2c5f729944caf47c4e7a65dcaabb9461e472b578765dd7bf6d2d4c"
 UPSTREAM_CHECK_REGEX = "valgrind-(?P\d+(\.\d+)+)\.tar"
 
 COMPATIBLE_HOST = '(i.86|x86_64|arm|aarch64|mips|powerpc|powerpc64).*-linux'
-- 
2.42.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#190369): 
https://lists.openembedded.org/g/openembedded-core/message/190369
Mute This Topic: https://lists.openembedded.org/mt/102477899/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFC 1/5] valgrind: make ptest depend on all components

2023-11-08 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

When the helper scripts were split into separate packages, they
weren't added as ptest dependencies. Fix that.

Signed-off-by: Randy MacLeod 
---
 meta/recipes-devtools/valgrind/valgrind_3.21.0.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb 
b/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
index 68ab319a1b..a2feda6aae 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.21.0.bb
@@ -139,7 +139,9 @@ RDEPENDS:${PN}-ptest += " bash coreutils curl file \
perl-module-overloading perl-module-cwd perl-module-ipc-open3 \
perl-module-carp perl-module-symbol \
procps sed ${PN}-dbg ${PN}-src ${TCLIBC}-src gcc-runtime-dbg \
-   util-linux-taskset"
+   util-linux-taskset \
+   ${PN}-cachegrind ${PN}-massif ${PN}-callgrind \
+"
 RDEPENDS:${PN}-ptest:append:libc-glibc = " glibc-utils glibc-gconv-utf-32"
 
 # One of the tests contains a bogus interpreter path on purpose.
-- 
2.42.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#190367): 
https://lists.openembedded.org/g/openembedded-core/message/190367
Mute This Topic: https://lists.openembedded.org/mt/102477896/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFC 4/5] valgrind: drop mips32 opcode patch

2023-11-08 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

Drop: 0001-fix-opcode-not-supported-on-mips32-linux.patch

The resolved (works for me) upstream defect rejected this patch:
   https://bugs.kde.org/show_bug.cgi?id=396905
and suggested using CFLAGS="-mips32". With this patch dropped, the
qemumips build succeeds perhaps due to using -march=mips32r2

Signed-off-by: Randy MacLeod 
---
 ...opcode-not-supported-on-mips32-linux.patch | 82 ---
 .../valgrind/valgrind_3.22.0.bb   |  1 -
 2 files changed, 83 deletions(-)
 delete mode 100644 
meta/recipes-devtools/valgrind/valgrind/0001-fix-opcode-not-supported-on-mips32-linux.patch

diff --git 
a/meta/recipes-devtools/valgrind/valgrind/0001-fix-opcode-not-supported-on-mips32-linux.patch
 
b/meta/recipes-devtools/valgrind/valgrind/0001-fix-opcode-not-supported-on-mips32-linux.patch
deleted file mode 100644
index 39b624d9f6..00
--- 
a/meta/recipes-devtools/valgrind/valgrind/0001-fix-opcode-not-supported-on-mips32-linux.patch
+++ /dev/null
@@ -1,82 +0,0 @@
-From fb5362f205b37c5060fcd764a7ed393abe4f2f3d Mon Sep 17 00:00:00 2001
-From: Hongxu Jia 
-Date: Fri, 27 Jul 2018 17:39:37 +0800
-Subject: [PATCH 1/2] fix opcode not supported on mips32-linux
-
-While build tests(`make check') on mips32-linux, there are
-serial failures such as:
-[snip]
-| mips-wrsmllib32-linux-gcc  -meb -mabi=32 -mhard-float -c
--o atomic_incs-atomic_incs.o `test -f 'atomic_incs.c' || echo
-'../../../valgrind-3.13.0/memcheck/tests/'`atomic_incs.c
-| /tmp/ccqrmINN.s: Assembler messages:
-| /tmp/ccqrmINN.s:247: Error: opcode not supported on this
-processor: mips1 (mips1) `ll $t3,0($t1)'
-| /tmp/ccqrmINN.s:249: Error: opcode not supported on this
-processor: mips1 (mips1) `sc $t3,0($t1)'
-[snip]
-
-Since the following commit applied, it defines CLFAGS for mips32,
-but missed to pass them to tests which caused the above failure
-...
-3e344c57f Merge in a port for mips32-linux
-...
-
-Upstream-Status: Submitted [https://bugs.kde.org/show_bug.cgi?id=396905]
-Signed-off-by: Hongxu Jia 

- helgrind/tests/Makefile.am| 5 +
- memcheck/tests/Makefile.am| 5 +
- none/tests/mips32/Makefile.am | 4 
- 3 files changed, 14 insertions(+)
-
-diff --git a/helgrind/tests/Makefile.am b/helgrind/tests/Makefile.am
-index ad1af191a..6209d35a7 100644
 a/helgrind/tests/Makefile.am
-+++ b/helgrind/tests/Makefile.am
-@@ -214,6 +214,11 @@ check_PROGRAMS += annotate_rwlock
- endif
- 
- AM_CFLAGS   += $(AM_FLAG_M3264_PRI)
-+
-+if VGCONF_PLATFORMS_INCLUDE_MIPS32_LINUX
-+AM_CFLAGS   += $(AM_CFLAGS_MIPS32_LINUX)
-+endif
-+
- AM_CXXFLAGS += $(AM_FLAG_M3264_PRI)
- 
- LDADD = -lpthread
-diff --git a/memcheck/tests/Makefile.am b/memcheck/tests/Makefile.am
-index 84e49405f..aff861a32 100644
 a/memcheck/tests/Makefile.am
-+++ b/memcheck/tests/Makefile.am
-@@ -443,6 +443,11 @@ check_PROGRAMS += reach_thread_register
- endif
- 
- AM_CFLAGS   += $(AM_FLAG_M3264_PRI)
-+
-+if VGCONF_PLATFORMS_INCLUDE_MIPS32_LINUX
-+AM_CFLAGS   += $(AM_CFLAGS_MIPS32_LINUX)
-+endif
-+
- AM_CXXFLAGS += $(AM_FLAG_M3264_PRI)
- 
- if VGCONF_PLATFORMS_INCLUDE_ARM_LINUX
-diff --git a/none/tests/mips32/Makefile.am b/none/tests/mips32/Makefile.am
-index d11591d45..602cd26f6 100644
 a/none/tests/mips32/Makefile.am
-+++ b/none/tests/mips32/Makefile.am
-@@ -99,6 +99,10 @@ check_PROGRAMS = \
-   round_fpu64 \
-   fpu_branches
- 
-+if VGCONF_PLATFORMS_INCLUDE_MIPS32_LINUX
-+AM_CFLAGS   += $(AM_CFLAGS_MIPS32_LINUX)
-+endif
-+
- AM_CFLAGS+= @FLAG_M32@
- AM_CXXFLAGS  += @FLAG_M32@
- AM_CCASFLAGS += @FLAG_M32@
--- 
-2.17.1
-
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb 
b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
index 0ebf08eb28..c3c1bc0b2c 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.22.0.bb
@@ -26,7 +26,6 @@ SRC_URI = 
"https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2 \

file://0001-makefiles-Drop-setting-mcpu-to-cortex-a8-on-arm-arch.patch \
file://0001-sigqueue-Rename-_sifields-to-__si_fields-on-musl.patch \
file://0003-correct-include-directive-path-for-config.h.patch \
-   file://0001-fix-opcode-not-supported-on-mips32-linux.patch \

file://0001-Make-local-functions-static-to-avoid-assembler-error.patch \
file://0001-Return-a-valid-exit_code-from-vg_regtest.patch \
file://0001-valgrind-filter_xml_frames-do-not-filter-usr.patch \
-- 
2.42.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#190368): 
https://lists.openembedded.org/g/openembedded-core/message/190368
Mute This Topic: https://lists.openembedded.org/mt/102477898/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] strace: upgrade 6.5 -> 6.6

2023-10-31 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

Update the COPYING checksum; only the copyright date changed.

Noteworthy changes in strace 6.6 (2023-10-31)
=

* Improvements
  * Implemented --kill-on-exit option that instructs the tracer to set
PTRACE_O_EXITKILL option to all tracee processes and not to detach them
on cleanup so they will not be left running after the tracer exit.
  * Implemented automatic activation of --kill-on-exit option when
--seccomp-bpf is enabled and -p/--attach option is not used.
  * Implemented decoding of map_shadow_stack syscall.
  * Implemented decoding of FSCONFIG_CMD_CREATE_EXCL fsconfig command.
  * Implemented decoding of IFLA_BRPORT_BACKUP_NHID netlink attribute.
  * Implemented decoding of SECCOMP_IOCTL_NOTIF_SET_FLAGS ioctl.
  * Implemented decoding of UFFDIO_CONTINUE, UFFDIO_POISON, and
UFFDIO_WRITEPROTECT ioctls.
  * Updated lists of ARCH_*, BPF_*, DEVCONF_*, IORING_*, KEXEC_*, MAP_*, NT_*,
PTRACE_*, QFMT_*, SEGV_*, UFFD_*, V4L2_*, and XDP_* constants.
  * Updated lists of ioctl commands from Linux 6.6.

ptest-runner results on qemux86-64/kvm with qemuparms="-m 1024 -smp 4":

Testsuite summary for strace 6.6



Signed-off-by: Randy MacLeod 
---
 .../strace/tests-fix-so_peerpidfd-test.patch  | 32 ---
 .../strace/{strace_6.5.bb => strace_6.6.bb}   |  5 ++-
 2 files changed, 2 insertions(+), 35 deletions(-)
 delete mode 100644 
meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch
 rename meta/recipes-devtools/strace/{strace_6.5.bb => strace_6.6.bb} (90%)

diff --git 
a/meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch 
b/meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch
deleted file mode 100644
index 62f73d3643..00
--- a/meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-From 44cf51a38cce1e90bb6c22208fa45f95cdcc8f5d Mon Sep 17 00:00:00 2001
-From: "Dmitry V. Levin" 
-Date: Sat, 14 Oct 2023 08:00:00 +
-Subject: [PATCH] tests: fix so_peerpidfd test
-
-* tests/so_peerpidfd.c (print_pidfd): Fix expected output.
-
-Fixes: v6.5~38 "net: implement decoding of SO_PEERPIDFD socket option"
-Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2243631
-
-Upstream-Status: Backport 
[https://github.com/strace/strace/commit/44cf51a38cce1e90bb6c22208fa45f95cdcc8f5d]
-Signed-off-by: Randy MacLeod 

- tests/so_peerpidfd.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/tests/so_peerpidfd.c b/tests/so_peerpidfd.c
-index 33988edec..dfad1c434 100644
 a/tests/so_peerpidfd.c
-+++ b/tests/so_peerpidfd.c
-@@ -37,7 +37,7 @@ print_pidfd(int *p)
-   if (rc < 0)
-   printf("%p", p);
-   else
--  printf("%d%s", *p, pidfd_suffix);
-+  printf("[%d%s]", *p, pidfd_suffix);
- }
- 
- static void
--- 
-2.34.1
-
diff --git a/meta/recipes-devtools/strace/strace_6.5.bb 
b/meta/recipes-devtools/strace/strace_6.6.bb
similarity index 90%
rename from meta/recipes-devtools/strace/strace_6.5.bb
rename to meta/recipes-devtools/strace/strace_6.6.bb
index d1536b1e8d..a3de7941cf 100644
--- a/meta/recipes-devtools/strace/strace_6.5.bb
+++ b/meta/recipes-devtools/strace/strace_6.6.bb
@@ -3,7 +3,7 @@ HOMEPAGE = "http://strace.io;
 DESCRIPTION = "strace is a diagnostic, debugging and instructional userspace 
utility for Linux. It is used to monitor and tamper with interactions between 
processes and the Linux kernel, which include system calls, signal deliveries, 
and changes of process state."
 SECTION = "console/utils"
 LICENSE = "LGPL-2.1-or-later & GPL-2.0-or-later"
-LIC_FILES_CHKSUM = "file://COPYING;md5=59a33f0a3e6122d67c0b3befccbdaa6b"
+LIC_FILES_CHKSUM = "file://COPYING;md5=63c8c3eb5c71b4362edac1397f40bdc7"
 
 SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
file://update-gawk-paths.patch \
@@ -14,9 +14,8 @@ SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
file://skip-load.patch \

file://0001-configure-Use-autoconf-macro-to-detect-largefile-sup.patch \
file://0002-tests-Replace-off64_t-with-off_t.patch \
-   file://tests-fix-so_peerpidfd-test.patch \
"
-SRC_URI[sha256sum] = 
"dfb051702389e1979a151892b5901afc9e93bbc1c70d84c906ade3224ca91980"
+SRC_URI[sha256sum] = 
"421b4186c06b705163e64dc85f271ebdcf67660af8667283147d5e859fc8a96c"
 
 inherit autotools ptest
 
-- 
2.42.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#189892): 
https://lists.openembedded.org/g/openembedded-core/message/189892
Mute This Topic: https://lists.openembedded.org/mt/102310517/21656
Group Owner: 

Re: [OE-core] [PATCH] strace: backport fix for so_peerpidfd-test

2023-10-31 Thread Randy MacLeod via lists.openembedded.org

On 2023-10-31 7:47 p.m., Randy MacLeod via lists.openembedded.org wrote:

From: Randy MacLeod

Backport the fix for the so_peerpidfd-test:
44cf51a38 tests: fix so_peerpidfd test
and drop the patch that skipped that test.

Note that options-syntax.test failed with the default qemux86-64/kvm memory

size but works with 1024 MB.

../Randy



Signed-off-by: Randy MacLeod
---
  .../skip-test-so_peerpidfd.gen.test.patch | 25 ---
  .../strace/tests-fix-so_peerpidfd-test.patch  | 32 +++
  meta/recipes-devtools/strace/strace_6.5.bb|  2 +-
  3 files changed, 33 insertions(+), 26 deletions(-)
  delete mode 100644 
meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
  create mode 100644 
meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch

diff --git 
a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch 
b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
deleted file mode 100644
index 5c73e1f10e..00
--- a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
+++ /dev/null
@@ -1,25 +0,0 @@
-From 002d9f2512245536dfc8d62db429d97e2216ec3a Mon Sep 17 00:00:00 2001
-From: Randy MacLeod
-Date: Fri, 6 Oct 2023 12:08:23 -0700
-Subject: [PATCH] skip tests/so_peerpidfd.gen.test
-
-Upstream-Status: Inappropriate
-
-Signed-off-by: Randy MacLeod

- tests/so_peerpidfd.gen.test | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/tests/so_peerpidfd.gen.test b/tests/so_peerpidfd.gen.test
-index 64ad3a2..f89da9f 100755
 a/tests/so_peerpidfd.gen.test
-+++ b/tests/so_peerpidfd.gen.test
-@@ -1,4 +1,5 @@
- #!/bin/sh -efu
- # Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (so_peerpidfd 
--trace=getsockopt -y); do not edit.
- . "${srcdir=.}/init.sh"
-+skip_ "Test fails due to apparently trivial log format differences"
- run_strace_match_diff --trace=getsockopt -y
---
-2.39.0
-
diff --git 
a/meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch 
b/meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch
new file mode 100644
index 00..62f73d3643
--- /dev/null
+++ b/meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch
@@ -0,0 +1,32 @@
+From 44cf51a38cce1e90bb6c22208fa45f95cdcc8f5d Mon Sep 17 00:00:00 2001
+From: "Dmitry V. Levin"
+Date: Sat, 14 Oct 2023 08:00:00 +
+Subject: [PATCH] tests: fix so_peerpidfd test
+
+* tests/so_peerpidfd.c (print_pidfd): Fix expected output.
+
+Fixes: v6.5~38 "net: implement decoding of SO_PEERPIDFD socket option"
+Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=2243631
+
+Upstream-Status: Backport 
[https://github.com/strace/strace/commit/44cf51a38cce1e90bb6c22208fa45f95cdcc8f5d]
+Signed-off-by: Randy MacLeod
+---
+ tests/so_peerpidfd.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tests/so_peerpidfd.c b/tests/so_peerpidfd.c
+index 33988edec..dfad1c434 100644
+--- a/tests/so_peerpidfd.c
 b/tests/so_peerpidfd.c
+@@ -37,7 +37,7 @@ print_pidfd(int *p)
+   if (rc < 0)
+   printf("%p", p);
+   else
+-  printf("%d%s", *p, pidfd_suffix);
++  printf("[%d%s]", *p, pidfd_suffix);
+ }
+
+ static void
+--
+2.34.1
+
diff --git a/meta/recipes-devtools/strace/strace_6.5.bb 
b/meta/recipes-devtools/strace/strace_6.5.bb
index d6475e8db9..d1536b1e8d 100644
--- a/meta/recipes-devtools/strace/strace_6.5.bb
+++ b/meta/recipes-devtools/strace/strace_6.5.bb
@@ -14,7 +14,7 @@ SRC_URI ="https://strace.io/files/${PV}/strace-${PV}.tar.xz \ 
file://skip-load.patch \ 
file://0001-configure-Use-autoconf-macro-to-detect-largefile-sup.patch 
\ file://0002-tests-Replace-off64_t-with-off_t.patch \ - 
file://skip-test-so_peerpidfd.gen.test.patch \ + 
file://tests-fix-so_peerpidfd-test.patch \ "

  SRC_URI[sha256sum] = 
"dfb051702389e1979a151892b5901afc9e93bbc1c70d84c906ade3224ca91980"
  






--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#189891): 
https://lists.openembedded.org/g/openembedded-core/message/189891
Mute This Topic: https://lists.openembedded.org/mt/102309591/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] strace: backport fix for so_peerpidfd-test

2023-10-31 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

Backport the fix for the so_peerpidfd-test:
   44cf51a38 tests: fix so_peerpidfd test
and drop the patch that skipped that test.

Signed-off-by: Randy MacLeod 
---
 .../skip-test-so_peerpidfd.gen.test.patch | 25 ---
 .../strace/tests-fix-so_peerpidfd-test.patch  | 32 +++
 meta/recipes-devtools/strace/strace_6.5.bb|  2 +-
 3 files changed, 33 insertions(+), 26 deletions(-)
 delete mode 100644 
meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
 create mode 100644 
meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch

diff --git 
a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch 
b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
deleted file mode 100644
index 5c73e1f10e..00
--- a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
+++ /dev/null
@@ -1,25 +0,0 @@
-From 002d9f2512245536dfc8d62db429d97e2216ec3a Mon Sep 17 00:00:00 2001
-From: Randy MacLeod 
-Date: Fri, 6 Oct 2023 12:08:23 -0700
-Subject: [PATCH] skip tests/so_peerpidfd.gen.test
-
-Upstream-Status: Inappropriate
-
-Signed-off-by: Randy MacLeod 

- tests/so_peerpidfd.gen.test | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/tests/so_peerpidfd.gen.test b/tests/so_peerpidfd.gen.test
-index 64ad3a2..f89da9f 100755
 a/tests/so_peerpidfd.gen.test
-+++ b/tests/so_peerpidfd.gen.test
-@@ -1,4 +1,5 @@
- #!/bin/sh -efu
- # Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (so_peerpidfd 
--trace=getsockopt -y); do not edit.
- . "${srcdir=.}/init.sh"
-+skip_ "Test fails due to apparently trivial log format differences"
- run_strace_match_diff --trace=getsockopt -y
--- 
-2.39.0
-
diff --git 
a/meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch 
b/meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch
new file mode 100644
index 00..62f73d3643
--- /dev/null
+++ b/meta/recipes-devtools/strace/strace/tests-fix-so_peerpidfd-test.patch
@@ -0,0 +1,32 @@
+From 44cf51a38cce1e90bb6c22208fa45f95cdcc8f5d Mon Sep 17 00:00:00 2001
+From: "Dmitry V. Levin" 
+Date: Sat, 14 Oct 2023 08:00:00 +
+Subject: [PATCH] tests: fix so_peerpidfd test
+
+* tests/so_peerpidfd.c (print_pidfd): Fix expected output.
+
+Fixes: v6.5~38 "net: implement decoding of SO_PEERPIDFD socket option"
+Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2243631
+
+Upstream-Status: Backport 
[https://github.com/strace/strace/commit/44cf51a38cce1e90bb6c22208fa45f95cdcc8f5d]
+Signed-off-by: Randy MacLeod 
+---
+ tests/so_peerpidfd.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tests/so_peerpidfd.c b/tests/so_peerpidfd.c
+index 33988edec..dfad1c434 100644
+--- a/tests/so_peerpidfd.c
 b/tests/so_peerpidfd.c
+@@ -37,7 +37,7 @@ print_pidfd(int *p)
+   if (rc < 0)
+   printf("%p", p);
+   else
+-  printf("%d%s", *p, pidfd_suffix);
++  printf("[%d%s]", *p, pidfd_suffix);
+ }
+ 
+ static void
+-- 
+2.34.1
+
diff --git a/meta/recipes-devtools/strace/strace_6.5.bb 
b/meta/recipes-devtools/strace/strace_6.5.bb
index d6475e8db9..d1536b1e8d 100644
--- a/meta/recipes-devtools/strace/strace_6.5.bb
+++ b/meta/recipes-devtools/strace/strace_6.5.bb
@@ -14,7 +14,7 @@ SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
file://skip-load.patch \

file://0001-configure-Use-autoconf-macro-to-detect-largefile-sup.patch \
file://0002-tests-Replace-off64_t-with-off_t.patch \
-   file://skip-test-so_peerpidfd.gen.test.patch \
+   file://tests-fix-so_peerpidfd-test.patch \
"
 SRC_URI[sha256sum] = 
"dfb051702389e1979a151892b5901afc9e93bbc1c70d84c906ade3224ca91980"
 
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#189890): 
https://lists.openembedded.org/g/openembedded-core/message/189890
Mute This Topic: https://lists.openembedded.org/mt/102309591/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [meta-oe][PATCH v2] volatile-binds: Calculate the name of the /var/lib service

2023-10-30 Thread Randy MacLeod via lists.openembedded.org

On 2023-10-28 4:17 a.m., Stéphane Veyret via lists.openembedded.org wrote:

Hello,

This patch and the previous one 
(https://lists.openembedded.org/g/openembedded-core/message/186778) 
have not been integrated yet. Have they been forgotten, should I do 
some modifications, or have they been definitly rejected ?


Hi Stephane,

The [meta-oe] prefix may have confused people anyway,
the two commits were merged this morning:

https://git.openembedded.org/openembedded-core/log/

https://git.openembedded.org/openembedded-core/commit/?id=66f0c2a1678cb69cf8d50372b0592c55e2dc3e3c

https://git.openembedded.org/openembedded-core/commit/?id=1ca031b77546056ca1994469b0f2e93ea2018edf

Thanks,

../Randy



Thanks.





--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#189822): 
https://lists.openembedded.org/g/openembedded-core/message/189822
Mute This Topic: https://lists.openembedded.org/mt/101015300/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe-core][kirkstone][PATCH 1/2] curl: fix CVE-2023-38545

2023-10-29 Thread Randy MacLeod via lists.openembedded.org

On 2023-10-29 5:49 a.m., Peter Marko via lists.openembedded.org wrote:

Gentle ping.
It would be great to have this in next kirkstone release which will be built in 
a week.

It's queued now:

https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/kirkstone-nut

Archana,

Can you be sure that you and co-workers are CC-ing Steve to make it 
easier for him

to notice the stable branch emails?

Thanks.

../Randy







--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#189779): 
https://lists.openembedded.org/g/openembedded-core/message/189779
Mute This Topic: https://lists.openembedded.org/mt/101936671/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe-core][kirkstone][PATCH 1/1] linux-firmware: upgrade 20230625 -> 20230804

2023-10-23 Thread Randy MacLeod via lists.openembedded.org

On 2023-10-20 12:25 a.m., Meenali Gupta via lists.openembedded.org wrote:

License-Update: additional firmwares

upgrade include fix for CVE-2023-20569 CVE-2022-40982 CVE-2023-20593

Changelog:
   
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/

References:
   https://nvd.nist.gov/vuln/detail/CVE-2023-20569
   https://nvd.nist.gov/vuln/detail/CVE-2022-40982
   https://nvd.nist.gov/vuln/detail/CVE-2023-20593

Signed-off-by: Meenali Gupta


To save others from checking:

Mickledore and master already have 20230804

https://git.openembedded.org/openembedded-core/tree/meta/recipes-kernel/linux-firmware/linux-firmware_20230804.bb?h=mickledore

Meenali,

Next time, it would be good to include some indication of that in your 
commit log or even as a reply to your own email

to save other people from having to check.

And as you may know, this is already merged to Steve's -nut branch and 
out for review as the latest batch of updates.

https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/kirkstone-nut

so no need to resend.

../Randy



---
  ...{linux-firmware_20230625.bb => linux-firmware_20230804.bb} | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
  rename meta/recipes-kernel/linux-firmware/{linux-firmware_20230625.bb => 
linux-firmware_20230804.bb} (99%)

diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20230625.bb 
b/meta/recipes-kernel/linux-firmware/linux-firmware_20230804.bb
similarity index 99%
rename from meta/recipes-kernel/linux-firmware/linux-firmware_20230625.bb
rename to meta/recipes-kernel/linux-firmware/linux-firmware_20230804.bb
index 6765226b9d..4defab434d 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_20230625.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20230804.bb
@@ -134,7 +134,7 @@ LIC_FILES_CHKSUM 
="file://LICENCE.Abilis;md5=b5ee3f410780e56711ad48eadc22b8bc \ "
  # WHENCE checksum is defined separately to ease overriding it if
  # class-devupstream is selected.
-WHENCE_CHKSUM  = "57bf874056926f12aec2405d3fc390d9"
+WHENCE_CHKSUM  = "41f9a48bf27971b126a36f9344594dcd"
  
  # These are not common licenses, set NO_GENERIC_LICENSE for them

  # so that the license files will be copied from fetched source
@@ -212,7 +212,7 @@ SRC_URI:class-devupstream = 
"git://git.kernel.org/pub/scm/linux/kernel/git/firmw
  # Pin this to the 20220509 release, override this in local.conf
  SRCREV:class-devupstream ?= "b19cbdca78ab2adfd210c91be15a22568e8b8cae"
  
-SRC_URI[sha256sum] = "87597111c0d4b71b31e53cb85a92c386921b84c825a402db8c82e0e86015500d"

+SRC_URI[sha256sum] = 
"88d46c543847ee3b03404d4941d91c92974690ee1f6fdcbee9cef3e5f97db688"
  
  inherit allarch
  






--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#189634): 
https://lists.openembedded.org/g/openembedded-core/message/189634
Mute This Topic: https://lists.openembedded.org/mt/102075429/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH V3] strace: skip so_peerpidfd test

2023-10-06 Thread Randy MacLeod via lists.openembedded.org

On 2023-10-06 5:27 p.m., Randy MacLeod via lists.openembedded.org wrote:

From: Randy MacLeod

The so_peerpidfd test is failing in every linux-yocto-6.5 ptest run
due to a difference of square brackets in part of the log file.

Skip the failing test until the difference is understood and fixed.

Signed-off-by: Randy MacLeod
---
  .../skip-test-so_peerpidfd.gen.test.patch | 25 +++
  meta/recipes-devtools/strace/strace_6.5.bb|  1 +
  2 files changed, 26 insertions(+)
  create mode 100644 
meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch

diff --git 
a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch 
b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
new file mode 100644
index 00..76f93ab613
--- /dev/null
+++ b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
@@ -0,0 +1,25 @@
+From 002d9f2512245536dfc8d62db429d97e2216ec3a Mon Sep 17 00:00:00 2001
+From: Randy MacLeod
+Date: Fri, 6 Oct 2023 12:08:23 -0700
+Subject: [PATCH] skip tests/so_peerpidfd.gen.test
+
+Upstream-Status: Pending


I updated the commit log but forgot to git add the changes I made to the 
patch!

Sigh.


Richard took pity on me and said that he'd fixed the Upstream-Status 
before merging.


Happy Canadian Thanksgiving weekend everyone,

../Randy


+
+Signed-off-by: Randy MacLeod
+---
+ tests/so_peerpidfd.gen.test | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tests/so_peerpidfd.gen.test b/tests/so_peerpidfd.gen.test
+index 64ad3a2..f89da9f 100755
+--- a/tests/so_peerpidfd.gen.test
 b/tests/so_peerpidfd.gen.test
+@@ -1,4 +1,5 @@
+ #!/bin/sh -efu
+ # Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (so_peerpidfd 
--trace=getsockopt -y); do not edit.
+ . "${srcdir=.}/init.sh"
++skip_ "Test fails due to apparently trivial log format differences"
+ run_strace_match_diff --trace=getsockopt -y
+--
+2.39.0
+
diff --git a/meta/recipes-devtools/strace/strace_6.5.bb 
b/meta/recipes-devtools/strace/strace_6.5.bb
index 8f90c35925..d6475e8db9 100644
--- a/meta/recipes-devtools/strace/strace_6.5.bb
+++ b/meta/recipes-devtools/strace/strace_6.5.bb
@@ -14,6 +14,7 @@ SRC_URI ="https://strace.io/files/${PV}/strace-${PV}.tar.xz \ 
file://skip-load.patch \ 
file://0001-configure-Use-autoconf-macro-to-detect-largefile-sup.patch 
\ file://0002-tests-Replace-off64_t-with-off_t.patch \ + 
file://skip-test-so_peerpidfd.gen.test.patch \ "

  SRC_URI[sha256sum] = 
"dfb051702389e1979a151892b5901afc9e93bbc1c70d84c906ade3224ca91980"
  






--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188792): 
https://lists.openembedded.org/g/openembedded-core/message/188792
Mute This Topic: https://lists.openembedded.org/mt/101807172/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH V3] strace: skip so_peerpidfd test

2023-10-06 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

The so_peerpidfd test is failing in every linux-yocto-6.5 ptest run
due to a difference of square brackets in part of the log file.

Skip the failing test until the difference is understood and fixed.

Signed-off-by: Randy MacLeod 
---
 .../skip-test-so_peerpidfd.gen.test.patch | 25 +++
 meta/recipes-devtools/strace/strace_6.5.bb|  1 +
 2 files changed, 26 insertions(+)
 create mode 100644 
meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch

diff --git 
a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch 
b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
new file mode 100644
index 00..76f93ab613
--- /dev/null
+++ b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
@@ -0,0 +1,25 @@
+From 002d9f2512245536dfc8d62db429d97e2216ec3a Mon Sep 17 00:00:00 2001
+From: Randy MacLeod 
+Date: Fri, 6 Oct 2023 12:08:23 -0700
+Subject: [PATCH] skip tests/so_peerpidfd.gen.test
+
+Upstream-Status: Pending
+
+Signed-off-by: Randy MacLeod 
+---
+ tests/so_peerpidfd.gen.test | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tests/so_peerpidfd.gen.test b/tests/so_peerpidfd.gen.test
+index 64ad3a2..f89da9f 100755
+--- a/tests/so_peerpidfd.gen.test
 b/tests/so_peerpidfd.gen.test
+@@ -1,4 +1,5 @@
+ #!/bin/sh -efu
+ # Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (so_peerpidfd 
--trace=getsockopt -y); do not edit.
+ . "${srcdir=.}/init.sh"
++skip_ "Test fails due to apparently trivial log format differences"
+ run_strace_match_diff --trace=getsockopt -y
+-- 
+2.39.0
+
diff --git a/meta/recipes-devtools/strace/strace_6.5.bb 
b/meta/recipes-devtools/strace/strace_6.5.bb
index 8f90c35925..d6475e8db9 100644
--- a/meta/recipes-devtools/strace/strace_6.5.bb
+++ b/meta/recipes-devtools/strace/strace_6.5.bb
@@ -14,6 +14,7 @@ SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
file://skip-load.patch \

file://0001-configure-Use-autoconf-macro-to-detect-largefile-sup.patch \
file://0002-tests-Replace-off64_t-with-off_t.patch \
+   file://skip-test-so_peerpidfd.gen.test.patch \
"
 SRC_URI[sha256sum] = 
"dfb051702389e1979a151892b5901afc9e93bbc1c70d84c906ade3224ca91980"
 
-- 
2.39.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188788): 
https://lists.openembedded.org/g/openembedded-core/message/188788
Mute This Topic: https://lists.openembedded.org/mt/101807172/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH V2] strace: skip so_peerpidfd test

2023-10-06 Thread Randy MacLeod via lists.openembedded.org

On 2023-10-06 5:14 p.m., Randy MacLeod via lists.openembedded.org wrote:

From: Randy MacLeod

The so_peerpidfd test is failing due to a difference of square brackets
in part of the log file. Skip the failing test until the difference is
understood and fixed.

Signed-off-by: Randy MacLeod
---
  .../skip-test-so_peerpidfd.gen.test.patch | 25 +++
  meta/recipes-devtools/strace/strace_6.5.bb|  1 +
  2 files changed, 26 insertions(+)
  create mode 100644 
meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch

diff --git 
a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch 
b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
new file mode 100644
index 00..76f93ab613
--- /dev/null
+++ b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
@@ -0,0 +1,25 @@
+From 002d9f2512245536dfc8d62db429d97e2216ec3a Mon Sep 17 00:00:00 2001
+From: Randy MacLeod
+Date: Fri, 6 Oct 2023 12:08:23 -0700
+Subject: [PATCH] skip tests/so_peerpidfd.gen.test
+
+Upstream-Status: Pending


Sigh, the status should be Inappropriate, v3 coming!

I do plan to fix this upstream but this work-around is inappropriate for 
upstream.


../Randy


+
+Signed-off-by: Randy MacLeod
+---
+ tests/so_peerpidfd.gen.test | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tests/so_peerpidfd.gen.test b/tests/so_peerpidfd.gen.test
+index 64ad3a2..f89da9f 100755
+--- a/tests/so_peerpidfd.gen.test
 b/tests/so_peerpidfd.gen.test
+@@ -1,4 +1,5 @@
+ #!/bin/sh -efu
+ # Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (so_peerpidfd 
--trace=getsockopt -y); do not edit.
+ . "${srcdir=.}/init.sh"
++skip_ "Test fails due to apparently trivial log format differences"
+ run_strace_match_diff --trace=getsockopt -y
+--
+2.39.0
+
diff --git a/meta/recipes-devtools/strace/strace_6.5.bb 
b/meta/recipes-devtools/strace/strace_6.5.bb
index 8f90c35925..d6475e8db9 100644
--- a/meta/recipes-devtools/strace/strace_6.5.bb
+++ b/meta/recipes-devtools/strace/strace_6.5.bb
@@ -14,6 +14,7 @@ SRC_URI ="https://strace.io/files/${PV}/strace-${PV}.tar.xz \ 
file://skip-load.patch \ 
file://0001-configure-Use-autoconf-macro-to-detect-largefile-sup.patch 
\ file://0002-tests-Replace-off64_t-with-off_t.patch \ + 
file://skip-test-so_peerpidfd.gen.test.patch \ "

  SRC_URI[sha256sum] = 
"dfb051702389e1979a151892b5901afc9e93bbc1c70d84c906ade3224ca91980"
  






--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188787): 
https://lists.openembedded.org/g/openembedded-core/message/188787
Mute This Topic: https://lists.openembedded.org/mt/101806877/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH V2] strace: skip so_peerpidfd test

2023-10-06 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

The so_peerpidfd test is failing due to a difference of square brackets
in part of the log file. Skip the failing test until the difference is
understood and fixed.

Signed-off-by: Randy MacLeod 
---
 .../skip-test-so_peerpidfd.gen.test.patch | 25 +++
 meta/recipes-devtools/strace/strace_6.5.bb|  1 +
 2 files changed, 26 insertions(+)
 create mode 100644 
meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch

diff --git 
a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch 
b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
new file mode 100644
index 00..76f93ab613
--- /dev/null
+++ b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
@@ -0,0 +1,25 @@
+From 002d9f2512245536dfc8d62db429d97e2216ec3a Mon Sep 17 00:00:00 2001
+From: Randy MacLeod 
+Date: Fri, 6 Oct 2023 12:08:23 -0700
+Subject: [PATCH] skip tests/so_peerpidfd.gen.test
+
+Upstream-Status: Pending
+
+Signed-off-by: Randy MacLeod 
+---
+ tests/so_peerpidfd.gen.test | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tests/so_peerpidfd.gen.test b/tests/so_peerpidfd.gen.test
+index 64ad3a2..f89da9f 100755
+--- a/tests/so_peerpidfd.gen.test
 b/tests/so_peerpidfd.gen.test
+@@ -1,4 +1,5 @@
+ #!/bin/sh -efu
+ # Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (so_peerpidfd 
--trace=getsockopt -y); do not edit.
+ . "${srcdir=.}/init.sh"
++skip_ "Test fails due to apparently trivial log format differences"
+ run_strace_match_diff --trace=getsockopt -y
+-- 
+2.39.0
+
diff --git a/meta/recipes-devtools/strace/strace_6.5.bb 
b/meta/recipes-devtools/strace/strace_6.5.bb
index 8f90c35925..d6475e8db9 100644
--- a/meta/recipes-devtools/strace/strace_6.5.bb
+++ b/meta/recipes-devtools/strace/strace_6.5.bb
@@ -14,6 +14,7 @@ SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
file://skip-load.patch \

file://0001-configure-Use-autoconf-macro-to-detect-largefile-sup.patch \
file://0002-tests-Replace-off64_t-with-off_t.patch \
+   file://skip-test-so_peerpidfd.gen.test.patch \
"
 SRC_URI[sha256sum] = 
"dfb051702389e1979a151892b5901afc9e93bbc1c70d84c906ade3224ca91980"
 
-- 
2.39.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188786): 
https://lists.openembedded.org/g/openembedded-core/message/188786
Mute This Topic: https://lists.openembedded.org/mt/101806877/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] strace: skip so_peerpidfd test

2023-10-06 Thread Randy MacLeod via lists.openembedded.org

On 2023-10-06 4:06 p.m., Randy MacLeod via lists.openembedded.org wrote:

From: Randy MacLeod

The so_peerpidfd test is failing due to a difference of square brackets
in part of the log file. Skip the failing test until the difference is
understood and fixed.

Signed-off-by: Randy MacLeod
---
  .../skip-test-so_peerpidfd.gen.test.patch | 25 +++
  meta/recipes-devtools/strace/strace_6.5.bb|  2 ++
  2 files changed, 27 insertions(+)
  create mode 100644 
meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch

diff --git 
a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch 
b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
new file mode 100644
index 00..76f93ab613
--- /dev/null
+++ b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
@@ -0,0 +1,25 @@
+From 002d9f2512245536dfc8d62db429d97e2216ec3a Mon Sep 17 00:00:00 2001
+From: Randy MacLeod
+Date: Fri, 6 Oct 2023 12:08:23 -0700
+Subject: [PATCH] skip tests/so_peerpidfd.gen.test
+
+Upstream-Status: Pending
+
+Signed-off-by: Randy MacLeod
+---
+ tests/so_peerpidfd.gen.test | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tests/so_peerpidfd.gen.test b/tests/so_peerpidfd.gen.test
+index 64ad3a2..f89da9f 100755
+--- a/tests/so_peerpidfd.gen.test
 b/tests/so_peerpidfd.gen.test
+@@ -1,4 +1,5 @@
+ #!/bin/sh -efu
+ # Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (so_peerpidfd 
--trace=getsockopt -y); do not edit.
+ . "${srcdir=.}/init.sh"
++skip_ "Test fails due to apparently trivial log format differences"
+ run_strace_match_diff --trace=getsockopt -y
+--
+2.39.0
+
diff --git a/meta/recipes-devtools/strace/strace_6.5.bb 
b/meta/recipes-devtools/strace/strace_6.5.bb
index 8f90c35925..81baae474f 100644
--- a/meta/recipes-devtools/strace/strace_6.5.bb
+++ b/meta/recipes-devtools/strace/strace_6.5.bb
@@ -14,6 +14,7 @@ SRC_URI ="https://strace.io/files/${PV}/strace-${PV}.tar.xz \ 
file://skip-load.patch \ 
file://0001-configure-Use-autoconf-macro-to-detect-largefile-sup.patch 
\ file://0002-tests-Replace-off64_t-with-off_t.patch \ + 
file://skip-test-so_peerpidfd.gen.test.patch \ "

  SRC_URI[sha256sum] = 
"dfb051702389e1979a151892b5901afc9e93bbc1c70d84c906ade3224ca91980"
  
@@ -47,6 +48,7 @@ do_install_ptest() {

install -m 755 ${S}/build-aux/test-driver ${D}${PTEST_PATH}/build-aux/
install -m 644 ${B}/src/config.h ${D}${PTEST_PATH}/src/
  sed -i -e '/^src/s/strace.*[0-9]/ptest/' 
${D}/${PTEST_PATH}/${TESTDIR}/Makefile
+sed -i '4 i skip_ "Skip due to trivial output format difference."' 
${D}${PTEST_PATH}/tests/so_peerpidfd.gen.test



Oops, that line is no longer needed. V2 with it removed coming up.

../Randy



  }
  
  RDEPENDS:${PN}-ptest += "make coreutils grep gawk sed"






--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188785): 
https://lists.openembedded.org/g/openembedded-core/message/188785
Mute This Topic: https://lists.openembedded.org/mt/101805563/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] strace: skip so_peerpidfd test

2023-10-06 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

The so_peerpidfd test is failing due to a difference of square brackets
in part of the log file. Skip the failing test until the difference is
understood and fixed.

Signed-off-by: Randy MacLeod 
---
 .../skip-test-so_peerpidfd.gen.test.patch | 25 +++
 meta/recipes-devtools/strace/strace_6.5.bb|  2 ++
 2 files changed, 27 insertions(+)
 create mode 100644 
meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch

diff --git 
a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch 
b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
new file mode 100644
index 00..76f93ab613
--- /dev/null
+++ b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
@@ -0,0 +1,25 @@
+From 002d9f2512245536dfc8d62db429d97e2216ec3a Mon Sep 17 00:00:00 2001
+From: Randy MacLeod 
+Date: Fri, 6 Oct 2023 12:08:23 -0700
+Subject: [PATCH] skip tests/so_peerpidfd.gen.test
+
+Upstream-Status: Pending
+
+Signed-off-by: Randy MacLeod 
+---
+ tests/so_peerpidfd.gen.test | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tests/so_peerpidfd.gen.test b/tests/so_peerpidfd.gen.test
+index 64ad3a2..f89da9f 100755
+--- a/tests/so_peerpidfd.gen.test
 b/tests/so_peerpidfd.gen.test
+@@ -1,4 +1,5 @@
+ #!/bin/sh -efu
+ # Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (so_peerpidfd 
--trace=getsockopt -y); do not edit.
+ . "${srcdir=.}/init.sh"
++skip_ "Test fails due to apparently trivial log format differences"
+ run_strace_match_diff --trace=getsockopt -y
+-- 
+2.39.0
+
diff --git a/meta/recipes-devtools/strace/strace_6.5.bb 
b/meta/recipes-devtools/strace/strace_6.5.bb
index 8f90c35925..81baae474f 100644
--- a/meta/recipes-devtools/strace/strace_6.5.bb
+++ b/meta/recipes-devtools/strace/strace_6.5.bb
@@ -14,6 +14,7 @@ SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
file://skip-load.patch \

file://0001-configure-Use-autoconf-macro-to-detect-largefile-sup.patch \
file://0002-tests-Replace-off64_t-with-off_t.patch \
+   file://skip-test-so_peerpidfd.gen.test.patch \
"
 SRC_URI[sha256sum] = 
"dfb051702389e1979a151892b5901afc9e93bbc1c70d84c906ade3224ca91980"
 
@@ -47,6 +48,7 @@ do_install_ptest() {
install -m 755 ${S}/build-aux/test-driver ${D}${PTEST_PATH}/build-aux/
install -m 644 ${B}/src/config.h ${D}${PTEST_PATH}/src/
 sed -i -e '/^src/s/strace.*[0-9]/ptest/' 
${D}/${PTEST_PATH}/${TESTDIR}/Makefile
+sed -i '4 i skip_ "Skip due to trivial output format difference."' 
${D}${PTEST_PATH}/tests/so_peerpidfd.gen.test
 }
 
 RDEPENDS:${PN}-ptest += "make coreutils grep gawk sed"
-- 
2.39.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188783): 
https://lists.openembedded.org/g/openembedded-core/message/188783
Mute This Topic: https://lists.openembedded.org/mt/101805563/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH V3] glibc: stable 2.38 branch updates.

2023-10-03 Thread Randy MacLeod via lists.openembedded.org

On 2023-10-03 1:34 a.m., Deepthi.Hemraj via lists.openembedded.org wrote:

Regression testing is done and below are the test results.

Before glibc update
Summary of test results:
213 FAIL
4805 PASS
16 XFAIL
4 XPASS
218 UNSUPPORTED

After glibc update
Summary of test results:
216 FAIL
4805 PASS
16 XFAIL
4 XPASS
218 UNSUPPORTED

These are the newly added test cases


Thanks for the update, summary and initial analysis.



PASS: io/tst-fcntl-lock-lfs
FAIL: nss/tst-nss-gai-hv2-canonname

It's a little odd that a new test case is failing.

Is this reproducible?

Is there a bug reported upstream or discussed on an email list?



PASS: resolv/tst-resolv-no-vc
And below are new failures
FAIL: nptl/tst-thread-affinity-sched
FAIL: malloc/tst-malloc_info-malloc-check


Are these reproducible?

Is there a bug reported upstream?

Please do some additional analysis of the failures
including whether they only happen in a bitbake build and
report back here so we can decide how to proceed.

Thanks again Deepthi,

../Randy







--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188638): 
https://lists.openembedded.org/g/openembedded-core/message/188638
Mute This Topic: https://lists.openembedded.org/mt/101727838/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH V2] glibc: stable 2.38 branch updates.

2023-09-27 Thread Randy MacLeod via lists.openembedded.org

On 2023-09-27 3:52 p.m., Alexandre Belloni via lists.openembedded.org wrote:

Randy,

Can you please ensure everyone at Windriver that will contribute to YP
has setup their from identity? This is described here:

https://docs.yoctoproject.org/dev/contributor-guide/submit-changes.html#fixing-your-from-identity

Thanks!

Hi Alex,


I've broadcast a summary of your email, the link and content internally.

If this continues next week, please just reject any patches until people 
make the change.


../Randy



On 27/09/2023 03:46:59-0700, Hemraj, Deepthi via lists.openembedded.org wrote:

Below commits on glibc-2.38 stable branch are updated.
0e1ef6779a (HEAD -> release/2.38/master, origin/release/2.38/master) 
manual/jobs.texi: Add missing @item EPERM for getpgid
d94461bb86 string: Fix tester build with fortify enable with gcc < 12
63250e9c57 iconv: restore verbosity with unrecognized encoding names (bug 30694)
00ae4f10b5 getaddrinfo: Fix use after free in getcanonname (CVE-2023-4806)
b25508dd77 CVE-2023-4527: Stack read overflow with large TCP responses in 
no- mode
89da8bc588 NEWS: Add the 2.38.1 bug list
d3ba6c1333 elf: Move l_init_called_next to old place of l_text_end in link map
750f19526a elf: Remove unused l_text_end field from struct link_map
a3189f66a5 elf: Always call destructors in reverse constructor order (bug 30785)
7ae211a01b elf: Do not run constructors for proxy objects
92201f16cb libio: Fix oversized __io_vtables
5bdef6f27c io: Fix record locking contants for powerpc64 with 
__USE_FILE_OFFSET64

Signed-off-by: Deepthi Hemraj
---
  meta/recipes-core/glibc/glibc-version.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/glibc/glibc-version.inc 
b/meta/recipes-core/glibc/glibc-version.inc
index a907444f50..f5ebbb2ee6 100644
--- a/meta/recipes-core/glibc/glibc-version.inc
+++ b/meta/recipes-core/glibc/glibc-version.inc
@@ -1,6 +1,6 @@
  SRCBRANCH ?= "release/2.38/master"
  PV = "2.38+git"
-SRCREV_glibc ?= "1aed90c9c8f8be9f68b58e96b6e4cd0fc08eb2b1"
+SRCREV_glibc ?= "0e1ef6779a90bc0f8a05bc367796df2793deecaa"
  SRCREV_localedef ?= "e0eca29583b9e0f62645c4316ced93cf4e4e26e1"
  
  GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git;protocol=https"

--
2.39.0








--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188345): 
https://lists.openembedded.org/g/openembedded-core/message/188345
Mute This Topic: https://lists.openembedded.org/mt/101614685/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 4/5] qemu: enable parallel builds when using the jobserver class

2023-08-30 Thread Randy MacLeod via lists.openembedded.org

Thanks for the patch set Martin!

On 2023-08-28 08:48, Martin Hundeb?ll via lists.openembedded.org wrote:

If the jobserver class is enabled, the PARALLEL_MAKE variable is unset in
favor of configuring a shared jobserver in the MAKEFLAGS variable. However,
the qemu makefile translates the missing `-j` argument to `-j1` when
calling into meson / ninja. Avoid this by setting `-j` without a value.
For normal/GNU make, this can result in a fork bomb, but for ninja, it
simply makes it use the jobserver fifa instead.

small typo: s/fifa/fifo/


Signed-off-by: Martin Hundebøll
---
  meta/recipes-devtools/qemu/qemu.inc | 5 +
  1 file changed, 5 insertions(+)

diff --git a/meta/recipes-devtools/qemu/qemu.inc 
b/meta/recipes-devtools/qemu/qemu.inc
index ea02bf0c73..7da05fcbf4 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -110,6 +110,11 @@ EXTRA_OECONF = " \
  ${PACKAGECONFIG_CONFARGS} \
  "
  
+# Avoid the qemu makefile treating a missing `-j` argument as `-j1` when

+# calling meson / ninja. This happens when the `jobserver` class is used, since
+# it manages parallelism in the MAKEFLAGS variable instead of PARALLEL_MAKE.
+EXTRA_OEMAKE:append ="${@' -j' if d.getVar('JOBSERVER_FIFO') else ''}"
+


Is there, or should there be, an upstream bug report/PR for this?

To save other from checking, this is from 2020:
qemu.git on master
❯ git blame Makefile | rg j1
09e93326e44 (Paolo Bonzini  2020-08-13 09:28:11 -0400 
145) $(filter-out -j, $(lastword -j1 $(filter -l% -j%, 
$(MAKEFLAGS \


09e93326e4 build: replace ninjatool with ninja
https://gitlab.com/qemu-project/qemu/-/commit/09e93326e4


I've applied the patch set and will do a few builds on a old 24 core 
system and maybe other systems.


Do you have any information on the impact when using the job server?

I suspect that adding openssl to an image might be a good use case since 
it's is a highly parallel build.
Are there other packages that don't depend on openssl that typically run 
at the same time and can use
loads of cores for a long time? If not, I may try out a Nodejs + 
chromium + webkitgtk + ??? build!



../Randy


  B = "${WORKDIR}/build"
  
  #EXTRA_OECONF:append = " --python=${HOSTTOOLS_DIR}/python3"






--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#186926): 
https://lists.openembedded.org/g/openembedded-core/message/186926
Mute This Topic: https://lists.openembedded.org/mt/101009095/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-Core][PATCH v2] rust: Upgrade 1.70.0 -> 1.71.0

2023-08-30 Thread Randy MacLeod via lists.openembedded.org

On 2023-08-17 03:46, Alexander Kanavin wrote:

If you already have a patch it's better if you don't wait for new
versions. New version may require significant additional work, and by
then feature freeze is in place, and then we'll end up with no upgrade
at all.

Alex


FYI,

There were some problems with the Rust test suite after the 1.71 update.

The 1.72 upgrade is done, local build/runtime testing of that is in 
progress and Yash is working on the rust test suite using 1.72. He hopes 
to have patches this week which is late for M3 so we'll see if they 
squeeze in or have to wait for 4.4 to open up.


I've pushed Yash's rust update to:

https://git.yoctoproject.org/poky-contrib/log/?h=rmacleod/yash-rust-1.72-wip 



in case anyone wants to help out.

--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#186923): 
https://lists.openembedded.org/g/openembedded-core/message/186923
Mute This Topic: https://lists.openembedded.org/mt/100230901/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v3] rust: Upgrade 1.70.0 -> 1.71.0

2023-08-25 Thread Randy MacLeod via lists.openembedded.org

On 2023-08-25 11:30, Shinde, Yash wrote:


Hi Luca,

The current version of Rust Oe-selftest is based on Rust 1.70 and 
works well there. It is yet to be updated for Rust 1.71 (eventually 
1.72 which is latest). With every new Rust version there are newly 
test cases added from which some might fail leading to failure of Rust 
Oe-selftest.


The patch sent here is only for Rust version update and not for Rust 
Oe-selftest. The Rust Oe-selftest would be updated to recent versions 
after the Rust update is done.



We need to do both steps in on patch series.




The Rust Oe-selftest fails since it is still on Rust 1.70 and the Rust 
version is updated to 1.71 here. Parallelly will start to rebase Rust 
Oe-selftest on the latest versions.



Thanks.

Send the 1.70 -> 1.71 update along with the Rust Oe-selftest using 1.71 
as one series of commits.


../Randy


Regards,
Yash

*From: *Luca Ceresoli 
*Sent: *25 August 2023 18:50
*To: *Shinde, Yash via lists.openembedded.org 

*Cc: *Shinde, Yash ; 
openembedded-core@lists.openembedded.org; MacLeod, Randy 
; Kallapa, Umesh 
; Gowda, Naveen 
; Kokkonda, Sundeep 
; Moodalappa, Shivaprasad 


*Subject: *Re: [OE-core] [PATCH v3] rust: Upgrade 1.70.0 -> 1.71.0

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender 
and know the content is safe.


Hello Yash,

On Thu, 24 Aug 2023 07:30:18 -0700
"Shinde, Yash via lists.openembedded.org"
 wrote:

> Switch libstd-rs to use the dummy `sysroot` crate which represents the
> standard library crates. Target getrandom-open64.patch at 0.2.8 (merged
> for 0.2.9).
>
> Drop bootstrap_fail.patch as it is merged in upstream rust.
>
> Signed-off-by: Yash Shinde 

The rust.RustSelfTestSystemEmulated.test_rust test is failing on the
ABs with this patch applied:

https://autobuilder.yoctoproject.org/typhoon/#/builders/146/builds/408/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/154/builds/407/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/147/builds/407/steps/12/logs/stdio

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#186741): 
https://lists.openembedded.org/g/openembedded-core/message/186741
Mute This Topic: https://lists.openembedded.org/mt/100936266/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] rust: Upgrade 1.70.0 -> 1.71.0

2023-08-17 Thread Randy MacLeod via lists.openembedded.org

On 2023-08-17 10:58, Alex Kiernan wrote:

Hi

Yeah, you're correct... Currently sitting beside a pool in France,  
having discovered that the DSL where we're staying is basically useless :)


I've been buried in an ESP32 project before we went away, so not 
meaningfully got back to this.


I did start looking at rebasing the patches, but there's massive churn 
and my suspicion is taking the changes to parameterise the test 
exclusions will be the way to go.


There biggest fix I had in the 1.71 update was to use the sysroot 
target for libstd, which is a much cleaner interface.



Alex,
Thanks for explaining the situation.

Sundeep and/or Yashe will take time to work on the 1.71.0 rebase and
send it to the list as suggested by Mr Kanavin.

We'll get the fix for CVE-2023-38497 
, in the 1.72.0 update 
for master.



Enjoy the pool!

../Randy


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#186327): 
https://lists.openembedded.org/g/openembedded-core/message/186327
Mute This Topic: https://lists.openembedded.org/mt/100230901/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] rust: Upgrade 1.70.0 -> 1.71.0

2023-08-17 Thread Randy MacLeod via lists.openembedded.org

Add Alex back to the To list.

On 2023-08-17 09:50, Shinde, Yash via lists.openembedded.org wrote:


Alex,

I will look into rust upgrade 1.70 -> 1.71. What's the timeline for 
this? I guess it's 2 weeks for feature freeze for 4.3.



We talked about this offline and concluded that the best approach would be:

1. do the rebase of 1.71 but don't send to be merged. (keep it aside safely)

2. when 1.72 is released on August 24 2023, do that update, test and submit.


Alex, I assume that you are on vacation but if you happen to read this, 
please

do let us know if we'd be duplicating any of  your work.

../Randy








--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#186320): 
https://lists.openembedded.org/g/openembedded-core/message/186320
Mute This Topic: https://lists.openembedded.org/mt/100230901/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][master][mickledore][PATCH] openssl: Upgrade 3.1.1 -> 3.1.2

2023-08-15 Thread Randy MacLeod via lists.openembedded.org

On 2023-08-13 06:49, Peter Marko via lists.openembedded.org wrote:

Gentle ping.
Is there any problem with this patch?

Peter


Peter,

We'd all like to see this openssl update merged but I suspect, that for 
master,
it's backed up behind the 6.4 kernel update and some glibc update 
problems summarize here:

https://lists.yoctoproject.org/g/yocto/message/60802

and (I confirmed with Steve) because it's not in master, as a matter of 
policy, it's not in mickledore-nut:

https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/mickledore-nut

Stay tuned, check on:
https://git.openembedded.org/openembedded-core/log/?qt=range=master-next
and ping again if it's not in oe-core/master-next/master in a week and  
mickledore-nut a while after that.


Note that, it won't be in mickledore-nut until after a week or two after 
it hits master.


--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#186099): 
https://lists.openembedded.org/g/openembedded-core/message/186099
Mute This Topic: https://lists.openembedded.org/mt/100487930/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][mickledore][PATCH 1/1] python3-pygments: upgrade 2.14.0 -> 2.15.1

2023-08-11 Thread Randy MacLeod via lists.openembedded.org

Narpat,

I don't see this in Steve's test branch:
https://git.openembedded.org/openembedded-core-contrib/log/?h=stable%2Fmickledore-nut=grep=pygments

which is good since for mickledore, I think that you need backport only 
the fix commits
because 2.15.1  has added features and build related changes. I'm not 
using pygments

so I've CCed Tim to ask him to confirm that this is the right approach.

I think that since we've worked on chromium and maybe vim together, and 
seen my

suggest an upgrade rather than a commit backport for dmidecode, you are
under the mistaken impression that it's generally acceptable. It's not.


Also you asked about kirkstone privately, so I'll quote that here:
   "the current version of python3-pygments is 2.11.2 in LTS22 and
    have tried back-porting these above fixes but, the source files
    have been changed a lot and I am unable to back-port these.
    So, upgrading this current version 2.11.2 -> 2.15.1 would be 
acceptable or not ? "


Here as well, the answer is no, we need you to backport the fixes. If 
it's simply not
practical to fix a CVE, in rare cases, you could tag the CVE with 
something like:


meta/recipes-devtools/flex/flex_2.6.4.bb:CVE_STATUS[CVE-2019-6293] = 
"upstream-wontfix:

or = "backporting-not-sensible"

but that's a last resort and others may rightfully object to that 
conclusion.





On 2023-08-08 04:32, Narpat Mali via lists.openembedded.org wrote:

From: Narpat Mali

* Upstream has dropped setup.py
* Inherit python_setuptools_build_meta instead of setuptools3
* Add self as maintainer, as this is a dependency for python3-sphinx

Adds some new lexers, updates a few others. A handful of bug fixes.

https://github.com/pygments/pygments/blob/2.15.1/CHANGES#L6
https://github.com/pygments/pygments/blob/2.15.1/CHANGES#L18

Have cherry-picked the upgrade commit from upstream/master:
https://git.openembedded.org/openembedded-core/commit/?id=22e2569ae4843071b2b48d026ca4742351baf6d1

It's good that you amended the commit log to show where the work
came from. It seems that you dropped these two SOB lines:

    Signed-off-by: Tim Orling 
    Signed-off-by: Richard Purdie 

I'd keep them since it's part of the upstream commit.




Signed-off-by: Narpat Mali
---
  meta/conf/distro/include/maintainers.inc  | 2 +-
  ...{python3-pygments_2.14.0.bb => python3-pygments_2.15.1.bb} | 4 ++--
  2 files changed, 3 insertions(+), 3 deletions(-)
  rename meta/recipes-devtools/python/{python3-pygments_2.14.0.bb => 
python3-pygments_2.15.1.bb} (76%)

diff --git a/meta/conf/distro/include/maintainers.inc 
b/meta/conf/distro/include/maintainers.inc
index 07498a23a9..c9d790ca32 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -666,7 +666,7 @@ RECIPE_MAINTAINER:pn-python3-pyasn1 = "Tim 
Orling"
  RECIPE_MAINTAINER:pn-python3-pycairo = "Zang Ruochen"
  RECIPE_MAINTAINER:pn-python3-pycparser = "Tim Orling"
  RECIPE_MAINTAINER:pn-python3-pyelftools = "Joshua Watt"
-RECIPE_MAINTAINER:pn-python3-pygments = 
"Unassigned"
+RECIPE_MAINTAINER:pn-python3-pygments = "Tim Orling"
This came from the cherry-pick but clearly you should CC Tim and 
probably email


him first to see if he agrees on maintainership for the recipe in 
mickledore.



../Randy



  RECIPE_MAINTAINER:pn-python3-pygobject = "Zang 
Ruochen"
  RECIPE_MAINTAINER:pn-python3-pyopenssl = "Tim Orling"
  RECIPE_MAINTAINER:pn-python3-pyparsing = 
"Unassigned"
diff --git a/meta/recipes-devtools/python/python3-pygments_2.14.0.bb 
b/meta/recipes-devtools/python/python3-pygments_2.15.1.bb
similarity index 76%
rename from meta/recipes-devtools/python/python3-pygments_2.14.0.bb
rename to meta/recipes-devtools/python/python3-pygments_2.15.1.bb
index 16769e9263..e0e477100e 100644
--- a/meta/recipes-devtools/python/python3-pygments_2.14.0.bb
+++ b/meta/recipes-devtools/python/python3-pygments_2.15.1.bb
@@ -4,8 +4,8 @@ HOMEPAGE ="http://pygments.org/;
  LICENSE = "BSD-2-Clause"
  LIC_FILES_CHKSUM ="file://LICENSE;md5=36a13c90514e2899f1eba7f41c3ee592"
  
-inherit setuptools3

-SRC_URI[sha256sum] = 
"b3ed06a9e8ac9a9aae5a6f5dbe78a8a58655d17b43b93c078f094ddc476ae297"
+inherit python_setuptools_build_meta
+SRC_URI[sha256sum] = 
"8ace4d3c1dd481894b2005f560ead0f9f19ee64fe983366be1a21e171d12775c"
  
  DEPENDS += "\

  ${PYTHON_PN} \





--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#185850): 
https://lists.openembedded.org/g/openembedded-core/message/185850
Mute This Topic: https://lists.openembedded.org/mt/100618182/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe-core][PATCH 1/1] runqemu: add some logging control

2023-08-02 Thread Randy MacLeod via lists.openembedded.org

On 2023-08-02 19:36, joe.sla...@windriver.com wrote:

From: Joe Slater

Use QB_LOG_FILE to log to a file, and QB_LOG_LEVEL
to set the base log level.  Example values -

QB_LOG_FILE="runq.log"
QB_LOG_LEVEL=DEBUG

Signed-off-by: Joe Slater
---
  scripts/runqemu | 16 
  1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index 5e6793d44e..bea164d041 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -36,12 +36,20 @@ runqemu, i.e. `runqemu /path/to/my-image-name.qemuboot.conf`\n\n 
%s" % message)
  
  def create_logger():

  logger = logging.getLogger('runqemu')
-logger.setLevel(logging.INFO)
+try:
+logger.setLevel(os.getenv("QB_LOG_LEVEL"))
+except:
+logger.setLevel(logging.INFO)
  
-# create console handler and set level to debug

-ch = logging.StreamHandler()
-ch.setLevel(logging.DEBUG)


Better to keep the log level the same or call out the change in the 
short/long log.


../Randy

  
+# create a handler and set level to debug

+try:
+ch = logging.FileHandler(os.getenv("QB_LOG_FILE"))
+except:
+ch = logging.StreamHandler()
+
+ch.setLevel(logging.DEBUG)
+
  # create formatter
  formatter = logging.Formatter('%(name)s - %(levelname)s - %(message)s')
  



--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#185445): 
https://lists.openembedded.org/g/openembedded-core/message/185445
Mute This Topic: https://lists.openembedded.org/mt/100516758/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] rust: Add failed test cases to exclude list for Rust Oe-selftest

2023-07-26 Thread Randy MacLeod via lists.openembedded.org

I don't see this in master or master-next yet so see comments below and
send a slightly updated v2.

On 2023-07-26 12:25, Yash Shinde wrote:

Failed test cases are added to exclude list.
Drop meta/recipes-devtools/rust/files/rust-oe-selftest.patch file.

Signed-off-by: Yash Shinde
---
  meta/lib/oeqa/selftest/cases/rust.py  |  209 +-
  .../rust/files/rust-oe-selftest.patch | 2324 -
  meta/recipes-devtools/rust/rust-source.inc|1 -
  3 files changed, 208 insertions(+), 2326 deletions(-)
  delete mode 100644 meta/recipes-devtools/rust/files/rust-oe-selftest.patch


It's good to see the large patch be replaced with a 10x smaller rust.py 
change.


If this change is acceptable to others, I'd like the commit log to be 
amended to explain
how to (automatically?) update the exclude list when rust is updated. 
Alternatively

we could add that to meta/recipes-devtools/rust/README-rust.md
https://github.com/yoctoproject/poky/blob/master/meta/recipes-devtools/rust/README-rust.md

Is this a manual process now? Could it be mostly automated?

Please sort the exclude list alphabetically in v2 so that it's
easier for people to see what tests are being excluded (see below (*))

I assume that this commit doesn't change the tests that are run but only
moves the skipping from being a patch to the exclude list. Please confirm
and in your v2 commit log, mention that as well as what the current 
number of

passed and skipped tests.




diff --git a/meta/lib/oeqa/selftest/cases/rust.py 
b/meta/lib/oeqa/selftest/cases/rust.py
index 7a0fd7033d..abd3ef8314 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -70,7 +70,214 @@ class RustSelfTestSystemEmulated(OESelftestTestCase, 
OEPTestResultTestCase):
  # no-fail-fast: Run all tests regardless of failure.
  # bless: First runs rustfmt to format the codebase,
  # then runs tidy checks.
-testargs = "--exclude tests/rustdoc --exclude src/tools/rust-analyzer  
--exclude tests/rustdoc-json  --exclude tests/run-make-fulldeps --exclude src/tools/tidy 
--exclude src/tools/rustdoc-themes --exclude src/rustdoc-json-types --exclude 
src/librustdoc --exclude src/doc/unstable-book --exclude src/doc/rustdoc --exclude 
src/doc/rustc --exclude compiler/rustc --exclude library/panic_abort --exclude 
library/panic_unwind --exclude src/tools/lint-docs  --exclude tests/rustdoc-js-std --doc 
--no-fail-fast --bless"


I think you're doing two things in the 2 lines above and the list below:

 1. splitting up the testargs into one per line

 2. adding an exclude list of tests that are know to fail.

Is that true?
If so can you use two seperate variables/lists to reflect the different 
intended purpose of each list?
This should also help in maintaining each list and hopefully the tests 
that are exluded will all have a:


   tests/foo/bar.rs

format rather than somewhat worrying prefixes like:
   compiler/rustc

and

   library/panic_abort


+exclude_list = """  --exclude tests/run-make

If python will let you, please split this line like this:

+exclude_list = """
+ --exclude tests/run-make

to separate the variables from the list name to make future updates a bit 
easier.


+--exclude tests/run-make/pgo-branch-weights/
+--exclude 
tests/ui/macros/restricted-shadowing-legacy.rs
+--exclude tests/ui-fulldeps/issue-14021.rs



>< -- the middle bits of the long unsorted list.



+--exclude library/panic_unwind
+--exclude src/tools/lint-docs
+--exclude tests/rustdoc-js-std"""


Similarly, if python will let you, put the terminating triple quote on a 
new line with proper identation of course.


These last two comments are "nice-to-have" so just call me a python 
newbie if that's not possible or is not pythonic!



+
+exclude_fail_tests = exclude_list.split("\n")
+exclude_fail_tests = " ".join(exclude_fail_tests)
+
+# Add exclude_fail_tests with other test arguments
+testargs =  exclude_fail_tests + " --doc --no-fail-fast --bless"
  
  # Set path for target-poky-linux-gcc, RUST_TARGET_PATH and hosttools.

  cmd = " export PATH=%s/recipe-sysroot-native/usr/bin:$PATH;" % 
rustlibpath
diff --git a/meta/recipes-devtools/rust/files/rust-oe-selftest.patch 
b/meta/recipes-devtools/rust/files/rust-oe-selftest.patch


><  -- giant 10x bigger than it needs to be patch



-diff --git a/tests/run-make/pointer-auth-link-with-c/Makefile 
b/tests/run-make/pointer-auth-link-with-c/Makefile
-index dffbd303582..5347d0a90f1 100644
 a/tests/run-make/pointer-auth-link-with-c/Makefile
-+++ b/tests/run-make/pointer-auth-link-with-c/Makefile
-@@ -1,3 +1,4 @@
-+# ignore-stage1
- include 

Re: [OE-core][mickledore 02/26] dmidecode: fix CVE-2023-30630

2023-07-20 Thread Randy MacLeod via lists.openembedded.org

On 2023-07-18 18:32, Steve Sakoman wrote:

On Tue, Jul 18, 2023 at 11:49 AM Randy MacLeod
  wrote:

Add Kai,

On 2023-07-14 18:32, Steve Sakoman via lists.openembedded.org wrote:

From: Yogita Urade

Dmidecode before 3.5 allows -dump-bin to overwrite a local file.
This has security relevance because, for example, execution of
Dmidecode via Sudo is plausible.

References:
https://nvd.nist.gov/vuln/detail/CVE-2023-30630
https://lists.nongnu.org/archive/html/dmidecode-devel/2023-04/msg00016.html
https://lists.nongnu.org/archive/html/dmidecode-devel/2023-04/msg00017.html

Signed-off-by: Yogita Urade
Signed-off-by: Steve Sakoman
---
  .../dmidecode/CVE-2023-30630_1.patch  | 237 ++
  .../dmidecode/CVE-2023-30630_2.patch  |  81 ++
  .../dmidecode/CVE-2023-30630_3.patch  |  69 +
  .../dmidecode/CVE-2023-30630_4.patch  | 137 ++


Summary:

 I think this can merge but we should agree on how to handle dmidecode.


Details:

These changes work but it's bringing back 4 patches rather than bumping the 
version to 3.5
and picking up 2 patches. My conclusion is that it's okay but we should 
probably talk
about how to maintain dmidecode since it just produces a bunch of programs for 
dumping
HW DMI/SMBIOS info and doesn't provide a runtime ABI, we can probably update to 
3.5
( or even 3.6 when that's out).

Do you agree Steve?

You'll always get the same answer from me: no version bumps that
implement new features/apis.  Bug/security fixes only.

If there is a strong case to be made for something outside this
policy, it should go to the TSC for consideration.

I don't want our stable branches to start resembling the kernel
"stable" branches ...

So, yes, I think we should merge this patch rather than version bump :-)

Steve


Fine with me!




There is no change to this commit and it will be merged so
read on only if you are interested in dmidecode maintenance and
my motivations in causing this bit of noise on the list. ;-)


I checked with the dmidecode upstream (1) about their versioning scheme 
and if they
have considered having a structured release numbering scheme and even a 
stable branch.


They said they increment versions at will and don't have a stable branch 
other than latest release.
As Richard and Steve have said, we should be more conservative and if we 
find that anyone needs
the additional hardware support that I was hoping to pick up, we can 
back port patches.


Sorry for the noise,

../Randy


1)

https://lists.nongnu.org/archive/html/dmidecode-devel/2023-07/msg6.html

--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#184662): 
https://lists.openembedded.org/g/openembedded-core/message/184662
Mute This Topic: https://lists.openembedded.org/mt/100151225/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][mickledore 02/26] dmidecode: fix CVE-2023-30630

2023-07-18 Thread Randy MacLeod via lists.openembedded.org

On 2023-07-18 18:32, Steve Sakoman wrote:

On Tue, Jul 18, 2023 at 11:49 AM Randy MacLeod
  wrote:

Add Kai,

On 2023-07-14 18:32, Steve Sakoman via lists.openembedded.org wrote:

From: Yogita Urade

Dmidecode before 3.5 allows -dump-bin to overwrite a local file.
This has security relevance because, for example, execution of
Dmidecode via Sudo is plausible.

References:
https://nvd.nist.gov/vuln/detail/CVE-2023-30630
https://lists.nongnu.org/archive/html/dmidecode-devel/2023-04/msg00016.html
https://lists.nongnu.org/archive/html/dmidecode-devel/2023-04/msg00017.html

Signed-off-by: Yogita Urade
Signed-off-by: Steve Sakoman
---
  .../dmidecode/CVE-2023-30630_1.patch  | 237 ++
  .../dmidecode/CVE-2023-30630_2.patch  |  81 ++
  .../dmidecode/CVE-2023-30630_3.patch  |  69 +
  .../dmidecode/CVE-2023-30630_4.patch  | 137 ++


Summary:

 I think this can merge but we should agree on how to handle dmidecode.


Details:

These changes work but it's bringing back 4 patches rather than bumping the 
version to 3.5
and picking up 2 patches. My conclusion is that it's okay but we should 
probably talk
about how to maintain dmidecode since it just produces a bunch of programs for 
dumping
HW DMI/SMBIOS info and doesn't provide a runtime ABI, we can probably update to 
3.5
( or even 3.6 when that's out).

Do you agree Steve?

You'll always get the same answer from me: no version bumps that
implement new features/apis.  Bug/security fixes only.

If there is a strong case to be made for something outside this
policy, it should go to the TSC for consideration.

I don't want our stable branches to start resembling the kernel
"stable" branches ...

So, yes, I think we should merge this patch rather than version bump :-)


Ok, that works for me and if there's no follow-up for Yogita, that's 
also good news.


I may ping the upstream devs to see if they really are following
a semantic versioning scheme (1). My goal was to not only get the CVEs
fixed but to get the additional decode info to better support new hardware.

I suppose that even for simple executables like this, it's possible that 
something

changed in the output format or the one or two changes that seem suspect,
could cause problems for someone and so we should be more conservative and
by keeping the number of exceptions to a minimum, we usually make 
maintenance easier.


Thanks for the comments,

../Randy

1)

https://semver.org/


Steve


The patches back-ported are:

❯ rg -i "subject: \[PATCH\]" /tmp/dmidecode-mickledore-cve.eml
201:+Subject: [PATCH] dmidecode: Write the whole dump file at once
444:+Subject: [PATCH] dmidecode: Do not let --dump-bin overwrite an existing 
file
531:+Subject: [PATCH] Consistently use read_file() when reading from a dump file
606:+Subject: [PATCH] Don't read beyond sysfs entry point buffer


Two of these patches would be picked up if we update mickledore to 3.5 - so 
let's look at what changed:

❯ git log --oneline dmidecode-3-4..dmidecode-3-5

484f893 (tag: dmidecode-3-5) Set the version to 3.5
8baf2f5 Fix a build warning when USE_MMAP isn't set
b9ebecc dmioem: HPE type 242: Fix ID on 32-bit systems
189ca35 Ensure /dev/mem is a character device file
8427888 dmidecode: Use the right variable for -s bios-revision/firmware-revision
6ca381c dmidecode: Do not let --dump-bin overwrite an existing file <-- 
Added.
d8cfbc8 dmidecode: Write the whole dump file at once   
<-- Added.
39b2dd7 dmidecode: Split table fetching from decoding
11b168f dmioem: Avoid intermediate buffer (HPE type 216)
9d2bbd5 dmioem: Decode HPE OEM Record 216
3d68350 dmidecode: Drop the CPUID exception list
c1a2520 dmidecode: Add a --no-quirks option
67dc0b2 dmidecode: Fortify entry point length checks
f801673 dmioem: Typo fix (Virutal -> Virtual)
90d1323 dmioem: Decode HPE OEM Record 242
f50b925 dmioem: Update HPE OEM Record 238
ac24b67 dmioem: Decode HPE OEM Record 230
c3357b5 dmioem: Fix segmentation fault in dmi_hp_240_attr()
a1a2258 dmioem: Decode HPE OEM Record 224
fb8766a NEWS: Fix typo


My summary of the changes above:

  - support additional HW,

  -  fix bugs, typos and build warnings.

  - internal program restructuring: 39b2dd7 dmidecode: Split table fetching 
from decoding

I was a bit concerned about:

3d68350 dmidecode: Drop the CPUID exception list

but it's pretty arcane (1) and only affects HW from 2008 or earlier

so we should be okay with that change!


Steve,

Do you agree?

Thanks,

../Randy



1)

commit 3d6835047f80691678e5db3127f9d573956413f0
Author: Jean Delvare
Date:   Fri Dec 16 04:37:04 2022

 dmidecode: Drop the CPUID exception list

 Back in 2003, I had a system where the CPU type was not set. I added
 a quirk so that it would still be recognized as x86, and the CPUID
 could be decoded.

 A few more exceptions where added over the years, but in effect, the
 list was last modified in 2008.

 Having 

Re: [OE-core][mickledore 02/26] dmidecode: fix CVE-2023-30630

2023-07-18 Thread Randy MacLeod via lists.openembedded.org

Add Kai,

On 2023-07-14 18:32, Steve Sakoman via lists.openembedded.org wrote:

From: Yogita Urade

Dmidecode before 3.5 allows -dump-bin to overwrite a local file.
This has security relevance because, for example, execution of
Dmidecode via Sudo is plausible.

References:
https://nvd.nist.gov/vuln/detail/CVE-2023-30630
https://lists.nongnu.org/archive/html/dmidecode-devel/2023-04/msg00016.html
https://lists.nongnu.org/archive/html/dmidecode-devel/2023-04/msg00017.html

Signed-off-by: Yogita Urade
Signed-off-by: Steve Sakoman
---
  .../dmidecode/CVE-2023-30630_1.patch  | 237 ++
  .../dmidecode/CVE-2023-30630_2.patch  |  81 ++
  .../dmidecode/CVE-2023-30630_3.patch  |  69 +
  .../dmidecode/CVE-2023-30630_4.patch  | 137 ++



Summary:

    I think this can merge but we should agree on how to handle dmidecode.


Details:

These changes work but it's bringing back 4 patches rather than bumping 
the version to 3.5
and picking up 2 patches. My conclusion is that it's okay but we should 
probably talk
about how to maintain dmidecode since it just produces a bunch of 
programs for dumping
HW DMI/SMBIOS info and doesn't provide a runtime ABI, we can probably 
update to 3.5

( or even 3.6 when that's out).

Do you agree Steve?


The patches back-ported are:

❯ rg -i "subject: \[PATCH\]" /tmp/dmidecode-mickledore-cve.eml
201:+Subject: [PATCH] dmidecode: Write the whole dump file at once
444:+Subject: [PATCH] dmidecode: Do not let --dump-bin overwrite an 
existing file
531:+Subject: [PATCH] Consistently use read_file() when reading from a 
dump file

606:+Subject: [PATCH] Don't read beyond sysfs entry point buffer


Two of these patches would be picked up if we update mickledore to 3.5 - 
so let's look at what changed:


❯ git log --oneline dmidecode-3-4..dmidecode-3-5

484f893 (tag: dmidecode-3-5) Set the version to 3.5
8baf2f5 Fix a build warning when USE_MMAP isn't set
b9ebecc dmioem: HPE type 242: Fix ID on 32-bit systems
189ca35 Ensure /dev/mem is a character device file
8427888 dmidecode: Use the right variable for -s 
bios-revision/firmware-revision
6ca381c dmidecode: Do not let --dump-bin overwrite an existing file 
<-- Added.
d8cfbc8 dmidecode: Write the whole dump file at 
once   <-- Added.

39b2dd7 dmidecode: Split table fetching from decoding
11b168f dmioem: Avoid intermediate buffer (HPE type 216)
9d2bbd5 dmioem: Decode HPE OEM Record 216
3d68350 dmidecode: Drop the CPUID exception list
c1a2520 dmidecode: Add a --no-quirks option
67dc0b2 dmidecode: Fortify entry point length checks
f801673 dmioem: Typo fix (Virutal -> Virtual)
90d1323 dmioem: Decode HPE OEM Record 242
f50b925 dmioem: Update HPE OEM Record 238
ac24b67 dmioem: Decode HPE OEM Record 230
c3357b5 dmioem: Fix segmentation fault in dmi_hp_240_attr()
a1a2258 dmioem: Decode HPE OEM Record 224
fb8766a NEWS: Fix typo


My summary of the changes above:

 - support additional HW,

 -  fix bugs, typos and build warnings.

 - internal program restructuring: 39b2dd7 dmidecode: Split table 
fetching from decoding


I was a bit concerned about:

   3d68350 dmidecode: Drop the CPUID exception list

but it's pretty arcane (1) and only affects HW from 2008 or earlier

so we should be okay with that change!


Steve,

Do you agree?

Thanks,

../Randy



1)

commit 3d6835047f80691678e5db3127f9d573956413f0
Author: Jean Delvare 
Date:   Fri Dec 16 04:37:04 2022

    dmidecode: Drop the CPUID exception list

    Back in 2003, I had a system where the CPU type was not set. I added
    a quirk so that it would still be recognized as x86, and the CPUID
    could be decoded.

    A few more exceptions where added over the years, but in effect, the
    list was last modified in 2008.

    Having such an exception list isn't actually a good idea, for the
    following reasons:
 * It requires endless maintenance work if we want to keep it
   up-to-date.
 * It adds some (admittedly minimal) burden to the sane systems.
 * If we were to add more entries to the exception list, it wouldn't
   scale well (linear algorithmic complexity). This could be improved
   but at the cost of more complex code.
 * It sends the wrong message to the hardware manufacturers ("You can
   get things wrong, we'll add a workaround on our side.")

    Therefore I would like to get rid of this exception list. Doing so
    has the nice side effect of simplifying the code and making the
    binary smaller.

    If anyone really needs the CPUID information on such non-compliant
    systems, there are other ways to retrieve it, such as lscpu or
    /proc/cpuinfo.

https://git.savannah.nongnu.org/cgit/dmidecode.git/commit/?id=3d6835047f80691678e5db3127f9d573956413f0




  .../dmidecode/dmidecode_3.4.bb|   4 +
  5 files changed, 528 insertions(+)
  create mode 100644 
meta/recipes-devtools/dmidecode/dmidecode/CVE-2023-30630_1.patch
  create mode 100644 

Re: [OE-core] [mickledore][PATCH 0/1] Cherry pick commit from master to update webkitgtk to 2.40.2

2023-07-17 Thread Randy MacLeod via lists.openembedded.org

On 2023-07-17 12:09, Steve Sakoman via lists.openembedded.org wrote:

On Sun, Jul 16, 2023 at 3:34 PM Kai  wrote:

On 7/14/23 15:15, Kai Kang wrote:

From: Kai Kang

Hi,

I've discussed with webkitgtk maintainers about api compatable issues on

https://lists.webkit.org/pipermail/webkit-gtk/2023-March/003887.html


WebKitGTK 2.38.x is backwards compatible with 2.36.x, you can safely update

without needing to change applications. In general, we always keep the API and
ABI backwards compatible.

Note that the current stable releases (2.40.x) introduce a new API level
when using GTK4, but I suppose this is not a problem because most likely you
are still using GTK3


I suggest we apply the update in mickledore too which solves lots of
CVEs.

Hi Steve,

I have no idea why the cover-letter is not in the same thread with the
patch.

So according to the reply from webkitgtk maintainer, would you like to
re-consider
to cherry-pick the commit to mickledore, please?

Sorry, still not possible, this is a major release bump that adds
features and APIs.  Please see:

https://wpewebkit.org/release/wpewebkit-2.40.0.html


We do need to be careful but upstream is saying that:

  "WebKitGTK 2.40.x is backwards-compatible as well and that will 
remain true indefinitely,

   as long as you continue to build the same API version [2]. "

I'd like a simple way to measure if that's true but I'm not sure one exists.

Kai,

Have you looked at the source diff to understand how upstream is able to 
introduce

a new API yet enable building the old one?


Kai, Steve,

Should we investigate using the flags suggested:
   "is still possible to build the old 1.0 API using |-USE_SOUP2=ON|, 
or the 1.1 API using |-DENABLE_WPE_1_1_API=ON|. "

  -- https://wpewebkit.org/release/wpewebkit-2.40.0.html

or do we really have to backport patches to 2.38.x ?

../Randy






Alexander Kanavin (1):
webkitgtk: update 2.38.5 -> 2.40.2

   meta/recipes-gnome/epiphany/epiphany_43.1.bb  |  3 ++
   ...tCore-CMakeLists.txt-ensure-reproduc.patch | 28 +
   ...44e17d258106617b0e6d783d073b188a2548.patch | 42 ---
   ...290ab4ab35258a6da9b13795c9b0f7894bf4.patch | 41 ++
   ...bb461f040b90453bc4e100dcf967243ecd98.patch | 30 -
   ...ebkitgtk_2.38.5.bb => webkitgtk_2.40.2.bb} | 15 +--
   6 files changed, 111 insertions(+), 48 deletions(-)
   create mode 100644 
meta/recipes-sato/webkit/webkitgtk/0001-Source-JavaScriptCore-CMakeLists.txt-ensure-reproduc.patch
   create mode 100644 
meta/recipes-sato/webkit/webkitgtk/4977290ab4ab35258a6da9b13795c9b0f7894bf4.patch
   delete mode 100644 
meta/recipes-sato/webkit/webkitgtk/d318bb461f040b90453bc4e100dcf967243ecd98.patch
   rename meta/recipes-sato/webkit/{webkitgtk_2.38.5.bb => webkitgtk_2.40.2.bb} 
(90%)





--
Kai Kang
Wind River Linux






--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#184483): 
https://lists.openembedded.org/g/openembedded-core/message/184483
Mute This Topic: https://lists.openembedded.org/mt/100136728/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [mickledore][PATCH] gcc : upgrade to v12.3

2023-06-24 Thread Randy MacLeod via lists.openembedded.org

Add Khem since he may want to test meta-oe with the updated toolchain.

On 2023-06-23 12:40, Sundeep KOKKONDA wrote:

gcc stable version upgraded from v12.2 to v12.3

Below is the bug fix list for v12.3
https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED=FIXED_milestone=12.3


Thanks Sundeep.


Did you run a toochain regression test and if so what are the before, 
after, delta stats

and your summary/analysis of the results?


It isn't a strict requirement but if it's easy, then it's good to copy 
data into the commit log rather than link it.


In this case, there are 129 bugs so that's too much info and a link is 
sensible but

it's nice if it's accompanied with a summary.
I don't think we need a commit log update but I'll summarize what I 
noticed below

to give you an indication of what I'd like to see in future commits.

Most of the bugs linked are "Regression" fixes leaving:

https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED_known_to_fail_type=allwords_known_to_work_type=allwords=gcc_format=advanced=FIXED_desc=Regression_desc_type=notregexp_milestone=12.3

ID    Product     Comp     Assignee     Summary
103387     gcc     libstdc+    redi              powerpc64le: 
segmentation fault on std::cout with ieee128 long doubl
109094     gcc     analyzer    dmalcolm        Uninit false positive 
from -fanalyzer when longjmp unwinds frames
106721     gcc     target        jakub           Error: invalid 
character '<' in mnemonic since r13-2122-g86c0d98620e
100103     gcc     fortran   jrfsousa       Automatic 
reallocation fails inside select rank
107551     gcc     target        marxin __builtin_cpu_supports returns a 
negative integer for "x86-64"
98487   gcc     c         mpolacek       ICE: tree check: 
expected identifier_node, have tree_list in is_attribut
109427     gcc     tree-opt     pinskia param=vect-induction-float= has 
a typo for IntegerRange

103081     gcc     c++           ppalka             [ICE] with "using enum"
107417     gcc     c++           ppalka             g++ fails to 
recognize parameter pack in requires-expression
107542     gcc     c++           ppalka             ICE in 
spaceship_comp_cat, at cp/method.cc:1055
108104     gcc     c++           ppalka             ICE in unify, at 
cp/pt.c:24333 with template partial specialization an
108362     gcc     libstdc+     ppalka            views::istream is 
SFINAE-unfriendly
103755     gcc     libstdc+    redi {has,use}_facet() and iostream 
constructor performance
105678     gcc     libstdc+    redi              Undefined reference 
to stacktrace standard library
109165     gcc     libstdc+    redi 
std::hash>::operator() should be const
109182     gcc     libstdc+    redi              unused parameter 
pack is in expected(in_place_t)
109242     gcc     libstdc+    redi              C++2b 
std::optional::transform omits required std::remove_cv_t from
99417   gcc     libstdc+    unassigned  [C++17] std::variant 
assignment fails to compile
103325     gcc     tree-opt     unassigned     1 << -1 is never reduced 
to a constant during gimple
106714     gcc     target        unassigned     Incorrect casts in 
macros in amxtileintrin.h
107121     gcc     tree-opt     unassigned     DEFERRED_INIT misspelled 
in error message
107206     gcc     tree-opt     unassigned     Bogus -Wuninitialized in 
std::optional
107713     gcc     target        unassigned     Wrong implementation 
atomic_exchange on LoongArch
108097     gcc     libstdc+    unassigned     std::stacktrace 
AddressSanitizer: new-delete-type-mismatch on 0
109000     gcc     target        xry111            LoongArch: 
"unmatched" -mabi and -mfpu setting can break ABI silent
104554     gcc     fortran       anlauf             ICE in 
check_assumed_size_reference, at fortran/resolv


The idea is to show that you've looked at what changed and though about 
it a bit even if it's

just bug review like I have above.


Html table below for those interested.


Also the release notes are not very helpful ( 
https://gcc.gnu.org/gcc-12/changes.html ):



   GCC 12.3


 Target Specific Changes


 x86-64

 * GCC now supports AMD CPUs based on the |znver4| core via
   |-march=znver4|. The switch makes GCC consider using 512 bit vectors
   when auto-vectorizing.

This is the list of problem reports (PRs) 
 
from GCC's bug tracking system that are known to be fixed in the 12.3 
release. This list might not be complete (that is, it is possible that 
some PRs that have been fixed are not listed here).



../Randy


ID 
 
	Product 

Re: [OE-core] [kirkstone][PATCH] Below commits on glibc-2.35 stable branch are updated.

2023-06-09 Thread Randy MacLeod via lists.openembedded.org

Thanks Deepthi.

Add Steve, who maintains the stable branches of oe-core.

Can you change the subject/oneline git summary from:

Re: [kirkstone][PATCH] Below commits on glibc-2.35 stable branch are 
updated.


to:
Re: [kirkstone][PATCH] glibc: stable 2.35 branch updates.

like you had in your previous commit.
Remember to keep with the existing style of commit logs.

On 2023-06-09 09:18, Deepthi Hemraj wrote:

cbceb903c4 io: Fix F_GETLK, F_SETLK, and F_SETLKW for powerpc64
0967fb5861 io: Fix record locking contants on 32 bit arch with 64 bit default 
time_t
739de21d30 Document BZ #20975 fix
2b9906f9a0 __check_pf: Add a cancellation cleanup handler
7035f2174f gmon: Revert addition of tunables to preserve GLIBC_PRIVATE ABI
e698e8bd8e gmon: fix memory corruption issues
9f81b8fa65 gmon: improve mcount overflow handling
f2820e478c gmon: Fix allocated buffer overflow
413af1eb02 posix: Fix system blocks SIGCHLD erroneously


Nice, I checked and this brings us up to date for 2.35 since there
hasn't been anything merged in the last week.


Please add a comment to the commit log explaining that you dropped

   CVE-2023-0687.patch

since it was back-ported to 2.35 as commit:

   f2820e478c gmon: Fix allocated buffer overflow (bug 29444)


We still have time to fix the commit log up since theYP 4.0.11 build 
date is 2023/06/26.


Thanks,

../Randy



Signed-off-by: Deepthi Hemraj
---
  meta/recipes-core/glibc/glibc-version.inc | 2 +-
  meta/recipes-core/glibc/glibc_2.35.bb | 1 -
  2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/recipes-core/glibc/glibc-version.inc 
b/meta/recipes-core/glibc/glibc-version.inc
index 4d8d96cefb..01b1abef7d 100644
--- a/meta/recipes-core/glibc/glibc-version.inc
+++ b/meta/recipes-core/glibc/glibc-version.inc
@@ -1,6 +1,6 @@
  SRCBRANCH ?= "release/2.35/master"
  PV = "2.35"
-SRCREV_glibc ?= "1c7f51c75ae300fe52ccb636e71b8e28cb20824c"
+SRCREV_glibc ?= "cbceb903c4d770acc7e4ba5641036516830ed69b"
  SRCREV_localedef ?= "794da69788cbf9bf57b59a852f9f11307663fa87"
  
  GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git"

diff --git a/meta/recipes-core/glibc/glibc_2.35.bb 
b/meta/recipes-core/glibc/glibc_2.35.bb
index 29fcb1d627..df847e76bf 100644
--- a/meta/recipes-core/glibc/glibc_2.35.bb
+++ b/meta/recipes-core/glibc/glibc_2.35.bb
@@ -50,7 +50,6 @@ SRC_URI =  "${GLIBC_GIT_URI};branch=${SRCBRANCH};name=glibc \
 
file://0024-fix-create-thread-failed-in-unprivileged-process-BZ-.patch  \
 \
 
file://0001-Revert-Linux-Implement-a-useful-version-of-_startup_.patch  \
-file://CVE-2023-0687.patch  \
 "
  S = "${WORKDIR}/git"
  B = "${WORKDIR}/build-${TARGET_SYS}"



--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#182561): 
https://lists.openembedded.org/g/openembedded-core/message/182561
Mute This Topic: https://lists.openembedded.org/mt/99430711/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe-core][kirkstone][PATCH 1/1] perl: Fix CVE-2023-31486

2023-06-06 Thread Randy MacLeod via lists.openembedded.org

On 2023-06-04 23:23, Soumya via lists.openembedded.org wrote:

HTTP::Tiny 0.082, a Perl core module since 5.13.9 and available standalone on 
CPAN,
has an insecure default TLS configuration where users must opt in to verify 
certificates.

Signed-off-by: Soumya
---
  .../perl/files/CVE-2023-31486.patch   | 89 +++
  meta/recipes-devtools/perl/perl_5.34.1.bb |  1 +
  2 files changed, 90 insertions(+)
  create mode 100644 meta/recipes-devtools/perl/files/CVE-2023-31486.patch

diff --git a/meta/recipes-devtools/perl/files/CVE-2023-31486.patch 
b/meta/recipes-devtools/perl/files/CVE-2023-31486.patch
new file mode 100644
index 00..55c4bd1d47
--- /dev/null
+++ b/meta/recipes-devtools/perl/files/CVE-2023-31486.patch
@@ -0,0 +1,89 @@
+From 1490431e40e22052f75a0b3449f1f53cbd27ba92 Mon Sep 17 00:00:00 2001
+From: Dominic Hargreaves
+Date: Thu, 21 May 2020 22:53:37 +0100
+Subject: [PATCH] Enable SSL by default in HTTP::Tiny
+
+Gbp-Pq: Topic debian
+Gbp-Pq: Name http-tiny-ssl.diff
+
+CVE: CVE-2023-31486
+
+Upstream-Status: Backport 
[https://salsa.debian.org/perl-team/interpreter/perl/-/commit/1490431e40e22052f75a0b3449f1f53cbd27ba92.patch]



The upstream for the YP Perl recipe is not Debian but rather:

https://layers.openembedded.org/layerindex/branch/master/recipes/?q=perl

-> https://www.perl.org/get.html

-> https://dev.perl.org/perl5/source.html

  git clone https://github.com/Perl/perl5.git perl


Please find the equivalent patch if it's available there and re-submit.

If the patch isn't there, there is a (not very active) maint-5.34 branch so
we should send a PR there and change the Upstream-Status for the oe-core 
commit as needed.


../Randy


+
+Signed-off-by: Soumya
+---
+ cpan/HTTP-Tiny/lib/HTTP/Tiny.pm | 20 +---
+ 1 file changed, 9 insertions(+), 11 deletions(-)
+
+diff --git a/cpan/HTTP-Tiny/lib/HTTP/Tiny.pm b/cpan/HTTP-Tiny/lib/HTTP/Tiny.pm
+index 5803e45..88ba514 100644
+--- a/cpan/HTTP-Tiny/lib/HTTP/Tiny.pm
 b/cpan/HTTP-Tiny/lib/HTTP/Tiny.pm
+@@ -40,7 +40,7 @@ sub _croak { require Carp; Carp::croak(@_) }
+ #pod * C — Request timeout in seconds (default is 60) If a socket 
open,
+ #pod   read or write takes longer than the timeout, an exception is thrown.
+ #pod * C — A boolean that indicates whether to validate the SSL
+-#pod   certificate of an C — connection (default is false)
++#pod   certificate of an C — connection (default is true)
+ #pod * C — A hashref of C — options to pass through to
+ #pod   L
+ #pod
+@@ -112,7 +112,7 @@ sub new {
+ max_redirect => 5,
+ timeout  => defined $args{timeout} ? $args{timeout} : 60,
+ keep_alive   => 1,
+-verify_SSL   => $args{verify_SSL} || $args{verify_ssl} || 0, # no 
verification by default
++verify_SSL   => $args{verify_SSL} // $args{verify_ssl} // 1, # 
verification by default
+ no_proxy => $ENV{no_proxy},
+ };
+
+@@ -1038,7 +1038,7 @@ sub new {
+ timeout  => 60,
+ max_line_size=> 16384,
+ max_header_lines => 64,
+-verify_SSL   => 0,
++verify_SSL   => 1,
+ SSL_options  => {},
+ %args
+ }, $class;
+@@ -1765,7 +1765,7 @@ C — Request timeout in seconds (default is 60) 
If a socket open, read
+
+ =item *
+
+-C — A boolean that indicates whether to validate the SSL certificate of 
an C — connection (default is false)
++C — A boolean that indicates whether to validate the SSL certificate of 
an C — connection (default is true)
+
+ =item *
+
+@@ -2035,7 +2035,7 @@ Verification of server identity
+
+ =back
+
+-B.
++Bhttp://cacert.org>.
+
+-By default, HTTP::Tiny does not make any assumptions about your trust model,
+-threat level or risk tolerance.  It just aims to give you an encrypted channel
+-when you need one.
+-
+ Setting the C attribute to a true value will make HTTP::Tiny 
verify
+ that an SSL connection has a valid SSL certificate corresponding to the host
+ name of the connection and that the SSL certificate has been verified by a CA.
+ Assuming you trust the CA, this will protect against a Lhttp://en.wikipedia.org/wiki/Man-in-the-middle_attack>.  If you are
+-concerned about security, you should enable this option.
++attack|http://en.wikipedia.org/wiki/Man-in-the-middle_attack>.
++
++If you are not concerned about security, and this default in Debian causes
++problems, you should disable this option.
+
+ Certificate verification requires a file containing trusted CA certificates.
+
+--
+2.40.0
diff --git a/meta/recipes-devtools/perl/perl_5.34.1.bb 
b/meta/recipes-devtools/perl/perl_5.34.1.bb
index 42bcb8b1bc..af4660091b 100644
--- a/meta/recipes-devtools/perl/perl_5.34.1.bb
+++ b/meta/recipes-devtools/perl/perl_5.34.1.bb
@@ -18,6 +18,7 @@ SRC_URI ="https://www.cpan.org/src/5.0/perl-${PV}.tar.gz;name=perl \ 
file://determinism.patch \ 
file://0001-cpan-Sys-Syslog-Makefile.PL-Fix-_PATH_LOG-for-determ.patch 
\ file://0001-Fix-build-with-gcc-12.patch \ + 

Re: [OE-core] [PATCH] perl: fix CVE-2023-31484

2023-06-06 Thread Randy MacLeod via lists.openembedded.org

On 2023-06-06 07:38, Soumya via lists.openembedded.org wrote:

This is for kirkstone branch. Attached is the updated patch.



Soumya,


We don't usually take patches as attachments since we
like to see the changes in email easily for review so

unless Steve makes an exception this time, please
resend following the workflow documented here:

https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded


See and read the section mentioning:

   git send-email  ... --subject-prefix="][PATCH"


and the rest of the document and links therein.


../Randy







Regards,
Soumya


*From:* Richard Purdie 
*Sent:* Tuesday, June 6, 2023 4:35 PM
*To:* Sambu, Soumya ; 
openembedded-core@lists.openembedded.org 


*Subject:* Re: [OE-core] [PATCH] perl: fix CVE-2023-31484
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender 
and know the content is safe.


On Mon, 2023-06-05 at 17:46 +, Soumya via lists.openembedded.org
wrote:
> CPAN.pm before 2.35 does not verify TLS certificates when downloading
> distributions over HTTPS.
>
> Signed-off-by: Soumya 
> ---
>  .../perl/files/CVE-2023-31484.patch   | 29 +++
>  meta/recipes-devtools/perl/perl_5.34.1.bb |  1 +
>  2 files changed, 30 insertions(+)
>  create mode 100644 
meta/recipes-devtools/perl/files/CVE-2023-31484.patch


Which release is this patch against?

Cheers,

Richard





--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#182448): 
https://lists.openembedded.org/g/openembedded-core/message/182448
Mute This Topic: https://lists.openembedded.org/mt/99345985/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v14] Rust Oe-Selftest implementation

2023-05-30 Thread Randy MacLeod via lists.openembedded.org

On 2023-05-30 17:20, Richard Purdie wrote:

wait for the beginning of the fail development cycle.


Ugh, that's: FALL development cycle.

What an unfortunate typo!!

--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181967): 
https://lists.openembedded.org/g/openembedded-core/message/181967
Mute This Topic: https://lists.openembedded.org/mt/99216990/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v14] Rust Oe-Selftest implementation

2023-05-30 Thread Randy MacLeod via lists.openembedded.org

On 2023-05-30 11:05, Frédéric Martinsons wrote:

Oh okay, didn't try that personnaly.
the class is currently tied to cargo behavior so for performing rust 
core tests, it will not be suitable (at least in its present form)


Well, that's good news in that we won't have to change our approach for 
v15 !



On 2023-05-30 09:59, Richard Purdie wrote:

I did put this into a build for testing on the autobuilder. It hasn't
been running long and I can already see build failures such as:

https://autobuilder.yoctoproject.org/typhoon/#/builders/103/builds/6077
https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/7200
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/7190
https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/2923
https://autobuilder.yoctoproject.org/typhoon/#/builders/37/builds/7200
https://autobuilder.yoctoproject.org/typhoon/#/builders/48/builds/7217
https://autobuilder.yoctoproject.org/typhoon/#/builders/104/builds/6080
https://autobuilder.yoctoproject.org/typhoon/#/builders/76/builds/7146
https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/7184

and there will likely be more.

I'm finding this rather frustrating and am not sure how this was
tested.


That's probably my fault. I've been asking Yash to keep pushing and 
suggesting that

I could help him with testing but the bad news is that we (Wind River)
have the tail end of a product release cycle happening now.

I'd like to help out with this, but it'll have to wait for at least 2 
months and
that puts us close to the end of M3 so we might have to wait for the 
beginning

of the fail development cycle.

Let me talk with Yashe and Sundeep and reply with info on what to expect.

--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181941): 
https://lists.openembedded.org/g/openembedded-core/message/181941
Mute This Topic: https://lists.openembedded.org/mt/99216990/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] p11-kit: add native to BBCLASSEXTEND -> kirkstone

2023-05-24 Thread Randy MacLeod via lists.openembedded.org

On 2023-01-26 01:46, Jan Luebbe via lists.openembedded.org wrote:

This recipe is needed to build softhsm (in meta-oe) in with p11-kit
support, which is useful when multiple PKCS#11 modules need to be used.

Signed-off-by: Jan Luebbe
---
  meta/recipes-support/p11-kit/p11-kit_0.24.1.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/p11-kit/p11-kit_0.24.1.bb 
b/meta/recipes-support/p11-kit/p11-kit_0.24.1.bb
index 59cbb67961ac..72b446204a1c 100644
--- a/meta/recipes-support/p11-kit/p11-kit_0.24.1.bb
+++ b/meta/recipes-support/p11-kit/p11-kit_0.24.1.bb
@@ -29,4 +29,4 @@ FILES:${PN} += " \
  # PN contains p11-kit-proxy.so, a symlink to a loadable module
  INSANE_SKIP:${PN} = "dev-so"
  
-BBCLASSEXTEND = "nativesdk"

+BBCLASSEXTEND = "native nativesdk"

Steve, could this change be back-ported to kirkstone?







--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181672): 
https://lists.openembedded.org/g/openembedded-core/message/181672
Mute This Topic: https://lists.openembedded.org/mt/99107763/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] vim: upgrade 9.0.1429 -> 9.0.1527

2023-05-11 Thread Randy MacLeod via lists.openembedded.org

On 2023-05-11 14:54, Alexandre Belloni wrote:

Hello Randy,

This patch is missing your From: ;)
See "Fixing your From identity" here:
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded


Fixed, sent v2,

https://lists.openembedded.org/g/openembedded-core/message/181142


The from on the first line looks ugly but I guess we'll have to get used 
to it.


../Randy

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181143): 
https://lists.openembedded.org/g/openembedded-core/message/181143
Mute This Topic: https://lists.openembedded.org/mt/98829205/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [Patch v2] vim: upgrade 9.0.1429 -> 9.0.1527

2023-05-11 Thread Randy MacLeod via lists.openembedded.org
From: Randy MacLeod 

Fixes: https://nvd.nist.gov/vuln/detail/CVE-2023-2426
caf642c25 patch 9.0.1499: using uninitialized memory with fuzzy matching

Signed-off-by: Randy MacLeod 
---
 meta/recipes-support/vim/vim.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-support/vim/vim.inc b/meta/recipes-support/vim/vim.inc
index 1e27415288..e1d2563316 100644
--- a/meta/recipes-support/vim/vim.inc
+++ b/meta/recipes-support/vim/vim.inc
@@ -19,8 +19,8 @@ SRC_URI = 
"git://github.com/vim/vim.git;branch=master;protocol=https \
file://no-path-adjust.patch \
"
 
-PV .= ".1429"
-SRCREV = "1a08a3e2a584889f19b84a27672134649b73da58"
+PV .= ".1527"
+SRCREV = "c28e7a2b2f23dbd246a1ad7ad7aaa6f7ab2e5887"
 
 # Remove when 8.3 is out
 UPSTREAM_VERSION_UNKNOWN = "1"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181142): 
https://lists.openembedded.org/g/openembedded-core/message/181142
Mute This Topic: https://lists.openembedded.org/mt/98835453/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] vim: upgrade 9.0.1429 -> 9.0.1527

2023-05-11 Thread Randy MacLeod via lists.openembedded.org

On 2023-05-11 10:59, Randy MacLeod via lists.openembedded.org wrote:

Fixes:https://nvd.nist.gov/vuln/detail/CVE-2023-2426
caf642c25 patch 9.0.1499: using uninitialized memory with fuzzy matching

Signed-off-by: Randy MacLeod
---
  meta/recipes-support/vim/vim.inc | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-support/vim/vim.inc b/meta/recipes-support/vim/vim.inc
index 1e27415288..e1d2563316 100644
--- a/meta/recipes-support/vim/vim.inc
+++ b/meta/recipes-support/vim/vim.inc
@@ -19,8 +19,8 @@ SRC_URI = 
"git://github.com/vim/vim.git;branch=master;protocol=https \
 file://no-path-adjust.patch  \
 "
  
-PV .= ".1429"

-SRCREV = "1a08a3e2a584889f19b84a27672134649b73da58"
+PV .= ".1527"
+SRCREV = "c28e7a2b2f23dbd246a1ad7ad7aaa6f7ab2e5887"


I noticed that qemuppc failed to build (1) and
bisected that back to:

   fa72b850b1 gcc: upgrade 11.3 -> 12.1
from April 2022.

Tracked by:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15116

../Randy


1)

❯ cat vim-buildall.log
BUILDALL-QEMU LOG FOR vim
START TIME: 2023-05-08_17:41:29
HOSTNAME: ala-lpggp3
HOST OS: Ubuntu 22.04.1 LTS
HOST KERNEL: 5.15.0-56-generic
===
BUILD RESULTS:
[glibc]
PASS: qemuriscv32
PASS: qemuarmv5
PASS: qemumips
PASS: qemux86-64
PASS: qemuarm64
PASS: qemumips64
PASS: qemuarm
FAIL: qemuppc
PASS: qemuriscv64
PASS: qemuppc64
PASS: qemux86
FAIL: qemuloongarch64
[musl]
FAIL: qemuriscv32
PASS: qemuarmv5
PASS: qemumips
PASS: qemux86-64
PASS: qemuarm64
PASS: qemumips64
PASS: qemuarm
PASS: qemuppc
PASS: qemuriscv64
PASS: qemuppc64
PASS: qemux86
FAIL: qemuloongarch64
===
PASSED: 20
FAILED: 4

  
  # Remove when 8.3 is out

  UPSTREAM_VERSION_UNKNOWN = "1"





--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181138): 
https://lists.openembedded.org/g/openembedded-core/message/181138
Mute This Topic: https://lists.openembedded.org/mt/98829205/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] vim: upgrade 9.0.1429 -> 9.0.1527

2023-05-11 Thread Randy MacLeod via lists.openembedded.org
Fixes: https://nvd.nist.gov/vuln/detail/CVE-2023-2426
caf642c25 patch 9.0.1499: using uninitialized memory with fuzzy matching

Signed-off-by: Randy MacLeod 
---
 meta/recipes-support/vim/vim.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-support/vim/vim.inc b/meta/recipes-support/vim/vim.inc
index 1e27415288..e1d2563316 100644
--- a/meta/recipes-support/vim/vim.inc
+++ b/meta/recipes-support/vim/vim.inc
@@ -19,8 +19,8 @@ SRC_URI = 
"git://github.com/vim/vim.git;branch=master;protocol=https \
file://no-path-adjust.patch \
"
 
-PV .= ".1429"
-SRCREV = "1a08a3e2a584889f19b84a27672134649b73da58"
+PV .= ".1527"
+SRCREV = "c28e7a2b2f23dbd246a1ad7ad7aaa6f7ab2e5887"
 
 # Remove when 8.3 is out
 UPSTREAM_VERSION_UNKNOWN = "1"
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181137): 
https://lists.openembedded.org/g/openembedded-core/message/181137
Mute This Topic: https://lists.openembedded.org/mt/98829205/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [AUH] rust: upgrading to 1.69.0 FAILED -> Sundeep to do the update.

2023-05-03 Thread Randy MacLeod via lists.openembedded.org

On 2023-05-03 03:39, Alexander Kanavin wrote:

I think Alex Kiernan already sent an update here about a week ago?



Thanks Alex*  ;-)
I should have checked the list.

It's not yet merged to master or master-next; I think it's stuck behind 
the gcc-13 update
and many other commits that are causing RP and gang more trouble than 
usual this week.


../Randy




Alex


On Wed, 3 May 2023 at 01:29, Randy MacLeod  wrote:

On 2023-05-01 17:25,a...@yoctoproject.org  wrote:

Hello,

this email is a notification from the Auto Upgrade Helper
that the automatic attempt to upgrade the recipe *rust* to *1.69.0* has Failed 
(devtool error).

Detailed error information:

The following devtool command failed:  upgrade rust -V 1.69.0

Sundeep said that he will start working on this tomorrow unless someone else 
speaks up
about having the update underway. 1.70 isn't due until June 1st or so.

../Randy



--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#180836): 
https://lists.openembedded.org/g/openembedded-core/message/180836
Mute This Topic: https://lists.openembedded.org/mt/98651181/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [AUH] rust: upgrading to 1.69.0 FAILED -> Sundeep to do the update.

2023-05-02 Thread Randy MacLeod via lists.openembedded.org

On 2023-05-01 17:25, a...@yoctoproject.org wrote:

Hello,

this email is a notification from the Auto Upgrade Helper
that the automatic attempt to upgrade the recipe *rust* to *1.69.0* has Failed 
(devtool error).

Detailed error information:

The following devtool command failed:  upgrade rust -V 1.69.0


Sundeep said that he will start working on this tomorrow unless someone 
else speaks up

about having the update underway. 1.70 isn't due until June 1st or so.

../Randy



NOTE: Starting bitbake server...
NOTE: Reconnecting to bitbake server...
NOTE: Retrying server connection (#1)... (14:02:48.244299)
Loading cache...done.
Loaded 1799 entries from dependency cache.
Removing 1 recipes from the x86_64 sysroot...done.
NOTE: Resolving any missing task queue dependencies

Build Configuration:
BB_VERSION   = "2.4.0"
BUILD_SYS= "x86_64-linux"
NATIVELSBSTRING  = "universal"
TARGET_SYS   = "x86_64-poky-linux"
MACHINE  = "qemux86-64"
DISTRO   = "poky"
DISTRO_VERSION   = "4.2"
TUNE_FEATURES= "m64 core2"
TARGET_FPU   = ""
meta
meta-poky
meta-yocto-bsp   = 
"tmp-auh-upgrades:c08f5fabc6f19121f285caaed7c99e1ba459baab"
workspace= "master:cce6db2a59d309f77c1f9ca173fc674c506062d0"

Initialising tasks...done.
Sstate summary: Wanted 0 Local 0 Mirrors 0 Missed 0 Current 22 (0% match, 100% 
complete)
NOTE: Executing Tasks
NOTE: Tasks Summary: Attempted 102 tasks of which 99 didn't need to be rerun 
and all succeeded.
NOTE: Writing buildhistory
NOTE: Writing buildhistory took: 2 seconds
Loading cache...done.
Loaded 1799 entries from dependency cache.
Parsing recipes...done.
Parsing of 900 .bb files complete (898 cached, 2 parsed). 1800 targets, 39 
skipped, 0 masked, 0 errors.
NOTE: Resolving any missing task queue dependencies

Build Configuration:
BB_VERSION   = "2.4.0"
BUILD_SYS= "x86_64-linux"
NATIVELSBSTRING  = "universal"
TARGET_SYS   = "x86_64-poky-linux"
MACHINE  = "qemux86-64"
DISTRO   = "poky"
DISTRO_VERSION   = "4.2"
TUNE_FEATURES= "m64 core2"
TARGET_FPU   = ""
meta
meta-poky
meta-yocto-bsp   = 
"tmp-auh-upgrades:c08f5fabc6f19121f285caaed7c99e1ba459baab"
workspace= "master:cce6db2a59d309f77c1f9ca173fc674c506062d0"

Initialising tasks...done.
Sstate summary: Wanted 0 Local 0 Mirrors 0 Missed 0 Current 18 (0% match, 100% 
complete)
NOTE: Executing Tasks
NOTE: Tasks Summary: Attempted 83 tasks of which 81 didn't need to be rerun and 
all succeeded.
NOTE: Writing buildhistory
NOTE: Writing buildhistory took: 2 seconds
DEBUG 5 [Errno 25] Inappropriate ioctl for device
Adding changed files:   0% |   | ETA:  --:--:--
Adding changed files:   0% |   | ETA:  --:--:--
Adding changed files:   1% || ETA:  0:01:03
Adding changed files:   2% || ETA:  0:00:45
Adding changed files:   3% |#   | ETA:  0:00:40
Adding changed files:   4% |#   | ETA:  0:00:36
Adding changed files:   5% |#   | ETA:  0:00:34
Adding changed files:   6% |##  | ETA:  0:00:33
Adding changed files:   7% |##  | ETA:  0:00:32
Adding changed files:   8% |##  | ETA:  0:00:31
Adding changed files:   9% |### | ETA:  0:00:30
Adding changed files:  10% |### | ETA:  0:00:30
Adding changed files:  11% || ETA:  0:00:29
Adding changed files:  12% || ETA:  0:00:29
Adding changed files:  13% || ETA:  0:00:28
Adding changed files:  14% |#   | ETA:  0:00:27
Adding changed files:  15% |#   | ETA:  0:00:27
Adding changed files:  16% |#   | ETA:  0:00:27
Adding changed files:  17% |##  | ETA:  0:00:26
Adding changed files:  18% |##  | ETA:  0:00:26
Adding changed files:  19% |##  | ETA:  0:00:25
Adding changed files:  20% |### | ETA:  0:00:25
Adding changed files:  21% |### | ETA:  0:00:25
Adding changed files:  22% || ETA:  0:00:24
Adding changed files:  23% || ETA:  0:00:24
Adding changed files:  24% || ETA:  0:00:23
Adding changed files:  25% |#   | ETA:  0:00:23
Adding changed files:  26% |#   | ETA:  0:00:23
Adding changed files:  27% |#   | ETA:  

Re: [OE-core] [PATCH v2] machine/qemuarm*: don't explicitly set vmalloc

2023-05-02 Thread Randy MacLeod via lists.openembedded.org

On 2023-04-18 12:54, Khem Raj via lists.openembedded.org wrote:

On Tue, Apr 18, 2023 at 9:41 AM Ross Burton  wrote:

In 5c6064 the qemuarm* machines gained vmalloc=256, because in testing
Bruce was seeing problems when the vmalloc area was too big for the
memory size of the machine (eg 256MB).


default seems to be 128M for 32bit systems with memory < 1G and 256M
for memory < 2G
but I think using defaults might be preferred it works with original problem too



I think we should backport this to mickledore, right Ross?

Steve, is so does it apply cleanly or should Narpat send a PR?

../Randy





The intention was for the area to be very small, but 256 bytes is too
small and the kernel sets a minimal vmalloc area of 16MiB:

[0.00] vmalloc area is too small, limiting to 16MiB

However, a 16MiB area is too small and results in pages of messages when
you try and use the system:

[  242.822481] vmap allocation for size 4100096 failed: use vmalloc= to 
increase size

There have been a number of changes since this commit, remove the
explicit vmalloc argument and use the default.  I've tested that the
system still boots locally.

[1] 
early_vmalloc(),https://elixir.bootlin.com/linux/latest/source/arch/arm/mm/mmu.c#L1170
Signed-off-by: Ross Burton
---
  meta/conf/machine/qemuarm.conf   | 2 --
  meta/conf/machine/qemuarmv5.conf | 1 -
  2 files changed, 3 deletions(-)

diff --git a/meta/conf/machine/qemuarm.conf b/meta/conf/machine/qemuarm.conf
index c5234231e2e..aa9ce882035 100644
--- a/meta/conf/machine/qemuarm.conf
+++ b/meta/conf/machine/qemuarm.conf
@@ -17,8 +17,6 @@ QB_SYSTEM_NAME = "qemu-system-arm"
  QB_MACHINE = "-machine virt,highmem=off"
  QB_CPU = "-cpu cortex-a15"
  QB_SMP ?= "-smp 4"
-# Standard Serial console
-QB_KERNEL_CMDLINE_APPEND = "vmalloc=256"
  # For graphics to work we need to define the VGA device as well as the 
necessary USB devices
  QB_GRAPHICS = "-device virtio-gpu-pci"
  QB_OPT_APPEND = "-device qemu-xhci -device usb-tablet -device usb-kbd"
diff --git a/meta/conf/machine/qemuarmv5.conf b/meta/conf/machine/qemuarmv5.conf
index 6e59e42c3ab..ef1b4ece230 100644
--- a/meta/conf/machine/qemuarmv5.conf
+++ b/meta/conf/machine/qemuarmv5.conf
@@ -12,7 +12,6 @@ SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;ttyAMA1"
  # For runqemu
  QB_SYSTEM_NAME = "qemu-system-arm"
  QB_MACHINE = "-machine versatilepb"
-QB_KERNEL_CMDLINE_APPEND = "vmalloc=256"
  QB_GRAPHICS = "-device virtio-gpu-pci"
  QB_OPT_APPEND = "-device qemu-xhci -device usb-tablet -device usb-kbd"
  QB_DTB ="${@oe.utils.version_less_or_equal('PREFERRED_VERSION_linux-yocto', 
'4.7', '', 'zImage-versatile-pb.dtb', d)}"

--
2.34.1









--
# Randy MacLeod
# Wind River Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#180755): 
https://lists.openembedded.org/g/openembedded-core/message/180755
Mute This Topic: https://lists.openembedded.org/mt/98348317/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][kirkstone][PATCH 1/1] ffmpeg: fix for CVE-2022-48434

2023-05-02 Thread Randy MacLeod via lists.openembedded.org

On 2023-04-28 12:58, Narpat Mali via lists.openembedded.org wrote:

From: Narpat Mali

libavcodec/pthread_frame.c in FFmpeg before 5.1.2, as used in VLC and
other products, leaves stale hwaccel state in worker threads, which
allows attackers to trigger a use-after-free and execute arbitrary
code in some circumstances (e.g., hardware re-initialization upon a
mid-video SPS change when Direct3D11 is used).


Thanks for working on this fix.

LGTM but see some nitpics below.

../Randy



Note that it's nice to minimize whitespace noise (but no need to re-submit):

poky.git on kirkstone [$]

❯ git am /tmp/narpat-ffmpeg.eml
Applying: ffmpeg: fix for CVE-2022-48434
.git/rebase-apply/patch:49: trailing whitespace.

.git/rebase-apply/patch:53: trailing whitespace.

.git/rebase-apply/patch:66: trailing whitespace.

.git/rebase-apply/patch:72: trailing whitespace.

.git/rebase-apply/patch:81: trailing whitespace.

warning: squelched 8 whitespace errors
warning: 13 lines add whitespace errors.


I also note that in the ffmpeg git repo, this commit has been back-ported:

ffmpeg.git on release/5.0
❯ git log --oneline -1 3bc28e9d1ab33627cea3c632dd6b0c33e22e93ba
3bc28e9d1a lavc/pthread_frame: avoid leaving stale hwaccel state in 
worker threads


ffmpeg.git on release/5.0
❯ git branch -a --contains 3bc28e9d1ab33627cea3c632dd6b0c33e22e93ba
* release/5.0
  remotes/origin/release/5.0


Your patch is identical to the backport so that's good and we can accept 
the patch
unless Steve finds a problem. Next time, check the git repo and see if 
there is a
branch that matches the version we're using and if someone has already 
done the

backport.


../Randy


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#180740): 
https://lists.openembedded.org/g/openembedded-core/message/180740
Mute This Topic: https://lists.openembedded.org/mt/98562871/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-