Re: [OE-core][PATCH] llvm: Remove -fcommon
On Tue, May 12, 2020 at 08:17:15AM -0700, Khem Raj wrote: > On 5/12/20 7:14 AM, Adrian Bunk wrote: > > I cannot reproduce the problem. > > have you built the target recipe with gcc10 with -fno-common default ? Yes. For menu-cache and matchbox-wm I got failures without the patches, but not for llvm. cu Adrian -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#138184): https://lists.openembedded.org/g/openembedded-core/message/138184 Mute This Topic: https://lists.openembedded.org/mt/74159120/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH] llvm: Remove -fcommon
On 5/12/20 7:14 AM, Adrian Bunk wrote: I cannot reproduce the problem. have you built the target recipe with gcc10 with -fno-common default ? Signed-off-by: Adrian Bunk --- meta/recipes-devtools/llvm/llvm_git.bb | 2 -- 1 file changed, 2 deletions(-) diff --git a/meta/recipes-devtools/llvm/llvm_git.bb b/meta/recipes-devtools/llvm/llvm_git.bb index a8607f5008..d24ed761bf 100644 --- a/meta/recipes-devtools/llvm/llvm_git.bb +++ b/meta/recipes-devtools/llvm/llvm_git.bb @@ -92,8 +92,6 @@ EXTRA_OECMAKE_append_class-nativesdk = "\ -DLLVM_CONFIG_PATH=${STAGING_BINDIR_NATIVE}/llvm-config${PV} \ " -CFLAGS += "-fcommon" - do_configure_prepend() { # Fix paths in llvm-config sed -i "s|sys::path::parent_path(CurrentPath))\.str()|sys::path::parent_path(sys::path::parent_path(CurrentPath))).str()|g" ${S}/tools/llvm-config/llvm-config.cpp -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#138180): https://lists.openembedded.org/g/openembedded-core/message/138180 Mute This Topic: https://lists.openembedded.org/mt/74159120/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core][PATCH] llvm: Remove -fcommon
I cannot reproduce the problem. Signed-off-by: Adrian Bunk --- meta/recipes-devtools/llvm/llvm_git.bb | 2 -- 1 file changed, 2 deletions(-) diff --git a/meta/recipes-devtools/llvm/llvm_git.bb b/meta/recipes-devtools/llvm/llvm_git.bb index a8607f5008..d24ed761bf 100644 --- a/meta/recipes-devtools/llvm/llvm_git.bb +++ b/meta/recipes-devtools/llvm/llvm_git.bb @@ -92,8 +92,6 @@ EXTRA_OECMAKE_append_class-nativesdk = "\ -DLLVM_CONFIG_PATH=${STAGING_BINDIR_NATIVE}/llvm-config${PV} \ " -CFLAGS += "-fcommon" - do_configure_prepend() { # Fix paths in llvm-config sed -i "s|sys::path::parent_path(CurrentPath))\.str()|sys::path::parent_path(sys::path::parent_path(CurrentPath))).str()|g" ${S}/tools/llvm-config/llvm-config.cpp -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#138169): https://lists.openembedded.org/g/openembedded-core/message/138169 Mute This Topic: https://lists.openembedded.org/mt/74159120/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-