Re: [OE-core][PATCH 0/4] patchtest: add to oe-core

2023-10-17 Thread Trevor Gamblin


On 2023-10-17 11:45, Michael Opdenacker wrote:

Hi Trevor

On 16.10.23 at 21:44, Trevor Gamblin wrote:

Add the patchtest core tools and supporting scripts to
openembedded-core. This will enable users to validate their changes
locally against the repository before submission to the mailing list,
reducing maintainer overhead and encouraging more consistent use of
important patch tags and information. Note that there are a few elements
of the tooling that are still under development, namely the
patchtest-send-results script, which is currently hard-coded to mail
test results to test-l...@lists.yoctoproject.org (and only that list),
while in the future it may be adjusted to directly reply to user
submissions.

A scripts/patchtest.README file is included for basic instructions on
how to use patchtest, as well as for submitting fixes should any bugs be
identified. The Yocto Project Contributor Guide will receive a single,
corresponding patch to provide similar details on why and how to use
patchtest. Finally, the patchtest layer itself will be reduced to only
those pieces that are required for building the core-image-patchtest
image, which makes special adjustments to kernel configurations and
initscripts that are only suitable for automation, and therefore outside
the scope of most contributors' usage.

Trevor Gamblin (4):
   patchtest/requirements.txt: update
   patchtest: add supporting modules
   patchtest: add scripts to oe-core
   patchtest: set default repo and testdir targets

  meta/lib/patchtest/data.py  | 100 
  meta/lib/patchtest/patch.py |  73 +
  meta/lib/patchtest/repo.py  | 185 ++
  meta/lib/patchtest/requirements.txt |   2 +
  meta/lib/patchtest/utils.py | 179 +
  scripts/patchtest   | 233 
  scripts/patchtest-get-branch    |  92 +++
  scripts/patchtest-get-series    | 125 +++
  scripts/patchtest-send-results  |  93 +++
  scripts/patchtest-setup-sharedir    |  95 
  scripts/patchtest.README    | 156 +++
  11 files changed, 1333 insertions(+)
  create mode 100644 meta/lib/patchtest/data.py
  create mode 100644 meta/lib/patchtest/patch.py
  create mode 100644 meta/lib/patchtest/repo.py
  create mode 100644 meta/lib/patchtest/utils.py
  create mode 100755 scripts/patchtest
  create mode 100755 scripts/patchtest-get-branch
  create mode 100755 scripts/patchtest-get-series
  create mode 100755 scripts/patchtest-send-results
  create mode 100755 scripts/patchtest-setup-sharedir
  create mode 100644 scripts/patchtest.README


Thanks for this!

I tried "patchtest --patch" with the attached patch, which had its 
"Signed-off-by" line intentionally removed.

However, it didn't find the issue (see the attached log).

Did I miss anything in the way I use it?


Hi Michael,

This is a little odd, I can't reproduce what you're seeing even with a 
fresh checkout of poky, so I'm wondering if maybe it's because Python 
modules are missing on the host. However, patchtest is currently only 
designed to work properly with oe-core patches, and trying to point it 
at yocto-docs will cause a failure because it expects the 
yocto-docs/scripts/lib path to exist for use (normally it will look in 
openembedded-core/scripts/lib for a few modules). This is one of the 
things I want to improve now that it's working again. In the meantime, 
This is some important info for the docs I had missed, so I'll send a 
patch with clarification about where patchtest can be used.


- Trevor


Thanks again
Michael.


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#189345): 
https://lists.openembedded.org/g/openembedded-core/message/189345
Mute This Topic: https://lists.openembedded.org/mt/102003998/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH 0/4] patchtest: add to oe-core

2023-10-17 Thread Michael Opdenacker via lists.openembedded.org

Hi Trevor

On 16.10.23 at 21:44, Trevor Gamblin wrote:

Add the patchtest core tools and supporting scripts to
openembedded-core. This will enable users to validate their changes
locally against the repository before submission to the mailing list,
reducing maintainer overhead and encouraging more consistent use of
important patch tags and information. Note that there are a few elements
of the tooling that are still under development, namely the
patchtest-send-results script, which is currently hard-coded to mail
test results to test-l...@lists.yoctoproject.org (and only that list),
while in the future it may be adjusted to directly reply to user
submissions.

A scripts/patchtest.README file is included for basic instructions on
how to use patchtest, as well as for submitting fixes should any bugs be
identified. The Yocto Project Contributor Guide will receive a single,
corresponding patch to provide similar details on why and how to use
patchtest. Finally, the patchtest layer itself will be reduced to only
those pieces that are required for building the core-image-patchtest
image, which makes special adjustments to kernel configurations and
initscripts that are only suitable for automation, and therefore outside
the scope of most contributors' usage.

Trevor Gamblin (4):
   patchtest/requirements.txt: update
   patchtest: add supporting modules
   patchtest: add scripts to oe-core
   patchtest: set default repo and testdir targets

  meta/lib/patchtest/data.py  | 100 
  meta/lib/patchtest/patch.py |  73 +
  meta/lib/patchtest/repo.py  | 185 ++
  meta/lib/patchtest/requirements.txt |   2 +
  meta/lib/patchtest/utils.py | 179 +
  scripts/patchtest   | 233 
  scripts/patchtest-get-branch|  92 +++
  scripts/patchtest-get-series| 125 +++
  scripts/patchtest-send-results  |  93 +++
  scripts/patchtest-setup-sharedir|  95 
  scripts/patchtest.README| 156 +++
  11 files changed, 1333 insertions(+)
  create mode 100644 meta/lib/patchtest/data.py
  create mode 100644 meta/lib/patchtest/patch.py
  create mode 100644 meta/lib/patchtest/repo.py
  create mode 100644 meta/lib/patchtest/utils.py
  create mode 100755 scripts/patchtest
  create mode 100755 scripts/patchtest-get-branch
  create mode 100755 scripts/patchtest-get-series
  create mode 100755 scripts/patchtest-send-results
  create mode 100755 scripts/patchtest-setup-sharedir
  create mode 100644 scripts/patchtest.README


Thanks for this!

I tried "patchtest --patch" with the attached patch, which had its 
"Signed-off-by" line intentionally removed.

However, it didn't find the issue (see the attached log).

Did I miss anything in the way I use it?
Thanks again
Michael.

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
From 2e1d43af896722a8788be102df1b975819ecf678 Mon Sep 17 00:00:00 2001
From: Michael Opdenacker 
Date: Tue, 17 Oct 2023 15:07:09 +0200
Subject: [PATCH] brief-yoctoprojectqs: use new CDN mirror for sstate

Recommended instead of the Yocto Project mirror, because expected
to be faster. Make sure you only set one such mirror.

CC: richard.pur...@linuxfoundation.org
---
 documentation/brief-yoctoprojectqs/index.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/documentation/brief-yoctoprojectqs/index.rst b/documentation/brief-yoctoprojectqs/index.rst
index 0ccffccc60..df8d75edc2 100644
--- a/documentation/brief-yoctoprojectqs/index.rst
+++ b/documentation/brief-yoctoprojectqs/index.rst
@@ -254,7 +254,7 @@ an entire Linux distribution, including the toolchain, from source.
  BB_SIGNATURE_HANDLER = "OEEquivHash"
  BB_HASHSERVE = "auto"
  BB_HASHSERVE_UPSTREAM = "hashserv.yocto.io:8687"
- SSTATE_MIRRORS ?= "file://.* https://sstate.yoctoproject.org/all/PATH;downloadfilename=PATH;
+ SSTATE_MIRRORS ?= "file://.* http://cdn.jsdelivr.net/yocto/sstate/all/PATH;downloadfilename=PATH;
 
 #. **Start the Build:** Continue with the following command to build an OS
image for the target, which is ``core-image-sato`` in this example:
-- 
2.34.1

Testing patch /home/mike/work/git/git.yoctoproject.org/yocto-docs/documentation/0001-brief-yoctoprojectqs-use-new-CDN-mirror-for-sstate.patch
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
--
Ran 18 tests in 0.403s

OK
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None
NoneType: None
None

[OE-core][PATCH 0/4] patchtest: add to oe-core

2023-10-16 Thread Trevor Gamblin
Add the patchtest core tools and supporting scripts to
openembedded-core. This will enable users to validate their changes
locally against the repository before submission to the mailing list,
reducing maintainer overhead and encouraging more consistent use of
important patch tags and information. Note that there are a few elements
of the tooling that are still under development, namely the
patchtest-send-results script, which is currently hard-coded to mail
test results to test-l...@lists.yoctoproject.org (and only that list),
while in the future it may be adjusted to directly reply to user
submissions.

A scripts/patchtest.README file is included for basic instructions on
how to use patchtest, as well as for submitting fixes should any bugs be
identified. The Yocto Project Contributor Guide will receive a single,
corresponding patch to provide similar details on why and how to use
patchtest. Finally, the patchtest layer itself will be reduced to only
those pieces that are required for building the core-image-patchtest
image, which makes special adjustments to kernel configurations and
initscripts that are only suitable for automation, and therefore outside
the scope of most contributors' usage.

Trevor Gamblin (4):
  patchtest/requirements.txt: update
  patchtest: add supporting modules
  patchtest: add scripts to oe-core
  patchtest: set default repo and testdir targets

 meta/lib/patchtest/data.py  | 100 
 meta/lib/patchtest/patch.py |  73 +
 meta/lib/patchtest/repo.py  | 185 ++
 meta/lib/patchtest/requirements.txt |   2 +
 meta/lib/patchtest/utils.py | 179 +
 scripts/patchtest   | 233 
 scripts/patchtest-get-branch|  92 +++
 scripts/patchtest-get-series| 125 +++
 scripts/patchtest-send-results  |  93 +++
 scripts/patchtest-setup-sharedir|  95 
 scripts/patchtest.README| 156 +++
 11 files changed, 1333 insertions(+)
 create mode 100644 meta/lib/patchtest/data.py
 create mode 100644 meta/lib/patchtest/patch.py
 create mode 100644 meta/lib/patchtest/repo.py
 create mode 100644 meta/lib/patchtest/utils.py
 create mode 100755 scripts/patchtest
 create mode 100755 scripts/patchtest-get-branch
 create mode 100755 scripts/patchtest-get-series
 create mode 100755 scripts/patchtest-send-results
 create mode 100755 scripts/patchtest-setup-sharedir
 create mode 100644 scripts/patchtest.README

-- 
2.41.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#189309): 
https://lists.openembedded.org/g/openembedded-core/message/189309
Mute This Topic: https://lists.openembedded.org/mt/102003998/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-