Re: [OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-19 Thread Burton, Ross 
On 19 April 2017 at 04:45, Kyle Russell  wrote:

> Thank you.  Do I need to submit an amended patch to the mailing list, or
> will your fixup get merged in from your staging branch pending no problems?
>

Don't worry about it, I've fixed it.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-18 Thread Kyle Russell 
Thank you.  Do I need to submit an amended patch to the mailing list, or
will your fixup get merged in from your staging branch pending no problems?

On Tue, Apr 18, 2017 at 3:17 PM, Burton, Ross  wrote:

>
> On 18 April 2017 at 19:53, Khem Raj  wrote:
>
>> dont use == here that will make it bash specific.
>>
>
> Well spotted Khem.  I've merged this into my staging branch with the test
> changed to = for POSIXness.
>
> Thanks,
> Ross
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-18 Thread Burton, Ross 
On 18 April 2017 at 19:53, Khem Raj  wrote:

> dont use == here that will make it bash specific.
>

Well spotted Khem.  I've merged this into my staging branch with the test
changed to = for POSIXness.

Thanks,
Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-18 Thread Khem Raj 
On Tue, Apr 18, 2017 at 8:02 AM, Kyle Russell  wrote:
> If CMAKE_SYSTEM_NAME is defined, CMake assumes we're cross-compiling,
> which is not necessarily the case.
> ---
>  meta/classes/cmake.bbclass | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
> index 9e74599..2dbaa8c 100644
> --- a/meta/classes/cmake.bbclass
> +++ b/meta/classes/cmake.bbclass
> @@ -42,9 +42,13 @@ def map_target_arch_to_uname_arch(target_arch):
>  return target_arch
>
>  cmake_do_generate_toolchain_file() {
> +   if [ "${BUILD_SYS}" == "${HOST_SYS}" ]; then

dont use == here that will make it bash specific.

> +   CMAKE_CROSSCOMPILING="set( CMAKE_CROSSCOMPILING FALSE )"
> +   fi
> cat > ${WORKDIR}/toolchain.cmake <  # CMake system name must be something like "Linux".
>  # This is important for cross-compiling.
> +${CMAKE_CROSSCOMPILING}
>  set( CMAKE_SYSTEM_NAME `echo ${TARGET_OS} | sed -e 's/^./\u&/' -e 
> 's/^\(Linux\).*/\1/'` )
>  set( CMAKE_SYSTEM_PROCESSOR 
> ${@map_target_arch_to_uname_arch(d.getVar('TARGET_ARCH'))} )
>  set( CMAKE_C_COMPILER ${OECMAKE_C_COMPILER} )
> --
> 2.7.4
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-18 Thread Kyle Russell 
If CMAKE_SYSTEM_NAME is defined, CMake assumes we're cross-compiling,
which is not necessarily the case.

Signed-off-by: Kyle Russell 
---
 meta/classes/cmake.bbclass | 4 
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
index 9e74599..2dbaa8c 100644
--- a/meta/classes/cmake.bbclass
+++ b/meta/classes/cmake.bbclass
@@ -42,9 +42,13 @@ def map_target_arch_to_uname_arch(target_arch):
 return target_arch
 
 cmake_do_generate_toolchain_file() {
+   if [ "${BUILD_SYS}" == "${HOST_SYS}" ]; then
+   CMAKE_CROSSCOMPILING="set( CMAKE_CROSSCOMPILING FALSE )"
+   fi
cat > ${WORKDIR}/toolchain.cmake

[OE-core] [PATCH] cmake.bbclass: Set CMAKE_CROSSCOMPILING correctly

2017-04-18 Thread Kyle Russell 
If CMAKE_SYSTEM_NAME is defined, CMake assumes we're cross-compiling,
which is not necessarily the case.
---
 meta/classes/cmake.bbclass | 4 
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
index 9e74599..2dbaa8c 100644
--- a/meta/classes/cmake.bbclass
+++ b/meta/classes/cmake.bbclass
@@ -42,9 +42,13 @@ def map_target_arch_to_uname_arch(target_arch):
 return target_arch
 
 cmake_do_generate_toolchain_file() {
+   if [ "${BUILD_SYS}" == "${HOST_SYS}" ]; then
+   CMAKE_CROSSCOMPILING="set( CMAKE_CROSSCOMPILING FALSE )"
+   fi
cat > ${WORKDIR}/toolchain.cmake