Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On 02/08/2012 08:06 AM, Andrei Gherzan wrote: 1. Update to 4.2.3-P2 2. From 4.2.0 final release, -lcrypto check was removed and we compile static libraries from bind that are linked to libcrypto. This is why i added a patch in order to add -lcrypto to LIBS. Signed-off-by: Andrei Gherzanand...@gherzan.ro --- .../dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch | 86 .../dhcp/dhcp-4.2.0/fix-client-path.patch | 23 - .../dhcp/dhcp-4.2.0/fix-external-bind.patch| 103 .../dhcp/dhcp-4.2.0/fixincludes.patch | 12 --- .../dhcp/dhcp-4.2.0/noattrmode.patch | 21 meta/recipes-connectivity/dhcp/dhcp-4.2.0/site.h | 21 .../dhcp-4.2.3-P2/dhcp-3.0.3-dhclient-dbus.patch | 86 .../dhcp/dhcp-4.2.3-P2/fix-client-path.patch | 23 + .../dhcp/dhcp-4.2.3-P2/fix-external-bind.patch | 103 .../dhcp/dhcp-4.2.3-P2/fixincludes.patch | 12 +++ .../dhcp/dhcp-4.2.3-P2/link-with-lcrypto.patch | 25 + .../dhcp/dhcp-4.2.3-P2/noattrmode.patch| 21 .../recipes-connectivity/dhcp/dhcp-4.2.3-P2/site.h | 21 meta/recipes-connectivity/dhcp/dhcp.inc|9 +-- meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb | 12 --- meta/recipes-connectivity/dhcp/dhcp_4.2.3-P2.bb| 12 +++ 16 files changed, 305 insertions(+), 285 deletions(-) delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fix-client-path.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fix-external-bind.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fixincludes.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/noattrmode.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/site.h create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/dhcp-3.0.3-dhclient-dbus.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fix-client-path.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fix-external-bind.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fixincludes.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/link-with-lcrypto.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/noattrmode.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/site.h delete mode 100644 meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb create mode 100644 meta/recipes-connectivity/dhcp/dhcp_4.2.3-P2.bb Merged into OE-core Thanks Sau! ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH] dhcp: Update to 4.2.3-P2
1. Update to 4.2.3-P2 2. From 4.2.0 final release, -lcrypto check was removed and we compile static libraries from bind that are linked to libcrypto. This is why i added a patch in order to add -lcrypto to LIBS. Signed-off-by: Andrei Gherzan and...@gherzan.ro --- .../dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch | 86 .../dhcp/dhcp-4.2.0/fix-client-path.patch | 23 - .../dhcp/dhcp-4.2.0/fix-external-bind.patch| 103 .../dhcp/dhcp-4.2.0/fixincludes.patch | 12 --- .../dhcp/dhcp-4.2.0/noattrmode.patch | 21 meta/recipes-connectivity/dhcp/dhcp-4.2.0/site.h | 21 .../dhcp-4.2.3-P2/dhcp-3.0.3-dhclient-dbus.patch | 86 .../dhcp/dhcp-4.2.3-P2/fix-client-path.patch | 23 + .../dhcp/dhcp-4.2.3-P2/fix-external-bind.patch | 103 .../dhcp/dhcp-4.2.3-P2/fixincludes.patch | 12 +++ .../dhcp/dhcp-4.2.3-P2/link-with-lcrypto.patch | 25 + .../dhcp/dhcp-4.2.3-P2/noattrmode.patch| 21 .../recipes-connectivity/dhcp/dhcp-4.2.3-P2/site.h | 21 meta/recipes-connectivity/dhcp/dhcp.inc|9 +-- meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb | 12 --- meta/recipes-connectivity/dhcp/dhcp_4.2.3-P2.bb| 12 +++ 16 files changed, 305 insertions(+), 285 deletions(-) delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fix-client-path.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fix-external-bind.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fixincludes.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/noattrmode.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/site.h create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/dhcp-3.0.3-dhclient-dbus.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fix-client-path.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fix-external-bind.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fixincludes.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/link-with-lcrypto.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/noattrmode.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/site.h delete mode 100644 meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb create mode 100644 meta/recipes-connectivity/dhcp/dhcp_4.2.3-P2.bb diff --git a/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch b/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch deleted file mode 100644 index b4a666d..000 --- a/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch +++ /dev/null @@ -1,86 +0,0 @@ -Upstream-Status: Inappropriate [distribution] - client/scripts/bsdos -+++ client/scripts/bsdos -@@ -47,6 +47,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/freebsd -+++ client/scripts/freebsd -@@ -57,6 +57,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/linux -+++ client/scripts/linux -@@ -69,6 +69,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/netbsd -+++ client/scripts/netbsd -@@ -47,6 +47,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/openbsd -+++ client/scripts/openbsd -@@ -47,6 +47,11 @@ - .
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On Wed, Feb 8, 2012 at 14:10, Phil Blundell ph...@gnu.org wrote:
This isn't just a straightforward update, you seem to be moving dhclient
from ${base_sbindir} to ${sbindir}. If that's a good thing (which
doesn't seem totally obvious to me) then it ought at least to be
mentioned in the commit message.
He is doing that because it links against libcrypt that is at ${libdir}.
But it clearly needs to be in another commit or, at least, explicit in the
changlog.
--
Otavio Salvador O.S. Systems
E-mail: ota...@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On 2/8/12 11:10 AM, Phil Blundell wrote:
On Wed, 2012-02-08 at 18:06 +0200, Andrei Gherzan wrote:
1. Update to 4.2.3-P2
2. From 4.2.0 final release, -lcrypto check was removed and we compile static
libraries
from bind that are linked to libcrypto. This is why i added a patch in order to
add
-lcrypto to LIBS.
Signed-off-by: Andrei Gherzanand...@gherzan.ro
[...]
@@ -66,7 +61,7 @@ FILES_dhcp-server-config = ${sysconfdir}/default/dhcp-server
${sysconfdir}/dhcp
FILES_dhcp-relay = ${sbindir}/dhcrelay ${sysconfdir}/init.d/dhcp-relay
${sysconfdir}/default/dhcp-relay
-FILES_dhcp-client = ${base_sbindir}/dhclient ${base_sbindir}/dhclient-script
${sysconfdir}/dhcp/dhclient.conf
+FILES_dhcp-client = ${sbindir}/dhclient ${base_sbindir}/dhclient-script
${sysconfdir}/dhcp/dhclient.conf
RDEPENDS_dhcp-client = bash
FILES_dhcp-omshell = ${bindir}/omshell
This isn't just a straightforward update, you seem to be moving dhclient
from ${base_sbindir} to ${sbindir}. If that's a good thing (which
doesn't seem totally obvious to me) then it ought at least to be
mentioned in the commit message.
I believe that dhcp-client was in the base_sbindir specifically to enable early
boot/network setup before /usr is potentially available. I think this is still
desired.
--Mark
p.
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On 02/08/2012 06:31 PM, Mark Hatle wrote:
On 2/8/12 11:10 AM, Phil Blundell wrote:
On Wed, 2012-02-08 at 18:06 +0200, Andrei Gherzan wrote:
1. Update to 4.2.3-P2
2. From 4.2.0 final release, -lcrypto check was removed and we
compile static libraries
from bind that are linked to libcrypto. This is why i added a patch
in order to add
-lcrypto to LIBS.
Signed-off-by: Andrei Gherzanand...@gherzan.ro
[...]
@@ -66,7 +61,7 @@ FILES_dhcp-server-config =
${sysconfdir}/default/dhcp-server ${sysconfdir}/dhcp
FILES_dhcp-relay = ${sbindir}/dhcrelay
${sysconfdir}/init.d/dhcp-relay ${sysconfdir}/default/dhcp-relay
-FILES_dhcp-client = ${base_sbindir}/dhclient
${base_sbindir}/dhclient-script ${sysconfdir}/dhcp/dhclient.conf
+FILES_dhcp-client = ${sbindir}/dhclient
${base_sbindir}/dhclient-script ${sysconfdir}/dhcp/dhclient.conf
RDEPENDS_dhcp-client = bash
FILES_dhcp-omshell = ${bindir}/omshell
This isn't just a straightforward update, you seem to be moving dhclient
from ${base_sbindir} to ${sbindir}. If that's a good thing (which
doesn't seem totally obvious to me) then it ought at least to be
mentioned in the commit message.
I believe that dhcp-client was in the base_sbindir specifically to
enable early boot/network setup before /usr is potentially available.
I think this is still desired.
In this case we will have to move -lcrypto as it is in ${libdir}.
Change-log will be edited after this will be cleared (sorry).
But still we need to conclude on a solution about this.
@g
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On Wed, 2012-02-08 at 14:30 -0200, Otavio Salvador wrote:
On Wed, Feb 8, 2012 at 14:10, Phil Blundell ph...@gnu.org wrote:
This isn't just a straightforward update, you seem to be
moving dhclient
from ${base_sbindir} to ${sbindir}. If that's a good thing
(which
doesn't seem totally obvious to me) then it ought at least to
be
mentioned in the commit message.
He is doing that because it links against libcrypt that is at
${libdir}. But it clearly needs to be in another commit or, at least,
explicit in the changlog.
Yeah, I guessed it was probably something like that. But this seems
like a bad solution since anybody who has /usr separate probably does
want dhclient during bootup. In particular, if you have /usr on NFS
then you might be hosed if dhclient is in /usr/bin.
It seems like the right way to fix this is one of:
a) move libcrypto to ${base_libdir}, or
b) stop dhclient from linking against libcrypto, or
c) make it link against the static rather than shared library
Do we know why dhclient has grown this dependency on libcrypto in the
first place? Or, as an alternative data point, is there a particular
reason why this upgrade is required (i.e. could we just stick with the
old version)?
But, the main point I was trying to make was that the checkin message
did not adequately describe what the patch was doing. I think the
quality of patches that are being applied to oe-core is, for the most
part, pretty good nowadays but there still do seem to be quite a few
with poor/inaccurate checkin messages and this is an area where it seems
like it should be possible to do better with relatively little effort.
For example, looking at the git log for the last week, there are at
least 3 commits which don't have the recipe name at the start of the
subject line. Although this sounds like a trivial thing it is actually
quite annoying if you're trying to scan the git logs to see what changes
have been applied to a recipe or set of recipes. Similarly, if the
commit message can't be relied upon to accurately describe what has been
changed, you end up having to read all the diffs for every change which
is quite a tedious business.
p.
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On 02/08/2012 07:00 PM, Phil Blundell wrote:
On Wed, 2012-02-08 at 14:30 -0200, Otavio Salvador wrote:
On Wed, Feb 8, 2012 at 14:10, Phil Blundellph...@gnu.org wrote:
This isn't just a straightforward update, you seem to be
moving dhclient
from ${base_sbindir} to ${sbindir}. If that's a good thing
(which
doesn't seem totally obvious to me) then it ought at least to
be
mentioned in the commit message.
He is doing that because it links against libcrypt that is at
${libdir}. But it clearly needs to be in another commit or, at least,
explicit in the changlog.
Yeah, I guessed it was probably something like that. But this seems
like a bad solution since anybody who has /usr separate probably does
want dhclient during bootup. In particular, if you have /usr on NFS
then you might be hosed if dhclient is in /usr/bin.
It seems like the right way to fix this is one of:
a) move libcrypto to ${base_libdir}, or
b) stop dhclient from linking against libcrypto, or
c) make it link against the static rather than shared library
Do we know why dhclient has grown this dependency on libcrypto in the
first place? Or, as an alternative data point, is there a particular
reason why this upgrade is required (i.e. could we just stick with the
old version)?
There is no grown dependency on libcrypto in this version. It used to
be in last version we had as well but as this is a warning, i guess it
was ignored as other QA warning are present in a core-image-minimal
build for example.
Here is the log from a build where it used to be dhcp 4.2.0 (last
version in yocto):
dhcp-4.2.0: dhcp: {build
path}/tmp/work/armv7a-vfp-neon-poky-linux-gnueabi/dhcp-4.2.0-r5/packages-split/dhcp-client/sbin/dhclient
links to something under exec_prefix
dhcp-4.2.0: ldd reports: -libcrypto.so.1.0.0 = {build
path}/tmp/sysroots/vexpressa9/usr/lib/libcrypto.so.1.0.0 (0xdead1000)
So this is not a new thing. In 4.2.3 this library check and linkage is
removed - from 4.2.1 rel notes:
- ./configure on longer searches for -lcrypto to explicitly link against.
This fixes a bug where 'dhclient' would have shared library dependencies
on '/usr/lib'. [ISC-Bugs #21967]
While integrating the new version of dhcp, the compile stage used to fail:
|
/home/agherzan/work/wrs/yocto-adige/2012-02-08-12-18-imx53/tmp-eglibc-eglibc/sysroots/imx53qsb/usr/lib//libdns.a(openssldh_link.o):
In function `openssldh_fromdns':
|
/home/agherzan/work/wrs/yocto-adige/2012-02-08-12-18-imx53/tmp-eglibc-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/bind-9.8.1-r2/bind-9.8.1/lib/export/dns/../../../lib/dns/openssldh_link.c:344:
undefined reference to `DH_new'
|
/home/agherzan/work/wrs/yocto-adige/2012-02-08-12-18-imx53/tmp-eglibc-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/bind-9.8.1-r2/bind-9.8.1/lib/export/dns/../../../lib/dns/openssldh_link.c:387:
undefined reference to `BN_bin2bn'
|
/home/agherzan/work/wrs/yocto-adige/2012-02-08-12-18-imx53/tmp-eglibc-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/bind-9.8.1-r2/bind-9.8.1/lib/export/dns/../../../lib/dns/openssldh_link.c:435:
undefined reference to `DH_free'
|
/home/agherzan/work/wrs/yocto-adige/2012-02-08-12-18-imx53/tmp-eglibc-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/bind-9.8.1-r2/bind-9.8.1/lib/export/dns/../../../lib/dns/openssldh_link.c:425:
undefined reference to `BN_bin2bn'
|
/home/agherzan/work/wrs/yocto-adige/2012-02-08-12-18-imx53/tmp-eglibc-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/bind-9.8.1-r2/bind-9.8.1/lib/export/dns/../../../lib/dns/openssldh_link.c:430:
undefined reference to `DH_free'
|
/home/agherzan/work/wrs/yocto-adige/2012-02-08-12-18-imx53/tmp-eglibc-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/bind-9.8.1-r2/bind-9.8.1/lib/export/dns/../../../lib/dns/openssldh_link.c:409:
undefined reference to `BN_bin2bn'
|
/home/agherzan/work/wrs/yocto-adige/2012-02-08-12-18-imx53/tmp-eglibc-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/bind-9.8.1-r2/bind-9.8.1/lib/export/dns/../../../lib/dns/openssldh_link.c:410:
undefined reference to `BN_cmp'
|
/home/agherzan/work/wrs/yocto-adige/2012-02-08-12-18-imx53/tmp-eglibc-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/bind-9.8.1-r2/bind-9.8.1/lib/export/dns/../../../lib/dns/openssldh_link.c:411:
undefined reference to `BN_free'
|
/home/agherzan/work/wrs/yocto-adige/2012-02-08-12-18-imx53/tmp-eglibc-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/bind-9.8.1-r2/bind-9.8.1/lib/export/dns/../../../lib/dns/openssldh_link.c:438:
undefined reference to `BN_bin2bn'
|
/home/agherzan/work/wrs/yocto-adige/2012-02-08-12-18-imx53/tmp-eglibc-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/bind-9.8.1-r2/bind-9.8.1/lib/export/dns/../../../lib/dns/openssldh_link.c:441:
undefined reference to `BN_num_bits'
so i had to add this -lcrypto check back in configure.
At that point i didn't
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On Wed, Feb 8, 2012 at 16:40, Andrei Gherzan and...@gherzan.ro wrote: ... In my opinion we ought to merge your patch without handling crypto issue right now while we set in one way of fixing it. It seems to me that the fix is to move libcrypto to base_libdir and don't touch dhcp for this. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On 02/08/2012 08:46 PM, Otavio Salvador wrote: On Wed, Feb 8, 2012 at 16:40, Andrei Gherzan and...@gherzan.ro mailto:and...@gherzan.ro wrote: ... In my opinion we ought to merge your patch without handling crypto issue right now while we set in one way of fixing it. It seems to me that the fix is to move libcrypto to base_libdir and don't touch dhcp for this. I don't know why my conclusion line from the last email was erased but this was my solution as well. I mean a quick and functional one. @g ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On 02/08/2012 08:46 PM, Otavio Salvador wrote: On Wed, Feb 8, 2012 at 16:40, Andrei Gherzan and...@gherzan.ro mailto:and...@gherzan.ro wrote: ... In my opinion we ought to merge your patch without handling crypto issue right now while we set in one way of fixing it. It seems to me that the fix is to move libcrypto to base_libdir and don't touch dhcp for this. Should we move the whole openssl package to prefix=/ ? Or just the libcrypto library? @g ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On Wed, Feb 8, 2012 at 2:20 PM, Andrei Gherzan and...@gherzan.ro wrote: Should we move the whole openssl package to prefix=/ ? Or just the libcrypto library? if libcrypto is emitted as a separate package then it would be easier that you just relocate it but if its bundled in a package that contains more stuff then you might have to bean it out and also make sure that all the dependencies that libcrypto requires at runtime are also then moved into /lib ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On 02/02/2012 08:20 AM, Andrei Gherzan wrote: From: Andrei Gherzanandrei.gher...@windriver.com 1. Update to 4.2.3-P2 2. From 4.2.0 final release, -lcrypto check was removed and we compile static libraries from bind that are linked to libcrypto. This is why i added a patch in order to add -lcrypto to LIBS. --- .../dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch | 86 .../dhcp/dhcp-4.2.0/fix-client-path.patch | 23 - .../dhcp/dhcp-4.2.0/fix-external-bind.patch| 103 .../dhcp/dhcp-4.2.0/fixincludes.patch | 12 --- .../dhcp/dhcp-4.2.0/noattrmode.patch | 21 meta/recipes-connectivity/dhcp/dhcp-4.2.0/site.h | 21 .../dhcp-4.2.3-P2/dhcp-3.0.3-dhclient-dbus.patch | 86 .../dhcp/dhcp-4.2.3-P2/fix-external-bind.patch | 103 .../dhcp/dhcp-4.2.3-P2/fixincludes.patch | 12 +++ .../dhcp/dhcp-4.2.3-P2/link-with-lcrypto.patch | 15 +++ .../dhcp/dhcp-4.2.3-P2/noattrmode.patch| 21 +++ Your patches are missing Signed-off-by: and in one case the link-with-lcrypto.patch is missing a Upstream-Status: Please resubmit Thanks Sau! .../recipes-connectivity/dhcp/dhcp-4.2.3-P2/site.h | 21 meta/recipes-connectivity/dhcp/dhcp.inc|2 +- meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb | 12 --- meta/recipes-connectivity/dhcp/dhcp_4.2.3-P2.bb| 12 +++ 15 files changed, 271 insertions(+), 279 deletions(-) delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fix-client-path.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fix-external-bind.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fixincludes.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/noattrmode.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/site.h create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/dhcp-3.0.3-dhclient-dbus.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fix-external-bind.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fixincludes.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/link-with-lcrypto.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/noattrmode.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/site.h delete mode 100644 meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb create mode 100644 meta/recipes-connectivity/dhcp/dhcp_4.2.3-P2.bb diff --git a/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch b/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch deleted file mode 100644 index b4a666d..000 --- a/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch +++ /dev/null @@ -1,86 +0,0 @@ -Upstream-Status: Inappropriate [distribution] - client/scripts/bsdos -+++ client/scripts/bsdos -@@ -47,6 +47,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/freebsd -+++ client/scripts/freebsd -@@ -57,6 +57,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/linux -+++ client/scripts/linux -@@ -69,6 +69,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/netbsd -+++ client/scripts/netbsd -@@ -47,6 +47,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } -
[OE-core] [PATCH] dhcp: Update to 4.2.3-P2
1. Update to 4.2.3-P2 2. From 4.2.0 final release, -lcrypto check was removed and we compile static libraries from bind that are linked to libcrypto. This is why i added a patch in order to add -lcrypto to LIBS. Signed-off-by: Andrei Gherzan and...@gherzan.ro --- .../dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch | 86 .../dhcp/dhcp-4.2.0/fix-client-path.patch | 23 - .../dhcp/dhcp-4.2.0/fix-external-bind.patch| 103 .../dhcp/dhcp-4.2.0/fixincludes.patch | 12 --- .../dhcp/dhcp-4.2.0/noattrmode.patch | 21 meta/recipes-connectivity/dhcp/dhcp-4.2.0/site.h | 21 .../dhcp-4.2.3-P2/dhcp-3.0.3-dhclient-dbus.patch | 86 .../dhcp/dhcp-4.2.3-P2/fix-client-path.patch | 23 + .../dhcp/dhcp-4.2.3-P2/fix-external-bind.patch | 103 .../dhcp/dhcp-4.2.3-P2/fixincludes.patch | 12 +++ .../dhcp/dhcp-4.2.3-P2/link-with-lcrypto.patch | 29 ++ .../dhcp/dhcp-4.2.3-P2/noattrmode.patch| 21 .../recipes-connectivity/dhcp/dhcp-4.2.3-P2/site.h | 21 meta/recipes-connectivity/dhcp/dhcp.inc|8 +- meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb | 12 --- meta/recipes-connectivity/dhcp/dhcp_4.2.3-P2.bb| 12 +++ 16 files changed, 310 insertions(+), 283 deletions(-) delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fix-client-path.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fix-external-bind.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fixincludes.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/noattrmode.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/site.h create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/dhcp-3.0.3-dhclient-dbus.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fix-client-path.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fix-external-bind.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fixincludes.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/link-with-lcrypto.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/noattrmode.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/site.h delete mode 100644 meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb create mode 100644 meta/recipes-connectivity/dhcp/dhcp_4.2.3-P2.bb diff --git a/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch b/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch deleted file mode 100644 index b4a666d..000 --- a/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch +++ /dev/null @@ -1,86 +0,0 @@ -Upstream-Status: Inappropriate [distribution] - client/scripts/bsdos -+++ client/scripts/bsdos -@@ -47,6 +47,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/freebsd -+++ client/scripts/freebsd -@@ -57,6 +57,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/linux -+++ client/scripts/linux -@@ -69,6 +69,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/netbsd -+++ client/scripts/netbsd -@@ -47,6 +47,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/openbsd -+++ client/scripts/openbsd -@@ -47,6 +47,11 @@ - .
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On Thu, Feb 2, 2012 at 20:07, Andrei Gherzan and...@gherzan.ro wrote: I couldn't find your commit on dhcp in that repo. Here is my new commit with signed-off message: https://github.com/agherzan/yocto-dev/commit/4fa2e86cc242bca3064c92ce6759dab0bca4eb5c https://github.com/OSSystems/oe-core/commit/3c3316854cd788f694f12f2721e7dba64105f375 -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH] dhcp: Update to 4.2.3-P2
From: Andrei Gherzan andrei.gher...@windriver.com 1. Update to 4.2.3-P2 2. From 4.2.0 final release, -lcrypto check was removed and we compile static libraries from bind that are linked to libcrypto. This is why i added a patch in order to add -lcrypto to LIBS. --- .../dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch | 86 .../dhcp/dhcp-4.2.0/fix-client-path.patch | 23 - .../dhcp/dhcp-4.2.0/fix-external-bind.patch| 103 .../dhcp/dhcp-4.2.0/fixincludes.patch | 12 --- .../dhcp/dhcp-4.2.0/noattrmode.patch | 21 meta/recipes-connectivity/dhcp/dhcp-4.2.0/site.h | 21 .../dhcp-4.2.3-P2/dhcp-3.0.3-dhclient-dbus.patch | 86 .../dhcp/dhcp-4.2.3-P2/fix-external-bind.patch | 103 .../dhcp/dhcp-4.2.3-P2/fixincludes.patch | 12 +++ .../dhcp/dhcp-4.2.3-P2/link-with-lcrypto.patch | 15 +++ .../dhcp/dhcp-4.2.3-P2/noattrmode.patch| 21 .../recipes-connectivity/dhcp/dhcp-4.2.3-P2/site.h | 21 meta/recipes-connectivity/dhcp/dhcp.inc|2 +- meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb | 12 --- meta/recipes-connectivity/dhcp/dhcp_4.2.3-P2.bb| 12 +++ 15 files changed, 271 insertions(+), 279 deletions(-) delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fix-client-path.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fix-external-bind.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/fixincludes.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/noattrmode.patch delete mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.0/site.h create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/dhcp-3.0.3-dhclient-dbus.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fix-external-bind.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/fixincludes.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/link-with-lcrypto.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/noattrmode.patch create mode 100644 meta/recipes-connectivity/dhcp/dhcp-4.2.3-P2/site.h delete mode 100644 meta/recipes-connectivity/dhcp/dhcp_4.2.0.bb create mode 100644 meta/recipes-connectivity/dhcp/dhcp_4.2.3-P2.bb diff --git a/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch b/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch deleted file mode 100644 index b4a666d..000 --- a/meta/recipes-connectivity/dhcp/dhcp-4.2.0/dhcp-3.0.3-dhclient-dbus.patch +++ /dev/null @@ -1,86 +0,0 @@ -Upstream-Status: Inappropriate [distribution] - client/scripts/bsdos -+++ client/scripts/bsdos -@@ -47,6 +47,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/freebsd -+++ client/scripts/freebsd -@@ -57,6 +57,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/linux -+++ client/scripts/linux -@@ -69,6 +69,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/netbsd -+++ client/scripts/netbsd -@@ -47,6 +47,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+dbus-send --system --dest=com.redhat.dhcp \ -+ --type=method_call /com/redhat/dhcp/$interface com.redhat.dhcp.set \ -+ 'string:'`env | grep -Ev '^(PATH|SHLVL|_|PWD|dhc_dbus)\='` -+ fi - exit $exit_status - } - client/scripts/openbsd -+++ client/scripts/openbsd -@@ -47,6 +47,11 @@ - . /etc/dhcp/dhclient-exit-hooks - fi - # probably should do something with exit status of the local script -+ if [ x$dhc_dbus != x -a $exit_status -eq 0 ]; then -+
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On Thu, Feb 2, 2012 at 14:20, Andrei Gherzan and...@gherzan.ro wrote: From: Andrei Gherzan andrei.gher...@windriver.com 1. Update to 4.2.3-P2 2. From 4.2.0 final release, -lcrypto check was removed and we compile static libraries from bind that are linked to libcrypto. This is why i added a patch in order to add -lcrypto to LIBS. The patch I sent yestarday will cause a conflict in this one. You might want to rebase it against my tree at: https://github.com/OSSystems/oe-core If you want, you can cherry-pick mine and send it together with your one so we avoid a conflict for Richard or Saul to deal with. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] dhcp: Update to 4.2.3-P2
On 02/02/2012 08:32 PM, Otavio Salvador wrote: On Thu, Feb 2, 2012 at 14:20, Andrei Gherzan and...@gherzan.ro mailto:and...@gherzan.ro wrote: From: Andrei Gherzan andrei.gher...@windriver.com mailto:andrei.gher...@windriver.com 1. Update to 4.2.3-P2 2. From 4.2.0 final release, -lcrypto check was removed and we compile static libraries from bind that are linked to libcrypto. This is why i added a patch in order to add -lcrypto to LIBS. The patch I sent yestarday will cause a conflict in this one. You might want to rebase it against my tree at: https://github.com/OSSystems/oe-core If you want, you can cherry-pick mine and send it together with your one so we avoid a conflict for Richard or Saul to deal with. I couldn't find your commit on dhcp in that repo. Here is my new commit with signed-off message: https://github.com/agherzan/yocto-dev/commit/4fa2e86cc242bca3064c92ce6759dab0bca4eb5c @g ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
